[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 27 11:01:13 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This is tight to bug 28870. I think we should push both altogether.

However there is one thing that seems wrong to me:

+    my $email = try {
+        Koha::Email->create(
[SKIP]
+    }
+    catch {
+        _set_message_status(
+            {
+                message_id   => $message->{'message_id'},
+                status       => 'failed',
+                failure_code => 'INVALID_EMAIL'
+            }
+        );
+        return 0;
+    };

Koha::Email->create is raising different exception, and Email::Stuffer
certainly raised its own.

Shouldn't we actually base this on top of bug 28870 and simply call (the newly
added) Koha::Email->is_valid to check if the email if valid?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list