[Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 27 15:14:15 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I get it, but consistency will always be a good thing!

Right now we need:

$template->param(
    outstanding_debits => scalar $patron->account->outstanding_debits,
    items              => $biblio->items,
);

Because we are not consistent (i.e. outstanding_debits does a return
$smth->search)

I'd prefer

$template->param(
    outstanding_debits => scalar $patron->account->outstanding_debits,
    items              => scalar $biblio->items,
);

The motivation for this bug was to find consensus on a predictable way of
coding to lower amount of bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list