[Koha-bugs] [Bug 28744] Class with empty/no to_api_mapping should generate an empty from_api_mapping

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28744

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124163|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 124189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124189&action=edit
Bug 28744: Better handling of undefined to_api_mapping

We always had some mapping because of the DB vs. API object definition
discrepancies. But bug 25260 revamps the reserves table, and it is a perfect
match. It highlights this edge case: if no mapping defined, then and undef
from_api_mapping is generated (as opposed to an empty hashref) and this leads
to errors in the query translation from the API.

This patch makes a small change so this method always returns an empty
hashref.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Test fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

JD amended patch: remove uneeded commented lines

-- 
You are receiving this mail because:
You are watching all bug changes.