[Koha-bugs] [Bug 28930] New: Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930

            Bug ID: 28930
           Summary: Cardnumber is lost if an invalid self registration
                    form is submited to the server, and the server side
                    form validation fails.
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: andreas.jonsson at kreablo.se
        QA Contact: testopia at bugs.koha-community.org

Cardnumber is lost if an invalid self registration form is submited to the
server, and the server side form validation fails.

I believe the idea is that the cardnumber should not be editable when
requesting modifications to the borrower's details in the OPAC.  But it would
still make sense to keep the cardnumber field editable when correcting invalid
form fields during self registration (also, see bug 17213).

So, a simple fix is to let the cardnumber be editable if action != 'edit'.

Test case

* Enable the system preference PatronSelfRegistration 
* Make sure  PatronSelfRegistrationBorrowerUnwantedField does not contain
cardnumber.
* Set the system preference  GDPR_Policy to "Enforce".
* In the OPAC click "Log in to your account" and "Register here".
* Fill out the form with valid data, but make sure you leave the checkbox under
"GDPR consent" unchecked.
* Submit the form
* You will get back the form with the error message "You have not filled out
all required fields. Please fill in all missing fields and resubmit."
* Without patch: cardnumber is not editable, and there is no input element for
borrower_cardnumber (so the cardnumber will be lost when resubmitting the form)
* With patch: cardnumber is editable.

-- 
You are receiving this mail because:
You are watching all bug changes.