[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Agustín Moyano from comment #8)

Thx for your prompt response.

> > [3] There is no longer a possibility to add a custom reason for cancelling
> > (as we had). The default reasons should be additional, not excluding free
> > text.
> 
> Ok, I'll try to restore the way it was... what happens if patron selects a
> reason, and then adds a custom text?.. which one wins?

Free text wins from a default text. But you could control that. Disable free
text unless they click an option 'Custom reason' or so?

> > [5] Why do you add cancel_article_request to Koha/REST/V1/Patrons.pm ? Apart
> > from checking existence of the patron id, what is its use ?
> 
> As I was making API endpoints for cancelling article requests from staff
> interface (we should move away from svc in any chance we've got), I thought
> it would be good to add the same for opac.. the endpoint that opac uses is
> DELETE /api/v1/public/patrons/{patron_id}/article_requests/{ar_id}, so It
> seemed natural to place it in Koha/REST/V1/Patrons.pm 

I dont really mind. Maybe ask Tomas? But it seemed more logical (or consistent)
to me that deleting an article request from OPAC or staff have similar end
points.

-- 
You are receiving this mail because:
You are watching all bug changes.