From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 00:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Nov 2021 23:18:08 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 00:18:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Nov 2021 23:18:12 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 128113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128113&action=edit Bug 29605: Add missing constraints from bug 15067 This patch fixes a missed update to kohastructure.sql. To test: 1. Checkout prior to bug 15067 (ab270c026be06f08745a14d1aea992877d20f812) would work. 2. Run: $ reset_all 3. Checkout v21.11.00 4. Run: $ updatedatabase $ koha-mysql kohadev > SHOW CREATE TABLE language_subtag_registry; => SUCCESS: There's UNIQUE KEY uniq_lang (subtag, type) 5. Run: > SHOW CREATE TABLE language_descriptions; => SUCCESS: There's UNIQUE KEY uniq_desc (subtag, type, lang) 6. Run: > SHOW CREATE TABLE language_rfc4646_to_iso639; => SUCCESS: There's UNIQUE KEY uniq_code (rfc4646_subtag, iso639_2_code) 7. Replicate a fresh install. Run: $ reset_all 8. Repeat 4, 5 and 6 => FAIL: The UNIQUE constraints are not there! 9. Apply this patch 10. Run: $ reset_all 11. Repeat 8 => SUCCESS: The UNIQUE constraints are there! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 00:18:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Nov 2021 23:18:17 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 128114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128114&action=edit Bug 29605: (follow-up) Add language_script_mapping primary key Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 00:32:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Nov 2021 23:32:47 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.07,20.11.12 |21.11.00,21.05.07,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 01:18:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 00:18:32 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from David Cook --- Thanks, Martin. I really appreciate your comments. Since I authored Bug 26048, it probably does make sense for me to make more of an effort here... I found something interesting with the status quo: http://localhost:8081/files/blah This returns a 404 page with a 200 status. That's bad! http://localhost:8081/cgi-bin/koha/circ/blahblah This returns a 404 page with a 404 status. That's good but a bit confusing! (NOTE: If you do change 404.pl to return a 404 status instead of a 200 status, it does cause a regression, so that this page now returns a blank page that just says "not found".) If we look at /etc/koha/apache-shared-intranet-plack.conf, only /index.html and path /cgi-bin/koha are proxied to Starman. So it makes sense that they're the only ones invoking the middleware. But if http://localhost:8081/blahblah is using Apache and not Starman, it shouldn't be setting the environmental variables that cause 404.pl to return a 200 status instead of a 404 status... Except that Apache's error documents themselves end up calling Starman! ErrorDocument 400 /cgi-bin/koha/errors/400.pl ErrorDocument 401 /cgi-bin/koha/errors/401.pl ErrorDocument 403 /cgi-bin/koha/errors/403.pl ErrorDocument 404 /cgi-bin/koha/errors/404.pl ErrorDocument 500 /cgi-bin/koha/errors/500.pl So of course the error pages called by Apache will return a 200 page whereas the ones using the ErrorDocument middleware return the actual error code. (Let me know if I'm not being clear enough here.) -- So that's... challenging. We need a way of differentiating if these error scripts are being called directly (e.g. Apache asking Starman for it) or by the ErrorDocument middleware... One way of doing that might be to inspect the REQUEST_URI environmental variable. When coming from ErrorDocument, the REQUEST_URI is "errors/404.pl". When coming from Apache, it's "/intranet/errors/404.pl". It doesn't seem like a super robust method, but it's the best I have at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 01:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 00:23:28 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #13 from David Cook --- Side note: In /etc/koha/sites/kohadev/plack.psgi I should've put '/errors/404.pl' instead of 'errors/404.pl' but it seems to work anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 01:35:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 00:35:50 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #14 from David Cook --- An easier to maintain option would be to not proxy "/cgi-bin/koha/errors/*" files to Starman, but... that would probably be short-sighted, since there are times where we redirect manually to 404.pl as well. For instance: members/apikeys.pl: print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early So that's not that long-term of a solution... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:06:18 +0000 Subject: [Koha-bugs] [Bug 29420] 401 Unauthorized pages come back as 200 OK under plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #15 from David Cook --- The ErrorDocument middleware does set up environmental variables prefixed with "psgix.errordocument" but CGI::Emulate::PSGI strips those out... https://metacpan.org/dist/CGI-Emulate-PSGI/source/lib/CGI/Emulate/PSGI.pm#L53 So that's annoying. It's too bad we don't have a Plack-enabled controller for handling these so we didn't have to emulate the PSGI for CGI scripts, but that's easier said than done. (I don't have the time/energy for refactoring C4/Templates.pm and C4/Auth.pm to make things like Bug 26791 or Bug 28325 possible ;).) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:25:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:25:42 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|401 Unauthorized pages come |HTTP status code incorrect |back as 200 OK under plack |when calling error pages | |directly under Plack/PSGI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:34:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:34:21 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|liz at bywatersolutions.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:34:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:34:49 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:34:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:34:53 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127364|0 |1 is obsolete| | --- Comment #16 from David Cook --- Created attachment 128115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128115&action=edit Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI The error pages wrote a HTTP status code of 200 for all PSGI requests, even though it should have only done it for PSGI requests from the ErrorDocument middleware. This patch fixes that. 0) Do not apply patch 1) Open F12 dev tools and go to Network tab 2) Go to http://localhost:8081/files/blah 3) Note that the webpage is a 404 error but HTTP status code is 200 4) Go to http://localhost:8081/cgi-bin/koha/circ/blah 5) Note that the webpage is a 404 error and HTTP status code is 404 6) Apply patch 7) Go to http://localhost:8081/files/blah 8) Note that the webpage is a 404 error and HTTP status code is 404 9) Go to http://localhost:8081/cgi-bin/koha/circ/blah 10) Note that the webpage is a 404 error and HTTP status code is 404 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:35:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:35:35 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #17 from David Cook --- For Liz's use case: To test: - mkdir /var/lib/koha/kohadev/public_html - create an alias in your /etc/apache2/sites-enabled/kohadev.conf file for something like files Alias /files "/var/lib/koha/kohadev/public_html/" Options +Indexes AuthUserFile /var/lib/koha/kohadev/.htpasswd AuthName ByPassword AuthType Basic require valid-user - make a .htpasswd file: https://hostingcanada.org/htpasswd-generator/ and put it in /var/lib/koha/kohadev - service apache2 reload - navigate to http://localhost:8080/files/, note that the response header in the browser inspector says "200 OK" and the basic auth user/pass is not shown - Apply this patch, restart the things - navigate to http://localhost:8080/files/, note that the response header in the browser inspector says "401 Unauthorized" and the basic auth user/pass is now shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 02:37:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 01:37:29 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #18 from David Cook --- I don't love the solution in my patch as it seems a bit fragile, but it seems to work in koha-testing-docker and I think it might be the best we can do for now. I think the only other viable alternative right now would be not proxying the ErrorDocument pages from Apache to Starman, which would also be suboptimal. But open to other solutions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:01:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:01:07 +0000 Subject: [Koha-bugs] [Bug 16994] Import and export MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #5 from AspenCat Team --- I like to test our marc modification template in sandbox. If successful and complicated it would be nice to be able to move to production without manually copying each line. I would also like to see a library that we could borrow modification templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:04:05 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:05:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:05:45 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #2 from AspenCat Team --- I would also like to see substitution work in marc modification templates - or really anywhere we can use regex (such as batch item modification). This would really power-up the regex capabilities. Agree with Andrew that it would be hugely useful not just for date modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:15:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:15:29 +0000 Subject: [Koha-bugs] [Bug 29020] Missing Background jobs link in admin-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29020 --- Comment #24 from David Cook --- (This is an aside not directly related to Koha, but I was thinking about this a little bit the other day, while working with Discourse. It uses Sidekiq (https://en.wikipedia.org/wiki/Sidekiq) for running it's background tasks. A top level administrator can just go to http:///sidekiq to see everything related to background tasks. As far as I can tell, there's no link to sidekiq from Discourse, but it is handy for the administrators to be able to trigger and review jobs from there.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:26:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:26:48 +0000 Subject: [Koha-bugs] [Bug 29587] Test mail option in SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimalibre at gmail.com Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:36:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:36:16 +0000 Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #77 from David Cook --- (In reply to Marcel de Rooy from comment #76) > See also bug 24988. But if a patron has no autorenewal, he should not even > have this choice. It would be useless and confusing. It could be confusing for patrons to view and update an autorenewal setting if no autorenewals are allowed, but I'm not sure that there is a simple reasonable alternative. On one hand, you could calculate the circulation rules to determine if a patron is allowed to have autorenewals. On the other hand, that wouldn't take into account their existing autorenewal checkouts *plus* it's possible to set autorenewals at checkout time. So determining if an item is autorenewable and whether a patron allows autorenewals seems to me like 2 completely separate things in the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:47:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:47:29 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #10 from David Cook --- (In reply to Marcel de Rooy from comment #8) > I do not really understand why autorenewal should default to Yes. I suspect most people would be in favour of autorenewal (I know I am as a library patron - very handy functionality), and it's more likely there would be a minority of people wanting to refuse it. Hence default to yes. > Suppose that you have set Autorenewal off for all your circ rules. And now > you see allow auto-renewal popping up everywhere.. > This is quite confusing. > Imo we need more checks than just default to Yes. As I noted on bug 24476, I don't think it's quite that simple. Even if all the autorenewals are turned off in the circ rules, you might have current checkouts that are still marked as autorenewal (which I think still get processed as autorenewals although I should double-check that), and you can choose to make an item an "Automatic renewal" by going into "Checkout settings" when checking out an item. I do agree though that it's complicated. On the surface, it seems silly to allow a patron to control an autorenewal setting if the library doesn't actually use autorenewals, but I think they're conceptually two different things. One is marking an item as an autorenewal, and the other is the patron allowing items to be autorenewed. (Of course, I wonder why a patron should be able to turn off autorenewal, but I don't really like how autorenewal has been implemented overall and how it prevents manual renewals. But that's another matter...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 04:59:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 03:59:16 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #11 from David Cook --- (In reply to Marcel de Rooy from comment #8) > Who opens a bug report like 'auto_renewal should not default to Yes' ? Does this seem like a productive question? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 07:01:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 06:01:58 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 07:02:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 06:02:08 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128103|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128116&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 07:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 06:06:04 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #20 from David Cook --- I'm looking into null branchcodes being used for reserves (and breaking the Reserves display in Circ), and I think that it's being caused by multiholds, since their default value for "Pickup location" is blank. I'm thinking that the solution is probably to remove the empty options... I am working on an instance with customized hold functionality, so it is possible that the customizations are preventing some error handling that is in master, but exploring currently... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 07:08:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 06:08:56 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #21 from David Cook --- Oh and it looks possible to nix the pickup location manually anyway... I'll have to test this on master... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 07:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 06:30:09 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Needs a rebase on current master since Bug 27173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 08:42:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 07:42:45 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119935|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 128117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128117&action=edit Bug 28186: Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority This patch replaces the use of $dbh->do by corresponding use of Koha::Authority object Test plan: 1. Verify that creating/modifying authority still work 2. prove t/db_dependent/AuthoritiesMarc.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 08:45:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 07:45:43 +0000 Subject: [Koha-bugs] [Bug 28186] Use Koha::Authority in C4::AuthoritiesMarc::AddAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28186 --- Comment #4 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 09:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 08:01:55 +0000 Subject: [Koha-bugs] [Bug 29606] New: Include items from host record in XML for XSLT processing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Bug ID: 29606 Summary: Include items from host record in XML for XSLT processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 09:02:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 08:02:27 +0000 Subject: [Koha-bugs] [Bug 29606] Include items from host record in XML for XSLT processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 --- Comment #1 from Julian Maurice --- Created attachment 128118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128118&action=edit Bug 29606: Include items from host record in XML for XSLT processing If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. Test plan: 0. Do not apply the patch yet 1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay to 'default' 2. Create a biblio record with title "parent" and create an item with a barcode for this biblio 3. Create a biblio record with title "child" with no items. On the biblio detail page, in the toolbar, click "Edit -> Link to host record" and enter the barcode for the item you created at step 2 4. Duplicate this biblio record, to be sure you will have at least two results with the search "child" (and not be redirected to the detail page) 5. Make sure your search index (zebra or elasticsearch) is up to date 6. Go to OPAC and search "child". You should see two results, no items. Click on one of them. On the detail page you should see one item (the one from the host record) 7. Apply the patch 8. Go to OPAC and search "child". You should now see one item (the same item) for each result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 09:02:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 08:02:38 +0000 Subject: [Koha-bugs] [Bug 29606] Include items from host record in XML for XSLT processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:02:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:02:54 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #7 from Jonathan Druart --- (In reply to Owen Leonard from comment #6) > What about Bug 26392? It's stuck, its author does not reply, and IIRC there were perf issues (I cannot find the numbers however). Here I am suggesting to not modify the current system, only focus on problematic strings (those with several %s, ie. TT tags). But you are right, it's certainly stupid to do the work twice. But doing it instead of nothing felt better, yesterday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:18:28 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:22:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:22:07 +0000 Subject: [Koha-bugs] [Bug 29607] New: addorderiso2709: The stored discount when importing an order from a file is invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Bug ID: 29607 Summary: addorderiso2709: The stored discount when importing an order from a file is invalid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.torin at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org In the Acquisitions module : - Create a new vendor with a discount (Or select one that has a discount). Here the discount will be 25% - Create a new basket or select an existing one - Select "Add to basket" => From a staged file - Add an order from one of the file ==> Here, you can use a specific discount for the order, to override the vendor discount. The result should be quite the same if you do, but with this discount - The order is created ==> Modify the order - The discount is 0.25% instead of 25% Note that the prices are initially correctly calculated, but the discount value will appear as false. Plus, if you modify the order and change a price, the wrong discount will be used. In database, the discount is indeed stored as a value between 0 and 1, but only in that case (for the vendor, it is the actual percentage, and when you create an order from anoher source, it is stored correctly) This was reported on Koha 20.11, but is still relevant on master. In the code, this happens because the discount value is first divided by 100 to calculate the price, but it is that divided value that is stored in database, instead of the whole percentage value. On the master branch, in the file Koha/acqui/addorderiso2709.pl, the line where it's done are lines 166, 279 and 340 What I would suggest is : - Remove the division per 100 on those lines (166, 279 and 340) - Divide per 100 only when calculating the price (lines 283, 285, 344, 346) ==> ( 1 - $c/100 ) instead of ( 1 - $c ) - In the template (for importing from file), add a "%" just to be clear that the discount is a percentage, and not a value between 0 and 1 I know there was a kind of security (divide by 100 if the input is > 1), but it could be the other way around (multiply by 100 if the input is < 1). But as it is based on the field that is in the form, with a simple "%" indication it should not be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:25:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:25:36 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:25:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:25:43 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128069|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 128119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128119&action=edit Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:25:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:25:47 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 --- Comment #7 from Jonathan Druart --- Created attachment 128120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128120&action=edit Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:33:46 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- (In reply to Jonathan Druart from comment #7) > (In reply to Owen Leonard from comment #6) > > What about Bug 26392? > > It's stuck, its author does not reply, and IIRC there were perf issues (I > cannot find the numbers however). Here I am suggesting to not modify the > current system, only focus on problematic strings (those with several %s, > ie. TT tags). I think it's stuck because no decision was made to follow this path (and it's probably not a good approach to translate all strings in a template at once). But the system works, and is already used in some places. About the performance concerns, yes, it affects performances but IMO it's negligible compared to the benefits (plural forms, context, named placeholders instead of %s, and more if we handle all translatable strings with it). See https://gitlab.com/jajm/time-i18n (it's not perfect, so take it with a grain of salt - we should probably test with a real world example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 10:47:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 09:47:03 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_05_candidate --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > I would push at least the fix only ? Sorry, I haven't answered here. I was not confident to push this the same day of the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:08:58 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #55 from Jonathan Druart --- I am getting an error: Template process failed: file error - recursion into 'i18n.inc' at /kohadevbox/koha/C4/Templates.pm line 121 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:09:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:09:43 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind --- For whatever reason I couldn't get "Tomorrow" to translate. I tried it with fr-FR and de-DE - there was a translation for that already available, but it didn't change anything in the staff interface. (All the other ones worked as expected.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:10:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:10:32 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #56 from Jonathan Druart --- (In reply to Jonathan Druart from comment #55) > I am getting an error: > Template process failed: file error - recursion into 'i18n.inc' at > /kohadevbox/koha/C4/Templates.pm line 121 ok, fixed. bin/koha-i18n ~/path/to/koha/**/*.tt ~/path/to/koha/**/*.inc then remove the changes generated to i18n.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:16:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:16:36 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #57 from Jonathan Druart --- 1. Item search is broken, invalid JSON. 2. /members/members-home.pl Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt line 153: unexpected token (") [% " s_o | html %] at /kohadevbox/koha/C4/Templates.pm line 121 3. /members/moremember.pl?borrowernumber=51 Template process failed: file error - parse error - patron-title.inc line 38: unexpected end of directive [% t('\' %] at /kohadevbox/koha/C4/Templates.pm line 121 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:20:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:20:30 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 --- Comment #9 from Jonathan Druart --- (In reply to David Nind from comment #8) > For whatever reason I couldn't get "Tomorrow" to translate. I tried it with > fr-FR and de-DE - there was a translation for that already available, but it > didn't change anything in the staff interface. (All the other ones worked as > expected.) Did you remove the fuzzy line? It should look like that (fr-FR): 62284 #: koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc:38 62285 msgid "Tomorrow" 62286 msgstr "Demain" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:25:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:25:12 +0000 Subject: [Koha-bugs] [Bug 29331] Batch edit items.itemlost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:28:32 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #53 from Katrin Fischer --- Is the sequence of the attached patch files correct? (QA follow-up on top) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:37:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:37:19 +0000 Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Hello Christophe, that looks correct, can you provide a patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:41:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:41:53 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:46:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:46:13 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 --- Comment #10 from David Nind --- (In reply to Jonathan Druart from comment #9) > Did you remove the fuzzy line? > It should look like that (fr-FR): I didn't - this now works as expected now. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:48:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:48:42 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:48:46 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128102|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 128121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128121&action=edit Bug 29588: (bug 29478 follow-up) Make strings translatable "or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are using __ when _ should be used (__ is for .js files only). Test plan: 0. Apply the patch 1. cd misc/translator && perl translate update fr-FR 2. Edit misc/translator/po/fr-FR-staff-prog.po Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them 3. cd misc/translator && perl translate install fr-FR 4. Enable fr-FR (syspref 'language') 5. Edit a patron and an item and confirm that the flatpickr widget has the strings correctly translated Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 11:54:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 10:54:44 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #9 from Katrin Fischer --- I wonder if a total switch is good at this point in time with the concerns given. Pootle doesn't like the named placeholders ({}) for example, it gives an error that is very confusing to the translators as it requires manually removing the warning almost every time a file with those strings is touched. For context and plurals: This needs to be introduced by us manually in my opionion, where it's needed and makes the most sense. Plural forms also have the problem as mentioned above right now, causing trouble in translation. So for the moment I think it makes sense to do these on a 'as needed' basis more than doing a total of templates. For a lot of strings, I am not sure if we would win a lot. The adding of spans is good and bad: By not having the spans we leave strings that appear together in one string. For some things this is nice, but it's also bad because it's a bit hard to maintain at times and a little scary to new translators unaware of the template dynamics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:06:04 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127925|0 |1 is obsolete| | --- Comment #2 from Thibaud Guillot --- Created attachment 128122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128122&action=edit Bug 29553: Fix crash on undefined notforloan value Test plan: Set item level itypes to biblioitems. Find a record with itemtype NULL, having an item. Place a hold. Without this patch, it crashes. Signed-off-by: Marcel de Rooy Signed-off-by: ThibaudGLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:16:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:16:23 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > The adding of spans is good and bad: By not having the spans we leave > strings that appear together in one string. For some things this is nice, > but it's also bad because it's a bit hard to maintain at times and a little > scary to new translators unaware of the template dynamics. Having the spans actually remove strings to translate. The same strings are grouped in a single msgstr and need to be translated only once. Compared to when we have the same string but with different number of %s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:22:53 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #11 from Katrin Fischer --- (In reply to Jonathan Druart from comment #10) > (In reply to Katrin Fischer from comment #9) > > The adding of spans is good and bad: By not having the spans we leave > > strings that appear together in one string. For some things this is nice, > > but it's also bad because it's a bit hard to maintain at times and a little > > scary to new translators unaware of the template dynamics. > > Having the spans actually remove strings to translate. The same strings are > grouped in a single msgstr and need to be translated only once. Compared to > when we have the same string but with different number of %s You are right, that is a plus :) I think I am pro span and I didn't check the patch completely yet, but from what I saw they seem to be translatable without the context of the other entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:28:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:28:29 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:28:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:28:34 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128119|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 128123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128123&action=edit Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:28:40 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128120|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 128124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128124&action=edit Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:41:36 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #12 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > (In reply to Jonathan Druart from comment #10) > > (In reply to Katrin Fischer from comment #9) > > > The adding of spans is good and bad: By not having the spans we leave > > > strings that appear together in one string. For some things this is nice, > > > but it's also bad because it's a bit hard to maintain at times and a little > > > scary to new translators unaware of the template dynamics. > > > > Having the spans actually remove strings to translate. The same strings are > > grouped in a single msgstr and need to be translated only once. Compared to > > when we have the same string but with different number of %s > > You are right, that is a plus :) I think I am pro span and I didn't check > the patch completely yet, but from what I saw they seem to be translatable > without the context of the other entries. If you need the context and not the ugly %s then we need the TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 12:53:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 11:53:04 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #13 from Katrin Fischer --- I think your suggestion is ok as is. But I have a feeling we will have to retranslate quite bit - should not stop us from improving tho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:00:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:00:55 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #14 from Jonathan Druart --- Yes, of course, strings will need to be fixed. It should be something for a major version. And that's why I am bringing this topic at the beginning of 21.12 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:04:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:04:27 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #362 from Michal Denar --- Hi Aleisha, can you fix errors mentioned ba David? I'm ready to test. We really need this feature. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:13:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:13:55 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #12 from Marcel de Rooy --- (In reply to David Cook from comment #11) > (In reply to Marcel de Rooy from comment #8) > > Who opens a bug report like 'auto_renewal should not default to Yes' ? > > Does this seem like a productive question? Heh. Thats a good point :) I am glad though that Nick already picked this up! Thanks for your feedback. Sometimes we should save our comment on Bugzilla a day or so, and decide not to submit it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:16:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:16:31 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:16:43 +0000 Subject: [Koha-bugs] [Bug 29608] New: Editing numbering patterns does require full serials permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Bug ID: 29608 Summary: Editing numbering patterns does require full serials permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There is a mismatch in permission checks for working with serial numbering patterns: https://git.koha-community.org/Koha-community/Koha/src/branch/master/serials/subscription-numberpatterns.pl flagsrequired => { 'serials' => * } https://git.koha-community.org/Koha-community/Koha/src/branch/master/serials/subscription-numberpattern.pl flagsrequired => { 'serials' => 1 } I think both shoudl be * and at some point we might want to think of maybe having a separate permission. The problem is, that this means currently it requires full serials permission or superlibrian to work with the numbering patterns which is not always practical. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:18:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:18:17 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- (In reply to Thibaud Guillot from comment #2) > Created attachment 128122 [details] [review] > Bug 29553: Fix crash on undefined notforloan value > > Test plan: > Set item level itypes to biblioitems. > Find a record with itemtype NULL, having an item. > Place a hold. Without this patch, it crashes. > > Signed-off-by: Marcel de Rooy > Signed-off-by: ThibaudGLT Thx Thibaud. I will adjust the patch status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:21:42 +0000 Subject: [Koha-bugs] [Bug 29600] Sorting Checkout History no longer supports Author Sort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29600 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:50:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:50:40 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128107|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 128125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128125&action=edit Bug 29601: Lists: Test OPACISBD before showing ISBD download Test plan: Check if you see Download/ISBD for a list on OPAC. Clear OPACISBD. Check if the link is gone. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 13:58:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 12:58:53 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #15 from Julian Maurice --- (In reply to Katrin Fischer from comment #9) > Pootle doesn't like the named placeholders ({}) for example, it gives an > error that is very confusing to the translators as it requires manually > removing the warning almost every time a file with those strings is touched. I wasn't aware of this. It's strange, as this syntax is documented in gettext: https://www.gnu.org/software/gettext/manual/html_node/perl_002dformat.html#perl_002dformat I just tested locally on a fresh install of Pootle, and it seems the warning only appear for strings that have several plural forms AND the {} placeholder is not used in all of them. No warnings for simple (singular) translations or for plural forms that all have the {} placeholder in them. Have you seen the same thing ? If it's a problem, it can be changed to the usual %1$s, %2$s, ... It's not too late as only a few strings use this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 14:11:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 13:11:11 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Did you try to add a test for this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 14:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 13:11:29 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se --- Comment #25 from Alexander Borkowski --- We do have this exact issue on 19.11 unfortunately. I guess a backport to 19.11 is unlikely at this stage in its lifecycle so I will just patch our local version based on the diffs provided here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 14:13:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 13:13:05 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Should not we set the time part to 23:59:59 instead? I think it's what we do in other parts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 14:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 13:16:48 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128121|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot --- Created attachment 128126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128126&action=edit Bug 29588: (bug 29478 follow-up) Make strings translatable "or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are using __ when _ should be used (__ is for .js files only). Test plan: 0. Apply the patch 1. cd misc/translator && perl translate update fr-FR 2. Edit misc/translator/po/fr-FR-staff-prog.po Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them 3. cd misc/translator && perl translate install fr-FR 4. Enable fr-FR (syspref 'language') 5. Edit a patron and an item and confirm that the flatpickr widget has the strings correctly translated Signed-off-by: David Nind Signed-off-by: ThibaudGLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 14:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 13:51:23 +0000 Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 --- Comment #2 from Christophe TORIN --- Created attachment 128127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128127&action=edit Patch for the bug 29607 Here is the patch I suggest for the resolution of the bug. With this, the discount is properly stored. I oversaw this but the '%' is already present in the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:10:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:10:10 +0000 Subject: [Koha-bugs] [Bug 29609] New: Links to guess the biblio default view need to be centralized Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Bug ID: 29609 Summary: Links to guess the biblio default view need to be centralized Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org It's spread in different places, we could have a BLOCK in an include file to avoid code to be duplicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:11:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:11:04 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:11:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:11:09 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128125|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 128128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128128&action=edit Bug 29601: Lists: Test OPACISBD before showing ISBD download Test plan: Check if you see Download/ISBD for a list on OPAC. Clear OPACISBD. Check if the link is gone. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:12:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:12:03 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:12:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:12:03 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29609 CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- I felt down a rabbit hole and opened bug 29609. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 [Bug 29609] Links to guess the biblio default view need to be centralized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:15:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:15:22 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:15:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:15:25 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 --- Comment #1 from Jonathan Druart --- Created attachment 128129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128129&action=edit Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:33:10 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- Missing test coverage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:38:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:38:24 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart --- Then you need to adjust the batch record deletion tool as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:50:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:50:12 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:50:16 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126083|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 128130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128130&action=edit Bug 29115: Fix syntax errors in club hold functionality The code didn't previously correctly do the checks for patron debarment status and whether the patron has fees, this caused the intended warnings messages to not appear when they should have. To test: 1) Create a new club and add a patron to it who has manual debarment and a manual charge of over $5 (more than the maxoutstanding syspref). 2) Try to create a new club hold for the previously created club and notice no warnings are listed for the patron. 3) Apply patch 4) Try to create now the club hold again and notice the warnings being shown in the hold page. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:55:20 +0000 Subject: [Koha-bugs] [Bug 28327] System preference CSVdelimiter special case for tabulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #33 from Jonathan Druart --- It would have been better to have a new method in Koha.Config that could be called from all the other places as well: admin/aqplan.pl:$del = "\t" if $del eq 'tabulation'; misc/cronjobs/overdue_notices.pl: $sep_char = "\t" if ($sep_char eq 'tabulation'); misc/cronjobs/overdue_notices.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; misc/export_borrowers.pl: $separator = "\t" if ($separator eq 'tabulation'); reports/acquisitions_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/bor_issues_top.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/borrowers_out.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/borrowers_stats.pl:$sep = "\t" if ($sep and $sep eq 'tabulation'); reports/cash_register_stats.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; reports/cat_issues_top.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/catalogue_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/guided_reports.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; reports/issues_avg_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/issues_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/orders_by_fund.pl: $sep = "\t" if ($sep eq 'tabulation'); reports/reserves_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); reports/serials_stats.pl:$sep = "\t" if ($sep eq 'tabulation'); t/Koha_Template_Plugin_Koha.t: is($plugin->CSVDelimiter(), "\t", "CSVDelimiter() returns \\t when preference is tabulation"); t/Koha_Template_Plugin_Koha.t: is($plugin->CSVDelimiter('tabulation'), "\t", "CSVDelimiter(arg) returns \\t value when arg is tabulation"); tools/viewlog.pl: $delimiter = "\t" if $delimiter eq 'tabulation'; With this patch we are adding yet one more occurrences... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 15:55:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 14:55:39 +0000 Subject: [Koha-bugs] [Bug 29610] New: "Cap fine at replacement price" un-checks when circulation rule is edited Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29610 Bug ID: 29610 Summary: "Cap fine at replacement price" un-checks when circulation rule is edited Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When editing any part of a circulation rule in which "Cap fine at replacement price" is checked, the box un-selects and must be re-selected with each edit. Steps: -Create a circulation rule with "Cap fine at replacement price" selected, or edit an existing rule to select it. -Save the new (or edited) rule. -Edit the same rule again to change any other field. Note that "Cap fine at replacement price" is not selected in the editing line. -Save your edited rule - "Cap fine at replacement price" will now save as un-checked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:03:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:03:19 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #587 from Andrew Nugged --- Created attachment 128131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128131&action=edit Bug 20447: (QA follow-up) wrong include place for Koha::Holdings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:04:16 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #26 from Jonathan Druart --- (Wouldn't it be better to put effort in merging the tables?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:05:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:05:49 +0000 Subject: [Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:09:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:09:12 +0000 Subject: [Koha-bugs] [Bug 29447] authority that begins with a number isn't found in tag editor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29447 --- Comment #2 from Noémie Labine --- Hi Jonathan, It seems it was a bug specific to our Koha branch. It's currently being fixed by one of our partner. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:22:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:22:04 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:22:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:22:08 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114979|0 |1 is obsolete| | Attachment #127457|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 128132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128132&action=edit Bug 26296: Use new table column selection modal for OPAC suggestion fields This patch builds on the change introduced by Bug 22844, changing the selection mode for the OPACSuggestionMandatoryFields and OPACSuggestionUnwantedFields preferences to a modal. This patch includes a database update for converting the format of the saved values in these preferences. Previously the suggestions table fields would be separated by a comma. Now they should be separated by a pipe. To test, apply the patch run the database update. - Go to Administration -> System preferences. - Search for 'OPACSuggestion.' - The input fields for OPACSuggestionUnwantedFields and OPACSuggestionMandatoryFields should appear as "locked" (read-only) inputs. - Clicking either input field should trigger a modal window with checkboxes for each available column in the suggestions table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function. - Test that changes to both preferences are correctly reflected in the OPAC suggestion form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:22:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:22:12 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #8 from Owen Leonard --- Created attachment 128133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128133&action=edit Bug 26296: (follow-up) Make sure title remains mandatory This patch adds a flag to the OPAC preferences file marking suggestion title as mandatory OPACSuggestionMandatoryFields and excluded from OPACSuggestionUnwantedFields. The patch also modifies the markup around required fields in the OPAC suggestion form to comply with changes made in Bug 27668 to mandatory field styling. To test, apply the patch and restart services. - Test the OPACSuggestionMandatoryFields preference. In the modal, "title" should be checked and the label in red. It should not be possible to uncheck the checkbox. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are still saved correctly. - Test the OPACSuggestionUnwantedFields preference. In the modal, "title" should be unchecked and disabled. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are saved correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:28:12 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:34:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:34:28 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #588 from Andrew Nugged --- Created attachment 128134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128134&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:40:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:40:25 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #67 from Jonathan Druart --- Comment on attachment 127372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127372 Bug 27741: catalogue folder Review of attachment 127372: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27741&attachment=127372) -----------------------------------------------------------------

[% title | html %]

- [% IF ( subtitle ) %]

[% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %]

[% END %] - [% IF ( author ) %]

by [% author | html %]

[% END %] +

+ [% IF ( subtitle ) %][% FOREACH subtitl IN subtitle %] [% subtitl | html %][% END %][% END %] + [% IF ( author ) %]by [% author | html %][% END %] +

Is this correct? Shouldn't be h3? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:42:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:42:19 +0000 Subject: [Koha-bugs] [Bug 29611] New: Clubs enrollment layout problem in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Bug ID: 29611 Summary: Clubs enrollment layout problem in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 128135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128135&action=edit Screenshot of the problem When a user enrolls in a club via the OPAC the enrollment form looks broken because the "Finish" button is outside of the container the form is in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:42:22 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #68 from Jonathan Druart --- Impressive work Wainui! How did you process? Has all been done manually or you managed to catch them using a specific tool? We will certainly need something automated once pushed to catch regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:49:23 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #88 from Jonathan Druart --- Not considering blocker but worth nothing: You are adding h1 to a couple of "members" pages: * members/routing-lists.tt

Subscription routing lists for [% INCLUDE 'patron-title.inc' %]

* members/boraccount.tt

Account for [% INCLUDE 'patron-title.inc' %]

However most of the other views of the "members" module have the h1 without the patron's name: "Circulation history", "Checkouts", "Holds history". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:49:31 +0000 Subject: [Koha-bugs] [Bug 29612] New: Orders By Fund report (orders_by_fund.pl) should include actual cost (unitprice) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29612 Bug ID: 29612 Summary: Orders By Fund report (orders_by_fund.pl) should include actual cost (unitprice) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The built-in Orders by Fund report does not include the actual cost for orders than have been received. It only shows the vendor price and the estimated purchase price. We should add two new columns to show both the actual cost per item and the total actual cost (unitprice * quantity). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:54:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:54:40 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:54:43 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 --- Comment #1 from Owen Leonard --- Created attachment 128136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128136&action=edit Bug 29611: Clubs enrollment layout problem in the OPAC This patch makes a minor change to the HTML of the clubs enrollment form in the OPAC so that the layout works better. To test you should have at least one club available which allows public enrollment. The club should have at least one enrollment field configured. - Apply the patch and log in to the OPAC. - On the "Your summary" page, click the "Clubs" tab. - Click "Enroll" next to the club you configured. - You should see an enrollment form with the field(s) you configured. - The "Finish enrollment" button should be styled green and should be positioned inside the box which delineates the Clubs tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:58:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:58:15 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #89 from Jonathan Druart --- There is something that is problematic, the [% INCLUDE 'blocking_errors.inc' %] should not be moved, it must be at the very beginning (right after main). The script will stop early (after the INCLUDE) and we don't want to display anything else before as the template won't receive the correct data in most of the cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 16:59:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 15:59:31 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 17:15:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 16:15:56 +0000 Subject: [Koha-bugs] [Bug 29445] Provide an option to not show Coce cover images on specific records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 17:54:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 16:54:20 +0000 Subject: [Koha-bugs] [Bug 29613] New: Set focus for cursor to barcode field on course reserves add items and batch add items pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 Bug ID: 29613 Summary: Set focus for cursor to barcode field on course reserves add items and batch add items pages Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: eliana at flo.org QA Contact: testopia at bugs.koha-community.org When clicking on the "Add reserves" or "batch add reserves" buttons in the course reserves module, the cursor focuses on the catalog search bar instead of the box where you scan in the barcodes. I fixed this locally by adding the following to IntranetUserJS: //Switch active cursor to correct box for adding course reserves $(document).ready(function(){ if (window.location.href.indexOf("cgi-bin/koha/course_reserves/add_items.pl") > -1) { $('#barcode').focus(); } }); $(document).ready(function(){ if (window.location.href.indexOf("cgi-bin/koha/course_reserves/batch_add_items.pl") > -1) { $('#barcodes').focus(); } }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 17:54:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 16:54:32 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 Eliana changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 17:55:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 16:55:25 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 --- Comment #1 from Eliana --- Created attachment 128137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128137&action=edit Screenshot of current behavior -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 17:58:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 16:58:16 +0000 Subject: [Koha-bugs] [Bug 29614] New: Add "Patron home library" option to Hold Pickup Library Match in circ rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29614 Bug ID: 29614 Summary: Add "Patron home library" option to Hold Pickup Library Match in circ rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries want to force all holds to be picked up at the patron's home library, regardless of which library the item is from. There is not currently an option for this in the circ rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 18:18:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 17:18:47 +0000 Subject: [Koha-bugs] [Bug 29615] New: Add library pull down to simple search in the staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29615 Bug ID: 29615 Summary: Add library pull down to simple search in the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This would be like OpacAddMastheadLibraryPulldown, but for the staff interface. A library pull down would display at the end of the simple search input field that allows to limit on a specific library right away. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 18:54:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 17:54:59 +0000 Subject: [Koha-bugs] [Bug 29616] New: Replace library information popup in the OPAC with a modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Bug ID: 29616 Summary: Replace library information popup in the OPAC with a modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 128138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128138&action=edit Screenshot showing the modal information window If you have "OPAC info" for any of your libraries this information will show up as a popup when the user, viewing the bibliographic detail page, hovers over the library name in the holdings table. I think it would be more user-friendly to have the user click to show this information in a modal dialog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 19:48:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 18:48:24 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 19:48:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 18:48:24 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 [Bug 18493] Add more languages to advanced search languages dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 20:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 19:56:19 +0000 Subject: [Koha-bugs] [Bug 29617] New: BorrowerUnwantedField should exclude the ability to hide categorycode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Bug ID: 29617 Summary: BorrowerUnwantedField should exclude the ability to hide categorycode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com BorrowerUnwantedField includes the ability to mark categorycode as unwanted/hidden. If you mark it as unwanted and try to add a new patron you will see an error: "Something went wrong when creating the patron. Check the logs." categorycode must not be hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:09:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:09:16 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:09:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:09:20 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 --- Comment #1 from Owen Leonard --- Created attachment 128139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128139&action=edit Bug 29616: Replace library information popup in the OPAC with a modal This patch modifies the OPAC bibliographic detail page so that information stored in libraries' "OPAC info" field can be displayed in a modal window instead of in a tooltip. This will make it more readable, especially for libraries with so much info content that the popup can disappear off the bottom of the page. To test, apply the patch and make sure you have at least one library configured according to each of these: A. One with both branches.branchurl and branches.opac_info B. One with branches.branchurl but not branches.opac_info C. One with branches.opac_info but not branches.branchurl D. One with neither branches.branchurl nor branches.opac_info View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:19:19 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:19:23 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128136|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128140&action=edit Bug 29611: Clubs enrollment layout problem in the OPAC This patch makes a minor change to the HTML of the clubs enrollment form in the OPAC so that the layout works better. To test you should have at least one club available which allows public enrollment. The club should have at least one enrollment field configured. - Apply the patch and log in to the OPAC. - On the "Your summary" page, click the "Clubs" tab. - Click "Enroll" next to the club you configured. - You should see an enrollment form with the field(s) you configured. - The "Finish enrollment" button should be styled green and should be positioned inside the box which delineates the Clubs tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:30:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:30:23 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes a minor HTML release notes| |issue with the clubs | |enrollment form in the | |OPAC. The "Finish | |enrollment" button is now | |positioned correctly inside | |the bordered area and uses | |standard colors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:43:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:43:57 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:44:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:44:03 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128133|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 128141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128141&action=edit Bug 26296: (follow-up) Make sure title remains mandatory This patch adds a flag to the OPAC preferences file marking suggestion title as mandatory OPACSuggestionMandatoryFields and excluded from OPACSuggestionUnwantedFields. The patch also modifies the markup around required fields in the OPAC suggestion form to comply with changes made in Bug 27668 to mandatory field styling. To test, apply the patch and restart services. - Test the OPACSuggestionMandatoryFields preference. In the modal, "title" should be checked and the label in red. It should not be possible to uncheck the checkbox. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are still saved correctly. - Test the OPACSuggestionUnwantedFields preference. In the modal, "title" should be unchecked and disabled. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are saved correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:46:07 +0000 Subject: [Koha-bugs] [Bug 29161] Holds to pull should show item level holds only if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Severity|enhancement |normal --- Comment #1 from Andrew Fuerste-Henry --- Changing this from Enhancement to Normal, as it is legitimately a bug rather than an enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:52:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:52:06 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128132|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 128142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128142&action=edit Bug 26296: Use new table column selection modal for OPAC suggestion fields This patch builds on the change introduced by Bug 22844, changing the selection mode for the OPACSuggestionMandatoryFields and OPACSuggestionUnwantedFields preferences to a modal. This patch includes a database update for converting the format of the saved values in these preferences. Previously the suggestions table fields would be separated by a comma. Now they should be separated by a pipe. To test, apply the patch run the database update. - Go to Administration -> System preferences. - Search for 'OPACSuggestion.' - The input fields for OPACSuggestionUnwantedFields and OPACSuggestionMandatoryFields should appear as "locked" (read-only) inputs. - Clicking either input field should trigger a modal window with checkboxes for each available column in the suggestions table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function. - Test that changes to both preferences are correctly reflected in the OPAC suggestion form. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:52:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:52:12 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128141|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 128143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128143&action=edit Bug 26296: (follow-up) Make sure title remains mandatory This patch adds a flag to the OPAC preferences file marking suggestion title as mandatory OPACSuggestionMandatoryFields and excluded from OPACSuggestionUnwantedFields. The patch also modifies the markup around required fields in the OPAC suggestion form to comply with changes made in Bug 27668 to mandatory field styling. To test, apply the patch and restart services. - Test the OPACSuggestionMandatoryFields preference. In the modal, "title" should be checked and the label in red. It should not be possible to uncheck the checkbox. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are still saved correctly. - Test the OPACSuggestionUnwantedFields preference. In the modal, "title" should be unchecked and disabled. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are saved correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 21:55:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 20:55:08 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This changes the selection release notes| |of values for | |OPACSuggestionUnwantedField | |s and | |OPACSuggestionMandatoryFiel | |ds from drop down lists to | |a modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 22:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 21:05:56 +0000 Subject: [Koha-bugs] [Bug 29161] Holds to pull should show item level holds only if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 --- Comment #2 from Andrew Fuerste-Henry --- As an added point of confusion, if your item-level hold is on an unavailable item and Koha shows it on the Holds to Pull anyway, it will be shown as an item-level hold for some copy that is available (though Koha rightly will refuse to fill the hold with the item its sent you to pull). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 22:52:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 21:52:01 +0000 Subject: [Koha-bugs] [Bug 29618] New: Typing a Patron Name into the checkout bar goes moremember.pl instead of circulation.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29618 Bug ID: 29618 Summary: Typing a Patron Name into the checkout bar goes moremember.pl instead of circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If we type a patron's name into the checkout bar it not takes us to moremember.pl instead of circulation.pl. This is an issue as many patrons come in with their ID instead of their library card and we look them up, especially in small branches. Some of these libraries are volunteer run and do not have permission to view the details page (view_borrower_infos_from_any_libraries) and they get an error message that they can't access that page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 23:22:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 22:22:51 +0000 Subject: [Koha-bugs] [Bug 29370] Cannot add patron attributes to quick add or mandatory list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29370 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown at bywatersolutions.com --- Comment #3 from Sara Brown --- Making attributes mandatory through the attribute vs. BorrowerMandatoryField can cause problems for libraries that allow self-registration since the attribute settings don't distinguish between creating an account and the ability to modify in the same way that PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerUnwantedField do. If the attribute is mandatory but libraries do not want patrons to be able to edit (Editable in OPAC not checked), Koha will return an error when someone tries to self-register. However, if Editable in OPAC is checked to avoid that error, patrons can continue to edit the information after registration. This could be avoided if attributes could be made mandatory for multiple patron categories instead of either all or one - that way, a library could choose every category except Self-registered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 23:31:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 22:31:38 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #15 from David Cook --- Btw, just sharing an experience using the https://metacpan.org/pod/TOML library. It takes a TOML Boolean false and converts it into a Perl string that says "false". I'm regretting using TOML and that library on a little program of mine. Glad that I didn't invest much in it... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 23:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 22:57:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #363 from David Cook --- (In reply to Michal Denar from comment #362) > Hi Aleisha, > can you fix errors mentioned ba David? I'm ready to test. We really need > this feature. > > Thank you. My hope is to get some sponsorship to keep working on this in the coming months. I've got it running on a customized 21.05 Koha, but if we don't work on upstreaming it soon, I fear it will become very challenging to try again in the future... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 1 23:59:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 22:59:20 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #13 from David Cook --- (In reply to Marcel de Rooy from comment #12) > Heh. Thats a good point :) I am glad though that Nick already picked this up! > Thanks for your feedback. > Sometimes we should save our comment on Bugzilla a day or so, and decide not > to submit it? Thanks for accepting the feedback, and I know that feeling well. These days, I try to sit on my own comments more, so I understand 😅. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 00:02:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Dec 2021 23:02:33 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Should this be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 01:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 00:54:24 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:26:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:26:26 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 [Bug 28338] Validate item holdability and pickup location separately -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:26:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:26:26 +0000 Subject: [Koha-bugs] [Bug 28338] Validate item holdability and pickup location separately In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:31:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:31:09 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Depends on| |28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:31:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:31:09 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:31:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:31:28 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28273 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:31:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:31:28 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28919 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:37:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:37:11 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #11 from David Cook --- Created attachment 128144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128144&action=edit Bug 28919: [Alternative] Select logged in library as pickup for multi holds Default pickup location to the logged in library for staff placed multiholds. Holds with a blank pickup location will cause 500 errors in the Reserves tab of the circulation screen, so we want to make sure the pickup location does not default to blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:37:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:37:45 +0000 Subject: [Koha-bugs] [Bug 29573] MARC Framework Subfields Visibility Setting Not Obeyed for 5XX In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 --- Comment #4 from Lye Jia Lun --- Dear Katrin, Thank you for your suggestion. I have tried using the NotesToHide by appending the value 583 there but the issue with this is that it will hide for both OPAC and the Staff Client. We wish to hide it from the OPAC only hence we were using the Subfields Visibility setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:41:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:41:38 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #12 from David Cook --- Attaching an alternative patch here, although I think Jonathan's is better overall (just needs to be applies to the "Pickup location" as well). This is causing frequent problems for a library of mine, so I'm keen to get a fix implemented ASAP. Personally, I think a lot of holds logic and error-handling needs work, but I don't mind just putting out fires for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:44:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:44:57 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:45:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:45:00 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 --- Comment #1 from Lucas Gass --- Created attachment 128145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128145&action=edit Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:46:35 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 02:48:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 01:48:12 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #3 from David Cook --- It looks like the values I have are a bit different too... Debits: C LOST_RETURN Pay W Credits: LOST OVERDUE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 03:05:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 02:05:04 +0000 Subject: [Koha-bugs] [Bug 29604] term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 03:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 02:05:07 +0000 Subject: [Koha-bugs] [Bug 29604] term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 --- Comment #1 from Lucas Gass --- Created attachment 128146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128146&action=edit Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 03:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 02:05:59 +0000 Subject: [Koha-bugs] [Bug 29604] term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 03:11:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 02:11:01 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Nope, it was a regression due to bug 29264 so you dodged a bullet ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 03:42:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 02:42:10 +0000 Subject: [Koha-bugs] [Bug 29031] Authorities see also links - plack error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29031 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- (In reply to Vitor Fernandes from comment #0) > The authorities see also links in Koha 21.05.01 OPAC gives a plack error: > Can't call method "authtypetext" on an undefined value at > opac-authorities-home.pl line 155 > > Test plan: > > - Create for example an UNIMARC authority with the following fields: > - 250$a - test1 > - 550$a - test2 > - Open the created authority in OPAC > - Click on the link test2 (see also section) > - Error 500 Which authority type please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 05:11:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 04:11:43 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- Hi, thanks Jonathan for the approach on the SWITCH-es only. It seems to be the biggest pain in our strings. Would a good solution be to surround same strings as this patch with t() instead of ? The only worry about progressive use of t() is performance, right? About the discussion on bug 26392 of t("Koha online catalogue") vs t("opac.homepage.title"), the current approach (1st) doesn't close the door for the 2nd (token based) since the strings would already be wrapped in calls. So it's not closing this door assuming the token based approach is chosen in the end. So about performance: Here are results of the benchmarks of bug 15395 on my laptop with a 2012 CPU (i5-3320M @3.3GHz on mono thread loads) Summary Average for 10 strings without translation: 0.0001145 seconds Average for 100 strings without translation: 0.0001114 seconds Average for 200 strings without translation: 9.82e-05 seconds Average for 500 strings without translation: 0.0001932 seconds Average for 10 strings with translation: 0.0014077 seconds Average for 100 strings with translation: 0.0076227 seconds Average for 200 strings with translation: 0.0120828 seconds Average for 500 strings with translation: 0.0306117 seconds The same PC has a median time of 0.350 sec to generate the untranslated HTML for this page: /cgi-bin/koha/admin/preferences.pl?tab=circulation (using browser network devtools) There are 200 sysprefs shown there. So it's surely one the of the pages with the most translatable strings we have. (Well, searching "a" in sysprefs yields 740 of them ^^" in more than 0.950 sec) git grep "circulation.pref#" misc/translator/po/bg-Cyrl-pref.po | wc -l => 633 So it seems we have 633 strings in our circulation sysprefs. if 500 strings took 0.031 sec in the benchmark then 633 strings => 0.039 sec 0.039 is 11% of 0.350 So we should expected that using t() on all string on this page should add 11% response time to 0.350 sec. Would there be another case where the overhead could be the more perceptible than this? (it's not really perceptible) Is the methodology valid? If so then we shouldn't expect issues about performance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 05:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 04:29:44 +0000 Subject: [Koha-bugs] [Bug 29619] New: Ordering single item does not save item as Ordered Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 Bug ID: 29619 Summary: Ordering single item does not save item as Ordered Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org When ordering just one item, the item does not get "Not for loan" -value "Ordered". When function "Add more items" is used to put item(s) to order, the item(s) get value "Ordered". (Even if you that way add only one item). Path to get the bug: Find a vendor and a acquisition basket Choose "Add to basket" Find title to order - Choose "Add order" Edit item details (do not touch Not for loan value). Choose "Add item". Save new order. -> result: item is added as available (Should be Ordered) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:18:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:18:39 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #24 from Fridolin Somers --- OK for push now ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:21:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:21:14 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |fridolin.somers at biblibre.co | |m Version(s)| |22.05.00 released in| | --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:39:06 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:44:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:44:41 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:46:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:46:24 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Passed QA |Pushed to master --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:48:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:48:09 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |unspecified CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:48:26 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:53:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:53:17 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |23013 --- Comment #5 from Fridolin Somers --- I bet is is since Bug 23013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:53:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:53:17 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 [Bug 29488] NumSavedReports system preference doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 07:55:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 06:55:24 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #25 from Jonathan Druart --- No, it's not ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:14:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:14:29 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:34:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:34:11 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:34:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:34:15 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128140|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 128147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128147&action=edit Bug 29611: Clubs enrollment layout problem in the OPAC This patch makes a minor change to the HTML of the clubs enrollment form in the OPAC so that the layout works better. To test you should have at least one club available which allows public enrollment. The club should have at least one enrollment field configured. - Apply the patch and log in to the OPAC. - On the "Your summary" page, click the "Clubs" tab. - Click "Enroll" next to the club you configured. - You should see an enrollment form with the field(s) you configured. - The "Finish enrollment" button should be styled green and should be positioned inside the box which delineates the Clubs tab. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:34:36 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:38:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:38:45 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:44:42 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- I see the commit has been pushed to 19.11.x I propose we set status to revolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:44:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:44:59 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:48:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:48:02 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |fridolin.somers at biblibre.co | |m Version(s)| |22.05.00 released in| | --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:51:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:51:42 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Looks like this is not needed for Firefox. Is it for a specific web browser ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:53:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:53:45 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 --- Comment #7 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #6) > Looks like this is not needed for Firefox. > Is it for a specific web browser ? Probably other browsers need it. I saw that it worked under Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:56:09 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 --- Comment #8 from Fridolin Somers --- (In reply to Fridolin Somers from comment #6) > Looks like this is not needed for Firefox. > Is it for a specific web browser ? Ah forget that, since it is the same as Bug 19570 I will push -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 08:58:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 07:58:36 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:03:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:03:10 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- File name is "js-patron-format.inc" but first line comment says "js-patron-title.inc" I suggest we rename file to be closer to existing include "patron-title.inc" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:10:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:10:11 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #16 from Julian Maurice --- (In reply to David Cook from comment #15) > Btw, just sharing an experience using the https://metacpan.org/pod/TOML > library. > > It takes a TOML Boolean false and converts it into a Perl string that says > "false". Thanks for sharing. The TOML module seems to be the worst implementation available. No release since 2017, only supports v0.4 of TOML spec, and of course this boolean horror :) TOML::Tiny and TOML::XS seems to be better alternatives, both supporting the latest version of the spec, and their latest releases were this year, in august. So, Perl support for TOML has improved since comment 7. And the latest version of TOML::Tiny is packaged in Debian testing, which is promising. Now, is TOML suited for Koha configuration ? That's another question... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:32:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:32:27 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED --- Comment #13 from Alexander Borkowski --- I built local packages from the latest 19.11.x and installed them on our test server. All works as expected (already hashed secrets remained untouched and plain ones I created for testing where hashed afterwards). Setting status to resolved now - many thanks to all involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:39:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:39:37 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #4 from Katrin Fischer --- We share Pay, W and LOST - W was a lot in our database, maybe this could be the first to focus on? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:54:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:54:32 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.24 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:56:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:56:12 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20988 --- Comment #17 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #16) > Is the methodology valid? You need to count how many times you enter t() instead of guessing the number of lines matching a pattern there are in a file. This discussion should take place on bug 20988. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:56:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:56:12 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29602 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 09:57:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 08:57:46 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #18 from Jonathan Druart --- (In reply to Julian Maurice from comment #15) > I just tested locally on a fresh install of Pootle, and it seems the warning > only appear for strings that have several plural forms AND the {} > placeholder is not used in all of them. No warnings for simple (singular) > translations or for plural forms that all have the {} placeholder in them. > Have you seen the same thing ? No, we are seeing it whenever {} is used in the translation (plural form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:20:47 +0000 Subject: [Koha-bugs] [Bug 29618] Typing a Patron Name into the checkout bar goes moremember.pl instead of circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Hi Lisette, Which link on which view exactly? Links in the autocomplete result from the header will bring you to circulation.pl if tab is "Check out" and to moremember if tab is "Search patron" Still in the header, the redirect if there is only one patron matching your search will bring you to either circulation or moremember depending on the tab. On the patron result, the link in the "Card" column points to circulation.pl when the link on the patron's name points to moremember. All those behaviours seem correct to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:20:47 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #364 from Michal Denar --- I agree with David. We need finish this feature ASAP. Lets talk about sponsorship. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:30:18 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart --- This is going backward IMO, why not move to DBIC/Koha::Object instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:32:16 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:32:35 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 10:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 09:55:20 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #13 from marion.durand at biblibre.com --- I'm not sure what to do in batch record deletion as it is the same behavior as when there are attached items. >From a record page, it's impossible to delete the record if there is any item attached to it but it is still possible to delete it from batch record deletion. Plus there is a reminder to warn the user that deleting the biblio will also delete attached subscription, holds and items (even if I can't find yet where in the code we delete the subscription) Maybe we could add a column to show the user how many subscriptions are attached to the biblio (just as items holds and checkouts) and add the possibility to select without subscription (as for items and holds). Should we block the deletion of biblio records with attached subscriptions ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:07:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:07:13 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart --- 1. There is a return in an assignment statement: + my $soonestrenewal = return dt_from_string( $itemissue->date_due ); 2. Wondering, should we return $soonestrenewal if $now < $soonestrenewal; ? 3. Shouldn't we finally call GetSoonestRenewDate from _CanBookBeAutoRenewed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:10:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:10:15 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 --- Comment #3 from Jonathan Druart --- Looking at api/v1/swagger/swagger.yaml it seems that we use the plural form for all other tags. Shouldn't we do the reverse and use "libraries" everywhere else instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:11:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:11:58 +0000 Subject: [Koha-bugs] [Bug 29473] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Documentation tasks for |Documentation changes for |21.11 |21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:15:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:15:27 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:15:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:15:31 +0000 Subject: [Koha-bugs] [Bug 29580] Missing end tag in circ/overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128056|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 128149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128149&action=edit Bug 29580: Fix missing end tag in circ/overdue.tt In circ/overdue.tt there is a end tag inside a IF condition. I should be outside. Test plan : Check HTML in overdue page with and without seeing patrons infos from other branches Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:16:34 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #14 from Jonathan Druart --- (In reply to marion.durand from comment #13) > Maybe we could add a column to show the user how many subscriptions are > attached to the biblio (just as items holds and checkouts) and add the > possibility to select without subscription (as for items and holds). Yes, that. It's what I was suggesting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:17:06 +0000 Subject: [Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing end tag in |Misplaced closing 'td' tag |circ/overdue.tt |in overdue.tt CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:18:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:18:13 +0000 Subject: [Koha-bugs] [Bug 29257] Redundant slash in the URL appear during item level hold placing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #7) > Just noting down here as well, if bug 28782 gets pushed then this bug is > fixed as well. Yes, I think we should favor bug 28782's solution over this one. Or we based it on top of this one to make this patch backportable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:20:27 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Should we fix the other occurrences as well? koha-tmpl/intranet-tmpl/prog/en/columns.def:Collection code koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: ccode: "Collection code" and in the framework installer files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:24:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:24:38 +0000 Subject: [Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Marcel de Rooy --- Well, any feedback is surely welcome. We could argue that this approach is the most logical one: We want to see the external record, not our defaults for a new record. And if needed, we could change external records via the XSLT step on the Z3950 target. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:24:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:24:39 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #15 from marion.durand at biblibre.com --- Ok I'll do that. Thank you for answering so quickly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:39:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:39:41 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #10) > Well, what's the point of the first/main select then? Tomas? This form had a problem, orginally: it allowed you to place holds with invalid pickup locations, and didn't even require AllowHoldPolicyOverride. The idea was to make it so you weren't offered bad pickup locations. Asking different libraries, it turned out this wasn't a bad workflow: - You select several biblios and click place hold - A form is presented (similar to the one before - There's a dropdown that lets you choose the union of the valid pickup locations from all selected titles - Only those for which the chosen one is a valid one are set - The rest require manually setting them - If you manually set one, changing the top-level 'Pickup at' one should not change it - It needs to honour the UI decision we made about overriden pickup locations, having them show a notice about them being an override to rules So that's it. Reading the bug description, my guess is that: - The 'Pickup at' dropdown might need some better explanation in the UI (a hint, a visible text) - I read a comment from dcook somewhere else, and it felt like he found a bug that made the form send empty pickup locations, that actually hit the DB, that'd be a bug, not a usability discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:45:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:45:02 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #13) > (In reply to Jonathan Druart from comment #10) > > Well, what's the point of the first/main select then? Tomas? > > This form had a problem, orginally: it allowed you to place holds with > invalid pickup locations, and didn't even require AllowHoldPolicyOverride. > The idea was to make it so you weren't offered bad pickup locations. > > Asking different libraries, it turned out this wasn't a bad workflow: > - You select several biblios and click place hold > - A form is presented (similar to the one before > - There's a dropdown that lets you choose the union of the valid pickup > locations from all selected titles > - Only those for which the chosen one is a valid one are set > - The rest require manually setting them > - If you manually set one, changing the top-level 'Pickup at' one should not > change it > - It needs to honour the UI decision we made about overriden pickup > locations, having them show a notice about them being an override to rules > > So that's it. Reading the bug description, my guess is that: > - The 'Pickup at' dropdown might need some better explanation in the UI (a > hint, a visible text) > - I read a comment from dcook somewhere else, and it felt like he found a > bug that made the form send empty pickup locations, that actually hit the > DB, that'd be a bug, not a usability discussion. And making a default selection is good too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:48:18 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128053|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot --- Created attachment 128150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128150&action=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process actually make the "Highlight"/"Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client. This patch fixes that by upgrading the plugin to its latest version. Test plan: 0) Catalogue two books using the titles below, one of which includes a word ("τοῖς") containing Greek diacritics: Book #1 title: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book #2 title: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) Then, perform a catalog search for "επιτομή των" (without the quotes). In the results page, notice that: a) the "Highlight"/"Unhighlight" button has disappeared, and b) not all search terms are highlighted (e.g. "των" in the 2nd book) 1) Apply this patch. 2) Repeat the same search (remember to press CTRL-F5 to refresh JS code). This time the "Highlight"/"Unhighlight" button is displayed normally, and all instances of your search terms are highlighted in the results. Signed-off-by: ThibaudGLT Work on Firefox 94.0-Ubuntu 20.04LTS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:55:21 +0000 Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment type required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m --- Comment #4 from Thibaud Guillot --- After trying to rebase the patch by deleting payment.inc, I did not see any changes according to the test plan. Maybe a change has been applied to master and this patch has become useless? Or is this a mistake on my part? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 11:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 10:57:19 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #4 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > Looking at api/v1/swagger/swagger.yaml it seems that we use the plural form > for all other tags. > > Shouldn't we do the reverse and use "libraries" everywhere else instead? Good point, updating the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:05:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:05:00 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #3 from Jonathan Druart --- How did we miss that?! It also means that there is a RM step that is missing when releasing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:08:40 +0000 Subject: [Koha-bugs] [Bug 29605] Add missing UNIQUE constraints in kohastructure.sql (Bug 15067 follow-up) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #4 from Jonathan Druart --- Oops, there are way more things that diverge! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:10:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:10:13 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128089|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 128151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128151&action=edit Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['libraries'] 3. swagger.yaml too! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:10:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:10:39 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:20:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:20:25 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add missing UNIQUE |DB structure may not be |constraints in |synced with |kohastructure.sql (Bug |kohastructure.sql |15067 follow-up) | Assignee|tomascohen at gmail.com |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:21:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:21:03 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #11) > File name is "js-patron-format.inc" but first line comment says > "js-patron-title.inc" That's a typo. > I suggest we rename file to be closer to existing include "patron-title.inc" I followed the (already existing) js-format-date.inc file name. I think I prefer it. But can adjust if required, not personally attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:41:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:41:23 +0000 Subject: [Koha-bugs] [Bug 29620] New: Move the OpenAPI spec to YAML format Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Bug ID: 29620 Summary: Move the OpenAPI spec to YAML format Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Work has started on new routes and the reference /cities spec, we should do it in one run on this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:41:35 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |29072 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072 [Bug 29072] Move reference route /cities spec to YAML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:41:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:41:35 +0000 Subject: [Koha-bugs] [Bug 29072] Move reference route /cities spec to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 [Bug 29620] Move the OpenAPI spec to YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 12:44:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 11:44:04 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:18 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #5 from Jonathan Druart --- Created attachment 128152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128152&action=edit Bug 29605: Missing FK on tmp_holdsqueue.borrowernumber (tmp_holdsqueue_ibfk_3) Bad copy paste on the foreign_key_exists condition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:22 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #6 from Jonathan Druart --- Created attachment 128153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128153&action=edit Bug 29605: account_offsets.type is not null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:27 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #7 from Jonathan Druart --- Created attachment 128154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128154&action=edit Bug 29605: additional_contents.code Added 100 on 210600016, but 20 in kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:30 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #8 from Jonathan Druart --- Created attachment 128155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128155&action=edit Bug 29605: additional_contents.lang Up to 50 on bug 23797 but bug 24387 switched it back to 25 (bad resolution conflict) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:34 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #9 from Jonathan Druart --- Created attachment 128156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128156&action=edit Bug 29605: search_marc_map.marc_type NOT NULL was missing when MODIFY -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:38 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #10 from Jonathan Druart --- Created attachment 128157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128157&action=edit Bug 29605: language_script_mapping.language_subtag cannot be null It's a PK now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:09:42 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #11 from Jonathan Druart --- Created attachment 128158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128158&action=edit Bug 29605: branchtransfers.cancellation_reason reason and cancellation_reason was inversed, and the enum values were lower cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:12:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:12:05 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Jonathan Druart --- Test plan: % git checkout -b bug_29605 origin/master % yes|git bz apply 29605 % git checkout v21.05.00 % reset_all % git checkout bug_29605 % updatedatabase # We are going to update the 21.05.00 DB with all the 21.11 dbrevs # Generate the DBIC schema file using the current DB % perl misc/devel/update_dbix_class_files.pl --koha-conf $KOHA_CONF % git commit -a -m"test diff" # commit the changes to help understand % dbic # generate the schema file using kohastructure.sql % git diff => NO relevant changes should be seen in this diff, only comments and date/md5sum must differ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:12:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:12:14 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:13:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:13:42 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > How did we miss that?! > It also means that there is a RM step that is missing when releasing https://tree.taiga.io/project/koha-ils/task/117 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:53:15 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 --- Comment #3 from Jonathan Druart --- Created attachment 128159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128159&action=edit Bug 29385: [ALTERNATIVE] Catch register_id for payments against fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:54:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:54:24 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- To prevent such problems from happening again I would prefer a version that will not duplicate code. But hard to provide patch and be confident in it as this code is not covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 13:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 12:58:33 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- (In reply to Jonathan Druart from comment #13) > (In reply to Jonathan Druart from comment #3) > > How did we miss that?! > > It also means that there is a RM step that is missing when releasing > > https://tree.taiga.io/project/koha-ils/task/117 Not sure where is the best place to comment, but I added a suggestion on taiga. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:02:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:02:04 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #16 from marion.durand at biblibre.com --- Created attachment 128160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128160&action=edit Bug 9565: (follow-up) Adapt batch record deletion tool Add a column "Subscriptions" to the batch deletion tools Add a link on the number of subscription to the search page with all the subscriptions of the record Add a button in the toolbar to select only biblio record without subscriptions The changes are only on display It is still possible to delete records that are attached to subscriptions from this tool (as it is possible for records with attached items) To test: 1) Go to the batch record deletion (in tools) 2) Select a list of record numbers (select some with one or more subscription) 3) Click on Continue 4) Check that there is no column named "Subscription" and that there is no button "Select without subscription" in the toolbar 5) Apply patch 6) Repeat steps 1 to 3 7a) Check that there is a column named "Subscription" fill with the number of subscriptions attached to the record 7b) Check that the link in the subscriptions column send you to the search page with the subscriptions linked to this record 7c) Check that there is a button "Select without subscription" in the toolbar that selects record with no subscription attached 8) Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:03:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:03:15 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Pablo López Liotti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paliotti at mdp.edu.ar --- Comment #23 from Pablo López Liotti --- hi, there are any news on this topic? In the university libraries is wanted to filter students suggestions. I hope I can do by jquery while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:07:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:07:13 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:26:19 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:26:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:26:23 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127348|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 128161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128161&action=edit Bug 28853: Fix authority plugin when textarea in biblio record editor In biblio record editor, when subfield value contains more than 100 characters the editor uses a textarea instead of an input. On a field using authority plugin, this breaks the JavaScript because it only searches for input tags : In /koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt : > this.getElementsByTagName('input')[1].value = values[i]; Test plan : 1) Prepare : 1.1) Create a new biblio record with a field using authority plugin, for example 606 1.2) Do not use authority plugin but enter in 606$x more than 100 chars 1.3) Save record 1.4) Create a new autority for 606 biblio field with $a and a $x containing more than 100 chars 2) Test 1 : 2.1) Edit again the biblio record, you see a text area for 606$x 2.2) Use authority plugin on field 606 2.3) Search and choose the new autority 2.4) Check $a,$x and $9 are well filled 3) Test 2 : 3.1) Empty field 606 3.2) Create a second $x subfield and fill it with a random value 3.3) Use authority plugin again on field 606 3.4) Search and choose the new autority 3.5) Check $a and $9 are well filled 3.6) Check first $x contains the value from autority and second $x is empty Signed-off-by: Florian Bontemps Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:45:36 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127678|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 128162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128162&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages:
    [% FOR m IN messages.search( message_type => 'L' ) %]
  • [% m.message %]
    • [% END %]
[% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:47:01 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se --- Comment #9 from Stina Hallin --- Signed off using a sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:50:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:50:19 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart --- Can you provide tests, please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:52:40 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113591|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes --- Created attachment 128163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128163&action=edit Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions Currently Koha will delete a biblio record if there are existent serial subscriptions. This patch will prevent deleting the biblio until attached subscriptions are removed. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Séverine QUEUNE Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:52:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:52:44 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128051|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes --- Created attachment 128164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128164&action=edit Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions Clicking on "Delete record" while there are existent subscriptions no longer delete the record and the subscription. Instead an alert box inform the user that he must delete all subscription before deleting the record. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Attempt to 'Delete record', you should recieve an error message stating to delete all subscriptions before deleting record. 6) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Samu Heiskanen Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:52:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:52:49 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128160|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes --- Created attachment 128165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128165&action=edit Bug 9565: (follow-up) Adapt batch record deletion tool Add a column "Subscriptions" to the batch deletion tools Add a link on the number of subscription to the search page with all the subscriptions of the record Add a button in the toolbar to select only biblio record without subscriptions The changes are only on display It is still possible to delete records that are attached to subscriptions from this tool (as it is possible for records with attached items) To test: 1) Go to the batch record deletion (in tools) 2) Select a list of record numbers (select some with one or more subscription) 3) Click on Continue 4) Check that there is no column named "Subscription" and that there is no button "Select without subscription" in the toolbar 5) Apply patch 6) Repeat steps 1 to 3 7a) Check that there is a column named "Subscription" fill with the number of subscriptions attached to the record 7b) Check that the link in the subscriptions column send you to the search page with the subscriptions linked to this record 7c) Check that there is a button "Select without subscription" in the toolbar that selects record with no subscription attached 8) Sign off Signed-off-by: Frank Hansen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:53:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:53:52 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:57:02 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #38 from Jonathan Druart --- Nick, I was wondering this morning (bug 29474 comment 9) if _CanBookBeAutoRenewed shouldn't actually call GetSoonestRenewDate. There is also bug 29537 that will conflict with this. Could we have a clean tree we could test and QA together? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:57:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:57:46 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #39 from Jonathan Druart --- Forget the second part, it's in the dependency tree already! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:58:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:58:50 +0000 Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment type required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119509|0 |1 is obsolete| | --- Comment #5 from Thibaud Guillot --- Created attachment 128166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128166&action=edit Bug 28138: Add syspref to make the payment type required The payment type is already required when using the cash register feature, but some users want to force selecting a payment type even when cash registers are not used The new system preference name is RequirePaymentType Test plan: 1. Apply patch and run updatedatabase.pl 2. Disable UseCashRegisters and RequirePaymentType sysprefs 3. Create some authorised values in PAYMENT_TYPE category if needed 4. Create a manual invoice and pay it. Notice that the payment type is optional. 5. Enable RequirePaymentType 6. Create a manual invoice and pay it. Notice that the payment type is now required. 7. Enable UseCashRegisters and verify that the payment type is always required, even if RequirePaymentType is disabled Rebased by Thibaud Guillot on 21-12-02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 14:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 13:59:59 +0000 Subject: [Koha-bugs] [Bug 28138] Add system preference to make the payment type required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28138 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:04:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:04:26 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:04:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:04:30 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127964|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 128167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128167&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. Signed-off-by: Barbara Johnson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:04:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:04:35 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #5 from Jonathan Druart --- Created attachment 128168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128168&action=edit Bug 29528: Surround strings with span Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:05:26 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |24387 Keywords| |rel_21_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:05:26 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 [Bug 29528] Breadcrumbs on HTML customizations take you to news -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:09:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:09:17 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:15:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:15:26 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- I will amend the patch with - ) unless scalar @{$sets} > 0; + ) unless @$sets; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:23:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:23:39 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #6 from Jonathan Druart --- $ cpanm HTTP::OAIPMH::Validator This fails for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:24:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:24:04 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:24:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:24:08 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127995|0 |1 is obsolete| | Attachment #127996|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 128169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128169&action=edit Bug 29484: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:24:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:24:12 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #8 from Jonathan Druart --- Created attachment 128170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128170&action=edit Bug 29484: Make ListSets return noSetHierarchy when no sets defined This simple patch makes our OAI-PMH server return the appropriate error code when no sets are defined. To test: 1. Apply the regression tests 2. Run: $ kshell k$ t/db_dependent/OAI/Server.t => FAIL: Tests fail. Boo! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! YAY! 5. Sign off :-D Bonus: you can check with the tool mentioned on the bug report, that the error is gone. No sets need to be defined. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind JD amended patch - ) unless scalar @{$sets} > 0; + ) unless @$sets; Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:25:33 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > I will amend the patch with > - ) unless scalar @{$sets} > 0; > + ) unless @$sets; Why? I prefer what I wrote and have been adding it all the time. If it makes more sense to do it your way, we should make sure it is in the guidelines. I still prefer to have the reader understand we are talking about the list size. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:31:27 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #20 from Frank Hansen --- Signed off using sandbox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:32:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:32:07 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk at ckls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:38:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:38:43 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:38:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:38:45 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:38:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:38:48 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127996|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:38:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:38:51 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127995|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:39:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:39:28 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #9) > (In reply to Jonathan Druart from comment #5) > > I will amend the patch with > > - ) unless scalar @{$sets} > 0; > > + ) unless @$sets; > > Why? I prefer what I wrote and have been adding it all the time. If it makes > more sense to do it your way, we should make sure it is in the guidelines. I > still prefer to have the reader understand we are talking about the list > size. ok, reverted. @$sets does exactly what you are describing, just less verbose. Nevermind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:49:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:49:08 +0000 Subject: [Koha-bugs] [Bug 29161] Holds to pull should show item level holds only if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 --- Comment #3 from Nick Clemens --- Created attachment 128171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128171&action=edit Bug 29161: POC This is messy - our listing of holds only grabs the first, so we cannot tell whether we have both itemnumber and biblionumber holds. This patch removes the limit on priority one, then checks in get_items_that_can_fill for both item level and title level holds. I don't know how this affects the grouping for display We also only deal with one hold at a time on this report - if there are several title level holds, we only see it once, I guess fine, you fill that, run the report, fill the second Test plan below fails To test: 1 - Place an item level hold on a biblio with multiple items 2 - Run Holds to pull 3 - The hold shgows - okay 4 - Checkout the item with the hold to another patron 5 - The holds shows - not okay 6 - Apply patch 7 - The hold no longer shows 8 - Place a title level hold 9 - That hold shows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:54:50 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:54:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:54:55 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128016|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 128172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128172&action=edit Bug 29530: Fix handling of NumSavedReports preference in reports table This patch updates the way the NumSavedReports preference value is used on the saved reports page so that the setting is correctly incorporated into the DataTable. The patch also expands the description of the NumSavedReports preference in order to clarify the expected behavior when no value is saved. To test, apply the patch and go to Administration -> System preferences and note the value of NumSavedReports. - Go to Reports -> Use saved. - Confirm that the first page of saved reports shows the number specified in NumSavedReports. - In the "Show" dropdown menu, confirm that the number from NumSavedReports is preselected by default. - Expand the dropdown menu to confirm that the NumSavedReports number is positioned sequentially with the default values. For example, if NumSavedReports = "78," the menu options should be "10, 20, 50, 78, 100, All". - Test with various values of NumSavedReports. A blank value should result in the "All" option being selected. A non-numeric or non-positive value should result in the default set of options being used ("10, 20, 50, 100, All"). Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:55:21 +0000 Subject: [Koha-bugs] [Bug 29621] New: Add link for Lists on opac-detail.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Bug ID: 29621 Summary: Add link for Lists on opac-detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:56:55 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- It's working but we need to make this code generic. First the NumSavedReports syspref should be removed in favour of the "default display length" table setting we now have. Then it would be actually great to make this setting work for all the tables, everywhere KohaTable is used. Owen, is that something you would like to work on? I could help of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 15:57:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 14:57:46 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #40 from Nick Clemens --- (In reply to Jonathan Druart from comment #38) > Nick, I was wondering this morning (bug 29474 comment 9) if > _CanBookBeAutoRenewed shouldn't actually call GetSoonestRenewDate. Can you elaborate? We pass the soonest renew date now, rather than calling twice, why do we need to call directly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:00:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:00:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78023|application/xml |application/mrc mime type| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:01:06 +0000 Subject: [Koha-bugs] [Bug 29622] New: Add link for Lists to staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29622 Bug ID: 29622 Summary: Add link for Lists to staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the staff interface on search.pl and detail.pl it would be helpful if it was possible to see if a title is contained in a List. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:01:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:01:52 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78023|application/mrc |application/xml mime type| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:17:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:17:11 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #10) > (In reply to Tomás Cohen Arazi from comment #9) > > (In reply to Jonathan Druart from comment #5) > > > I will amend the patch with > > > - ) unless scalar @{$sets} > 0; > > > + ) unless @$sets; > > > > Why? I prefer what I wrote and have been adding it all the time. If it makes > > more sense to do it your way, we should make sure it is in the guidelines. I > > still prefer to have the reader understand we are talking about the list > > size. > > ok, reverted. > > @$sets does exactly what you are describing, just less verbose. Nevermind. I like your approach, is more Perl-ish, and we should adopt it as a guideline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:17:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:17:52 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > 3. Shouldn't we finally call GetSoonestRenewDate from _CanBookBeAutoRenewed? This is what you actually did on the patch "Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:18:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:18:34 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #41 from Jonathan Druart --- (In reply to Nick Clemens from comment #40) > (In reply to Jonathan Druart from comment #38) > > Nick, I was wondering this morning (bug 29474 comment 9) if > > _CanBookBeAutoRenewed shouldn't actually call GetSoonestRenewDate. > > Can you elaborate? We pass the soonest renew date now, rather than calling > twice, why do we need to call directly? Sorry, I meant bug 29476 comment 9. And it's actually what Joonas did here in the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:19:35 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |kyle at bywatersolutions.com Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:26:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:26:08 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #42 from Jonathan Druart --- I agree with most of the changes, but I don't think it's a good idea to pass the issuing rules and the "soonest date". It's just hiding problem with the code, which shouldn't be resolved that way. For instance if we are facing perf issues with the fetch of the circ rules, we should then cache them. Other areas would benefit from that kind of change. Code will stay clean and we wouldn't need write acrobatic code in this C4::Circ module, it does not need that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:31:03 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 128173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128173&action=edit Bug 29620: Move the OpenAPI spec to YAML format This patch moves all the REST API spec pieces into YAML. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:31:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:31:10 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 128174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128174&action=edit Bug 29620: (follow-up) Rename remaining old-style parameters The first routes we added named parameters in camelCase. We moved to snake_case really fast, but there are two that were kept by mistake. This patch fixes them. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:32:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:32:03 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #3 from Tomás Cohen Arazi --- If we agree with this, it should be pushed early this cycle. To allow people to produce their patches on top of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:10 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:14 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125698|0 |1 is obsolete| | Attachment #125699|0 |1 is obsolete| | Attachment #125700|0 |1 is obsolete| | Attachment #125701|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 128175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128175&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Michael Sutherland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:17 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #18 from Nick Clemens --- Created attachment 128176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128176&action=edit Bug 27138: (follow-up) Embed host items when performing index from command line The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex To test: 0 - Follow previous test plan to setup records and set search engine to elasticsearch 1 - perl misc/search_tools/rebuild_elasticsearch.pl -d 2 - Search for the barcode and confirm both records are returned 3 - Confirm the host items are included in the results Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Michael Sutherland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:21 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #19 from Nick Clemens --- Created attachment 128177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128177&action=edit Bug 27138: Add preference EmbedHostItemsInSearchEngine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:24 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #20 from Nick Clemens --- Created attachment 128178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128178&action=edit Bug 27138: Import needed subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:28 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #21 from Nick Clemens --- Created attachment 128179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128179&action=edit Bug 27138: (follow-up) Remove extraneous require and use Koha::Items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:33:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:33:56 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #43 from Jonathan Druart --- And... thinking loud, sorry for the noise if it does not make sense. There is a _CanBookBeAutoRenewed sub but we are still doing "auto renewal" related checks in CanBookBeRenewed. It should be simpler than that actually, we should call _CanBookBeAutoRenewed that will call CanBookBeRenewed, not the reverse. Ideally Koha::AutoRenewalHold inherit from Koha::Hold Koha::AutoRenewalHold->can_be_renewed will do its specific check for auto renew then can SUPER::can_be_renewed Aren't we actually doing the reverse here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:35:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:35:53 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Carolyn Hughesman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman at cclsny.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 16:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 15:52:03 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #44 from Nick Clemens --- (In reply to Jonathan Druart from comment #42) > I agree with most of the changes, but I don't think it's a good idea to pass > the issuing rules and the "soonest date". It's just hiding problem with the > code, which shouldn't be resolved that way. > > For instance if we are facing perf issues with the fetch of the circ rules, > we should then cache them. Other areas would benefit from that kind of > change. Code will stay clean and we wouldn't need write acrobatic code in > this C4::Circ module, it does not need that :) I see your point, however, in this instance _CanBookBeAutoRenewed is just a helper function here, moved out to make the logic easier to read. Passing variables we are fetching that are common to both routines seems logical to me. It's not so much that there is a perf problem fetching them, but that we are fetching the same data here multiple times (In reply to Jonathan Druart from comment #43) > And... thinking loud, sorry for the noise if it does not make sense. > > There is a _CanBookBeAutoRenewed sub but we are still doing "auto renewal" > related checks in CanBookBeRenewed. It should be simpler than that actually, > we should call _CanBookBeAutoRenewed that will call CanBookBeRenewed, not > the reverse. > > Ideally > Koha::AutoRenewalHold inherit from Koha::Hold > Koha::AutoRenewalHold->can_be_renewed will do its specific check for auto > renew then can SUPER::can_be_renewed > I assume you mean 'Issue' not 'Hold' > Aren't we actually doing the reverse here? Automatic renewals and renewals are not discrete - a regular renewal block will prevent auto_renewal and is cheaper to check the simple bits first - it makes sense to go through the simple renewal checks that will block, before checking the auto_renewal blocks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:19:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:19:02 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:19:19 +0000 Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:30:45 +0000 Subject: [Koha-bugs] [Bug 29623] New: Cache circulation rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Bug ID: 29623 Summary: Cache circulation rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We could cache the circulation rules (in memory/L1) to speed up areas where they are fetched several times (in a loop). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:31:27 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #1 from Jonathan Druart --- Created attachment 128180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128180&action=edit Bug 29623: Cache circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:31:45 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29537 Status|ASSIGNED |In Discussion Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:31:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:31:45 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 [Bug 29623] Cache circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:32:28 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #45 from Jonathan Druart --- (In reply to Jonathan Druart from comment #42) > For instance if we are facing perf issues with the fetch of the circ rules, > we should then cache them. Other areas would benefit from that kind of > change. Code will stay clean and we wouldn't need write acrobatic code in > this C4::Circ module, it does not need that :) I've attached a patch on bug 29623, for discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:32:35 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29623 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:32:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:32:35 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29474 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:34:32 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Jonathan Druart --- Nick, that would be helpful if you could run the same tests as you did on bug 29474 comment 9, to see if we can gain more caching the circ rules in L1. This patch is absolutely not ready to be integrated into master but I would like to get some opinions about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:43:04 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #46 from Jonathan Druart --- (In reply to Nick Clemens from comment #44) > (In reply to Jonathan Druart from comment #42) > > Ideally > > Koha::AutoRenewalHold inherit from Koha::Hold > > Koha::AutoRenewalHold->can_be_renewed will do its specific check for auto > > renew then can SUPER::can_be_renewed > > > I assume you mean 'Issue' not 'Hold' Of course! I actually replaced "Issue" with "Hold" instead of "Checkout", erk! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 17:51:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 16:51:51 +0000 Subject: [Koha-bugs] [Bug 29268] Query used in Koha::Biblio->get_marc_host is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29268 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:12:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:12:07 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128169|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:12:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:12:21 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128170|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:12:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:12:39 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:13:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:13:15 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:13:17 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:13:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:13:19 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 18:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 17:43:04 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Amy Schapiro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy at bywatersolutions.com --- Comment #7 from Amy Schapiro --- According to the most recent MARC rules at LOC - https://www.loc.gov/marc/bibliographic/bd505.html Two hyphens are the appropriate way to separate these fields. Thanks everyone! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 19:03:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 18:03:09 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- It would be good to also log permission changes via Koha::Logger with a namespace so these changes can be logged to external facilities. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 19:26:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 18:26:12 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 --- Comment #1 from David Gustafsson --- Created attachment 128181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128181&action=edit Bug 29597: Add tomarcplugin option to bulkmarcimport.pl Add tomarcplugin option to bulkmarcimport script. To test: 1) Place ToMarcExample.pm in a Koha plugin directory at Koha/Plugin/ToMarcExample.pm and make sure its enabled and installed in Koha 2) Import some biblio with ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -n=1 -tomarcplugin="Koha::Plugin::ToMarcExample" 3) For the imported biblio, check that field 590a has been populated with the value 'ToMarcExample added field' Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 19:29:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 18:29:57 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 --- Comment #2 from David Gustafsson --- Created attachment 128182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128182&action=edit ToMarcExample.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 19:35:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 18:35:42 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #27 from David Gustafsson --- Discovered looks like there is encoding issues with "biblios.mrc", double encoded most likely, I suspect the file was re-encoded either on download/upload as the original file correctly encoded. If requested I can upload another file and tar it beforehand. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 20:41:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 19:41:29 +0000 Subject: [Koha-bugs] [Bug 29624] New: ITEMTYPECAT Icons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29624 Bug ID: 29624 Summary: ITEMTYPECAT Icons Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: eliana at flo.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We can set custom itype icons for Administration > Item Types but not for Administration > Authorized Values > ITEMTYPECAT. This means that some of the itype icons that display in the search results differ from the icons that show up in our advanced search. We use JS to fix this, but it would be nice if it was a built-in option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 21:21:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 20:21:59 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #4 from Heather --- We're on 21.05, and the item search is the *only* place where Library of Congress call numbers are sorting correctly. I'm a little confused about your example, too--are the call numbers in your example Library of Congress call numbers, or call numbers in a different classification system? Library of Congress call numbers' initial alpha-numeric sequence are decimals after the period, so there wouldn't be a call number, "QA76.760" because this is the same as "QA76.76"--Library of Congress call numbers never end with a zero after the decimal. If it were a call number used locally, this sorting is correct: > Call Numbers in Item search results seem to be sorted ALPHABETICALLY, so > currently it is displayed: > QA76.76 > QA76.760 > QA76.77 The filing rule for this, if I remember correctly, is covered in the Library of Congress Filing Rules, illustrated by this example, where the absence of a character comes before the presence of a character--that is, "nothing comes before something:" A is for anatomy A4D desert speed run So this isn't correct, for Library of Congress call numbers: > where the results should be shown in the following order: > QA76.76 > QA76.77 > QA76.760 Because "point seven six zero" is less than "point seven seven." But if these aren't Library of Congress call numbers, then the sorting would be different? The LC Filing Rules say, "Arrange numerals after a decimal point digit by digit, one place at a time." So, also, ".760" can't come after ".77," if you're arranging digit-by-digit, one place at a time. (This is in section 14 of https://www.loc.gov/catdir/cpso/G100.pdf ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 22:30:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 21:30:10 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #365 from Aleisha Amohia --- Hi everyone, I'll try to fix the patches today! Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 22:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 21:32:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #366 from Michal Denar --- Great news, Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 22:38:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 21:38:35 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- A check to search_for_data_inconsistencies.pl +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 22:42:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 21:42:22 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 22:47:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 21:47:11 +0000 Subject: [Koha-bugs] [Bug 29564] Use List::MoreUtils so SIP U16/Xenial does not break In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29564 --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- (In reply to Victor Grousset/tuxayo from comment #14) > Nope, it was a regression due to bug 29264 so you dodged a bullet ^^ Cool, I thought that was the case. Thank you!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:21:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:21:15 +0000 Subject: [Koha-bugs] [Bug 29625] New: Wrong var name in Koha::BiblioUtils get_all_biblios_iterator Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Bug ID: 29625 Summary: Wrong var name in Koha::BiblioUtils get_all_biblios_iterator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In Koha::BiblioUtils, get_all_biblios_iterator method is a class level method like get_from_biblionumber. So its first arg should be named $class instead of $self. Even if this var in not used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:21:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:21:29 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:23:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:23:38 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:23:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:23:42 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 --- Comment #1 from Fridolin Somers --- Created attachment 128183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128183&action=edit Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator In Koha::BiblioUtils, get_all_biblios_iterator method is a class level method like get_from_biblionumber. So its first arg should be named $class instead of $self. Even if this var in not used. Test plan : 1) Run Elasticsearch full rebuild with and without patch 2) Check all biblio records are in index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:32:04 +0000 Subject: [Koha-bugs] [Bug 29626] New: Map biblioitems.place to 264$a by default Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 Bug ID: 29626 Summary: Map biblioitems.place to 264$a by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In Administration > Koha to MARC mappings, biblioitems.place is currently only mapped to 260$a. I propose we also link to 264$a as RDA uses that MARC field rather than 260. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:32:13 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21705 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:32:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:32:13 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29626 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:35:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:35:51 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Map biblioitems.place to |Map biblioitems.place to |264$a by default |264$a by default (MARC21) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:47:21 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:47:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:47:24 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 128184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128184&action=edit Bug 29626: Map biblioitems.place to 264 by default (MARC21) This patch adds a mapping from 264 to biblioitems.place. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblioitems.place - biblioitems.place should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblioitems entry for this record, the value from 264 should be in place 7) Create a bibliographic record with a value un 260 - In the database, check the biblioitems entry for this record, the value from 260 should be in place I hope I didn't forget anything! :) Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:50:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:50:53 +0000 Subject: [Koha-bugs] [Bug 29627] New: Map biblioitems.publishercode to 264$b by default (MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 Bug ID: 29627 Summary: Map biblioitems.publishercode to 264$b by default (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In Administration > Koha to MARC mappings, biblioitems.publishercode is currently only mapped to 260$b. I propose we also link to 264$b as RDA uses that MARC field rather than 260. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:54:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:54:57 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:54:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:54:59 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 128185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128185&action=edit Bug 29627: Map biblioitems.publishercode to 264 by default (MARC21) This patch adds a mapping from 264 to biblioitems.publishercode. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblioitems.publishercode - biblioitems.publishercode should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblioitems entry for this record, the value from 264 should be in publishercode 7) Create a bibliographic record with a value un 260 - In the database, check the biblioitems entry for this record, the value from 260 should be in publishercode I hope I didn't forget anything! :) Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:55:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:55:40 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29626 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:55:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:55:40 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29627 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:55:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:55:53 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21705 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:55:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:55:53 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29627 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:59:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:59:23 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 2 23:59:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 22:59:26 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 128186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128186&action=edit Bug 21705: Map copryrightdate to both 260/264c by default for new MARC21 installations This patch adds a mapping from 264 to biblio.copyrightdate. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblio.copyrightdate - biblioitems.publishercode should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate 7) Create a bibliographic record with a value un 260 - In the database, check the biblio entry for this record, the value from 264 should be in copyrightdate I hope I didn't forget anything! :) Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 00:22:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 23:22:06 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > We share Pay, W and LOST - W was a lot in our database, maybe this could be > the first to focus on? Sure, sounds good to me. CREDIT: - LOST DEBIT: - Pay - W -- I've taken a look at a 19.11 database: - it looks like "Unexpected type found during upgrade" appears for "W" - there's no evidence of a "Pay" type. - In this case "LOST" is shown as a debit type with a description of "Lost Item" and is marked "is_system". -- Looking at a 20.11 database, I see "LOST" as as a debit and neither "W" nor "Pay" exist. (But this database doesn't have any accountlines...) -- Looking at older databases and the tables "account_credit_types" and "account_debit_types" don't exist... Looking now at Bug 23049... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 00:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 23:30:45 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #11 from Michael Hafen --- (In reply to Jonathan Druart from comment #10) > Can you provide tests, please? Looking through the db_dependent/Overdues.t file I notice that Koha expects a new fine to be generated if an overdue book is renewed and then becomes overdue again. This complicates things since a book renewed just after the cronjob starts could look like it was renewed previously and became overdue again. Now I'm trying to think of how to tell the difference between a book renewed a couple weeks ago (for example) and a book renewed after the cronjob started. Does the cronjob/fines.pl script need to pull the fines status again just before updating the fine to make sure the status hasn't changed, instead of changing how C4::Overdues::UpdateFine() handles status? But then we'd have to make the cronjob lock the database at the point of refreshing the status and updating the fine; otherwise we've only reduced the window on the race condition (to nearly nil). Or is the very small chance of a race condition good enough? (I don't think it is, but I don't like locking the database during operating hours either.) I'm going to chose the locking option, and make a new patch to do that. (Bonus, I don't have to write a test case ;) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 00:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 23:55:59 +0000 Subject: [Koha-bugs] [Bug 29132] API access denied after update to 19.11.22 due to not executed atomicupdate for api keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29132 --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Cool, yes this will be in 19.11.24. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 00:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Dec 2021 23:56:56 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #6 from David Cook --- (In reply to David Cook from comment #5) > CREDIT: > - LOST > > DEBIT: > - Pay > - W I think Martin might be best placed to comment on this one as I think he authored the changes... If we look at the database update for 19.06.00.044, it looks like the values in accountlines were updated as follows: W -> WRITEOFF Pay -> PAYMENT Yikes... looking at the accountlines on a 19.11 system and it's a mess. In one example, the user has 2 debits of $80 and the balance is 0. The W is a Writeoff which should've been a credit to balance the account. The LOST fee is from May 2016 and the writeoff is June 2017. Don't know if that's significant. Must've been a bug back then that never got fixed quite right. -- My 21.05 system started as a 16.11 system I think, so the problem was between 16.11 and 19.11 it seems. -- But yeah... as Martin suggests at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532#c1 the solution isn't obvious... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:04:32 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #7 from David Cook --- I think overall the math is probably correct - otherwise we'd have a lot of upset people. My advice to libraries so far has been to uncheck the "Can be manually added" box, and add a corresponding description of 'Writeoff', 'Payment', 'Credit', etc. They'll appear in legacy accountlines but won't be able to be added going forward. It sucks but it might be the best we can do without trying to re-write years of accounting data... ...but I also never touch Koha's accounting code, so hopefully Martin or Kyle have a better idea than me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:22:52 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC| |wainuiwitikapark at catalyst.n | |et.nz Version(s)|21.11.00,21.05.05,20.11.12, |21.11.00,21.05.05,20.11.12, released in|20.05.18 |20.05.18,19.11.24 --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Backported: Pushed to 19.11.x branch for 19.11.24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:26:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:26:48 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127851|0 |1 is obsolete| | Attachment #127852|0 |1 is obsolete| | --- Comment #12 from Michael Hafen --- Created attachment 128187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128187&action=edit Proposed fix in cronjobs/fines.pl This changes cronjobs/fines.pl instead of C4/Overdues.pm Test plan: 1. find an overdue fine near the end of the list of overdue fines that cronjobs/fines.pl will be considering. 2. start cronjobs/fines.pl. 3. immediately check in or renew the overdue book. 4. once fines.pl is finished observe that a duplicate overdue fine has been created on the patrons account. 5. apply patch. 6. repeat 1 - 4 and observe that the duplicate fine was not created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:28:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:28:41 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:29:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:29:13 +0000 Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits when they shouldn't be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook --- I wonder if we should rename this bug and open a new one with this name, since this technically is still an on-going problem... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:30:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:30:38 +0000 Subject: [Koha-bugs] [Bug 29300] Release team 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29300 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |19.11.24 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #21 from wainuiwitikapark at catalyst.net.nz --- Backported: Pushed to 19.11.x branch for 19.11.24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:39:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:39:10 +0000 Subject: [Koha-bugs] [Bug 28904] Update information on Newsletter editor on about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28904 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12, |21.11.00,21.05.05,20.11.12, released in|20.05.18 |20.05.18,19.11.24 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #24 from wainuiwitikapark at catalyst.net.nz --- Backported: Pushed to 19.11.x branch for 19.11.24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:45:18 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #15 from David Cook --- (In reply to Tomás Cohen Arazi from comment #13) > - I read a comment from dcook somewhere else, and it felt like he found a > bug that made the form send empty pickup locations, that actually hit the > DB, that'd be a bug, not a usability discussion. Yeah I was thinking the same thing. We could throw an exception client-side or server-side (or both). (In reply to Tomás Cohen Arazi from comment #14) > And making a default selection is good too. I think this would be a good first step, since it requires only a small change and brings multiholds in line with require holds I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:49:05 +0000 Subject: [Koha-bugs] [Bug 29628] New: purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 Bug ID: 29628 Summary: purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently if a logged in location has suggestions at that branch we will show some like: Suggestions pending approval: Centerville: 1 / All libraries: 2 But if the logged in branch has 0 suggestions we display nothing. Many librarians find this a bit confusing and would prefer, if there are any suggestions systemwide, to show something like: Suggestions pending approval: Centerville: 0 / All libraries: 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:59:00 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:59:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:59:03 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #1 from Lucas Gass --- Created attachment 128188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128188&action=edit Bug 29628: Show purchase suggestion link when there are any suggestions systemwide To test: 1. Make some purchase suggestions at different branches. 2. Log in to a branch with a suggestion and visit /cgi-bin/koha/mainpage.pl 3. See something like: Suggestions pending approval: Centerville: 1 / All libraries: 2 4. Log into a branch with no suggestions, no link about suggestions 5. Apply patch 6. Repeat step 2, and still see something like: Centerville: 1 / All libraries: 2 7. Try a branch with no suggestions, now you see a link like: Centerville: 0 / All libraries: 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 01:59:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 00:59:17 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 02:36:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 01:36:53 +0000 Subject: [Koha-bugs] [Bug 23693] More Languages needed for OPAC advanced search Languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23693 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:08:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:08:12 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:32:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:32:25 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:32:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:32:32 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120643|0 |1 is obsolete| | --- Comment #367 from Aleisha Amohia --- Created attachment 128189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128189&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:32:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:32:41 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120644|0 |1 is obsolete| | --- Comment #368 from Aleisha Amohia --- Created attachment 128190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128190&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:32:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:32:49 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120645|0 |1 is obsolete| | --- Comment #369 from Aleisha Amohia --- Created attachment 128191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128191&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:32:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:32:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120646|0 |1 is obsolete| | --- Comment #370 from Aleisha Amohia --- Created attachment 128192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128192&action=edit Bug 15516: Schema updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120647|0 |1 is obsolete| | --- Comment #371 from Aleisha Amohia --- Created attachment 128193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128193&action=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120648|0 |1 is obsolete| | --- Comment #372 from Aleisha Amohia --- Created attachment 128194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128194&action=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120649|0 |1 is obsolete| | --- Comment #373 from Aleisha Amohia --- Created attachment 128195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128195&action=edit Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120651|0 |1 is obsolete| | --- Comment #374 from Aleisha Amohia --- Created attachment 128196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128196&action=edit Bug 15516: (follow-up) Fixing file permissions and title elements order Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121523|0 |1 is obsolete| | --- Comment #375 from Aleisha Amohia --- Created attachment 128197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128197&action=edit Bug 15516: Fix shebang in hold-group.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121623|0 |1 is obsolete| | --- Comment #376 from Aleisha Amohia --- Created attachment 128198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128198&action=edit Bug 15516: (follow-up) Count group holds always -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:33:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122097|0 |1 is obsolete| | --- Comment #377 from Aleisha Amohia --- Created attachment 128199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128199&action=edit Bug 15516: Fix hold groups for multi items for one bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:34:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:34:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122102|0 |1 is obsolete| | --- Comment #378 from Aleisha Amohia --- Created attachment 128200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128200&action=edit Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:34:09 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122627|0 |1 is obsolete| | --- Comment #379 from Aleisha Amohia --- Created attachment 128201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128201&action=edit Bug 15516: Show user's hold groups to user via OPAC This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:34:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:34:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #380 from Aleisha Amohia --- Created attachment 128202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128202&action=edit Bug 15516: (follow-up) Prevent cancelling unintended holds And a fix for consistent TT code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 03:45:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 02:45:01 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #26 from Victor Grousset/tuxayo --- > I guess a backport to 19.11 is unlikely at this stage in its lifecycle Indeed 19.11.x is still supported but only for security fixes. But the main issues is to be able to make a working backport. See comment 22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 06:53:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 05:53:46 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 07:57:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 06:57:24 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 08:01:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 07:01:29 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Passed QA |Pushed to master --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 08:03:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 07:03:07 +0000 Subject: [Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 08:07:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 07:07:37 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 08:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 07:27:37 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 --- Comment #8 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #7) > Pushed to master for 22.05, thanks to everybody involved! Where to ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 08:34:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 07:34:48 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #8) > (In reply to Fridolin Somers from comment #7) > > Pushed to master for 22.05, thanks to everybody involved! > > Where to ? Found it. Test was still running.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:02:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:02:52 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:06:41 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 --- Comment #8 from Marcel de Rooy --- Jonathan: Here is what makes the difference (yes it is confusing at least): MARC21slim2MODS.xsl contains This is our include that contains the template named part. But MARC21slim2MADS.xsl contains This is NOT our include, but the LOC one. And it does not include a template named part. Etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:07:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:07:02 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 --- Comment #9 from Marcel de Rooy --- (In reply to Owen Leonard from comment #6) > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl > > This seems to be an authority record export format which can be tested by > viewing an authority in the staff interface and choosing Save -> MADS. The > export appears to work correctly. > > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl > > This seems to be a bibliographic record export format which can be tested by > viewing a bibliographic record in the staff interface and choosing Save -> > MODS. The export appears to work correctly. > > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl > > These two files appear to be unused. I could only find references to them in > .po files. Thanks for checking. See former comment too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:09:00 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 --- Comment #10 from Marcel de Rooy --- What does not help either, is that opac/unapi runs INTRANET xslt sheets: sub get_xslt_file { my ($format, $format_to_stylesheet_map, $format_info) = @_; $format = lc $format; my $marcflavour = uc(C4::Context->preference('marcflavour')); return unless $format_to_stylesheet_map->{$marcflavour}->{$format}; my $xslt_file = C4::Context->config('intrahtdocs') . "/prog/en/xslt/" . $format_to_stylesheet_map->{$marcflavour}->{$format}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:11:24 +0000 Subject: [Koha-bugs] [Bug 29629] New: Remove two unused intranet XSLT sheets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Bug ID: 29629 Summary: Remove two unused intranet XSLT sheets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 29556: Owen discovered: > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl These two files appear to be unused. I could only find references to them in .po files. Lets remove them here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:12:11 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29629 --- Comment #11 from Marcel de Rooy --- (In reply to Owen Leonard from comment #6) > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl > > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl > > These two files appear to be unused. I could only find references to them in > .po files. Lets remove them on bug 29629. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:12:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:12:11 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29556 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:18:51 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:18:55 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 --- Comment #1 from Marcel de Rooy --- Created attachment 128203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128203&action=edit Bug 29629: Remove two unused MODS XSLT stylesheets Follow-up of bug 29556. With thanks to Owen for checking. > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl > These two files appear to be unused. I could only find references to them in .po files. Test plan: git grep MARC21slim2MODS32 git grep MARC21slim2MODS3 Skip the misc/translator/po references. Note in the second grep that you only see that MODS3-1 is used in unapi and C4::Record. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:19:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:19:19 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|Needs Signoff |Signed Off --- Comment #2 from Marcel de Rooy --- Trivial: self signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:19:33 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet MODS XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove two unused intranet |Remove two unused intranet |XSLT sheets |MODS XSLT sheets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:26:53 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #26 from Marcel de Rooy --- I wouldnt try to run this LOL SELECT borrowernumber FROM borrowers WHERE borrowers.userid = accountlines.manager_id ) WHERE credit_type_code = 'CANCELLATION'' Double WHERE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:35:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:35:06 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128115|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 128204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128204&action=edit Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI The error pages wrote a HTTP status code of 200 for all PSGI requests, even though it should have only done it for PSGI requests from the ErrorDocument middleware. This patch fixes that. 0) Do not apply patch 1) Open F12 dev tools and go to Network tab 2) Go to http://localhost:8081/files/blah 3) Note that the webpage is a 404 error but HTTP status code is 200 4) Go to http://localhost:8081/cgi-bin/koha/circ/blah 5) Note that the webpage is a 404 error and HTTP status code is 404 6) Apply patch 7) Go to http://localhost:8081/files/blah 8) Note that the webpage is a 404 error and HTTP status code is 404 9) Go to http://localhost:8081/cgi-bin/koha/circ/blah 10) Note that the webpage is a 404 error and HTTP status code is 404 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:35:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:35:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #381 from Michal Denar --- Hi Aleisha, I just tested the new patches. Everything seems to be working, but the model is empty in all places after clicking on "hold Group". https://prnt.sc/21iwwv5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:36:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:36:24 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize --- This all works as expected for me now, no regressions found. Thanks for finding some time to fit this in David. :) I'd love to see a follow-up bug later to use the new function to replace the various places we look for a psgi/plack app already.. but that can certainly wait. Nice work, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 09:44:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 08:44:59 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #27 from Marcel de Rooy --- Another try to get this further ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:03:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:03:48 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #28 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #26) > I wouldnt try to run this LOL > > SELECT borrowernumber FROM borrowers WHERE borrowers.userid = > accountlines.manager_id ) WHERE credit_type_code = 'CANCELLATION'' > > Double WHERE Sorry, reading half the line or something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:13:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:13:24 +0000 Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Christophe TORIN changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:13:37 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Christophe TORIN changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:14:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:14:03 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Christophe TORIN changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:15:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:15:41 +0000 Subject: [Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:16:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:16:11 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:20:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:20:37 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #27 from Alexander Borkowski --- Applying only attachments 114508 and 114509 went without problems and resolved the issue for our 19.11.23 installation. I think attachment 114510 which gave problems in comment 22 is not necessary for 19.11 as the return value of Koha::Account::pay changed only in attachment 100185 to bug 23501 which was not backported to 19.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:27:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:27:45 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #29 from Marcel de Rooy --- This seems like overkill. But it worked for me without CAST warnings etc on alphanumeric userid's : UPDATE accountlines LEFT JOIN borrowers ON CAST(borrowers.userid AS INT) = accountlines.manager_id SET manager_id = borrowers.borrowernumber WHERE manager_id IS NOT NULL AND userid RLIKE "^[0-9]+$" AND borrowers.borrowernumber IS NOT NULL AND credit_type_code = 'CANCELLATION' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:28:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:28:44 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #30 from Marcel de Rooy --- Note that the idea is just to list these SQL updates here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:31:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:31:24 +0000 Subject: [Koha-bugs] [Bug 28645] write off fine on selected items does not pay against those lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28645 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se --- Comment #4 from Alexander Borkowski --- As we ran into the same issue on 19.11.23 and the patches in bug 26356 fixed it for us as well I think it is safe to say this is a duplicate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:34:03 +0000 Subject: [Koha-bugs] [Bug 28645] write off fine on selected items does not pay against those lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28645 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Alexander Borkowski --- *** This bug has been marked as a duplicate of bug 26356 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:34:03 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com --- Comment #12 from Alexander Borkowski --- *** Bug 28645 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:36:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:36:18 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prior to this patch release notes| |inadvertently the field | |borrowers.userid was used | |to fill | |accountslines.manager_id. | |This should have been | |borrowernumber. | | | |This | |report fixes that. The | |dbrev will count the number | |of missing or bad | |manager_id's in | |cancellation records and | |report them. It refers to | |this report for optional | |sql updates to fix or clear | |the records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:37:12 +0000 Subject: [Koha-bugs] [Bug 28645] write off fine on selected items does not pay against those lines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28645 --- Comment #6 from Alexander Borkowski --- Wrong bug number, bug 26536 is correct. Sorry. *** This bug has been marked as a duplicate of bug 26536 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:37:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:37:12 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com --- Comment #28 from Alexander Borkowski --- *** Bug 28645 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:53:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:53:49 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #1 from Kevin Carnes --- Created attachment 128205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128205&action=edit [PATCH] Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:56:13 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #31 from Marcel de Rooy --- NOTE: This comment is referred to from the db revision of this report ! If you come here since a Koha upgrade referred you to this place, you have two options: (1) try to correct the incorrect manager_id's or (2) clear the incorrect manager_id's. A suggestion beforehand: Make a SQL dump before running the SQL updates below on your (production) data. OPTION 1 CORRECT In the more exceptional case that your records contain a numeric manager_id which actually is a USERID (read: user code) and NOT a borrowernumber, you may want to run this sql statement: UPDATE accountlines LEFT JOIN borrowers ON CAST(borrowers.userid AS INT) = accountlines.manager_id SET manager_id = borrowers.borrowernumber WHERE manager_id IS NOT NULL AND userid RLIKE "^[0-9]+$" AND borrowers.borrowernumber IS NOT NULL AND credit_type_code = 'CANCELLATION' OPTION 2 CLEAR Use this SQL statement to correct records with a wrong wrong manager_id, setting them to NULL: UPDATE accountlines SET manager_id = NULL WHERE manager_id IS NOT NULL AND credit_type_code = 'CANCELLATION' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 10:56:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 09:56:17 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 --- Comment #2 from Kevin Carnes --- Created attachment 128206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128206&action=edit Bug 29012: Add default values for blank circulation rules that weren't saved to the database There are 5 fields that are not set if no value is provided when saving/editing a rule in Administration->Circulation and fines rules - issuelength - hardduedate - unseenrenewalsallowed - rentaldiscount - decreaseloanholds This is problematic because it gives the impression these rules are set as blank, but in reality they don't exist and the rule will fal back to the higher level To test: 1 - Set a rule for Patron category: Teacher Itemtype: All Hard due date: (Today) Lona period: 10 2 - Set a rule for Patron category: Teacher Itemtype: Books Hard due date: (leave blank) Loan period: 10 3 - Expected behaviour is Book item will checkout to teacher for 10 days, all other types will be due yesterday at 25:59:00 4 - Checkout an non-book item type to teacher 5 - Hard due date applies 6 - Checkout a 'book' item type to teacher 7 - Hard due date applies - FAIL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:00:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:00:21 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se Attachment #128205|1 |0 is patch| | Attachment #128205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:00:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:00:22 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:00:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:00:26 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128030|0 |1 is obsolete| | Attachment #128031|0 |1 is obsolete| | Attachment #128032|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 128207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128207&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:00:30 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #33 from Marcel de Rooy --- Created attachment 128208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128208&action=edit Bug 29457: (QA follow-up) Report about checked manager_id's We print the number of missing or incorrect manager_id's now. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:03:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:03:57 +0000 Subject: [Koha-bugs] [Bug 29630] New: Failure on selenium 01-installation.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 Bug ID: 29630 Summary: Failure on selenium 01-installation.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Jenkins build with Selenium failed : https://jenkins.koha-community.org/view/master/job/Koha_Master/1848/ koha_1 | t/db_dependent/selenium/00-onboarding.t .. ok koha_1 | All tests successful. koha_1 | Files=1, Tests=2, 34 wallclock secs ( 0.04 usr 0.03 sys + 2.85 cusr 0.53 csys = 3.45 CPU) koha_1 | Result: PASS koha_1 | Restarting Apache httpd web server: apache2. koha_1 | Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:. db_1 | 2021-12-03 7:45:12 31 [Warning] Aborted connection 31 to db: 'koha_kohadev' user: 'koha_kohadev' host: '172.21.0.6' (Got an error reading communication packets) koha_1 | Stopping Z39.50/SRU daemon for kohadev:. koha_1 | Stopping Koha worker daemon for kohadev:. koha_1 | Stopping Koha indexing daemon for kohadev:. db_1 | 2021-12-03 7:45:13 34 [Warning] Aborted connection 34 to db: 'koha_kohadev' user: 'koha_kohadev' host: '172.21.0.6' (Got an error reading communication packets) koha_1 | Starting Plack daemon for kohadev:. koha_1 | Starting Z39.50/SRU daemon for kohadev:DBD::mysql::st execute failed: Table 'koha_kohadev.systempreferences' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | DBD::mysql::st execute failed: Table 'koha_kohadev.systempreferences' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | DBD::mysql::db selectall_arrayref failed: Table 'koha_kohadev.marc_subfield_structure' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | DBD::mysql::st execute failed: Table 'koha_kohadev.authorised_values' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | . koha_1 | Starting Koha worker daemon for kohadev:. koha_1 | Starting Koha indexing daemon for kohadev:. koha_1 | . selenium_1 | 07:45:25.238 INFO [ActiveSessionFactory.apply] - Capabilities are: { selenium_1 | "acceptSslCerts": true, selenium_1 | "browserName": "firefox", selenium_1 | "javascriptEnabled": true, selenium_1 | "version": "" selenium_1 | } selenium_1 | 07:45:25.240 INFO [ActiveSessionFactory.lambda$apply$11] - Matched factory org.openqa.selenium.grid.session.remote.ServicedSession$Factory (provider: org.openqa.selenium.firefox.GeckoDriverService) selenium_1 | 1638517525267 geckodriver INFO Listening on 127.0.0.1:27348 selenium_1 | 1638517525305 mozrunner::runner INFO Running command: "/usr/bin/firefox" "--marionette" "-foreground" "-no-remote" "-profile" "/tmp/rust_mozprofileJXkgVd" selenium_1 | [GFX1-]: glxtest: libpci missing selenium_1 | [GFX1-]: glxtest: libEGL missing selenium_1 | 1638517527025 Marionette INFO Marionette enabled selenium_1 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at /tmp/rust_mozprofileJXkgVd/search.json.mozlz4", (void 0))) selenium_1 | 1638517531931 Marionette INFO Listening on port 33539 selenium_1 | 07:45:32.097 INFO [ProtocolHandshake.createSession] - Detected dialect: W3C selenium_1 | 07:45:32.098 INFO [RemoteSession$Factory.lambda$performHandshake$0] - Started new session 7bd2cfd4-18c4-47c2-b441-bcded48340d4 (org.openqa.selenium.firefox.GeckoDriverService) koha_1 | koha_1 | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try koha_1 | (eval 358):1 in Selenium::Remote::Driver::__ANON__ koha_1 | (eval 360):2 in Selenium::Remote::Driver::__ANON__ koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in (eval) koha_1 | t/db_dependent/selenium/01-installation.t:99 in Selenium::Remote::Driver::find_element koha_1 | selenium_1 | 1638517555349 Marionette INFO Stopped listening on port 33539 selenium_1 | JavaScript error: resource:///modules/Interactions.jsm, line 230: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIUserIdleService.removeIdleObserver] selenium_1 | 07:45:56.645 INFO [ActiveSessions$1.onStop] - Removing session 7bd2cfd4-18c4-47c2-b441-bcded48340d4 (org.openqa.selenium.firefox.GeckoDriverService) koha_1 | Error while executing command: no such element: Unable to locate element: //div[@class="alert alert-success"] at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411. koha_1 | at /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 356. koha_1 | # Looks like your test exited with 255 before it could output anything. koha_1 | [07:45:56] t/db_dependent/selenium/01-installation.t ............................... koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 2/2 subtests koha_1 | DBD::mysql::st execute failed: Table 'koha_kohadev.systempreferences' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. koha_1 | DBD::mysql::st execute failed: Table 'koha_kohadev.systempreferences' doesn't exist at /kohadevbox/koha/Koha/Database.pm line 152. selenium_1 | 07:46:01.517 INFO [ActiveSessionFactory.apply] - Capabilities are: { selenium_1 | "acceptSslCerts": true, selenium_1 | "browserName": "firefox", selenium_1 | "javascriptEnabled": true, selenium_1 | "version": "" selenium_1 | } selenium_1 | 07:46:01.518 INFO [ActiveSessionFactory.lambda$apply$11] - Matched factory org.openqa.selenium.grid.session.remote.ServicedSession$Factory (provider: org.openqa.selenium.firefox.GeckoDriverService) selenium_1 | 1638517561540 geckodriver INFO Listening on 127.0.0.1:12870 selenium_1 | 1638517561579 mozrunner::runner INFO Running command: "/usr/bin/firefox" "--marionette" "-foreground" "-no-remote" "-profile" "/tmp/rust_mozprofileYsufal" selenium_1 | [GFX1-]: glxtest: libpci missing selenium_1 | [GFX1-]: glxtest: libEGL missing selenium_1 | 1638517563733 Marionette INFO Marionette enabled selenium_1 | console.warn: SearchSettings: "get: No settings file exists, new profile?" (new NotFoundError("Could not open the file at /tmp/rust_mozprofileYsufal/search.json.mozlz4", (void 0))) selenium_1 | 1638517569405 Marionette INFO Listening on port 44107 selenium_1 | 07:46:09.556 INFO [ProtocolHandshake.createSession] - Detected dialect: W3C selenium_1 | 07:46:09.557 INFO [RemoteSession$Factory.lambda$performHandshake$0] - Started new session ac595bfb-83ee-4401-94bb-177f9b39f638 (org.openqa.selenium.firefox.GeckoDriverService) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:04:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:04:08 +0000 Subject: [Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:06:06 +0000 Subject: [Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 --- Comment #1 from Fridolin Somers --- Looks like db creation or connection had a problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:07:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:07:16 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Kevin Carnes --- Here is a possible solution. It just sets a default value if no value is specified when saving a rule. There is also an atomic update to update rules already in the database. We are testing it and would appreciate your feedback so I'm setting it as "Needs Signoff". Please advise me if this not correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:08:50 +0000 Subject: [Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:08:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:08:50 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 [Bug 29630] Failure on selenium 01-installation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:41:01 +0000 Subject: [Koha-bugs] [Bug 29631] New: 21.06.000.12 may fail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Bug ID: 29631 Summary: 21.06.000.12 may fail Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 15067 We got 2 reports of this problem in the last 24h, uniq_lang unique key is failing to be created because several rows with the same (subtag, type) exist in DB. I have no idea how this is possible, but apparently it is. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 [Bug 15067] Add additional languages to advanced search language search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:41:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:41:01 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29631 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 [Bug 29631] 21.06.000.12 may fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:44:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:44:04 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #1 from Jonathan Druart --- Created attachment 128209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128209&action=edit Bug 29631: Prevent uniq_lang creation to fail We got 2 reports of this problem in the last 24h, uniq_lang unique key is failing to be created because several rows with the same (subtag, type) exist in DB. I have no idea how this is possible, but apparently it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:45:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:45:03 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- The SQL query does not seem very good, and it won't work if there are more than 2 entries (only 1 will be deleted). Could someone help me to get something better? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 11:49:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 10:49:42 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #34 from Marcel de Rooy --- In order to prevent running the dbrev twice and cause confusion, we could not push the second patch on master and only backport it. Since the second run might mark valid manager_id's as incorrect although they were added in a fixed system. Could someone come theoretically from a version where the error already exists, missed the backport fix and dbrev, and now upgrade to 22.05 (and miss the warn)? Yes, could be. If someone still wants to address this, please go ahead :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 12:04:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 11:04:58 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 12:12:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 11:12:09 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 12:49:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 11:49:02 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #29 from Victor Grousset/tuxayo --- Thanks a lot :D glad you figured it out. That could help others still using 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:02:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:02:54 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20754 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:02:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:02:54 +0000 Subject: [Koha-bugs] [Bug 20754] Db revision to remove double accepted list shares In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29631 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:13:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:13:52 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 [Bug 29593] Wrong tag in GET /public/libraries spec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:13:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:13:52 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 [Bug 29620] Move the OpenAPI spec to YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:16:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:16:02 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128173|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 128211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128211&action=edit Bug 29620: Move the OpenAPI spec to YAML format This patch moves all the REST API spec pieces into YAML. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:16:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:16:08 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128174|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 128212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128212&action=edit Bug 29620: (follow-up) Rename remaining old-style parameters The first routes we added named parameters in camelCase. We moved to snake_case really fast, but there are two that were kept by mistake. This patch fixes them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:16:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:16:32 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Solid improvement, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:17:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:17:12 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Go Go Go... this is a no brainer to me.. all works, no breaking changes, just improves readability and makes it easier going forward. Going straight for QA.. Passed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:17:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:17:18 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:17:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:17:32 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:23:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:23:41 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:24:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:24:02 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:15:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:15:24 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128151|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 128210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128210&action=edit Bug 29593: Fix wrong tag in GET /public/libraries spec This makes the documentation look untidy. To test: 1. Open the api/v1/swagger/paths/libraries.json file with your favourite editor. => FAIL: All routes, but this one, have tags: ['library'] 2. Apply this patch => SUCCESS: All routes have tags: ['libraries'] 3. swagger.yaml too! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 13:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 12:28:54 +0000 Subject: [Koha-bugs] [Bug 29595] missing Content-Type / HTTP 415 check for POST requests to /api/v1/patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29595 --- Comment #1 from Tomás Cohen Arazi --- We rely on the Mojolicious::Plugin::OpenAPI library to validate requests based on our OpenAPI 2.0 spec. I'll try to check if there's a way to avoid this fallback behavior in the spec, but I haven't found anything yet. So, we depend on the library to take care of this situation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 14:25:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 13:25:48 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 14:26:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 13:26:01 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 --- Comment #2 from Owen Leonard --- Created attachment 128213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128213&action=edit Screenshot of current behavior -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 14:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 13:35:41 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 14:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 13:35:46 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128209|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 128214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128214&action=edit Bug 29631: Prevent uniq_lang creation to fail We got 2 reports of this problem in the last 24h, uniq_lang unique key is failing to be created because several rows with the same (subtag, type) exist in DB. I have no idea how this is possible, but apparently it is. Test plan: Checkout a commit before 21.06.00.012 reset_all Create duplicate in language_subtag_registry > insert into language_subtag_registry(subtag, type, description) values('IN', 'region', 'India'); Checkout master+this patch, updatedatabase => Only 1 IN-region exists in the DB, the last one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 14:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 13:48:05 +0000 Subject: [Koha-bugs] [Bug 29632] New: Callnumber sorting is incorrect in Elasticsearch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Bug ID: 29632 Summary: Callnumber sorting is incorrect in Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com It looks like we are not sorting cn_sort as a raw field, but sorting the analyzed version. To recreate: 0 - Be using ES with Koha 1 - On records with single item, add callnumbers: VA65 E7 R63 1984 VA65 E7 T35 1990 VA65 E45 R67 1985 2 - Add public note 'shrimp' or something to make them easily searchable as a group 3 - Search for 'shrimp' 4 - Note E45 comes last, it should come first Problem may be here: 1122 sub _sort_field { 1123 my ($self, $f) = @_; 1124 1125 my $mappings = $self->get_elasticsearch_mappings(); 1126 my $textField = defined $mappings->{data}{properties}{$f}{type} && $mappings->{data}{properties}{$f}{type} eq 'text'; 1127 if (!defined $self->sort_fields()->{$f} || $self->sort_fields()->{$f}) { 1128 $f .= '__sort'; 1129 } else { 1130 # We need to add '.raw' to text fields without a sort field, 1131 # otherwise it'll sort based on the tokenised form. 1132 $f .= '.raw' if $textField; 1133 } 1134 return $f; 1135 } We need to enforce raw for cn-sort, or we need to index it unanalyzed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:00:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:00:44 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127238|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud --- Created attachment 128215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128215&action=edit Bug 29393 - Ability to send emails from patron details page Test plan - apply Bug 12802 - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - Select a notice (module members) or manualy fill the message - Save - Check the message is saved in message_queue table Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:00:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:00:59 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127452|0 |1 is obsolete| | --- Comment #12 from Alex Arnaud --- Created attachment 128216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128216&action=edit Bug 29393 - Use patron language in letters Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:01:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:01:09 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127506|0 |1 is obsolete| | --- Comment #13 from Alex Arnaud --- Created attachment 128217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128217&action=edit Bug 29393 - add a dedicated letters module for add message Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:01:20 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127511|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud --- Created attachment 128218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128218&action=edit Bug 29393 - Add send_messages_to_borrowers permission Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:01:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:01:30 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127847|0 |1 is obsolete| | --- Comment #15 from Alex Arnaud --- Created attachment 128219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128219&action=edit Bug 29393 - Don't show notice templates for each language Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:21:25 +0000 Subject: [Koha-bugs] [Bug 29633] New: Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29633 Bug ID: 29633 Summary: Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Andrew contacted me to raise a potential problem coming from bug 27526: commit 7a8357f7099d0863a322d1e91741b792b97fd6e1 Bug 27526: Adjust code to use Koha::Items -C4::Biblio::EmbedItemsInMarcBiblio({ - marc_record => $temp, - biblionumber => $biblionumber }); has been removed. I have tried to know where the items subfields could be used and found, in Koha/UI/Form/Builder/Item.pm: 1. only if itemcallnumber is used 164 my $temp2 = $marc_record->field($CNtag); 2. cataloguing plugins: 316 record => $marc_record, I have not found any cataloguing plugins using the MARC::Record (some are retrieving it when they have been passed in parameter, but that's another story). So maybe we could: * Remove marc_record from generate_subfield_form param list * Fetch it in the itemcallnumber block * Remove it from the cataloguing plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:21:25 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:21:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:21:48 +0000 Subject: [Koha-bugs] [Bug 29633] Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |m.de.rooy at rijksmuseum.nl, | |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:41:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:41:05 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #2 from Andreas Roussos --- Created attachment 128220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128220&action=edit Bug 29628: (follow-up) fix for rare edge case When the number of pending suggestions in the currently selected branch is equal to the number of pending suggestions across all branches, the `all_pendingsuggestions` template parameter is equal to 0. This results in the "Suggestions pending approval:" block not being printed at all. This follow-up patch fixes that. Also fixed is the display of pending suggestions in Home > Acquisitions. Test plan: 1) Apply this patch. 2) Create two Library branches; submit two suggestions in each one. 3) Visit the Home page, and also visit Home > Acquisitions: you should only see "${BRANCH_CODE}: 2" suggestions pending approval, regardless of the branch you have selected using the 'Set library' menu option. 4) Delete both suggestions from the 1st branch, and set your library to be the 1st branch. 5) Visit the same pages: this time "${BRANCH_CODE}: 0 / All libraries: 2" is displayed. 6) Set your library to be the 2nd branch, and visit the same two pages: this time "${BRANCH_CODE}: 2" is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:41:43 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:41:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:41:47 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127954|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 128221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128221&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:41:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:41:50 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #4 from Owen Leonard --- Created attachment 128222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128222&action=edit Bug 29552: (follow-up) Use CSS to set disabled class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:53:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:53:50 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:54:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:54:04 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:56:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:56:02 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:57:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:57:07 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:57:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:57:20 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 --- Comment #3 from Owen Leonard --- I can't reproduce this problem in master or 21.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:57:50 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:58:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:58:21 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124279|0 |1 is obsolete| | Attachment #124280|0 |1 is obsolete| | Attachment #124281|0 |1 is obsolete| | --- Comment #54 from Nick Clemens --- Created attachment 128223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128223&action=edit Bug 27981: DB update Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:58:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:58:25 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #55 from Nick Clemens --- Created attachment 128224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128224&action=edit Bug 27981: Add option to automatically set 001 to the biblionumber This patch adds a new system preference: autoControlNumber The option "biblionumber" will set field 001 to the biblionumber when you create a new record or edit an existing record and clear the 001 field. If a value is present in 001 when saving the record it will be preserved. If set to 'OFF' the 001 field wil not be touched When duplicating a record the 001 will be removed if autoControlNumber is set To test: 1 - Apply patches and updatedatabase 2 - Create a new record with no 001 field 3 - Save and view the MAC, confirm there is no 001 4 - Set the system preference to 'biblionumber' 5 - Edit the record you created previously 6 - Note the 001 is prepopulated with the biblionumber 7 - Delete the field 8 - Save the record 9 - View the MARC, the 001 is filled with biblionumber 10 - Edit the record 11 - Set the 001 to a different value "Not the biblionumber" 12 - Save 13 - View the marc and confirm the value you entered is retained 14 - Edit a record with an existing 001 that is not the biblionumber 15 - Save and confirm 001 is not updated To test duplication: 1 - Edit a record as duplicate when using the advanced editor 2 - Confirm the 001 does not load, but record saves correctly 3 - Edit the record 4 - Switch to 'basic editor' 5 - Save, then view record 6 - Edit as duplicate in basic editor 7 - Confirm the 001 is removed 8 - Confirm the 001 is added on save Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:58:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:58:28 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 15:58:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 14:58:30 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 --- Comment #56 from Nick Clemens --- Created attachment 128225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128225&action=edit Bug 27981: Adjust imported records, svc/import_bibs, records from Z3950 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:02:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:02:28 +0000 Subject: [Koha-bugs] [Bug 29634] New: Map biblio.medium to 245$h by default (MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 Bug ID: 29634 Summary: Map biblio.medium to 245$h by default (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 11529 added a medium field in the biblio table, but it is not linked to 245$h in the default marc21 framework. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:11:20 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #24 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:12:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:12:08 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:12:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:12:13 +0000 Subject: [Koha-bugs] [Bug 29604] term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:12:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:12:16 +0000 Subject: [Koha-bugs] [Bug 29604] term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128146|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 128226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128226&action=edit Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:13:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:13:31 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Erica Rohlfs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erica.rohlfs at equinoxOLI.org --- Comment #1 from Erica Rohlfs --- Noting that I recreated this workflow on Koha version 20.11. My results returned step 4 as the second result. So, in my testing, Koha returned results in the following order: VA65 E7 T35 1990, VA65 E45 R67 1985, VA65 E7 R63 1984. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:13:34 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:13:37 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 128227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128227&action=edit Bug 29634: Map biblio.medium to 245 by default (MARC21) This patch adds a mapping from 245 to biblio.medium. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblio.medium - biblio.medium should be mapped to 245 6) Create a bibliographic record with a value in 245 - In the database, check the biblio entry for this record, the value from 245 should be in medium I hope I didn't forget anything! :) Caroline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:14:10 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11529 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:14:10 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29634 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:15:55 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:16:34 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:18:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:18:22 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:19:01 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05 |22.05,21.11.01 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:19:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:19:59 +0000 Subject: [Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:20:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:20:23 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:20:27 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:20:27 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:23:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:23:10 +0000 Subject: [Koha-bugs] [Bug 29635] New: Map biblioitems.collectionissn to 490$x by default (MARC21) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29635 Bug ID: 29635 Summary: Map biblioitems.collectionissn to 490$x by default (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This mapping is not as critical in my opinion as some others that are missing, but while I'm at it, I thought I'd map everything correctly in the default marc21 framework, I hope that's ok. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:26:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:26:30 +0000 Subject: [Koha-bugs] [Bug 29331] Batch edit items.itemlost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29331 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #5 from Andrew Fuerste-Henry --- Just to clarify, one is able to use batch modification to add a lost status to items and to use batch modification to change other values on items that are lost. But one cannot use batch modification to remove a lost status from items. I guess it makes sense to prevent items being un-lost in bulk, but if we're maintaining the current behavior we should actually disable the checkbox in batch mod. Right now, I can take a bunch of lost items and *tell* batch mod to un-lose them. Koha claims it will do so and then just doesn't. If we're preventing an action, we should do so deliberately and clearly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:31:43 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 --- Comment #6 from Martin Renvoize --- Created attachment 128228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128228&action=edit Bug 27801: Fix javascript price calculations This patch ensures we're formatting the price values consistently for the table total and the amount to pay input field. Test plan 1) Add an item to charge at 0.10. 2) Add this same item 8 or 9 times (Do not use the 'quantity') 3) Note that the table total and the 'Amount paid' values do not match 4) Apply the patch and repeat the above steps.. the values should now match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:32:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:32:45 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128228|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 128229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128229&action=edit Bug 27801: Fix javascript price calculations This patch ensures we're formatting the price values consistently for the table total and the amount to pay input field. Test plan 1) Add an item to charge at 0.10. 2) Add this same item 8 or 9 times (Do not use the 'quantity') 3) Note that the table total and the 'Amount paid' values do not match 4) Apply the patch and repeat the above steps.. the values should now match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:34:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:34:54 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:44:45 +0000 Subject: [Koha-bugs] [Bug 29636] New: System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 Bug ID: 29636 Summary: System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The sysprefs StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay are a paired set, but not constructed such that they easily come up in searches together. I suggest we rename OpacLocationBranchToDisplay to OPACSearchResultsDisplayBranch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:49:07 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #3 from Jonathan Druart --- Created attachment 128230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128230&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:49:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:49:11 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #4 from Jonathan Druart --- Created attachment 128231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128231&action=edit Bug 27272: Remove type= This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:50:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:50:10 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- This is just a start! I am willing to work on that (ie. completely remove this silly subroutine). Just tell me you are ready to test the patches and I will continue! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:53:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:53:30 +0000 Subject: [Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 --- Comment #1 from Owen Leonard --- If we're renaming things let's use "Library" instead of "Branch." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 16:58:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 15:58:07 +0000 Subject: [Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 --- Comment #2 from Andrew Fuerste-Henry --- (In reply to Owen Leonard from comment #1) > If we're renaming things let's use "Library" instead of "Branch." Works for me! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 17:02:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 16:02:48 +0000 Subject: [Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 Erica Rohlfs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erica.rohlfs at equinoxOLI.org Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 18:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 17:13:17 +0000 Subject: [Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #3 from Andrew Fuerste-Henry --- Taking this out of In Discussion. I see a tangible gain in making this change and no one has stated a reason for objection. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 18:13:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 17:13:28 +0000 Subject: [Koha-bugs] [Bug 29636] System preferences StaffSearchResultsDisplayBranch and OpacLocationBranchToDisplay should have parallel names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29636 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 18:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 17:21:08 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard --- The OPAC detail page does currently show links to lists, but only to public lists. I don't think there's any reason why we shouldn't show links to private lists if the user is logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 18:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 17:49:01 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Stacey Nix changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snix at coastlinelibrarynetwor | |k.org --- Comment #5 from Stacey Nix --- We are also a consortium and we need to be able to have item level hold set to send them to the pickup location chosen by the patron. It is currently setting it at the pickup location as the home library and that does not work for us at all. Please fix this and set it back the way it was! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 19:07:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 18:07:52 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 19:42:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 18:42:40 +0000 Subject: [Koha-bugs] [Bug 29637] New: AutoSwitchPatron is broken since Bug 26352 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Bug ID: 29637 Summary: AutoSwitchPatron is broken since Bug 26352 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: michael.hafen at washk12.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 19:47:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 18:47:20 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #1 from Michael Hafen --- Created attachment 128232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128232&action=edit Proposed fix Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 19:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 18:47:27 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 19:57:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 18:57:51 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Todd Goatley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoatley at gmail.com --- Comment #6 from Todd Goatley --- We have received requests from libraries asking that this please be fixed as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:07:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:07:30 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:51:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:51:11 +0000 Subject: [Koha-bugs] [Bug 29638] New: Framework default value for year is not <> but is <> Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 Bug ID: 29638 Summary: Framework default value for year is not <> but is <> Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: courtenay.johnson at gmail.com QA Contact: testopia at bugs.koha-community.org The online manual description of the Framework default value field incorrectly describes the special values associated with date. It mentions <>,<>, AND <
>. The ones for month and day work, but not the one for year. This documentation is misleading. After looking at the additem.pl if found out why the <> did not work. It should be <> which does work as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:52:30 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:52:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:52:40 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 128233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128233&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Holding branch - The first valid pickup location the above are not valid To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, the holding branch is picked, and if not, some of the valid pickup locations is selected (i.e. there's no empty dropdowns) 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:58:33 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=28273 |?id=29349 Depends on| |28273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 [Bug 28273] Multi-holds allow invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:58:33 +0000 Subject: [Koha-bugs] [Bug 28273] Multi-holds allow invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28919 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 20:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 19:58:33 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 21:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 20:14:56 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #8 from Lucas Gass --- Thanks Tomas. I am wondering if we should change how this falls back if the pickup location is not valid. I think it should be: - Logged-in library - Holding branch - Empty/blank Instead of defaulting to the first choice alphabetically for the 3rd fallback we should set no value. This seems like it would be a rare occurrence that the logged in library and the holding branch are not valid pickup locations but if it does happen I think it can cause confusion. By leaving it empty it forces librarians to make a decision and I think in this case that is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 21:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 20:44:43 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry --- I like Jonathan's patch here, it does what libraries have indicated they want. Though I agree that on initial page load all dropdowns (the overall dropdown at the top and the individual dropdowns on each title) should default to the logged in branch if that's a valid pickup location. But if the logged-in branch is not a valid pickup location for one of the titles, then that title's dropdown should be blank to start and require one to select a valid pickup location before the form can be submitted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 21:59:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 20:59:00 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 21:59:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 20:59:04 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128229|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 128234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128234&action=edit Bug 27801: Fix javascript price calculations This patch ensures we're formatting the price values consistently for the table total and the amount to pay input field. Test plan 1) Add an item to charge at 0.10. 2) Add this same item 8 or 9 times (Do not use the 'quantity') 3) Note that the table total and the 'Amount paid' values do not match 4) Apply the patch and repeat the above steps.. the values should now match. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 21:59:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 20:59:43 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 --- Comment #9 from Andrew Fuerste-Henry --- I also confirmed the errors Esther mentioned were present without the patch and fixed with it. Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:07:40 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #25 from Fridolin Somers --- Solved by Bug 22417 for example items edition Bug 28445 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:13:21 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110130|0 |1 is obsolete| | --- Comment #17 from Fridolin Somers --- Created attachment 128235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128235&action=edit Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl Patron categories may have age limits. Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of patrons which age is invalid regarding there category. Test plan : 1) Create an adult patron category limited to 18-99 years 2) Create a patron in the category 3) Edit in database its date of birth so that he is 17 years old 4) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the patron Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:13:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:13:52 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110131|0 |1 is obsolete| | --- Comment #18 from Fridolin Somers --- Created attachment 128236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128236&action=edit Bug 26311: (QA follow-up) Rephrase output message This is a suggestion for rephrasing the message slightly: Before: * Patron borrowernumber=15 in category 'J' has invalid age '56' After: * Patron borrowernumber=37 has an invalid age of 37 for their category 'K' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:14:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:14:08 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110998|0 |1 is obsolete| | --- Comment #19 from Fridolin Somers --- Created attachment 128237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128237&action=edit Bug 26311: (follow-up) loop through the patron with date of birth and in categories having age limits Also added category limits in message, for example (12-18) Check patron : - with no date of birth - with invalid age in category having age required - with invalid age in category having upper age limit - with invalid age in category having age required and upper age limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:17:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:17:05 +0000 Subject: [Koha-bugs] [Bug 18273] Bulkmarcimport inserts authority duplicates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18273 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #6 from Fridolin Somers --- Needs an easy rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:19:18 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:21:25 +0000 Subject: [Koha-bugs] [Bug 29639] New: OPAC cart and staff cart are not consistent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639 Bug ID: 29639 Summary: OPAC cart and staff cart are not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you add items to your cart on the OPAC and go to view them you'll see these columns: Title Author Year Location (Status) If you look in the staff client: Title Item type Items I would be neat if these were more consistent. And perhaps also column configurable? Lucas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:23:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:23:33 +0000 Subject: [Koha-bugs] [Bug 29639] OPAC cart and staff cart are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 3 22:29:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 21:29:57 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #9 from Phil Ringnalda --- Alphabetically-first is also used for bib-level holds in the case where either the logged-in library isn't a valid pickup location at all, or is not a valid pickup location for any of the items. Should we also change that to blank, guessing without having yet had feedback from people using local hold groups that alphabetically-first is a bad idea, or should we take this patch to restore the previous behavior for people who do not use local hold groups while retaining consistent behavior between bib-level and item-level for people who do use them, and then find out from feedback whether alphabetically-first for people who do use them is worse than blank? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:04:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:04:59 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #5 from David Nind --- I had a go at testing but came across some issues (or I don't understand how to test this...). Testing notes using koha-testing-docker: 1. Update the CSS (yarn install, yarn build, yarn build --view opac, flush_memcached, restart_all) 2. Examples of where yesterday, today and tomorrow should not be active: . Place a hold for: for 'Hold expires on date:' yesterday and today should not be active [see potential issue [1]] . Circulation > Overdue report: in the filter make the from date in the future, Yesterday, Today and Tomorrow should all be not active, but are active even though they don't work . Struggled to find examples of when Tomorrow should not be selectable Potential issues noted - mainly with Yesterday, Today and Tomorrow not showing as inactive when they should be: 1. When placing a hold you can't enter today's date but 'Today' is still active 2. Same for Circulation > Renew 3. Administration > Patron categories > New category - Yesterday and Today are still active, even though you can't enter a date 4. Reports > Patrons: the "Date of birth" fields are linked so that to cannot be before from dates, if you add a date in the from taht is a few days in the future tehy should all be inactive, but aren't -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:28:14 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:28:18 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128214|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 128238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128238&action=edit Bug 29631: Prevent uniq_lang creation to fail We got 2 reports of this problem in the last 24h, uniq_lang unique key is failing to be created because several rows with the same (subtag, type) exist in DB. I have no idea how this is possible, but apparently it is. Test plan: Checkout a commit before 21.06.00.012 reset_all Create duplicate in language_subtag_registry > insert into language_subtag_registry(subtag, type, description) values('IN', 'region', 'India'); Checkout master+this patch, updatedatabase => Only 1 IN-region exists in the DB, the last one. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:29:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:29:57 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- I hope I have tested this correctly, as I often have problems with KTD and changing to previous versions rather than master. In this case, for step 1 of the test plan I checked out v21.05.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:35:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:35:20 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue when release notes| |upgrading from 21.05.x to | |21.11 - the uniq_lang | |unique key is failing to be | |created because several | |rows with the same subtag | |and type exist in database | |table | |language_subtag_registry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 00:47:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Dec 2021 23:47:53 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #15 from David Nind --- Created attachment 128239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128239&action=edit Bug 29605 - Error messages after reset_all I had a go at testing this, but I get "BEGIN failed--compilation aborted at...." error messages after the reset_all command. See attachment for the command line log. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:10:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:10:55 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #20 from David Nind --- Testing notes and issues identified (using koha-testing-docker): 1. Database query for step 3: update borrowers set dateofbirth = '2004-11-01' where borrowernumber = 49; 2. Main patch test plan worked as expected. 3. Had issues with some of the tests in the third patch (see details below), others worked as expected: . with no date of birth: doesn't seem to work if age is NULL . with invalid age in category having age required: 'Use of uninitialized value in sprintf...' message . with invalid age in category having upper age limit: 'Use of uninitialized value in sprintf...' message with no date of birth ~~~~~~~~~~~~~~~~~~~~~ 1. Edited a staff patron (Henry - 34) and removed date of birth 2. Changed the staff patron category (S) so age required = 18-99 years 3. Error message after running (note: dateofbirth is NULL in database): => Patron borrowernumber=34 has an invalid age of 104 for their category 'S' (18-99) => This looks wrong to me - with no date of birth I'm not sure how it works out they 104 years of age 4. If I update in the database so dateofbirth = '' (which becomes 0000-00-00) I get this message: ==> Can't call method "strftime" on an undefined value at /kohadevbox/koha/Koha/Patron.pm line 1149. with invalid age in category having age required ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Edited a patron (Mary Burton - 49) so that age is less than 24. 2. Changed patron category (PT) so age required = 24 and no maximum age. 3. Worked as expected except for 'Use of unitialized value...' message: ==> Use of uninitialized value in sprintf at misc/maintenance/search_for_data_inconsistencies.pl line 256. * Patron borrowernumber=49 has an invalid age of 10 for their category 'PT' (24-) 4. If they have the correct age (changed so they were older than 24) with invalid age in category having upper age limit ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Edited a patron (Mary Burton - 49) so that age is more than 50. 2. Changed patron category (PT) so that no age required and upper age limit was 50. 3. Output as expected except for 'Use of uninitialized value in sprintf...' message: ==> Use of uninitialized value in sprintf at misc/maintenance/search_for_data_inconsistencies.pl line 256. * Patron borrowernumber=49 has an invalid age of 71 for their category 'PT' (-50) with invalid age in category having age required and upper age limit ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Edited a patron (Mary Burton - 49) so that age is more than 60. 2. Changed patron category (PT) so that age required = 20 and upper age limit = 60. 3. Output as expected: ==> * Patron borrowernumber=44 has an invalid age of 70 for their category 'PT' (20-60) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:46:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:46:54 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #37 from David Nind --- This no longer seems to work unless I haven't set something up right. I added an A as a suffix and prefix to Bug 29637 in the patron search. The plugin installed okay (I used the latest version) and I copied the configuration in. I was testing Bug 29637 - which indicates this bug broke AutoSwitchPatron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:47:19 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:47:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:47:19 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:51:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:51:31 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:51:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:51:36 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #2 from David Nind --- Created attachment 128240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128240&action=edit Bug 29637: AutoSwitchPatron should look for card number in the barcode Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:52:03 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 03:57:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 02:57:07 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue release notes| |introduced by bug 26352 in | |21.11 that caused the | |AutoSwitchPatron system | |preference to no longer | |work. (When | |AutoSwitchPatron is enabled | |and a patron barcode is | |scanned instead of a book, | |it automatically redirects | |to the patron.) CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 04:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 03:47:56 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 04:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 03:48:30 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128227|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128241&action=edit Bug 29634: Map biblio.medium to 245 by default (MARC21) This patch adds a mapping from 245 to biblio.medium. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblio.medium - biblio.medium should be mapped to 245 6) Create a bibliographic record with a value in 245 - In the database, check the biblio entry for this record, the value from 245 should be in medium I hope I didn't forget anything! :) Caroline Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 04:52:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 03:52:53 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Text to go in the| |This updates the default release notes| |framework to map | |biblio.medium to 245$h. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 05:37:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 04:37:47 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 05:37:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 04:37:57 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128188|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 128242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128242&action=edit Bug 29628: Show purchase suggestion link when there are any suggestions systemwide To test: 1. Make some purchase suggestions at different branches. 2. Log in to a branch with a suggestion and visit /cgi-bin/koha/mainpage.pl 3. See something like: Suggestions pending approval: Centerville: 1 / All libraries: 2 4. Log into a branch with no suggestions, no link about suggestions 5. Apply patch 6. Repeat step 2, and still see something like: Centerville: 1 / All libraries: 2 7. Try a branch with no suggestions, now you see a link like: Centerville: 0 / All libraries: 2 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 05:38:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 04:38:06 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128220|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 128243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128243&action=edit Bug 29628: (follow-up) fix for rare edge case When the number of pending suggestions in the currently selected branch is equal to the number of pending suggestions across all branches, the `all_pendingsuggestions` template parameter is equal to 0. This results in the "Suggestions pending approval:" block not being printed at all. This follow-up patch fixes that. Also fixed is the display of pending suggestions in Home > Acquisitions. Test plan: 1) Apply this patch. 2) Create two Library branches; submit two suggestions in each one. 3) Visit the Home page, and also visit Home > Acquisitions: you should only see "${BRANCH_CODE}: 2" suggestions pending approval, regardless of the branch you have selected using the 'Set library' menu option. 4) Delete both suggestions from the 1st branch, and set your library to be the 1st branch. 5) Visit the same pages: this time "${BRANCH_CODE}: 0 / All libraries: 2" is displayed. 6) Set your library to be the 2nd branch, and visit the same two pages: this time "${BRANCH_CODE}: 2" is displayed. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 05:44:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 04:44:30 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |suggestions pending on the | |staff interface home page | |will always show, even if | |the current library has no | |suggestions. For example: | |Suggestions pending | |approval: Centerville: 0 / | |All libraries: 2 CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 06:10:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 05:10:53 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the display of |This fixes the display of release notes|suggestions pending on the |suggestions pending |staff interface home page |approval section on the |will always show, even if |staff interface home page |the current library has no |so that it always shows, |suggestions. For example: |even if the current library |Suggestions pending |has no suggestions. For |approval: Centerville: 0 / |example: Suggestions |All libraries: 2 |pending approval: | |Centerville: 0 / All | |libraries: 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 06:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 05:12:45 +0000 Subject: [Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #5 from David Nind --- I wasn't able to replicate the edge case in the follow-up patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:06:50 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:06:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:06:54 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128185|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128244&action=edit Bug 29627: Map biblioitems.publishercode to 264 by default (MARC21) This patch adds a mapping from 264 to biblioitems.publishercode. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblioitems.publishercode - biblioitems.publishercode should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblioitems entry for this record, the value from 264 should be in publishercode 7) Create a bibliographic record with a value un 260 - In the database, check the biblioitems entry for this record, the value from 260 should be in publishercode I hope I didn't forget anything! :) Caroline Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:09:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:09:42 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes using koha-testing-docker: 1. Had to make 264$b visible in the editor for the default framework 2. Database query for steps 6 and 7 (where XXX = the newly created record number): select * from biblioitems where biblionumber = XXX; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:13:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:13:14 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the default release notes| |framework to map | |biblioitems.publishercode | |to 264$b. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:15:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:15:05 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|purchase suggestion link on |Purchase suggestion link on |staff main page should |staff main page should |always show, even if logged |always show, even if logged |in branch has 0 suggestions |in branch has 0 suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:29:24 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:29:28 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128184|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 128245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128245&action=edit Bug 29626: Map biblioitems.place to 264 by default (MARC21) This patch adds a mapping from 264 to biblioitems.place. To test: 1) Apply patch 2) Delete existing frameworks - In the database delete from marc_tag_structure; delete from marc_subfield_structure; delete from biblio_framework; 3) Load default framework - In a terminal, run ./misc/load_yaml.pl -f installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml --load 4) In the staff interface, go to Administration > MARC bibliographic framework - Make sure the default framework is there 5) In Administration > Koha to MARC mapping, check the mappings for biblioitems.place - biblioitems.place should be mapped to 260 as well as 264 6) Create a bibliographic record with a value in 264 - In the database, check the biblioitems entry for this record, the value from 264 should be in place 7) Create a bibliographic record with a value un 260 - In the database, check the biblioitems entry for this record, the value from 260 should be in place I hope I didn't forget anything! :) Caroline Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:35:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:35:08 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the default release notes| |Koha to MARC mappings so | |that biblioitems.place is | |mapped to 264$a. Currently | |it is only mapped to 260$a, | |and RDA uses 264$a. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:37:01 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|Koha to MARC mappings so |Koha to MARC mappings so |that biblioitems.place is |that biblioitems.place maps |mapped to 264$a. Currently |to 264$a. Currently it only |it is only mapped to 260$a, |maps to 260$a, and RDA uses |and RDA uses 264$a. |264$a. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:37:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:37:49 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 --- Comment #3 from David Nind --- Testing notes using koha-testing-docker: 1. I had to make 264$a visible in the editor for the default framework 2. Database query for steps 6 and 7 (where XXX = the newly created record number): select * from biblioitems where biblionumber = XXX; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:45:39 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|framework to map |Koha to MARC mappings so |biblioitems.publishercode |that |to 264$b. |biblioitems.publishercode | |maps to 264$b. Currently it | |only maps to 260$b,and RDA | |uses 264$b. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:47:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:47:59 +0000 Subject: [Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Fridolin Somers --- Next run whas OK : https://jenkins.koha-community.org/view/master/job/Koha_Master/1849/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:49:31 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|framework to map |Koha to MARC mappings so |biblio.medium to 245$h. |that biblio.medium maps to | |245$h. The medium field was | |added in 19.11 but it was | |not linked to 245$h. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:50:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:50:26 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |26051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 [Bug 26051] Elasticsearch uses the wrong field for callnumber sorting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:50:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:50:26 +0000 Subject: [Koha-bugs] [Bug 26051] Elasticsearch uses the wrong field for callnumber sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29632 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 [Bug 29632] Callnumber sorting is incorrect in Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:51:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:51:53 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- I like the idea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:55:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:55:13 +0000 Subject: [Koha-bugs] [Bug 29634] Map biblio.medium to 245$h by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29634 --- Comment #3 from David Nind --- I also changed the assignee for the bug to you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:55:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:55:32 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:55:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:55:48 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:56:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:56:33 +0000 Subject: [Koha-bugs] [Bug 29626] Map biblioitems.place to 264$a by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29626 --- Comment #4 from David Nind --- I also changed the assignee for the bug to you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 07:57:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 06:57:14 +0000 Subject: [Koha-bugs] [Bug 29627] Map biblioitems.publishercode to 264$b by default (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29627 --- Comment #4 from David Nind --- I also changed the assignee for the bug to you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:05:41 +0000 Subject: [Koha-bugs] [Bug 29638] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- The manual is managed in GitLab https://gitlab.com/koha-community/koha-manual. I've opened a new issue with your text : https://gitlab.com/koha-community/koha-manual/-/issues/27 Best regards, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:20:05 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #2 from David Nind --- Hi Caroline. I'm not seeing copyrightdate in steps 6 and 7. The database query I used was (where XXX = the newly created record number): select * from biblioitems where biblionumber = XXX; Both mappings for biblio.copyrightdate appear in Koha to MARC mappings. Note: For step 5 I'm assuming biblioitems.publishercode should be biblio.copyrightdate. David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:31:27 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16551 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 [Bug 16551] Display the name of lists to the search results at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:31:27 +0000 Subject: [Koha-bugs] [Bug 16551] Display the name of lists to the search results at the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 [Bug 29621] Add link for Lists on opac-detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:44:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:44:23 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 08:45:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 07:45:13 +0000 Subject: [Koha-bugs] [Bug 21705] Map copryrightdate to both 260/264c by default for new MARC21 installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21705 --- Comment #3 from David Nind --- I changed the assignee to Caroline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 10:08:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 09:08:16 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 10:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 09:08:21 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 --- Comment #2 from Fridolin Somers --- Created attachment 128246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128246&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 10:12:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 09:12:45 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128246|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 128247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128247&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 10:44:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 09:44:24 +0000 Subject: [Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 --- Comment #1 from Didier Gautheron --- Created attachment 128248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128248&action=edit Bug 34874: Add streettype and B_streettype to PrefillGuaranteeField To test : 1) modify PrefillGuaranteeField system preference 2) road type for main and alternate addresses aren't in the list 3) Apply patch 4) Redo 1, now they are -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 10:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 09:45:36 +0000 Subject: [Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 11:12:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 10:12:17 +0000 Subject: [Koha-bugs] [Bug 29473] [21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Documentation changes for |[21.11] Documentation |21.11 |changes for 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 11:23:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 10:23:07 +0000 Subject: [Koha-bugs] [Bug 29640] New: [22.05] Documentation changes for 22.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640 Bug ID: 29640 Summary: [22.05] Documentation changes for 22.05 Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://docs.google.com/spreadsheets/d/1fhi7ogwYjtYlal s5K6_Uxun9LBqRktGOTLC3k3fT1aA/edit?usp=sharing OS: All Status: NEW Severity: normal Priority: P1 - high Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org This is a placeholder for reviewing all the bugs in 22.05 and determining which ones require documentation updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 12:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 11:01:50 +0000 Subject: [Koha-bugs] [Bug 29640] [22.05] Documentation changes for 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640 --- Comment #1 from David Nind --- The spreadsheet lists all bugs pushed to master for 22.05. This will be used to: 1. Review all bugs 2. Determine if documentation changes are required, and 3. Manage documentation tasks for a release. Process for maintaining the list: 1. Update list each week (or as required) with the bugs pushed to master by either: . using the GitLab mirror at https://gitlab.com/koha-community/Koha/-/commits/master to identify bugs pushed . incorporate changes from the Bugzilla query https://bugs.koha-community.org/bugzilla3/buglist.cgi?cmdtype=runnamed&list_id=394355&namedcmd=Doc%20changes%2022.05 2. Review each bug and determine whether any updates are required. 3. Update the appropriate columns in the spreadsheet (apart from assigned to): . Reviewed for documentation changes? (Y/N) . Documentation changes required? (Y/N/Review) . Complexity (Easy/Medium/Hard) . Reviewed by . Date reviewed . Assigned to . Completed (Y/N/N/A) . Include in what's new? (Y/N) . Notes 3. Update the text to go in the release notes where required. 4. Update the log in the spreadsheet and note on this bug, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 14:35:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 13:35:04 +0000 Subject: [Koha-bugs] [Bug 29641] New: Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 Bug ID: 29641 Summary: Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org Created attachment 128249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128249&action=edit Error message in CLI During both phase one (command line installer) and phase two (web-based installer) upgrade from 21.05.05-3 to 21.11.00-1 fails, throwing the following message: Upgrade to 21.06.00.012 [15:25:02]: Bug 15067 - Add missing languages ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738 Please advise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 14:35:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 13:35:35 +0000 Subject: [Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 --- Comment #1 from Manos PETRIDIS --- Created attachment 128250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128250&action=edit Error message in web interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 18:19:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 17:19:31 +0000 Subject: [Koha-bugs] [Bug 29642] New: About page marks several Perl modules as missing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 Bug ID: 29642 Summary: About page marks several Perl modules as missing Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org I notice that in the "Perl modules" tab at /cgi-bin/koha/about.pl some modules appear as missing, namely Text::CSV::Unicode (0.40) Not Installed Selenium::Remote::Driver (1.27) Not Installed Test::DBIx::Class (0.42) Not Installed HTTPD::Bench::ApacheBench (0.73) Not Installed Locale::XGettext::TT2 (0.7) Not Installed As my installation is a vanilla one (koha-common on Debian), I wonder if they should have been installed by default. For example, I see in https://git.koha-community.org/Koha-community/Koha/commit/f180314f58c57ce0c6c1094fa19da88502085144 that "Selenium::Remote::Driver (1.27)" should have been included in the dependencies list years ago. Another example: Locale::XGettext::TT2 (0.7) is mentioned in https://git.koha-community.org/Koha-community/Koha/commit/3cfc2ec7bd1becef4386404fe7fc9f12740e8c97 as "new dependency" two years ago, yet it is absent from my installation, despite several upgrades since. What gives? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 19:00:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 18:00:14 +0000 Subject: [Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 --- Comment #2 from Manos PETRIDIS --- I wonder if it is related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 19:00:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 18:00:52 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #6 from Manos PETRIDIS --- Could it be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 19:11:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 18:11:25 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #9 from Manos PETRIDIS --- Am I correct to understand that Jonathan Druart decided to remove functionality from the koha-common package after consulting a single person? Are there no other libraries in Italy following the UNIMARC standard? Are there no other libraries in Italy interested in installing koha? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 19:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 18:16:25 +0000 Subject: [Koha-bugs] [Bug 29642] About page marks several Perl modules as missing (package installation). In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|About page marks several |About page marks several |Perl modules as missing |Perl modules as missing | |(package installation). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 19:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 18:18:27 +0000 Subject: [Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- This is a duplicate of bug 29631 - the screens shots are helpful though! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 23:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 22:45:59 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 4 23:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 22:45:59 +0000 Subject: [Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29631 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 00:11:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Dec 2021 23:11:42 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #7 from David Nind --- I think it is the same (better described). I hadn't marked as a duplicate yet, but did link them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 06:52:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 05:52:56 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #10 from Samu Heiskanen --- If you move the line: 323 my $biblio = Koha::Biblios->find( $biblionumber ); just before the foreach loop and add the line: biblio => $biblio, to: 738 # display infos 739 $template->param( 740 reserveloop => 1, 741 itemdata_enumchron => $itemdata_enumchron, 742 itemdata_ccode => $itemdata_ccode, 743 date => $date, 744 biblionumber => $biblionumber, 745 findborrower => $findborrower, 746 holdsview => 1, 747 C4::Search::enabled_staff_search_views, 748 ); like: # display infos $template->param( reserveloop => 1, itemdata_enumchron => $itemdata_enumchron, itemdata_ccode => $itemdata_ccode, date => $date, biblionumber => $biblionumber, findborrower => $findborrower, biblio => $biblio, holdsview => 1, C4::Search::enabled_staff_search_views, ); The patch works. What is your opinion, have I got it done correcly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 09:17:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 08:17:02 +0000 Subject: [Koha-bugs] [Bug 29538] UNIMARC no longer available as marc flavour when installing in Italian In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29538 --- Comment #10 from John Fawcett --- Manos. no, there was no discussion about removing UNIMARC. The discussion was about a more maintainable way of providing UNIMARC translations that keep in sync with the original template. With the then existing mechanism UNIMARC was no longer installing anyway for Italian and I submitted some fixes to realign the translated version with the baseline which meant that it was now installable again. (From this I gather that not many new installations were being done in Italian for UNIMARC, but not sure whether people didn't need it or they needed it but it wasn't working). The basic problem with the then existing approach is translations were in the code. Jonathan proposed an alternative approach which would mean all translations would be on pootle and there was only one version of the template in the code (so nothing in the code to get out of sync as had happened). I believe that is a good approach and gave my feedback on it. I don't know who was involved in the decision but I do know I was not the only person to be asked for feedback. Your question is related to the Italian version, but I believe the modification applies to all translated versions except English and French. I think the issue is not about the discussion that was done or with how many people it was done, but that not all the code changes needed were committed together. As Jonathan has said, there is however a workaround, since upgrades from previouos versions installed with UNIMARC are supported. John -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 09:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 08:39:53 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind --- Created attachment 128251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128251&action=edit Bug 29168 - Error trace when viewing detail in OPAC when logged in When viewing the detail page for a record in the OPAC when logged in I get the error as attached. This is after applying the patch, enabling article requests, but before setting any article request limits. If you are not logged in, the detail page is displayed as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 09:40:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 08:40:21 +0000 Subject: [Koha-bugs] [Bug 29168] Only show "Request article" if allowed on the detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 10:55:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 09:55:59 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #35 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #34) > In order to prevent running the dbrev twice and cause confusion, we could > not push the second patch on master and only backport it. I don't think that will work, because people jump versions/come from an older version without the fix directly to a new version released from master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 17:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 16:56:03 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 17:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 16:56:09 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127484|0 |1 is obsolete| | --- Comment #29 from David Nind --- Created attachment 128252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128252&action=edit Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber or [[biblionumber|Biblio number]] but not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. The selection persists until the user logs out. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 18:01:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 17:01:59 +0000 Subject: [Koha-bugs] [Bug 29060] Use modal for suspending holds until a date from the holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind --- Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29060: Use modal for suspending holds until a date from the holds page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 18:23:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 17:23:14 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 18:23:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 17:23:19 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127866|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 128253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128253&action=edit Bug 29040: Remove warning from the itemtype edit view Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. We are expecting "intranet" or "opac", here we sent undef which raises a warning. For no change in behaviour we can send "both" (or whatever different than "intranet" and "opac"). Test plan: Hit /cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK Notice that the warning does no longer appear in the logs with the patch applied. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 18:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 17:27:28 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This removes the cause of release notes| |the warning message "Use of | |uninitialized value | |$interface in concatenation | |(.) or string at | |/kohadevbox/koha/C4/Languag | |es.pm line 121." when | |editing item types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 19:35:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 18:35:06 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #58 from Victor Grousset/tuxayo --- In 29602 the question of performance came up. Here will be moved some comments from there. Here are results of the benchmarks of bug 15395 on my laptop with a 2012 CPU (i5-3320M @3.3GHz on mono thread loads) Summary Average for 10 strings without translation: 0.0001145 seconds Average for 100 strings without translation: 0.0001114 seconds Average for 200 strings without translation: 9.82e-05 seconds Average for 500 strings without translation: 0.0001932 seconds Average for 10 strings with translation: 0.0014077 seconds Average for 100 strings with translation: 0.0076227 seconds Average for 200 strings with translation: 0.0120828 seconds Average for 500 strings with translation: 0.0306117 seconds The same PC has a median time of 0.350 sec to generate the untranslated HTML for this page: /cgi-bin/koha/admin/preferences.pl?tab=circulation (using browser network devtools) There are 200 sysprefs shown there. So it's surely one the of the pages with the most translatable strings we have. (Well, searching "a" in sysprefs yields 740 of them ^^" in more than 0.950 sec) git grep "circulation.pref#" misc/translator/po/bg-Cyrl-pref.po | wc -l => 633 So it seems we have 633 strings in our circulation sysprefs. if 500 strings took 0.031 sec in the benchmark then 633 strings => 0.039 sec 0.039 is 11% of 0.350 So we should expected that using t() on all string on this page should add 11% response time to 0.350 sec. Would there be another case where the overhead could be the more perceptible than this? (it's not really perceptible) Is the methodology valid? If so then we shouldn't expect issues about performance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 19:36:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 18:36:55 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #59 from Victor Grousset/tuxayo --- Jonathan wrote (bug 29602 comment 17) (In reply to Victor Grousset/tuxayo from comment #16) > Is the methodology valid? You need to count how many times you enter t() instead of guessing the number of lines matching a pattern there are in a file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 19:46:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 18:46:00 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #60 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart) > You need to count how many times you enter t() instead of guessing the > number of lines matching a pattern there are in a file. Won't we have one t() usage per string starting with `circulation.pref#` ? Doesn't the above prefix matches all the translatable strings of the page with all the circulation sysprefs? Except the ones on the left and up parts of the UI but in the end the strings of the syspref descriptions and values(dropdowns) dominate the whole page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 21:30:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 20:30:41 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #47 from Victor Grousset/tuxayo --- About the discussion of t("Koha online catalogue") vs t("opac.homepage.title"), the current approach (1st) doesn't close the door for the 2nd (token based) since the strings would already be wrapped in calls. So it's not closing this door assuming the token based approach is chosen in the end.t It's even a common step, right? About that choice: (In reply to David Cook from comment #38) > I agree that the PO files are huge, but looking through them that are also lots of junk lines, duplicate translations, unnecessary translations, etc. Using tokens would cut down on a lot of that. How would tokens allow us to get less junk, duplicates and unnecessary translations? Don't a smarter (manual or automated) use of t() already does all that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 23:20:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 22:20:16 +0000 Subject: [Koha-bugs] [Bug 20956] BorrowersLog is not logging permission changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 --- Comment #9 from Katrin Fischer --- I think action_logs would be the logical place for it as it also has the other changes to the patron account for the librarians as it can be looked up easily then, but something extermal might be nice additionally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 23:27:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 22:27:00 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #14 from Katrin Fischer --- I just got into this conversation... but why is this resolved fixed now? The bug report made sense to me? (must be missing something here) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 5 23:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 22:55:03 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #48 from Katrin Fischer --- I haven't heard any good argument for tokens yet tbh. I think they would just obscure the templates and make them harder for people to work with. Koha is a huge application by now, that has a lot of strings, we'd also end up with tons of tokens. For the discussion: I think we need to discuss pros and cons of rewriting all our templates, because of the consequences: * A ton of pending code would have to be rewritten * Backporting patches would be harder for quite a while/versions * It would add another 'not so obvious' thing for development that is an additional barrier for people starting out * Template files will be bigger/contain more code. * We need to investigate a possible performance issue. * We could save 'space' as templates files won't need to be copied for each added language any longer. * We could see if we could shorten some of the constructs a bit more - the BLOCK/EXPAND especially. * We would need good documentation. * We would need to carefully the change for translators, not only locally, but also in Pootle. * We need to solve the issue where Pootle marks strings using {} placeholders as an error which makes things really hard for translators right now. So far I totally see the pros for using the new techniques for plural forms and context where words can have different meaning/need different translations, and we have already started to introduce them to the templates. But I am not totally persuaded that we should do a total switch (yet) I think this is not something that can go through dev/sign-off/QA/RM with only a few people involved in the discussion, it's something a lot more people need to be aware of and given the possibility to comment on and get onboard with, because a lot of people will be affected. So mailing list, dev meeting, consensus, coding guidelines, documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:01:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:01:38 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 --- Comment #8 from Katrin Fischer --- (In reply to Amy Schapiro from comment #7) > According to the most recent MARC rules at LOC - > https://www.loc.gov/marc/bibliographic/bd505.html > Two hyphens are the appropriate way to separate these fields. > Thanks everyone! Hi Amy, that's correct and it is what happens in the XSLT in current versions now. There is an issue where an extra -> (used at the beginning of the line, but you could change it to something else) appears at the end of the list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:04:03 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 --- Comment #17 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #16) > I like Jonathan's patch here, it does what libraries have indicated they > want. Though I agree that on initial page load all dropdowns (the overall > dropdown at the top and the individual dropdowns on each title) should > default to the logged in branch if that's a valid pickup location. > > But if the logged-in branch is not a valid pickup location for one of the > titles, then that title's dropdown should be blank to start and require one > to select a valid pickup location before the form can be submitted. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:13:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:13:15 +0000 Subject: [Koha-bugs] [Bug 29370] Cannot add patron attributes to quick add without making them mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29370 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Cannot add patron |Cannot add patron |attributes to quick add or |attributes to quick add |mandatory list |without making them | |mandatory --- Comment #4 from Katrin Fischer --- Hi Sara and Bohdan, you are both correct I think in there is something still missing here. I suggest we could change this bug for adding the option to add patron attributes to the quick add form (which is not possible now without making it mandatory). And as this worked before, I am updating this to 'normal'. Then Sara, maybe you could file a separate bug about the self registration issue? I think that is a very valid point as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:40:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:40:08 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:55:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:55:50 +0000 Subject: [Koha-bugs] [Bug 29599] addorderiso2709.pl - Discount is stored as value below 1 instead of actual percentage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29599 --- Comment #1 from Katrin Fischer --- Hi Christophe, if this is the same as Bug 29607 - addorderiso2709: The stored discount when importing an order from a file is invalid, you could also use the "Mark as duplicate" option, then both bugs will be linked which might help someone stumbling on this bug to make the connection. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 00:57:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Dec 2021 23:57:11 +0000 Subject: [Koha-bugs] [Bug 29610] "Cap fine at replacement price" un-checks when circulation rule is edited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29610 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |major --- Comment #1 from Katrin Fischer --- I count this as a 'data loss' bug as it would happen really easily when editing those long lines. Updating severity for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:00:08 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 --- Comment #1 from Katrin Fischer --- Hi Minna, have you set the default value for subfield 7 to -1 in your ACQ framework? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:03:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:03:28 +0000 Subject: [Koha-bugs] [Bug 29643] New: [DOC] Review and update koha-manual git repository README and CONTRIBUTING files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29643 Bug ID: 29643 Summary: [DOC] Review and update koha-manual git repository README and CONTRIBUTING files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Review and update the koha-manual git repository README and CONTRIBUTING files to include: * A link to Documentation Team wiki pages * A link to CONTRIBUTING.md * Make the information about setup, producing output and useful commands more concise The main goal is to make it more useful and clearer for those that would like to contribute a change to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:03:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:03:45 +0000 Subject: [Koha-bugs] [Bug 29643] [DOC] Review and update koha-manual git repository README and CONTRIBUTING files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:05:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:05:50 +0000 Subject: [Koha-bugs] [Bug 29624] ITEMTYPECAT Icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29624 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Eliana, do you use the "remote icon" option? I think then this would be bug 7374. IIRC it works if you add the path to the database table directly, it just doesn't work correctly for setting it from the GUI. But we should fix this properly. *** This bug has been marked as a duplicate of bug 7374 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:05:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:05:50 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eliana at flo.org --- Comment #13 from Katrin Fischer --- *** Bug 29624 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:08:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:08:31 +0000 Subject: [Koha-bugs] [Bug 29643] [DOCS] Review and update koha-manual git repository README and CONTRIBUTING files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29643 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DOC] Review and update |[DOCS] Review and update |koha-manual git repository |koha-manual git repository |README and CONTRIBUTING |README and CONTRIBUTING |files |files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:08:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:08:35 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #6 from Katrin Fischer --- Hi Lucas, can you please check if this is a duplicate to bug 29571? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:08:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:08:59 +0000 Subject: [Koha-bugs] [Bug 29640] [DOCS 22.05] Documentation changes for 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[22.05] Documentation |[DOCS 22.05] Documentation |changes for 22.05 |changes for 22.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:09:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:09:20 +0000 Subject: [Koha-bugs] [Bug 29473] [DOCS 21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[21.11] Documentation |[DOCS 21.11] Documentation |changes for 21.11 |changes for 21.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:10:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:10:09 +0000 Subject: [Koha-bugs] [Bug 29640] [DOCS 22.05] Documentation changes for 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:11:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:11:00 +0000 Subject: [Koha-bugs] [Bug 29473] [DOCS 21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:11:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:11:25 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:13:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:13:04 +0000 Subject: [Koha-bugs] [Bug 29638] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com, david at davidnind.com --- Comment #2 from Katrin Fischer --- (In reply to Fridolin Somers from comment #1) > The manual is managed in GitLab > https://gitlab.com/koha-community/koha-manual. > > I've opened a new issue with your text : > https://gitlab.com/koha-community/koha-manual/-/issues/27 > > Best regards, Hi Fridolin, the documentation team agreed on using Bugzilla a while ago. So I think we don't need to file on gitlab separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:14:44 +0000 Subject: [Koha-bugs] [Bug 29641] Error "Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738" while upgrading from 21.05.05-3 to 21.11.00-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 29631 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:14:44 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #8 from Katrin Fischer --- *** Bug 29641 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:17:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:17:41 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:24:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:24:33 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #7 from David Nind --- Thanks Katrin! I was sure I had signed of something similar, but I couldn't find it... (and it was only a week ago!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:50:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:50:04 +0000 Subject: [Koha-bugs] [Bug 29638] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 --- Comment #3 from David Nind --- (In reply to Katrin Fischer from comment #2) > Hi Fridolin, the documentation team agreed on using Bugzilla a while ago. So > I think we don't need to file on gitlab separately. Thanks Katrin. I was about to add a comment and make the manual change... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:51:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:51:35 +0000 Subject: [Koha-bugs] [Bug 29638] [DOCS] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | Summary|Framework default value for |[DOCS] Framework default |year is not <> but is |value for year is not |<> |<> but is <> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 01:51:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 00:51:59 +0000 Subject: [Koha-bugs] [Bug 29638] [DOCS] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 02:04:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 01:04:18 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #11 from Samu Heiskanen --- Created attachment 128254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128254&action=edit Here's the fixed patch for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 02:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 01:23:09 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #17) > This discussion should take place on bug 20988. Correct, I moved it and answered in bug 20988 and bug 6392 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 02:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 01:28:01 +0000 Subject: [Koha-bugs] [Bug 29644] New: [DOCS] Update version number for GitLab configuration for 22.05 cycle Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29644 Bug ID: 29644 Summary: [DOCS] Update version number for GitLab configuration for 22.05 cycle Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Update .gitlab-ci.yml on master to change the location from 21.05 to 22.05. Otherwise, as I understand it, the 21.05 version of the manual will be overwritten when changes are made to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 02:28:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 01:28:29 +0000 Subject: [Koha-bugs] [Bug 29644] [DOCS] Update version number for GitLab configuration for 22.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 02:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 01:41:15 +0000 Subject: [Koha-bugs] [Bug 29644] [DOCS] Update version number for GitLab configuration for 22.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29644 --- Comment #1 from David Nind --- Also requires updating source/conf.py. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:00:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #382 from Aleisha Amohia --- Thanks Michal I will investigate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:30:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:30:27 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128189|0 |1 is obsolete| | --- Comment #383 from Aleisha Amohia --- Created attachment 128255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128255&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:30:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:30:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128190|0 |1 is obsolete| | --- Comment #384 from Aleisha Amohia --- Created attachment 128256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128256&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:30:45 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128191|0 |1 is obsolete| | --- Comment #385 from Aleisha Amohia --- Created attachment 128257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128257&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:30:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:30:54 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128192|0 |1 is obsolete| | --- Comment #386 from Aleisha Amohia --- Created attachment 128258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128258&action=edit Bug 15516: Schema updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128193|0 |1 is obsolete| | --- Comment #387 from Aleisha Amohia --- Created attachment 128259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128259&action=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:10 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128194|0 |1 is obsolete| | --- Comment #388 from Aleisha Amohia --- Created attachment 128260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128260&action=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128195|0 |1 is obsolete| | --- Comment #389 from Aleisha Amohia --- Created attachment 128261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128261&action=edit Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:27 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128196|0 |1 is obsolete| | --- Comment #390 from Aleisha Amohia --- Created attachment 128262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128262&action=edit Bug 15516: (follow-up) Fixing file permissions and title elements order Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:34 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128197|0 |1 is obsolete| | --- Comment #391 from Aleisha Amohia --- Created attachment 128263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128263&action=edit Bug 15516: Fix shebang in hold-group.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128198|0 |1 is obsolete| | --- Comment #392 from Aleisha Amohia --- Created attachment 128264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128264&action=edit Bug 15516: (follow-up) Count group holds always -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:31:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:31:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128199|0 |1 is obsolete| | --- Comment #393 from Aleisha Amohia --- Created attachment 128265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128265&action=edit Bug 15516: Fix hold groups for multi items for one bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:32:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128200|0 |1 is obsolete| | --- Comment #394 from Aleisha Amohia --- Created attachment 128266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128266&action=edit Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:32:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:32:09 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128201|0 |1 is obsolete| | --- Comment #395 from Aleisha Amohia --- Created attachment 128267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128267&action=edit Bug 15516: Show user's hold groups to user via OPAC This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:32:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:32:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128202|0 |1 is obsolete| | --- Comment #396 from Aleisha Amohia --- Created attachment 128268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128268&action=edit Bug 15516: (follow-up) Prevent cancelling unintended holds And a fix for consistent TT code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 04:32:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 03:32:25 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #397 from Aleisha Amohia --- Created attachment 128269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128269&action=edit Bug 15516: (follow-up) Fix hold group details not showing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 06:48:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 05:48:08 +0000 Subject: [Koha-bugs] [Bug 29638] [DOCS] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #4 from David Nind --- A change was required for these versions of the manual: 20.05, 20.11, 21.05, 21.11 and master. I've made the change - the change should be live once the regeneration is finished for all versions. (20.05 required manual back porting - all others were able to be "Cherry picked".) Commit: https://gitlab.com/koha-community/koha-manual/-/commit/c126d5a000a7ad62a1e03e6ef904c0f6c5de9a64 Thanks Courtenay for identifying and raising the issue! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 06:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 05:54:11 +0000 Subject: [Koha-bugs] [Bug 29644] [DOCS] Update version number for GitLab configuration for 22.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29644 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #2 from David Nind --- Change successfully made. 22.05 (development) version reflecting master is now available at https://koha-community.org/manual/22.05/en/html/ Commit: https://gitlab.com/koha-community/koha-manual/-/commit/be316f4258e56d3dfede241f8837a0ba80c4e19b -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 07:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 06:02:16 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #12 from Lari Taskula --- Hi Samu and welcome, I can confirm the "No title" bug from Nick's patches. I tested Samu's patch and noticed that your patch is introducing a new bug - batch placement of holds gets broken, follow this plan to replicate: 0. Have at least two bibliographic records in your Koha installation 1. In staff client, perform a search that returns at least two results 2. On search result list there are checkboxes, check them for two or more results 3. Click "Place hold" button 4. Observe the following error: "Cannot place hold: one or more records don't exist." This is because at line 326 (with your patch included) we are checking if any of the biblios in batch request is missing. The loop that starts at line 321 is handling each biblio of the batch request individually and each iteration requires that specific biblio to be loaded with "my $biblio = Koha::Biblios->find( $biblionumber );" so that required steps can be performed on it. Also, patch/commit title should be "Bug 29043: subject". See https://wiki.koha-community.org/wiki/Commit_messages#Subject_line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 07:10:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 06:10:13 +0000 Subject: [Koha-bugs] [Bug 29645] New: [DOCS] Update manual theme for 19.11 and 20.05 so it matches later versions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29645 Bug ID: 29645 Summary: [DOCS] Update manual theme for 19.11 and 20.05 so it matches later versions Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org The theme for versions 19.11 and 20.05 of the manual are different all the later versions of the manual. Update so that they use the same theme - would provide a more consistent experience for site visitors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 07:10:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 06:10:59 +0000 Subject: [Koha-bugs] [Bug 29645] [DOCS] Update manual theme for 19.11 and 20.05 to match later versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Summary|[DOCS] Update manual theme |[DOCS] Update manual theme |for 19.11 and 20.05 so it |for 19.11 and 20.05 to |matches later versions |match later versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 08:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 07:07:22 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #14) > I just got into this conversation... but why is this resolved fixed now? > > The bug report made sense to me? (must be missing something here) Pushed to 20.05. See also comment8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 08:54:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 07:54:17 +0000 Subject: [Koha-bugs] [Bug 29646] New: opac-password-recovery crash on wrong borrower_number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Bug ID: 29646 Summary: opac-password-recovery crash on wrong borrower_number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Seeing this in 20.11 but code in master has not changed: Can't call method "category" on an undefined value at /usr/share/koha/opac/opac-password-recovery.pl line 204 eval {...} at /usr/share/koha/opac/opac-password-recovery.pl line 2 CGI::Compile::ROOT::usr_share_koha_opac_opac_2dpassword_2drecovery_2epl::__ANON__('CGI::Compile=HASH(0x56477a9a9208)', '', '/usr/share/koha/opac/opac-password-recovery.pl', '/usr/share/koha/opac', 'ARRAY(0x56477b4391f0)') called at /usr/share/perl5/CGI/Compile.pm line 151 Code looks like: if ( !$borrower_number ) { $errLinkNotValid = 1; } my $borrower = Koha::Patrons->find($borrower_number); $template->param( new_password => 1, email => $email, uniqueKey => $uniqueKey, username => $username, errLinkNotValid => $errLinkNotValid, hasError => ( $errLinkNotValid ? 1 : 0 ), minPasswordLength => $borrower->category->effective_min_password_length, RequireStrongPassword => $borrower->category->effective_require_strong_password If the borrower_number is not found, the $borrower->category crashes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:06:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:06:11 +0000 Subject: [Koha-bugs] [Bug 29646] opac-password-recovery crash on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 --- Comment #1 from Marcel de Rooy --- Seems like a hack attempt btw. The regular password recovery should not crash. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:19:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:19:57 +0000 Subject: [Koha-bugs] [Bug 29638] [DOCS] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 --- Comment #5 from Katrin Fischer --- (In reply to David Nind from comment #3) > (In reply to Katrin Fischer from comment #2) > > > Hi Fridolin, the documentation team agreed on using Bugzilla a while ago. So > > I think we don't need to file on gitlab separately. > > Thanks Katrin. I was about to add a comment and make the manual change... I added you and Caroline in case I had missed another workflow change :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:22:13 +0000 Subject: [Koha-bugs] [Bug 29647] New: Update po files in manual repository Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 Bug ID: 29647 Summary: Update po files in manual repository Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: david at davidnind.com At the moment some of the po files in the manual repository are quite outdate compared to the po files on pootle. Before branching out the manual, could we do a general update on all po files for the manuals 21.05 and 20.11? I know it would help a lof for German, but I think doing it for all languages every half year would be good as a lot of people are not aware of the process and wouldn't ask for updating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:30:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:30:39 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-password-recovery |Bad or repeated |crash on wrong |opac-password-recovery |borrower_number |attempt crashes on wrong | |borrower_number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:30:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:30:57 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:34:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:34:27 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:34:30 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 --- Comment #2 from Marcel de Rooy --- Created attachment 128270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128270&action=edit Bug 29646: Fix undefined category crash in opac-password-recovery The crash is a result of a not found borrower. This is typically a bad or repeated recovery attempt. Test plan: Do a password recovery. Use the mailed URL twice. Without this patch, the second attempt crashes. With this patch, the second attempt shows an error dialog. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 09:35:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 08:35:01 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrower_number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- Super trivial fix: self signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:01:06 +0000 Subject: [Koha-bugs] [Bug 26834] Hiding Branches from the Libraries Link on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26834 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Holly --- *** This bug has been marked as a duplicate of bug 27360 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:01:06 +0000 Subject: [Koha-bugs] [Bug 27360] Libraries should be able to pick which branches display on the public 'Libraries' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27360 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #38 from Holly --- *** Bug 26834 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:05:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:05:24 +0000 Subject: [Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 --- Comment #5 from Martin Renvoize --- Sorry, been a busy time as usual. I think you are right that it's a bit confusing/inconsistent at the moment but as I'm not all that close to cataloguing personally I need to ask colleagues for an opinion to really know what would be best. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:05:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:05:37 +0000 Subject: [Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:07:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:07:44 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #8 from Martin Renvoize --- Thanks for testing and SO :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:13:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:13:12 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #3 from Martin Renvoize --- Are you thinking of working on this Nick.. it sounds like you had a hold of the issues it may present? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:13:32 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:15:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:15:19 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 --- Comment #5 from Martin Renvoize --- (In reply to Jonathan Druart from comment #4) > Should not we set the time part to 23:59:59 instead? I think it's what we do > in other parts. Seems reasonable to me... I'll add a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 10:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 09:39:23 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes an issue when release notes| |adding or editing record | |subfields using the | |authority plugin and it has | |a value with more than 100 | |characters. (When a | |subfield has more than 100 | |characters it changes to a | |text area rather than a | |standard input field, this | |caused JavaScript issues | |when using authority terms | |over 100 characters.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 11:03:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 10:03:41 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This turns autocompletion release notes| |off for userid and password | |fields on the login forms | |for the OPAC and staff | |interface. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 11:22:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 10:22:10 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the release notes| |accessibility of the OPAC | |by increasing the contrast | |ratio for buttons, making | |the button text easier to | |read. | | | |As part of this | |change the OPAC SCSS was | |modified so that a "base | |theme color" variable is | |defined which can be used | |to color button backgrounds | |and similar elements. It | |also moves some other | |colors into variables and | |removes some unused CSS. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 11:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 10:27:37 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128060|0 |1 is obsolete| | --- Comment #3 from Thibaud Guillot --- Created attachment 128271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128271&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind Signed-off-by: ThibaudGLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 11:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 10:58:38 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the saved release notes| |reports page so that the | |NumSavedReports system | |preference works as | |intended - the number of | |reports listed should | |default to the value in the | |system preference (the | |initial default is 20). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:05:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:05:56 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the link from release notes| |thea patron club name on | |the patrons club listing | |page as it didn't work. It | |also improves the | |consistency of the table of | |patron clubs so that the | |interface is consistent | |whether you're looking at | |clubs during the holds | |process or during the clubs | |management view. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:11:24 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:11:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:11:28 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128076|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi --- Created attachment 128272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128272&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:11:32 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128077|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi --- Created attachment 128273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128273&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:11:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:11:35 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128078|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi --- Created attachment 128274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128274&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:18:08 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > "Suspend until" is not saved. > > + var suspend_until_date = > $("#suspend-modal-until").datepicker("getDate"); > > We are not using flatpickr Right, it was migrated after the patches were tested. > + if (jqXHR.status === 404) { > > What about other errors? We shouldn't ignore them IMO. I'm not sure. I mean, it is doing the exact same thing it did before. Would you agree with a fallback for the rest of the errors like 'Your request could not be processed. Check the logs' kind of thing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:25:10 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #18) > Created attachment 128048 [details] [review] > ALT: An idea of doing it at singular level? > > In this patch I add 'user', containing the Koha::Patron object for the > logged in user in the params hash we pass around in to_api. I then use > that in a new 'is_accessible_in_context' method added to Koha::Patron. > > The method name is a bit of a mouthfull.. it could be 'is_limited' as > it's really the equivilent of 'search_limited' in the plural class.. but > I wasn't sure that was actually clearer... if we like it we could strip > back out some of the work around search_related. > > As an asside, I also update Koha::Patron->can_see_patrons_from to use > Koha::Patron->libraries_where_can_see_patrons internally.. DRY! I like your approach. Also, things like $self->libraries_where_can_see_patrons in Koha::Patron could be cached and thus reused in further recursive calls. That would be great, to mitigate the overhead this will introduce! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:27:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:27:09 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the release notes| |accessibility of | |breadcrumbs so that they | |adhere to the WAI-ARIA | |Authoring Practices. It | |covers additional | |breadcrumbs that weren't | |fixed in bug 27486 in these | |areas: | |* Home > | |Acquisitions > [Vendor name | |> [Basket name] | |* Home > | |Administration > Set | |library checkin and | |transfer policy | |* Home > | |Patrons > Merge patron | |records CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:32:51 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a small typo in release notes| |the breadcrumbs section for | |ILL requests - it had an | |extra › HTML entity | |after "Home". CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:34:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:34:02 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #39 from Martin Renvoize --- I've discussed this a little offline with a few people but never found a moment to put it down as a comment here. I think this bug starts going in the right direction.. but.. I don't think we should continue down the route of 'nesting' permissions in a hierarchy. I'd rather see 'a bag of permissions' and then ways to arbitrarily group them.. be that for 'roles' or 'permissions groups' or whatever. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:39:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:39:30 +0000 Subject: [Koha-bugs] [Bug 28716] Hide toolbar and opaccredits when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28716 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the toolbar release notes| |(Advanced Search | | |Authority Search | etc) and | |opaccredits (where set) | |from printed lists. The | |printed lists are cleaner | |without these. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:45:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:45:25 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement changes release notes| |the way the "Suppressed in | |OPAC" message is shown on | |the staff interface search | |results and the | |bibliographic detail page. | |Now the information is | |displayed like other | |bibliographic details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 12:53:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 11:53:13 +0000 Subject: [Koha-bugs] [Bug 29473] [DOCS 21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 --- Comment #2 from David Nind --- Spreadsheet updated for bugs pushed for week ended 6 December 2021. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:13:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:13:43 +0000 Subject: [Koha-bugs] [Bug 29645] [DOCS] Update manual theme for 19.11 and 20.05 to match later versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from David Nind --- Change to theme made for 1911 and 20.05: * 19.11 - commit: https://gitlab.com/koha-community/koha-manual/-/commit/39a216490605aad808a2f8b0dbd7c14630a7b031 * 20.05 - last commit (x3 - original + 2 follow-ups): https://gitlab.com/koha-community/koha-manual/-/commit/3a2cce486fb4204ed8d7e8f319f59afe312abb03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:16:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:16:46 +0000 Subject: [Koha-bugs] [Bug 29473] [DOCS 21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 --- Comment #3 from David Nind --- (In reply to David Nind from comment #2) > Spreadsheet updated for bugs pushed for week ended 6 December 2021. Wrong bug - should have been for 22.05 documentation changes (bug 29640)! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:17:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:17:27 +0000 Subject: [Koha-bugs] [Bug 29640] [DOCS 22.05] Documentation changes for 22.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29640 --- Comment #2 from David Nind --- Spreadsheet updated for bugs pushed to 22.05 for the week ended 6 December 2021. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:44:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:44:10 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | Severity|normal |major CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:44:34 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:45:37 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 13:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 12:45:41 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128240|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 128275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128275&action=edit Bug 29637: AutoSwitchPatron should look for card number in the barcode Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:05:11 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #18 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #17) > (In reply to Jonathan Druart from comment #15) > > + if (jqXHR.status === 404) { > > > > What about other errors? We shouldn't ignore them IMO. > > I'm not sure. I mean, it is doing the exact same thing it did before. Would > you agree with a fallback for the rest of the errors like 'Your request > could not be processed. Check the logs' kind of thing? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:06:41 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #18) > (In reply to Tomás Cohen Arazi from comment #17) > > (In reply to Jonathan Druart from comment #15) > > > + if (jqXHR.status === 404) { > > > > > > What about other errors? We shouldn't ignore them IMO. > > > > I'm not sure. I mean, it is doing the exact same thing it did before. Would > > you agree with a fallback for the rest of the errors like 'Your request > > could not be processed. Check the logs' kind of thing? > > Yes. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:36:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:36:44 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:36:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:36:49 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128252|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 128277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128277&action=edit Bug 5697: Automatic linking in guided reports This patch modifies the output of reports so that if certain columns are returned the data in the colums automatically offer menus of actions: - borrowernumber: View, edit, check out - cardnumber: Check out - itemnumber: View, edit - biblionumber: View, edit Like the menu of batch operations, this functionality is available only if the column is returned with its original name (e.g. biblionumber or [[biblionumber|Biblio number]] but not "biblionumber AS `Biblio number`). To test, apply the patch and run a report which will return examples of each kind of data. I used: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() LIMIT 50 When the report runs you should see that the data in each affected column is displayed as a link, each of which should trigger the correct menu. Test each case to confirm that the correct page is opened. Test the "toggle data menus" control. Clicking it should hide and show the menus in the report results. The selection persists until the user logs out. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:45:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:45:28 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:45:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:45:34 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128163|0 |1 is obsolete| | Attachment #128164|0 |1 is obsolete| | Attachment #128165|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 128278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128278&action=edit Bug 9565: Deleting a biblio should alert/fail if there are existent subscriptions Currently Koha will delete a biblio record if there are existent serial subscriptions. This patch will prevent deleting the biblio until attached subscriptions are removed. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Séverine QUEUNE Signed-off-by: Frank Hansen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:45:39 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #22 from Jonathan Druart --- Created attachment 128279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128279&action=edit Bug 9565: (follow-up) Deleting a biblio should alert/fail if there are existent subscriptions Clicking on "Delete record" while there are existent subscriptions no longer delete the record and the subscription. Instead an alert box inform the user that he must delete all subscription before deleting the record. To test: 1) Add a subscription to a biblio, or check a biblio which has one attached already. 2) Remove all items if there are any. 3) Apply patch. 4) Confirm that the 'Delete record' item is disabled in the list. 5) Attempt to 'Delete record', you should recieve an error message stating to delete all subscriptions before deleting record. 6) Sign off. Sponsored by: Lunds Universitetsbibliotek Signed-off-by: Samu Heiskanen Signed-off-by: Frank Hansen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:45:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:45:43 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #23 from Jonathan Druart --- Created attachment 128280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128280&action=edit Bug 9565: (follow-up) Adapt batch record deletion tool Add a column "Subscriptions" to the batch deletion tools Add a link on the number of subscription to the search page with all the subscriptions of the record Add a button in the toolbar to select only biblio record without subscriptions The changes are only on display It is still possible to delete records that are attached to subscriptions from this tool (as it is possible for records with attached items) To test: 1) Go to the batch record deletion (in tools) 2) Select a list of record numbers (select some with one or more subscription) 3) Click on Continue 4) Check that there is no column named "Subscription" and that there is no button "Select without subscription" in the toolbar 5) Apply patch 6) Repeat steps 1 to 3 7a) Check that there is a column named "Subscription" fill with the number of subscriptions attached to the record 7b) Check that the link in the subscriptions column send you to the search page with the subscriptions linked to this record 7c) Check that there is a button "Select without subscription" in the toolbar that selects record with no subscription attached 8) Sign off Signed-off-by: Frank Hansen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:45:49 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #24 from Jonathan Druart --- Created attachment 128281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128281&action=edit Bug 9565: Use Koha::Biblio Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:48:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:48:16 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #25 from Jonathan Druart --- Nice one Marion. I have attached a follow-up to use Koha::Biblio instead of subroutines from C4. Also I am not sure the "without" links on top of the table are actually useful as it, I think they should work together: like you want to uncheck biblios that have items then those without subscriptions. Not considering blocker as it's the current behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:49:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:49:16 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor at tuxayo.net |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |marion.durand at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 14:55:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 13:55:44 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 16:16:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 15:16:04 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #5 from Owen Leonard --- (In reply to Jonathan Druart from comment #4) > First the NumSavedReports syspref should be removed in favour of the > "default display length" table setting we now have. Bug 17465 didn't have any discussion on it about why we needed a separate system preference, but since the numSearchResults predates it I think we must assume that the intention of Bug 17465 was to create an exception to the numSearchResults setting. On the other hand, perhaps the need for NumSavedReports is not as great now that we have better searching via DataTables? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 16:17:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 15:17:01 +0000 Subject: [Koha-bugs] [Bug 29639] OPAC cart and staff cart are not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639 --- Comment #1 from Owen Leonard --- I caution against consistency for consistency's sake because the OPAC and staff interface serve very different purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 16:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 15:34:34 +0000 Subject: [Koha-bugs] [Bug 29624] ITEMTYPECAT Icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29624 --- Comment #2 from Eliana --- (In reply to Katrin Fischer from comment #1) > Hi Eliana, do you use the "remote icon" option? I think then this would be > bug 7374. > > IIRC it works if you add the path to the database table directly, it just > doesn't work correctly for setting it from the GUI. But we should fix this > properly. > > *** This bug has been marked as a duplicate of bug 7374 *** Whoops, yep. I didn't see that bug, but this is the same problem I was describing. Thank you for the tip! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 17:06:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 16:06:24 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 --- Comment #8 from Lucas Gass --- (In reply to Katrin Fischer from comment #6) > Hi Lucas, can you please check if this is a duplicate to bug 29571? Katrin, looks like a duplicate to me. I will close this one but I am curious if Bug 29571 needs Andreas's follow-up. I am unable to reproduce the edge case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 17:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 16:06:53 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #9 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 29571 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 17:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 16:06:53 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- *** Bug 29628 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 17:33:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 16:33:03 +0000 Subject: [Koha-bugs] [Bug 29031] Authorities see also links - plack error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29031 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Authority data support Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 17:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 16:37:18 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 18:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 17:12:38 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128247|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 128282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128282&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 18:12:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 17:12:41 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 --- Comment #5 from Owen Leonard --- Created attachment 128283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128283&action=edit Bug 29621: (follow-up) Make all views consistent This follow-up makes various views more consistent: OPAC search results, OPAC details, staff search results, and staff details. The patch also adds an indication to the user which lists are private. To test, apply the patch and rebuild the OPAC and staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Repeat the previous test plan in the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 18:17:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 17:17:18 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 18:24:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 17:24:56 +0000 Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 --- Comment #2 from Heather --- We're now on 21.05 with Elasticsearch and the call numbers are no longer sorting correctly--call numbers with the cutter S5:2 are sorting before S5. --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:32:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:32:34 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #10 from Victor Grousset/tuxayo --- IIUC if something goes wrong so will the CI image. And the API tests will catch that so I guess we can backport without worry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:41:43 +0000 Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 --- Comment #3 from Katrin Fischer --- (In reply to Heather from comment #2) > We're now on 21.05 with Elasticsearch and the call numbers are no longer > sorting correctly--call numbers with the cutter S5:2 are sorting before S5. > > --h2 Hi Heather! I think you might be seeing Bug 29632 - Callnumber sorting is incorrect in Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:41:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:41:45 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #6 from David Nind --- If we have a generic way of doing this for all tables with DataTables, then we should probably do that - whatever way, it should work. I'm all for making things as consistent as possible in the UI, and one less system preference is probably a good thing! Maybe a separate bug, since you have got this back working... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:46:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:46:42 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #4 from David Nind --- Note that bug 26352 no longer seems to work (unless I set things up wrong) - see my note on the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:47:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:47:47 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #10 from Donna --- >From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind. I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 19:53:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 18:53:36 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #1 from Blou --- Created attachment 128284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128284&action=edit Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:09:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:09:03 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com, | |philippe.blouin at inlibro.com Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch Text to go in the| |Improved display of MARC release notes| |field 260 in the detail | |page by respecting the | |order of subfields in the | |record. Previously, | |$a$b$a$b would be displayed | |as aabb. Assignee|oleonard at myacpl.org |philippe.blouin at inlibro.com --- Comment #2 from Blou --- I was going to create a new ticket, but am happy to have found that someone else already raised the issue (albeit 5 years ago). I had to dig, being no xslt expert, and finding no other example in the code for that ordering problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:09:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:09:09 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #11 from Lucas Gass --- (In reply to Donna from comment #10) > From a workflow point of view, logged in makes sense as the first choice. I > feel the second option should be blank. That indicates to staff that there > is something unusual about this hold, and they need to verify the pickup > location. If we make alpha the second choice then we will be back at square > one with staff placing holds for pickups at locations that may never fill. > The idea behind this change originally was to prevent unfillable holds, so > we need to keep that in mind. > > I think the main issue was that users did not fully understand why the > change was made. We just need to make sure that it is clearly explained why > the change is being made. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:43:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:43:43 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #12 from Katrin Fischer --- (In reply to Lucas Gass from comment #11) > (In reply to Donna from comment #10) > > From a workflow point of view, logged in makes sense as the first choice. I > > feel the second option should be blank. That indicates to staff that there > > is something unusual about this hold, and they need to verify the pickup > > location. If we make alpha the second choice then we will be back at square > > one with staff placing holds for pickups at locations that may never fill. > > The idea behind this change originally was to prevent unfillable holds, so > > we need to keep that in mind. > > > > I think the main issue was that users did not fully understand why the > > change was made. We just need to make sure that it is clearly explained why > > the change is being made. > > +1 +1 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:45:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:45:22 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #7 from Katrin Fischer --- (In reply to David Nind from comment #6) > If we have a generic way of doing this for all tables with DataTables, then > we should probably do that - whatever way, it should work. > > I'm all for making things as consistent as possible in the UI, and one less > system preference is probably a good thing! > > Maybe a separate bug, since you have got this back working... That's my thought too - let's make the move to table configuration but treat this as a bug fix until we have the better solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:47:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:47:20 +0000 Subject: [Koha-bugs] [Bug 29648] New: Replace NumSavedReports with table configuration setting Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Bug ID: 29648 Summary: Replace NumSavedReports with table configuration setting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 29530 discussed, that the NumSavedReports would be better placed as an option in the table configuration settings. Using this as a pattern could also then help add this option to more tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:47:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:47:43 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29648 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:47:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:47:43 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29530 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 20:55:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 19:55:05 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #8 from David Nind --- (In reply to Katrin Fischer from comment #7) > That's my thought too - let's make the move to table configuration but treat > this as a bug fix until we have the better solution. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:03:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:03:56 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:17:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:17:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:17:42 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128255|0 |1 is obsolete| | Attachment #128256|0 |1 is obsolete| | Attachment #128257|0 |1 is obsolete| | Attachment #128258|0 |1 is obsolete| | Attachment #128259|0 |1 is obsolete| | Attachment #128260|0 |1 is obsolete| | Attachment #128261|0 |1 is obsolete| | Attachment #128262|0 |1 is obsolete| | Attachment #128263|0 |1 is obsolete| | Attachment #128264|0 |1 is obsolete| | Attachment #128265|0 |1 is obsolete| | Attachment #128266|0 |1 is obsolete| | Attachment #128267|0 |1 is obsolete| | Attachment #128268|0 |1 is obsolete| | Attachment #128269|0 |1 is obsolete| | --- Comment #398 from Michal Denar --- Created attachment 128285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128285&action=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:17:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:17:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #399 from Michal Denar --- Created attachment 128286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128286&action=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:01 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #400 from Michal Denar --- Created attachment 128287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128287&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:11 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #401 from Michal Denar --- Created attachment 128288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128288&action=edit Bug 15516: Schema updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:19 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #402 from Michal Denar --- Created attachment 128289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128289&action=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:28 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #403 from Michal Denar --- Created attachment 128290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128290&action=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #404 from Michal Denar --- Created attachment 128291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128291&action=edit Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:47 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #405 from Michal Denar --- Created attachment 128292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128292&action=edit Bug 15516: (follow-up) Fixing file permissions and title elements order Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:18:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:18:55 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #406 from Michal Denar --- Created attachment 128293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128293&action=edit Bug 15516: Fix shebang in hold-group.pl Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #407 from Michal Denar --- Created attachment 128294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128294&action=edit Bug 15516: (follow-up) Count group holds always Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:13 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #408 from Michal Denar --- Created attachment 128295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128295&action=edit Bug 15516: Fix hold groups for multi items for one bib Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #409 from Michal Denar --- Created attachment 128296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128296&action=edit Bug 15516: Add ability to create hold groups from OPAC This patch adds a "Treat as hold group" to opac-reserve.pl, which lets OPAC users create a hold group which can include 1+ bibs and either bib-level holds, or item-level holds, or both. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #410 from Michal Denar --- Created attachment 128297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128297&action=edit Bug 15516: Show user's hold groups to user via OPAC This patch shows the item-level and bib-level holds in a hold group for the user's holds in the OPAC. This includes both the opac-user.pl page and the self-checkout hold display. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:37 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #411 from Michal Denar --- Created attachment 128298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128298&action=edit Bug 15516: (follow-up) Prevent cancelling unintended holds And a fix for consistent TT code Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:19:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:19:46 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #412 from Michal Denar --- Created attachment 128299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128299&action=edit Bug 15516: (follow-up) Fix hold group details not showing Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:26:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:26:52 +0000 Subject: [Koha-bugs] [Bug 29649] New: [DOCS] What's new section Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 Bug ID: 29649 Summary: [DOCS] What's new section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Consider creating a "What's new" section that highlights in a "librarian friendly" way the new features, enhancements, and things fixed in a release - each item would eventually link to the updated section(s) in the documentation. This could make it easier for Koha Community members to identify what's new in a release, and save some of the work that support providers do each release highlighting the changes (or at least create a good starting point!). It could also be supported by a presentation (for use at events) and a video. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:27:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:27:22 +0000 Subject: [Koha-bugs] [Bug 29649] [DOCS] What's new section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:27:42 +0000 Subject: [Koha-bugs] [Bug 29649] [DOCS] What's new section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:32:51 +0000 Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 --- Comment #4 from Heather --- (In reply to Katrin Fischer from comment #3) It sure could be, Katrin! Nick Clemens filed bug 29632 just a few days ago--maybe that's a duplicate of this one? Or that's a better written/better one than this one, which has been languishing for years? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:35:41 +0000 Subject: [Koha-bugs] [Bug 29649] [DOCS] What's new section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from David Nind --- The idea for this was influenced by these presentations: 1. Best Practices for Creating & Managing Release Notes (Part One): https://heretto.com/best-practices-for-creating-and-managing-release-notes-part-one/ (and also https://heretto.com/release-notes-webinar-part-1/) 2. Webinar: Release Notes Part 2 https://heretto.com/release-notes-part-2/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:38:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:38:00 +0000 Subject: [Koha-bugs] [Bug 29638] [DOCS] Framework default value for year is not <> but is <> In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29638 --- Comment #6 from Fridolin Somers --- (In reply to Katrin Fischer from comment #2) > Hi Fridolin, the documentation team agreed on using Bugzilla a while ago. So > I think we don't need to file on gitlab separately. Ah OK Sorry, I see we use Component=Documentation. Thanks Katrin and David ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 21:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 20:49:47 +0000 Subject: [Koha-bugs] [Bug 17269] Library::CallNumber::LC does not follow LC standards for Area Subarrangments of cataloged maps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17269 --- Comment #5 from Katrin Fischer --- I think Barton's bug was about a possible issue with the library we use to generate the cn_sort - the sortable form of the callnumber - for LC callnumbers. As this should be fixed by the maintainers of this library, he has filed it here: https://github.com/libraryhackers/library-callnumber-lc/issues/10 If things have worked ok for you before, they will probably work ok once Elasticsearch uses cn_sort for sorting as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 23:19:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 22:19:31 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #38 from Fridolin Somers --- If you used plugin koha-plugin-barcode-transformer, I confirm it does not work. I've opened an issue : https://github.com/bywatersolutions/koha-plugin-barcode-transformer/issues/5 I've created a pull-request on KitchenSink to add an easy example for this two hooks : https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/pull/17 Those hooks use a ref to value which is not easy to understand, we have to document it well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 23:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 22:20:05 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128233|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi --- Created attachment 128300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128300&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 23:21:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 22:21:13 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Donna from comment #10) > From a workflow point of view, logged in makes sense as the first choice. I > feel the second option should be blank. That indicates to staff that there > is something unusual about this hold, and they need to verify the pickup > location. If we make alpha the second choice then we will be back at square > one with staff placing holds for pickups at locations that may never fill. > The idea behind this change originally was to prevent unfillable holds, so > we need to keep that in mind. > > I think the main issue was that users did not fully understand why the > change was made. We just need to make sure that it is clearly explained why > the change is being made. Agreed, patch adjusted. If we need more options for special use cases, we will need to consider separate bug, and more complex configurations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 23:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 22:30:50 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 --- Comment #39 from David Nind --- (In reply to Fridolin Somers from comment #38) > If you used plugin koha-plugin-barcode-transformer, I confirm it does not > work. Thanks Fridolin! I had used that plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 6 23:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 22:56:57 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #791 from Aleisha Amohia --- I've developed this further for a university library so I have patches that would possibly help it to work more in the way that academic libraries might expect? I'll contact you all about progressing with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 00:03:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 23:03:26 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #16 from Fridolin Somers --- (In reply to David Nind from comment #15) > Created attachment 128239 [details] > Bug 29605 - Error messages after reset_all > > I had a go at testing this, but I get "BEGIN failed--compilation aborted > at...." error messages after the reset_all command. > > See attachment for the command line log. Ah 21.05.x does not have same perl deps as 21.11. Try installing package libemail-valid-perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 00:05:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 23:05:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #792 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #791) > I've developed this further for a university library so I have patches that > would possibly help it to work more in the way that academic libraries might > expect? > > I'll contact you all about progressing with this. Hi Aleisha, I volunteered to work on this at the beginning of this cycle, but have to admit, I still have to start digging into it. Any additional information is very welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 00:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Dec 2021 23:17:40 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- (In reply to David Nind from comment #4) > Note that bug 26352 no longer seems to work (unless I set things up wrong) - > see my note on the bug. I've tested with KitchenSink and pull-request : https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/pull/17 All good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 02:31:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 01:31:57 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #6 from David Nind --- (In reply to Fridolin Somers from comment #5) > All good. Excellent! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:24 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:29 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118258|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia --- Created attachment 128301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128301&action=edit Bug 24194: Add DisableReserveExpiration system preference to hide expiration date options for reserves To test: 1) Update database 2) Go to place a hold on any biblio in the staff intranet and confirm you can see the 'Hold expires on date' field. 3) In another tab, go to place a hold on any biblio in the OPAC and confirm you can see the 'Hold not needed after' field as an option. 4) In yet another tab, open the staff intranet and place a reserve for a user. Check it in and set the reserve as waiting. Notice that an expiration date has now been generated for this reserve. 5) Attempt to check out the item you reserved to some other borrower. Revert waiting status. Notice that the expiration date that was generated remains. 6) Go to Administration -> system preferences and set DisableReserveExpiration system preference to 'Disable' 7) Refresh the hold request page in the intranet. Confirm the expiration date field disappears. 8) Refresh the hold request page in the OPAC. Confirm the expiration date field disappears. 9) Place another reserve. Check it in and set the reserve as waiting. Notice that no expiration date was generated for this reserve. 10) Attempt to check out the item you reserved to some other borrower. Revert waiting status. The expiration date should remain null. 11) Confirm tests pass t/db_dependent/Hold.t t/db_dependent/Reserves.t Sponsored-by: Horowhenua Library Trust Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=24914 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:34 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118259|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia --- Created attachment 128302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128302&action=edit Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more - change syspref description to say 'holds' instead of reserves - clarify descriptions of related sysprefs - hide expiration column on reserves page - move syspref to 'hold policy' section - fix cancel_expired_holds.pl cron to consider syspref - set expirationdate to undef always https://bugs.koha-community.org/show_bug.cgi?id=24194 Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:39 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118260|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia --- Created attachment 128303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128303&action=edit Bug 24194: (follow-up) Renaming syspref to ReserveExpiration Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=24914 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:44 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118261|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia --- Created attachment 128304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128304&action=edit Bug 24194: (follow-up) Correct some missing instances This patch fixes some instances where hold expiration dates are set or referenced. To test, apply the patch and test the following pages with the ReserveExpiration preference both on and off to confirm that expiration dates are shown or hidden correctly. Pages in the staff interface: - Check out to a patron and check the holds tab - View patron details and check the holds tab - Patron hold history - Patron details -> Print -> Print summary - Place a hold on a title which already has at least one hold on it, check the table of existing holds. Pages in the OPAC: - Log in to the OPAC as a patron with holds - Your summary -> Holds tab - Your holds history (OPACHoldsHistory must be enabled). Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=24914 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:49 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118262|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia --- Created attachment 128305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128305&action=edit Bug 24194: (follow-up) Link references to new preference As was done in Bug 27263, references to one system preference in another system preference's description should be a link back to the mentioned preference. To test, apply the patch go to Administration -> Global system preferences. - Search for "ReserveExpiration." - Besides the preference itself, you should get four other preferences which have mentions of "ReserveExpiration" in their descriptions. - Confirm that each mention in the description is a link to a search for "ReserveExpiration." Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=24914 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:54 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118263|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia --- Created attachment 128306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128306&action=edit Bug 24194: (follow-up) Use ReservesExpiration in other places -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:09:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:09:59 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #54 from Aleisha Amohia --- Created attachment 128307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128307&action=edit Bug 24194: (follow-up) Use ExpireReservesMaxPickUpDelay when setting hold waiting If ExpireReservesMaxPickUpDelay is disabled then we don't need to set an expiration date when setting a hold as waiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 05:10:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 04:10:04 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 --- Comment #55 from Aleisha Amohia --- Created attachment 128308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128308&action=edit Bug 24194: (follow-up) Throw an error if expiration date used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 06:42:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 05:42:03 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 --- Comment #2 from Minna Kivinen --- Yes I have set default value for subfield 7 to -1 in ACQ framework. Actually it seems that Koha does not read all default values from the framework for the first item when adding on one item at time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 09:06:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 08:06:27 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 --- Comment #3 from Katrin Fischer --- Hi Minna, is this in 21.11.00? And does the not for loan show as empty in the item form in acq? (it should not... but...) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 09:09:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 08:09:48 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 --- Comment #4 from Minna Kivinen --- Yes it is in 21.11. And the field is empty when editing the aq-item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 09:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 08:13:37 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 09:14:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 08:14:36 +0000 Subject: [Koha-bugs] [Bug 29619] Ordering single item does not save item as Ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29619 --- Comment #5 from Katrin Fischer --- Thx Minna, I've updated severity to get more attention. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 09:48:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 08:48:44 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #13 from Samu Heiskanen --- Created attachment 128309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128309&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" I tried to fix this bug with my previous attempt, but introduced a new bug. I return the line: my $biblio = Koha::Biblios->find( $biblionumber ); to it's previous place and just copy it to the end of the foreach loop. The display infos for template will remain as they were in my first attempt. Hope this fix works properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:19:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:19:36 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |testopia at bugs.koha-communit | |y.org Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:19:39 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #17 from David Nind --- (In reply to Fridolin Somers from comment #16) > Ah 21.05.x does not have same perl deps as 21.11. > Try installing package libemail-valid-perl. Thanks Fridolin - that did the trick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:29:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:29:41 +0000 Subject: [Koha-bugs] [Bug 29650] New: False update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 Bug ID: 29650 Summary: False update Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vvishnuaejith at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 128310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128310&action=edit patron id :1028 book TB9218 on 22-11-2021 i renewed 3 books .The transaction log on that day shows the three books renewed successfully. But on the Patron page only 2 books renewed remaining one books on the same due date.due date not updated.There is no auto increment problem in the server. book:TB9218 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:30:24 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 --- Comment #1 from Vishnu Jith --- Created attachment 128311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128311&action=edit Patron home -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:31:03 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 --- Comment #2 from Vishnu Jith --- Created attachment 128312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128312&action=edit Server info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:41:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:41:33 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #18 from David Nind --- Created attachment 128313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128313&action=edit Bug 29605 - Result from git diff I followed Jonathan's test plan in comment 12 - I've attached the diff, so I hope that is what is expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:45:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:45:31 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #19 from David Nind --- Created attachment 128314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128314&action=edit Bug 29605 - Error when accessing staff interface and OPAC I haven't signed off because when I try to go into the staff interface or the OPAC I get errors (after flush_memcached and restart_all) - see the attached error trace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 10:46:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 09:46:08 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m Assignee|fridolin.somers at biblibre.co |thibaud.guillot at biblibre.co |m |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 11:02:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 10:02:21 +0000 Subject: [Koha-bugs] [Bug 29651] New: Add a note field to invoices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29651 Bug ID: 29651 Summary: Add a note field to invoices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be great if there was a note field for storing additional information for notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 11:34:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 10:34:24 +0000 Subject: [Koha-bugs] [Bug 24180] maintain separate repeated subfields when linking authority in advanced catalog editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24180 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com --- Comment #3 from Lucy Vaux-Harvey --- We have a library reporting the same issue in the advanced cataloguing editor with the 610 tag and multiple $v subfields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 11:47:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 10:47:33 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #1 from marion.durand at biblibre.com --- (be sur to have at least one Z39-50 or SRU serveur set for authority or the fisrt buton won't be displayed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 13:08:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 12:08:21 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancment moves |This enhancment moves release notes|C4::Biblio::GetMarcAuthors |C4::Biblio::GetMarcAuthors |to |to |Koha::Biblio->get_authors_f |Koha::Biblio->get_marc_auth |rom_MARC. This is so the |ors. This is so the method |method can be used in |can be used in templates |templates and notices. |and notices. CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 13:14:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 12:14:50 +0000 Subject: [Koha-bugs] [Bug 29652] New: Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Bug ID: 29652 Summary: Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When you look at the methods code, you notice - It is tied to the Koha::Biblio::Metadata->record - The code branches depending on information that is passed, that is already present at the Koha::Biblio::Metadata object/level (MARCFLAVOUR=schema, the record itself) There should still exist a Koha::Biblio->authors/notes method to retrieve this information at that level, but calling the metadata object methods. This way the caller could do: my $biblio = Koha::Biblios->find( $biblio_id, { prefetch => ['biblio_metadata'] } ); and even save some queries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 13:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 12:15:14 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27266, 27268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 13:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 12:15:14 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 13:15:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 12:15:14 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 14:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 13:24:23 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master CC| |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 14:29:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 13:29:20 +0000 Subject: [Koha-bugs] [Bug 29618] Typing a Patron Name into the checkout bar goes moremember.pl instead of circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29618 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Andrew Fuerste-Henry --- I can confirm the behavior Lisette describes in 21.05.04, but it is mysteriously fixed in 21.05.07. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 14:31:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 13:31:04 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 14:41:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 13:41:45 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #34 from Katrin Fischer --- We just updated to 20.11.12 and noticed that libyaml-libyaml-perl was missing. This was marked only for 21.05, but is it possible a backport could require it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 14:57:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 13:57:21 +0000 Subject: [Koha-bugs] [Bug 29250] "Show checkouts/fines to guarantor" cannot be set to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29250 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I am unable to replicate this error on 21.05.07, 21.05.x, or master. Sally, what version did you see it on? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 15:17:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 14:17:25 +0000 Subject: [Koha-bugs] [Bug 29250] "Show checkouts/fines to guarantor" cannot be set to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29250 --- Comment #2 from Sally --- (In reply to Andrew Fuerste-Henry from comment #1) > I am unable to replicate this error on 21.05.07, 21.05.x, or master. Sally, > what version did you see it on? Master was at 21.05.04 when I logged the bug - and it's in 20.11.10 It looks to me as if this duplicate bug has the fix on it: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 15:25:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 14:25:10 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #20 from Nick Clemens --- (In reply to David Nind from comment #19) > Created attachment 128314 [details] > Bug 29605 - Error when accessing staff interface and OPAC > > I haven't signed off because when I try to go into the staff interface or > the OPAC I get errors (after flush_memcached and restart_all) - see the > attached error trace. apt install libcgi-session-serialize-yaml-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 15:48:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 14:48:04 +0000 Subject: [Koha-bugs] [Bug 29250] "Show checkouts/fines to guarantor" cannot be set to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29250 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Andrew Fuerste-Henry --- *** This bug has been marked as a duplicate of bug 29524 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 15:48:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 14:48:04 +0000 Subject: [Koha-bugs] [Bug 29524] Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #10 from Andrew Fuerste-Henry --- *** Bug 29250 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 16:13:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 15:13:17 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 16:49:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 15:49:35 +0000 Subject: [Koha-bugs] [Bug 27673] Replace YAML with YAML::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 --- Comment #35 from Katrin Fischer --- (In reply to Katrin Fischer from comment #34) > We just updated to 20.11.12 and noticed that libyaml-libyaml-perl was > missing. This was marked only for 21.05, but is it possible a backport could > require it? It was cleared up on IRC: http://irc.koha-community.org/koha/2021-12-07#i_2392844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 19:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 18:59:07 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #21 from David Nind --- (In reply to Nick Clemens from comment #20) > apt install libcgi-session-serialize-yaml-perl Thanks Nick. I have installed that but get exactly the same error trace, so I'm not sure what might be going wrong with my KTD setup. if this is not an issue (it wasn't part of the test plan) for solving the actual bug as opposed to sorting out my KTD setup I would be happy to sign-off. On the other-hand, I don't want there to be additional problems.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:13:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:13:40 +0000 Subject: [Koha-bugs] [Bug 23456] Show 'date last seen' for items requested in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23456 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:22:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:22:03 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #15 from Lucas Gass --- Created attachment 128315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128315&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:32:04 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #4 from Michael Spagnuolo --- This is how I assumed it worked. I would like this option as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:45:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:45:19 +0000 Subject: [Koha-bugs] [Bug 29653] New: Return claims on deleted items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29653 Bug ID: 29653 Summary: Return claims on deleted items Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: mspagnuolo at nrhtx.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When an item that has been claims returned previously is deleted, the item no longer shows on the patron's account. I would prefer Koha to leave the name of the item or a place holder to be able to track claims returns better. Or perhaps a counter that is not dependent on the item being in the system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:46:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:46:00 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #24 from Fridolin Somers --- As a quickfix, I propose this JavaScript that sets empty when entering the input : $(document).ready(function() { $("#header_search #catalog_search input[name='q']").focusin(function() { $(this).val(""); }); }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:56:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:56:47 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:56:55 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125383|0 |1 is obsolete| | --- Comment #145 from Aleisha Amohia --- Created attachment 128316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128316&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:02 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125384|0 |1 is obsolete| | --- Comment #146 from Aleisha Amohia --- Created attachment 128317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128317&action=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:11 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125385|0 |1 is obsolete| | --- Comment #147 from Aleisha Amohia --- Created attachment 128318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128318&action=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:19 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125386|0 |1 is obsolete| | --- Comment #148 from Aleisha Amohia --- Created attachment 128319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128319&action=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:26 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125387|0 |1 is obsolete| | --- Comment #149 from Aleisha Amohia --- Created attachment 128320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128320&action=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:34 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125388|0 |1 is obsolete| | --- Comment #150 from Aleisha Amohia --- Created attachment 128321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128321&action=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:40 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125389|0 |1 is obsolete| | --- Comment #151 from Aleisha Amohia --- Created attachment 128322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128322&action=edit Bug 13952: (follow-up) Removing XML options Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 20:57:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 19:57:48 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125390|0 |1 is obsolete| | --- Comment #152 from Aleisha Amohia --- Created attachment 128323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128323&action=edit Bug 13952: (follow-up) fixing indentation and rebasing Signed-off-by: Mazen Khallaf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:14:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:14:37 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:14:42 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128316|0 |1 is obsolete| | Attachment #128317|0 |1 is obsolete| | Attachment #128318|0 |1 is obsolete| | Attachment #128319|0 |1 is obsolete| | Attachment #128320|0 |1 is obsolete| | Attachment #128321|0 |1 is obsolete| | Attachment #128322|0 |1 is obsolete| | Attachment #128323|0 |1 is obsolete| | --- Comment #153 from Michal Denar --- Created attachment 128324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128324&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:14:49 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #154 from Michal Denar --- Created attachment 128325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128325&action=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:00 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #155 from Michal Denar --- Created attachment 128326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128326&action=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:10 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #156 from Michal Denar --- Created attachment 128327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128327&action=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:17 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #157 from Michal Denar --- Created attachment 128328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128328&action=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:24 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #158 from Michal Denar --- Created attachment 128329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128329&action=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:30 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #159 from Michal Denar --- Created attachment 128330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128330&action=edit Bug 13952: (follow-up) Removing XML options Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:15:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:15:36 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #160 from Michal Denar --- Created attachment 128331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128331&action=edit Bug 13952: (follow-up) fixing indentation and rebasing Signed-off-by: Mazen Khallaf Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:32:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:32:53 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:32:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:32:57 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119341|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 128332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128332&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out, available on the shelf, or not available for checkout for some other reason). If checked out, also shows due date in item search results. Both the new availability and due date columns will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up three items. Check out Item A to a borrower. Set Item B to some damaged, notforloan, withdrawn etc status so that it is considered not available. Leave Item C as is, not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, Checked out, and Available. 4) Leave the Ignore option selected and do a search so that all three items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says Not available. Confirm Item C says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Items B and C). 8) Go to edit your search. Select the 'Available' radio option for Availability and submit the search. Confirm only Item B shows in the results (not Items A and C). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:33:02 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #10 from Aleisha Amohia --- Created attachment 128333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128333&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:44:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:44:54 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:44:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:44:57 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:45:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:45:34 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 21:59:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 20:59:14 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #16 from Christopher Brannon --- (In reply to Donna from comment #10) > From a workflow point of view, logged in makes sense as the first choice. I > feel the second option should be blank. That indicates to staff that there > is something unusual about this hold, and they need to verify the pickup > location. If we make alpha the second choice then we will be back at square > one with staff placing holds for pickups at locations that may never fill. > The idea behind this change originally was to prevent unfillable holds, so > we need to keep that in mind. > > I think the main issue was that users did not fully understand why the > change was made. We just need to make sure that it is clearly explained why > the change is being made. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:00:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:00:05 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Severity|enhancement |normal --- Comment #2 from Fridolin Somers --- Indeed, this is a bug (not enhancement) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:00:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:00:49 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Button "replace authority |Button "replace authority |record via Z39/50/SRU" |record via Z39/50/SRU" |doesn't work |doesn't pre-fill -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:05:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:05:30 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- What is your Koha version and install method/OS please ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:07:06 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #1 from Andrew Fuerste-Henry --- +100. On this page (waitingreserves.pl), we show the user the waitingdate (the date on which the item went to the hold shelf) and tell the user what the pickup delay value is, thereby very strongly implying that expirationdate will always equal waitingdate+pickup delay. Actually, there are a bunch of ways the expiration date can end up being something else. We should show the expirationdate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:09:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:09:41 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26457 --- Comment #4 from Fridolin Somers --- This may be like Bug 26457 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:09:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:09:41 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29650 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:21:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:21:50 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:53:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:53:27 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 22:53:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 21:53:30 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:02:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:02:05 +0000 Subject: [Koha-bugs] [Bug 28668] typo in Koha Manual 21.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28668 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |david at davidnind.com --- Comment #2 from David Nind --- Thanks Manu for identifying and raising the issue, and apologies for this taking so long to fix! I've made the changes to the manual, and some other changes that hopefully improve the text. The change will be live once the manual is regenerated. The changes made can be viewed at: https://gitlab.com/koha-community/koha-manual/-/commit/98ede183c6a09ad66b181d86c0849b4f09655cec Once I figure out the translation process, the string changes should come through to Pootle for translation. David Nind (Documentation Manager (22.05)) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:03:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:03:12 +0000 Subject: [Koha-bugs] [Bug 28668] [DOCS] Typo and repeated information in FAQ - Unable to place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28668 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|typo in Koha Manual 21.05 |[DOCS] Typo and repeated | |information in FAQ - Unable | |to place holds Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:03:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:03:55 +0000 Subject: [Koha-bugs] [Bug 28668] [DOCS] Typo and repeated information in FAQ - Unable to place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28668 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:07:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:07:07 +0000 Subject: [Koha-bugs] [Bug 29587] Test mail option in SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:10:12 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:10:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:10:14 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #14 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:19:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:19:08 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:19:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:19:11 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:28:21 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:28:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:28:24 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 --- Comment #2 from Lucas Gass --- Created attachment 128334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128334&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:28:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:28:48 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:29:49 +0000 Subject: [Koha-bugs] [Bug 29587] Test mail option in SMTP servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29587 --- Comment #1 from Pablo AB --- Meanwhile, after the SMTP server is selected on the library admin page, is possible to test them sending a list or the cart: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343#c125 And try to catch any errors grep mail /var/log/koha/$INSTANCE/intranet-error.log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:33:16 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 7 23:33:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 22:33:19 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:01:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:01:14 +0000 Subject: [Koha-bugs] [Bug 29654] New: Add Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 Bug ID: 29654 Summary: Add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:01:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:01:45 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add option to | |bulkmarimport.pl for | |matching on original id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:02:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:02:37 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 [Bug 29440] Refactor/clean up bulkmarcimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:02:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:02:37 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 [Bug 29654] Add option to bulkmarimport.pl for matching on original id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:07:42 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 --- Comment #1 from David Gustafsson --- If I'm not mistaken, currently in bulkmarkimport.pl, if no match is found for authorities the incoming record is used for matching against an existing Koha authority, this is not done for biblio records though. Instead of this inconsistent behaviour it would be better if there was an option to explicitly set if matching on incoming record ids should be performed or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:09:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:09:47 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 --- Comment #2 from David Gustafsson --- Created attachment 128335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128335&action=edit Bug 29654 - Add match_record_id option to bulkmarimport.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 00:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Dec 2021 23:11:22 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 --- Comment #3 from David Gustafsson --- Not yet ready for review, will later add how to test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 01:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 00:59:42 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #7) > Pushed to master for 22.05, thanks to everybody involved 🦄 Thank you. We need to have documentation people add more info now in Markdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 02:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 01:06:18 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128309|0 |1 is obsolete| | --- Comment #14 from Samu Heiskanen --- Created attachment 128336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128336&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 02:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 01:10:43 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128336|0 |1 is obsolete| | --- Comment #15 from Samu Heiskanen --- Created attachment 128337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128337&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 02:34:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 01:34:12 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128254|0 |1 is obsolete| | Attachment #128337|0 |1 is obsolete| | --- Comment #16 from Samu Heiskanen --- Created attachment 128338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128338&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 02:45:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 01:45:39 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128338|0 |1 is obsolete| | --- Comment #17 from Samu Heiskanen --- Created attachment 128339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128339&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 02:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 01:48:48 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128339|0 |1 is obsolete| | --- Comment #18 from Samu Heiskanen --- Created attachment 128340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128340&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 03:26:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 02:26:30 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 04:40:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 03:40:47 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 --- Comment #8 from David Nind --- I get this message when running the script after the patch is applied (koha-testing-docker): root at kohadevbox:koha(bz27265)$ perl misc/cronjobs/process_message_queue.pl -c HOLD Global symbol "$type" requires explicit package name (did you forget to declare "my $type"?) at misc/cronjobs/process_message_queue.pl line 89. Global symbol "$letter_code" requires explicit package name (did you forget to declare "my $letter_code"?) at misc/cronjobs/process_message_queue.pl line 90. Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) at misc/cronjobs/process_message_queue.pl line 96, near "};" Type of arg 1 to Try::Tiny::try must be block or sub {} (not reference constructor) at misc/cronjobs/process_message_queue.pl line 96, near "};" Execution of misc/cronjobs/process_message_queue.pl aborted due to compilation errors. It worked with a single letter type before the patch was applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:33:02 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 --- Comment #5 from Vishnu Jith --- (In reply to Fridolin Somers from comment #3) > What is your Koha version and install method/OS please ? Koha version: 19.11.12.000 Distributor ID: Debian Description: Debian GNU/Linux 9.9 (stretch) Release: 9.9 Codename: stretch Install method:command line operations in Terminal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:45:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:45:07 +0000 Subject: [Koha-bugs] [Bug 29649] [DOCS] What's new section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 --- Comment #2 from David Nind --- A related idea Bug 22890 - Add a chronological changelog. While not exactly the same there are some similarities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:46:35 +0000 Subject: [Koha-bugs] [Bug 29649] [DOCS] What's new section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29649 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:46:35 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29649 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:48:55 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- I was going to write a very different comment here based on what I read in the "Text to go in the release notes", but after re-reading the comments and code, I realized I totally misunderstood this change. You might consider changing the phrasing to something like "This patch allows one to specify several types or letter codes, instead of only one type or letter code, when running the process_message_queue script. This allows libraries to consolidate calls when some messages types or letter codes are scheduled differently than others." I thought this patch added the ability to specify types or letter codes in general, and I was going to comment on that ability, but that ability was added in a previous ticket... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:00 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101565|0 |1 is obsolete| | --- Comment #136 from Aleisha Amohia --- Created attachment 128341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128341&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:08 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101566|0 |1 is obsolete| | --- Comment #137 from Aleisha Amohia --- Created attachment 128342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128342&action=edit Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:16 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101567|0 |1 is obsolete| | --- Comment #138 from Aleisha Amohia --- Created attachment 128343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128343&action=edit Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:23 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101568|0 |1 is obsolete| | --- Comment #139 from Aleisha Amohia --- Created attachment 128344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128344&action=edit Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:30 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101569|0 |1 is obsolete| | --- Comment #140 from Aleisha Amohia --- Created attachment 128345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128345&action=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:36 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101570|0 |1 is obsolete| | --- Comment #141 from Aleisha Amohia --- Created attachment 128346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128346&action=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:42 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101571|0 |1 is obsolete| | --- Comment #142 from Aleisha Amohia --- Created attachment 128347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128347&action=edit Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:49 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101572|0 |1 is obsolete| | --- Comment #143 from Aleisha Amohia --- Created attachment 128348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128348&action=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:56:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:56:56 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101573|0 |1 is obsolete| | --- Comment #144 from Aleisha Amohia --- Created attachment 128349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128349&action=edit Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar Signed-off-by: Michal Denar Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:03 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101574|0 |1 is obsolete| | --- Comment #145 from Aleisha Amohia --- Created attachment 128350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128350&action=edit Bug 15326: (follow-up) Redindent new CMS page templates This patch is an opinionated reindent of new and changed templates related to the CMS feature. I think it would be nice for these templates to start out with good indentation. To test, apply the patch and test the CMS feature. There should be no visible change to the way it looks or the way it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:10 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101575|0 |1 is obsolete| | --- Comment #146 from Aleisha Amohia --- Created attachment 128351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128351&action=edit Bug 15326: (follow-up) Corrections to staff client templates This patch makes some corrections to the staff client's CMS-related templates: - Add missing Template Toolkit filters. - Remove JavaScript from tools-menu.inc. This must have crept in during a rebase. - Add navigation link highlighting to tools-menu.js instead. - Convert tools/cmspages.tt to Bootstrap grid. - Correct toolbar button class. - Move some column sorting configuration out of JS and into table markup. - Move "Select all" / "Clear all" links to the top of the table to match similar interfaces. - Change the Action menu's "Intranet" and "OPAC" links to be "View" and "View in OPAC." The OPAC view now opens a new window. To test, apply the patches and test the Pages feature in the staff client: Adding, editing, deleting, viewing. For each view, test that the page layout adjusts to various browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:18 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101576|0 |1 is obsolete| | --- Comment #147 from Aleisha Amohia --- Created attachment 128352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128352&action=edit Bug 15326: (follow-up) Remove obsolete LESS file, add TT filters Previous versions of this patch set adds a LESS file to the OPAC, which is now obsolete. It should be removed. In addition, the change made to opac.less contained CSS which didn't apply to any existing markup, so it need not be added to opac.scss. The patch also adds missing Template Toolkit filters to template files. None of these changes should be visible in testing. OPAC CMS pages should function as usual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:25 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101577|0 |1 is obsolete| | --- Comment #148 from Aleisha Amohia --- Created attachment 128353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128353&action=edit Bug 15326: Fix QA errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:32 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101578|0 |1 is obsolete| | --- Comment #149 from Aleisha Amohia --- Created attachment 128354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128354&action=edit Bug 15326: Fix filters and adjust tiny_mce assets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:38 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101579|0 |1 is obsolete| | --- Comment #150 from Aleisha Amohia --- Created attachment 128355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128355&action=edit Bug 15326: (follow-up) Template tweaks This patch makes some tweaks to the staff-side template: - Fix some indentation - Add some markup comments - Fix some HTML validation errors: Eliminate duplicate id attributes - Expand the descriptiveness of , breadcrumbs, and form legend - Increase size of link and title fields; Add maxlength attribute to title field. - Move title and link fields to the second column of the table -- more consistent with other tables where the main link is in the first column. - Link parent page information to corresponding edit page - Correct incorrectly filtered action links - Correct default table sort - Fix TinyMCE configuration - I copied some configuration code from another page which was updated more recently. To test, apply the patch and test the process of adding, editing, and deleting pages. Test all the options in the "Actions" menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:44 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-lV7yu6pYVk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #151 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128356&action=edit Bug 15326: (follow-up) WIP Fixing breadcrumbs Hiding private/unpublished pages etc Still working on pages navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 05:57:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 04:57:50 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-GwPDzSclwW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #152 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128357&action=edit Bug 15326: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 06:43:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 05:43:37 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: <bug-29578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29578-70-tqIyn2G9Xs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #9 from David Nind <david at davidnind.com> --- Hi Andreas and Thibaud. >From your screenshots I can see that what is described is happening, but I still can't reproduce it. I was testing on the latest master with Zebra koha-testing-docker. Are there any specific system preferences that need to be set, or any other configuration that needs to be done? David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 07:25:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 06:25:47 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: <bug-29650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29650-70-F1uDrpNURU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- OK thanks. You should consider upgrading to last version 21.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 08:57:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 07:57:08 +0000 Subject: [Koha-bugs] [Bug 29655] New: Email sender name setting Message-ID: <bug-29655-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29655 Bug ID: 29655 Summary: Email sender name setting Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: resetka.bedi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice if the name of the library, for example, was part of the email notifications in addition to KohaAdminEmailAddress. This procedure is not possible in the current version: https://wiki.koha-community.org/wiki/Adding_Custom_name_to_the_%27From%27_field_in_email_notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:15:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:15:02 +0000 Subject: [Koha-bugs] [Bug 29656] New: [DOCS] Version number in HTML output is hard to read Message-ID: <bug-29656-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29656 Bug ID: 29656 Summary: [DOCS] Version number in HTML output is hard to read Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org In the the HTML output for the manual the version number in the navigation heading is very dim and hard to read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:15:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:15:57 +0000 Subject: [Koha-bugs] [Bug 29656] [DOCS] Version number in HTML output is hard to read In-Reply-To: <bug-29656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29656-70-L7WSZwbDQI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29656 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:24:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:24:44 +0000 Subject: [Koha-bugs] [Bug 22428] MARC modification template cuts text to 100 characters In-Reply-To: <bug-22428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22428-70-D3gov8zMCW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:31:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:31:49 +0000 Subject: [Koha-bugs] [Bug 29657] New: OpacNavRight is only added to one language for OPACs with multiple active languages Message-ID: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657 Bug ID: 29657 Summary: OpacNavRight is only added to one language for OPACs with multiple active languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We are just starting our updates and in all updated instances the OpacNavRight entry hasn't been migrated correctly. The entry in the news is only added for one language, instead of all languages (default doesn't exist in 20.11 yet). So this requires a lot of manual work after the updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:32:16 +0000 Subject: [Koha-bugs] [Bug 29657] OpacNavRight is only added to one language for OPACs with multiple active languages In-Reply-To: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29657-70-TkLpViFsfL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:32:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:32:16 +0000 Subject: [Koha-bugs] [Bug 27909] When upgrading, old sysprefs are only copied in english news items In-Reply-To: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27909-70-8OhPiELWMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27909 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29657 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 09:32:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 08:32:46 +0000 Subject: [Koha-bugs] [Bug 27909] When upgrading, old sysprefs are only copied in english news items In-Reply-To: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27909-70-ip1EFjQRtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27909 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure if this is the case for all the migrations from sysprefs to news, but it's definitely not working correctly for OpacNavRight. I've filed: Bug 29657 - OpacNavRight is only added to one language for OPACs with multiple active languages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 10:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 09:14:38 +0000 Subject: [Koha-bugs] [Bug 29656] [DOCS] Version number in HTML output is hard to read In-Reply-To: <bug-29656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29656-70-yOygEALTJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29656 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #1 from David Nind <david at davidnind.com> --- I have added a custom css file to override the theme css styles. The custom css changes the colour of the version number to white. Back ported back to 19.11 versions of the manual. Commit: https://gitlab.com/koha-community/koha-manual/-/commit/26850c50fa4ca279ba2d38df8542976a57c2974c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 10:34:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 09:34:13 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-Fm9Hh6QLVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #153 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Aleisha, with the recent "additional contents" changes we could have a new type of content "page". They would be stored in the same DB table and would profit from the other possibilities (translation, etc.) Is it something that could work for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 10:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 09:37:46 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-QXvdTNvQg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27527 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 10:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 09:37:46 +0000 Subject: [Koha-bugs] [Bug 27527] Plugin hooks to create additional contents In-Reply-To: <bug-27527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27527-70-y4csPw7lVO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15326 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 10:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 09:47:54 +0000 Subject: [Koha-bugs] [Bug 29657] OpacNavRight is only added to one language for OPACs with multiple active languages In-Reply-To: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29657-70-gTVJVrBsdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I realize we might just have to live with this, as there won't be any new versions for 20.11 and lower. We could only fix it for those librares making a bigger jump in the old database update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:01:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:01:32 +0000 Subject: [Koha-bugs] [Bug 27382] [DOCS] [Omnibus] Typos in the manual In-Reply-To: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27382-70-aiSHCDDlgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Omnibus] Typos in the |[DOCS] [Omnibus] Typos in |manual |the manual CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:08:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:08:32 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-ILDjKaP7Ro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128234|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128358&action=edit Bug 27801: Fix javascript price calculations This patch ensures we're formatting the price values consistently for the table total and the amount to pay input field. Test plan 1) Add an item to charge at 0.10. 2) Add this same item 8 or 9 times (Do not use the 'quantity') 3) Note that the table total and the 'Amount paid' values do not match 4) Apply the patch and repeat the above steps.. the values should now match. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:09:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:09:26 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-7xg3CiesuV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Also tested, and in live operation, at Cheshire libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:09:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:09:41 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-Uxju9Wp6lZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:21:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:21:31 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-eusKMUPkQr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #8 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128359&action=edit Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "HighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:22:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:22:32 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-PpIFIDaf5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:25:33 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-X4Hltqms2z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20396 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Cleanup Koha and fight feature creep -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:25:33 +0000 Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature creep In-Reply-To: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20396-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20396-70-G2KfmYJuZB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20398 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 [Bug 20398] Add a system preference to disable search result highlighting in the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 11:37:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 10:37:34 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-XdFpz1gwVb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:08:53 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to update and create biblio record In-Reply-To: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28201-70-1awJxUTYqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 128360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128360&action=edit Bug 28201: Add API route to create a biblio Example usage: POST /api/v1/biblios Accept: application/json { "marcxml": "<record>...</record>", "framework_id": "FA" } It can return data in the same formats as GET /api/v1/biblios/:biblio_id depending on the value of the Accept request header: - application/json - application/marcxml+xml - application/marc-in-json - application/marc - text/plain Test plan: 1. Try requesting this endpoint with your favorite API tool (I recommend https://github.com/frigus02/RESTer) 2. Run `prove t/db_dependent/api/v1/biblios/post.t` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:09:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:09:58 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to create biblio record In-Reply-To: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28201-70-fAKdDouSjM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |julian.maurice at biblibre.com Summary|Add API routes to update |Add API routes to create |and create biblio record |biblio record --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Removing the "update" part of this bug. It should be done in another bug IMO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:14:04 +0000 Subject: [Koha-bugs] [Bug 29650] False update In-Reply-To: <bug-29650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29650-70-3xtuGIfqR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29650 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You should at least upgrade to the latest 19.11.x version (v19.11.23) as 19.11.16 has the patch from bug 26457 that may fix this problem. *** This bug has been marked as a duplicate of bug 26457 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:14:04 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: <bug-26457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26457-70-hVSsygdLHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vvishnuaejith at gmail.com --- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 29650 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:19:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:19:55 +0000 Subject: [Koha-bugs] [Bug 29642] About page marks several Perl modules as missing (package installation). In-Reply-To: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29642-70-bpYLft52ve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified Component|Architecture, internals, |Packaging |and plumbing | CC| |jonathan.druart+koha at gmail. | |com, mtj at kohaaloha.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Hi Manos, There are used for tests of benchmarking so they are not mandatory and you can use Koha without any problems. Locale::XGettext::TT2 is a false positive, see bug 28666. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:20:40 +0000 Subject: [Koha-bugs] [Bug 29642] About page marks several Perl modules as missing (package installation). In-Reply-To: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29642-70-4AGtZnY1fo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28666 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Hi Manos, They are used for tests or benchmarking, so they are not mandatory and you can use Koha without any problems. Locale::XGettext::TT2 is a false positive, see bug 28666. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:20:40 +0000 Subject: [Koha-bugs] [Bug 28666] Locale::XGettext::TT2 shows as missing in about.pl page In-Reply-To: <bug-28666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28666-70-fDZPrveiCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28666 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29642 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 12:24:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 11:24:09 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-ASIUTsFhOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #60) > (In reply to Jonathan Druart) > > You need to count how many times you enter t() instead of guessing the > > number of lines matching a pattern there are in a file. > > Won't we have one t() usage per string starting with `circulation.pref#` ? > > Doesn't the above prefix matches all the translatable strings of the page > with all the circulation sysprefs? Except the ones on the left and up parts > of the UI but in the end the strings of the syspref descriptions and > values(dropdowns) dominate the whole page. The exact reason I am suggesting to count how many times you enter the method is that I don't want to think about those questions. Create a global var $i, warn ++$i and you will know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:04:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:04:20 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-s161hYcrCV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #154 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #153) > Aleisha, with the recent "additional contents" changes we could have a new > type of content "page". They would be stored in the same DB table and would > profit from the other possibilities (translation, etc.) > > Is it something that could work for you? Yes, I was thinking the same. Actually I am already using the news database as a simple cms for some local pages. Perhaps some of the additional features(?) here could be incorporated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:12:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:12:48 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16694-70-yA0BbetizU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #31 from Magnus Enger <magnus at libriotech.no> --- (In reply to Marcel de Rooy from comment #21) > Also the current code needs additional checking. > If a patron is already debarred etc, so charge_ok is already 0, we should > not set charge_ok to 1 only because the validation attribute is present. Remember that there will be a dedicated Meröppet login, and only that login will have the extra attribute "validate_patron_attribute". This login will only be concerned with letting patrons into the building or not, and that will be governed by the setting of the patron attribute in Koha. The user with this login will not care about whether the patron is debarred or not, or what "charge_ok" is really set to. It is the role of librarians (or custom scripts) to make sure the Meröppet attribute reflects the Meröppet access of the patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:23:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:23:40 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16694-70-6DfMLILQzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #32 from Magnus Enger <magnus at libriotech.no> --- It's been a while... Mark: would you object to moving the plugin code to a separate bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:53:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:53:48 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: <bug-29597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29597-70-mRP1dJyrCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 --- Comment #3 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128361&action=edit biblios.marc.tar.g -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:54:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:54:01 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: <bug-29597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29597-70-jP5ax3lfRB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128361|biblios.marc.tar.g |biblios.marc.tar.gz description| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:54:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:54:53 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-eVfdwRy2Yc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127963|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 13:56:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 12:56:12 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-gh6xGfSiJL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #28 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128362&action=edit biblios.marc.tar.gz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:04:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:04:07 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29393-70-5Jix0y6JPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #16 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 128363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128363&action=edit Bug 29393 - Sort notice templates by name Sponsored-by: Aix-Marseille University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:04:32 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29393-70-yoVnz4xPvf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:26:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:26:49 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29283-70-PvqJzP3Tod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Found something similar: Cannot insert order: Mandatory parameter biblionumber is missing at /usr/share/koha/acqui/cancelorder.pl line 60. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Cannot insert order: Mandatory parameter biblionumber is missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79 Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)') called at /usr/share/koha/Koha/Acquisition/Order.pm line 189 Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)', 'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60 cancelorder L60 (20.11) shows my $order = Koha::Acquisition::Orders->find($ordernumber); L60 $order->cancel({ reason => $reason, delete_biblio => $delete_biblio }); I am not sure how to recreate this one actually. I found it in the logs. The only way I found is opening the basket twice. Delete order in the first tab, and now delete it in the second. The second tab will crash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:45:41 +0000 Subject: [Koha-bugs] [Bug 29658] New: Crash on cancelling cancelled order Message-ID: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Bug ID: 29658 Summary: Crash on cancelling cancelled order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 29823. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:46:16 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-KsaB7O5T0Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29283 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:46:16 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29283-70-3kuId2EUJq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29658 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:46:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:46:53 +0000 Subject: [Koha-bugs] [Bug 29283] Cannot delete basket with cancelled order for deleted biblio In-Reply-To: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29283-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29283-70-TwA2Z6mTqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29283 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Opened bug 29658 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:50:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:50:55 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-fMcgMfYoqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:55:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:55:00 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-qrZGSt5YIG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:55:03 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-8vNStZchKq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128364&action=edit Bug 29658: Fix crash on cancelling cancelled order Found this crash in our 20.11 logs: Cannot insert order: Mandatory parameter biblionumber is missing at /usr/share/koha/acqui/cancelorder.pl line 60. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Cannot insert order: Mandatory parameter biblionumber is missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79 Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)') called at /usr/share/koha/Koha/Acquisition/Order.pm line 189 Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)', 'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60 Not sure how to reproduce this one as it happened. But might be related to repeated clicking, backspacing etc. Test plan: Create a new basket and order. Open this same basket in two browser tabs. Cancel the order line (delete catalog record) in tab 1. Go to second tab, try again. Without this patch, it will crash. With this patch, an error message. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:56:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:56:35 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-FYqlskraz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 14:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 13:56:58 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-lwM0NkClKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:04:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:04:03 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29654-70-RZuCePteU8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128335|0 |1 is obsolete| | --- Comment #4 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128365&action=edit Bug 29654 - Add match_record_id option to bulkmarimport.pl Add -match_record_id option to bulkmarkimport.pl. When enabled incoming record id will be assumed to match record in Koha. To test: 1) Before applying patch, export a biblio from staff interace 2) Import using the exported file: ./bulkmarcimport.pl -m="MARCXML" -v -b -file bib-xxxxx.marcxml -insert -update -c=MARC21 -l "/tmp/import.log" 3) The import with be inserted and create a duplicate record in Koha. Check the import.log or search using the staff interface. (could also crash with duplicate key error if contains item) 4) Apply patch 5) Run the import again with the same command as above 6) A new record should been inserted 7) Remove all newly inserted duplicate records (it's important to keep the record the export was initially performed on) 6) Run the import again, but add the -match_record_id option 8) The original Koha record should now have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:04:16 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29654-70-Sf4Ce2x5VM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:10:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:10:26 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-oP2LtfThAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm, this even opens up new possibilities like: Can't call method "edi_order" on an undefined value at /usr/share/koha/acqui/basket.pl line 381 Probably by trying to delete a deleted basket? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:12:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:12:38 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-myjdZmA9nd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2) > Hmm, this even opens up new possibilities like: > > Can't call method "edi_order" on an undefined value at > /usr/share/koha/acqui/basket.pl line 381 > > Probably by trying to delete a deleted basket? Not sure about that. Cant exactly reproduce. Lets resolve that somewhere else.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:13:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:13:18 +0000 Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29658-70-tMQMVu00yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 15:52:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 14:52:09 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29437-70-TIkbwzV5oh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #18) > Depends on Bug 29319 not in 20.11.x Actually a pity that we didnt backport something. Quite easy to generate this in the logs: [2021/12/08 15:49:20] [WARN] DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 5 [for Statement "SELECT import_record_id, file_name, isbn, title, author FROM import_biblios JOIN import_records USING (import_record_id) JOIN import_batches USING (import_batch_id) WHERE "] at /usr/share/koha/C4/Breeding.pm line 100. [2021/12/08 15:49:20] [WARN] DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for Statement "SELECT import_record_id, file_name, isbn, title, author FROM import_biblios JOIN import_records USING (import_record_id) JOIN import_batches USING (import_batch_id) WHERE "] at /usr/share/koha/C4/Breeding.pm line 101. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:02:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:02:42 +0000 Subject: [Koha-bugs] [Bug 29659] New: QR Code Accompanying material Message-ID: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 Bug ID: 29659 Summary: QR Code Accompanying material Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: infoscienceaddict at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Some newer printed book editions include QR codes linking to sound recordings of the content or other material. Could there be a way to add these QR codes in the bibliographic record so that users can actually scan and listen to / watch / see the content (provided that all rights are reserved etc.)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:09:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:09:08 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29437-70-2fdUMn0kwZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This is the most minimal maintenance solution I could come up with for 20.11: diff --git a/C4/Breeding.pm b/C4/Breeding.pm index 6b103b3..5b0d83a 100644 --- a/C4/Breeding.pm +++ b/C4/Breeding.pm @@ -96,6 +96,7 @@ sub BreedingSearch { $query .= "isbn like ?"; push(@bind,"$isbn%"); } + return 0 unless @bind; $sth = $dbh->prepare($query); $sth->execute(@bind); while (my $data = $sth->fetchrow_hashref) { Since Koha returns a 200, it only gives you a few log lines less. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:10:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:10:09 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-w1OJobaj8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 Afroditi Fragkou <infoscienceaddict at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infoscienceaddict at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:26:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:26:09 +0000 Subject: [Koha-bugs] [Bug 29660] New: reserve/request.pl should not deal with biblioitem Message-ID: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Bug ID: 29660 Summary: reserve/request.pl should not deal with biblioitem Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org The way reserve/request.pl is written is wrong, hard to read and to maintain. We should not use a biblioitemloop variable as there is a 1-1 link between biblio and biblioitem That would simplify the code a lot and make it more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:30:27 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28057-70-0a9Dwzudpw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Nick Clemens from comment #17) > (In reply to Jonathan Druart from comment #16) > > Why aren't we going further here? > > > > IMO we should completely remove the code related to biblioitemnumber. > > > > This comment: > > 405 ## Here we go backwards again to create hash of biblioitemnumber to > > itemnumbers > > 406 ## this is important when we have analytic items which may be on > > another record > > > > It implies that we must use biblioitemnumber to be correct, but we actually > > should use biblionumber. > > > > Is this correct? > > The comment is meant to describe what we are doing so that we can fix it in > the future > > I don't go further to keep this small for backporting, but I agree, we > should rewrite much of this I have opened bug 29660. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:31:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:31:03 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-PGMc0iXlHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at iki.fi, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:43:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:43:18 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-ivTuq3gM3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128366&action=edit Bug 29660: Remove hostitemsflag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:43:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:43:22 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-mfsCKHcZPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128367&action=edit Bug 29660: Unused code in placerequest.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:43:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:43:26 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-HY6cysEoDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128368&action=edit Bug 29660: Remove biblioitem loop from request.pl It seems that hiddencount didn't work prior to this patch (to confirm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:45:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:45:40 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-4MLtxyIT85@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28057 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Nick, Joonas, what about this approach? I haven't tested it yet much. Only tried with a record with 1500+ items and the load time is the same. If you are with me I can continue and 1. clean a bit more the controller and template then 2. try to improve the perf for big biblio records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:45:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:45:40 +0000 Subject: [Koha-bugs] [Bug 28057] Confusion of biblionumber and biblioitemnumber in request.pl In-Reply-To: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28057-70-a3zzMITjxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28057 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29660 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 16:45:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 15:45:50 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29660-70-7a1dFCgK7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 17:52:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 16:52:18 +0000 Subject: [Koha-bugs] [Bug 29661] New: PreFillItem should not apply to duplicated items Message-ID: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 Bug ID: 29661 Summary: PreFillItem should not apply to duplicated items Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In 21.05.07, the PreFillItem syspref is applied when duplicating an item. This was not the case in previous versions of Koha and is not the case on master. To recreate (on 21.05): - set PrefillItem to "the new item is prefilled ..." - set SubfieldsToUseWhenPrefill to 3 so that the Materials Specified value is prefilled - create an item that has a Materials Specified note - confirm that when the Add Item page reloads after creating your item, the Materials Specified note is prefilled as expected - find an item without a Materials Specified value, duplicate it - confirm your duplicate item's Materials Specified is prefilled with the value from your first item, when it should be null like your second item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 17:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 16:55:27 +0000 Subject: [Koha-bugs] [Bug 29662] New: PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null Message-ID: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Bug ID: 29662 Summary: PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: - turn on PrefillItem - confirm SubfieldsToUseWhenPrefill is empty - create an item, confirm no values are prefilled for next item - set at least one subfield in SubfieldsToUseWhenPrefill - create an item, confirm specified subfield(s) get prefilled for next item In previous versions, leaving SubfieldsToUseWhenPrefill blank meant all subfields were prefilled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 17:58:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 16:58:21 +0000 Subject: [Koha-bugs] [Bug 29663] New: Document expected behavior of Prefill Item Message-ID: <bug-29663-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29663 Bug ID: 29663 Summary: Document expected behavior of Prefill Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 29661 and bug 29662 highlight a general confusion about how PrefillItem and SubfieldsToUseWhenPrefill are expected to behave, which makes it too easy to inadvertently change behavior. More detail in the manual could be helpful. The two bits in question are whether or not fields should be prefilled when duplicating an item and whether a blank SubfieldsToUseWhenPrefill should mean all subfields are prefilled or no subfields are prefilled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 18:21:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 17:21:18 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29632-70-XJyyRpX7oT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 --- Comment #2 from Heather <heather_hernandez at nps.gov> --- We're having this problem on 21.05 and can be seen in our OPAC: https://keys.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=callnum%2Cphr%3Ava65&offset=80&sort_by=call_number_asc You'll see that VA65 E45 is still sorting *after* VA65 E7. It's a big problem for us to continue to have the LC call numbers not sorted correctly--the staff can't sort correctly for paging lists, for example, and being a closed stack library, this impacts us daily, with every service request, where they're operating from Carts, searches, lists, and often generating their own paging/pull lists from various parts of Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 18:31:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 17:31:54 +0000 Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in Elasticsearch In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29632-70-fTor8JmcBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 18:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 17:52:43 +0000 Subject: [Koha-bugs] [Bug 29664] New: Do not show voided payments in cash_register_stats.pl Message-ID: <bug-29664-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Bug ID: 29664 Summary: Do not show voided payments in cash_register_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: - take a payment of $1 - void that payment - go to reports, Cash Register (cash_register_stats.pl) and run a report for all payments taken today, see your voided payment We should not included voided credits, it throws off the totals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:08:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:08:02 +0000 Subject: [Koha-bugs] [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual In-Reply-To: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27382-70-RblZ9YpwHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27387, 27419 |28430, 28431 Summary|[DOCS] [Omnibus] Typos in |[DOCS] [Omnibus] Spelling |the manual |errors in the manual Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27387 [Bug 27387] [20.05] Broken image in patrons chapter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27419 [Bug 27419] Manual: Remove mention of rebuild index cronjob from implementation checklist https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430 [Bug 28430] Typo: alreay https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 [Bug 28431] Typo: exsit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:08:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:08:02 +0000 Subject: [Koha-bugs] [Bug 27387] [20.05] Broken image in patrons chapter In-Reply-To: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27387-70-bOCPiHuU5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27387 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27382 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:08:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:08:02 +0000 Subject: [Koha-bugs] [Bug 27419] Manual: Remove mention of rebuild index cronjob from implementation checklist In-Reply-To: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27419-70-zGoHi5l21U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27382 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:08:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:08:02 +0000 Subject: [Koha-bugs] [Bug 28430] Typo: alreay In-Reply-To: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28430-70-yjnLdiigmy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:08:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:08:02 +0000 Subject: [Koha-bugs] [Bug 28431] Typo: exsit In-Reply-To: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28431-70-bUqplQ9Spg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27382 [Bug 27382] [DOCS] [Omnibus] Spelling errors in the manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:13:29 +0000 Subject: [Koha-bugs] [Bug 28430] [DOCS] Spelling error in the manual (tools): alreay In-Reply-To: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28430-70-jfgKUgH8Vd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Typo: alreay |[DOCS] Spelling error in | |the manual (tools): alreay CC| |david at davidnind.com Version|20.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:15:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:15:07 +0000 Subject: [Koha-bugs] [Bug 28430] [DOCS] Spelling error in the manual (tools): alreay In-Reply-To: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28430-70-KKUJ6Wu1Ay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28430 --- Comment #1 from David Nind <david at davidnind.com> --- Change required in all versions of the manual from 20.11 to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:22:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:22:37 +0000 Subject: [Koha-bugs] [Bug 28431] [DOCS] Spelling error in the manual (tools): exsit In-Reply-To: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28431-70-AfEs3kqWRf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Summary|Typo: exsit |[DOCS] Spelling error in | |the manual (tools): exsit Version|20.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:23:09 +0000 Subject: [Koha-bugs] [Bug 28431] [DOCS] Spelling error in the manual (tools): exsit In-Reply-To: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28431-70-YvfloA7bGJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 --- Comment #1 from David Nind <david at davidnind.com> --- Change required in all versions of the manual from 20.11 to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 21:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 20:29:40 +0000 Subject: [Koha-bugs] [Bug 29665] New: Claims Returned status cannot be removed if BlockReturnofLostItems set to Block Message-ID: <bug-29665-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29665 Bug ID: 29665 Summary: Claims Returned status cannot be removed if BlockReturnofLostItems set to Block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: - designate a lost status in ClaimReturnedLostValue - set BlockReturnofLostItems to Block - check an item out - create a return claim - confirm you cannot remove the Claims Returned lost status -- item cannot be checked in to clear the status and the lost value used for claims is disabled on the item edit screens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:18:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:18:25 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27259-70-JTUolyCSi9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:20:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:20:52 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-FAfPMjNYDS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> --- Oh crap. We found a big performance issue with this hook. Each store() call is checking in DB the plugin version and if it is enabled. Particulary when DB is distant this is bad for performance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:26:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:26:14 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-kdG55u3GOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- This hook is used by Biblibre for action on record before saving. I suggest we change to implement hooks 'before_authority_action' and 'before_biblio_action'. With record as param. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:35:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:35:17 +0000 Subject: [Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records In-Reply-To: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28478-70-GQQ7pdRYAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Arf indeed, code in only in opac-detail.pl : https://git.koha-community.org/Koha-community/Koha/src/commit/3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147 This needs to be in a module, and if possible with a Koha to MARC mapping instead of hardcoded 942$n. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:35:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:35:47 +0000 Subject: [Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records In-Reply-To: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28478-70-22vSrRGlxW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 [Bug 10195] Records hidden with OpacSuppression can still be accessed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:35:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:35:47 +0000 Subject: [Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed In-Reply-To: <bug-10195-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10195-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10195-70-LbtMQxuaYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 [Bug 28478] MARC detail and ISBD pages still show suppressed records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:38:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:38:31 +0000 Subject: [Koha-bugs] [Bug 27419] Manual: Remove mention of rebuild index cronjob from implementation checklist In-Reply-To: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27419-70-EtwMcRzn5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Still a valid issue - should be removed from all supported versions of the manual as it was introduced in Koha about 9 years ago (from the Git history for debian/scripts/koha-indexer). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:39:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:39:14 +0000 Subject: [Koha-bugs] [Bug 27419] [DOCS] Remove mention of rebuild index cronjob from the implementation checklist In-Reply-To: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27419-70-YXYMOY0Dy7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27419 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Manual: Remove mention of |[DOCS] Remove mention of |rebuild index cronjob from |rebuild index cronjob from |implementation checklist |the implementation | |checklist -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:43:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:43:10 +0000 Subject: [Koha-bugs] [Bug 29661] PreFillItem should not apply to duplicated items In-Reply-To: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29661-70-hUPjo9aDeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29662 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:43:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:43:10 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-O5AId6bxuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29661 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:43:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:43:50 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-RsuIzi1Tjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:44:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:44:01 +0000 Subject: [Koha-bugs] [Bug 27387] [DOCS] Broken image in patrons section: image1501 In-Reply-To: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27387-70-YP4crjt77E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27387 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Version|master |20.05 Assignee|eden.bacani at gmail.com |koha-bugs at lists.koha-commun | |ity.org Summary|[20.05] Broken image in |[DOCS] Broken image in |patrons chapter |patrons section: image1501 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:44:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:44:17 +0000 Subject: [Koha-bugs] [Bug 29661] PreFillItem should not apply to duplicated items In-Reply-To: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29661-70-TZDepO7BYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:44:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:44:38 +0000 Subject: [Koha-bugs] [Bug 27387] [DOCS] Broken image in patrons section: image1501 In-Reply-To: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27387-70-ZH2j3D8GTp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27387 --- Comment #2 from David Nind <david at davidnind.com> --- Still an issue for 19.11 and 20.05 versions of the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:45:59 +0000 Subject: [Koha-bugs] [Bug 27387] [DOCS] Broken image in patrons section: image1501 In-Reply-To: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27387-70-IgvDn3y2Xd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27387 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:46:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:46:46 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15594-70-jXyyOJCJS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #3 from Blou <philippe.blouin at inlibro.com> --- Created attachment 128369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128369&action=edit Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:47:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:47:12 +0000 Subject: [Koha-bugs] [Bug 29642] About page marks several Perl modules as missing (package installation). In-Reply-To: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29642-70-bzbs9zagvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29642 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> --- If you have commandline access, you may use 'koha_perl_deps.pl -m' : https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha_perl_deps.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:58:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:58:44 +0000 Subject: [Koha-bugs] [Bug 29647] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-6klC64H4Mc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from David Nind <david at davidnind.com> --- Thanks for raising Katrin. I'm still getting my head around the translation process (I should really know this by now). I'll write up how I think it is supposed to work in the Wiki (probably https://wiki.koha-community.org/wiki/Translating_the_Koha_Manual), and incorporate the material from https://gitlab.com/koha-community/koha-manual/-/issues/13#note_243241096 Then I'll ask for feedback - to make sure I've got it right, including the specific steps! David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:59:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:59:01 +0000 Subject: [Koha-bugs] [Bug 29647] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-A1ZETbWXkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 22:59:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 21:59:59 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-XHldO5Fvmg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update po files in manual |[DOCS] Update po files in |repository |manual repository -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:03:58 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15067-70-EfwKMXBlEs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Manos PETRIDIS <egpetridis at yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #35 from Manos PETRIDIS <egpetridis at yahoo.com> --- Has anyone noticed bugs 29631 and 29641? They seem to be caused by the unique keys introduced here. Shouldn't this bug revert to QA needed status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:04:54 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-7zQZj1d29q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- A QR code is a text representing an hyperlink. One can scan and store in some MARC field. Then in my opinion displaying a QR code in OPAC is not better than an hyperlink since user is already on a web page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:09:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:09:59 +0000 Subject: [Koha-bugs] [Bug 29424] Replace the table on 'HTML customisations' administration with a visual alternative. In-Reply-To: <bug-29424-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29424-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29424-70-in96FeOWmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- +1 for this really cool idea Wondering how the different language blocks would fit in here: -OPACMainUserBlock_en -OPACMainUserBlock_es Also wondering how some blocks which don't appear on the mainpage fit in: -ArticleRequestsDisclaimerText -OpacSuggestionInstructions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:27:31 +0000 Subject: [Koha-bugs] [Bug 29661] PreFillItem should not apply to duplicated items In-Reply-To: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29661-70-cpzyhzpoxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- I think that we've noticed the same thing in 21.05.x and similar report that it didn't happen in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:28:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:28:06 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-zR81csD7W9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:32:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:32:08 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29393-70-qFV5mIMomw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:32:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:32:52 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to create biblio record In-Reply-To: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28201-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28201-70-8s90jc590M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:34:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:34:22 +0000 Subject: [Koha-bugs] [Bug 27909] When upgrading, old sysprefs are only copied in english news items In-Reply-To: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27909-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27909-70-7fJqYYMtsu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27909 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 8 23:34:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 22:34:42 +0000 Subject: [Koha-bugs] [Bug 29657] OpacNavRight is only added to one language for OPACs with multiple active languages In-Reply-To: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29657-70-MUmk9ZwMZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- It is rather annoying. What bug number provides a default instead of English only? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 00:11:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 23:11:46 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-5tzvipvDbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128300|0 |1 is obsolete| | --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128370&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 00:12:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Dec 2021 23:12:17 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-REnBLNwBxH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:03:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:03:06 +0000 Subject: [Koha-bugs] [Bug 29666] New: Gmail>>Compose>>Clicking on send button application throws server error Message-ID: <bug-29666-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29666 Bug ID: 29666 Summary: Gmail>>Compose>>Clicking on send button application throws server error Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC OS: All Status: NEW Severity: critical Priority: P2 Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: madangowda046 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:11:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:11:11 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed In-Reply-To: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25370-70-CuYlIX5Uwu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create whitelist of plugins |Create allowlist of plugins |allowed to be installed |allowed to be installed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:17:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:17:30 +0000 Subject: [Koha-bugs] [Bug 29667] New: Gmail>>Compose>>Clicking on send button application throws server error Message-ID: <bug-29667-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29667 Bug ID: 29667 Summary: Gmail>>Compose>>Clicking on send button application throws server error Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC OS: All Status: NEW Severity: critical Priority: P2 Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: madangowda046 at gmail.com steps to reproduce defect: 1. Login to gmail application - username:test at gmail.com - password:test$1234 2. Click on compose 3. In compose enter the following To Subject Email body Expected Result: Email should be sent Actual Result: Email sending failed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:23:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:23:38 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed In-Reply-To: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25370-70-fE0VDguXth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- This looks a bit tougher than I was thinking but should still be doable... I think if I do a Module::Pluggable search for "Koha::Plugin" in between these following two lines and then compare to an allowlist... that should do the trick. my $ae = Archive::Extract->new( archive => $tempfile, type => 'zip' ); unless ( $ae->extract( to => $plugins_dir ) ) { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:30:18 +0000 Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28498-70-xhzo7gqBV0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Nick Clemens from comment #0) > We need a CLI counterpart for plugin actions: > - Install (from a URL, from a .kpz) > - Upgrade (from a URL, from a .kpz) > - Uninstall > - Configure based on some file format I actually had another thought about this... What if we had an instance-level configuration file that defined the plugin, the plugin version, and the plugin configuration? We could even re-use that configuration file across multiple Koha instances which would help with the logistical challenges of managing plugins. (We could use symlinks to point to a central file, or point to a central file from koha-conf.xml for instance.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:33:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:33:16 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed In-Reply-To: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25370-70-epRk8Q21ua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- The challenge is how to define this configuration, but I think I could use the same idea I had at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498#c4 Set up a configuration file called /etc/koha/plugin-allowlist.yml and then point each Koha instance at that file via koha-conf.xml. That also allows for the possibility to have 99% of instances using the generic allow list while some instances could be configured using /etc/koha/sites/INSTANCE/plugin-allowlist.yml to provide a different list. (I still want to replace koha-conf.xml, but creating Koha::Config->file() with caching layers is beyond what I want to do right now...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:33:47 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed by Web UI In-Reply-To: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25370-70-uBQr7jwGc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create allowlist of plugins |Create allowlist of plugins |allowed to be installed |allowed to be installed by | |Web UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:34:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:34:58 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed by Web UI In-Reply-To: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25370-70-c9eZEzIo7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I've updated the summary because I think we only need to define an allowlist that inhibits the Web UI. I think we should allow sysadmins to install whatever they want. (I'm also not too concerned with people uninstalling plugins at this point. I think that would be better handled by Bug 28499.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:40:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:40:25 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: <bug-26790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26790-70-AepStfycVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #17 from David Cook <dcook at prosentient.com.au> --- I was thinking more today about how this all could work and I'm thinking something like this: my $mq_crud_conf = Koha::Config->relative_file('mq_crud.yml'); The "relative" here means relative to $ENV{'KOHA_CONF'} as the configuration directory. Now I'm pondering whether we build in L1 and L2 caching into that method or if we have multiple different methods: Koha::Config->relative_file() Koha::Config->relative_file_cached() It might be a good idea to have multiple methods because sometimes you don't need to waste time setting up the cache. (For instance, when uploading a plugin, you might only need "relative_file", but when calling a plugin over X records in a row you'd definitely want to use "relative_file_cached".) But curious what other people think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 04:55:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 03:55:44 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: <bug-26790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26790-70-8suglmEjfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #18 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #17) > > my $mq_crud_conf = Koha::Config->relative_file('mq_crud.yml'); > Oh but this wouldn't work with Tomas's ideas, which were very good. (In reply to Tomás Cohen Arazi from comment #12) > My vote would be: > - Use separate files with expected names (config.yaml, shibboleth.yaml, etc) > - No includes > - Have C4::Context->config rebuild the 'old structure we already have, and > deal with a different new handling on a separate bug (Koha::Config singleton > implementation?) > - Have a way for C4::Context->config to override any configuration if an env > variable exists. e.g. KOHA_DATABASE_NAME should override the relevant entry. What about using AUTOLOAD? my $mq_crud = Koha::Config->mq_crud(); If the "mq_crud" doesn't exist in an internal data structure, it could then do the Koha::Config->relative_file('mq_crud.yml') or looks for KOHA_MQ_CRUD in an environmental variable to load the configuration from file and then saves it. (This wouldn't use Koha::Cache at all and would require a process restart to refresh configuration like with koha-conf.xml.) The only downside of that would be that you couldn't use an env var override for lower level config... like Koha::Config->mq_crud()->destination; Although you probably could do something clever... where Koha::Config->mq_crud() returns a Koha::Config::Entry object which could use AUTOLOAD or have dynamically created methods during object creation time. There are options... which of course makes it tougher to choose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 08:26:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 07:26:06 +0000 Subject: [Koha-bugs] [Bug 29668] New: Add API route to create a basket Message-ID: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 Bug ID: 29668 Summary: Add API route to create a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: REST API Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 08:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 07:27:42 +0000 Subject: [Koha-bugs] [Bug 29668] Add API route to create a basket In-Reply-To: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29668-70-McYnnLbhTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 128371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128371&action=edit Bug 29668: Add API route to add a basket Example usage: POST /api/v1/acquisitions/baskets { "vendor_id": 1, "name": "Basket #1", } Test plan: 1. Try requesting this endpoint with your favorite API tool (I recommend https://github.com/frigus02/RESTer) 2. Run `prove t/db_dependent/api/v1/acquisitions_baskets/post.t` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 08:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 07:27:53 +0000 Subject: [Koha-bugs] [Bug 29668] Add API route to create a basket In-Reply-To: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29668-70-mmDWTn3lfG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 09:52:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 08:52:20 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-w5dzRxxxUZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- I think Fridolin has a good point. But if you really want to display the QR-code, maybe you could add it as a local cover image? (One scenario: The OPAC is displayed in a kiosk setup in the library, where you do not want patrons to be able to click on anything that takes them outside the OPAC. But letting them scan the QR-code on their mobile device and enjoy the content there might be desirable.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 09:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 08:56:57 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16694-70-zs1s7stbRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 --- Comment #33 from Magnus Enger <magnus at libriotech.no> --- I just discovered that some of my use cases for this bug can be solved by the development on bug 17826. If the Meröppet vendor can work with 0/1 in a made up SIP2 field, that bug solves the problem. We still need this bug if the vendor only accepts values in field 1 and/or two of the patron information response. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 10:00:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 09:00:20 +0000 Subject: [Koha-bugs] [Bug 29657] OpacNavRight is only added to one language for OPACs with multiple active languages In-Reply-To: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29657-70-ckSr1uQcd0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29657 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Default is a 21.11 feature done with the "rename tools" bug 24387. So in older versions the prefs were added to each language to not break behaviour. It worked for header, credits and such, but not for OpacNavRight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 10:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 09:28:54 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-rPDZnLC8eb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 --- Comment #3 from Afroditi Fragkou <infoscienceaddict at gmail.com> --- Maybe I lack some knowledge so my understanding is poor, but when I have a QR code printed on the book, don't I need a qr reader to see the url it leads to? How can I do that using my regular client pc, so that I can add it in the bibliographic record? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 12:50:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 11:50:19 +0000 Subject: [Koha-bugs] [Bug 29667] Gmail>>Compose>>Clicking on send button application throws server error In-Reply-To: <bug-29667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29667-70-5Bxunwpq14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29667 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This bug tracker doesn't cover GMail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:20:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:20:29 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28607-70-qwo1PAHFOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 Kunal <kunalschakraborty at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kunalschakraborty at gmail.com Priority|P5 - low |P1 - high Hardware|All |PC Severity|enhancement |major OS|All |Linux --- Comment #1 from Kunal <kunalschakraborty at gmail.com> --- This happened after full web-installation of Koha 21.11.00.000 in Ubuntu 20.04LTS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:32:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:32:48 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-9jPqTUEeUL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, David. I think Martin/Caroline might also be able to help a bit. We really need to write things down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:33:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:33:54 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-MbrX0nhreS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Summary|Manual: Translation issue |[DOCS] Manual: Translation |with repeated strings in |issue with repeated strings |system preferences |in system preferences Component|I18N/L10N |Documentation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:36:11 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28607-70-KCnprYIAbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org Hardware|PC |All Version|unspecified |21.11 Component|Web services |Authentication Priority|P1 - high |P5 - low OS|Linux |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:37:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:37:30 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-y1qKBoEfPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- For an example: Asks: ___ cash registers with the accounting system to track payments. Default: Don't use Values: Don't use Use So each of those lines get to be a separate string. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:47:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:47:36 +0000 Subject: [Koha-bugs] [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported In-Reply-To: <bug-22671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22671-70-7Ia4ODgobG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Built-in offline |Warn the user in offline |circulation |circulation if |applicationCache errors |applicationCache isn't | |supported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:49:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:49:57 +0000 Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page In-Reply-To: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29228-70-1I2qiNuIzD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22671 | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I'm removing the dependency on Bug 22671 because it's not strictly necessary, it just makes it easier to identify whether you're testing in a browser which will work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 13:49:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 12:49:57 +0000 Subject: [Koha-bugs] [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported In-Reply-To: <bug-22671-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22671-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22671-70-iGUVDWh2Rb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 [Bug 29228] Use Flatpickr on offline circulation page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:14:12 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: <bug-25643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25643-70-W34ktk78FD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #13 from Ray Delahunty <r.delahunty at arts.ac.uk> --- I have been testing out changes to reservations / holds settings in our test server and the maxreserves setting is not working for us in the way Katrin reports. We are on 20.11.04 and all our 6 libraries have the same circulation policies so I have set Total reservations allowed (under Default issue, reserve & return policy by category) to 5 for all user categories permitted to place reservations. Our maxreserves is set to 10. We do not (currently) allow OPAC item level reservations so I am not yet thinking about how the Reservations allowed (under Defining circulation & fine rules for all libraries) will work for us. (Like, how would Koha know the counts of reservations by item type in our title-level reservation environment, so it could limit reservations using this very granular functionality?). I have set Reservations allowed to 10 which I think effectively takes ‘reservations by item type/user category’ out of the equation). But I have not been able to place more than 5 reservation using either the OPAC or the Koha intranet. I tried this with ReservesControlBranch set to either of Item’s home library or user’s home library, but I have not been able to achieve what I thought was how the functionality works- say 5 reservations for items at library A, 3 reservations at library B and 2 at Library C. We are trying to unravel how the counts are set so we can set the counts to be how we want them to be. Being able to advise users that ‘Patrons in Category A can have a total of 50 holds across all branches’ (or whatever) would be great. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:16:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:16:21 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-lJmN7GUeRX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128315|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128372&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:17:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:17:10 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-emaMfcO2Jo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Signed on the follow-up. Thanks, Lucas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:46:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:46:30 +0000 Subject: [Koha-bugs] [Bug 29669] New: Uninitialized value warnings when XSLTParse4Display is called Message-ID: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Bug ID: 29669 Summary: Uninitialized value warnings when XSLTParse4Display is called Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: stalkernoid at gmail.com Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:47:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:47:08 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27708-70-8fVeY6VVlX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233 Bug 27708: Unify two item object creation blocks to be stored as hash Review of attachment 127233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233) ----------------------------------------------------------------- ::: Koha/Edifact/Order.pm @@ +392,5 @@ > + branchcode => $item->{branchcode}, > + itype => $item->{itype}, > + location => $item->{location}, > + itemcallnumber => $item->{itemcallnumber}, > + }; Pretty sure the above block causes breakage.. you are using `$item` as though it's a hash representation of an item row.. but it's not.. it's the hash of the AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or itemcallnumber. It should be using the actual item row.. as before.. $i_obj This breaks our live systems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:47:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:47:11 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27708-70-MowR3BWR8t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 127233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233 Bug 27708: Unify two item object creation blocks to be stored as hash Review of attachment 127233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233) ----------------------------------------------------------------- ::: Koha/Edifact/Order.pm @@ +392,5 @@ > + branchcode => $item->{branchcode}, > + itype => $item->{itype}, > + location => $item->{location}, > + itemcallnumber => $item->{itemcallnumber}, > + }; Pretty sure the above block causes breakage.. you are using `$item` as though it's a hash representation of an item row.. but it's not.. it's the hash of the AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or itemcallnumber. It should be using the actual item row.. as before.. $i_obj This breaks our live systems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:48:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:48:37 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-N33vfbtexE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Peter Vashchuk <stalkernoid at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:48:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:48:40 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-AZhNi3xq98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 --- Comment #1 from Peter Vashchuk <stalkernoid at gmail.com> --- Created attachment 128373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128373&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce: 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:52:14 +0000 Subject: [Koha-bugs] [Bug 29670] New: Fix errors caused by bug 27708 Message-ID: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Bug ID: 29670 Summary: Fix errors caused by bug 27708 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Bug 27708 misunderstood how the acquisitions link tables work and thus incorrectly assigned values from rows in the wrong table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:52:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:52:20 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-rLHqV49UZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:52:30 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-o7tqXzUAlk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical Depends on| |27708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:52:30 +0000 Subject: [Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order" In-Reply-To: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27708-70-s8PRUxJFE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 [Bug 29670] Fix errors caused by bug 27708 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:52:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:52:54 +0000 Subject: [Koha-bugs] [Bug 29671] New: Dropbox mode is unchecked after check in confirm on item with Materials specified Message-ID: <bug-29671-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Bug ID: 29671 Summary: Dropbox mode is unchecked after check in confirm on item with Materials specified Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: christophe.torin at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Created attachment 128374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128374&action=edit Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:57:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:57:07 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-IA0K9Hr8Ii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128375&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 14:58:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 13:58:19 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-CE2LUuGkkT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:34:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:34:30 +0000 Subject: [Koha-bugs] [Bug 29672] New: Increase performance of Koha::Plugins->call Message-ID: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Bug ID: 29672 Summary: Increase performance of Koha::Plugins->call Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Every call to Koha::Plugins->call do a lot of database queries: 1) One in GetPlugins searches for available plugin_class in plugin_methods table 2) One in Koha::Plugins::Base::is_enabled for each plugin returned by (1) 3) One or two in Koha::Plugins::Base::new for each plugin returned by (1) to check the install status and the installed version All of these requests only need to be made once per HTTP request at most. One could argue that it's needed only at Koha startup but that besides the point of this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:36:56 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-5OG2NgiBT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 128376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128376&action=edit Bug 29672: Increase performance of Koha::Plugins->call Make use of Koha::Cache::Memory::Lite to avoid hitting the database and creating plugins object for every call to Koha::Plugins->call Test plan: 1. Make sure plugins still work by executing `prove t/db_dependent/Koha/Plugins/Plugins.t` 2. Run the test script provided in the following patch to see how it affects performances -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:37:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:37:01 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-cg6NUiWFmG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 128377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128377&action=edit Bug 29672: [DO NOT PUSH] Test script Run test-plugins-call.pl without arguments with and without the patches, with some plugins enabled. Make sure to run misc/devel/install_plugins.pl before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:37:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:37:11 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-Fk2yi7mKk4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:39:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:39:43 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-YgCLvHnXbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Times I get on master: 1 call(s): Elapsed 0.670997 seconds 10 call(s): Elapsed 0.049056 seconds 100 call(s): Elapsed 0.468099 seconds 1000 call(s): Elapsed 4.762553 seconds Times I get with the patch: 1 call(s): Elapsed 0.634319 seconds 10 call(s): Elapsed 0.000154 seconds 100 call(s): Elapsed 0.001282 seconds 1000 call(s): Elapsed 0.011682 seconds As you can see the first call takes the same time with or without the patch, but subsequent calls are much more faster with the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:39:58 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-tX8hSNK8UK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:39:58 +0000 Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins In-Reply-To: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28172-70-tBXihYmzHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29672 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 15:41:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 14:41:30 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-Ch3rcuygF1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Fridolin Somers from comment #3) > Oh crap. > > We found a big performance issue with this hook. > > Each store() call is checking in DB the plugin version and if it is enabled. > > Particulary when DB is distant this is bad for performance. The problem is not this particular hook. It's Koha::Plugins->call that is too slow. I tried making it faster with bug 29672. Please test and let me know what you think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:06:53 +0000 Subject: [Koha-bugs] [Bug 29673] New: Allow an English sql localization script Message-ID: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 Bug ID: 29673 Summary: Allow an English sql localization script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org There is no default English sql localization obviously. But why shouldnt we allow it when someone adds a custom script there to do things that are done too for the other languages like de-DE etc. ? Tiny adjustment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:18:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:18:01 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-VzFDcvAVv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #3 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128378&action=edit Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:18:38 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-9dk82LTT0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:19:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:19:09 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-FvR5yJ62Pm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:20:20 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-ezssggPp7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128375|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128379&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:30:15 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-9k1UkRMdzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:30:45 +0000 Subject: [Koha-bugs] [Bug 29674] New: Syspref autoBarcode add just <branchcode> Message-ID: <bug-29674-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29674 Bug ID: 29674 Summary: Syspref autoBarcode add just <branchcode> Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The System Preference autoBarcode have this option: <branchcode>yymm0001 It would be very useful to our Library if there we have the option just <branchcode> The other part of the barcode it would be manually inserted. The reason is to avoid mistakes because our School Librarians always forget to start barcode with <branchcode>. Thank you very much -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:33:35 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-GtgxMPJz3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |testopia at bugs.koha-communit | |y.org Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:33:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:33:46 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-W5GJrIIuon@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 16:41:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 15:41:27 +0000 Subject: [Koha-bugs] [Bug 29673] Allow an English sql localization script In-Reply-To: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29673-70-2z6mhgED9y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- DBIx::RunSQL is quite stupid on splitting by newlines btw.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 17:34:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 16:34:13 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15594-70-J99W93OVPE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #4 from Blou <philippe.blouin at inlibro.com> --- Sponsored by: Ville de Saint-Eustache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:22:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:22:44 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-8nHBAmW7Cd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:23:04 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-RsBe6XIwx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:25:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:25:52 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-e6ZgbzS0zv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #7 from George Williams (NEKLS) <george at nekls.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:32:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:32:14 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-g08YGK8U8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Michael Adamyk <madamyk at ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:33:47 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: <bug-12450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12450-70-vTajhulR8g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #12 from Michael Adamyk <madamyk at ckls.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 18:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 17:45:35 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-XeuhxqiQev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Sarah Fletcher <sfletcher at ncrl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfletcher at ncrl.org --- Comment #8 from Sarah Fletcher <sfletcher at ncrl.org> --- NCW Libraries is extremely interested in this enhancement as well! It would save us a lot of staff time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:23:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:23:52 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-rJz8QYEjPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128380&action=edit Bug 28377: (28937 follow-up) Flatpickr change Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:26:42 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-ETTyzQ4BC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:26:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:26:42 +0000 Subject: [Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages In-Reply-To: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28937-70-SPiR4b1kIy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28377 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 [Bug 28377] Use the API to suspend/resume holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:40:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:40:32 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-P0IRrh3Hdk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128381&action=edit Bug 28377: (QA follow-up) Fallback error handling The code only dealt with 404, this patch makes it have a fallback message for failure codes. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:40:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:40:54 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-dzH5xTxMYW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 20:41:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 19:41:11 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-jnv3ykDjwH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 21:46:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 20:46:02 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27868-70-7xfPQiDHXs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 21:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 20:46:06 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27868-70-nbLaEtM6WN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128334|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128382&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 23:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 22:11:05 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-QoC8YsHKkD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #19 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Sorry, I got a little carried away with this bug. But original assignee, Nick please continue from here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 23:27:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 22:27:46 +0000 Subject: [Koha-bugs] [Bug 29675] New: Can't get to Holds Ratio page Message-ID: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675 Bug ID: 29675 Summary: Can't get to Holds Ratio page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Go to Circulation and try go click on the Hold Ratios report. ( /cgi-bin/koha/circ/reserveratios.pl ) CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 23:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 22:28:43 +0000 Subject: [Koha-bugs] [Bug 29675] Can't get to Holds Ratio page In-Reply-To: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29675-70-qo12VBZU6R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 23:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 22:30:53 +0000 Subject: [Koha-bugs] [Bug 29675] Can't get to Holds Ratio page In-Reply-To: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29675-70-PsdymP3OYe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- In koha-testing-docker, If I turn off SQL strict mode I can access the page. So I'm not sure if this is a Koha bug or just a koha-testing-docker thing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 9 23:56:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 22:56:10 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28607-70-sxKLPsNdxf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is it possible that you have changed the timeout system preference to a too low value? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 00:01:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 23:01:56 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-W0dk1QxyVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like there are barcode scanners that can read QR codes you could use at a normal computer to 'translate' the QR code to an URL. Maybe there are also web apps that can use your laptop camera or webcam? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 00:53:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Dec 2021 23:53:58 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-l0fSoKOiKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 01:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 00:56:03 +0000 Subject: [Koha-bugs] [Bug 29676] New: Protect a bib record from being overlaid when matched Message-ID: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 Bug ID: 29676 Summary: Protect a bib record from being overlaid when matched Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: aspencatteam at clicweb.org QA Contact: testopia at bugs.koha-community.org It would be nice to be able to mark a bibliographic record that would protect it from being overlaid when "matched" on import. For example we have records that are for a book club kit, so there is an ISBN in the record that puts it available for match when importing records. We would want to indicate in some fashion that this record will not be available to attach items on import, nor be available to be overlaid if that was the choice made on import. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 01:56:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 00:56:13 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-n2xWy2m2Lr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:06:18 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-GfE79r68ua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #105 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hi all, I've rebased this patchset, added a missing change to kohastructure.sql, and merged the following 4 patches into 1 patch: - Bug 26346: Add option to make public lists editable by all staff - Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch 'owner only' public lists (which they're not the owners of) to 'staff only' lists - Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user - Bug 26346: (follow-up) Fixes in response to QA I have also reworked the test plan to hopefully make it more succinct, and easier to follow. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:06:45 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-2BOvTN6Iyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:06:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:06:56 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-tBfrE3r426@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:07:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:07:07 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-gua6Ev6PLp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:07:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:07:18 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-hvhRQ2PLe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:07:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:07:36 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-eUDuPbrj01@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:07:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:07:47 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-EnwCrmVir9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:08:20 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-ecGLA97bAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #106 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128383&action=edit Bug 26346: Database changes - Adds allow_change_from_staff to virtualshelves table - Add edit_public_lists sub-permission Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:08:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:08:58 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-ExcP0l6ikA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #107 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128384&action=edit Bug 26346: Updated schema file Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:09:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:09:26 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-kB8uoCMPp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #108 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128385&action=edit Bug 26346: Add option to make public lists editable by all staff If a staff member has access to the staff client (either because 'catalogue' permission is enabled or they're a superlibrarian then that user can add items (from OPAC or staff client) to a list marked 'Staff only' Test plan: 1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes to contents from' there are three options: Nobody, Owner only, Anyone seeing this list 2. Apply first 3 patches and run updatedatabase.pl cd installer/data/mysql sudo koha-shell <instance> ./updatedatabase.pl 3. Restart memcached and plack 4. Create 4 patron accounts: - User A : Superlibrarian permissions - User B : 'Staff access, allows viewing of catalogue in staff interface (catalogue)' - User C : No permissions - User D : 'Staff access, allows viewing of catalogue in staff interface' and 'Lists' > Edit public lists (edit_public_lists)' sub-permission 5. Login to staff client as User A. Create a public list and select the new 'Staff only' option under 'Allow changes to contents from' 6. Log into the staff client as User B. Confirm you can add items to the list from the following staff client pages: - Individual list page using the 'Add items' button - Staff client search result page - Staff client biblio detail page 7. Confirm you can remove items from the list 8. Confirm you can perform an OPAC search when not logged in 9. Log into the OPAC as User B. Confirm you can add items to the list from the following OPAC pages: - OPAC search result page - OPAC biblio detail page 10. Log into the OPAC as User C. Do an OPAC search and confirm you can view the list, but not add items to it 11. Login to the staff client as User B. Create a new list with the following settings: - 'Category'='Private', - 'Allow changes to contents from'='Staff only' Notice a red hint message is displayed. Change 'Category'='Public' and notice the hint is removed 12. Log into the OPAC as User C. Notice the 'Staff only' option is not available when creating a list 13. Log into the OPAC as User B. Repeat step 11. Confirm the same outcome 14. Log into the staff client as User A. Create a list with the following settings: - Public = 'Public' - Allow changes to contents from = 'owner only' 15. Log into the staff client as User D. Edit the list from step 14 confirm you can edit the list to have 'Allow changes to contents from' = 'Staff only' 16. Run Patron.t and Virtualshelves.t unit tests: sudo koha-shell <instance> prove t/db_dependent/Koha/Patron.t prove t/db_dependent/Virtualshelves.t Sponsored-by: Horowhenua District Council, New Zealand Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:38:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:38:55 +0000 Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23793-70-VMDWlGFCAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 --- Comment #19 from David Cook <dcook at prosentient.com.au> --- (In reply to Ere Maijala from comment #14) > Ok, fine. :) I trust that there will be something using this soon. I'm > generally not in favour of adding functionality without anything using it > since there's always a risk that something happens and it ends up never > being used. I don't think there's any core functionality that is using it today unfortunately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 05:58:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 04:58:26 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-qU3OPv9qqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 --- Comment #109 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Ready to test again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:22:13 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-vDrs06ZFQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:22:13 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7923-70-2Jkqz2xD8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 [Bug 29672] Increase performance of Koha::Plugins->call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:29:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:29:43 +0000 Subject: [Koha-bugs] [Bug 29677] New: SErials logs Message-ID: <bug-29677-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29677 Bug ID: 29677 Summary: SErials logs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org Serials logs should include more data, now there is no way of knowsing how many issues has been added by subscription or who has added them,all other modules haave detailed info in logs Action_log table should include also modifications on serial table, who, when and action -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:35:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:35:33 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-wHbgWCB01v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- I see it returns undef when plugins are disabled. It should return empty array non ? In order to allow : my @plugin_responses = Koha::Plugins->call( 'opac_results_xslt_variables', { lang => $lang, patron_id => $borrowernumber } ); for my $plugin_variables ( @plugin_responses ) { $variables = { %$variables, %$plugin_variables }; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:40:41 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-LQBkVo2ihr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Fridolin Somers from comment #4) > I see it returns undef when plugins are disabled. > It should return empty array non ? > > In order to allow : > > my @plugin_responses = Koha::Plugins->call( > 'opac_results_xslt_variables', > { > lang => $lang, > patron_id => $borrowernumber > } > ); > for my $plugin_variables ( @plugin_responses ) { > $variables = { %$variables, %$plugin_variables }; > } Oh i see it is covered by a unit test : t::lib::Mocks::mock_config('enable_plugins', 0); @responses = Koha::Plugins->call('check_password', { password => '1234' }); is_deeply(\@responses, [], 'call() should return an empty array if plugins are disabled'); Should be OK :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:41:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:41:42 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-yWVW4L3Mte@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:53:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:53:01 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-ywNx7zI8xG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 --- Comment #2 from David Nind <david at davidnind.com> --- Hi Katrin. Just to make sure I've understand the problem. Previously you would get something like 'Don't use' and 'Use' as separate strings to translate. That way you could translate using the right word, depending on the rest of the sentence for the system preference. But now you are getting 'Don't use Use' as one string to translate. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 07:53:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 06:53:36 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-BIDgeJXclk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:00:02 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-Okuv6WNTt6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- Instead of creating get_enabled_plugins(), Why not adding a param "only_enabled" in GetPlugins() ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:11:29 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-WoBoVbSiYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Fridolin Somers from comment #6) > Instead of creating get_enabled_plugins(), > Why not adding a param "only_enabled" in GetPlugins() ? GetPlugins already returns only enabled plugins by default (without the 'all' parameter), but it also have other parameters that make it hard for its result to be put in cache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:14:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:14:28 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28607-70-IxUgJjnAWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 --- Comment #3 from Kunal <kunalschakraborty at gmail.com> --- (In reply to Katrin Fischer from comment #2) > Is it possible that you have changed the timeout system preference to a too > low value? I have not changed anything. I have tried many instructions but the only one that reached up to web installation and showed that error. Below is the link for the instruction page that I followed. https://technicaldigit.com/install-koha-on-ubuntu/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:23:48 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-tBPBYPWAGy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 --- Comment #5 from Afroditi Fragkou <infoscienceaddict at gmail.com> --- Ok, I'll look into it. Thank you all! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:34:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:34:01 +0000 Subject: [Koha-bugs] [Bug 29659] QR Code Accompanying material In-Reply-To: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29659-70-9jej5ojpNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29659 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- Or use a smartphone app and share the result somehow to your computer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:36:31 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-RPnPoQWSKs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29672 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:36:31 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-hAkycPAh0Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:38:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:38:20 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-43rCSANW2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Julian Maurice from comment #5) > > The problem is not this particular hook. It's Koha::Plugins->call that is > too slow. I tried making it faster with bug 29672. > Please test and let me know what you think I agree with you. Thanks a lot for the perf patch, looks great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 08:40:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 07:40:15 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-7eU1qT9Seg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:42:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:42:13 +0000 Subject: [Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+ In-Reply-To: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13669-70-FfvHhM66MI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I stumbled over RunSQL while trying to add a CREATE FUNCTION in a Koha installer script. The script can be run fine with mysql client but not via RunSQL. Why? In order to create a function or procedure you need to change the delimiter with DELIMITER // (or some other character). This is not a MySQL command. RunSQL will crash on it, but the mysql client knows about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:44:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:44:25 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-27TFDRw7is@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 jmbroust <jean-manuel.broust at univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:50:32 +0000 Subject: [Koha-bugs] [Bug 29677] Add more detailed serials logs In-Reply-To: <bug-29677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29677-70-YuRMyVcJHl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29677 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SErials logs |Add more detailed serials | |logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:55:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:55:44 +0000 Subject: [Koha-bugs] [Bug 29673] Allow an English sql localization script In-Reply-To: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29673-70-dB5eKSi05e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:55:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:55:47 +0000 Subject: [Koha-bugs] [Bug 29673] Allow an English sql localization script In-Reply-To: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29673-70-NeGqpi4NiB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128386&action=edit Bug 29673: Allow English sql localization script Test plan: You might want to add a simple SQL statement to your English custom.sql in order to verify the execution. Run a Koha install (in English). Check if the data shows your custom sql action. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:56:24 +0000 Subject: [Koha-bugs] [Bug 29673] Allow an English sql localization script In-Reply-To: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29673-70-m2nxq0DGti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:56:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:56:57 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-xaoeHufVyO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Actually it's the other way around: The problem is that they are separate strings. A lot of the system preferences use "use", "don't use", "activate", deactivate" as options in the pull downs. But when translating you don't always translate them the same way, especially for system preferences where you might need to move things around to make the sentence sound nice and work grammatically. But because I only get 1 tanslation for "don't use" per file I can't make it work and match what we have in the GUI. What I would much prefer is it being one string, something like: Asks: [Use|Don't use] cash registers with the accounting system to track payments. (Default: Don't use) But this is only one solution to the issue, which is why I wanted to discuss. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 09:58:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 08:58:42 +0000 Subject: [Koha-bugs] [Bug 29063] [DOCS] Manual: Translation issue with repeated strings in system preferences In-Reply-To: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29063-70-6K3mkqNRJ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29063 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe if you see it on pootle it explains a bit better (you might have to be logged in): https://translate.koha-community.org/de/21.11/translate/de-DE-pref.po#search=don't%20use&sfields=source,target&offset=10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 10:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 09:14:42 +0000 Subject: [Koha-bugs] [Bug 29673] Allow an English sql localization script In-Reply-To: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29673-70-aaoNkPyQIu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29673 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- See bug 13669 comment71 showing that you cannot add functions or procedures in a sql file run by DBIx::RunSQL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 10:54:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 09:54:55 +0000 Subject: [Koha-bugs] [Bug 29666] Gmail>>Compose>>Clicking on send button application throws server error In-Reply-To: <bug-29666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29666-70-1dUpvFS8Ob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29666 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is not the bug tracker for Gmail, but for Koha, the open source library management system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 11:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 10:08:51 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-cJa0Odep4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se --- Comment #2 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128387&action=edit Bug 27208: Add a user specified delay before sending pickup notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 11:09:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 10:09:37 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-PZCAwvBQ32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #3 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128388&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 11:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 10:10:52 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-lZVHUCQTcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bjorn.nylen at ub.lu.se |ity.org | Status|NEW |ASSIGNED --- Comment #4 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128389&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 11:11:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 10:11:45 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-ldLCR55DwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #5 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128390&action=edit Bug 27208: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 11:26:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 10:26:13 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-Rkl5yeva6i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Proposing this solution. Th patch adds a new column to the message_queue, delay_until, that contains a time that the notice should be delayed until. Om the returns page there are a new circulation setting, Delay pickup notice until, where the librarian can set a time the notice will be delyed until. On the patron account notice log, there will be a note indicating the delayed messages.(pending, delayed until [datetime]) For us the main usage in our stacks where books are processed as they are picked but they might not be available for the patron until a few hours later in the day. The change to the message queue should be backwards compatible as the delay_until will be set to null unless a time is provided and those messages will be processed as before. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in an item with a hold to produce a pickup notice. 3. Select a time for pickup notice delay. Note the warning about the delay. 4. Check in another item with hold to produce a pickup notice. 5. Check the patron notice logs, the one with a delay should read "pending, delayed until ...". 6. Run process_message_queue.pl before and after the selected time above. The delayed message should not be sent until after the set time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:02:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:02:41 +0000 Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23793-70-5InHWWuYdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #19) > (In reply to Ere Maijala from comment #14) > > Ok, fine. :) I trust that there will be something using this soon. I'm > > generally not in favour of adding functionality without anything using it > > since there's always a risk that something happens and it ends up never > > being used. > > I don't think there's any core functionality that is using it today > unfortunately. opac/opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:09:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:09:09 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-1sl5HVi7to@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128391&action=edit Bug 29670: Unit tests This patch adds unit tests for Koha::Edifact::Order->order_line. We now check that the message segments are created as expected for both the 'ordering' and not 'ordering' case for acquisitions item creation time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:09:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:09:13 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-IZsT8wPagL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128379|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128392&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. Test plan. 1) Run the newly created unit tests that prove both settings work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:10:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:10:39 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-alFKRByMEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:11:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:11:07 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-wjJkXWlmuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi, | |joonas.kylmala at iki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:11:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:11:24 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-IIgJaepLMW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:13:32 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-zvLHEbDqUe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128391|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128393&action=edit Bug 29670: Unit tests This patch adds unit tests for Koha::Edifact::Order->order_line. We now check that the message segments are created as expected for both the 'ordering' and not 'ordering' case for acquisitions item creation time. Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:13:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:13:36 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-X8QEppQotm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128392|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128394&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. Test plan. 1) Run the newly created unit tests that prove both settings work Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:17:07 +0000 Subject: [Koha-bugs] [Bug 29670] Fix errors caused by bug 27708 In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-Ec9Btf6mdG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Tested on live environments that exhibited problems prior to the patch and signed off. The issue was that if your settings meant that items were created at order time, but 27708 made it so that the GIR segments would not get sent to the vendor. The patch fixes that problem, but leaves in place the handling for when items are not created at order time. I also corrected the itemtype assignment key for the case where items are not created as this was incorrect in bug 27708 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:24:36 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-zY6pe7qUAf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix errors caused by bug |Restore functionality |27708 |broken by bug 27708 for | |AcqCreateItem set to | |"placing an order" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 12:26:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 11:26:09 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-zVQbZ2ePcG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch restores the release notes| |lost GIR segments in EDI | |messages generated by | |orders with items attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:06:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:06:18 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: <bug-29637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29637-70-dM058VF1Ni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:09:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:09:14 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29528-70-aFZujAqmAd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:14:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:14:56 +0000 Subject: [Koha-bugs] [Bug 29464] Sorting broken for receiving in acquisitions In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-c3kax0Drx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- This was certainly working on bug 20212. Will try to check what else changed after it was pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:21:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:21:49 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-zWenTci2pM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #3 from David Nind <david at davidnind.com> --- I've made my first attempt on documenting the steps - still needs some work: https://wiki.koha-community.org/wiki/Documentation_management#Translating_the_manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:25:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:25:01 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: <bug-28617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28617-70-HD8RDBfIJF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:27:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:27:34 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29593-70-8SgVW29QcT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:29:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:29:32 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-USwMIgQOcG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:30:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:30:52 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-qZgDHmmLBS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- I anticipate we may need to backport patches related to these files in 21.11.x branch. It makes sense to backport these changes for that reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:39:40 +0000 Subject: [Koha-bugs] [Bug 29678] New: Can't use exteral URL for XSLT stylesheet Message-ID: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 Bug ID: 29678 Summary: Can't use exteral URL for XSLT stylesheet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org If I try to specify an external URL as an XSLT stylesheet it doesn't work. In the error logs I see messages like this: [2021/12/10 12:37:50] [WARN] XSLT::Base: Could not create file parser context for file "https://path/to/MARC21slim2intranetResults.xsl": No such file or directory at /kohadevbox/koha/Koha/XSLT/Base.pm line 330. I have verified that the .xsl file is accessible and that internal links (to MARC21slimUtils.xsl for instance) are valid too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:44:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:44:44 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-5SZsZRQCZa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sorting broken for |GET /acquisitions/orders |receiving in acquisitions |doesn't honour sorting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:45:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:45:23 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-4Ji6eKS4yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #4 from David Nind <david at davidnind.com> --- I'm still not 100% clear on the process to update the translations for 20.05 and 20.11. ** Update the translations on koha-community.org/manuals ** 1. Follow step 6 - pull request, merge into repository -> builds run and update k-c.org OR 2. Use secret URL to make the pull request? ** To get Pootle updated with changed strings ** Contact Translation manager and ask for strings to be updated. Or do I use the tools to update the .po files in the repository for the versions: 1. Create a branch 2. Locally run: make gettext 3. Tidy ups to .po files? 4. Commit and push to branches on GitLab: Translation update - manual - 2021-12-XX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 13:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 12:59:48 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-77aWcdAezB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #5 from David Nind <david at davidnind.com> --- (In reply to David Nind from comment #4) > 3. Tidy ups to .po files? That should have said .pot files! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:24:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:24:31 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-oVDOrl87HV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128395&action=edit Bug 29464: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:24:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:24:36 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-aHifyuICid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128396&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:28:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:28:11 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-KBUmQUnV3t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:28:32 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-LIBidCRppv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:30:50 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-zq13rVkviJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:30:50 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29570-70-QfqfJLrOOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 [Bug 29464] GET /acquisitions/orders doesn't honour sorting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:31:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:31:23 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-64tRfzuQNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Nick Clemens from comment #0) > This seems to be from bug 20212 - the sort options in the headers of the > pending_orders table no longer function. Done. > Additionally, the 'Summary' column is now marked as 'orderable: false' - it > was possible to sort on this column before those patches Will handle this on bug 29570. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:31:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:31:39 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29570-70-Xhp4nCOmY4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:31:41 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-1PB0bxn0k2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, not sure about the process, but you don't want to update the po files locally (your last option). The translation work is already done on another repo and "just" needs to be merged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:31:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:31:48 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29570-70-5CxhqMLF1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 14:43:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 13:43:48 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-07hB9g2YOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, reading the wiki page: String freeze Currently we have no string freezes for the manual as it doesn't have a real release date. The translation files on translate.kc.org used to be updated more continuously I think - but I don't seen an update for your latest changes: https://translate.koha-community.org/de/ (last update 7 months ago) I think the current string freeze for Koha is already quite short, which makes it hard to finish the Koha translations in that amount of time. Adding the manual to it would be too much I think. I'd prefer having a monthly update of po files at least or even better continously updates whenever a change is made. Especially since we have been backporting fixes/corrections to older versions of the manual. I believe using the "magic url" to make pull requests for the each language would work, but maybe there is an easier way to do them all at once? And it's currently missing 21.05 in the pull down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:27:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:27:50 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-B7l9nFyAIv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:27:53 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-zTx4wYarsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128395|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128397&action=edit Bug 29464: Regression tests Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:27:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:27:57 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-Rciu0syKdF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128396|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128398&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:29:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:29:21 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-wQOt6VZQPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Tests pass and sorting works so I signed off. Making the Summary/title sortable again will happen in Bug 29570? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:32:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:32:33 +0000 Subject: [Koha-bugs] [Bug 29628] Purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions In-Reply-To: <bug-29628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29628-70-8B7m11Q17m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr --- Comment #10 from Andreas Roussos <a.roussos at dataly.gr> --- (In reply to Lucas Gass from comment #8) > (In reply to Katrin Fischer from comment #6) > > Hi Lucas, can you please check if this is a duplicate to bug 29571? > > Katrin, looks like a duplicate to me. I will close this one but I am curious > if Bug 29571 needs Andreas's follow-up. I am unable to reproduce the edge > case. Hi Lucas -- by all means, please feel free to close this bug ;-) Jonathan's fix in Bug 29571 is much shorter/cleaner than my follow-up patch here, and also deals with the edge case I described. FWIW, the edge case would manifest after applying the initial patch submitted for this bug, since in the template file koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt 178 [% IF ( CAN_user_suggestions_suggestions_manage && pendingsuggestions ) %] was changed to 178 [% IF ( CAN_user_suggestions_suggestions_manage && all_pendingsuggestions ) %] In mainpage.pl, the template parameter `all_pendingsuggestions` would be equal to 0 if the number of pending suggestions in the currently selected branch is equal to the number of pending suggestions across all branches (see line 90 below): 86 my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" }); 87 my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count(); 88 my $pendingsuggestions_count = $pendingsuggestions->count(); 89 $template->param( 90 all_pendingsuggestions => $pendingsuggestions_count != $local_pendingsuggestions_count ? $pendingsuggestions_count : 0, 91 pendingsuggestions => $local_pendingsuggestions_count 92 ); Thus, the condition inside the template [% IF %] block would be false and the "Suggestions pending approval:" text would not appear at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:41:31 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-hg1n5sqvmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:41:34 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-Ipsqx3pDxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128271|0 |1 is obsolete| | --- Comment #5 from Andreas Roussos <a.roussos at dataly.gr> --- Created attachment 128399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128399&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot at biblibre.com> Signed-off-by: Andreas Roussos <a.roussos at dataly.gr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:55:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:55:50 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-8ECtAwYl40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate Severity|critical |blocker CC| |kyle at bywatersolutions.com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Upping severity, this is blocker for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 15:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 14:56:20 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-AyBoW9aaZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr --- Comment #6 from Andreas Roussos <a.roussos at dataly.gr> --- (In reply to Christophe TORIN from comment #0) > On the mainpage, the "Suggestions pending approval" block is shown only if > there are suggestions for the user's current library, even if the other > library have suggestions. The suggestions pending approval are also meant to be displayed in the right hand side of Home > Acquisitions. The change Jonathan suggested can be applied to koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt as well. Would it be OK if I submitted a follow-up patch for this here, and also change the Bug title accordingly (remove "Mainpage : ")? Or is it best practice to submit a new bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:08:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:08:20 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29464-70-fQT1YPQ0Uy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Lucas Gass from comment #9) > Tests pass and sorting works so I signed off. Making the Summary/title > sortable again will happen in Bug 29570? Yes, that's much more complex to solve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:17:37 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-4DGbnwho5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 --- Comment #18 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128400&action=edit Add syspref to deal with overdues notification I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Change syspref 'EmailOverduesNoEmail' to "Don't send" 11. Delete data from message_queue (if you have access) for a cleaner view 12. Run again misc/cronjobs/overdue_notices.pl 13. Check that only the print message is now generated and not the "Overdue Notices" one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:19:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:19:03 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-uzpnfKp8jJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #15 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128401&action=edit Add syspref to deal with overdues notification I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Change syspref 'EmailOverduesNoEmail' to "Don't send" 11. Delete data from message_queue (if you have access) for a cleaner view 12. Run again misc/cronjobs/overdue_notices.pl 13. Check that only the print message is now generated and not the "Overdue Notices" one. https://bugs.koha-community.org/show_bug.cgi?id=20074 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:21:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:21:39 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-jO6LAUfvAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m --- Comment #19 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Sorry for disturbing I miss my last bug attachement with git bz :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:22:13 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-GYF4Lfy72O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m Assignee|arthur.suzuki at biblibre.com |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:23:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:23:48 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-iXtDvNMdqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Sorry for the message at the bottom of the test plan, I miss my last attachement with git bz :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:57:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:57:17 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-8DcsKSTES6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127270|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128402&action=edit Bug 28377: Use the API to suspend/resume holds This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:57:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:57:21 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-rs8sRfRVDq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127271|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128403&action=edit Bug 28377: (follow-up) Remove svc/hold/{resume|suspend} This files are no longer used and thus removed. Their functionality is already present on the API POST /holds/:hold_id/suspension DELETE /holds/:hold_id/suspension To test: 1. Apply this patch 2. Run: $ git grep 'hold/suspend' $ git grep 'hold/resume' => SUCCESS: No references to the scripts 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:57:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:57:25 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-fI8If0G3qP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128380|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128404&action=edit Bug 28377: (28937 follow-up) Flatpickr change Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:57:29 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-525mzLjySp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128381|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128405&action=edit Bug 28377: (QA follow-up) Fallback error handling The code only dealt with 404, this patch makes it have a fallback message for failure codes. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:57:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:57:53 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-yTsMeddOta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:58:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:58:05 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-I3xhDbWVk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Retested, back to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 16:58:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 15:58:11 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-RFBZW2fRNi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 17:03:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 16:03:39 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-QgHOe3gicJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128370|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128406&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 17:03:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 16:03:44 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-b8SA98GQGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128372|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128407&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 17:04:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 16:04:21 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-X2qOPyZuXN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 17:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 16:04:56 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-VXPPaDJKhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This all appears to make sense and passes the QA scripts.. I believe it resolves the regression and doesn't cause any new ones. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 17:12:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 16:12:30 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-g82sId9sYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Hi Andreas, attach a patch here and switch the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 18:59:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 17:59:47 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26355-70-aANk17RpKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Cheryl <clackman at fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 20:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 19:30:09 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-UckLoXQbZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #8 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #7) >.. Adding > the manual to it would be too much I think. I'd prefer having a monthly > update of po files at least or even better continously updates whenever a > change is made. Especially since we have been backporting fixes/corrections > to older versions of the manual. Now that I'm figuring things out, I think monthly would make sense. I've updated the page to reflect this. > I believe using the "magic url" to make pull requests for the each language > would work, but maybe there is an easier way to do them all at once? And > it's currently missing 21.05 in the pull down. The "magic URL" seems to only be for Koha itself, so I've used the other page - pull requests for 20.05 and 20.11 made. I will ask Bernardo about updating it so 21.05 is available that way. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 20:49:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 19:49:30 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-lb9eI3IgB2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the patron page (detail and | |circulation) so that is | |uses the API to suspend and | |resume holds on the holds | |tab. | | | |It also removes the | |svc/hold/{resume|suspend} | |files as they are no longer | |used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 20:58:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 19:58:00 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-ynHsNnaDEj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds the system preference |Adds the system preference release notes|PatronSelfModificationManda |PatronSelfModificationManda |toryField in order to |toryField in order to |separate borrower |separate borrower |registration from borrower |registration from borrower |modification. |modification. | |Initial value | |is a copy of system | |preference | |PatronSelfRegistrationBorro | |werMandatoryField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:24:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:24:45 +0000 Subject: [Koha-bugs] [Bug 29679] New: Reports result menu shows too much dividers Message-ID: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Bug ID: 29679 Summary: Reports result menu shows too much dividers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In reports when you have item/biblio/patron records, you see a menu "Batch operations with ..." In this menu dividers are double when showing several menu headers. Looks like it is since Bug 29186. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:25:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:25:47 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-8PXKt1kzNy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29186 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 [Bug 29186] Move reports result limit menu into toolbar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:25:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:25:47 +0000 Subject: [Koha-bugs] [Bug 29186] Move reports result limit menu into toolbar In-Reply-To: <bug-29186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29186-70-TRb3nMa2RH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29186 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 [Bug 29679] Reports result menu shows too much dividers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:26:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:26:06 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-XlOncZzLT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:26:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:26:38 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-cT7Jmz4Sr3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128408&action=edit Screenshot of the bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:27:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:27:21 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-oXu1NGzfjU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- Test with report from Bug 5697 : SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:28:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:28:05 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-Zl54lUvfGE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29679 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:28:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:28:05 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-1MLOLd1BOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5697 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:38:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:38:48 +0000 Subject: [Koha-bugs] [Bug 29680] New: Reports menu 'Show SQL code' wrong border radius Message-ID: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Bug ID: 29680 Summary: Reports menu 'Show SQL code' wrong border radius Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In reports menu the 'Show SQL code' button has no right border radius. And if you click you see 'Hide SQL code' button has no left border radius. This is because these are two buttons in a group, hidden or displayed. The CSS ruling border radius is from bootstrap.min.css: .btn-group > .btn:first-child:not(:last-child):not(.dropdown-toggle) 0px A way to fix is to create 2 button groups. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:39:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:39:00 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-AwAQE5jCjT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:43:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:43:13 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-9AsFZftPfP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> --- Looks really great :D I'm testing for push to master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:45:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:45:18 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-gagsq8sIEB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:50:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:50:21 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-fKyr9KufgK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 21:50:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 20:50:25 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-HUUQF8UjTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 --- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 22:08:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 21:08:25 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-vqbUvmOBfH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- There's a magic URL from manual translations too I believe. I'm happy to help on automating more of this.. I did do some work last cycle to automate the merge requests but I can't remember what state we got to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 22:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 21:15:17 +0000 Subject: [Koha-bugs] [Bug 29647] [DOCS] Update po files in manual repository In-Reply-To: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29647-70-83Nq10WX4p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29647 --- Comment #10 from David Nind <david at davidnind.com> --- Thanks Martin! Happy to figure out and run any manual steps required in the meantime. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 10 22:47:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Dec 2021 21:47:02 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-2nTOHC0YY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Nugged <nugged at gmail.com> --- Please provide second reproduction scheme, for opac-tags.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 04:23:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 03:23:12 +0000 Subject: [Koha-bugs] [Bug 29681] New: How to unblock someone on Facebook on android phones? Message-ID: <bug-29681-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29681 Bug ID: 29681 Summary: How to unblock someone on Facebook on android phones? Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: jin20010629 at gmail.com Facebook has a different application for android gadgets. Assuming you are utilizing an android gadget interestingly, you could deal with an issue in utilizing the application. We propose clients contact our leaders to realize How to unblock someone on Facebook. They will disclose to you the least difficult methodology to eliminate a person from your companion list. https://www.numbersforsupport.net/blog/unblock-someone-on-facebook/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 04:24:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 03:24:22 +0000 Subject: [Koha-bugs] [Bug 29682] New: Need to realize how to activate cash app card? Message-ID: <bug-29682-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29682 Bug ID: 29682 Summary: Need to realize how to activate cash app card? Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: jin20010629 at gmail.com Assuming that you are a cash app client and need to activate your cash app card then you have picked the correct way to your goal. To realize how to activate cash app card you simply need to tap on this connection and afterward your work will be done in couple of moments. https://www.numbersforsupport.net/blog/how-to-activate-cash-app-card/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 06:42:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 05:42:53 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-HTthwXopOC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #29 from Fridolin Somers <fridolin.somers at biblibre.com> --- Great enhancement but I found some issues in db changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 06:43:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 05:43:25 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-tpx9blHa1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 06:43:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 05:43:31 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-5JKb9n38ZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128409&action=edit Bug 13188: (RM follow-up) Several fixes on db changes Several issues with the atomic update: - File must to be .pl - File must be executable : chmod a+x - Syspref type is 'free' not 'multiple' Small addition in atomic update: I've added a print of syspref name and value, this can be usefull for upgrade logs. Also a minor issue in installer/data/mysql/mandatory/sysprefs.sql : The description whas different from the atomic update. I choose that atomic update is correct. Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 06:48:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 05:48:06 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-RsFoFfRJhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> --- Another point : Since in opac.pref, syspref PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField contain : exclusions: sort1|sort2 https://git.koha-community.org/Koha-community/Koha/src/commit/b0767f94d07950e7420deb901b208d131427c535/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref#L837 So should new syspref PatronSelfModificationMandatoryField ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 06:48:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 05:48:39 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-H0b80kkz0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #32 from Fridolin Somers <fridolin.somers at biblibre.com> --- I'd like a new QA on this please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:04:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:04:28 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15157-70-8wJL3uYj0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> --- I think we should rename the script debarrBorrowersWithFines.pl. Essentially we use 'patron' now instead of 'borrowers', like misc/import_patrons.pl. So maybe debarr_patrons_with_fines.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:16:15 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-AgFowzNSAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:16:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:16:18 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-pznlEX6dWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:17:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:17:03 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-1YE7Q9pUty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:49:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:49:51 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-volYA3W5E0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #27 from Fridolin Somers <fridolin.somers at biblibre.com> --- + alert(_("Your request could not be processed. Check the logs")); It is in holds.js, shouldn't it use __("foo") ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 07:55:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 06:55:02 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-kLCPTsGGUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:10:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:10:46 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-7THwWUO64d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #17 from David Nind <david at davidnind.com> --- Patch no longer applies 8-(... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20076: Overdues: remove redundant message when patrons don't have email addresses Using index info to reconstruct a base tree... M misc/cronjobs/overdue_notices.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 20076: Overdues: remove redundant message when patrons don't have email addresses Testing notes (using koah-testing-docker): * To get notices generated on Tools > Patrons and circulation > Overdue notice/status triggers I set the rules for all patron types and the default library to: delay = 1, Letter = Overdue notice, Email = ticked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:15:50 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-I6qUhh2YXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:15:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:15:54 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-PTNuW8Qdne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:19:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:19:55 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29611-70-sfTPhbqSxT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:19:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:19:58 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29611-70-CixcJu81XJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:29:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:29:09 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-cOHZ6VBg0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:32:20 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-1jWbhFG0re@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:32:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:32:22 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-Btxii3TjeV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:42:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:42:54 +0000 Subject: [Koha-bugs] [Bug 29681] SPAM In-Reply-To: <bug-29681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29681-70-v4czUFV841@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29681 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m QA Contact| |testopia at bugs.koha-communit | |y.org Component|Project website |Architecture, internals, | |and plumbing Status|NEW |RESOLVED Summary|How to unblock someone on |SPAM |Facebook on android phones? | Product|Project Infrastructure |Koha Assignee|wizzyrea at gmail.com |koha-bugs at lists.koha-commun | |ity.org Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:44:37 +0000 Subject: [Koha-bugs] [Bug 29682] SPAM In-Reply-To: <bug-29682-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29682-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29682-70-Uh2NIRoHfE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29682 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Project Infrastructure |Koha Assignee|wizzyrea at gmail.com |koha-bugs at lists.koha-commun | |ity.org Status|NEW |RESOLVED CC| |fridolin.somers at biblibre.co | |m QA Contact| |testopia at bugs.koha-communit | |y.org Resolution|--- |INVALID Summary|Need to realize how to |SPAM |activate cash app card? | Component|Project website |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:45:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:45:24 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-xg8yi7jBAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Summary|Can't use exteral URL for |Can't use external URL for |XSLT stylesheet |XSLT stylesheet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 08:53:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 07:53:11 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-kchL7q8rmV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I was slow to the game here.. adding to the ndiscussion on tiaga, I've used a few systems that take the approach Julian suggests and never had any real performance concerns. I quite like the idea of not having to maintain the structure twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 09:19:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 08:19:00 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-teOvVVfWxs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- In my tests I get logs : 204 Exception::Class::Base::throw('Koha::Exceptions::Metadata::Invalid', 'id', 368, 'biblionumber', 369, 'format', 'marcxml', 'schema', 'MARC21', 'decoding _error', ':8: parser error : PCDATA invalid Char value 31^J <controlfield tag="001">00^_aD000015937</controlfield>...) called at /kohadevbox/koha/Koha/Bibl io/Metadata.pm line 73 205 Koha::Biblio::Metadata::record('Koha::Biblio::Metadata=HASH(0x55905c3efc40)') called at /kohadevbox/koha/Koha/Biblio.pm line 943 206 Koha::Biblio::get_marc_notes('Koha::Biblio=HASH(0x55905cbc1820)', 'HASH(0x55905cbbb5b0)') called at /kohadevbox/koha/catalogue/detail.pl line 148 207 eval {...} at /kohadevbox/koha/catalogue/detail.pl line 2 Very strange... Maybe some impact I can't explain of Bug 28734 adding transformMARCXML4XSLT() to get_marc_notes(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 09:28:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 08:28:39 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-ADJA2YFB3U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Fridolin Somers from comment #1) > In my tests I get logs : > > 204 Exception::Class::Base::throw('Koha::Exceptions::Metadata::Invalid', > 'id', 368, 'biblionumber', 369, 'format', 'marcxml', 'schema', 'MARC21', Ah forget that, biblionumber=369 has bad MARCXML on purpose in KTD -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 10:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 09:48:55 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-e8wPQEvSBV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 10:49:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 09:49:01 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-l936FJRrSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128410&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 10:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 09:51:03 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-f59ZRbHnkD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #128378|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Comment on attachment 128378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128378 Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Not sure what I did - obsoleting the patch. Note: I changed the title of the commit message so it includes the bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 11:08:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 10:08:34 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-zcat4qtRHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the behaviour of release notes| |the replace an authority | |record via Z39.50/SRU | |buttons when editing an | |authority record. Both ways | |of doing this (Edit > Edit | |record > Replace record via | |Z39.50/SRU search and Edit | |> Replace record via | |Z39.50/SRU search) now | |pre-fill the search form | |with available data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 13:42:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 12:42:28 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-BYQn4ivDQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Fridolin Somers from comment #27) > + alert(_("Your request could not be processed. Check the logs")); > It is in holds.js, shouldn't it use __("foo") ? Yes, good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 18:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 17:37:02 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-weMogp8hrm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 18:37:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 17:37:07 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-HC8e6fF5Oq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127482|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128411&action=edit Bug 28855: Purging suggestions test should not be on timestamp DelSuggestionsOlderThan is on "date", a timestamp. It can be a problem because "date" is updated when we update the database, in consequences all the suggestions take the same date. This patch use 'manageddate' instead. In order to test this patch, you will need to have some suggestions where "Managed on" (suggestions.manageddate in the database) is older from "Last updated" (suggestions.date in the database). This can append during some specific update. If you don't have such data, you will have to add them via SQL request. Example of sql for insertion (ID is the patron id of a librarian which can manage suggestions): INSERT INTO suggestions (suggestedby, suggesteddate, managedby, manageddate, acceptedby, accepteddate, STATUS, title) VALUES (1, '2020-10-13', 1, '2020-10-26', 1, '2020-10-26', 'ACCEPTED', 'title'); Test plan: 1- Choose a date and find (or add) a suggestion where: - "Last updated" is not older than this date - "Managed on" is older than this date - "Status" is different from "Pending" ("ASKED" in database) Calculate number_days = today's date - chosen date Example: (Today's date 28/10/2021, chosen date : 28/10/2020, number_days=365) Suggestion | .. | Managed on | .. | Last updated | .. | Status title | .. | 10/26/2020 | .. | 05/15/2021 | .. | Accepted 2- Run cron job /home/koha/src/misc/cronjobs/purge_suggestions.pl --confirm --days number_days 3- Check that this suggestion has not been deleted 4- Apply the patch 5- Repeat steps 1 and 2 6- Check that this suggestion has been deleted Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 18:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 17:37:13 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-i8ZJdkHt3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127483|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 128412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128412&action=edit Bug 28855: (follow-up) adapt specific test Adapt the test of function DelSuggestionsOlderThan to match the new behaviour of the function. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 19:04:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 18:04:44 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-pMgRgUlymX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This changes the date field release notes| |that cronjob | |misc/cronjobs/purge_suggest | |ions.pl uses to calculate | |the number of days for | |deleting accepted or | |rejected suggestions. It | |now uses the managed on | |date, as the last updated | |date that was used can be | |changed by other database | |updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 19:10:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 18:10:54 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-WiAgfvkP4T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #6 from David Nind <david at davidnind.com> --- I reviewed the manual to see whether any changes are required - no change as required as it doesn't mention how the date is calculated (see acquisitions > suggestions section, acquisition system preferences > PurgeSuggestionsOlderThan, and cron jobs > clean up old suggestions). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 11 21:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Dec 2021 20:22:29 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-4BTRb5d3kg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #39 from Fridolin Somers <fridolin.somers at biblibre.com> --- I think this can be useful in other places like a patrons search filter. I'm looking at it for master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 10:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 09:24:06 +0000 Subject: [Koha-bugs] [Bug 29641] Upgrade to 21.06.00.012 [15:20:16]: Bug 15067 - Add missing languages ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738 In-Reply-To: <bug-29641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29641-70-m0F2bCIvYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29641 MD NAZRUL ISLAM <nazrul.it.puc at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nazrul.it.puc at gmail.com Summary|Error "Duplicate entry |Upgrade to 21.06.00.012 |'IN-region' for key |[15:20:16]: Bug 15067 - Add |'uniq_lang' at |missing languages ERROR: |/usr/share/koha/lib/C4/Inst |{UNKNOWN}: DBI Exception: |aller.pm line 738" while |DBD::mysql::db do failed: |upgrading from 21.05.05-3 |Duplicate entry 'IN-region' |to 21.11.00-1 |for key 'uniq_lang' at | |/usr/share/koha/lib/C4/Inst | |aller.pm line 738 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 13:11:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 12:11:43 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-LzKyEtHAbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #62 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > The exact reason I am suggesting to count how many times you enter the method is that I don't want to think about those questions. Oh, I see. > Create a global var $i, warn ++$i and you will know. Would that be using the wrapping script on the syspref template and then adding the counter in t in Koha/Template/Plugin/I18N.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:00:04 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-nWCR3vhrXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #0) > If I try to specify an external URL as an XSLT stylesheet it doesn't work. > In the error logs I see messages like this: > > [2021/12/10 12:37:50] [WARN] XSLT::Base: Could not create file parser > context for file "https://path/to/MARC21slim2intranetResults.xsl": No such > file or directory at /kohadevbox/koha/Koha/XSLT/Base.pm line 330. > > I have verified that the .xsl file is accessible and that internal links (to > MARC21slimUtils.xsl for instance) are valid too. Where did you specify it? Z3950/SRU target? If you have an external IntranetResults.xsl, how do you get to the slimUtils? I remember to have opened a bug report for includes over https. (Was not possible) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:08:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:08:49 +0000 Subject: [Koha-bugs] [Bug 25216] XSLT can only use HTTP not HTTPS URL. In-Reply-To: <bug-25216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25216-70-201MNHKm07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25216 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 12758 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:08:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:08:49 +0000 Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12758-70-VRBOEI5DFE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 25216 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:09:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:09:37 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-9hWGLmG7g5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this was filed for the XSLT system preferences (results and detail pages), from the discussion on IRC. I've found bug 25216 - could this be the reason? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:37:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:37:17 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15157-70-a0QOl15qsU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 1) I think debar_patrons_with_fines.pl would be great. Note r vs rr here. :) 2) I am not sure about this requirement here: + print "\nYour --message is too short. A proper message to your end-users must be longer than 20 characters.\n"; Depending on language this might be a strange requirement. For example Chinese/Japanese tend to have much shorter texts because of the use of signs. 3) I think David is right about having a system preference for this to make it easier to use on multi-instance systems, but I wonder if this should be a hard requirement. One advantage of doing it right from the beginning is that it's much easier than introducing later when you might break/change peoples workflows. But I am not sure if a lot of instances would use that in the same way, it looks more like a 'once a year' type of thing then a very regular cronjob. So for me this would not be a blocker right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 14:52:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 13:52:51 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15157-70-ftOgAccyG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I see that this is still assigned to Olli, but has follow-ups from Emmi and Martin. Is someone currently working on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:23:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:23:41 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-TlafXAgHJm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:23:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:23:46 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-LugLqXb2zj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125272|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128413&action=edit Bug 13188: Add PatronSelfModificationMandatoryField system preference TEST PLAN: 1. Apply patch, updatedatabase, restart_all 2. In the PatronSelfRegistrationBorrowerMandatoryField add the field password. 3. Go to the self registration page on make sure password is required. 4. Now go to the OPAC modification page, make some changes and attempt to submit. It should work. 5. Go to PatronSelfModificationMandatoryField and select some fields. 6. The columns you selected should now be required. 7. On the PatronSelfModificationMandatoryField page, make sure the select all and clear all buttons work. Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:23:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:23:51 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-HX13VhsLHa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125273|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128414&action=edit Bug 13188: (follow-up) Get value from PatronSelfRegistrationBorrowerMandatoryField when updating database Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:23:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:23:56 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-wv158q01aO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125274|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128415&action=edit Bug 13188: (QA follow-up) Modernise atomicupdate Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:24:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:24:01 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-ZXzHsDWJIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128409|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128416&action=edit Bug 13188: (RM follow-up) Several fixes on db changes Several issues with the atomic update: - File must to be .pl - File must be executable : chmod a+x - Syspref type is 'free' not 'multiple' Small addition in atomic update: I've added a print of syspref name and value, this can be usefull for upgrade logs. Also a minor issue in installer/data/mysql/mandatory/sysprefs.sql : The description whas different from the atomic update. I choose that atomic update is correct. Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:24:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:24:07 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-m9z4lNocDg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128417&action=edit Bug 13188: Fix alphabetic order in sysprefs.sql As a librarian I had to. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:24:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:24:12 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-MeUFJ1qeD5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128418&action=edit Bug 13188: (QA follow-up) Enhance list of field exclusions It doesn't make sense to allow for fields not visible in the OPAC form to be made mandatory. This patch specifically adds: * opacnote * borrowernotes * sort 1 and sort2 (missing only from Modification) PatronSelfRegistrationBorrowerMandatoryField exclusions: sort1|sort2|opacnote|borrowernotes PatronSelfModificationMandatoryField exclusions: password|cardnumber|dateexpiry|categorycode|sort1|sort2|opacnote|borrowernotes Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:25:34 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-feUtwYUWiw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the lists of exclusions have probably still some room for improvement, but this should be ok for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:42:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:42:56 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-tF6S1IX8ZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can only partially test this, but I have made sure the unit tests pass and I have run through the test plan from bug 27708. No errors in the GUI and none in the logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:43:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:43:27 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-F7KrL7wDSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:43:33 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-4qHYDGkbYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128393|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128419&action=edit Bug 29670: Unit tests This patch adds unit tests for Koha::Edifact::Order->order_line. We now check that the message segments are created as expected for both the 'ordering' and not 'ordering' case for acquisitions item creation time. Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:43:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:43:38 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-ZulpCyvEm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128394|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128420&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. Test plan. 1) Run the newly created unit tests that prove both settings work Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 15:59:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 14:59:28 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-igELtC2nVl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Björn, thx for your patches! Some first things I noticed: 1) QA test tools There are some problems noticed by the QA test tools. It's a good habit to run them yourself before submitting patches to catch these kind of things: FAIL circ/returns.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/atomicupdate/bug_27208-add_delay_util_to_message_queue.pl FAIL file permissions File must have the exec flag FAIL valid Useless use of anonymous hash ({}) in void context FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL forbidden patterns forbidden pattern: console.log (line 1167) 2) Authorship of patches The first 2 patches don't have your authorship: Author: root <root at 9b7442205204> 3) Functionality It looks like this will allow for manually setting a time until the notice will be delayed on the checkin page. I am not sure if this is what Barbara had in mind here as it won't work for self checkins using the web based checkin or the RFID based ones. - And it also might be quite easy to get things confused if you have multiple circulation desks. I wonder if it would not be easier/better to make this a configuration setting, but probably a little harder to do. I am thinking circulation rules, since you might want to differentiate for different branches, but possibly a global setting could also be a good starting point. What do others think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:04:48 +0000 Subject: [Koha-bugs] [Bug 28607] Error: Session timed out. Please log in again In-Reply-To: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28607-70-rLyeNo6nHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28607 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kunal, it is recommended to always use the installation instructions linked in the release notes. For Ubuntu these would be: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages Are you trying to log in from http://23.239.31.27:8080/cgi-bin/koha/admin/authorised_values.pl ? Please try and see if the problem also occurs when you log in from: http://23.239.31.27:8080 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:12:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:12:55 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-QObjMJwCKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It might be nice to build this into the matching rules somehow. If I understand the current rules correclty, we can only check for records matching certain criteria by comparing fields on the incoming record with the existing record, but cannot define a negative rule. I was thinking of something like: existing record doesn't contain: 942$9nomatch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:15:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:15:33 +0000 Subject: [Koha-bugs] [Bug 29675] Can't get to Holds Ratio page In-Reply-To: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29675-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29675-70-B3aq1e7gjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29675 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's neither - it's a known issue with MySQL strict mode. *** This bug has been marked as a duplicate of bug 21941 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:15:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:15:33 +0000 Subject: [Koha-bugs] [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl In-Reply-To: <bug-21941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21941-70-19xjSiLwNn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 29675 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:16:27 +0000 Subject: [Koha-bugs] [Bug 23360] Move reserveratios to a module and refactor to avoid problems with strict mode In-Reply-To: <bug-23360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23360-70-9Q2oQTrDam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23360 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21941 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 16:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 15:16:27 +0000 Subject: [Koha-bugs] [Bug 21941] Incorrect GROUP BY in circ/reserveratios.pl In-Reply-To: <bug-21941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21941-70-6YwDv1Mhj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21941 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23360 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 18:09:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 17:09:00 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-7Z5L3tIwAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Samu, do you want to sign-off on the first 2 patches in combination with yours? Then we could ask Nick to sign-off on yours and move to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 18:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 17:10:52 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15594-70-apyTAGZ7Oe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Blou from comment #4) > Sponsored by: Ville de Saint-Eustache If you add the line as Sponsored-by: to your commit message it will be picked up automatically by the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 18:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 17:17:06 +0000 Subject: [Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records In-Reply-To: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28478-70-YXfN8EVnaB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Fridolin Somers from comment #1) > Arf indeed, code in only in opac-detail.pl : > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > 3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147 > > This needs to be in a module, and if possible with a Koha to MARC mapping > instead of hardcoded 942$n. I think adding a Koha to MARC mapping could be a different bug, also to keep this as easy as possible for backporting. Possibly the code for the check should also be in a routine somewhere? For MARC21 942$n has been established as standard and has a matching index. I am not sure if UNIMARC has a standard mapping at the moment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 20:08:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 19:08:22 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-8U613kjqMx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #21 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Ok, I'll do that. Thx Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 20:27:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 19:27:10 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-Z2pPPsqkjb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127731|0 |1 is obsolete| | --- Comment #22 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Created attachment 128421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128421&action=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch moves the code that we sh9ould run if there is no patron to the head of the biblio loop. If we have no patron we execute this and go to the next loop. A few variables that were being passed to the template in the loop are moved outside - no reason to overwrite each loop To test: 1 - Browse to a bib in the staff client 2 - Click on the holds tab 3 - Note loading time 4 - Add 500 items to bib 5 - Note loading time - it takes longer 6 - Note items are not displayed 7 - Apply patch 8 - Reload page - is much faster 9 - Find/choose a patron 10 - Confirm items are loaded correctly Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 20:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 19:48:17 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-XcDOno00TE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127732|0 |1 is obsolete| | --- Comment #23 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Created attachment 128422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128422&action=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for form name I don't see nay reason we needed this Remove messagetransfert from template Never passed in code Remove totalcount variable Assigned and never referenced Remove 'alreadyres'/'alreadyreserved' from template All references in coide were in template - never set or passed Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 20:50:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 19:50:35 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-Bct7erFZPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128340|0 |1 is obsolete| | --- Comment #24 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Created attachment 128423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128423&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 21:22:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 20:22:16 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-x5EewYmfmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 21:22:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 20:22:19 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-ZQzAPaXT5y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125446|0 |1 is obsolete| | --- Comment #9 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Created attachment 128424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128424&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 12 23:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 22:37:18 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-q8Ni4sx058@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What can we do to help people that have already run into the issue? There was another report on the mailing list from Beda Szukics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 00:28:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 23:28:48 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27613-70-t15le8SwVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 00:28:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 23:28:51 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27613-70-Z13nt3rhQZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128425&action=edit Bug 27613: (follow-up) add authors and contributors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 00:31:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Dec 2021 23:31:41 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber In-Reply-To: <bug-29646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29646-70-ut2lmVTQBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad or repeated |Bad or repeated |opac-password-recovery |opac-password-recovery |attempt crashes on wrong |attempt crashes on wrong |borrower_number |borrowernumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 06:44:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 05:44:24 +0000 Subject: [Koha-bugs] [Bug 29683] New: Samba4 AD DC integration with koha ldap Message-ID: <bug-29683-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29683 Bug ID: 29683 Summary: Samba4 AD DC integration with koha ldap Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: iamalon1434 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Hello, I have installed koha 20.11 and samba4 AD DC and enabled LDAP server in koha-conf.xml, when I am trying to log in on opac getting the following error : LDAP search failed to return object : 00002020: Operation unavailable without authentication at /usr/share/test_koha/lib/C4/Auth_with_ldap.pm line 102. when I try to search via terminal using ldapsearch query it's working fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 08:04:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 07:04:38 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29678-70-5y49HpDSPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Bug 12758 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 08:09:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 07:09:53 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-1Wp9UUGLbA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 08:09:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 07:09:56 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-SJtqEr0bZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #8 from Andreas Roussos <a.roussos at dataly.gr> --- Created attachment 128426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128426&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 08:12:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 07:12:01 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-0Afz0zLg8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #9 from Andreas Roussos <a.roussos at dataly.gr> --- (In reply to Jonathan Druart from comment #7) > Hi Andreas, attach a patch here and switch the status back to Needs Signoff. Thanks, Jonathan. Follow-up attached and bug status changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 09:38:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 08:38:34 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-M7ks2X1Qa6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70846|0 |1 is obsolete| | Attachment #128401|0 |1 is obsolete| | --- Comment #18 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128427&action=edit Add syspref to remove overdues notification by email to staff if user has no email address I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run updatedabatase.pl 11. Change syspref 'EmailOverduesNoEmail' to "Don't send" 12. Delete data from message_queue (if you have access) for a cleaner view 13. Run again misc/cronjobs/overdue_notices.pl 14. Check that only the print message is now generated and not the "Overdue Notices" one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 09:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 08:41:36 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-xM6QNLeSIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- (In reply to David Nind from comment #17) > Patch no longer applies 8-(... > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 20076: Overdues: remove redundant message when patrons don't > have email addresses > Using index info to reconstruct a base tree... > M misc/cronjobs/overdue_notices.pl > Falling back to patching base and 3-way merge... > Auto-merging misc/cronjobs/overdue_notices.pl > CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl > error: Failed to merge in the changes. > Patch failed at 0001 Bug 20076: Overdues: remove redundant message when > patrons don't have email addresses > > Testing notes (using koah-testing-docker): > > * To get notices generated on Tools > Patrons and circulation > Overdue > notice/status triggers I set the rules for all patron types and the default > library to: delay = 1, Letter = Overdue notice, Email = ticked Sorry David I miss up my attachment and some obsolete tag to apply correctly my patch (and also a important step in test plan : updatedabatase.. I'm losing my mind :') ) Now normally everything is going well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 09:42:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 08:42:41 +0000 Subject: [Koha-bugs] [Bug 20074] Auth_subfield_structure changes hidden attribute In-Reply-To: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20074-70-ffSkbKSfLT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128400|1 |0 is patch| | Attachment #128400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 09:46:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 08:46:23 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-iFfhrWzCdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #6 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- (In reply to David Nind from comment #5) > Comment on attachment 128378 [details] [review] > Fixed pre-filling of the search form from the "Replace record with > ZR39.50/SRU" (Authority page detail) > > Not sure what I did - obsoleting the patch. Note: I changed the title of the > commit message so it includes the bug number. Okay, thanks for commit title, I'm new on this so I can made some mistakes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:10:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:10:43 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-sJwQambc8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #10) > What can we do to help people that have already run into the issue? There > was another report on the mailing list from Beda Szukics. They should either remove duplicates manually or run the SQL query provided by this patch. But it would be better to get a QA stamp on it before telling people to run it on production installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:24:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:24:14 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-HQGC7vkWFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #7 from David Nind <david at davidnind.com> --- > Okay, thanks for commit title, I'm new on this so I can made some mistakes :) 8-) The QA Team are very helpful in helping out new contributors! Here are the guidelines for commits: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:26:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:26:12 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-NSwyTgcyFN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #20 from David Nind <david at davidnind.com> --- (In reply to Thibaud Guillot from comment #19) > Sorry David I miss up my attachment and some obsolete tag to apply correctly > my patch (and also a important step in test plan : updatedabatase.. I'm > losing my mind :') ) > > Now normally everything is going well No problem! We all have those days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:29:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:29:29 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-yV8LuRjgEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #11 from Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> --- I was testing, and unfortunately on step 8 the unavailable item (i set the damaged status) also shows up togeter with the available items in the results, with the radio button set to 'available'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:37:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:37:59 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-FZNOk5XThm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128090|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128428&action=edit Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 10:38:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 09:38:02 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-rEayA5vUcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128429&action=edit Bug 28481: (QA follow-up) Set date to 23:59:59 This patch changes the fix from adding a day to setting the time to 23:59:59. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:01:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:01:05 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-MYDTeTYsog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:02:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:02:26 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-1g2Pstrm91@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128430&action=edit Bug 23873: Enable capture groups in MarcModificationTemplates This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based MarcModificationTemplate and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:02:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:02:50 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-Z5cX4IlkjG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:02:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:02:56 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-fsqT2gElXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:12:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:12:03 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-bUK3JnIWjh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128430|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128431&action=edit Bug 23873: Enable capture groups in MarcModificationTemplates This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based MarcModificationTemplate and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:14:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:14:05 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-3WVkXzDrJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #11) > (In reply to Katrin Fischer from comment #10) > > What can we do to help people that have already run into the issue? There > > was another report on the mailing list from Beda Szukics. > > They should either remove duplicates manually or run the SQL query provided > by this patch. But it would be better to get a QA stamp on it before telling > people to run it on production installations. There are 3 UNIQUE constraints that could fail, added on bug 15067. This patch covers one. Can you provide the others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:22:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:22:31 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-7lED7MR5Y2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128432&action=edit Bug 23873: Unit tests This patch adds a unit test for capture groups support in Koha::SimpleMARC. Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply teh capture groups fix patch 3) Run the test again, it should now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:22:35 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23873-70-7lRWtLCBZa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128431|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128433&action=edit Bug 23873: Enable capture groups in MarcModificationTemplates This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based MarcModificationTemplate and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:26:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:26:52 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-jwCr1lW0P3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:26:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:26:59 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-iq8Y8w3WOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:28:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:28:00 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-KPTop9EInT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:28:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:28:04 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-XNBO3ylDNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128238|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128434&action=edit Bug 29631: Prevent uniq_lang creation to fail We got 2 reports of this problem in the last 24h, uniq_lang unique key is failing to be created because several rows with the same (subtag, type) exist in DB. I have no idea how this is possible, but apparently it is. Test plan: Checkout a commit before 21.06.00.012 reset_all Create duplicate in language_subtag_registry > insert into language_subtag_registry(subtag, type, description) values('IN', 'region', 'India'); Checkout master+this patch, updatedatabase => Only 1 IN-region exists in the DB, the last one. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:28:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:28:09 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-hwwO1ekDmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128435&action=edit Bug 29631: (QA follow-up) Add missing cleanups Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:30:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:30:49 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-Xcjz4dteud@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I ran the original INSERTs (on the three tables) several times before running the db_rev, and it made the original patch fail (of course). My follow-up covers that. It still feels we should add: - FK constraints between this tables - UNIQUE to language_script_mapping - UNIQUE to language_script_bidi Those, on a separate bug of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:33:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:33:54 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-8kmWYayMm1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Martin Renvoize from comment #22) > I was slow to the game here.. adding to the ndiscussion on tiaga, I've used > a few systems that take the approach Julian suggests and never had any real > performance concerns. I quite like the idea of not having to maintain the > structure twice. Wrong bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:40:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:40:26 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too much dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-CxNEl3wutj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Owen, should we remove the .dropdown-header's border-top? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:52:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:52:15 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-gKTSjeL7mt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Do you know when the regression happened? On bug 27526 I have explicitly taken this use case into account so I guess I compared with current master (21.06). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:52:29 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-etX99ghHt5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED Depends on| |27526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:52:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:52:29 +0000 Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl In-Reply-To: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27526-70-g2blvI2YaV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:53:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:53:30 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-OCphfT794L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:53:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:53:34 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-DjFOz3IVG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128436&action=edit Bug 29662: (bug 27526 follow-up) Prefill all subfields if SubfieldsToUseWhenPrefill is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 11:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 10:54:21 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-r41uxuacr1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch removes the code that dealt with that specific case, but it would be good to know when this regression occurred. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:00:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:00:08 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-Bq9P2Y37B4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- After the upgrade: - language_script_mapping.language_subtag is_nullable 0 vs 1 - __PACKAGE__->add_unique_constraint("uniq_code", ["rfc4646_subtag", "iso639_2_code"]); - AdditionalContent.pm => field sizes differences for 'category' and 'content' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:01:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:01:24 +0000 Subject: [Koha-bugs] [Bug 29684] New: Warning File not found: js/locale_data.js Message-ID: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Bug ID: 29684 Summary: Warning File not found: js/locale_data.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Have been seeing this various times, things like: File not found : default/js/locale_data.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. File not found : ArticleRequestsDisclaimerText_en/js/locale_data.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. Obviously these are not languages. Default might be a notice language?? And the Disclaimer is a html customization. Still need to find a way to reproduce. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:05:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:05:26 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-Gvu3t6loDb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Nind from comment #19) > Created attachment 128314 [details] > Bug 29605 - Error when accessing staff interface and OPAC > > I haven't signed off because when I try to go into the staff interface or > the OPAC I get errors (after flush_memcached and restart_all) - see the > attached error trace. This is because reset_all (on the 21.05 branch) called cp_debian_files.pl which copied 'old' koha-* scripts and tools which don't acknowledge the location of CGI/Session/Serialize/yamlxs.pm To solve it, you should run: $ cd /kohadevbox/misc4dev $ perl cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:07:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:07:28 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-BFLPqsZqzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- For information, I had a try at removing GetItemsInfo from detail.pl on bug 27272. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:07:50 +0000 Subject: [Koha-bugs] [Bug 26587] detail.pl is very slow for records with many items In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-x7r40D98E7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:07:50 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27272-70-CuQtfPiJXD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26587 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:08:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:08:43 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-krgA1MpegU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|detail.pl is very slow for |Cache libraries in Branches |records with many items |TT plugin to improve | |performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:14:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:14:05 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-Pu5OD21oVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Ok. This is ready to go IMHO. The only missing bit is the updated DBIC files, which make sense and should be done by the RM on pushing, so we are good. New revisited test plan: % git checkout -b bug_29605 origin/master % yes|git bz apply 29605 % git checkout v21.05.00 % reset_all % git checkout bug_29605 % updatedatabase # We are going to update the 21.05.00 DB with all the 21.11 dbrevs % perl cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev # Generate the DBIC schema file using the current DB % perl misc/devel/update_dbix_class_files.pl --koha-conf $KOHA_CONF % git commit -a -m"test diff" # commit the changes to help understand % dbic # generate the schema file using kohastructure.sql % git diff => NO relevant changes should be seen in this diff, only comments and date/md5sum must differ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:32 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-BdEWYwUDAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128113|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128437&action=edit Bug 29605: Add missing constraints from bug 15067 This patch fixes a missed update to kohastructure.sql. To test: 1. Checkout prior to bug 15067 (ab270c026be06f08745a14d1aea992877d20f812) would work. 2. Run: $ reset_all 3. Checkout v21.11.00 4. Run: $ updatedatabase $ koha-mysql kohadev > SHOW CREATE TABLE language_subtag_registry; => SUCCESS: There's UNIQUE KEY uniq_lang (subtag, type) 5. Run: > SHOW CREATE TABLE language_descriptions; => SUCCESS: There's UNIQUE KEY uniq_desc (subtag, type, lang) 6. Run: > SHOW CREATE TABLE language_rfc4646_to_iso639; => SUCCESS: There's UNIQUE KEY uniq_code (rfc4646_subtag, iso639_2_code) 7. Replicate a fresh install. Run: $ reset_all 8. Repeat 4, 5 and 6 => FAIL: The UNIQUE constraints are not there! 9. Apply this patch 10. Run: $ reset_all 11. Repeat 8 => SUCCESS: The UNIQUE constraints are there! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:37 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-bCoiZO7ae7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128114|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128438&action=edit Bug 29605: (follow-up) Add language_script_mapping primary key Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:41 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-XNQQ5qW60L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128152|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128439&action=edit Bug 29605: Missing FK on tmp_holdsqueue.borrowernumber (tmp_holdsqueue_ibfk_3) Bad copy paste on the foreign_key_exists condition Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:46 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-CXACqSwGf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128153|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128440&action=edit Bug 29605: account_offsets.type is not null Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:50 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-ZxWdhd80RW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128154|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128441&action=edit Bug 29605: additional_contents.code Added 100 on 210600016, but 20 in kohastructure Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:55 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-2IQTqAjgna@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128155|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128442&action=edit Bug 29605: additional_contents.lang Up to 50 on bug 23797 but bug 24387 switched it back to 25 (bad resolution conflict) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:15:59 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-KQ24cmH2ay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128156|0 |1 is obsolete| | --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128443&action=edit Bug 29605: search_marc_map.marc_type NOT NULL was missing when MODIFY Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:16:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:16:05 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-On9jWpHwm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128157|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128444&action=edit Bug 29605: language_script_mapping.language_subtag cannot be null It's a PK now Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:16:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:16:10 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-yt32P5MkhF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128158|0 |1 is obsolete| | --- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128445&action=edit Bug 29605: branchtransfers.cancellation_reason reason and cancellation_reason was inversed, and the enum values were lower cases Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:16:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:16:42 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-buYr8u7mj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:16:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:16:54 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-tx3UP7oyAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:17:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:17:07 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-z2d0WqQOPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:17:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:17:16 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-wCXYGlupjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:24:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:24:45 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-oazeaCllc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:25:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:25:49 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-uqFfZsIqSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128446&action=edit Bug 26587: Use Koha::Cache::Memory::Lite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:28:14 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-R8R3BVXkpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:28:18 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-TayPbWOnqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128123|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128447&action=edit Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:28:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:28:19 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-j5QV34NKvP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #16) > Maybe we could prefer using Koha::Cache::Memory::Lite like in other places : > https://git.koha-community.org/Koha-community/Koha/src/commit/ > 2e6b5483503e7feb0afc6ef526a675bde767dd8e/Koha/AuthorisedValues.pm#L104 > > In order to avoid having different cache features. I second that and I submitted a patch. I haven't noticed any significant changes in perf between the 2 versions (always 21-22s). Tested using 1000 items with the following script to generate the biblio record: use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my @branchcodes = Koha::Libraries->search->get_column('branchcode'); my $biblio = $builder->build_sample_biblio; for my $i ( 1..1000 ) { say $i; my $branchcode = @branchcodes[int(rand(scalar @branchcodes))]; $builder->build_sample_item({biblionumber => $biblio->biblionumber, homebranch => $branchcode, holdingbranch => $branchcode }); } say "biblionumber=".$biblio->biblionumber; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:28:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:28:23 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-zEFSOXUAXH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128124|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128448&action=edit Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:29:47 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-yiVBVvj25Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Good catch! Trivial fix, working as expected and QA scripts happy. We need a script to catch those in the QA tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:30:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:30:57 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-cStj0mJO3h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #22) > (In reply to Fridolin Somers from comment #16) > > Maybe we could prefer using Koha::Cache::Memory::Lite like in other places : > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > > 2e6b5483503e7feb0afc6ef526a675bde767dd8e/Koha/AuthorisedValues.pm#L104 > > > > In order to avoid having different cache features. > > I second that and I submitted a patch. I haven't noticed any significant > changes in perf between the 2 versions (always 21-22s). vs 25-26s using master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:34:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:34:11 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-Ghw1IdGz2D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:35:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:35:55 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-cO0l6fiZN4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Andrew, does this make sense to you? It does to me but I would prefer to get your feedback on it before flagging it as PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:41:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:41:49 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28782-70-TWLvkgKfmq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Joonas, do you think you will be back at this one soon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:44:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:44:56 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-911T3IuVjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #16 from Manos PETRIDIS <egpetridis at yahoo.com> --- Aren't language_descriptions.id and language_rfc4646_to_iso639.id already referenced anywhere in koha? Shouldn't there be some previous statements, where use is determined (if any) and existing references updated so that they would only point to the IDs that are to remain? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:45:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:45:42 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-kBOmgLRsX8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128358|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128449&action=edit Bug 27801: Fix javascript price calculations This patch ensures we're formatting the price values consistently for the table total and the amount to pay input field. Test plan 1) Add an item to charge at 0.10. 2) Add this same item 8 or 9 times (Do not use the 'quantity') 3) Note that the table total and the 'Amount paid' values do not match 4) Apply the patch and repeat the above steps.. the values should now match. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:46:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:46:24 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-iHZnLBbNR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:49:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:49:50 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-isZq7GqchR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Manos PETRIDIS from comment #16) > Aren't language_descriptions.id and language_rfc4646_to_iso639.id already > referenced anywhere in koha? Shouldn't there be some previous statements, > where use is determined (if any) and existing references updated so that > they would only point to the IDs that are to remain? I did a git grep for language_descriptions and language_rfc4646_to_iso639 and no, couldn't find any references to the ids. They are always queried by subtag, lang and type. Good question, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:58:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:58:14 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-01Cux4hYRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:58:18 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-34u5sb63uM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128272|0 |1 is obsolete| | Attachment #128273|0 |1 is obsolete| | Attachment #128274|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128450&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:58:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:58:21 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-jQy7t9ShsB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128451&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:58:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:58:25 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-Yu2A5dwt47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128452&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 12:58:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 11:58:38 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-LxKkoyq6rK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- In my opinion we should not backport those patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:01:20 +0000 Subject: [Koha-bugs] [Bug 29685] New: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac Message-ID: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Bug ID: 29685 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 24185 made a nice fix for the satff client - we should port this to OPAC too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:03:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:03:39 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-8ryAqgQCsK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:03:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:03:43 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-6bbNki6cZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128428|0 |1 is obsolete| | Attachment #128429|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128453&action=edit Bug 28481: Make 'to' date inclusive. Test Plan: 1) Sell an item 2) Cash up to make the sale historical 3) Search "Older transactions" with both dates being the current date, click "Display" to search 4) Note you get no results 5) Apply the patch 6) You should now see your transaction Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:03:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:03:47 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-cAyziXauYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128454&action=edit Bug 28481: (QA follow-up) Set date to 23:59:59 This patch changes the fix from adding a day to setting the time to 23:59:59. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:04:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:04:40 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-EGiBJwdTW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:04:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:04:43 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-SFMxVhB1l1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128455&action=edit Bug 29685: Reduce item processing by calculating 'items any available' outside of loop See bug 24185, this avoids looping every each item of the record for every item of the record How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. In testing with 100 books I went from ~6.5 seconds to ~3.2 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:16:51 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-ucYZN2oMAc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reports result menu shows |Reports result menu shows |too much dividers |too many dividers Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:17:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:17:21 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-4mv2jGQSlh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #18) > Created attachment 128048 [details] [review] > As an asside, I also update Koha::Patron->can_see_patrons_from to use > Koha::Patron->libraries_where_can_see_patrons internally.. DRY! I would remove this part from the patch. It's not related and I don't think it's correct, it could bring perf regressions for installs with large number of libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:27:32 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-BXQNSYRPEL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:27:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:27:35 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-9dQXGeddH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 128456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128456&action=edit Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:28:37 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-nIq9M1Wbdg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #19) > I have a question.. if you embed a plural on a route.. like 'patrons'.. > should the result be an array with 'null' gaps.. or an array that just > contains valid patrons without gaps? I would not leave gaps for searches. In my understanding we could have a "no accessible" string displayed in place of patron's info (or whatever other entity/object) close to another info you can see. For instance the checkout list for a given biblio record (you can see when/what but not who). I don't really see a use case where we would display a list of patrons with "no accessible" in the result view with links to point to 403's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:28:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:28:58 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-5cT1FLrWVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Can you clarify the situation? What's missing to make it ready for a QA review? I like the idea but don't manage to see how far we are from something done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:31:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:31:06 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-G0VLaNwTSw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 13:38:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 12:38:19 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-jYNHywhV5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #23) > Can you clarify the situation? What's missing to make it ready for a QA > review? I like the idea but don't manage to see how far we are from > something done. I think this is done. But Martin's follow-up was an attempt to think of further enhancements. Particulary, as he passes the $patron object around, we could rely on some implicit caching to calculate the libraries_... stuff once, no matter how many times it will be used. As for the gaps situation, this patch only covers the 'singular' use case, so that's a different bug. I narrowed the implementation to what I needed for bug 29275, and am willing to work on the plural embeds once we agree on the implementation. I also think we shouldn't leave gaps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:08:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:08:19 +0000 Subject: [Koha-bugs] [Bug 29686] New: Adapt OverDrive for new fulfillment API Message-ID: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Bug ID: 29686 Summary: Adapt OverDrive for new fulfillment API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Background: http://developer.overdrive.com/overdrive-api-notices/01-sep-2021-coming-soon-changes-to-overdrive-checkouts-api Basically, once a title is checked out, we need to make a call to get the 'fulfillment' URL The new API endpoint returns a redirect request, but we can also get the URL back and refer the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:13:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:13:39 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-Xm6XmIVeeV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:13:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:13:42 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-IS2C3cDb6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128457&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:13:54 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-HfsgQi9Nri@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:20:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:20:03 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-xYgxrvXsE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:20:08 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-cwHphvTns7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128458&action=edit Bug 28377: (QA follow-up) .js files should use __() As noted by QA, this bug contained uses of _() which is not correct in include .js files [1]. There was another occurence from prior patches (mine :-/) that gets fixed as well. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:20:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:20:47 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-hGvmvSAkSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:20:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:20:51 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-EAjmQV01wS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128253|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128459&action=edit Bug 29040: Remove warning from the itemtype edit view Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. We are expecting "intranet" or "opac", here we sent undef which raises a warning. For no change in behaviour we can send "both" (or whatever different than "intranet" and "opac"). Test plan: Hit /cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK Notice that the warning does no longer appear in the logs with the patch applied. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:21:08 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-F5PDCTDBiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:21:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:21:28 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-zcQEaaplND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fridolin Somers from comment #27) > + alert(_("Your request could not be processed. Check the logs")); > It is in holds.js, shouldn't it use __("foo") ? Thanks for spotting that. I was really lost in the translation arena until you pointed this here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:22:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:22:00 +0000 Subject: [Koha-bugs] [Bug 29687] New: Get rid of a few OPAC warnings Message-ID: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Bug ID: 29687 Summary: Get rid of a few OPAC warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:22:13 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-IwvFsceYV6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29687 CC| |m.de.rooy at rijksmuseum.nl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 [Bug 29687] Get rid of a few OPAC warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:22:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:22:13 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of a few OPAC warnings In-Reply-To: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29687-70-AIwne7Dziz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:22:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:22:41 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of a few OPAC warnings In-Reply-To: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29687-70-j2ru7t3Utc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:22:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:22:49 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of a few OPAC warnings In-Reply-To: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29687-70-z21ydBIZ7b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:24:25 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-naspCRUNoC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Keywords| |rel_21_11_candidate Depends on| |12561 Severity|enhancement |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 [Bug 12561] Remove non-XSLT views -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:24:25 +0000 Subject: [Koha-bugs] [Bug 12561] Remove non-XSLT views In-Reply-To: <bug-12561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12561-70-sf7S71cUR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:29:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:29:10 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of a few OPAC warnings In-Reply-To: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29687-70-fjeCoNfTAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128460&action=edit Bug 29687: Uninitialized warning C4/XSLT line 286 >From plack-opac-error.log: [WARN] Use of uninitialized value $value in concatenation (.) or string at /usr/share/koha/C4/XSLT.pm line 286. Test plan: An opac search triggered the warning. So repeat it without warns. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:29:24 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-Sduqu6XaVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #29) > There was another occurence from prior patches (mine :-/) that gets > fixed as well. Should be on its own bug report if it's in stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:37:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:37:09 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-c6RS8yYzjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128458|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128461&action=edit Bug 28377: (QA follow-up) .js files should use __() As noted by QA, this bug contained uses of _() which is not correct in include .js files [1]. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:37:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:37:50 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-UIsMSovsUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #31) > (In reply to Tomás Cohen Arazi from comment #29) > > There was another occurence from prior patches (mine :-/) that gets > > fixed as well. > > Should be on its own bug report if it's in stable. Right, removed from here, submitting somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:38:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:38:50 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-iiNuHt4IKv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:38:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:38:54 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-qTF7jWqh7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128424|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128462&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:39:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:39:35 +0000 Subject: [Koha-bugs] [Bug 29688] New: Incorrect use of _() in holds.js Message-ID: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Bug ID: 29688 Summary: Incorrect use of _() in holds.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:39:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:39:43 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29688-70-F6ErYhqHgA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29404 Assignee|oleonard at myacpl.org |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:39:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:39:43 +0000 Subject: [Koha-bugs] [Bug 29404] Add infinite scrolling to pickup location dropdowns In-Reply-To: <bug-29404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29404-70-FKzvcSF0rt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 [Bug 29688] Incorrect use of _() in holds.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:41:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:41:56 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29688-70-o336rfjTn9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:42:00 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29688-70-MwXxFCF6gg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128463&action=edit Bug 29688: Incorrect use of _() in holds.js Bug 29404 moved code from request.tt into holds.js, and I didn't know about the _() vs. __(). This patch fixes that. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:42:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:42:18 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29688-70-ivS5YONHGE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:42:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:42:31 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-KSRNskpfvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please correct English: + die "Mandatory \$params->{xsl_syspref} does not provided, called with biblionumber $params->{biblionumber}" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:43:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:43:58 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-kru8dAmquW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 [Bug 29684] Warning File not found: js/locale_data.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:43:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:43:58 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-0OuQ2QdHxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:44:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:44:22 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29454-70-KjxITMhZuX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |In Discussion See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26587 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is a duplicate of bug 26587. However I think the approach there is better (use of Koha::Cache::Memory::Lite), but it only deals with 'Branches'. If you agree with using the L1 cache, could you add your QA stamp there and provide a patch here for itemtypes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:44:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:44:22 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-hdNnKHzVtP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29454 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:54:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:54:59 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-QpBMPn2tbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm happy for this to progress without my final patch... but I would love to see it moved to another bug for the next round of performance enhancements and code cleaning. I think the following statement still needs some action though: However, currently, there is one test failing and I couldn't grok how to fix it: `t/db_dependent/api/v1/patrons.t` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:56:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:56:03 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-mE7XwujsWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial small fix, waiting for 2 months ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 14:57:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 13:57:20 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-Io98GNhz2d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Makes sense to me! Thanks, all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:05:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:05:59 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-9W5QzuwG1c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:06:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:06:04 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-aXHWqcnPNE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128411|0 |1 is obsolete| | Attachment #128412|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128464&action=edit Bug 28855: Purging suggestions test should not be on timestamp DelSuggestionsOlderThan is on "date", a timestamp. It can be a problem because "date" is updated when we update the database, in consequences all the suggestions take the same date. This patch use 'manageddate' instead. In order to test this patch, you will need to have some suggestions where "Managed on" (suggestions.manageddate in the database) is older from "Last updated" (suggestions.date in the database). This can append during some specific update. If you don't have such data, you will have to add them via SQL request. Example of sql for insertion (ID is the patron id of a librarian which can manage suggestions): INSERT INTO suggestions (suggestedby, suggesteddate, managedby, manageddate, acceptedby, accepteddate, STATUS, title) VALUES (1, '2020-10-13', 1, '2020-10-26', 1, '2020-10-26', 'ACCEPTED', 'title'); Test plan: 1- Choose a date and find (or add) a suggestion where: - "Last updated" is not older than this date - "Managed on" is older than this date - "Status" is different from "Pending" ("ASKED" in database) Calculate number_days = today's date - chosen date Example: (Today's date 28/10/2021, chosen date : 28/10/2020, number_days=365) Suggestion | .. | Managed on | .. | Last updated | .. | Status title | .. | 10/26/2020 | .. | 05/15/2021 | .. | Accepted 2- Run cron job /home/koha/src/misc/cronjobs/purge_suggestions.pl --confirm --days number_days 3- Check that this suggestion has not been deleted 4- Apply the patch 5- Repeat steps 1 and 2 6- Check that this suggestion has been deleted Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:06:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:06:08 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-v3q6X7ZNO2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128465&action=edit Bug 28855: (follow-up) adapt specific test Adapt the test of function DelSuggestionsOlderThan to match the new behaviour of the function. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:09:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:09:57 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-5dn5GtRZ2E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We are loosing the ability to translate syspref's values, is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:11:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:11:15 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-q2ekB5PPyM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:14:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:14:04 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-jeC5djB9pt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:16:58 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-TyYvH6Fhpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:17:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:17:02 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-3V56iErz4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 128466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128466&action=edit Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:20:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:20:06 +0000 Subject: [Koha-bugs] [Bug 28453] Update pagination subroutine to generate Bootstrap markup In-Reply-To: <bug-28453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28453-70-F3cXCjv2L9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28453 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Owen, it seems that you needs to adjust the two occurrences at the OPAC as well: opac/opac-authorities-home.pl: pagination_bar => pagination_bar( opac/opac-shelves.pl: pagination_bar => pagination_bar( opac/opac-shelves.pl: pagination_bar => pagination_bar( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:22:26 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29289-70-w6fcojJX0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- <li id="patron-privacyguarantor"> <li id="patron-privacy_guarantor_fines"> That's inconsistent... Not blocker however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:22:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:22:50 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29289-70-elhFRGsfm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:22:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:22:54 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29289-70-Lf7nmeBjp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127494|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128467&action=edit Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:32 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29491-70-vVrExxKMZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:36 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29491-70-yo36cfGTYZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127775|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128468&action=edit Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:40 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29491-70-0rRxKB4fjY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127776|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128469&action=edit Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:43 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-6DtQEv7gfQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:46 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-t6gUChQUJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127411|0 |1 is obsolete| | Attachment #128446|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128470&action=edit Bug 26587: Cache libraries in Koha/Template/Plugins/Branches.pm to improve performance This patch caches the Koha::Library object in a hashmap in the Branches object (GetName, GetURL) to avoid multiple database lookups while looping many items. To test: 1. Have a biblio with many items (1000's). 2. View in staff (detail.pl) and opac (opac-detail.pl). Note how long it takes to load. 3. Apply patch. 4. Repeat 2. Note that pages load faster. Sponsored-by: Lund University Library JK: replaced tab indendation with spaces Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:31:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:31:51 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-LBFCuAwSNk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128471&action=edit Bug 26587: Use Koha::Cache::Memory::Lite Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:48:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:48:45 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29454-70-Z2hXd6Ycnx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:48:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:48:48 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29454-70-C2sKQeDNuY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127520|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128472&action=edit Bug 29454: Use Koha Cache Memory Lite to stash itemtype descriptions for template plugin To test: 1 - Add 1000 items to a record, of varying item types 2 - Bring up the details page 3 - Note time to load 4 - Apply patch 5 - Reload page and compare to previous 6 - Confirm information is correct 7 - Confirm some performance benefit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:50:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:50:59 +0000 Subject: [Koha-bugs] [Bug 29454] Stash branches and itemtypes in plugin objects to reduce DB calls In-Reply-To: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29454-70-59GQelyDFI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:56:01 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-XYGEhoParD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This method exists, and is C4::Auth::psgi_env And this patch exists, on bug 27555. Why are we duplicating work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:58:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:58:49 +0000 Subject: [Koha-bugs] [Bug 27555] Use psgi_env from errors/* controller scripts In-Reply-To: <bug-27555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27555-70-OfpItBO3sJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 29420 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 15:58:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 14:58:49 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-x10jUoQc89@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 27555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:00:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:00:07 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-WArPIkYe1S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #20) > This all works as expected for me now, no regressions found. Thanks for > finding some time to fit this in David. :) > > I'd love to see a follow-up bug later to use the new function to replace the > various places we look for a psgi/plack app already.. but that can certainly > wait. > > Nice work, signing off. I cannot PQA without a follow-up bug report and patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:04:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:04:31 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-NN6ggzF80F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #18 from Manos PETRIDIS <egpetridis at yahoo.com> --- As mine was one of the installations affected by this bug, I can verify that after running the following statements, web istaller completed successfully. DELETE a FROM language_subtag_registry AS a, language_subtag_registry AS b WHERE a.id < b.id AND a.subtag IS NOT NULL AND a.subtag=b.subtag AND a.type=b.type; DELETE a FROM language_descriptions AS a, language_descriptions AS b WHERE a.id < b.id AND a.subtag IS NOT NULL AND a.subtag=b.subtag AND a.lang IS NOT NULL AND a.lang=b.lang AND a.type=b.type; DELETE a FROM language_rfc4646_to_iso639 AS a, language_rfc4646_to_iso639 AS b WHERE a.id < b.id AND a.rfc4646_subtag IS NOT NULL AND a.rfc4646_subtag=b.rfc4646_subtag AND a.iso639_2_code=b.iso639_2_code; Thank you all for your help in resolving this issue. Manos Petridis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:36:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:36:30 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-wKKirbySC6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Do we move forward with this patch or abandon it? It's now or never. Or with bug 20988, maybe one day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:42:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:42:05 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-sAo0TW208W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:42:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:42:11 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-XrkalKg2lk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128426|0 |1 is obsolete| | --- Comment #10 from Florian <florian.bontemps at biblibre.com> --- Created attachment 128473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128473&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps <florian.bontemps at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:42:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:42:12 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-ZtVUjiuKVm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we should move forward with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 16:42:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 15:42:37 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-tAtsyTvOrd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 17:07:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 16:07:24 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-4umlL6RvVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks Katrin, the yeah, EDI is notoriously difficult to test. I'm really pleased with the unit tests this patch adds personally, I feel like it's a real steel in the right direction for keeping EDI working in future versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 17:07:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 16:07:35 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-nMwkYmrfjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 17:07:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 16:07:38 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-avIuxBjXBj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128421|0 |1 is obsolete| | Attachment #128422|0 |1 is obsolete| | Attachment #128423|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128474&action=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch moves the code that we sh9ould run if there is no patron to the head of the biblio loop. If we have no patron we execute this and go to the next loop. A few variables that were being passed to the template in the loop are moved outside - no reason to overwrite each loop To test: 1 - Browse to a bib in the staff client 2 - Click on the holds tab 3 - Note loading time 4 - Add 500 items to bib 5 - Note loading time - it takes longer 6 - Note items are not displayed 7 - Apply patch 8 - Reload page - is much faster 9 - Find/choose a patron 10 - Confirm items are loaded correctly Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 17:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 16:07:42 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-8gcRT8DSL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128475&action=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for form name I don't see nay reason we needed this Remove messagetransfert from template Never passed in code Remove totalcount variable Assigned and never referenced Remove 'alreadyres'/'alreadyreserved' from template All references in coide were in template - never set or passed Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 17:07:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 16:07:45 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29043-70-xAxQSRRPRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128476&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 18:08:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 17:08:38 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-HH2XXG2VWw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I just tested this feature on 20.11.12 and when adding a suggestion from the detail page the biblionumber is not filled in. I think this is a bug, can you confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 18:28:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 17:28:15 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-TMXXMpuY6I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 18:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 17:28:18 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-sVbdfCX5Od@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128096|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128477&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for displaying the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 18:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 17:28:22 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-g0oIaQy2tr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128478&action=edit Bug 29476: (follow-up) Fix return, add precision test Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 18:30:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 17:30:40 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-jOX4GS3HHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9) > 2. Wondering, should we > return $soonestrenewal if $now < $soonestrenewal; > ? I don't think so There are two cases: with undefined no renewal before: 1 - Automatic renewals wait until it is due 2 - Manual renewals are possible at any time Let me know if I missed something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 19:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 18:23:09 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-79r63mHFOM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 19:23:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 18:23:25 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-L1WqXQuvV2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 19:25:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 18:25:40 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-EUo2AYUgwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #47 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #45) > (In reply to Jonathan Druart from comment #42) > > For instance if we are facing perf issues with the fetch of the circ rules, > > we should then cache them. Other areas would benefit from that kind of > > change. Code will stay clean and we wouldn't need write acrobatic code in > > this C4::Circ module, it does not need that :) > > I've attached a patch on bug 29623, for discussion. I tested that similar to here, I did not se any significant performance change. I then tested here without the last two patches to see how much passing rules and dates save us. It turns out it make the routine take longer. I am not sure how/why, but it seems fetching the values was faster than passing them. I obsoleted the last two patches, as those are the ones you didn't like hopefully we can move this forward ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 19:42:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 18:42:03 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-ajtXXFxTUa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127952|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 19:42:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 18:42:07 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-0Zek4l1aX1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127953|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:00:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:00:32 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-TUOquN4ZRx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:00:38 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-Wjfmz0CzFq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128456|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 128479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128479&action=edit Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:05:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:05:38 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-N0BgIeFUWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127952|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:05:41 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-t4Q06HjMm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:20:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:20:20 +0000 Subject: [Koha-bugs] [Bug 29689] New: Update to 21.11 broken auto-generated barcode in <branchcode>0001 option Message-ID: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Bug ID: 29689 Summary: Update to 21.11 broken auto-generated barcode in <branchcode>0001 option Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jmhenrique at yahoo.com.br QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 128480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128480&action=edit Error in Chrome console Hi! In version 21.05 the automatic barcode generator for manual addition of items worked. When upgrading to 21.11, it stopped working. The chrome debug shows the following message attached To reproduce the error, clicking on the item "p - barcode" generates the error on the console, and does not show any expected results. The autoBarcode option is set to "<branchcode>yymm0001" . Other autoBarcode options work except "<branchcode>aamm0001" . -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:20:53 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-aooFWPMxm6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Henry <jmhenrique at yahoo.com.br> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:23:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:23:56 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-0BhSUscrza@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Henry <jmhenrique at yahoo.com.br> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:25:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:25:09 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-49wImyqNMy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128457|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128481&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:45:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:45:05 +0000 Subject: [Koha-bugs] [Bug 29419] suggest for purchase clears itemtype, quantity, library and reason if bib exists In-Reply-To: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29419-70-YCMWEMeaS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:45:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:45:08 +0000 Subject: [Koha-bugs] [Bug 29419] suggest for purchase clears itemtype, quantity, library and reason if bib exists In-Reply-To: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29419-70-Ya675Z9MIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127684|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128482&action=edit Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 20:46:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 19:46:07 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29419-70-J6lUWOkrCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|suggest for purchase clears |Suggest for purchase clears |itemtype, quantity, library |item type, quantity, |and reason if bib exists |library and reason if bib | |exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:26:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:26:44 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-S7JA5e77aV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #36 from David Nind <david at davidnind.com> --- Created attachment 128483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128483&action=edit Bug 29605 - Error when accessing staff interface and OPAC - 2021-12-14 Still getting an error trace when accessing staff interface and OPAC after flush_memcached and restart_all (see attached). Testing notes (koha-testing-docker): 1. apt-get install libcgi-session-serialize-yaml-perl (comment 16) 2. apt-get install libemail-valid-perl (comment 20) 3. Use updated test plan in comment 26: . for perl cp_debian_files.pl... change to: perl /kohadevbox/misc4dev/cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev 5. As per comment 27 check SQL for steps 4, 5 and 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:46:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:46:09 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-d7DgCo0Blw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:46:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:46:18 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-IPI8TUQPKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:46:31 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-iBDJuzKwAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:46:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:46:39 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-sTB87TgLwy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:46:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:46:49 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-prweNy8uNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:56:18 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-s0fhOQaj9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> --- FYI here is the upgrade doc : https://www.elastic.co/guide/en/elasticsearch/reference/current/setup-upgrade.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:58:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:58:49 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-32GU8iple4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- Actually https://www.elastic.co/fr/support/eol says : 6.8.x EOL on 2022-02-08 If you are in 6 < 6.8, first upgrade to 6.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 21:59:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 20:59:11 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29605-70-yJGKRaVgzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Nind from comment #36) > Created attachment 128483 [details] > Bug 29605 - Error when accessing staff interface and OPAC - 2021-12-14 > > Still getting an error trace when accessing staff interface and OPAC after > flush_memcached and restart_all (see attached). > > Testing notes (koha-testing-docker): > > 1. apt-get install libcgi-session-serialize-yaml-perl (comment 16) > > 2. apt-get install libemail-valid-perl (comment 20) > > 3. Use updated test plan in comment 26: > . for perl cp_debian_files.pl... change to: > perl /kohadevbox/misc4dev/cp_debian_files.pl --koha_dir > /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev And a gentle koha-plack --restart kohadev? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 22:25:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 21:25:05 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-gGOmcEGUsg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > I miss up my attachment and some obsolete tag to apply correctly my patch Don't worry, some tools take a bit long to get used to. And sometimes we just don't know an easier way. For the record, here is how I attach two 2 on a ticket. git-bz attach 20076 HEAD~2..HEAD If it's updating an existing patch. This will mark obsolete the old patches based on commit message matching. If the commit message changed, I manually mark the old patch via the UI. I don't know if git-bz is convenient for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 22:32:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 21:32:02 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-s2c7fSD30f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> --- Ah OK thanks. get_enabled_plugins () is a private method ? maybe rename _get_enabled_plugins() Best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 13 23:50:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 22:50:15 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-eDFKVa0cae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 00:03:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 23:03:01 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-Qs8d6FEKI8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure if .json is parsed by the translation tools, but maybe introducing HTML tags would be worth trying? For the borrowers prefs we use the database column names, so translations weren't needed, but it would be nice if we could make it possible in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 00:05:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 23:05:58 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-Lwau57VE0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tbh this doesn't read like a trivial fix from the number of code changes. I also think we shouldn't hardcode templates, as this breaks the templating system: if ( C4::Context->preference('TranslateNotices') ) { my $translated_languages = - C4::Languages::getTranslatedLanguages( 'opac', - C4::Context->preference('template') ); + C4::Languages::getTranslatedLanguages( 'opac', 'bootstrap' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 00:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 23:12:54 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-cajQbthWOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think one problem is the lack of a test plan apart from running the tests, which limits the people who can test, and that there is no easy to understand description of the issue this is trying to fix. - This makes it harder to test, especially for our non-programmer testers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 00:24:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Dec 2021 23:24:58 +0000 Subject: [Koha-bugs] [Bug 29683] Samba4 AD DC integration with koha ldap In-Reply-To: <bug-29683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29683-70-Exta83LsVw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29683 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, at the moment this looks more like an installation/setup issue and as such is better suited for the mailing list where it will also be read by many more people Bugzilla should only be used for filing bugs, with details on how to reproduce the issue, and enhancement requests. You can also find some information on LDAP configuration in 20.11 in the manual: https://koha-community.org/manual/20.11/en/html/apis_protocols.html#ldap Could your user be the issue? <user>cn=<nameofuser>, dc=<domaincontroller>,dc=<domaincontroller></user> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 02:46:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 01:46:13 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-uB0wjWhswu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 02:46:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 01:46:16 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-hzr1juM90B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:03:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:03:49 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-cIN7kVdZM5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:03:51 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-UXEGKD3kiO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:06:50 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-Cg5hQznzBS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:12:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:12:31 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-0QoPYGGr54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #40 from Fridolin Somers <fridolin.somers at biblibre.com> --- Useful to find who will have no Christmas gifts 🎅 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:12:54 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-ESScqwRNVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:12:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:12:57 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-qIez6q6oTy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #41 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:30:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:30:44 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-0TrbOsIND4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #21) > I think we should move forward with it. +1 I'm sure we already have some code with this technique. I follow french translation group, sure they will like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:37:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:37:51 +0000 Subject: [Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records In-Reply-To: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28478-70-hhYG5W2lsi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #2) > (In reply to Fridolin Somers from comment #1) > > Arf indeed, code in only in opac-detail.pl : > > > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > > 3ba74940ee730e92ad7061f27f18390cc6308364/opac/opac-detail.pl#L147 > > > > This needs to be in a module, and if possible with a Koha to MARC mapping > > instead of hardcoded 942$n. > > I think adding a Koha to MARC mapping could be a different bug, also to keep > this as easy as possible for backporting. > Sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 03:42:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 02:42:10 +0000 Subject: [Koha-bugs] [Bug 28478] MARC detail and ISBD pages still show suppressed records In-Reply-To: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28478-70-h87zBwSmrG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28478 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- Should we add to Koha::Biblio hidden_in_opac() ? Maybe with a param 'context' = 'search' or 'details' ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:19:48 +0000 Subject: [Koha-bugs] [Bug 29690] New: Software error in details.pl when invalid MARCXML Message-ID: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Bug ID: 29690 Summary: Software error in details.pl when invalid MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:20:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:20:01 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-ZuqSYv0720@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:22:53 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-yeZ9yIP980@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:22:53 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-eDYB7SKLeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:24:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:24:49 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-uqflziADbp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:26:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:26:57 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-yswMWtCMek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:27:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:27:01 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-hWQkp32y5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128484&action=edit Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:27:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:27:42 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-PwFRmsAAPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- If we are OK with this implementation, I will amend unit tests (any help is welcome) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:28:14 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-VWPCmoLbS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:28:22 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-4m2JXselmg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:28:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:28:22 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-1EzO09td4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27266 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:29:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:29:48 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-WdRz6El2TD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #64 from Fridolin Somers <fridolin.somers at biblibre.com> --- Please have a look at Bug 29690. We need to catch invalid metadata record so get_marc_authors() is concerned. I'd like QA to confirm this is the correct way to implement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 07:40:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 06:40:32 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-penWacRu1U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Could we not move the eval up a level into the record accessor itself this catching all cases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 08:44:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 07:44:23 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-tcuy5i0qYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Martin Renvoize from comment #3) > Could we not move the eval up a level into the record accessor itself this > catching all cases? OK, we already do and throw an exception.. hence your evals here.. my mistake -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:05:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:05:58 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-zYDQ3G2ggj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #22 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- You are understanding, thank you :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:14:10 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-lUquz2QH3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128484|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128485&action=edit Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:14:13 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-BgH68iCFdL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128486&action=edit Bug 29690: (follow-up) Catch other cases This patch catches the rest of the cases in Koha::Biblio where `->metadata->record` may fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:14:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:14:30 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-Lv2eJuqmEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:17:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:17:46 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-hgbUX4tREm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It looks to me like `opac/opac-ISBDdetail.pl` and `opac/opac-showmarc.pl` are also affected by this.. should we fix those here too.. and perhaps introduce a QA script check for any `->metadata->record` call not wrapped in eval or try/catch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:25:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:25:15 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-nXE7Dcfeb6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:55:22 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-P35lCGAdwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:55:22 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-iCIfP1cAEK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 09:56:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 08:56:58 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-wEaatS22FV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Martin Renvoize from comment #7) > It looks to me like `opac/opac-ISBDdetail.pl` and `opac/opac-showmarc.pl` > are also affected by this.. should we fix those here too.. and perhaps > introduce a QA script check for any `->metadata->record` call not wrapped in > eval or try/catch? Mmm lets focus for this bug on regression in detail.pl. We may open other reports :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:21:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:21:17 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29688-70-P37C6wBp4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Shouldn't we fix all the existing occurrences? background-job-progressbar.js: humanMsg.displayMsg( '<p>' + _('Import of record(s) failed: ') + textStatus + '</p></br>'+xml.responseText, { className: 'humanError' } ); calendar.js: is_date_after: _("Validation error to be shown, i.e. End date must come after start date") checkouts.js: $(selected_option).text(_("%s (current status)").format($(selected_option).text())); datatables.js: var search_title = _("%s search").format(title); holds.js: _("This pickup location is not allowed according to circulation rules") + letter.js: $(sms_counter).html(length + "/" + sms_limit + _(" characters")); onboarding.js:function _(s) { return s; } // dummy function for gettext pages/results.js: div.find(".hint").html(_("Coce image from Amazon.com")); pages/results.js: div.find(".hint").html(_("Coce image from Google Books")); pages/results.js: div.find(".hint").html(_("Coce image from Open Library")); pages/tags-review.js: // window.alert(_("AJAX approved tag: ") + tag); pages/tags-review.js: // window.alert(_("AJAX rejected tag: ") + tag); pages/tags-review.js: $('#test_button').html("<i class='fa fa-check-square-o' aria-hidden='true'></i>" +_(" Test")); pages/tags-review.js: // window.alert(_("Click detected on ") + event.target + ": " + $(event.target).html); rotating-collections.js: if(confirm(_("Are you sure you want to delete this rotating collection?"))){ xmlControlfield.js: alert(_("AJAX error: receiving data from %s").format(settings.url)); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:31:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:31:22 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-7HenjUZ3aF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128487&action=edit Bug 29690: Unit test for get_components_query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:38:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:38:11 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-Gwntb9GEX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- > 1) Create a biblio record with invalid MARCXML (see Bug 29690) Referring to bug 23846? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:43:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:43:07 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-E6rd9vWvuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Should not we at least warn? There is nothing else more frustrating that investigating a problem and find that it's coming from an exception that is being ignored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:46:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:46:42 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-13xTKjpexh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #11) > Should not we at least warn? Probably a good call.. I hate silent failures... do we not already throw a warning from the parent as part of the exception it throws though? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:48:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:48:03 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-0XY0Z4VF2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It would appear not.. so yes, throwing a warning in would be beneficial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:56:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:56:27 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-C9Z3WW6hqI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128488&action=edit Bug 29690: Always warn if something is wrong with the metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:57:19 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-hCdJ55rhzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Would something like this patch work for you, Martin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 10:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 09:59:58 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-Cm3CKPQgCo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Looks great to me Jonathan, thanks for taking it on :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 11:50:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 10:50:52 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-0fmW83xL6z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #8 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Thx for pointing out the qa-tools, will correct the patches. For the functionality, we feel that it's neccessary for staff to be able to set the delay depending on situation, even within the same library. Controling it through circ-rules might be an issue depending on the whether rules are set by holdig or home branch. The processing is obviously done the holding branch but circ rules may be set according the the homebranch? One solution may be to have a syspref eg. PickupNoticeDelayMode that can be set to off|fixed|staff that controls how a delay is set, and a PickupNoticeDelayDuration pref to set the fixed time. Should be fairly straightforward to implement, a fixed duration could be calculated in ModReserveAffect to capture both staff and selfcheck machines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:08:48 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-PzUfgffGmE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28445 Version|21.11 |unspecified CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:08:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:08:48 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28445-70-qQSGFstYcM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:06 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-aI4s4difDG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:06 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-w4tbls9KKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121296|0 |1 is obsolete| | --- Comment #188 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128489&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: David Nind <david at davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:10 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-trFoK3R8Sr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128490&action=edit Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr The selector is not correct, we need to use .input_marceditor instead of name="field_value". Test plan: Set autoBarcode=<branchcode>yymm0001 Catalogue a new item, click into the barcode input Notice that without this patch you get a JS error in the console Uncaught TypeError: form.field_value is undefined Focustag_952_subfield_p_878344 Focustag_952_subfield_p_878344_handler jQuery 11 BindEventstag_952_subfield_p_878344 With this patch applied the barcode is correctly generated. QA Note: it would be way easier if all add item forms were using the new methods, it could be: let loc = document.getElementsByName('items.homebranch')[0].value; Yes, that's all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:13 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-R9CJ5t6VK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121297|0 |1 is obsolete| | --- Comment #189 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128491&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:19 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-pKiEUeDtLq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121298|0 |1 is obsolete| | --- Comment #190 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128492&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:27 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-iOOgISpawF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121299|0 |1 is obsolete| | --- Comment #191 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128493&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:33 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-RHmSEqRkQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121300|0 |1 is obsolete| | --- Comment #192 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128494&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka at gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:40 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-HR0IDepBd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121301|0 |1 is obsolete| | --- Comment #193 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128495&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:14:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:14:47 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-PHO7fubB5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121302|0 |1 is obsolete| | --- Comment #194 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128496&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:18:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:18:04 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-XoI9I0cG8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #1 from Andrew Nugged <nugged at gmail.com> --- it's reproducible on some pages: members/memberentry.pl members/paycollect.pl for example, edit some user: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=1&step=1 This happens because of mass-assignment of keys for template from DB where occasionally template's "lang" value replaced with trashy one. Petro has fix, will publish it. I still can't find direct reproduction for "ArticleRequestsDisclaimerText_en": (somewhere related to tools/additional-contents.pl or Koha::AdditionalContents probably) but that honeypot code added will help further find other paces where such tricks happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:23:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:23:52 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-teh3FbJHJ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:26:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:26:19 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-DFNHb5Cw9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128488|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128497&action=edit Bug 29690: Always warn if something is wrong with the metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:33:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:33:28 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-wGn1802q9E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128489|0 |1 is obsolete| | --- Comment #195 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128498&action=edit Bug 17656: Keep irregularities during subscription renewals When renewing a subscription, irregularities are lost. This patch allows to keep them for daily, weekly and monthly serials (1 unit per issue only). Test plan: - Apply this patch, - Launch installer/data/mysql/updatedatabase.pl - Launch misc/devel/update_dbix_class_files.pl - Create a daily subscription. i.e: - From: 2017-10-09, To: 2017-10-15, - Frequency: 1/day, - 7 issues, - test prediction pattern - check Wednesday and Thursday as irregularity, - save - Edit subscription, - Check that Wednesday and Thursday are still checked - Renew subscription from 2017-10-16 - Edit subscription, - Make sure that Wednesday and Thursday are still checked with corresponding serials - Do the same for a monthly and weekly subscription Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: David Nind <david at davidnind.com> Rebased - 2021-03-04 - Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:33:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:33:35 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-DKbzsrrwON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128491|0 |1 is obsolete| | --- Comment #196 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128499&action=edit Bug 17656: (follow-up) Add missing filters Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:33:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:33:41 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-s647DRCsEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128492|0 |1 is obsolete| | --- Comment #197 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128500&action=edit Bug 17656: [DO NOT PUSH] provide schema file Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:33:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:33:48 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-ggX8BBUFra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128493|0 |1 is obsolete| | --- Comment #198 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128501&action=edit Bug 17656: [DO NOT PUSH] provide css file Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:33:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:33:55 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-0TBKAS5hDk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128494|0 |1 is obsolete| | --- Comment #199 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128502&action=edit Bug 17656: QA warnings fixes Signed-off-by: Amarangi <amarangikarunathilaka at gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:34:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:34:02 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-Aq1SRUmYy1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128495|0 |1 is obsolete| | --- Comment #200 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128503&action=edit Bug 17656: use Koha::Subscription->startdate instead of Koha::Subscriptions Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:34:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:34:09 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-VshgK3yMk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128496|0 |1 is obsolete| | --- Comment #201 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128504&action=edit Bug 17656: More meaningful messages in prediction pattern table Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 12:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 11:36:14 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-POLIfuZdVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 13:10:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 12:10:40 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25408-70-Ix4XxY0ZLh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #62 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 128505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128505&action=edit Bug 25408: (QA follow-up) This rule should not apply when placing a hold from staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 13:13:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 12:13:10 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25408-70-w4CYMQGZFR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #63 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Salut Victor :) Sorry for the late reply... I made a follow-up patch to make sure things won't be changed on the staff interface. Can you retry the patch-set please? Thanks in advance! All the best, Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:02:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:02:36 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-gYSMARVJ0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:14:38 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17656-70-mii6kqCjkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #202 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Patchs rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:29:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:29:03 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-A4YD0XDcYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am going to work on the translatability problem on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:35:41 +0000 Subject: [Koha-bugs] [Bug 29691] New: Use template plugins to display opac news on homepage Message-ID: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Bug ID: 29691 Summary: Use template plugins to display opac news on homepage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently the news for display are fetched in the script, if we move this to the template, bug 28955 will allow displaying branch news by default on home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:36:45 +0000 Subject: [Koha-bugs] [Bug 29692] New: Koha should respect DefaultToLoggedInLibraryCircRules on a single-library system Message-ID: <bug-29692-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29692 Bug ID: 29692 Summary: Koha should respect DefaultToLoggedInLibraryCircRules on a single-library system Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If the system only contains one library, the system preference DefaultToLoggedInLibraryCircRules is not followed. Instead, Koha will always take one to the rules for all libraries. This behavior is not documented on the syspref itself or in the manual. The related sysprefs DefaultToLoggedInLibraryNoticesSlips and DefaultToLoggedInLibraryOverdueTriggers do not behave this way. In a singl-library system, they both continue to apply as stated. This forced and undocumented behavior increases confusion. We should follow the choice on the system preference even if there is only one library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:40:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:40:01 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-VGfDXB29Tz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:40:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:40:04 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-vvmc1iBaj9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128506&action=edit Bug 29691: Use template to display news on opac homepage This patch moves the fetching of news to the template and adds a p[lugin method to get news by id TO test: 1 - Define some general and library specific news items 2 - Define in various languages 3 - Define some 'Additional contents' as well 4 - Apply patch 5 - Confirm onlly 'all libraries' news show if not loigged in to opac 6 - Confirm correct library news show when logged in 7 - View specific news items: http://localhost:8080/cgi-bin/koha/opac-main.pl?news_id=12 8 - Confirm that non-existent ids show " This news item does not exist. " 9 - Confirm if you enter ID for additional contents you get 'does not exist' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:41:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:41:40 +0000 Subject: [Koha-bugs] [Bug 29692] Koha should respect DefaultToLoggedInLibraryCircRules on a single-library system In-Reply-To: <bug-29692-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29692-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29692-70-4co3SCE1K5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29692 --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- To expand a little on why this is an issue, here's what I see frequently: - a single-library system creates all of their rules on the All Libraries page - someone clones those rules to the branch-specific page (either accidentally or in confusion) - time passes, everyone forgets the branch-specific rules are there - someone edits the All Libraries rules to reflect a change in policy - loan behavior doesn't change, because Koha is following the branch-specific rules If we force Koha to always load the All Libraries rules first for a single-library system, we are telling Koha that the first rules it shows us should always be the last rules it enforces. We're explicitly forcing the system to take the more important rules and hide them behind some clicks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:43:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:43:01 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-GAIzUaXYPt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:43:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:43:04 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-ziCtue9R0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126989|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128507&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. To test (on top of bug 29691) 1 - Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "CPL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT CPL" 2 - Restart all 3 - Confirm that news for all and CPL show on opac mainpage 4 - Sign in as a different library 5 - Confirm users library news shows Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:44:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:44:17 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-daWoFNNpLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:51:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:51:47 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-ty3K3jnV11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Henry <jmhenrique at yahoo.com.br> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #2 from Henry <jmhenrique at yahoo.com.br> --- All works, thanks =D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:51:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:51:53 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-rGBFW9tswf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128506|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128508&action=edit Bug 29691: Use template to display news on opac homepage This patch moves the fetching of news to the template and adds a p[lugin method to get news by id TO test: 1 - Define some general and library specific news items 2 - Define in various languages 3 - Define some 'Additional contents' as well 4 - Apply patch 5 - Confirm onlly 'all libraries' news show if not loigged in to opac 6 - Confirm correct library news show when logged in 7 - View specific news items: http://localhost:8080/cgi-bin/koha/opac-main.pl?news_id=12 8 - Confirm that non-existent ids show " This news item does not exist. " 9 - Confirm if you enter ID for additional contents you get 'does not exist' Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:52:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:52:43 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-febCSdckEf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work Nick.. signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:53:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:53:52 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-BMGwxH00GI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm escalating this one a bit as really it's a regression rather than an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:54:11 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-DD1NSC6FX9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 14:54:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 13:54:51 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-0m2hzxLCV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com, | |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:13:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:13:31 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: <bug-27883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27883-70-dtqxhHFwzg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is causing the following warning: [2021/12/14 14:12:13] [WARN] CGI::param called in list context from /kohadevbox/koha/tools/import_borrowers.pl line 94, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:14:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:14:42 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-it1kcgWUKt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch needs to be integrated. Can you signoff on the patch? https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:14:49 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-Zdk4VVMKAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:32:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:32:50 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24857-70-4ReGlz8q0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|In Discussion |Passed QA --- Comment #460 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #459) > A discussion needs to take place on the status of the different bug reports > offering the same or alternative to this patch set. > > Bug 24023 - Add ability to create bundles of items > Bug 20447 - Add support for MARC holdings records > Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items > > It's not clear to me and I won't have time to spend on this huge task before > the release. > Bug 20447 has been part of the roadmap for the 2 last dev cycles and it > would be weird to make this one passed before the "MARC holdings records" if > they conflict with each other. While these patch sets all have similar functions, I don't believe they are contradictory: This bug creates groups for holds functionality, i.e. holds one any of a 'volume' set - it is a logical grouping only Bug 24023/28854 are 'bundles' for circulation purposes Bug 20447 is tied to MARC import/export While there may be some overlap, I think these are discrete enough to operate independently - a library would likely only want to implement either 'groups' or 'holdings' and I believe they can stand alone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:36:43 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-oYYd1pcztB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128126|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128509&action=edit Bug 29588: (bug 29478 follow-up) Make strings translatable "or", "Yesterday", "Today" and "Tomorrow" are not translatable, we are using __ when _ should be used (__ is for .js files only). Test plan: 0. Apply the patch 1. cd misc/translator && perl translate update fr-FR 2. Edit misc/translator/po/fr-FR-staff-prog.po Search for "or", "Yesterday", "Today" and "Tomorrow" and translate them 3. cd misc/translator && perl translate install fr-FR 4. Enable fr-FR (syspref 'language') 5. Edit a patron and an item and confirm that the flatpickr widget has the strings correctly translated Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:37:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:37:18 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-ITXQanK31u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Man.. that's an easy hole to fall into! Works as expected now, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:37:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:37:53 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-QAoQtu6emJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:45:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:45:45 +0000 Subject: [Koha-bugs] [Bug 19421] Predue Notices should work like Overdue Notices In-Reply-To: <bug-19421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19421-70-ZO2dM2FT9b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19421 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:49:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:49:46 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24857-70-hxhQLGPyuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #461 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- No discussion but wait for another RM. Ok, if you want, that's a technique... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:52:14 +0000 Subject: [Koha-bugs] [Bug 21452] Items available for hold or loan must have an item type In-Reply-To: <bug-21452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21452-70-eeWisrqerJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21452 Andreas Jonsson <andreas.jonsson at kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:53:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:53:08 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-g8Is8BOEhF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128221|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128510&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:53:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:53:12 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-DLUlDNlZbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128222|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128511&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:53:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:53:15 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-YnWMR0vcta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128512&action=edit Bug 29552: (follow-up) Reverse SCSS declaration order I'm not sure why, but the order matters in this SCSS declaration. If the &:hover is placed below the &:disabled, as it was, then it appears to negate the effect of the &:disabled rule entirely. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:53:33 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-Be8hc0UzXh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 15:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 14:55:33 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-vuDV7e08oL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This works well once I applied my follow-up. Test plan I followed: 1. Update CSS (This is a staff client patch.. so yarn build [no --view=opac]) 2. Follow Davids test plan, but for staff client pages only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:10:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:10:07 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25408-70-gyynDD3ysY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #64 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Oh damn it, I see what you meant by "I can't place a hold at all from Opac". forget the "re-test please", I will re-work things (opac interface) and re-upload a patch. Things are working from staff and ils-di though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:36:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:36:05 +0000 Subject: [Koha-bugs] [Bug 29693] New: CodeMirror broken on additional_contents.tt Message-ID: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Bug ID: 29693 Summary: CodeMirror broken on additional_contents.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: -Go to Tools and open either additional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:36:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:36:18 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-8cC0NrTXti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 [Bug 29113] New "code" field for additional contents is not useful for the end users -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:36:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:36:18 +0000 Subject: [Koha-bugs] [Bug 29113] New "code" field for additional contents is not useful for the end users In-Reply-To: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29113-70-rd0iUIksXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29113 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29693 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 [Bug 29693] CodeMirror broken on additional_contents.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:42:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:42:15 +0000 Subject: [Koha-bugs] [Bug 29694] New: Add preference for setting marc-record system control number and identifier when saving biblio Message-ID: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 Bug ID: 29694 Summary: Add preference for setting marc-record system control number and identifier when saving biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: glasklas at gmail.com QA Contact: testopia at bugs.koha-community.org Add a syspref, "AutoAddSystemControlNumberAndMARCOrgCode". If enabled, when a new biblio is saved, the 001 and 003 fields of the marc record will be set to the koha biblionumber and value of the "MARCOrgCode" syspref respectively. According to the MARC21 standard the old values of 001 and 003 may also be moved to field 035, 010 or 016 as appropriate, but it since this step is more complicated it's perhaps better left to the user to implement some custom solution for this (for example as a to-marc-plugin). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:46:40 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-my4zAn1gAz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:46:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:46:43 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-r58Q78Ktph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128513&action=edit Bug 29693: Make CodeMirror work again To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, you don't see line numbers or syntax highlighting 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. 8. Try 5 and 6 again but with Additional contents (News) instead of HTML customizations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:46:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:46:58 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-3qiX6xN8VW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 16:52:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 15:52:27 +0000 Subject: [Koha-bugs] [Bug 25232] Add ability to skip triggering holds with a given notforloan value In-Reply-To: <bug-25232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25232-70-ASETu42QyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25232 Cheryl <clackman at fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:04:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:04:12 +0000 Subject: [Koha-bugs] [Bug 29695] New: Centralize columns' descriptions Message-ID: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug ID: 29695 Summary: Centralize columns' descriptions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We have columns.def that contains the descriptions for DB columns and some json files that are used for syspref's values selection. 1. We duplicate them 2. columns.def is translatable but json files are not 3. columns.def is a XML file we are parsing with regexs We should have a single and better way to deal with those descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:04:29 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-8limmtq0Kx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29695 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #14) > I am going to work on the translatability problem on a separate bug report. I've opened bug 29695. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 [Bug 29695] Centralize columns' descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:04:29 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-mUHehBEpEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 [Bug 26296] Use new table column selection modal for OPAC suggestion fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:04:48 +0000 Subject: [Koha-bugs] [Bug 25441] Improve columns.def by adding more descriptions In-Reply-To: <bug-25441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25441-70-YA76t3g1nr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25441 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29695 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:04:48 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-OLtwzjpiOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:12:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:12:06 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-OeidMW8023@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:12:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:12:09 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-Mc7OVfolZc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128481|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128514&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:24:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:24:19 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-NA3pV6pKBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:24:23 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-rl5Pi7ObXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128427|0 |1 is obsolete| | --- Comment #23 from David Nind <david at davidnind.com> --- Created attachment 128515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128515&action=edit Add syspref to remove overdues notification by email to staff if user has no email address I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run updatedabatase.pl 11. Change syspref 'EmailOverduesNoEmail' to "Don't send" 12. Delete data from message_queue (if you have access) for a cleaner view 13. Run again misc/cronjobs/overdue_notices.pl 14. Check that only the print message is now generated and not the "Overdue Notices" one. https://bugs.koha-community.org/show_bug.cgi?id=20076 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:29:24 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-7cLfuDDMHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:29:28 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-IyQnJBUfuf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128455|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128516&action=edit Bug 29685: Reduce item processing by calculating 'items any available' outside of loop See bug 24185, this avoids looping every each item of the record for every item of the record How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. In testing with 100 books I went from ~6.5 seconds to ~3.2 seconds Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:32:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:32:57 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29694-70-raDH5TenI4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 --- Comment #1 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128517&action=edit Bug 29694: Add preference for setting 001 and 003 fields on biblio save Add a syspref, "AutoAddSystemControlNumberAndMARCOrgCode". If enabled the 001 and 003 fields of the marc record will be set to the koha biblionumber and value of the "MARCOrgCode" syspref respectively before when saving biblios. To test: 1) Add a new biblio 2) Verify that 001 field is empty 3) Enable AutoAddSystemControlNumberAndMARCOrgCode syspref and make sure MARCOrgCode syspref is set to some value 4) Save biblio again 5) Verify that 001 has been set to the Koha biblio and 003 to the value of MARCOrgCode 6) Run tests in t/db_dependent/Biblio.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:33:02 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29694-70-Jke6A8So0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 --- Comment #2 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128518&action=edit Bug 29694: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:36:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:36:13 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29694-70-0DaH94MSHg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128517|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128519&action=edit Bug 29694: Add preference for setting 001 and 003 fields on biblio save Add a syspref, "AutoAddSystemControlNumberAndMARCOrgCode". If enabled the 001 and 003 fields of the marc record will be set to the koha biblionumber and value of the "MARCOrgCode" syspref respectively before when saving biblios. To test: 1) Add a new biblio 2) Verify that 001 field is empty 3) Enable AutoAddSystemControlNumberAndMARCOrgCode syspref and make sure MARCOrgCode syspref is set to some value 4) Save biblio again 5) Verify that 001 has been set to the Koha biblionumber and 003 to the value of MARCOrgCode 6) Run tests in t/db_dependent/Biblio.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:36:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:36:17 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29694-70-r4VagE1wqg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128518|0 |1 is obsolete| | --- Comment #4 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128520&action=edit Bug 29694: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:37:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:37:21 +0000 Subject: [Koha-bugs] [Bug 29694] Add preference for setting marc-record system control number and identifier when saving biblio In-Reply-To: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29694-70-LU3w5B3Kbr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29694 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:39:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:39:58 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-yDbUyzIXnv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:40:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:40:06 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-6JiWEpJwnM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128490|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128521&action=edit Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr The selector is not correct, we need to use .input_marceditor instead of name="field_value". Test plan: Set autoBarcode=<branchcode>yymm0001 Catalogue a new item, click into the barcode input Notice that without this patch you get a JS error in the console Uncaught TypeError: form.field_value is undefined Focustag_952_subfield_p_878344 Focustag_952_subfield_p_878344_handler jQuery 11 BindEventstag_952_subfield_p_878344 With this patch applied the barcode is correctly generated. QA Note: it would be way easier if all add item forms were using the new methods, it could be: let loc = document.getElementsByName('items.homebranch')[0].value; Yes, that's all! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:41:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:41:00 +0000 Subject: [Koha-bugs] [Bug 27123] Add messages to batch patrons modification In-Reply-To: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27123-70-DJ1pqbvlEV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:41:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:41:38 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25408-70-tAmfKPc3un@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #65 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- (In reply to Arthur Suzuki from comment #64) > Oh damn it, I see what you meant by "I can't place a hold at all from Opac". > forget the "re-test please", I will re-work things (opac interface) and > re-upload a patch. > Things are working from staff and ils-di though. Ok, i got the issue while applying this patch to 20.11, but on master it seems ok, I can place a hold at the record level on a koha-testing-docker. Or maybe it's late here, buzzy day and i'm not sure about anything anymore... I guess another test from another person won't hurt. Best, Arthur Suzuki for BibLibre Support Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:47:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:47:03 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-2o2T91wnfe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:53:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:53:04 +0000 Subject: [Koha-bugs] [Bug 26058] Add ability for AllowHoldsOnPatronsPossessions to be limited by item type, collection code or shelving location In-Reply-To: <bug-26058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26058-70-oMQnvTQCvJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26058 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 17:54:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 16:54:11 +0000 Subject: [Koha-bugs] [Bug 26058] Add ability for AllowHoldsOnPatronsPossessions to be limited by item type, collection code or shelving location In-Reply-To: <bug-26058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26058-70-k3ZuErPoct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26058 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:02:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:02:55 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-guipMUvudk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:02:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:02:59 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-Ujl5hpsmCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128522&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:03 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-42Z9sdfanM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128523&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:07 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-kFXJToVNgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128524&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:11 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-3YFBUaQla2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128525&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:14 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-TZ5ai2UANN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128526&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:18 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-ARXTFq4Ntv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128527&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:03:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:03:22 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-cTY5TfJcjj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128528&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:04:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:04:29 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-099AIEvg7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128527|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128529&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:28:37 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-1MYvEF0M7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128485|0 |1 is obsolete| | --- Comment #18 from David Nind <david at davidnind.com> --- Created attachment 128530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128530&action=edit Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:28:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:28:43 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-U8ey8hnbSw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128486|0 |1 is obsolete| | --- Comment #19 from David Nind <david at davidnind.com> --- Created attachment 128531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128531&action=edit Bug 29690: (follow-up) Catch other cases This patch catches the rest of the cases in Koha::Biblio where `->metadata->record` may fail. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:28:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:28:48 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-eOwovHbXjy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128487|0 |1 is obsolete| | --- Comment #20 from David Nind <david at davidnind.com> --- Created attachment 128532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128532&action=edit Bug 29690: Unit test for get_components_query Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 18:28:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 17:28:57 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-g6fd3y2kDX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128497|0 |1 is obsolete| | --- Comment #21 from David Nind <david at davidnind.com> --- Created attachment 128533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128533&action=edit Bug 29690: Always warn if something is wrong with the metadata Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:17:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:17:55 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-TOGskbirM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Martin Renvoize from comment #9) > Created attachment 128487 [details] [review] > Bug 29690: Unit test for get_components_query Thanks a lot. We need to also impact other unit tests right ? get_coins, is_serial ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:39:20 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19865-70-fbdSiZONq5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:39:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:39:33 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19865-70-FtrBuonhkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:49:31 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-yjPpzLGkD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:49:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:49:34 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-oYmCzHb4Pw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 --- Comment #40 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:49:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:49:37 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-JvTHn0WSMa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 20:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 19:49:39 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-BAPzRE2DRr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 21:14:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 20:14:12 +0000 Subject: [Koha-bugs] [Bug 19421] Predue Notices should work like Overdue Notices In-Reply-To: <bug-19421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19421-70-M7caxtmaGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19421 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 21:41:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 20:41:30 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: <bug-29408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29408-70-PfxqaSGzsJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #25 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. (and if the above comments are followed upon) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 21:41:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 20:41:31 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-HGfn4K92lA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 29408, which changed state. Bug 29408 Summary: The datatables api wrapper is ambiguously named https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 21:41:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 20:41:32 +0000 Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper should allow picking match type at the column level In-Reply-To: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29302-70-Bp6iOWAcHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302 Bug 29302 depends on bug 29408, which changed state. Bug 29408 Summary: The datatables api wrapper is ambiguously named https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 21:49:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 20:49:22 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-omRuSdqLUC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Rebecca Coert <rcoert at arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:00:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:00:31 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-imju91V2bD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #23 from Fridolin Somers <fridolin.somers at biblibre.com> --- I've done some counting for fr-FR : Without patch : > msggrep -K -e '%s' misc/translator/po/fr-FR-staff-prog.po | grep -c ^msgid 1819 With patch : > msggrep -K -e '%s' misc/translator/po/fr-FR-staff-prog.po | grep -c ^msgid 1747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:06:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:06:00 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-CahHbNaOIv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> --- Ah some problems : 1) I get : Template process failed: file error - parse error - about-team.inc line 3-30: unexpected token (-) [% CASE 'manager' -]<span>Release manager</span> Should be : [% CASE 'manager' -%]<span>Release manager</span> 2) I think we must leave koha-tmpl/opac-tmpl/bootstrap/en/modules/text/explodedterms.tt untouched. It is a weird TT usage. See : https://git.koha-community.org/Koha-community/Koha/src/commit/b0767f94d07950e7420deb901b208d131427c535/koha-tmpl/opac-tmpl/bootstrap/en/modules/svc/suggestion.tt#L46 This should maybe use t() calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:08:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:08:51 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6796-70-7DPq6LTaX0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Azucena Aguayo <azucena.aguayo at uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azucena.aguayo at uvu.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:10:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:10:02 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6796-70-p3Xt5U6eD5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Azucena Aguayo <azucena.aguayo at uvu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:16:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:16:31 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-KtBy2nwn0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #25 from Fridolin Somers <fridolin.somers at biblibre.com> --- 3) A few typo of span closing tag (uppercase S) : > git grep '</Span' koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_hold_cancel.inc: <span>Hold on [% biblio_link | $KohaSpan %] for [% patron_link | $KohaSpan %] has successfully been cancelled.</Span> koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc: <span>No results found</Span> koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt: <span>Cleaned</Span> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:21:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:21:25 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-tLbeLmEjHG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> --- 4) We must not impact koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt Its for the CSV export of items search. Maybe we should also use t() here ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 14 23:24:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Dec 2021 22:24:30 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-5Q7SGgkMcn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #27 from Fridolin Somers <fridolin.somers at biblibre.com> --- 5) Changes in intranet-main.tt seems an error ? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt_sec1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 03:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 02:19:29 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-m8BIic2mSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> --- Very useful for repeated tip text : (closed), (uncertain), ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 03:28:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 02:28:02 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-jIPTLQJHWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #29 from Fridolin Somers <fridolin.somers at biblibre.com> --- 6) There is a removal in issues_stats.tt, is this on purpose ? - [% loopfilte.filter | html %] https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt_sec1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 03:32:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 02:32:53 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-5392BAfVRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> --- 7) There is a missing openning <span> : [% ELSIF ( message_loo.approver ) %]No match for user ([% message_loo.approver | html %]). FILTER REQUIRES BORROWERNUMBER (not name).</span> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt_sec1 In fact other lines all have : <strong>Error :</strong> ... Maybe this text can be moved outside of IF loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:29:04 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-o4hIShQ6Oq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128109|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128534&action=edit Bug 29602: Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:29:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:29:37 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-DE7dqNL1m2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- All done, thanks Frido! (In reply to Fridolin Somers from comment #29) > 6) > > There is a removal in issues_stats.tt, is this on purpose ? > - [% loopfilte.filter | html %] > > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/ > issues_stats.tt_sec1 Yes, it's moved up to be part of the string to translate. (In reply to Fridolin Somers from comment #30) > 7) > > There is a missing openning <span> : > [% ELSIF ( message_loo.approver ) %]No match for user ([% > message_loo.approver | html %]). FILTER REQUIRES BORROWERNUMBER (not > name).</span> > > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/ > review.tt_sec1 > > In fact other lines all have : > <strong>Error :</strong> ... > > Maybe this text can be moved outside of IF loop. I fixed the missing span but prefer to not modify the logic here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:34:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:34:06 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-cx0CB0VaMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128534|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128535&action=edit Bug 29602: Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:46:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:46:14 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-AR2uk0YXzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #34) > I just tested this feature on 20.11.12 and when adding a suggestion from the > detail page the biblionumber is not filled in. I think this is a bug, can > you confirm? Confirmed, on master as well. Certainly caused by bug 28941. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:48:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:48:50 +0000 Subject: [Koha-bugs] [Bug 29696] New: "Suggest for purchase" missing biblio link Message-ID: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Bug ID: 29696 Summary: "Suggest for purchase" missing biblio link Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:49:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:49:13 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-pDgWZO0d06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29696 --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #35) > (In reply to Katrin Fischer from comment #34) > > I just tested this feature on 20.11.12 and when adding a suggestion from the > > detail page the biblionumber is not filled in. I think this is a bug, can > > you confirm? > > Confirmed, on master as well. Certainly caused by bug 28941. Opened bug 29696. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 [Bug 29696] "Suggest for purchase" missing biblio link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:49:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:49:13 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-fY5U1FJbEa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:49:47 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-O4wIjebOw4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28941 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941 [Bug 28941] No filtering on suggestion at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:49:47 +0000 Subject: [Koha-bugs] [Bug 28941] No filtering on suggestion at the OPAC In-Reply-To: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28941-70-lAB3EpXF81@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28941 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 [Bug 29696] "Suggest for purchase" missing biblio link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 06:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 05:49:47 +0000 Subject: [Koha-bugs] [Bug 29416] Regression: information from existing bib no longer populating on suggest for purchase In-Reply-To: <bug-29416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29416-70-6D9rRiR0qQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29416 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29696 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:04:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:04:37 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-gnrj3mtVag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:04:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:04:40 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-WAaehQRew8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128536&action=edit Bug 29696: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:04:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:04:44 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-ceib2aqyab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128537&action=edit Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:05:07 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-izsWSVMGW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:10:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:10:30 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-GUSqRQsT9t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:10:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:10:35 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-dCaLxSUcwN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128142|0 |1 is obsolete| | Attachment #128143|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128538&action=edit Bug 26296: Use new table column selection modal for OPAC suggestion fields This patch builds on the change introduced by Bug 22844, changing the selection mode for the OPACSuggestionMandatoryFields and OPACSuggestionUnwantedFields preferences to a modal. This patch includes a database update for converting the format of the saved values in these preferences. Previously the suggestions table fields would be separated by a comma. Now they should be separated by a pipe. To test, apply the patch run the database update. - Go to Administration -> System preferences. - Search for 'OPACSuggestion.' - The input fields for OPACSuggestionUnwantedFields and OPACSuggestionMandatoryFields should appear as "locked" (read-only) inputs. - Clicking either input field should trigger a modal window with checkboxes for each available column in the suggestions table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function. - Test that changes to both preferences are correctly reflected in the OPAC suggestion form. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:10:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:10:40 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-hvrNM7SqIt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128539&action=edit Bug 26296: (follow-up) Make sure title remains mandatory This patch adds a flag to the OPAC preferences file marking suggestion title as mandatory OPACSuggestionMandatoryFields and excluded from OPACSuggestionUnwantedFields. The patch also modifies the markup around required fields in the OPAC suggestion form to comply with changes made in Bug 27668 to mandatory field styling. To test, apply the patch and restart services. - Test the OPACSuggestionMandatoryFields preference. In the modal, "title" should be checked and the label in red. It should not be possible to uncheck the checkbox. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are still saved correctly. - Test the OPACSuggestionUnwantedFields preference. In the modal, "title" should be unchecked and disabled. - Test that the "Select all" and "Clear all" links don't affect the "title" checkbox. - Confirm that your selections are saved correctly. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:11:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:11:05 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-dkqJXjViwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I would suggest to push this one along with bug 29695, to note lose the translatability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:16:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:16:35 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-7h58v2yV5R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Initial step is: turn on UseWYSIWYGinSystemPreferences :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:17:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:17:47 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-0AalMQeqlm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #2) > Initial step is: turn on UseWYSIWYGinSystemPreferences :) Nope, it's AdditionalContentsEditor=text! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:20:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:20:34 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-ipE2DRL1pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #2) > > Initial step is: turn on UseWYSIWYGinSystemPreferences :) > > Nope, it's AdditionalContentsEditor=text! Well, it's second step. I totally forgot about that group button. The syspref does not make sense then. Sorry for the noise! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:22:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:22:32 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-uUiC1xALxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:22:36 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-2kk3KsphxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128513|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128540&action=edit Bug 29693: Make CodeMirror work again To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, you don't see line numbers or syntax highlighting 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. 8. Try 5 and 6 again but with Additional contents (News) instead of HTML customizations Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:23:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:23:02 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-j5iWt3yJCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Trivial fix, skipping QA. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:23:08 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29693-70-bCHIGVdGDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:46:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:46:14 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-Cy0hD4OpSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #34 from Fridolin Somers <fridolin.somers at biblibre.com> --- I confirm 1 to 7 problems are solved. Sorry there are still problems (I've looked at all changes now) : 8) Missing % : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128535&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt_sec1 9) Missing closing tag </span> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128535&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt_sec1 10) viewlog.tt : Why not changing BLOCK translate_log_interface ? 11) opac-authorities.inc in BLOCK authtypelabel : Don't we have <span> inside <span> ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 07:58:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 06:58:25 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-34ORnYDlYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #35 from Fridolin Somers <fridolin.somers at biblibre.com> --- 11) We should not impact koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title-head.inc, it is called in <title> and must be text only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:24:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:24:34 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-rjnEzPttAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128541&action=edit Bug 29690: Add selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:25:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:25:06 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-WUzbgl5xor@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #22) > (In reply to Martin Renvoize from comment #9) > > Created attachment 128487 [details] [review] [review] > > Bug 29690: Unit test for get_components_query > > Thanks a lot. > We need to also impact other unit tests right ? > get_coins, is_serial ... I actually prefer a selenium test, it will catch possible future regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:35:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:35:40 +0000 Subject: [Koha-bugs] [Bug 29697] New: Excessive use of StripNonXmlChars Message-ID: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Bug ID: 29697 Summary: Excessive use of StripNonXmlChars Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We are using C4::Charset::StripNonXmlChars from different places of the code to remove characters that should not be part of the MARC::XML Historically we were removing them every time we were fetching the record. However, since we are starting to use Koha::Biblio::Metadata ($biblio->metadata->record) to retrieve the xml stored in the biblio_metadata table, such characters will not be removed and a degraded view will be displayed on the bibliographic detail page (see bug 23846). We didn't get a lot of complains, and it's part of Koha since 19.05.05. Shouldn't we start to use $biblio->metadata->record where GetMarcBiblio is actually used? Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:36:14 +0000 Subject: [Koha-bugs] [Bug 29697] Excessive use of StripNonXmlChars In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-avOlf93JmF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29307 Depends on| |23846, 29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:36:14 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-j00qFEDfzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Excessive use of StripNonXmlChars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:36:14 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-nec7rQ90l0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Excessive use of StripNonXmlChars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:36:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:36:14 +0000 Subject: [Koha-bugs] [Bug 29307] marc record fetched twice in detail.pl In-Reply-To: <bug-29307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29307-70-56qfZDGSDi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29697 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:36:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:36:31 +0000 Subject: [Koha-bugs] [Bug 29697] Excessive use of StripNonXmlChars In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-DjLASjFS3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:45:37 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-denr8dP2CZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:45:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:45:43 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-tRVLgbGLrv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128535|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128542&action=edit Bug 29602: Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:45:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:45:59 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-TaWyNpml7y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #34) > I confirm 1 to 7 problems are solved. > > Sorry there are still problems (I've looked at all changes now) : > > 8) Missing % : > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=128535&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/ > subscription-frequencies.tt_sec1 Fixed > 9) Missing closing tag </span> > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=128535&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/ > additional-contents.tt_sec1 Fixed > 10) viewlog.tt : > Why not changing BLOCK translate_log_interface ? Done > 11) opac-authorities.inc in BLOCK authtypelabel : > Don't we have <span> inside <span> ? Is that a problem? Nested spans are valid in HTML5. (In reply to Fridolin Somers from comment #35) > 11) > We should not impact > koha-tmpl/intranet-tmpl/prog/en/includes/biblio-title-head.inc, it is called > in <title> and must be text only. Removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:49:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:49:14 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-KFSOKjsDPw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #38 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128543&action=edit Bug 29602: (follow-up) Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:49:56 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-1CjD5Z3QoL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #39 from Fridolin Somers <fridolin.somers at biblibre.com> --- I found some places it will be usful. Only looked at includes by now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:51:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:51:23 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-DiYccNOoJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #40 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #37) > > > 11) opac-authorities.inc in BLOCK authtypelabel : > > Don't we have <span> inside <span> ? > > Is that a problem? Nested spans are valid in HTML5. > Ah OK cool Thanks for the fixes :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:56:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:56:20 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-PpwtZEKVXK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Peter Vashchuk <stalkernoid at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:56:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:56:23 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-Tm7J2Uynxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Peter Vashchuk <stalkernoid at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128373|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid at gmail.com> --- Created attachment 128544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128544&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 08:57:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 07:57:37 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26296-70-m0FXRXkySe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> --- Ah atomic update script needs to be updated to match new DBRev system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:00:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:00:40 +0000 Subject: [Koha-bugs] [Bug 28708] fr-CA localization file In-Reply-To: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28708-70-jbzLKGaRTw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Sorry Caroline, I haven't seen this one before. IMO the localization should not include your own (or company) preferences. See bellow. +UPDATE systempreferences SET value = 'fre|eng' WHERE variable = 'AdvancedSearchLanguages'; +UPDATE systempreferences SET value = 'CA' WHERE variable = 'AmazonLocale'; +UPDATE systempreferences SET value = 'père|mère|grand-parent|tuteur légal|autre' WHERE variable = 'borrowerRelationship'; +UPDATE systempreferences SET value = 'M.|Mme|Mx' WHERE variable = 'BorrowersTitles'; ok +UPDATE systempreferences SET value = 365 WHERE variable = 'ConfirmFutureHolds'; nok +UPDATE systempreferences SET value = 'FR' WHERE variable = 'CurencyFormat'; +UPDATE systempreferences SET value = 'iso' WHERE variable = 'dateformat'; ok +UPDATE systempreferences SET value = 1 where variable ='FilterBeforeOverdueReport'; +UPDATE systempreferences SET value = 'production' WHERE variable = 'finesMode'; +UPDATE systempreferences SET value = 365 WHERE variable = 'HoldsToPullStartDate'; nok +UPDATE systempreferences SET value = 'fr' WHERE variable = 'KohaManualLanguage'; +UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'language'; +UPDATE systempreferences SET value = 'http://www.marc21.ca/MaJ/BIB/B{FIELD}.pdf' WHERE variable = 'MarcFieldDocURL'; +UPDATE systempreferences SET value = 'pdfformat::layout3pagesfr' WHERE variable = 'OrderPdfFormat'; +UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'OPACLanguages'; ok +UPDATE systempreferences SET value = 0 WHERE variable = 'OpacAllowPublicListCreation'; +UPDATE systempreferences SET value = 1 WHERE variable = 'opaclanguagesdisplay'; +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav'; +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom'; +UPDATE systempreferences SET value = 1 WHERE variable = 'OpacSuppression'; nok +UPDATE systempreferences SET value = '0|0.05|0.09975|0.14975' WHERE variable = 'TaxRates'; ok +UPDATE systempreferences SET value = 1 WHERE variable = 'useDefaultReplacementCost'; nok Does it make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:06:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:06:06 +0000 Subject: [Koha-bugs] [Bug 27481] Use Modern::Perl in cataloguing unimarc plugins In-Reply-To: <bug-27481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27481-70-2iefz7JybL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27481 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch is not doing what it is advertising. We should use Modern::Perl, not removing a line that is commented-out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:07:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:07:12 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-crRbD2vQ4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Martin, did you see my comment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:12:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:12:27 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-qdhaVyXRmN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:12:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:12:31 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-LOnjKcWX03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128544|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128545&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:38:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:38:29 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-mEX1ApwHSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This patch is required for the conversion of digest notices to TT.. it would be really beneficial to see it moving again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:47:46 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-k4DmXV2RVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #25 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #24) > (In reply to Fridolin Somers from comment #22) > > (In reply to Martin Renvoize from comment #9) > > > Created attachment 128487 [details] [review] [review] [review] > > > Bug 29690: Unit test for get_components_query > > > > Thanks a lot. > > We need to also impact other unit tests right ? > > get_coins, is_serial ... > > I actually prefer a selenium test, it will catch possible future regressions. Super giga. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:49:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:49:57 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-XAPN4DnB7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123106|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128546&action=edit Bug 19966: Add ability to pass objects directly to slips and notices Koha spends an incredible amount of time on parsing and processing parameters passed in to slips and notices. It would be immensely more efficient to be able to pass objects directly to GetPreparedLetter so it doesn't need to do any fetching / processing on them. Test plan: 1) Apply this patch 2) prove t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:50:56 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-48kIy7wIgl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Really glad this bug got split up.. it's now a simple QA. Everything works as described and causes no obvious regressions. QA Script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:51:03 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-njZLzirkbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 09:52:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 08:52:14 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-ukmfSbs6Ur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I did, but I haven't had a moment to come back to work on this again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:09:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:09:20 +0000 Subject: [Koha-bugs] [Bug 29698] New: items are not available for TT syntax for PREDUEDGST Message-ID: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698 Bug ID: 29698 Summary: items are not available for TT syntax for PREDUEDGST Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:12:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:12:15 +0000 Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29698-70-jMt1FNxN5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128547&action=edit Bug 29698: Make items available for PREDUEDGST With this patch you can access items using: Number of items [% items.count %] [% FOR i IN items %] [% SET checkout = i.checkout %] Item [% i.itemnumber %] is due on [% checkout.date_due | $KohaDates %] [% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:13:32 +0000 Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29698-70-24m9ir3p0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- It should work for DUEDGST as well but I haven't tested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:13:48 +0000 Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29698-70-wrk09TKSz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:13:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:13:55 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-qjvFNBbdSZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The same issue is present with HIGHHOLDS then right.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:20:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:20:09 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29516-70-b2QUsK64RG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:20:13 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29516-70-bvWZJ3QmHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127785|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128548&action=edit Bug 29516: Remove dependency on IO::Scalar IO::Scalar is used in Koha::App::Plugin::CGIBinKoha to create a filehandle tied to a scalar. Perl has this feature built in since 5.8.0 so IO::Scalar is not needed I'm not sure how to test this, since it should behave exactly the same with or without the patch, but we can at least verify that it doesn't introduce encoding issues. Test plan: 1. Run `morbo bin/intranet` 2. Go to http://localhost:3000 3. Create a bibliographic record with some non-latin characters (try emoji characters for instance). Verify that there is no visible encoding issues. 4. Save this record as MARCXML and re-import it as a new record using Tools » Stage MARC records for import. Verify that the new record has no visible encoding issues 5. `git grep IO::Scalar` should not return any result Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:20:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:20:27 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29516-70-DQ5fgyo7om@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:21:53 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-azdk1Z0ifM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127926|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128549&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:21:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:21:57 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-S9aSms4YWf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128550&action=edit Bug 29504: (follow-up) Account for other blockers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:22:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:22:35 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-f6a538eUYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My attempt at a fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:22:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:22:40 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29504-70-J2nM5P0RPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My attempt at a fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:28:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:28:57 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-TyNsW0JMWS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Julian, I am not sure, you are bypassing Koha::Plugin::Base->retrieve_data that is used in other places. As we are actually looking at caching the result, why not keep the usual way to retrieve the enabled plugins then cache them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:29:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:29:22 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-3jjbPPdFGw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #8) > Ah OK thanks. > > get_enabled_plugins () is a private method ? maybe rename > _get_enabled_plugins() > > Best regards, It's a class method, like all other methods from this module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:36:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:36:11 +0000 Subject: [Koha-bugs] [Bug 29698] items are not available for TT syntax for PREDUEDGST In-Reply-To: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29698-70-MMENCM0i5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29698 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:36:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:36:41 +0000 Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19966-70-NcG3MgZz5c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What are the next steps then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:41:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:41:52 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-Jc6hrrY8YJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart+koha at gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- error: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). You shouldn't need to reorder kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:42:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:42:51 +0000 Subject: [Koha-bugs] [Bug 29668] Add API route to create a basket In-Reply-To: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29668-70-j64rCuWbx8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29668 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:45:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:45:56 +0000 Subject: [Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling In-Reply-To: <bug-25078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25078-70-3j4deYIJok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27880 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27880 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 [Bug 27880] Store each database migrations state in database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:45:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:45:56 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27880-70-llIQPZwktm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25078 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25078 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:46:04 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: <bug-14698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14698-70-conVYQ6rK3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** This bug has been marked as a duplicate of bug 27880 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:46:04 +0000 Subject: [Koha-bugs] [Bug 27880] Store each database migrations state in database In-Reply-To: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27880-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27880-70-EEcX0HMp7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27880 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 14698 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:46:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:46:04 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15654-70-zQSbJXfIHN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Bug 15654 depends on bug 14698, which changed state. Bug 14698 Summary: AtomicUpdater - Keeps track of which updates have been applied to a database https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:47:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:47:45 +0000 Subject: [Koha-bugs] [Bug 25951] Koha::Objects using the DBIx::Class relationships in Koha::Hold and Koha::Item In-Reply-To: <bug-25951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25951-70-Y15Wjg20PF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Failing QA regarding last comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:50:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:50:09 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29480-70-aJXvFLT72O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:50:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:50:32 +0000 Subject: [Koha-bugs] [Bug 29480] Add email address as a method for generating the userid when self registering in OPAC In-Reply-To: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29480-70-1cgSiz4hni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- You also need to rename 'borrower' with 'patron'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 10:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 09:56:18 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-XQ5EPNSxpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Shouldn't we store it as a user's setting in local storage instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:00:30 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28876-70-KkgoFOleXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:00:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:00:34 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28876-70-BTAwaNtWdi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125900|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128551&action=edit Bug 28876: Wrap no renewal before advisory text in selector This patch adds some more <span>s to the user summary page in the OPAC so that information about renewal status can be targeted with CSS or JS. It adds each <span> with a "usr-msg" class for general styling and a specific class for each renewal message, e.g. <span class="usr-msg no-renew-hold">Not renewable <span class="renewals">(on hold)</span></span> These classes are added: - no-renew-hold - Not renewable (on hold) - no-renew-too-many - Not renewable (too many renwals) - no-renew-unseen - Item must be renewed at the library - no-renew-overdue - Not allowed (overdue) - no-renew-too-late - No longer renewable - auto-renew-fines - Automatic renewal failed, you have unpaid fines - auto-renew-expired - Automatic renewal failed, your account is expired - no-renewal-before - No renewal before [date] - automatic-renewal - Automatic renewal To test, apply the patch and try to locate or set up a patron to have multiple checkouts with multiple renewal conditions: - On hold - Too many renewals - Overdues (if OverduesBlockRenewing is on) ...etc. In the OPAC, log in and view the table of checkouts on the "your summary" page. Confirm that messages in the "Renew" column are marked up correctly. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> JD amended patch: fix commit title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:01:06 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28876-70-W69NU8yibM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:19:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:19:41 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-3GENFtTUcY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Note that we could reuse this to remove the different includes/csv_headers files. We are generating the CSVs using TT to make the headers translatable, but it would be better to generate them using Text::CSV. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:25:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:25:27 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-2VIkXVUcEY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Joubu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:32:00 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-MZxjPyjvL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:32:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:32:04 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-vwrZgt6YcW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128477|0 |1 is obsolete| | Attachment #128478|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128552&action=edit Bug 29476: Correct soonest renewal date calculation for checkouts with auto-renewal If a checkout with auto-renewal enabled doesn't have a "norenewalbefore" circulation rule set the code in CanBookBeRenewed() falls back to using due date (to verify this please look for the string "auto_too_soon" in C4/Circulation.pm), the calculation result of GetSoonestRenewDate() however didn't do this, though luckily it was not used in CanBookBeRenewed so we didn't get any issues there. However, GetSoonestRenewDate() is used for displaying the soonest renewal date in the staff interface on the circ/renew.pl page so you would have gotten wrong results there. This patch moves additionally the tests made for Bug 14395 under a new subtest for GetSoonestRenewDate() as they should have been like that already before. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:32:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:32:09 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-U9Nr9EbCxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128553&action=edit Bug 29476: (follow-up) Fix return, add precision test Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:36:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:36:30 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-EW9u9nd6TF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:36:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:36:34 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-ensP9mj6O5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127949|0 |1 is obsolete| | Attachment #127950|0 |1 is obsolete| | Attachment #127951|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128554&action=edit Bug 29474: Return too_soon before checking renewals This patch allows us to avoid checking reserves when the issue is too_soon and we are running the cron Code is covered by existing tests To test: 1 - prove -v t/db_dependent/Circulation.t Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:36:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:36:38 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-KbP6OEg3IU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128555&action=edit Bug 29474: Decouple renewal checks of auto-renewed issues from non-autorenewed The too_soon check does not relate at all to auto-renewed issues and should be moved outside the _CanBookBeAutoRenewed() function. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:36:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:36:43 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29474-70-luTWV33M7U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128556&action=edit Bug 29474: Remove one layer of indendation by adding if check in the begginning If we simply return "no" immediately from the function when the checkout is not an autorenewed checkout we can drop one layer of indendation and the code becomes much easier to read. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:38:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:38:36 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29537-70-ZjSiejr0wS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Patch doesn't apply --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- No longer apply correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:42:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:42:55 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-uDTIaAT9PR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:44:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:44:42 +0000 Subject: [Koha-bugs] [Bug 28708] fr-CA localization file In-Reply-To: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28708-70-uScH0o0S0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think these would be ok: +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav'; +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom'; The default is in English - I think in the German file some have been translated but setting them to empty is valid too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:44:43 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29591-70-17p1N1P2GP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29695 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Note that I am suggesting to remove borrowers.json on bug 29695. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:44:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:44:43 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-FLJK3vPgHK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:47:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:47:05 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15067-70-Y9o5zmr8tv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 MD NAZRUL ISLAM <nazrul.it.puc at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nazrul.it.puc at gmail.com --- Comment #36 from MD NAZRUL ISLAM <nazrul.it.puc at gmail.com> --- Upgrade to 21.06.00.012 [16:41:31]: Bug 15067 - Add missing languages ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:54:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:54:46 +0000 Subject: [Koha-bugs] [Bug 28708] fr-CA localization file In-Reply-To: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28708-70-WVK5B7XIpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28708 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #3) > I think these would be ok: > > +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNav'; > +UPDATE systempreferences SET value = '' WHERE variable = 'OpacNavBottom'; > > The default is in English - I think in the German file some have been > translated but setting them to empty is valid too. Those 2 have been removed anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:56:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:56:18 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15067-70-zSCdJ5wsWb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to MD NAZRUL ISLAM from comment #36) > Upgrade to 21.06.00.012 [16:41:31]: Bug 15067 - Add missing languages > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry > 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line > 738 See bug 29631. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 11:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 10:58:33 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-vkDCWFXKL8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We should have actually cached in L1 instead of passing the result around. That would have fix all the different occurrences (luckily there are only 2 of them). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 12:00:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 11:00:33 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-ce9LcBQrgv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 12:00:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 11:00:37 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29685-70-eOSJs09HcL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128516|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128557&action=edit Bug 29685: Reduce item processing by calculating 'items any available' outside of loop See bug 24185, this avoids looping every each item of the record for every item of the record How to reproduce: 1) on freshly installed kohadevbox create/import one book, remember that biblionumber for later use it in down below, 2) add 100 items for that book for some library, 3) find some patron, that patron's card number we will use as a borrower down below to open holds page, 4) check for the rule or set up a single circulation rule in admin "/cgi-bin/koha/admin/smart-rules.pl", that rule should match above book items/library/patron, check that rule to have a non-zero number of holds (total, daily, count) allowed, and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable", ("item level holds" doesn't matter). 5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page ("holds" tab), and enter patron code in the search field, or you can create a direct link by yourself, for example, in my case it was: /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353 6) it should be pretty long page generation time on old code, densely increasing for every hundred items added. In the case of this solution, it's fast, and time increases a little only, linear. In testing with 100 books I went from ~6.5 seconds to ~3.2 seconds Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:14:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:14:02 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29591-70-hX022sKvGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:14:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:14:05 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29591-70-8wvKH1nEZc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128081|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128558&action=edit Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:19:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:19:49 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29591-70-n1QyRy9kTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > Note that I am suggesting to remove borrowers.json on bug 29695. Thats great. But no reason to skip this patch. This works and can be backported as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:36:04 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-vmLwrZ0JtQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #10 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- I reproduced the same behavior than OPAC side and from the discussion it coincided with the integration of a system preference. If we put this parameter in the localstorage could problems arise? Like using a browser that is set to not store anything in the localstorage or simply the library that would prefer not to store anything there. I am not against it but I question to raise possible problems with its storage. Especially since the system preference allows not to highlight certain words. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:15 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-lyt0mzTuau@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128522|0 |1 is obsolete| | Attachment #128523|0 |1 is obsolete| | Attachment #128524|0 |1 is obsolete| | Attachment #128525|0 |1 is obsolete| | Attachment #128526|0 |1 is obsolete| | Attachment #128528|0 |1 is obsolete| | Attachment #128529|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128559&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:19 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-WTZLIlaWNI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128560&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:23 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-NXRLavS8zv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128561&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:27 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-ieh5cR4Nnv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128562&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:31 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-bzVXHMrRNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128563&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:35 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-DyhDMZiFb7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128564&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:39 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-dFnxD8V4as@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128565&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:44 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29591-70-X6bICfBFkb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29695 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Marcel de Rooy from comment #5) > (In reply to Jonathan Druart from comment #3) > > Note that I am suggesting to remove borrowers.json on bug 29695. > > Thats great. But no reason to skip this patch. This works and can be > backported as well. Of course, it was just something I wanted to highlight here. I have rebased the patches on top of this one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 [Bug 29695] Centralize columns' descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:42:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:42:44 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29695-70-HWMuD4UTAK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 13:53:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 12:53:49 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-qSDPBwVnia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- In my opinion sysprefs should not drive UI's preferences. We are using local storage for several features already so that should not be a problem. See bug 5697 for instance, that have been pushed recently, or bug 24958. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:00:39 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-1BFGQQA4yo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Andrew Nugged from comment #1) > Petro has fix, will publish it. Great ! > I still can't find direct reproduction for > "ArticleRequestsDisclaimerText_en": > (somewhere related to tools/additional-contents.pl or > Koha::AdditionalContents probably) but that honeypot code added will help > further find other paces where such tricks happen. Yeah couldnt find it at first try. Note that additional_contents has a column *lang*. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:01:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:01:52 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-Zu1D209v6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- I think that the existence of OpacHighlightedWords makes it logical to add a preference for the staff interface. I agree that the "stopwords" option is important to have. I think it might also be good to preserve the user's highlight/unhighlight choice in local storage so that it is preserved across their session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:08:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:08:36 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-sn6w9wkBMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:08:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:08:40 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-1tW9txuPUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128545|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128566&action=edit Bug 29669: fix uninitialized value warnings when XSLTParse4Display is called Wrong key 'xsl_filename' is present in opac-tags.pl and shelves.pl (the only places where it is used in the code even) instead of 'xsl_syspref' that is actually used and this is the cause of those warnings. Also added honeypot to check if other calls in same way happens. Honeypot probably not needed, review when QA in the Community. To reproduce (shelves.pl): 1) Prepare some test list with items or use existing one. 2) Go to the lists page (koha/virtualshelves/shelves.pl), notice multitude of new warnings in the "intranet-error.log" log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Go back to same page and check it again, warns like that should not appear in the log file anymore. To reproduce (opac-tags.pl): 1) Go to the "my tags" page in OPAC and open "tag cloud". 2) Notice a bunch of new warnings in the log file that mostly have to do with "Use of uninitialized value $xslsyspref". 3) Apply the patch. 4) Reload the page and check the log file again. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:09:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:09:02 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-aurN4MOx3w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:10:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:10:22 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-1GHLFHFcQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 1. Shouldn't only be passed to the templates for OPAC interface? 2. You are assuming that this "branchcode" variable is passed only for this purpose. Is that true? 3. Where is this "branchcode" actually passed to the template? 4. Did you see that sometimes "logged_in_user.branchcode" is used (opac-main.tt)? Not sure this is correct actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:11:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:11:30 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-A3YvZqBWOg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #12) > Tbh this doesn't read like a trivial fix from the number of code changes. I > also think we shouldn't hardcode templates, as this breaks the templating > system: > > if ( C4::Context->preference('TranslateNotices') ) { > my $translated_languages = > - C4::Languages::getTranslatedLanguages( 'opac', > - C4::Context->preference('template') ); > + C4::Languages::getTranslatedLanguages( 'opac', 'bootstrap' ); Try a git grep ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:11:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:11:57 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-IXoB2fKwnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #13) > I think one problem is the lack of a test plan apart from running the tests, > which limits the people who can test, and that there is no easy to > understand description of the issue this is trying to fix. - This makes it > harder to test, especially for our non-programmer testers. You're probably right :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:13:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:13:16 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-yoDX5nRYkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #5) > I'm escalating this one a bit as really it's a regression rather than an > enhancement. How is it a regression? I don't think it was possible before either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:19:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:19:29 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-20dulgZC6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Why do we need the syspref if each user can decide if they want the feature? We could (later) remove OpacHighlightedWords and use local storage for OPAC as well. The reason I see would be to turn it off globally, but I don't think it's useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:19:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:19:33 +0000 Subject: [Koha-bugs] [Bug 29699] New: cronjobs/patron_emailer.pl fails with Module Patrons Message-ID: <bug-29699-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29699 Bug ID: 29699 Summary: cronjobs/patron_emailer.pl fails with Module Patrons Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org After doing the this instructions: https://bywatersolutions.com/education/monday-minutes-emailing-customized-patron-notices If the Module of the Notice is "patrons", I have this error: "The specified letter was not found, please check your input" If I change it to "circulation" works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:28:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:28:18 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-ICSlwNwTze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #14 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- I agree, it's like "killing an ant with a tank" to remove the highlight by adding a syspref, run updatedatabase.pl, add a conditioner... etc. I wanted to keep the same behavior as OPAC for some unity of operation. If we plan to remove OPACHighlightedWords later, it may be easier to add it to localstorage by a little js code for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:29:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:29:55 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29391-70-fRxw3HQuqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- - copyrightdate => $resultsbr->{copyrightdate}, - editionstatement => $resultsbr->{editionstatement}, This is correct, columns were always empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:30:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:30:15 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-3SNTQvNEb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #13) > Why do we need the syspref if each user can decide if they want the feature? > We could (later) remove OpacHighlightedWords and use local storage for OPAC > as well. > > The reason I see would be to turn it off globally, but I don't think it's > useful. We had requests to turn it off in the OPAC and also the staff interface. I think that it's by default 'on' is an issue that can be annoying. People are often irritated that everything is highlighted instead of only highlighting the words int he fields they searched in. I think having a pref here would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:30:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:30:24 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29391-70-gCQifOJKIv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:30:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:30:27 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29391-70-tdrsLkZmil@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127327|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128567&action=edit Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:31:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:31:57 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-U6FEs5w4Tv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What I am trying to say: this is a feature that is not wanted by some and we have a lot of feature on/off switches. I don't see the difference with this one? Having it in localstorage would be nice, but then I think we also should have a pref to set the default (highlight or not highlight). The unhighlight option is often missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:34:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:34:07 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-9eT539QwFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I count myself as a non-progammer tester as well - I think you mean that we already break the rule for not hardcoding the template, but I think those are bugs we should fix then. Hea shows that having your own OPAC template is not as rare as one would think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:39:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:39:16 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-Q4LuzGMBwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #16) > I count myself as a non-progammer tester as well - I think you mean that we > already break the rule for not hardcoding the template, but I think those > are bugs we should fix then. Hea shows that having your own OPAC template is > not as rare as one would think. This is an architectural patch, not the popular kind, yes. And insisting that it should also fix such occurrences makes it even harder. Since the patch is about fixing parameters, I would be tempted to say that it is outside the scope too ;) Having a look now how to get this on track again. But if it takes too much time, I will abandon it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:39:23 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-PhEPfIqTH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It's a regression in so much as when these were system preferences rather than news blocks you could set them in the apache environment to get a different OPAC look depending on the URL of the virtual host. That is impossible since the move from syspref to news and is causing a number of our upgrades pain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:42:01 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-UOyAGqOApI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #17 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- For now maybe someone can test my patch and tell if it's appropriate or not ? "Highlighting" and "Unhighlighting" options are still possible on the go when syspref isn't set to "Highlight" (by default) but if you disable highlighting you will didn't see any highlighting after that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:49:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:49:33 +0000 Subject: [Koha-bugs] [Bug 29700] New: Koha performs a second cashup in error when changing registers immediately after cashup Message-ID: <bug-29700-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29700 Bug ID: 29700 Summary: Koha performs a second cashup in error when changing registers immediately after cashup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com To recreate: - perform a cashup for library A, register A - after cashup, koha takes you do /cgi-bin/koha/pos/register.pl?op=cashup - from that url, click to Set Library - Change yourself to library B and register B - koha takes you back to /cgi-bin/koha/pos/register.pl?op=cashup, this time for your new register, and performs a second cashup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:52:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:52:17 +0000 Subject: [Koha-bugs] [Bug 29701] New: Add some user preferences in localstorage Message-ID: <bug-29701-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29701 Bug ID: 29701 Summary: Add some user preferences in localstorage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com For now some preferences depending to a syspref (OPACHighlightedWords for example) but it can be also interesting to store them in localstorage. So I create this BZ to develop it in the future -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:54:21 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20398-70-kae7pqUOu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #18 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Because it can concerned other syspref and this can be interesting to develop more I created https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:56:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:56:29 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-8Bpoj8MvBw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 14:56:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 13:56:33 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-yvn7dESWjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128479|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128568&action=edit Bug 29679: Remove redundant divider element from reports menu The SQL report batch operations dropdown menu has divider list items which add a border between sections (Bibliographic records, item records, etc.). This element is redundant because the sections have "headers" which also add a border. This patch removes them. To test, apply the patch and run an SQL report which will return results that trigger the batch modification menu: SELECT biblio.biblionumber , biblio.title, items.itemnumber, items.itemcallnumber, items.barcode, borrowers.firstname, borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber FROM issues LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber LEFT JOIN items ON issues.itemnumber=items.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber ORDER BY RAND() There should be no double border in the menu. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:38:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:38:10 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-SNTKMxlbAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128507|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128569&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:38:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:38:14 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-UVMTC8HRD5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128570&action=edit Bug 28955: (follow-up) Set to fall back This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:39:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:39:27 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9290-70-TWbWCYOUEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:40:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:40:50 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28955-70-QtVd4wqrtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #6) > 1. Shouldn't only be passed to the templates for OPAC interface? Done > 2. You are assuming that this "branchcode" variable is passed only for this > purpose. Is that true? Renamed to 'default_branch' > 3. Where is this "branchcode" actually passed to the template? I've switched to using a new default_branch and it's always passed for OPAC templates > 4. Did you see that sometimes "logged_in_user.branchcode" is used > (opac-main.tt)? > Not sure this is correct actually. It looks like most occurrences have no actually switched from 'branchcode' to 'logged_in_user.branchcode'.. I've updated all templates to use `logged_in_branch.branchcode || default_branch` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:45:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:45:49 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29325-70-6fFxEWZkHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #20 from Ulrich Kleiber <ulrich.kleiber at bsz-bw.de> --- Under Koha version 20.11 we have the following problem with this patch. The commit_file.pl script (CLI) runs through without error message. Example: MARC record import report ---------------------------------------- Batch number: 1 Number of new records added: 25315 Number of records replaced: 0 Number of records ignored: 0 Number of items added: 26973 Number of items replaced: 0 Number of items ignored: 0 In reality, however, not all bibliographic records are imported. In this example the last 14 records are missing. On the Staff page "Manage staged MARC records" the job status is displayed as "Importing" and the last 14 titles have the status "Staged". After a reset, another attempt with the same data resulted in the same problem, except that this time 16 records remained with the status "Staged". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:50:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:50:02 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-b1ET9k56OX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 15:50:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 14:50:07 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-nlT924OMRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #3 from Peter Vashchuk <stalkernoid at gmail.com> --- Created attachment 128571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128571&action=edit Bug 29684: fix warn about not found file js/locale_data.js Value of 'lang' unexpectedly was set to 'default', to prevent it, the feature was added to detect 'lang' getting overlaid in template and prevent + warn the developer about it. To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:44:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:44:03 +0000 Subject: [Koha-bugs] [Bug 29702] New: all_libraries routine in library groups make a DB call per member of group Message-ID: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Bug ID: 29702 Summary: all_libraries routine in library groups make a DB call per member of group Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursivley calls itself if a group. This slows down performance To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:47:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:47:21 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29702-70-DDS3KrOJFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:47:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:47:24 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29702-70-5XwF5My2ZX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128572&action=edit Bug 29702: fetch group libraries in a single call The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursively calls itself if a group. This slows down performance. We can utilize the 'libraries' method to get all child libraries at once, then make a check for child groups separately To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection 8 - Apply patch 9 - note improvement 10 - prove -v t/db_dependent/Koha/Libraries.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:49:31 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29702-70-4soyKMUlDY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:49:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:49:32 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19865-70-S387js4AfY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 16:49:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 15:49:36 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19865-70-ef6EvWTFbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128573&action=edit Bug 19865: Add back horizontal scrollbar to cat_z3950_search To test: 1. Do a Z39.50/SRU search 2. In the search results click on MARC to get the MARC preview. Choose something with lots of MARC data so it is both wide and long. 3. See the Y axis scrollbar 4. You must scroll bottom of the modal to see the X axis scrollbar, annoying. 5. Apply patch 6. Regenrate the CSS files ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) 7. Try steps 1-4 again. This time you should see the X axis scrollbar without having to scroll to the bottom. 8. It's not a bad idea to test in multiple browsers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:27:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:27:09 +0000 Subject: [Koha-bugs] [Bug 29703] New: Simplify GetBranchItemRule Message-ID: <bug-29703-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29703 Bug ID: 29703 Summary: Simplify GetBranchItemRule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Possibly we should work towards removing this sub, but for now we should use get_effective_rules rather than calling get_effective rule three times -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:28:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:28:29 +0000 Subject: [Koha-bugs] [Bug 29703] Simplify GetBranchItemRule In-Reply-To: <bug-29703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29703-70-BuHyhywQ8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29703 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:28:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:28:32 +0000 Subject: [Koha-bugs] [Bug 29703] Simplify GetBranchItemRule In-Reply-To: <bug-29703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29703-70-VPxXuRUciv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29703 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128574&action=edit Bug 29703: Use get_effective_rules in GetBranchItemRule To test: 1 - prove -v t/db_dependent/Circulation/Branch.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:37:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:37:35 +0000 Subject: [Koha-bugs] [Bug 28111] Add file grouping and granular permissions to the 'Access files' tool In-Reply-To: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28111-70-J2a9LXqQQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28111 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Would go along nicely with https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:56:01 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29654-70-u4mMd5Cv8b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 --- Comment #5 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128575&action=edit Bug 29654: Add match_record_id option to bulkmarimport.pl Add -match_record_id option to bulkmarkimport.pl. When enabled incoming record id will be assumed to match record in Koha. To test: 1) Before applying patch, export a biblio from staff interace 2) Import using the exported file: ./bulkmarcimport.pl -m="MARCXML" -v -b -file bib-xxxxx.marcxml -insert -update -c=MARC21 -l "/tmp/import.log" 3) The import with be inserted and create a duplicate record in Koha. Check the import.log or search using the staff interface. (could also crash with duplicate key error if contains item) 4) Apply patch 5) Run the import again with the same command as above 6) A new record should been inserted 7) Remove all newly inserted duplicate records (it's important to keep the record the export was initially performed on) 6) Run the import again, but add the -match_record_id option 8) The original Koha record should now have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:56:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:56:11 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29623-70-hetp4IeDoc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128180|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128576&action=edit Bug 29623: Cache circulation rules Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 17:57:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 16:57:08 +0000 Subject: [Koha-bugs] [Bug 29623] Cache circulation rules In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29623-70-RZI1gfp0VC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Testing on top of 29703 this improves the performance on request.pl by about 1.5 seconds with 100 items, which is pretty decent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 20:50:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 19:50:08 +0000 Subject: [Koha-bugs] [Bug 29704] New: Holds reminder emails should allow configuration for a specific number of days Message-ID: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Bug ID: 29704 Summary: Holds reminder emails should allow configuration for a specific number of days Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The holds reminder email cron takes a DAYS value and sends reminders to all patrons with holds waiting more than that number of days. Currently, once a hold passes the number of DAYS specified in the cron, the patron gets a reminder on EVERY run of the cron going forward. We should also provide an option to send reminder emails only for holds that have been waiting EXACTLY that many days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 20:50:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 19:50:34 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29704-70-lUmrOJU2Wj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com, | |sbrown at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:18:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:18:42 +0000 Subject: [Koha-bugs] [Bug 29705] New: Test suite has some IssuingRules left-overs Message-ID: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Bug ID: 29705 Summary: Test suite has some IssuingRules left-overs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ We should merge with CirculationRules. Also we should rename in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:18:51 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29705-70-xDN5JmSUTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:18:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:18:51 +0000 Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-zPzgStcA8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 [Bug 29705] Test suite has some IssuingRules left-overs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:18:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:18:58 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29705-70-0rFF2670Tf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:22:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:22:32 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29705-70-Y3XReUyuld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:22:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:22:36 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29705-70-9mQklmU8Me@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128577&action=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:29:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:29:44 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-Kcj7WzCKW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org --- Comment #9 from Ed Veal <eveal at mckinneytexas.org> --- I agree with Lucas, can we get this back ported to 21.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:37:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:37:44 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-C4Q5IlLuF3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #21) > Created attachment 128446 [details] [review] > Bug 26587: Use Koha::Cache::Memory::Lite Great. But in my opinion cache key is too short : my $cache_key = "Library_branchname:" . $branchcode; We may have need for library datas cache in other places. I propose : my $cache_key = "Template_Plugin_Branches_branchname:" . $branchcode; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:36 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-2Pthy30Muv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:39 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-4bMIfsX3Ej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:41 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-9bRHrrd9Ja@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:43 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-rQUPdWHyTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:46 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-STx3T4fA6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:48 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-Vi8uf1yQXt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:51 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-NfLu4mSiGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:54 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-x2OWifUmVH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #23 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:50:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:50:57 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-V70Ie9FatK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 22:51:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 21:51:00 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-89QWQ4h8JK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:16:27 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-37hNGVJt5k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #65 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Fridolin Somers from comment #64) > Please have a look at Bug 29690. > We need to catch invalid metadata record so get_marc_authors() is concerned. > I'd like QA to confirm this is the correct way to implement. Since this one is already passed-QA I push it and will amend Bug 29690 for get_marc_authors(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:16:43 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-UAMiEu5p3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:16:43 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-Ivd0BcZLZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:16:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:16:51 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-bML2rJ44Gb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:18:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:18:14 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-xEM2NkkY9i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:18:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:18:16 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-bxYdgEhXeX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #66 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:31:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:31:56 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-8IdPpjycto@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- I see Bug 27268 kept marcflavour has param : my $marcflavour = $params->{marcflavour}; But other calls fetch syspref value : get_marc_host, get_marc_authors ... We should be consistent. Any reason to keep marcflavour has param ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:33:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:33:58 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-civpFjFPZi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fridolin Somers from comment #1) > I see Bug 27268 kept marcflavour has param : > my $marcflavour = $params->{marcflavour}; > > But other calls fetch syspref value : > get_marc_host, get_marc_authors ... > > We should be consistent. > > Any reason to keep marcflavour has param ? I wouldn't keep it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:37:10 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-zNbrYQoPzw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:37:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:37:14 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-E8xNFFOYVw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128578&action=edit Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:38:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:38:27 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-TDzpI9GA2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #27 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Fridolin Somers from comment #26) > Created attachment 128578 [details] [review] > Bug 29690: (follow-up) Add eval on metadata record fetch in > get_marc_authors() @Rmaints : When backporting this, skip this patch if branch does not contain Bug 27266 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:38:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:38:45 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-Y87jIxzyo5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:50:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:50:34 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-ZEn2PkKQ8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #10) > (In reply to Fridolin Somers from comment #8) > > Ah OK thanks. > > > > get_enabled_plugins () is a private method ? maybe rename > > _get_enabled_plugins() > > > > Best regards, > > It's a class method, like all other methods from this module. Ah OK thanks. Now i see there is : my ($class) = @_; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:54:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:54:19 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-EO3Vyc2IUY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #3) > Owen, should we remove the .dropdown-header's border-top? I think it makes more sense to keep this CSS and remove divider HTML element -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 15 23:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 22:55:27 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-SivAfskvxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #2) > (In reply to Fridolin Somers from comment #1) > > I see Bug 27268 kept marcflavour has param : > > my $marcflavour = $params->{marcflavour}; > > > > But other calls fetch syspref value : > > get_marc_host, get_marc_authors ... > > > > We should be consistent. > > > > Any reason to keep marcflavour has param ? > > I wouldn't keep it I don't even think it should consider the syspref. The syspref would've been considered when setting the 'schema' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 00:22:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 23:22:40 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-DnLtQDhbWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 00:22:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Dec 2021 23:22:43 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-SPUjS5zu2t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128466|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128579&action=edit Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 01:55:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 00:55:17 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-IbouVjQKDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #27 from David Cook <dcook at prosentient.com.au> --- (In reply to Fridolin Somers from comment #26) > (In reply to Jonathan Druart from comment #21) > > Created attachment 128446 [details] [review] [review] > > Bug 26587: Use Koha::Cache::Memory::Lite > > Great. > > But in my opinion cache key is too short : > my $cache_key = "Library_branchname:" . $branchcode; > We may have need for library datas cache in other places. > > I propose : > my $cache_key = "Template_Plugin_Branches_branchname:" . $branchcode; Good call on using Koha::Cache::Memory::Lite. I suppose the cache key is debateable. I don't think we have an index of cache keys, so Frido might be right about making a more targeted cache key, so that there isn't an accidental collision with another script that stores different data using the same key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 01:59:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 00:59:32 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-1AdCu49svv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #28 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #27) > I suppose the cache key is debateable. I don't think we have an index of > cache keys, so Frido might be right about making a more targeted cache key, > so that there isn't an accidental collision with another script that stores > different data using the same key. Sorry I shouldn't have said another script since it's a L1 cache. I mean a different module/function. That said, the risk seems fairly low of that happening... If we did have an index, re-using the same cache key across different modules seems appealing to me. I'm on the fence. On one hand, this is already Passed QA, so maybe we leave it as is, and just change it later if it's an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 02:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 01:59:42 +0000 Subject: [Koha-bugs] [Bug 29706] New: When placing a request on the opac, the user is shown titles they cannot place a hold on Message-ID: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Bug ID: 29706 Summary: When placing a request on the opac, the user is shown titles they cannot place a hold on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When a user is placing a hold in a consortium, there may be many items on a record that cannot be held. We display these items which can cause the need for scrolling to get to items that can be held. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:06:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:06:47 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29706-70-apR9gtIGIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:06:50 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29706-70-W90hlNJ3GJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128580&action=edit Bug 29706: Improve table elements This patch add a thead and tbody element to the 'copiesrow' table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:06:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:06:53 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29706-70-pYv0Bq6DLT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128581&action=edit Bug 29706: Hide items that cannot be held by default when placing hold on OPAC This patch adds a 'holdable' and 'unholdable' class to the rows of the table Additionally I rename the 'backgroundcolor' field to 'onloan' as that is what it contains. Note: Out of the box, there is no css associated with this class I add a div around the table to allow hiding the new buttons as well when optiuons are hidden It would be nice in the future to utilise a Koha table here, however, it is complicated by multi-holds To test: 1 - Add a number of items to a record, ensuring they belong to different libraries 2 - Set 'Default checkout, hold and return policy'->'Hold policy' to 'From home library' 3 - Sign in to opac and attempt to placehold on the record 4 - Click 'show more options' and 'a specificitem' 5 - Note holds table includes items that cannot be held 6 - Apply patch 7 - Reload holds page 8 - Note items that cannot be heldare hidden 9 - Click 'Show unholdable items' and note they appear 10 - Click 'Hide unholdable items' and veriofy they hide 11 - Test with multi holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:07:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:07:08 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29706-70-MsrR7T7C1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:18:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:18:50 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-8CkvNxyl2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:18:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:18:54 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-8sQ2XQRHqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128332|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128582&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:18:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:18:58 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-ysvd31DCUo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128333|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128583&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 03:19:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 02:19:03 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-czuEimChtY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128584&action=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 05:18:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 04:18:06 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-qexsB67JM4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101580|0 |1 is obsolete| | Attachment #128341|0 |1 is obsolete| | Attachment #128342|0 |1 is obsolete| | Attachment #128343|0 |1 is obsolete| | Attachment #128344|0 |1 is obsolete| | Attachment #128345|0 |1 is obsolete| | Attachment #128346|0 |1 is obsolete| | Attachment #128347|0 |1 is obsolete| | Attachment #128348|0 |1 is obsolete| | Attachment #128349|0 |1 is obsolete| | Attachment #128350|0 |1 is obsolete| | Attachment #128351|0 |1 is obsolete| | Attachment #128352|0 |1 is obsolete| | Attachment #128353|0 |1 is obsolete| | Attachment #128354|0 |1 is obsolete| | Attachment #128355|0 |1 is obsolete| | Attachment #128356|0 |1 is obsolete| | Attachment #128357|0 |1 is obsolete| | --- Comment #155 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128585&action=edit Bug 15326: WIP: Using AdditionalContents for custom pages on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 05:18:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 04:18:50 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-rG3UEOpRak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 06:54:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 05:54:21 +0000 Subject: [Koha-bugs] [Bug 29707] New: Proficient methods to make payment from apple pay to cash app: Message-ID: <bug-29707-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29707 Bug ID: 29707 Summary: Proficient methods to make payment from apple pay to cash app: Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: re0664059 at gmail.com QA Contact: testopia at bugs.koha-community.org Making a payment online has become a trendy custom with the rapid development of the internet world. With another payment app. Apple pay is also there to serve. Now you can carry on the transactional activities from the apple pay to cash app easily through certain steps and guidance from the highly competent Apply pay app professionals. The improved service by the executive is usually helpful in many terms. https://www.number-directory.com/blog/apple-pay-to-cash-app/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 08:08:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 07:08:55 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26440-70-LJ5RNpZrRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 --- Comment #6 from Didier Gautheron <didier.gautheron at biblibre.com> --- Created attachment 128586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128586&action=edit Bug 26440: Prioritize 'on hold' over Not renewable' in Renew column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 08:11:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 07:11:09 +0000 Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold In-Reply-To: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26440-70-kPyw1DaU9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om Depends on| |25758 --- Comment #7 from Didier Gautheron <didier.gautheron at biblibre.com> --- It's still an issue in 20.11. Attached the patch we are using. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 08:11:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 07:11:09 +0000 Subject: [Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold In-Reply-To: <bug-25758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25758-70-RBLTqgtH3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440 [Bug 26440] Not renewable Supersedes On Hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 08:24:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 07:24:11 +0000 Subject: [Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call In-Reply-To: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29672-70-0ZsOEFWHmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672 --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jonathan Druart from comment #9) > Julian, I am not sure, you are bypassing Koha::Plugin::Base->retrieve_data > that is used in other places. As we are actually looking at caching the > result, why not keep the usual way to retrieve the enabled plugins then > cache them? I guess you're talking about the is_enabled method (which calls retrieve_data) ? I think we should not ask the plugin itself if it's enabled because a plugin can override this method. It also produces less SQL queries that way (one query to retrieve all enabled plugins, instead of one query per module) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:19:21 +0000 Subject: [Koha-bugs] [Bug 28775] Warn when viewing itemtypes.pl In-Reply-To: <bug-28775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28775-70-nwQQWNQ88M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28775 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 29040 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:19:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:19:21 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-re2we0N5uy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** Bug 28775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:22:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:22:33 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-D8rAXVKYhC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I will still have a look at this call now on bug 29245. my $translated_languages = C4::Languages::getTranslatedLanguages( "both", C4::Context->preference('template') ); When we ask for both, it is actually a bit weird to pass the staff theme too. But this is merely theoretical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:23:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:23:41 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-tuMLZswaMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 [Bug 29245] Fix the parameters of getTranslatedLanguages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:23:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:23:41 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-iB2kxYkVTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 [Bug 29040] Uninitialized value warning in Languages.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:24:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:24:18 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-A2Ari0oB3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:27:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:27:43 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-LhrlkltROQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- To me the key is correct and actually perfect as it, we can imagine another method using it as well. It's storing a map of branchcode => branchname, no need to be more specific IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:32:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:32:20 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-dtZvgSznaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:32:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:32:28 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-AmSxyDk6nJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:32:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:32:37 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-DqpJ23o093@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:32:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:32:53 +0000 Subject: [Koha-bugs] [Bug 29411] Single result for checkout search by name should redirect to check out tab In-Reply-To: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29411-70-CHkJS0Gw5u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29411 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 10:38:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 09:38:47 +0000 Subject: [Koha-bugs] [Bug 29708] SPAM In-Reply-To: <bug-29708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29708-70-wm1NkSCttO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | QA Contact| |testopia at bugs.koha-communit | |y.org Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Summary|How to activate cash app |SPAM |card-Give a call to | |specialists. | Component|Koha |Architecture, internals, | |and plumbing Resolution|--- |INVALID Product|Koha security |Koha Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:00:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:00:16 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-NsHB1ij2O9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Another question: admin/localization.pl contains: my $translated_languages = C4::Languages::getTranslatedLanguages( 'intranet', C4::Context->preference('template') ); Since we use both in itemtypes, I am wondering if this statement is wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:07:34 +0000 Subject: [Koha-bugs] [Bug 28617] misc/kohalib.pl no longer useful In-Reply-To: <bug-28617-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28617-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28617-70-LGqOYRbwqm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |the script misc/kohalib.pl. | | | |The purpose of this script | |was to load the relevant | |Koha lib for the different | |scripts (installation, | |cronjob, CLI, etc.). | |However, it is not used | |consistently and we prefer | |to rely on PERL5LIB. | | | |If | |upgrading ancient Koha | |systems from tarballs | |double-check that PERL5LIB | |is set in crontab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:17:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:17:56 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-twgkvRZmMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:17:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:17:59 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-80FwukBZE7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128387|0 |1 is obsolete| | Attachment #128388|0 |1 is obsolete| | Attachment #128389|0 |1 is obsolete| | Attachment #128390|0 |1 is obsolete| | --- Comment #9 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128587&action=edit Bug 27208: Add a user specified delay before sending pickup notices. This bug adds the ability to delay sending a notice until a set timestamp. It also adds a user selectable time on the returns page to delay sending of the pickup notice. The notice delay will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in an item with a hold to produce a pickup notice. 3. Select a time for pickup notice delay. Note the warning about the delay. 4. Check in another item with hold to produce a pickup notice. 5. Check the patron notice logs, the one with a delay should read "pending, delayed until ...". 6. Run process_message_queue.pl before and after the selected time above. The delayed message should not be sent until after the set time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:18:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:18:03 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-CrPR3BLaiX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #10 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128588&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:18:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:18:07 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-FRf0d2gwCj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #11 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128589&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:18:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:18:10 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-IkJBIFpgAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #12 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Created attachment 128590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128590&action=edit Bug 27208: Unit tests This commit adds unit test for changes in C4/Letters.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:19:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:19:22 +0000 Subject: [Koha-bugs] [Bug 29707] SPAM In-Reply-To: <bug-29707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29707-70-ZO3p3ll6jK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29707 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Proficient methods to make |SPAM |payment from apple pay to | |cash app: | Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:21:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:21:20 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-8nj5DyZpNi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #13 from Björn Nylén <bjorn.nylen at ub.lu.se> --- Updated patches that passed the qa-tools. Set back to Needs signoff and awaiting any comments on the functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:29:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:29:24 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29593-70-7B1Q0FdFEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the tag in GET release notes| |/public/libraries | |(api/v1/swagger/paths/libra | |ries.json file) from | |library to libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:42:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:42:46 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-7BW2HKOH8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves all release notes| |the Koha REST API | |specification from json to | |YAML format. It also | |corrects two named | |parameters incorrectly in | |camelCase to sanake_case | |(fundidPathParam => | |fund_id_pp, | |vendoridPathParam => | |vendor_id_pp). CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:48:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:48:10 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-qLsMA6nTKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes Koha's OAI-PMH release notes| |server so that it returns | |the appropriate error code | |when no sets are defined. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 11:49:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 10:49:51 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-xpQAYtstCg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:17:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:17:24 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-u4a4CdQPxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |david at davidnind.com Text to go in the| |This change prevents the release notes| |deletion of records with | |current serial | |subscriptions. | | | |Selecting | |"Delete record" when there | |are existing subscriptions | |no longer deletes the | |record and subscription, | |and adds an alert box | |"[Count] subscription(s) | |are attached to this | |record. You must delete all | |subscriptions before | |deleting this record.". | | | |It | |also: | |- adds a | |"Subscriptions" column in | |the batch deletion records | |tool with the number of | |subscriptions and a link to | |the search page with all | |the subscriptions for the | |record, and | |- adds a button | |in the toolbar to enable | |selecting only records | |without subscriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:22:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:22:38 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-qtlh6MYA1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #15 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 128591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128591&action=edit Screenshot showing problems I'm seeing a couple of issues with the results, as shown in this screenshot: Is there supposed to be both an "Availability" and "Due date" column? I think this misalignment is why the column search field under "Availability" doesn't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:22:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:22:46 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-f1Q398VuHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:33:25 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-Uvr0rUI6kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes placing club release notes| |holds so that checks are | |correctly made and warning | |messages displayed when | |patrons are debarred or | |have outstanding fees and | |charges. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:50:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:50:51 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9290-70-ydfbHDS2mx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 12:53:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 11:53:03 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-HZ1h3lFW18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Keywords|release-notes-needed | Text to go in the| |This fixes an issue with release notes| |the installer files that | |meant "Hold reminder" | |notices were not shown in | |messaging preferences for | |new installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 13:01:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 12:01:20 +0000 Subject: [Koha-bugs] [Bug 29709] New: Add option to use patron library as suggestion library Message-ID: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29709 Bug ID: 29709 Summary: Add option to use patron library as suggestion library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org It could be useful to the have the ability to use the library in which the patron is registered (borrowers.branchcode I suppose) as the default library of suggestions submitted by this patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 13:09:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 12:09:18 +0000 Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes and needs protection against cyclic relations In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24407-70-HuYpIA43TS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #0) > Suppose I have term A with children B and C where the children have a 550 > tag with broader indication to A. > If I go to record A, the tree is built showing B and C. > If I add a child D to A, the tree for A is not rebuilt but still showing the > old situation. What you're saying is that if you sit on the parent, it doesn't have a way to know a new child showed up, and you're proposing some automatic bi-directional linking? I like this. > A related problem: > If I change term A setting it to a be child of B with a 550 (which it > obviously not is), this cyclic relation will trigger deep recursion. > Resulting in a gateway timeout and a process eating up resources.. Had to deal with this in production. I wrote a tiny script that does a DFS to find cycles from a leaf, following the $wg path (the $wh are not considered in most of the code as far as I can tell.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 13:10:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 12:10:33 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-19M4QlXreX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes an issue where release notes| |vendors are repeated in the | |serials report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 13:20:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 12:20:53 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-dAX0sv5BIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the POS release notes| |transactions page so that | |the total for the sale and | |the amount to collect are | |the same. | | | |Before this a | |POS transaction with | |multiple items in the Sale | |box, say for example 9 x | |.10 items, the total in the | |Sale box appears correct, | |but the amount to Collect | |from Patron is off by a | |cent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 13:42:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 12:42:56 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-rl0CUjtb9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |Up until Koha 20.11 the release notes| |pickup location when | |placing item-level holds | |was the currently logged-in | |library. | | | |From Koha 21.05 | |the holding branch was used | |as the default. | | | |This | |restores the previous | |behaviour so that the | |logged-in library (if a | |valid pickup location) is | |selected as the default | |pickup location for | |item-level holds. When it | |is not, an empty dropdown | |is used as a fallback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:16:25 +0000 Subject: [Koha-bugs] [Bug 29710] New: Add cancellation reason to OPAC holds history Message-ID: <bug-29710-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29710 Bug ID: 29710 Summary: Add cancellation reason to OPAC holds history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: axelle.clarisse at univ-amu.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 26281 adds the cancellation reason to the holds history page in the staff interface. It would be useful to have the same dev on the holds history page on the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:15:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:15:25 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29528-70-qssnLMPUxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change removes the release notes| |"Additional contents" | |breadcrumb when working | |with news items or HTML | |customizations. Since news | |and HTML customizations are | |separate links on the tools | |home page there's no reason | |to have the breadcrumbs | |imply the two sections are | |connected in any way. We | |already have the "See News" | |link, for example, for | |switching quickly between | |the two areas. Keywords| |Manual CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:54 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29036-70-ET7OG1Zs2k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #25 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:54 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29529-70-OeA3BBA9yg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #6 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:55 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29514-70-uWNEZXubup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #6 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:55 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29513-70-a3g69AMP4X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #7 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:55 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29488-70-mRXESL9NNX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #8 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:55 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29521-70-VQ1GgdLi9g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #6 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:56 +0000 Subject: [Koha-bugs] [Bug 29406] Improve display of OPAC suppression message In-Reply-To: <bug-29406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29406-70-luvAvTJtKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29406 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #8 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:28:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:28:56 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-ZbcyXZyjwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #41 from David Nind <david at davidnind.com> --- Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:38 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-LgwiOb5f6J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:41 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-UsIVJLQqyW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128592&action=edit Bug 29648: Improve existing code We already have 2 tables that are configurable, on acqui/basket and reports/orders_by_budget. This patch is modifying a bit the existing code to transfer the responsability/logic to the KohaTable constructor instead of the template that is creating the object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:46 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-ZXKPYrTNFZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128593&action=edit Bug 29648: Move NumSavedReports to the table settings The syspref NumSavedReports can be moved to the table settings config Test plan: 1. Set the syspref to a given value 2. updatedatabase # execute the atomic update 3. Go to the table settings page and confirm that the syspref's value has been retrieved 4. Select a specific colonne for the default sort 5. Go to the report list view and confirm that the "Show X entries" has the correct selected value and that the table is sorted as you expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:50 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-OB0WB56Ro4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128594&action=edit Bug 29648: Add item - broken FIXME Why don't we have the columns visibility button? It looks like there is something broken here, why don't we have the show/hide columns buttons? The code expects it to be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:54 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-4Hxd8Pfk2k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128595&action=edit Bug 29648: Duplicate orders view - no change No change expected here, only removing commented-out code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:47:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:47:58 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-fuWbwfpdoO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128596&action=edit Bug 29648: Order search view - normal "normal" means that we are expecting the table to have the 2 options implemented and working. You can select "Default display length" and "Default sort order" in the "table settings" administration view, then go the the view and confirm that the table has the configured values pre-selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:01 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-sUHVscJA21@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128597&action=edit Bug 29648: Late orders view - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:05 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-m2G9aLRk42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128598&action=edit Bug 29648: Authorised values view No change is expected on this view as the table is not part of the table settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:09 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-ABbCdZCI1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128599&action=edit Bug 29648: Libraries administration view - normale -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:13 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-VgQWf18PqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128600&action=edit Bug 29648: Patron categories administration view - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:18 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-flh0OJ34zA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128601&action=edit Bug 29648: Cities administration view - REST API Here we need to deal with the other DT config (in datatables.js, not columns_settings.inc). Test plan: Same as "normal" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:22 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-5i3DN530KZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128602&action=edit Bug 29648: Item types administration view Set noItemTypeImages and OpacNoItemTypeImages to "No" and confirm that the first column (the image) is not displayed. Otherwise test as "normal" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:26 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-pioQXgd4js@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128603&action=edit Bug 29648: Allow tables_settings.default_display_length to be NULL We actually want this value to be NULL. If set to NULL and default_display_length is not in the yml, then the option will not be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:30 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-gv8jrRW2Oz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128604&action=edit Bug 29648: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:34 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-e1rOxsULHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128605&action=edit Bug 29648: Catalogue detail - no default_display_length On the acquisition table the sort option is not available as we don't offer the ability to selection asc/desc and default to asc. We cannot offer default_display_length for those tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:38 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-k1XSAXBp90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128606&action=edit Bug 29648: Checkout history - normal no sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:42 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-MFHM9rUXGL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128607&action=edit Bug 29648: Cataloguing Z3950 search - no pagination Pagination is done server-side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:46 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-AFT3VvHGZG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128608&action=edit Bug 29648: Overdue list - normal 'stateSave' so need to test on the first try or delete the relevant local storage entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:50 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-Yx0MaMRZzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128609&action=edit Bug 29648: Holds to pull - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:55 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-1xsTvAQigA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128610&action=edit Bug 29648: Holds ratios - normal but no sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:48:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:48:58 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-dBZuWsK1iD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128611&action=edit Bug 29648: Returns - no change No change expected here, there is no sort and no paginate possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:02 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-9sNB1O5EmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128612&action=edit Bug 29648: Holds queue - only sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:06 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-X3MdcqV60O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128613&action=edit Bug 29648: Course reserve detail - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:10 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-m6y2AtyFlb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128614&action=edit Bug 29648: Course reserve list - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:14 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-jXuhmYPEWc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128615&action=edit Bug 29648: ILL - no change No change expected here for ILL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:19 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-Y8j3jjIrKV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128616&action=edit Bug 29648: Patron accounting page - no sort because of desc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:23 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-3SMdVc2b1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128617&action=edit Bug 29648: Holds history - no sort because of desc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:27 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-0HUK3alIqg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128618&action=edit Bug 29648: Patron page (PatronsPerPage) - no change PatronsPerPage should be done on a separate bug report, not trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:31 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-IZuEQxsBWr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128619&action=edit Bug 29648: Payments - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:35 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-RR8gXg8OvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128620&action=edit Bug 29648: Checkout history - no sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:39 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-mjztj9m66g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128621&action=edit Bug 29648: patron list table - normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:43 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-UsmwcKhy41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128622&action=edit Bug 29648: Item lost report - no change hum, there is no sort on this table, so it's displayed like it's coming from the controller, but perl code does not sort either. This could be improved and we could make it configurable easily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:47 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-ZmHXWAvxbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128623&action=edit Bug 29648: Subscription detail - no change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:52 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-RPDMp5qX34@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128624&action=edit Bug 29648: Notice template - only sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:49:56 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-MZm6bXSkre@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128625&action=edit Bug 29648: Upload tool - no sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:50:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:50:00 +0000 Subject: [Koha-bugs] [Bug 29648] Replace NumSavedReports with table configuration setting In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-aIt52VVBPT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128626&action=edit Bug 29648: Log viewer - no sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:50:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:50:47 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-XGKodhex7S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace NumSavedReports |Make KohaTable tables |with table configuration |'default length' and |setting |'default sort' configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:50:56 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-4CQeehtEmK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29530 | Depends on| |29530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 [Bug 29530] When NumSavedReports is set, show value in pull down of entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:50:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:50:56 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29530-70-cfkXQTnSc6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29648 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29648 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 14:51:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 13:51:10 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-jEA58AVU0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:21:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:21:09 +0000 Subject: [Koha-bugs] [Bug 29711] New: Release date not passed as ISO to about.tt Message-ID: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Bug ID: 29711 Summary: Release date not passed as ISO to about.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When parsing the teams.yaml file, the release date is (correctly) parsed from epoch into a DateTime, but the $KohaDates filter expects 'iso' formatted dates, and stringifying the 'dt' object leads to non-comformant datetime format. To test: 1. On current master 2. Point your staff interface to the About page => FAIL: It explodes because of date formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:21:42 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-zXVQRuU2mE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:21:42 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-hRzHei34fi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 [Bug 29711] Release date not passed as ISO to about.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:21:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:21:46 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-MPaFTugKdK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:26:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:26:24 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-G20HzqJ7eO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:26:29 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-zoNRngYQM1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128627&action=edit Bug 29711: Pass release date in ISO to about.tt This patch makes the date be converted into ISO format so it is correctly handled by the KohaDates TT filter. To test: 1. Point your browser to the about page => FAIL: It explodes: Template process failed: undef error - The given date (2022-05-22T00:00:01) does not match the date format (iso) 2. Apply this patch 3. Restart: $ koha-plack --restart kohadev 4. Repeat 1 => SUCCESS: It doesn't explode, shows the right date! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 15:29:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 14:29:56 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-MGOZMa50Oz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:07:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:07:39 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-T4LhEywgnj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is really ugly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:08:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:08:49 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-kC7TThaQYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I meant, not your patch :) But what we need to do. That is plain wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:13:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:13:54 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-5lWzF9GXcC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:13:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:13:57 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29686-70-pr1IblACK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128514|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 128628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128628&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:18:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:18:38 +0000 Subject: [Koha-bugs] [Bug 29712] New: [DOCS] [Omnibus] Content development guide Message-ID: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 Bug ID: 29712 Summary: [DOCS] [Omnibus] Content development guide Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://wiki.koha-community.org/wiki/Documentation_-_C ontent_Development_Guide OS: All Status: ASSIGNED Severity: enhancement Priority: P3 Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Omnibus bug for the creation of a content development guide for the documentation team. It will include: * a style guide: guidelines for writing clear and concise content, including grammar and word lists * an information model: structures and guidelines to help us write different types of content consistently * a content strategy: a plan outlining how we develop content, including the types of information products we create, the tools we use, and the processes we follow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:29:47 +0000 Subject: [Koha-bugs] [Bug 29713] New: Make item table when placing an item level hold sortable Message-ID: <bug-29713-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Bug ID: 29713 Summary: Make item table when placing an item level hold sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For serial records where the items are different volumes and issues, item level holds make sense, but there are often a lot of items to pick from too. It would be great if the item form on the hold request page in the OPAC had sorting and filter options to make picking the correct item easier. The table is already sortable in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:30:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:30:01 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: <bug-29713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29713-70-dH1KQTwmK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/opac-reserve. | |pl?biblionumber= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:30:45 +0000 Subject: [Koha-bugs] [Bug 29714] New: [DOCS] Git guide for documentation Message-ID: <bug-29714-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29714 Bug ID: 29714 Summary: [DOCS] Git guide for documentation Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://wiki.koha-community.org/wiki/Git_guide_for_doc umentation OS: All Status: ASSIGNED Severity: enhancement Priority: P3 Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Blocks: 29712 Complete the beginners guide to using Git - aimed at non-developers, and specifically for the documentation team. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 [Bug 29712] [DOCS] [Omnibus] Content development guide -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:30:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:30:45 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29712-70-Ph9tL85Xay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29714 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29714 [Bug 29714] [DOCS] Git guide for documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:31:11 +0000 Subject: [Koha-bugs] [Bug 29715] New: Duplicate entry 'IN-region' for key Message-ID: <bug-29715-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29715 Bug ID: 29715 Summary: Duplicate entry 'IN-region' for key Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: mhby87 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 128629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128629&action=edit Updating database structure error I upgrade from 21.05.05.003 to 21.11 Updating database structure, I get this error (see attachment) Upgrade to 21.06.00.012 [23:24:27]: Bug 15067 - Add missing languages ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'IN-region' for key 'language_subtag_registry.uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738 Thank you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:37:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:37:14 +0000 Subject: [Koha-bugs] [Bug 29716] New: [DOCS] Automated screenshots Message-ID: <bug-29716-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716 Bug ID: 29716 Summary: [DOCS] Automated screenshots Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://gitlab.com/davidnind/koha-automated-screenshot s OS: All Status: ASSIGNED Severity: enhancement Priority: P4 Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org See if we can automate the capture of as many screenshots as possible for the Koha documentation, in as many languages as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:39:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:39:45 +0000 Subject: [Koha-bugs] [Bug 29716] [DOCS] Automated screenshots In-Reply-To: <bug-29716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29716-70-LH6OZuJR2V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716 --- Comment #1 from David Nind <david at davidnind.com> --- I've added a URL for a Git repository and work I had done some time ago. Need to refresh the tooling and see if any other options are available. See also this information on the Wiki: https://wiki.koha-community.org/wiki/Documentation_Automated_Screencapture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:48:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:48:01 +0000 Subject: [Koha-bugs] [Bug 29717] New: Too many DateTime manipulation in tools/additional-contents.pl Message-ID: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Bug ID: 29717 Summary: Too many DateTime manipulation in tools/additional-contents.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:48:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:48:07 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29717-70-igWv1BOoXj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:48:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:48:07 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24387-70-axpOf9jCrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:49:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:49:41 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29717-70-KRykqlLVeH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:49:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:49:45 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29717-70-dH7b31zaHl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128630&action=edit Bug 29717: Remove unecessary DT manipulations from tools/additional-contents.pl DBIC handles DateTime correctly, no need for this output_pref call. Test plan: Create a new content, set the dates, confirm they are set correctly Modify the content, modify the dates, confirm they are stored correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 16:50:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 15:50:13 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29717-70-JmISwyZtTX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:00:38 +0000 Subject: [Koha-bugs] [Bug 29718] New: DateTime - our 'iso' is not ISO 8601 Message-ID: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Bug ID: 29718 Summary: DateTime - our 'iso' is not ISO 8601 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com, tomascohen at gmail.com In some scripts we are doing unnecessary conversion from string to DT and vice-versa, sometimes several times. For instance, see bug 29711. We have epoch => DT => string => sending to template in 'iso' YYYY-MM-DD HH:MM => DT => string. This is because the stringified version of DT (the real ISO 8601 YYYY-MM-DDTHH:MM:SS) is not supported by our dt_from_string method. There are (at least) two options: * Use DateTime::Format::Strptime In dt_from_string: my $formatter = DateTime::Format::Strptime->new(pattern => '%Y-%m-%d %H:%M:%S'); return DateTime->now( time_zone => $tz, formatter => $formatter, ) unless $date_string; Then later $dt_params{formatter} = $formatter; But that's an overhead for all dt_from_string calls. * add "T?" to $time_re, easy and efficient. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:02:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:02:43 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-4XfhVkmm1U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128631&action=edit Bug 29718: Support ISO8601 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:03:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:03:34 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-MXSSPOIjzV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Note that this patch fixes bug 29711. We would also remove all the extra output_pref calls from pl scripts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:04:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:04:33 +0000 Subject: [Koha-bugs] [Bug 27859] Marc export for search result In-Reply-To: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27859-70-HAcqGPAvxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124893|0 |1 is obsolete| | --- Comment #7 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128632&action=edit Bug 27859: marc search result export Enable export of staff interface search results in different marc formats. The export will be mailed to the configured mail address of the current user. This feature is Elasticsearch only. To test: 1) Apply patch 2) Run installer/data/mysql/updatedatabase.pl 3) Make sure the syspref EnableSearchResultMARCExport is enabled 4) Make sure the current user has the tools -> export_catalog permission 5) Make sure the current user has an email under your control set 6) Perform a search 7) Export the serach result by choosing a format under the "Export results" drop down 8) Verify that link(s) with exported data has been mailed to the provided emial 9) Revoke the permission in 3) and make sure exporting is no longer possible 10) Run tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:04:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:04:49 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-z1JmBFuE5m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Martin, Tomas, what do you think? I knew we wanted to be stricter, but here I have the feeling that this patch is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:04:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:04:49 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27992-70-PEE7VYnET6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:04:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:04:53 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27992-70-PCHvxrGTg2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128633&action=edit Bug 27992: Unit test Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:04:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:04:56 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27992-70-Drez94a8xn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127189|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128634&action=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. 8. Item is checked in and now seen as available Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:07:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:07:04 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-TtfpWvGF7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Fridolin Somers from comment #16) > Pushed to master for 22.05, thanks to everybody involved 🦄 This is causing failures on t/db_dependent/Circulation.t not ok 17 - CanBookBeRenewed tests # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1450. The given date (2021-12-15T16:06:30) does not match the date format (us) at /kohadevbox/koha/Koha/DateUtils.pm line 197. # Looks like your test exited with 11 just after 17. Dubious, test returned 11 (wstat 2816, 0xb00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:09:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:09:46 +0000 Subject: [Koha-bugs] [Bug 29719] New: onloan dates are cleared from items when importing and overlaying Message-ID: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Bug ID: 29719 Summary: onloan dates are cleared from items when importing and overlaying Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Check an item out to a paron 2 - Export the item using Tools->Export data 3 - Stage the record for import 4 - Match on 999c and replace items 5 - Import the batch 6 - View the record and note item is checked out and Available 7 - In the DB note the onloan value is now null -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:23:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:23:49 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29719-70-EgfOVvW0GD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:23:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:23:52 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29719-70-LjV2jHoW1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128635&action=edit Bug 29719: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:23:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:23:55 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29719-70-I10pDayloO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128636&action=edit Bug 29719: Do not clear onloan value when not passed in MARC To test: 1 - Check an item out to a paron 2 - Export the item using Tools->Export data 3 - Stage the record for import 4 - Match on 999c and replace items 5 - Import the batch 6 - View the record and note item is checked out and Available 7 - In the DB note the onloan value is now null 8 - Check in the item 9 - Apply patch 10 - Repeat 1-5 11 - View the record and note item is checked out 12 - In the DB note the onloan value matches the due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:24:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:24:25 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29719-70-zxb9BxlxQs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:35:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:35:02 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27208-70-h6sLYGdKzp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #14 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- We use an automated materials handling system. As items are returned through the sorter holds are trapped, sorted, checked in and a hold pickup slip is generated. This all happens via SIP outside of Koha. So for our library we would be looking for an automated setting to control the delay rather than having to re-checkin the item in Koha and manually select a notice delay for each item. I like the idea of a system pref such as the suggested PickupNoticeDelayMode and the PickupNoticeDelayDuration pref to set the the amount of delay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 17:59:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 16:59:10 +0000 Subject: [Koha-bugs] [Bug 29720] New: Allow per-user customization of table settings Message-ID: <bug-29720-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29720 Bug ID: 29720 Summary: Allow per-user customization of table settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Table settings are currently global. Per-user customization would be great! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 18:37:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 17:37:23 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-2wRf03a6zo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128637&action=edit Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Full history" tab Test plan: 1)Intranet: Make sure to have at least one Serial/Subscription created with the field 'location' filled in 2)Opac: Find your Serial/Subscription 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Full history' to see the detailed array 5)Apply patch and refresh your browser 6)The location is now above the array -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 18:38:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 17:38:05 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-LFnCeQs8Lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 18:50:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 17:50:06 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-Q5i8Z7MmMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 mathieu saby <mathsabypro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 18:50:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 17:50:16 +0000 Subject: [Koha-bugs] [Bug 29281] Allow per-user configuration default sort orders In-Reply-To: <bug-29281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29281-70-Pvv4HFZukd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29281 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow per-user |Allow per-user |configuration of table |configuration default sort |settings and default sort |orders |orders | --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Updating this bug to narrow its scope. I've filed bug 29720 for per-user table settings. It would also be good to allow per-user default sort behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:30:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:30:29 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-ueKs3LSZkI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:30:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:30:33 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-widcwNQPbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128584|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128638&action=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:31:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:31:01 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-Wd8ItLslRR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Owen Leonard from comment #15) > Created attachment 128591 [details] > Screenshot showing problems > > I'm seeing a couple of issues with the results, as shown in this screenshot: > > Is there supposed to be both an "Availability" and "Due date" column? I > think this misalignment is why the column search field under "Availability" > doesn't work. Woops I had missed one more instance of removing the Availability column. Should be good to test now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:47:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:47:55 +0000 Subject: [Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables In-Reply-To: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27403-70-dUnBvm4g7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #25 from Christopher Brannon <cbrannon at cdalibrary.org> --- If this is the same feature, I think we are seeing some issues with orphaned column headers and bleed over from other tabs (like seeing the checkout headers on the holds tab though part of the scrolling). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:52:30 +0000 Subject: [Koha-bugs] [Bug 29715] Duplicate entry 'IN-region' for key In-Reply-To: <bug-29715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29715-70-tyslTXCDZe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29715 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Resolution|--- |DUPLICATE CC| |fridolin.somers at biblibre.co | |m Status|NEW |RESOLVED --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- This is a duplicate of bug 29631 Thanks for the warning. *** This bug has been marked as a duplicate of bug 29631 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:52:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:52:30 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-RrFvElMiVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhby87 at gmail.com --- Comment #20 from Fridolin Somers <fridolin.somers at biblibre.com> --- *** Bug 29715 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:53:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:53:05 +0000 Subject: [Koha-bugs] [Bug 29721] New: automatic_renewal.pl dies if patrons choose SMS for digests and there is no SMS template defined Message-ID: <bug-29721-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29721 Bug ID: 29721 Summary: automatic_renewal.pl dies if patrons choose SMS for digests and there is no SMS template defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Have AutoRenewalNotices set to "according to patron messaging preferences" 2. Make some patron checkouts eligible from auto_renewal 3. Turn on SMS and Digest only Auto renewal messaging prefs for that patron 4. By default there is no SMS template for AUTO_RENEWALS_DGST, leave it that way 5. Run automatic_renewal.pl When it hits that patron you'll see: No circulation AUTO_RENEWALS_DGST letter transported by sms at /kohadevbox/koha/C4/Letters.pm line 633. no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see sample_notices.sql at /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl line 304. Can't use string ("1") as a HASH ref while "strict refs" in use at /kohadevbox/koha/C4/Letters.pm line 947. The job dies at this point. It would be better if it just skipped sending this patron a notice and carried on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 21:54:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 20:54:10 +0000 Subject: [Koha-bugs] [Bug 29710] Add cancellation reason to OPAC holds history In-Reply-To: <bug-29710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29710-70-UoKiIga6pg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29710 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:04:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:04:01 +0000 Subject: [Koha-bugs] [Bug 29699] cronjobs/patron_emailer.pl fails with Module Patrons In-Reply-To: <bug-29699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29699-70-QYauZg7Pu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29699 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Hi, > If the Module of the Notice is "patrons", I have this error: Indeed, it is because the module code is "members". You can see it in letter.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/feaeff330cfa9d49c99a0d70da0df87f5316652b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt#L151 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:05:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:05:13 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29514-70-aXGVlffdWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:10:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:10:48 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29513-70-lNJWbR9sjJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:16:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:16:23 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-iTnliEhbBL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #36 from Fridolin Somers <fridolin.somers at biblibre.com> --- I change to in dicussion to remember why I dont push to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:24:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:24:23 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-f9VxViVCYF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #12) > (In reply to Fridolin Somers from comment #11) > > File name is "js-patron-format.inc" but first line comment says > > "js-patron-title.inc" > > That's a typo. Ok then I remove this HTML comments. > > > I suggest we rename file to be closer to existing include "patron-title.inc" > > I followed the (already existing) js-format-date.inc file name. I think I > prefer it. But can adjust if required, not personally attached. OK I like that (its js-date-format.inc) And since method is $patron_to_html it makes sens to name js-patron-format.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:27:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:27:31 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-6TxXkBnuys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128639&action=edit Bug 29575: (RM follow-up) remove HTML comments Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:27:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:27:46 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-PqJQIt3ygA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:28:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:28:27 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29521-70-Q5zi9SQW0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:30:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:30:57 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-EpgKcwwrRk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:34:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:34:46 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-DF8B5eRigI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 128640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128640&action=edit Bug 28481: (RM follow-up) formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:35:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:35:45 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-jM8wLQoy2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 22:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 21:43:36 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-XawU4oFfEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #22 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Working on rebasing this against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:04:57 +0000 Subject: [Koha-bugs] [Bug 23149] Unsuspend button in staff interface is confusing In-Reply-To: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23149-70-2cw4HslYcT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28816 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:04:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:04:57 +0000 Subject: [Koha-bugs] [Bug 28816] Improve the display of multiple holds during hold process In-Reply-To: <bug-28816-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28816-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28816-70-LK2UYaHvnE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28816 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23149 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:05:03 +0000 Subject: [Koha-bugs] [Bug 23149] Unsuspend button in staff interface is confusing In-Reply-To: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23149-70-3VwG6B13wC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28377 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:05:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:05:03 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-gCWfaPS0Qy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:06:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:06:12 +0000 Subject: [Koha-bugs] [Bug 23149] Unsuspend button in staff interface is confusing In-Reply-To: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23149-70-HnzKMdLGOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Indeed. Display in catalogue should be like in patrons module : - Use "Resume" instead of "Unsuspend" - Use a modal for date entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:18 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-5nIOREXHkG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:20 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-vU5yvx3DPH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 --- Comment #34 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:23 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-AXhbSz3g2X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:25 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-wSCq88drfq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 --- Comment #11 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:28 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-zDABKJQt1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:30 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-3rVxc2mIYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:32 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-l1ZHEGGLTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:34 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-HwhMR9wqzJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:37 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-K1u2u7x4eU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 16 23:13:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 22:13:39 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-H738D8bl58@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 00:09:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Dec 2021 23:09:44 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-pzFXpdIWsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers at biblibre.com> --- O crap, I see it Looks like it comes from test on no_auto_renewal_after_hard_limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 01:23:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 00:23:40 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-ReI3KiQJLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 01:27:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 00:27:40 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-hxvsZJ9DOe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Version(s)|22.05.00 | released in| | --- Comment #19 from Fridolin Somers <fridolin.somers at biblibre.com> --- I revert from master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 01:27:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 00:27:53 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-e5jIoAU7TK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 01:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 00:28:01 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-yjilPbAu27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 01:38:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 00:38:12 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-qL2Ms1YYJD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #2 from AspenCat Team <aspencatteam at clicweb.org> --- I was excited about the matching rule idea, so I tried it in the current version 21.05 (though probably would work with earlier records). I edited an existing record and added a 942$9 subfield with yes and a description of protect this record. Although I think any data would work. I exported the edited record, then deleted the 942$9 subfield (which would be how our vendor and migration records would appear). I then tested against two matching rules. One with just isbn as match point. The other with isbn as a match point, but made the 942$9 as required match point. The one with just isbn as match point matched. The one with the additional match point of 942$9 did not match. Therefore, I think this would work for protecting a bib record from overlay on migration records(though it wouldn't protect from overlay of z39.50 search). Thanks for the match point suggestion! For us, this would meet our needs without further development. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 02:18:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 01:18:08 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-7bP7v3Rzwx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fridolin Somers from comment #19) > I revert from master This bug made things stricter. It highlighted we have fragile spots when it comes to date handling. It is not a bad thing per se on the master branch. But it is not bad to revert anyway. There are bugs in which Jonathan proposed alternative solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:13:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:13:16 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-taqBcPgRlp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:13:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:13:26 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-d5AhHGZh2Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:13:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:13:36 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-uZhp87dxSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:13:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:13:55 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-CtD6C162lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #23 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128641&action=edit Bug 23291: Patron batch modification based on SMS number This patch is based on the patchset on bug 24019. It enabled librarians to list SMS numbers (one per line) or upload a file of SMS numbers, just like they can currently do with borrowernumbers or card numbers. Test plan: 1. Apply patch 2. Restart services 3. Create a patron list in: Tools > Patrons lists 4. Navigate to Tools > Batch patron modification 5. Observe there are 4 tabs: 'By card number', 'By SMS number', 'By borrowernumber', 'By patron list' 6. Test each option for batch patron modifications: - By cardnumber file - By cardnumber list - By SMS number file - By SMS number list - By borrowernumber file - By borrowernumber list - By patron list 7. In all of the above cases the correct patrons should be retrieved by Koha, and modified. 8. Test uploading a SMS number shared by multiple patrons and confirm all patrons with that SMS number are returned 9. Confirm the 'order of operations' for card numbers, SMS numbers and borrowernumbers is followed: - If a file is uploaded AND a list of number submitted then the list of numbers will be used 10. Confirm batches are only submitted from the active tab - If you upload a file OR input a list SMS numbers, and then switch to a different tab and input a list of borrowernumbers then the SMS numbers originally inputted should be ignored. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:25:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:25:34 +0000 Subject: [Koha-bugs] [Bug 23291] Allow selecting patrons by smsalertnumber in batch patron modification In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-hd27wv1aUn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #24 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hi all, I've merged the 3 previous commits and rebased this patchset against master. I tried making this patchset, and it's test plan, as close as possible to bug 23291 Ready to test again! Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:27:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:27:32 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-5Ki7me1xid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:27:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:27:39 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-qgyg3UuQ08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128585|0 |1 is obsolete| | --- Comment #156 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128642&action=edit Bug 15326: Using AdditionalContents for custom pages on OPAC This page utilises the Additional Contents feature to add custom pages to the staff client and the OPAC in the user's desired language. To test: 1. Apply patch and restart services 2. In the staff client, go to Tools, then go to the new 'Pages' page 3. Add a new page to display on both the staff client and OPAC. 4. Notice the 'View' button in the Actions column. This button should only show when viewing Pages, it should not show when viewing HTML customisations or News. Test that the main View button links you to the page in the staff client. Test that clicking the arrow shows a button to view the page in the OPAC, and clicking it opens the OPAC in a new tab. 5. When viewing your new page in the staff client, confirm a Pages navigation shows in the left navigation. 6. When viewing your new page in the OPAC, confirm a Pages navigation shows in the left navigation. Confirm pages are also linked in the masthead links (i.e. with Advanced search and Libraries etc). 7. Confirm that any pages made for the staff client only do not show in the OPAC, and that any pages made for the OPAC only do not show in the staff client. 8. Pages that can be viewed on the staff client will also show under the Pages link on the Tools main page. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:28:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:28:30 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-ZCfQFzCTpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement utilises release notes| |the Additional Contents | |feature to add custom pages | |to the staff client and the | |OPAC in the user's desired | |language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:31:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:31:33 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-Il9uBlxuIn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow selecting patrons by |Patron batch modification |smsalertnumber in batch |based on SMS number |patron modification | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:48:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:48:37 +0000 Subject: [Koha-bugs] [Bug 29722] New: Add some diversity to sample quotes Message-ID: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Bug ID: 29722 Summary: Add some diversity to sample quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Currently all of the sample quotes are by US Presidents and were all said by white men. It would be great to see some diversity in these sample quotes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:49:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:49:56 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-sNTIYvVlpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #24 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #21) > This method exists, and is C4::Auth::psgi_env > And this patch exists, on bug 27555. Why are we duplicating work? It looks like I avoided C4::Auth::psgi_env at the time since it didn't actually work: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27555#c1 (CGI::Emulate::PSGI strips out environmental variables starting with "psgi") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:50:28 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-1LzTgDI246@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:50:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:50:31 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-LgnmODOLUo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 128643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128643&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 03:51:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 02:51:04 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-XJBYNSMCwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Text to go in the| |This patch adds sample release notes| |quotes from women, women of | |colour, trans women, Black | |and Indigenous women, and | |people who weren't US | |Presidents! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 04:01:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 03:01:16 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-76FxhINfBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #25 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #23) > > I cannot PQA without a follow-up bug report and patch. Could you elaborate a bit? Do you mean a follow-up bug report that depends on this one? And in that bug report one would replace C4::Auth::psgi_env with C4::Context->is_psgi_or_plack() (or vice versa) and check that it doesn't cause a regression in the multiple different calls to C4::Auth::safe_exit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 08:01:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 07:01:33 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-fJxjM9WnqW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #36) > I change to in dicussion to remember why I dont push to master. Please explain what you are doing here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 08:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 07:54:50 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-RSP8BZEqom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #19) > I revert from master Ideally we prefer to not revert but fix. It will get messy if you revert every time jenkins is failing after a push :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:08:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:08:04 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29711-70-ihJ75vFK0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29718 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:08:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:08:04 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-C2fLWSS24Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29711 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:09:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:09:41 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-EQLp1sbJlk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Nick Clemens from comment #17) > (In reply to Fridolin Somers from comment #16) > > Pushed to master for 22.05, thanks to everybody involved 🦄 > > This is causing failures on t/db_dependent/Circulation.t > > not ok 17 - CanBookBeRenewed tests > # Failed test 'CanBookBeRenewed tests' > # at t/db_dependent/Circulation.t line 1450. > The given date (2021-12-15T16:06:30) does not match the date format (us) at > /kohadevbox/koha/Koha/DateUtils.pm line 197. > # Looks like your test exited with 11 just after 17. > Dubious, test returned 11 (wstat 2816, 0xb00) This one is fun. We are storing a DT into a varchar (rule_value) and so the DT object is stringified using ISO 8601. And yes, this is closely related to bug 29718. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:15:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:15:48 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29530-70-aq2aarm52V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128172|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128644&action=edit Bug 29530: Fix handling of NumSavedReports preference in reports table This patch updates the way the NumSavedReports preference value is used on the saved reports page so that the setting is correctly incorporated into the DataTable. The patch also expands the description of the NumSavedReports preference in order to clarify the expected behavior when no value is saved. To test, apply the patch and go to Administration -> System preferences and note the value of NumSavedReports. - Go to Reports -> Use saved. - Confirm that the first page of saved reports shows the number specified in NumSavedReports. - In the "Show" dropdown menu, confirm that the number from NumSavedReports is preselected by default. - Expand the dropdown menu to confirm that the NumSavedReports number is positioned sequentially with the default values. For example, if NumSavedReports = "78," the menu options should be "10, 20, 50, 78, 100, All". - Test with various values of NumSavedReports. A blank value should result in the "All" option being selected. A non-numeric or non-positive value should result in the default set of options being used ("10, 20, 50, 100, All"). Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:16:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:16:07 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29530-70-LHhIH0lkQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29488 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Rebased on top of bug 29488. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 [Bug 29488] NumSavedReports system preference doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:16:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:16:07 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29488-70-7aaJzmj2g1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 [Bug 29530] When NumSavedReports is set, show value in pull down of entries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:45:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:45:58 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-zARoDtWhdb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I really love this, thx Aleisha! I had tried to get people to send me quotes at one of the GBSD days, but sadly that didn't work out. Glad to see more diversity, will try to test (or better QA). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:48:47 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-fGuhISGR2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx for the reply and taking my idea further! Could you share your matching rule setup maybe as a screenshot? I always had a bit of trouble with the match points. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:48:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:48:59 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-pMfi2YCoyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:49:07 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-wKQFMdJXEF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:50:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:50:14 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-4GitGQ731T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This just takes too much time. Without the prospect of getting someone to sign off. Closing the report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:50:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:50:14 +0000 Subject: [Koha-bugs] [Bug 29251] Local use sysprefs: Language list does not work In-Reply-To: <bug-29251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29251-70-y6cOls1Vqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29251 Bug 29251 depends on bug 29245, which changed state. Bug 29245 Summary: Fix the parameters of getTranslatedLanguages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:50:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:50:55 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-BNzOtX8NCT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29251 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29251 [Bug 29251] Local use sysprefs: Language list does not work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:50:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:50:55 +0000 Subject: [Koha-bugs] [Bug 29251] Local use sysprefs: Language list does not work In-Reply-To: <bug-29251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29251-70-nceBhEQ050@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29251 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29245 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 [Bug 29245] Fix the parameters of getTranslatedLanguages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:51:03 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-eDTzqyA6P4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29040 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 [Bug 29040] Uninitialized value warning in Languages.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:51:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:51:03 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-GHg7WrtYN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29245 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 [Bug 29245] Fix the parameters of getTranslatedLanguages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:52:59 +0000 Subject: [Koha-bugs] [Bug 29246] We should rename the prefs 'template' and opacthemes In-Reply-To: <bug-29246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29246-70-0UeQSajpSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- See bug 29245. Abandoning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:53:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:53:53 +0000 Subject: [Koha-bugs] [Bug 29246] We should rename the prefs 'template' and opacthemes In-Reply-To: <bug-29246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29246-70-df3M9cMyDz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:57:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:57:16 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-H7J9KSne1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:57:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:57:49 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-jXCMgkwIdN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128582|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 128645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128645&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian <christian.stelzenmueller at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:57:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:57:53 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-rATYGuWJnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128583|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 128646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128646&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian <christian.stelzenmueller at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 09:57:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 08:57:57 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17748-70-tyHw1np5m0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128638|0 |1 is obsolete| | --- Comment #20 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 128647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128647&action=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. Signed-off-by: Christian <christian.stelzenmueller at bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:09:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:09:21 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29336-70-1t5VAGrysR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #21) > This one should be pushed along with bug 29390 in my opinion. It can go on its own. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:19:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:19:20 +0000 Subject: [Koha-bugs] [Bug 29723] New: Add a "Configure table" button for KohaTable tables Message-ID: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Bug ID: 29723 Summary: Add a "Configure table" button for KohaTable tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org We could have a "Configure table" link/button on the table that are a "KohaTable" table that can be configurable in the administration area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:19:34 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29723-70-NUrRaWy9qj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Depends on| |29648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:19:34 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29648-70-ZFXtvRq87I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 [Bug 29723] Add a "Configure table" button for KohaTable tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:21:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:21:22 +0000 Subject: [Koha-bugs] [Bug 29314] Move some OpenURL code to Koha::Biblio In-Reply-To: <bug-29314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29314-70-4yWOxGkwBK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29314 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- ping Julian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:22:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:22:56 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29723-70-KzX1w5fae8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:22:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:22:59 +0000 Subject: [Koha-bugs] [Bug 29723] Add a "Configure table" button for KohaTable tables In-Reply-To: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29723-70-6tFnQqIC4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29723 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128648&action=edit Bug 29723: Add a "Configure table" button for KohaTable tables This patch suggests to have a "Configure table" button when a table can be configured in the "Table settings" administraition area. Test plan: Go to different views where the table can be configured (you an exhaustive list on bug 29648), notice the "Configure table" button (if you have the 'manage_column_config' subpermission. Note that the link is correct but the scrollbar is not adjusted at the correct position. Maybe we could improve that switching to the bootstrap accordion plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:25:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:25:32 +0000 Subject: [Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables In-Reply-To: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27403-70-ihuHm3nWCr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Christopher Brannon from comment #25) > If this is the same feature, I think we are seeing some issues with orphaned > column headers and bleed over from other tabs (like seeing the checkout > headers on the holds tab though part of the scrolling). Hi Christopher, can you detail a bit more? Which Koha version? On which view are you seeing that? /circulation.pl?borrowernumber=5 on the "X checkout(s)" tab? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:28:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:28:38 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-IUqblGb9km@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Cook from comment #25) > (In reply to Jonathan Druart from comment #23) > > > > I cannot PQA without a follow-up bug report and patch. > > Could you elaborate a bit? > > Do you mean a follow-up bug report that depends on this one? And in that bug > report one would replace C4::Auth::psgi_env with > C4::Context->is_psgi_or_plack() (or vice versa) and check that it doesn't > cause a regression in the multiple different calls to C4::Auth::safe_exit? Yes, we should use a single method for the same thing. Here you introduce is_psgi_or_plack then we should use it from where psgi_env and other similar checks exist. Either here or a separate bug report. `git grep "psgi.*ENV"` shows the different occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:35:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:35:50 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29458-70-qroQ7Ef01s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #3) > Looks way better :D > > In opac-auth, with should also fix : > You may register here. > instead of > Don't have an account? Register here. > > Maybe in another bug. Please open another bug. Can we get this one further please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:58:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:58:56 +0000 Subject: [Koha-bugs] [Bug 29144] Make branches.opac_info suitable for multi language use In-Reply-To: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29144-70-QlM1TEIaxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 10:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 09:59:38 +0000 Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28999-70-JAIgjwnlL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:00:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:00:00 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: <bug-29578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29578-70-ToiISSEZxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #10 from Andreas Roussos <a.roussos at dataly.gr> --- (In reply to David Nind from comment #9) > Hi Andreas and Thibaud. > > From your screenshots I can see that what is described is happening, but I > still can't reproduce it. > > I was testing on the latest master with Zebra koha-testing-docker. > > Are there any specific system preferences that need to be set, or any other > configuration that needs to be done? > > David Hi David, Thank you for your continued interest in this bug report! ;-) The Koha instance I used was brand new, without any specific system preferences applied to it (I actually double-checked this today via the Log viewer under Tools which showed no SysPref modifications at all). It's a generic MARC21 instance w/ Zebra, nothing special about it AFAICT. This is a long shot, but could it be that -- somehow -- the patch is already applied to your docker instance when you launch it, therefore you are always seeing the correct behaviour w.r.t. the highlighter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:00:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:00:02 +0000 Subject: [Koha-bugs] [Bug 28999] Add Koha::AllowList and DenyList In-Reply-To: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28999-70-59dHfYgFZz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Waste of time? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:04:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:04:13 +0000 Subject: [Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing In-Reply-To: <bug-12872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12872-70-p3XNXdZhEB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:22:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:22:24 +0000 Subject: [Koha-bugs] [Bug 29029] Koha::Object - add filter method based on column sets In-Reply-To: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29029-70-iYBY8dnhHf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29029 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Wasting time? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:26:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:26:53 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-qWtMLkVR54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128649&action=edit Bug 29457: Generic warning at upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:27:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:27:12 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-8kVa04HJKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:28:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:28:01 +0000 Subject: [Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob In-Reply-To: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27344-70-tQqVh96ItT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:28:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:28:30 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-E7xIPWexOh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, how about that.. a super super generic note at upgrade telling people to come and read about the bug here.. no link (in case we ever switch from bugzilla), no counts (as they may well be incorrect if the update has already been run at some point) and a small note to say you might just want to ignore it entirely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:39:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:39:02 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-h2WdWzQeXN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:39:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:39:06 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-2mEiX1jsIi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128207|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128650&action=edit Bug 29457: Pass context borrowernumber This patch updates the call to cancel such that we pass the currently logged in users borrowernumber instead of their userid. Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:39:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:39:10 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-PWfpG4H1po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128649|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128651&action=edit Bug 29457: Generic warning at upgrade Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended: Adding exec flag and two dots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:39:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:39:49 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-81H4pA5Njw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This is where we ended up discussing it for 23th time ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:40:22 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-wrMLRCGZlK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I had a feeling this might throw a few issues.. I kinda hoped to have it pushed and help deal with the repercussions.... or that we'd team together to try and spot repercussions and fix them before the push. Honestly.. I thought I'd run the whole test suit though, so that's my bad.. I should have got the tests all passing first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:41:21 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-7vlp4Ayuiq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prior to this patch |Prior to this patch release notes|inadvertently the field |inadvertently the field |borrowers.userid was used |borrowers.userid was used |to fill |to fill |accountslines.manager_id. |accountslines.manager_id. |This should have been |This should have been |borrowernumber. |borrowernumber. | | |This |This |report fixes that. The |report fixes that and |dbrev will count the number |prints a generic warning. |of missing or bad | |manager_id's in | |cancellation records and | |report them. It refers to | |this report for optional | |sql updates to fix or clear | |the records. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 11:42:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 10:42:04 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-zGH2flUUK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #31) > NOTE: This comment is referred to from the db revision of this report ! NOTE: This is no longer the case :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 12:13:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 11:13:46 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28943-70-0FlISTJIi0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 12:13:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 11:13:51 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28943-70-2ObAXjOYnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126038|0 |1 is obsolete| | --- Comment #13 from David Nind <david at davidnind.com> --- Created attachment 128652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128652&action=edit Bug 28943: Lower the risk of accidental patron deletion If you do not use a temporary self registration patron category, you should actually make the preference PatronSelfRegistrationExpireTemporaryAccountsDelay empty. As the comment in sysprefs.sql already said, we should not let a zero value in the pref delete patrons too. The module is changed now, the test adjusted and the description of both related sysprefs modified. Test plan: Run t/db_dependent/Members.t Check in Administration the two adjusted OPAC pref descriptions. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 12:45:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 11:45:11 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-kcVHeiOFWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Right.. I agree with your patch.. mostly. In the RFC3339 regex we actually do '([Tt\s])'.. Whilst I think ISO was slightly more strict.. i.e 'T' now and '\s' before (So I agree to allowing for both).. should we also support lower case 't' ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 12:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 11:50:28 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-5XW9rCSvNP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Also.. being slightly picky.. I'd update the comment lines that explain the regex's.. # iso or sql format are yyyy-dd-mm[ hh:mm:ss]" and # Add the faculative time part [hh:mm[:ss]] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 12:55:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 11:55:09 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-OeDR5PB7li@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Also, interestingly.. I note that for ISO I don't believe 'am/pm' is actually allowed.. all times should be 24 hour. That's an oversight I hadn't spotted before.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:15:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:15:04 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-xhSmEptj6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Also.. to properly adhere to ISO we should also optionally support timezone (with it defaulting to "local" when one isn't passed). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:21:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:21:22 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-8DuZ8f71DQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128631|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128653&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:21:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:21:26 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-YBizq5MJsW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128654&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:22:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:22:50 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-l4Xb6TVeYS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|dt_from_string should fail |dt_from_string should fail |if passed and rfc3339 |if passed an rfc3339 |formatted string when 'iso' |formatted string when 'iso' |is selected as dateformat |is selected as dateformat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:30:34 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29336-70-H3j8SoEBdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:30:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:30:44 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29336-70-okLWazI9rk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127169|0 |1 is obsolete| | --- Comment #23 from David Nind <david at davidnind.com> --- Created attachment 128655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128655&action=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:31:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:31:12 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29336-70-qgGISq4dYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127170|0 |1 is obsolete| | --- Comment #24 from David Nind <david at davidnind.com> --- Created attachment 128656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128656&action=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:32:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:32:32 +0000 Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response In-Reply-To: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23548-70-JGf7RKNNti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 --- Comment #1 from David Gustafsson <glasklas at gmail.com> --- Created attachment 128657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128657&action=edit Bug 23548: Set AQ to empty when item not exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:33:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:33:08 +0000 Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response In-Reply-To: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23548-70-iMCUh4BFUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 David Gustafsson <glasklas at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |glasklas at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:38:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:38:58 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-rdOvEZELJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128658&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:43:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:43:34 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-z1yXjxiSLv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 13:44:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 12:44:50 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-qiiHgEt9K2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Clearly, we still need to add some additional unit tests to prove the new support. Whilst testing I took the following set of strings to test the regex's against: 2020-12-09T16:09:53+00:00 2020-12-09 16:09:53+00:00 2020-12-09T 16:09:53+00:00 2020-12-09t16:09:53+00:00 2020-12-0916:09:53+00:00 2020-12-09 16:09:53+00:00 2020-12-09 16:09:53Z 2020-12-09 04:09:53 pm 2020-12-09 04:09:53 am 2020-12-09 04:09:53 2020-12-09 04:09:53am+00:00 # Fails as it should 2020-12-09 04:09:53+00:00am # Fails as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:01:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:01:50 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29336-70-qq9ON4lA3y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #25 from David Nind <david at davidnind.com> --- Testing notes (koha-testing-docker): - Access the database and use describe <table-name>; to show current definitions - See the database update for the table names - Run the tests - should pass - Apply the patch - Run databaseupdate - Access the database again and see that the definitions are updated - reset_all - Access the database again and see that the definitions are updated - Run the tests again - should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:10:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:10:12 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-BKgdbf0Rou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.08 released in| | Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:10:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:10:19 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-fwGDzNiOyy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:33:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:33:07 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-3ftHyo0Fw9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:37:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:37:39 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-l0keOQm6w6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:40:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:40:14 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-GR87s2n9IP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:41:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:41:12 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29611-70-68AxLPDnz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:43:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:43:33 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-6gNrZRvq5h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:45:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:45:03 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-DUGaWeTo9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:54:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:54:23 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28153-70-DEiMhX0VyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.11.01 released in| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:58:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:58:10 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-BH32iQKhVD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- This works on additem.pl and neworderempty.pl but it fails on serials-edit.pl - I don't get the branchcode - though that page works before this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:59:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:59:02 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-PKXxCRo7Ji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Andreas Roussos <a.roussos at dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128579|0 |1 is obsolete| | --- Comment #3 from Andreas Roussos <a.roussos at dataly.gr> --- Created attachment 128659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128659&action=edit Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Andreas Roussos <a.roussos at dataly.gr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:59:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:59:26 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-5PVB3w348w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 14:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 13:59:27 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15157-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15157-70-Smnx4jL9IV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Bug 15157 depends on bug 15156, which changed state. Bug 15156 Summary: Get all Borrowers with pending/unpaid fines/accountlines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:01:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:01:05 +0000 Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory patron data differently between OPAC registration and modification In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13188-70-mboW9fWSLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:09:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:09:38 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-fyNOkbuEtP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:12:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:12:21 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-LIcII9o5Pl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Tomas: Add some patches ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:13:48 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-Mx3aR6x4St@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #43) > Tomas: Add some patches ;) Good idea :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:14:33 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28656-70-9ZPyPpVNLZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27946 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:14:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:14:33 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-FMunHzIrln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28656 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 [Bug 28656] Cancellations should be allowed on paid/partially paid debts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:15:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:15:46 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-OqsCmdNICq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128660&action=edit Bug 27946: Add article_requests.debit_id and ARTICLE_REQUEST account debit type Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:16:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:16:00 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-0owykoTOFT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #46 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128661&action=edit Bug 27946: DBIC schema changes [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:16:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:16:11 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-kQwqTuONhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #47 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128662&action=edit Bug 27946: Add article request fee to circulation rules This patch adds a new circulation rule: article requests fee. It can be set per library and category. To test: 1. Try setting sdifferent numeric values, change, and delete them => SUCCESS: Things work as expected 2. Make sure rules are loaded correctly when re-entering the circ rules page => SUCCESS: All good 3. Verify the data on the DB is stored as it should on each of your tests: $ koha-mysql kohadev > SELECT * FROM circulation_rules \ WHERE rule_name='article_request_fee'; => SUCCESS: All good (remember NULL => 'All' in the UI) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:16:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:16:21 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-Br7ArhMqjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128663&action=edit Bug 27946: Article request fee methods in Koha::Patron This patch adds article_request_fee() and add_article_request_fee_if_needed() methods to Koha::Patron. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:16:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:16:27 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-hK2lfu4An5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128664&action=edit Bug 27946: Make Koha::ArticleRequest->request add a fee if required This patch makes the ->request method add a fee for the patron if required. It relies on methods defined in Koha::Patron for the task. The debit line is linked to the AR if applies. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:16:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:16:34 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories configuration In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-XHpuJjlmMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #50 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128665&action=edit Bug 27946: Add UI handling of AR fees This patch: - Adds a notice about the fee to be charged to the patron (staff and OPAC) - Adds the right UI description for ARTICLE_REQUEST_FEE debit types in the UI. To test: 1. Have some article request fee rules 2. Play with placing an article request in OPAC and staff => SUCCESS: You see a message about the fee => SUCCESS: The fees are correctly applied to the patron 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:17:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:17:37 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29506-70-zzg0nPGy66@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:17:40 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29506-70-MPCuXQ2R17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127754|0 |1 is obsolete| | Attachment #127755|0 |1 is obsolete| | Attachment #127756|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128668&action=edit Bug 29506: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:17:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:17:43 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29506-70-agxZMrhpJs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128669&action=edit Bug 29506: Make objects.search call search_limited if present This patch makes objects.search implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:17:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:17:46 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29506-70-F4mHmYJMUz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128670&action=edit Bug 29506: (follow-up) Adapt GET /patrons This patch makes GET /patrons rely on this new behavior from the objects.search helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:19:44 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-Js81rs6Zeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a charge per article |Add a charge per article |request to patron |request to patron |categories configuration |categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:20:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:20:58 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29508-70-L6T2Ldm1yh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:21:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:21:03 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29508-70-GkFy9KOIyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127770|0 |1 is obsolete| | Attachment #127771|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128671&action=edit Bug 29508: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:21:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:21:07 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29508-70-NvK7BrtJnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128672&action=edit Bug 29508: Make GET /patrons/:patron_id use Koha::Patrons->search_limited This patch makes the route return 404 if the user is not allowed to see the requested patron information. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: The code doesn't respect limits 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:37:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:37:57 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29436-70-3zOU2TUQBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:38:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:38:00 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29436-70-FKw7jCTWWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127824|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128673&action=edit Bug 29436: ES mappings not saved if zebra is configured The mappings must be editable even if ES is not turned on yet. Using a separate array to store the errors as we are testing for $@ || @messages. There is still something wrong that should be improve, but this patch should be safe for backport. Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:39:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:39:32 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22038-70-oRgv0n7lW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:39:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:39:37 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22038-70-dn9iu3iL1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122350|0 |1 is obsolete| | --- Comment #8 from Florian <florian.bontemps at biblibre.com> --- Created attachment 128674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128674&action=edit Bug 22038: Fix excel export if CurrencyFormat is FR DataTables excel export is broken if number decimal separator is a comma. Test plan: 1 - Set syspref CurrencyFormat to US 2 - Export as excel a table with decimal numbers, patrons list with fines for example. 3 - Open in libreoffice or excel, numbers are ok. 4 - Set syspref CurrencyFormat to FR 5 - Export and open again, number are wrong 25,10 is imported as 2510 6 - Apply patch 7 - Redo 1 to 4 8 - Excel export, number is 25,10 Signed-off-by: hakam <hakam at inlibro.com> Signed-off-by: Florian Bontemps <florian.bontemps at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:48:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:48:03 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-3lQPowroD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:49:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:49:52 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-G6NrUqLVoV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:51:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:51:25 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22038-70-VKyT3Rpd0i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om --- Comment #9 from Florian <florian.bontemps at biblibre.com> --- The patch fixed the problem (and also worked for CH currency btw), but it did introduce a weird but harmless glitch : for FR and CH currency, any sum higher than 999.99 is written from the left side of their cell rather than the usual right. For reference, I used LibreOffice calculator on Linux(ubuntu). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:53:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:53:04 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-wJoKn4H1hw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:54:25 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27266-70-nuPisQrFdA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:54:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:54:25 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-2UPAaPJFvS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Bug 3150 depends on bug 27266, which changed state. Bug 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:54:26 +0000 Subject: [Koha-bugs] [Bug 29421] Remove C4::Biblio::GetBiblioData In-Reply-To: <bug-29421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29421-70-P7VdQogOgd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 Bug 29421 depends on bug 27266, which changed state. Bug 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:54:26 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-b8LOg9jTXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Bug 29652 depends on bug 27266, which changed state. Bug 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:54:27 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-kcpcNJUy6k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Bug 29690 depends on bug 27266, which changed state. Bug 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:55:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:55:26 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-UXnLdxTD9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:55:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:55:33 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-orUbdcY0V9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128571|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128675&action=edit Bug 29684: fix warn about not found file js/locale_data.js Value of 'lang' unexpectedly was set to 'default', to prevent it, the feature was added to detect 'lang' getting overlaid in template and prevent + warn the developer about it. To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:57:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:57:58 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-XKKMBik00f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:59:36 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-AbV8QtOGE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:59:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:59:37 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28854-70-pPL9wVKVT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 29575, which changed state. Bug 29575 Summary: Add a JS render function equivalent of the patron-title.inc TT include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:59:38 +0000 Subject: [Koha-bugs] [Bug 28874] We need javascript equivalents to many of our TT plugins In-Reply-To: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28874-70-Bjplmc17uZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28874 Bug 28874 depends on bug 29575, which changed state. Bug 29575 Summary: Add a JS render function equivalent of the patron-title.inc TT include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 15:59:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 14:59:38 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29275-70-TNDw83DMHN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Bug 29275 depends on bug 29575, which changed state. Bug 29575 Summary: Add a JS render function equivalent of the patron-title.inc TT include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:04:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:04:21 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29498-70-H9sjPRmv7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:04:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:04:25 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29498-70-JjOHtSjw8i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127705|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128676&action=edit Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:04:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:04:48 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-cdBaTITBpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:05:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:05:10 +0000 Subject: [Koha-bugs] [Bug 28377] Use the API to suspend/resume holds In-Reply-To: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28377-70-uUOP1dvQD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:05:11 +0000 Subject: [Koha-bugs] [Bug 28521] [OMNIBUS] Replace svc scripts In-Reply-To: <bug-28521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28521-70-FrdFrbymva@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28521 Bug 28521 depends on bug 28377, which changed state. Bug 28377 Summary: Use the API to suspend/resume holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:09:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:09:22 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29498-70-Cq0MhVEDEE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |mtj at kohaaloha.com, | |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Trivial change that prepares the ground for upgrading Mojolicious (in the works). Works as expected, passes the QA checks. Straight QA as it will hardly find a good soul to QA it sooner than later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:19:52 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29704-70-DBzSVb58Ck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:19:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:19:52 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28153-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28153-70-FJw1wB0RgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 [Bug 29704] Holds reminder emails should allow configuration for a specific number of days -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:20:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:20:16 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21729-70-o1DPhCuxvz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com Status|Signed Off |Failed QA --- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Any plans on adding the missing tests soon? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:24:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:24:46 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-utYqthCSXr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:26:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:26:30 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-VZfQAGJy2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:26:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:26:33 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29680-70-8wBdXHKptW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128659|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128677&action=edit Bug 29680: Change markup to correct button radius This patch alters the markup around the "Show SQL/Hide SQL" buttons so that they are not styled as if they are a button group. To test, apply the patch and run an SQL report. The "Show SQL code" button should be styled consistently with other single buttons in the toolbar. Click it to test that the "Hide SQL code" button is also correct. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Andreas Roussos <a.roussos at dataly.gr> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:29:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:29:11 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-Wtzm86CbmN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128098|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128678&action=edit Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:29:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:29:46 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-9qea4r60a2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:32:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:32:15 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-vfi9ZdmuMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128637|0 |1 is obsolete| | --- Comment #3 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128679&action=edit Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:53:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:53:22 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29704-70-gMfxia9baZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128680&action=edit Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:54:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:54:12 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-itWOS5zymY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:54:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:54:14 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-XqA8PUjq02@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:54:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:54:39 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-RdHMsChXdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128681&action=edit Bug 29553: Fix crash on undefined notforloan value Test plan: Set item level itypes to biblioitems. Find a record with itemtype NULL, having an item. Place a hold. Without this patch, it crashes. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: ThibaudGLT <thibaud.guillot at biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:54:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:54:43 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-jEVeqs2vG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128682&action=edit Bug 29553: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:54:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:54:49 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-UUTTDaugcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128683&action=edit Bug 29553: (QA follow-up) Check defined instead of evaluating as boolean Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:55:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:55:19 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29553-70-RfGKpmpBir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:55:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:55:57 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-ZXSzCNY3WA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:58:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:58:56 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-otmeFxbnpN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 16:58:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 15:58:59 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-teWmXw3E5c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:00:50 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-STQZ3Swwg7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:00:53 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-oVtl3XCKEc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:01:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:01:34 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-YHFlNCugOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128684&action=edit Bug 28977: Add GROUP_CONCAT to some of the selected columns To get the 'Most circulated items' report to run in ONLY_FULL_GROUP_BY Sql mode. Test plan: Turn on strict_sql_modes ( make sure <strict_sql_modes> is 1 in KOHA_CONF ) Go to Reports -> Most circulated items submit the form. Without the patch you get an error like: CGI::Compile::ROOT::usr_local_koha_master_reports_cat_issues_top_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: Expression #4 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'koha_main_v4.items.itemcallnumber' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by [for Statement "SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS `RANK`, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND old_issues.issuedate > '2020-08-03' AND old_issues.issuedate < '2021-05-17' AND old_issues.returndate > '2020-08-27' AND old_issues.returndate < '2021-06-01' AND old_issues.branchcode like '403' AND items.itype like 'F' AND ccode like 'FIC' AND borrowers.categorycode like 'ST' group by biblio.biblionumber order by `RANK` DESC"] at /usr/local/koha_master/reports/cat_issues_top.pl line 67 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 With the patch you will see the report results view. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:01:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:01:55 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-OUZkE8YTXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:02:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:02:30 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-YIiPoROhuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:04:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:04:19 +0000 Subject: [Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables In-Reply-To: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27403-70-lGSsD4DTYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #27 from Christopher Brannon <cbrannon at cdalibrary.org> --- Created attachment 128685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128685&action=edit Floating header checkout bleed on holds tab When on the holds tab in circulation.pl or moremember.pl, when you scroll down and just switch over to the floating header, the checkouts header appears on top of the holds header for a little bit until you scroll down further. I have seen this demonstrated on other systems, and have seen other tabs bleed over as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:07:42 +0000 Subject: [Koha-bugs] [Bug 29724] New: Different authority usage count Message-ID: <bug-29724-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29724 Bug ID: 29724 Summary: Different authority usage count Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: fribeiro at keep.pt When searching for authorities, in the results table, the column "Used in" contains a different value from the counter shown at the details page of that authority. The first count comes from https://github.com/Koha-Community/Koha/blob/v21.05.07/Koha/SearchEngine/Elasticsearch/Search.pm#L263 The second one comes from https://github.com/Koha-Community/Koha/blob/v21.05.07/Koha/Authorities.pm#L55 This last subroutine may return an incorrect value because the querybuilder adds a * at the end. Eg. "query": "(koha-auth-number:722*)" Maybe we can replace simple_search_compat with count_auth_use -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:12:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:12:17 +0000 Subject: [Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables In-Reply-To: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27403-70-GEbPYhaVkD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #28 from Christopher Brannon <cbrannon at cdalibrary.org> --- Ignore the comment about the orphaned column header. We hide a particular column through css (because it can't be turned off) and it was showing up in the floating toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:13:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:13:21 +0000 Subject: [Koha-bugs] [Bug 27403] Enable fixedHeader for Datatables In-Reply-To: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27403-70-cozRKKIXm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27403 --- Comment #29 from Christopher Brannon <cbrannon at cdalibrary.org> --- The other issue (checkout header appearing on the holds tab) still exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:19:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:19:35 +0000 Subject: [Koha-bugs] [Bug 29725] New: Holds-table needs table setting Message-ID: <bug-29725-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29725 Bug ID: 29725 Summary: Holds-table needs table setting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The holds-table on circulation.pl and moremember.pl needs to be included on the table settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 17:42:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 16:42:34 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-H7YV2Bd3vA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Ok, a few comments: - If you add parameters to a koha-* script, you need to add them to the docs in debian/docs/koha-* as well. This is a blocker, so FQA Also - I don't 100% understand how the uploaded tmp files will be differentiated from any other file in tmp. The 'get_tmp_path' function name in koha-functions.sh raised my suspicion, as it doesn't mention 'upload' or 'uploaded'. This could be revisited too. - I have the feeling that in order to make this more useful for production, we could try thinking how this could be used from koha-run-backups. When I added the 'exclude_indexes' option switch to koha-dump, I also added it to koha-run-backups. In this case it is not a flag (yes/no) but a string parameter with a path, so it doesn't sound like a straight-forward addition. But... maybe an option switch to include/not include uploads on the backup? Food for thougth, not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 18:06:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 17:06:27 +0000 Subject: [Koha-bugs] [Bug 29726] New: ulactioncontainer on opac-detail.pl needs to be closer to top on small devices Message-ID: <bug-29726-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29726 Bug ID: 29726 Summary: ulactioncontainer on opac-detail.pl needs to be closer to top on small devices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org With recent changes to bootstrap, the OPAC now throws the ulactioncontainer (which is in div.col-lg-3) all the way to the bottom of the screen. This is annoying if you are on a small device and your library has lots of details and add-ons (like Novelist Select). Users on small devices have to do a lot of scrolling to do anything. The ulactioncontainer would be better placed either under #catalogue_detail_biblio, or as popup menu under a 3 bar menu icon when viewed on a small device. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 18:31:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 17:31:37 +0000 Subject: [Koha-bugs] [Bug 29727] New: Koha should respect NoRenewalBeforePrecision when No Renewal Before is unset Message-ID: <bug-29727-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29727 Bug ID: 29727 Summary: Koha should respect NoRenewalBeforePrecision when No Renewal Before is unset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: - create a circ rule for item type A, automatic renewal, No Renewal Before=0 - create a circ rule for item type B, automatic renewal, No Renewal Before unset - set NoRenewalBeforePrecision to Exact Time - check out an item of type A with a due date of today, 23:59 - check out an item of type B with a due date of today, 23:59 - perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -v - confirm neither checkout would have renewed, both would get auto_too_soon error - set NoRenewalBeforePrecision to Date - perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -v - confirm that item type A, where No Renewal Before=0, would have renewed - confirm that item type B, where No Renewal Before is unset, would have renewed We generally treat an unset No Renewal Before as equivalent to zero for automatic renewal. We should do the same here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 19:26:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 18:26:32 +0000 Subject: [Koha-bugs] [Bug 29727] Koha should respect NoRenewalBeforePrecision when No Renewal Before is unset In-Reply-To: <bug-29727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29727-70-vBpaOvuGig@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29727 --- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Spotted a typo in my description. Those last two lines should be: - confirm that item type A, where No Renewal Before=0, would have renewed - confirm that item type B, where No Renewal Before is unset, would NOT have renewed, would have gotten an auto_too_soon error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 19:36:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 18:36:12 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29488-70-Bc5YXRUnEq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 19:46:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 18:46:25 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29036-70-SmbHwhIjpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #26 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:01:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:01:46 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: <bug-29494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29494-70-j0C3VRkG9D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:05:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:05:41 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29529-70-SSUJGZoVGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:13:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:13:03 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: <bug-29487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29487-70-IFKl0MZKoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:15:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:15:07 +0000 Subject: [Koha-bugs] [Bug 29728] New: upgrade from 21.05 to 21.11 DBI Exception Message-ID: <bug-29728-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29728 Bug ID: 29728 Summary: upgrade from 21.05 to 21.11 DBI Exception Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: juanpablovalles at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Upgrading from 21.05 to 21.11 the installer said: Upgrade to 21.06.00.007 [15:41:52]: Bug 11879 - Add a new field to patron record: main contact method ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs at /usr/share/koha/lib/C4/Installer.pm line 738 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:17:15 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: <bug-29556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29556-70-o7wwskq4Bd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:20:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:20:48 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: <bug-29601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29601-70-4u0zSCgQqv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|22.05,21.11.01 |22.05,21.11.01,21.05.08 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:22:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:22:59 +0000 Subject: [Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt In-Reply-To: <bug-29580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29580-70-voMCleKlXg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:31:27 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: <bug-28853-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28853-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28853-70-9kCRxkmQYQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:33:47 +0000 Subject: [Koha-bugs] [Bug 29637] AutoSwitchPatron is broken since Bug 26352 In-Reply-To: <bug-29637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29637-70-ty92jc6Jrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:39:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:39:59 +0000 Subject: [Koha-bugs] [Bug 29528] Breadcrumbs on HTML customizations take you to news In-Reply-To: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29528-70-uXAWXVsQ3p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:41:06 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-RRIusYAYiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Bug 29620 depends on bug 29593, which changed state. Bug 29593 Summary: Wrong tag in GET /public/libraries spec https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:41:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:41:06 +0000 Subject: [Koha-bugs] [Bug 29593] Wrong tag in GET /public/libraries spec In-Reply-To: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29593-70-AekGaV5Blc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29593 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependencies, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:44:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:44:48 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-5ktBGnZZUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Not backporting to 21.05 due to missing dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 20:55:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 19:55:03 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-hBlmHHRDVW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:29 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a biblio should alert/fail if there are existent subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-aVhZSXQ8og@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #28 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Doesn't apply cleanly to 21.05. Please rebase if needed. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:31 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-1FnAE7m9Fu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:34 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-QUjRogTO73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:40 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-3REhHgeWUH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128043|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:43 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-ASImFxwe5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:47 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-brY2fV0SQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:50 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-fodNAGI3Hr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:53 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-jSL38LnOpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:07:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:07:57 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-BULU1xA7mK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:10:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:10:58 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29611-70-AACeHkHYyU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:16:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:16:48 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-LoJiOaYkjP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:17:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:17:34 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-Mis8lwQLij@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #22 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:18:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:18:27 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-1yzOQHxP0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependencies, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:29:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:29:00 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15654-70-NJLDaNd6In@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:43:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:43:03 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-8Knp2bKUha@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #30 from Fridolin Somers <fridolin.somers at biblibre.com> --- OK super. Good to have several feedbacks it help understanding how we develop. So OK with this key, makes sens to reuse it. I see we have a wiki page for that : https://wiki.koha-community.org/wiki/Cache_handling_in_Koha#What_is_cached.3F I'll had this case and try to improve this doc. Best regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:43:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:43:25 +0000 Subject: [Koha-bugs] [Bug 22647] Copy number should increment similar to barcode In-Reply-To: <bug-22647-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22647-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22647-70-cnU0DTafk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22647 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:57:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:57:27 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-XFL8vii2Do@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.05.08 released in| | CC| |andrew at bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 (looks like this is in 21.11 but not noted here yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:57:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:57:41 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-v35TF0HcuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 21:57:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 20:57:47 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-wm85sqv72F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:04:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:04:16 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-FFwBr5iJvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #12 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:06:42 +0000 Subject: [Koha-bugs] [Bug 29729] New: if serials_stats.pl returns on results dataTables get angry Message-ID: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Bug ID: 29729 Summary: if serials_stats.pl returns on results dataTables get angry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. Notice that console error: datatables.min_21.1200002.js:62 Uncaught TypeError: Cannot set properties of undefined (setting '_DT_CellIndex') If you run the report for a branch WITH subscriptions it works just fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:06:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:06:56 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns on results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-Y5mrWDBlN9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:07:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:07:16 +0000 Subject: [Koha-bugs] [Bug 28855] Purging Suggestions test should not being on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-pXdRdRyZzU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:12:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:12:30 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns on results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-KXaS3Gcuhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:12:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:12:32 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns on results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-oLfiZsbIIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128686&action=edit Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:12:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:12:57 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-Iooien7iYg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|if serials_stats.pl returns |if serials_stats.pl returns |on results dataTables get |no results dataTables get |angry |angry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:13:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:13:00 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-x4f3QeRZmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #25 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:15:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:15:41 +0000 Subject: [Koha-bugs] [Bug 29730] New: Register text should be consistent in OPAC Message-ID: <bug-29730-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29730 Bug ID: 29730 Summary: Register text should be consistent in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In OPAC when you are not logged in you can see a text telling to register : > git grep -i 'register here' -- koha-tmpl/ koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: <p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <a href="/cgi-bin/koha/opac-memberentry.pl">You may register here.</a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt: <p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt: [% IF PatronSelfRegistration && PatronSelfRegistrationDefaultCategory %]<div id="patronregistration"><p>Don't have an account? <a href="/cgi-bin/koha/opac-memberentry.pl">Register here.</a></p></div>[% END %] We see that opac-auth.tt text is not consistant with other ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:15:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:15:49 +0000 Subject: [Koha-bugs] [Bug 29730] Register text should be consistent in OPAC In-Reply-To: <bug-29730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29730-70-toYZqYE7Ts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29730 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:15:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:15:49 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29458-70-lyktnvV3Fi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:15:58 +0000 Subject: [Koha-bugs] [Bug 29730] Register text should be consistent in OPAC In-Reply-To: <bug-29730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29730-70-W6EqcE6VFI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29730 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28934 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:15:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:15:58 +0000 Subject: [Koha-bugs] [Bug 28934] OPAC registration form design is not consistent In-Reply-To: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28934-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28934-70-hsCNiaz1X3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:16:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:16:38 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29458-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29458-70-kACi5Fz2dz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> --- I opened Bug 29730 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:18:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:18:50 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-vd7ciB19ik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01,21.05.08 released in| | --- Comment #14 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:18:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:18:57 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-xy8Rn1Cqjb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:20:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:20:19 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-Uf9otwCxlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependency, not backported to 21.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:20:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:20:59 +0000 Subject: [Koha-bugs] [Bug 29669] Uninitialized value warnings when XSLTParse4Display is called In-Reply-To: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29669-70-uwJWDyKzkG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:20:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:20:59 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-GlopjNu53N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Bug 25790 depends on bug 29669, which changed state. Bug 29669 Summary: Uninitialized value warnings when XSLTParse4Display is called https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:24:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:24:06 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-eLzr8AUIFw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:29:04 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-r8I530cLQt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:29:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:29:07 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-BOtgq2Lpaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128686|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128687&action=edit Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:15 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-nNlpASuwVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128688&action=edit Bug 29523: Add Koha::Objects->search_limited stub method This method is just a passthru to the search method. It is defined here to avoid the need to check if each class implements it. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:20 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-e5bDcoGsHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128689&action=edit Bug 29523: Add Koha::Object->accessible This patch introduces a method for checking if an object can be retrieved by the current user. It depends on the plural class implementation of the ->search_limited method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:26 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-put9imbMT7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128690&action=edit Bug 29523: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:30 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-IZ18v36kNJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128691&action=edit Bug 29523: Make Koha::Object->to_api respect accessibility This patch makes the *to_api* method honour the accessibility check for the object. This is relevant in the context of embedding single objects. The Koha::Patron->to_api method is adjusted to reflect this behavior as well (it does some manipulation after the ->to_api call and we need to prevent it). To test: 1. Apply up to the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => FAIL: A patron, that shouldn't be accessed, is returned by ->to_api 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 6. Pick Henry Acevedo from the sample data, assign him 'catalogue' permissions and a know user/password combination 7. Enable basic authentication 8. Point your favourite tool (Postman?) to GET http://kohadev-intra.myDNSname.org:8081/api/v1/biblio/245/checkouts Set the following header: x-koha-embed: patron Pick whatever biblio you want, actually. => SUCCESS: No checkouts 9. Perform a couple checkouts on the chosen biblio. Make sure one checkout is for a patron on the same library as Henry, and the other on a different one. 10. Repeat 8 => SUCCESS: You see two checkouts. One of them has an attribute 'patron' containing the patron from Henry's library. The other, has the attribute set to 'null'. 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:35 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-oK4yHnlrx7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128692&action=edit Bug 29523: (QA follow-up) Catch remaining SUPER::to_api cases Koha::Object->to_api can now return undefined.. we should be catching that cases in all post manipulation cases. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:40 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-DG3L1dQpA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128693&action=edit Bug 29523: (QA follow-up) Fix failing test in club holds With this patch series, all singular objects need to 'use' their plural counterparts.. otherwise the parent can't find search_related. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:39:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:39:45 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-EJbQAfHM2w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128694&action=edit Bug 29523: Pass the logged user around and use for validating In this patch I add 'user', containing the Koha::Patron object for the logged in user in the params hash we pass around in to_api. I then use that in a new 'is_accessible_in_context' method added to Koha::Patron. The method name is a bit of a mouthfull.. it could be 'is_limited' as it's really the equivilent of 'search_limited' in the plural class.. but I wasn't sure that was actually clearer... if we like it we could strip back out some of the work around search_related. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 22:57:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 21:57:40 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-sVGKTFbD1y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> --- Ah good points. I've dig about an hour trying to fix but couldn't get it work. > This one is fun. We are storing a DT into a varchar (rule_value) and so the DT object is stringified using ISO 8601. > And yes, this is closely related to bug 29718. Ah that is complex for me. We cant change how DT is stringified right ? So we better change how we store. Maybe a Koha::DateUtils dt_to_sql method ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 23:06:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 22:06:50 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-dWN4gmRqGP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #3) > I don't even think it should consider the syspref. The syspref would've been > considered when setting the 'schema' Ah but the code of get_marc_*() often contains a "if UNIMARC else ..." because fields number are hardcoded (for example title on 200 in UNIMARC). Only when we will have a Dublin Core schema this will not be needed anymore ^^ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 23:11:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 22:11:12 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-kQVdRmIrTV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fridolin Somers from comment #4) > (In reply to Tomás Cohen Arazi from comment #3) > > I don't even think it should consider the syspref. The syspref would've been > > considered when setting the 'schema' > > Ah but the code of get_marc_*() often contains a "if UNIMARC else ..." > because fields number are hardcoded (for example title on 200 in UNIMARC). > > Only when we will have a Dublin Core schema this will not be needed anymore > ^^ What if the biblio_metadata.schema had UNIMARC and the syspref MARC? I'd say biblio_metadata.schema would be the source for truth, same as with DublinCore. So we don't need to read the syspref in Koha::Biblio::Metadata->authors, we just check $self->schema and do the right thing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 23:20:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 22:20:13 +0000 Subject: [Koha-bugs] [Bug 29697] Excessive use of StripNonXmlChars In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-fGLGd5PBBA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Joubu, can you give an example for such characters that would be stripped? I want to help, but not sure about why it was added. Maybe it would be enough to do it on import/saving a record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 23:28:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 22:28:48 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29652-70-8LXxZcAXLx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #5) > > What if the biblio_metadata.schema had UNIMARC and the syspref MARC? > > I'd say biblio_metadata.schema would be the source for truth, same as with > DublinCore. So we don't need to read the syspref in > Koha::Biblio::Metadata->authors, we just check $self->schema and do the > right thing A sure, 100% agreed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 17 23:52:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 22:52:16 +0000 Subject: [Koha-bugs] [Bug 15749] Add library menu to OPAC header In-Reply-To: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15749-70-R4fM4qceaK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Chad for commenting! I am closing. Please feel free to reopen or file a new bug if there are still functionalities you are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 00:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 23:48:17 +0000 Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA) In-Reply-To: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28707-70-kpxQeIo59V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Caroline, the texts of any sample notice is stored in a .yml file now and the translation should be done via the pootle files. https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/en/mandatory/sample_notices.yml#L1112 But I didn't find 'Operator ID:' on pootle - and now I am confused too... https://translate.koha-community.org/fr_CA/21.11/translate/#search=Operator%20ID%3A&sfields=source,target&soptions=exact -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 00:54:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Dec 2021 23:54:38 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-eZZrYCEALJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marcel de Rooy from comment #17) > (In reply to Katrin Fischer from comment #16) > > I count myself as a non-progammer tester as well - I think you mean that we > > already break the rule for not hardcoding the template, but I think those > > are bugs we should fix then. Hea shows that having your own OPAC template is > > not as rare as one would think. > > This is an architectural patch, not the popular kind, yes. And insisting > that it should also fix such occurrences makes it even harder. Since the > patch is about fixing parameters, I would be tempted to say that it is > outside the scope too ;) > > Having a look now how to get this on track again. But if it takes too much > time, I will abandon it. I didn't mean fixing them on this bug - just that I would consider it a bug and that we should not add more hardcoded 'bootstraps'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:15:59 +0000 Subject: [Koha-bugs] [Bug 28635] upgrade from Koha 20.05.06.000 to latest version failing with Row size too large In-Reply-To: <bug-28635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28635-70-wr6IMfbhI4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28635 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- *** This bug has been marked as a duplicate of bug 28267 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:15:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:15:59 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-e4J8jwXA0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mesfin.teshome at africaintern | |ational.edu --- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> --- *** Bug 28635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:16:58 +0000 Subject: [Koha-bugs] [Bug 29728] upgrade from 21.05 to 21.11 DBI Exception In-Reply-To: <bug-29728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29728-70-nRRnCS1fsf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29728 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28267 CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Looks like same problem as Bug 28267 What is your OS and mariadb/mysql version please ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:16:58 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-DQOYYkL1KS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29728 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:23:04 +0000 Subject: [Koha-bugs] [Bug 29724] Different authority usage count In-Reply-To: <bug-29724-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29724-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29724-70-cSrGqhoUw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29724 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Indeed its a bug. Already reported in Bug 26608 *** This bug has been marked as a duplicate of bug 26608 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:23:04 +0000 Subject: [Koha-bugs] [Bug 26608] Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate In-Reply-To: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26608-70-g8wlvTjsL0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26608 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fribeiro at keep.pt --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- *** Bug 29724 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:23:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:23:28 +0000 Subject: [Koha-bugs] [Bug 29724] Different authority usage count In-Reply-To: <bug-29724-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29724-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29724-70-8BFuaHQuIZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29724 --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- Thanks for this report. Best regards, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:39:04 +0000 Subject: [Koha-bugs] [Bug 29533] add more fields to items sql table In-Reply-To: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29533-70-7qwuzVKL4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> --- This would be a little bit like borrowers sort1 and sort2. I'm not against it :/ We should consider using the "additional fields" feature like for subscriptions, Bug 10855 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:40:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:40:50 +0000 Subject: [Koha-bugs] [Bug 29574] OPACShelfBrowser doesn't show any records in koha 21.05.x In-Reply-To: <bug-29574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29574-70-5qOHk3QhqC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29574 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |fridolin.somers at biblibre.co | |m Status|NEW |RESOLVED --- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> --- You may use /misc/maintenance/touch_all_items.pl Best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 08:50:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 07:50:18 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-HXgtqDSjWm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- Arg this is bad. We can see there is only one check from Bug 14708 Maybe we need to create like for Koha::Item : safe_to_delete() safe_delete() Or throw more exceptions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 09:00:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 08:00:39 +0000 Subject: [Koha-bugs] [Bug 29304] Add a first time login page In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29304-70-kAXtb2EOPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- Awesome idea. Maybe we create an HTML additional content for this (like OpacLoginInstructions). Maybe use borrowers.lastseen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 09:36:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 08:36:04 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search. In-Reply-To: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27912-70-3I0FnjW0L2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> --- I reproduce. Ajax call returns a JSON with an HTML href containing a JSON HTML-encoded. value=\"[% To.json(data) | html %]\" This double-quotes generates : \"test\" Maybe as a quick fix remove borrowernotes from those Ajax tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 09:43:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 08:43:53 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9097-70-lTGYKz75f6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29304 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 09:43:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 08:43:53 +0000 Subject: [Koha-bugs] [Bug 29304] Add a first time login page In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29304-70-MKzAxQpCMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9097 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 09:49:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 08:49:28 +0000 Subject: [Koha-bugs] [Bug 29492] SPAM In-Reply-To: <bug-29492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29492-70-SGF2nUGntT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29492 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:03:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:03:05 +0000 Subject: [Koha-bugs] [Bug 29433] SPAM In-Reply-To: <bug-29433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29433-70-u69I7ACING@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29433 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing QA Contact| |testopia at bugs.koha-communit | |y.org Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Product|Koha security |Koha Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:27:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:27:52 +0000 Subject: [Koha-bugs] [Bug 29295] Page specific jQuery In-Reply-To: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29295-70-RpLbDkEQDC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29295 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- You mean JQuery code added in IntranetUserJS or OPACUserJS ? Each page as an id in the body. For example : <body id="main_intranet-main" class="intranet-main"> So you can create a code loaded just for that page with : if ( $("body#main_intranet-main").length > 0 ) { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:30:08 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-3zDkuCSkQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |11083 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Starts on Bug 11083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 [Bug 11083] Authority Search Result Display should be XSLT Driven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:30:08 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11083-70-uxo00XC0rR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21330 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 [Bug 21330] Add xslt for authority normal view in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:36:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:36:08 +0000 Subject: [Koha-bugs] [Bug 29147] Add option to specify Zebra is not being used In-Reply-To: <bug-29147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29147-70-AuVrQZ7k0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29147 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Duplicate of Bug 21820 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 10:40:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 09:40:08 +0000 Subject: [Koha-bugs] [Bug 24129] Add ability to configure some search fields to not autotruncate In-Reply-To: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24129-70-t8anWErrNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24129 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to configure |Add ability to configure |some indexes to not |some search fields to not |autotruncate |autotruncate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 12:35:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 11:35:07 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-eF9CpJACk5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Manos PETRIDIS <egpetridis at yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #6 from Manos PETRIDIS <egpetridis at yahoo.com> --- Same behaviour here, autoBarcode set to <branchcode>yymm0001 but barcodes are not auto-generated after upgrading to 21.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 17:25:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 16:25:17 +0000 Subject: [Koha-bugs] [Bug 29731] New: UNIMARC 100$a 17-19 Target Audience Code Message-ID: <bug-29731-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29731 Bug ID: 29731 Summary: UNIMARC 100$a 17-19 Target Audience Code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org Problem UNIMARC 100 $a/17-19 Target Audience Code It is not possible to use the "#" symbol. Unused positions are filled with space characters "#". For example, when you need to use "x##". https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_100_update2020_online_final.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 19:44:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 18:44:45 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29679-70-xQGZozxl5n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes borders release notes| |between sections that are | |not required. The SQL | |report batch operations | |dropdown menu has divider | |list items which add a | |border between sections | |(bibliographic records, | |item records, etc.). This | |element is redundant | |because the sections have | |"headers" which also add a | |border. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 19:48:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 18:48:14 +0000 Subject: [Koha-bugs] [Bug 28855] Purging suggestions test should not be on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-3JKw5xgKeS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Purging Suggestions test |Purging suggestions test |should not being on |should not be on timestamp |timestamp | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 19:53:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 18:53:08 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-9wRy56BLTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting a biblio should |Deleting a record should |alert/fail if there are |alert or fail if there are |existent subscriptions |current subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 19:59:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 18:59:27 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29529-70-nAAAHFtuMT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes: |This fixes: release notes|- a string in |- a string in |Koha to MARC mappings |Koha to MARC mappings |(koha2marclinks.tt:86) so |(koha2marclinks.tt:86) so |that it can be correctly |that it can be correctly |translated (excludes "\n" |translated (excludes "\n" |from what is translated), |from what is translated), |and |and |- Capitalization for |- capitalization for |the breadcrumb link: |the breadcrumb link: |Administration > Koha to |Administration > Koha to |MARC mappings. |MARC mappings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:08:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:08:53 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28977-70-8TQ8o5ryTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error that release notes| |causes the most circulated | |items report to fail when | |run on a database with SQL | |mode ONLY_FULL_GROUP_BY and | |in struct SQL mode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:12:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:12:44 +0000 Subject: [Koha-bugs] [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include In-Reply-To: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29575-70-k7EnWQ7QmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds a release notes| |re-usable javascript render | |function that accepts a | |Koha REST APIi Patron | |object and outputs the HTML | |representation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:13:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:13:09 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-AYI869TTBT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127899|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128695&action=edit Bug 29481: Terminology: Collection code, call number This patch corrects an instance of the phrase "Collection code," replacing it with the standard "Collection." To test, apply the patch and restart services. - In the staff interface, go to Administration -> System preferences and set the OpacItemLocation preference to "library, collection code, and call number." - In the OPAC, search the catalog using a term which will return multiple results. - In the search results, item descriptions in the "Availability" line should read like this: [Collection, call number: Non-fiction 394.2663 Bu] Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:13:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:13:14 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-6vT840Qdb4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128696&action=edit Bug 29481: Terminology: Fix other occurrences of 'Collection code' This changes Â"collection code" to be "collection" as Koha displays the collection description and no codes. This will also help to make the GUI more consistent overall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:14:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:14:09 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-A4msqz7Iwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128696|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128697&action=edit Bug 29481: Terminology: Fix other occurrences of 'Collection code' This changes "collection code" to be "collection" as Koha displays the collection description and no codes. This will also help to make the GUI more consistent overall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:14:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:14:41 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code, call number: In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-Roa0SUvA59@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #3) > Should we fix the other occurrences as well? > koha-tmpl/intranet-tmpl/prog/en/columns.def:<field > name="items.ccode">Collection code</field> > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: > ccode: "Collection code" > > and in the framework installer files. I made the additional changes, would you mind checking them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:14:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:14:58 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-TpDPec5dmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Collection |Terminology: Collection |code, call number: |code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:29:28 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-L8pOiNilQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |API call that returns | |patrons filtered by how | |much money they owe, | |between passed limits (for | |example less than $2.50 or | |more than $0.50). | |Optionally, can limit to | |debts of a particular | |debit_type and owed to a | |particular library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:30:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:30:50 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15156-70-p5oMkziMQC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #42 from David Nind <david at davidnind.com> --- I attempted to add release notes, but as I don't really understand the this and the terminology it may need reviewing and updating! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:32:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:32:51 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5697-70-qCCnnI5TP5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a feature |This patch adds a feature release notes|to automatically link |to automatically link |certain database columns in |certain database columns in |report results. If your |report results. If your |report returns itemnumber, |report returns itemnumber, |biblionumber, cardnumber, |biblionumber, cardnumber, |or borrowernumber, that |or borrowernumber, that |cell in the report will |cell in the report will |contain a menu: |contain a menu: | | |- |- |borrowernumber: View, edit, |borrowernumber: View, edit, |check out |check out |- cardnumber: |- cardnumber: |Check out |Check out |- itemnumber: |- itemnumber: |View, edit |View, edit |- biblionumber: |- biblionumber: |View, edit |View, edit | | |A link at the |A link at the |top of the report results |top of the report results |will toggle the new menus |will toggle the new menus |on and off in case you |on and off in case you |don't want to see the |don't want to see the |menus. Your choice will |menus. Your choice will |persist until you log out. |persist until you log out. | | |The feature works with |The feature works with |column name placeholders, |column name placeholders, |so if you want the table |so if you want the table |column to be a human |column to be a human |readable label you can |readable label you can |still get automatic |still get automatic |linking, e.g. |linking, for example: | |[[items.itemnumber|Item |[[items.itemnumber|Item |number]] |number]] | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:35:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:35:29 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-oL5V3oWaFt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's really bad but didn't get much attention yet. At the moment I would almost lean to deactivate that route as it might leave you with inconsistent data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:38:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:38:31 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-8zEoUELFpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #3) > It's really bad but didn't get much attention yet. At the moment I would > almost lean to deactivate that route as it might leave you with inconsistent > data. I'll fix it first thing in the morning next Monday :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:39:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:39:54 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search In-Reply-To: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27912-70-TqW06nN3HB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quotes break guarantor |Quotes break guarantor |search. |search See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26865 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I feel like we have fixed this in other places and just removing borrowernotes will leave us with the same issue in other input fields like firstname that we cannot remove. This one might give a clue: Bug 22715 - Searching for patrons with "" in the circulation note hangs patron search And then there is also: Bug 26865 - Double quotes in patron's data breaks patron searches (no patch yet) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:39:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:39:54 +0000 Subject: [Koha-bugs] [Bug 26865] Double quotes in patron's data breaks patron searches In-Reply-To: <bug-26865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26865-70-iu6pQO4gZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26865 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27912 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:43:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:43:15 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29589-70-tcBuX00M4d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:43:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:43:18 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29589-70-mkoAdL2YKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128116|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128698&action=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:44:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:44:19 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29589-70-bkk7JMi12K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks for the fix! I didn't know about KohaSpan. I wonder if we could move this issue into coding guidelines somehow with some example on how to make formatting work without making it hard for translators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:53:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:53:28 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-vGLTfQxuEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:53:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:53:31 +0000 Subject: [Koha-bugs] [Bug 29729] if serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-dEI4aAO4ej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128699&action=edit Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 22:53:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 21:53:56 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29729-70-GOm8RtZj0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|if serials_stats.pl returns |If serials_stats.pl returns |no results dataTables get |no results dataTables get |angry |angry --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nice catch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:03:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:03:31 +0000 Subject: [Koha-bugs] [Bug 29146] Default values from the framework should only be applied at biblio/item creation In-Reply-To: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29146-70-5zKOUV0WIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch makes Koha no |This fixes the standard release notes|longer apply default values |cataloguing editor and the |to empty fields in an |item editor so that when |existing biblio record in |updating existing records |the regular cataloguing |and items empty fields are |editor. Same for item |not updated with the |editor. |default framework values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:08:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:08:10 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-UI4zyGxpat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is this not more a clash of variables where we should rename one? There is also the preferred language for notices stored in borrowers.lang and it has a "default" setting. It will be visible after activating the TranslateNotices system preferences on opac-messaging.pl, but also memeberenty.pl. With this patch in place, I can no longer set the preferred language to "Default" or any other installed language in the staff interface. It will always store the template language. 1) Activate TranslateNotices 2) Edit any existing patron, set language to Default 3) Save 4) Edit: Template language will show as selected. I haven't verified, but the patch possibly triggering printing slips/notices in the preferred language from paycollect as well. I believe we need to approach this differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:17:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:17:17 +0000 Subject: [Koha-bugs] [Bug 29709] Add option to use patron library as suggestion library In-Reply-To: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29709-70-BwlGs8Mi9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29709 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Mathieu, that already works. The pull down for library will preselect the home library of the patron. If you don't want them to change it, you only need to add the library to OPACSuggestionUnwantedFields. In earlier versions this was a separate permission, but also possible, IIRC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:23:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:23:25 +0000 Subject: [Koha-bugs] [Bug 15459] Allow to select 'Any library' for suggestions In-Reply-To: <bug-15459-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15459-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15459-70-UkeS2IZZne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15459 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The old system preference has been replaced by the 'library or branch' option of OPACSuggestionUnwantedFields, but this feature would still be nice :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:28:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:28:12 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29419-70-FtdFe61w5m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:28:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:28:16 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29419-70-K2CsoifZut@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128482|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128700&action=edit Bug 29419: Retain user's inputs when suggesting for purchase and match found If a user suggests for purchase and a match is found, their inputs was not retained: quantity, item type, library, reason. Test plan: 1. Suggest for purchase 2. Fill the title in with a string that will match an existing record 3. Fill value in quantity, item type, library and reason input/dropdown 4. Submit => Notice that with this patch the values you entered are retained on the confirmation screen Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:34:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:34:37 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-zVf41lArWz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:34:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:34:41 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-Y4SQWpbOdN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128537|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128701&action=edit Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:35:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:35:45 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-a6UajyhBua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128536|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128702&action=edit Bug 29696: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:35:49 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-xJpki73tzi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128701|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128703&action=edit Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:36:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:36:28 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-FitGUF42vl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx a lot. I had some trouble running the selenium tests (with and without patch), so maybe QA can take care of that? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:39:23 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29230-70-shKk7du9Ru@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:50:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:50:28 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-Jfmhzz1GWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marion, I believe this will work nicely for MARC21, but not work for UNIMARC as the fields are quite different. Why in MARC21 100 is a person's name, in UNIMARC it seems to be used quite differently: https://www.ifla.org/g/unimarc-rg/unimarc-authorities-3rd-edition-with-updates/ 100 – General Processing Data (update 2018) So I think we need at least a check on the marcflavor, but it would be even nicer if we could pick out the right fields for UNIMARC as well. Also I wonder if we could avoid querying the record twice, but someone else might be better suited to comment on that: my $record = GetAuthority($authid); my $authobj = Koha::Authorities->find($authid); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:52:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:52:59 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-CF7dQOYlRt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 18 23:53:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 22:53:02 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-1FpSH4PMk6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124617|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128704&action=edit Bug 28962: Add del-unv-selfreg to crontab We also add a test by inserting a simulated borrower modification record in the same table which should not be deleted. NOTE: This patch fixes the del-unv-selfreg parameter in the cleanup db script. It did not even do what it promised :) Test plan: Verify if the crontab change is correct. Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:00:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:00:01 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17127-70-pOBQmQQiw1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:00:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:00:06 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17127-70-PbUOClifmS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128049|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128705&action=edit Bug 17127: Remove notes from detail.tt to only use MARCNOTES Notes come from the biblio table, but that table is already used to fill in MARCNOTES through Biblio.pm and get_marc_notes. Get_marc_notes does check for NotesToHide and already read every note on the records, but .notes doesn't go through that same filter. I don't see the point of keeping notes as a condition when MARCNOTES does the same job but better. To test: 1) Take any record, or create one 2) Input something in the 500 field (or 300 in UNIMARC) 3) In Systempreferences -> NotesToHide, fill in the number 500 (or 300). 4) Save, then go look at the record detail in the OPAC and admin website. 5) You should still see the 500 or 300 field under the Description tab. 6) Apply patch. 7) Reload the record detail page. 8) Observe the error is gone. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:00:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:00:38 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17127-70-WVOgrAPCyr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Really love to see this one finally fixed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:01:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:01:25 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29604-70-WYQ62keree@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|term highlighting adds |Term highlighting adds |unwanted pseudo element in |unwanted pseudo element in |the contentblock of OPAC |the contentblock of OPAC |details page |details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:15:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:15:08 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29604-70-oqOiRPMdZc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:15:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:15:12 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29604-70-tzSnycrKMj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128226|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128706&action=edit Bug 29604: Dont add psuedo content to highlighted terms To test: 1. Do a search for something where the search terms will be in the 505 note. 2. Visit the OPAC detail page of the record. 3. The first occurance of the term highlighting will include the CSS pseduo element "→ "; 4. Apply patch 5. Do the stuff to regenerate the CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 6. Do 1 & 2 again. 7. No weird psuedo element in the term highlighting Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:27:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:27:49 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-AkqoZ7l3qh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the|This report makes the |This fixes the release notes|del-unv-selfreg flag of the |cleanup_database script so |cleanup_database script |that the option to delete |part of the standard |unverified self |crontab of Koha. |registrations | |(del-unv-selfreg) works. It |It |also adds this option to |defaults to 14 days. |the standard crontab, | |defaulting to 14 days (the |Note: |default notice says |If you do not use self |unverified registrations |registration with |will expire "shortly"). |verification mail, this | |does not affect you. |Note: If you don't use self | |registration with a | |verification email, this | |does not affect you. If you | |do use self registration, | |check the system | |preferences and settings - | |particularly | |PatronSelfRegistrationDefau | |ltCategory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:28:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:28:14 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-eHQx0BmZcC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 00:30:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 Dec 2021 23:30:55 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-CAvwUNJxwB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #5 from David Nind <david at davidnind.com> --- The crontab entry looks fine to me. The tests pass. No updates are required to the cron jobs and crontab sections of manual. The flag is already covered in the description of the script, although it doesn't work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 06:31:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 05:31:34 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-ajAXI8R3B0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 MD NAZRUL ISLAM <nazrul.it.puc at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nazrul.it.puc at gmail.com --- Comment #23 from MD NAZRUL ISLAM <nazrul.it.puc at gmail.com> --- Upgrade to 21.06.00.012 [11:07:40]: Bug 15067 - Add missing languages ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line 738 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 11:30:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 10:30:43 +0000 Subject: [Koha-bugs] [Bug 29631] 21.06.000.12 may fail In-Reply-To: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29631-70-Fb6rRPnmGg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to MD NAZRUL ISLAM from comment #23) > Upgrade to 21.06.00.012 [11:07:40]: Bug 15067 - Add missing languages > ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry > 'IN-region' for key 'uniq_lang' at /usr/share/koha/lib/C4/Installer.pm line > 738 Please read through the bug - there is no need to post the issue again. The SQL statements in comment#18 are the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:02:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:02:46 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29557-70-164Aolp161@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am in doubt about the database update as this will only work for notices that haven't been changed - including untranslated. But it doesn't hurt to update unchanged notices, so we can keep it. But maybe we could add a note to the update statement about updating your notice if you have changed them? Attaching a patch to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:06:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:06:41 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29557-70-HdBfHlMwOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:06:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:06:45 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29557-70-QZ4w2SG7zX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128099|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128707&action=edit Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:06:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:06:49 +0000 Subject: [Koha-bugs] [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration In-Reply-To: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29557-70-a72cL3dJtg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128708&action=edit Bug 29557: (QA follow-up) Add note for translated notices to update statement Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:07:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:07:42 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29557-70-rJSuueq1cx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|auto-renew notices should |Auto renew notices should |handle failed renewal due |handle failed renewal due |to patron expiration |to patron expiration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:10:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:10:04 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28832-70-22DhL2Jr8s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, this no longer applies - can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28832: Don't batch modify fields that we don't update Using index info to reconstruct a base tree... M tools/batchMod.pl Falling back to patching base and 3-way merge... Auto-merging tools/batchMod.pl CONFLICT (content): Merge conflict in tools/batchMod.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 28832: Don't batch modify fields that we don't update The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28832-Dont-batch-modify-fields-that-we-dont-up-dHzj6t.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:24:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:24:47 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-z0SnyMt3Tw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I still see some glitches here: 1) Place a hold in staff and set the expiration date - Yesterday is inactive - OK - Today doesn't jump to today when clicked, but is still active (not OK) 2) Set a date of birth for a patron - You can set a date of birth into the future. All options are active an and work. (possibly not related to this patch?) 3) Administration > Edit or add a patron category > Set the "Until date" - Dates in the past are greyed out, Yesterday and Today are active, but won't select a date (not OK) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:31:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:31:40 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22866-70-QsB6IH7GmK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have to admit, AllowRenewalItemsDeniedOverride reads a little strange to me, why not AllowItemsDeniedRenewalOverride to stick with the feature name? Not a blocker. ItemsDeniedRenewal in the pref description should be linked, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:39:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:39:28 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22866-70-Vox8DskzGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128709&action=edit Bug 22866: (QA follow-up) Link system preference in preference description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 12:42:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 11:42:20 +0000 Subject: [Koha-bugs] [Bug 22866] ItemsDeniedRenewal cannot be overriden In-Reply-To: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22866-70-cZhqk9pIPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The override checkbox will only show if AllowRenewalLimitOverride is also set to "Allow", but this dependency is not clear from the preferences and might be unintended? As is the new preference alone will have no effect. How should this work in reference to the Override blocked renewals (override_renewals) permission? Can you please clarify? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:38:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:38:02 +0000 Subject: [Koha-bugs] [Bug 29709] Add option to use patron library as suggestion library In-Reply-To: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29709-70-J5rb0PHlBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29709 --- Comment #2 from mathieu saby <mathsabypro at gmail.com> --- Thank you! Sorry, I made a mistake in my tests, and I was given ambiguous information by other libraries... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:41:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:41:24 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27992-70-3LgTMo2to9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This works as intended as far as I can tell, but I have something to clarify: In marked my item lost using the 'claims returned' feature. With this change the item will be returned and the claim remains unresolved. Is this an issue? When you try to return an item that is lost with BlockReturnOfLostItems we deny the return. But we allow checking it out to a statistical patron. Should the latter also be blocked? Maybe instead of resolving the lost status automatically, we should ask for confirmation and when BlockReturnOfLostItems is set even block it hard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:42:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:42:36 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24866-70-rJCg63HVpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |florian.bontemps at biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:44:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:44:16 +0000 Subject: [Koha-bugs] [Bug 29709] Add option to use patron library as suggestion library In-Reply-To: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29709-70-Qy8ZWKG1IX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29709 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- No problem at all. Please keep filing bugs :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:57:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:57:23 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-NouNd5KYKD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:57:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:57:27 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-MGk4a1FevT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128399|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128710&action=edit Bug 29571: Display all pending suggestions even if none from logged in library The number of pending suggestions was only displayed if there are pending suggestions at the logged in library. Test plan: Login at CPL Create a suggestion (ASKED) for another library => Without this patch there is nothing on the mainpage => With this patch applied you will see info about pending suggestions: "Suggestions pending approval: Centerville: 0 / All libraries: 1" Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: ThibaudGLT <thibaud.guillot at biblibre.com> Signed-off-by: Andreas Roussos <a.roussos at dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 13:57:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 12:57:31 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29571-70-HtH3Mgckcy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128473|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128711&action=edit Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt In addition to the Staff Client's home page, the number of pending suggestions is also displayed in Home > Acquisitions. Currently, these are only displayed if there are pending suggestions at the logged in library. However, suggestions should always be displayed. This follow-up patch fixes that, and also removes a template variable (`suggestion`) that is no longer in use (removed as part of Bug 4331, commit 70af4593722ce2f3debd4f6d2c251ad29008b923). Test plan: 1) Create a suggestion for Library A. 2) Go to Home > Acquisitions while logged in at Library B. Without this patch, nothing is displayed regarding suggestions. 3) Apply this patch. Notice how suggestion information is shown, like: "Manage suggestions: Library B: 0 / All libraries: 1" If you change the library to Library A, you should get: "Manage suggestions: Library A: 1" Signed-off-by: Florian Bontemps <florian.bontemps at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:10:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:10:11 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-tUxNg76JYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Thibault, some small things: 1) Make sure that you start the subject line of your patch with Bug XXXX: I'll fix this in QA. 2) Database update: We have a new format for the database update, the patch still uses the old one. Please make sure to use the new format in future patches, see: https://wiki.koha-community.org/wiki/Database_updates 3) I'll rephrase the description of the pref a bit. If you'd like some help for checking something in English, the native speakers on IRC are usually willing to help out quickly. 4) I noticed your patch has your name as "ThibaudGLT". We can map this to your full name if you want, but easiest is always to submit the patches with the name you want to appear on the Dashboard and the release notes already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:19:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:19:34 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-3DRcbDuXH8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:19:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:19:39 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-PltFWEEH8V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128515|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128712&action=edit Bug 20076: Add syspref to remove overdues notification by email to staff if user has no email address I took the same test plan as victor but I added the system preference to manage the case more easily, especially for users who do not have access to the koha server. Test plan 1. Check the size of the message queue With the following SQL query (using an SQL report if you want) SELECT COUNT(*) FROM message_queue; 2. Run misc/cronjobs/overdue_notices.pl 3. Check the size of the message queue To ensure that no other overdues will create noise in this test plan. Or you can take them into account. 4. Choose a patron with no email address 5. Create an overdue (checkout an item and unfold "Checkout settings" and set a date in the past which is compatible with what you find in staff:/cgi-bin/koha/tools/overduerules.pl 6. Run misc/cronjobs/overdue_notices.pl 7. Check that you have two new messages in the queue 8. Inspect these two messages SELECT * FROM message_queue ORDER BY time_queued DESC LIMIT 2 \G 1. One has the type "print" and the borrowernumber matching the patron. 2. The other has subject: Overdue Notices borrowernumber: NULL message_transport_type: email and contains "These messages were not sent directly to the patrons." This is the one we don't want anymore. Because it's now obsolete due to the first message. 9. Apply this patch 10. Run updatedabatase.pl 11. Change syspref 'EmailOverduesNoEmail' to "Don't send" 12. Delete data from message_queue (if you have access) for a cleaner view 13. Run again misc/cronjobs/overdue_notices.pl 14. Check that only the print message is now generated and not the "Overdue Notices" one. https://bugs.koha-community.org/show_bug.cgi?id=20076 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:19:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:19:44 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-3lylPXb4xm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128713&action=edit Bug 20076: (QA follow-up) Reformat database update to use newer format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:19:48 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-qu8fpor9Qz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128714&action=edit Bug 20076: (QA follow-up) Rephrase system preference description sightly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:19:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:19:53 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-me3Tb4RALr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128715&action=edit Bug 20076: (QA follow-up) We need to default to 'Send' on update to keep existing behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:30:53 +0000 Subject: [Koha-bugs] [Bug 29732] New: Check alert in cataloguing authorities should be a static message Message-ID: <bug-29732-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 Bug ID: 29732 Summary: Check alert in cataloguing authorities should be a static message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 28694 It would be great if the changes from the cataloguing editor for bibliographic records from bug 28694 could also be made available for the authorities editor. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:30:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:30:53 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28694-70-6e0WJg0Oze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 [Bug 29732] Check alert in cataloguing authorities should be a static message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:32:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:32:01 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28694-70-qvMom86TD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just noticed in testing that it would be nice to have these changes for the authority editor as well: Bug 29732 - Check alert in cataloguing authorities should be a static message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:50:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:50:17 +0000 Subject: [Koha-bugs] [Bug 29733] New: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder in sample frameworks Message-ID: <bug-29733-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29733 Bug ID: 29733 Summary: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder in sample frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We do link the authority controlled fields to the authority linker by default, so it would make sense to link the fields used for linking between bibliographic records to the available helper plugin as well. At the moment the plugin is not well know, although it provides a great functionality, this could help advertise and improve it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:59:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:59:13 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29585-70-nq1MSognjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 14:59:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 13:59:17 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29585-70-k8BWF84bbv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128066|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128723&action=edit Bug 29585: Fix unstranslatable strings in addbiblio.tt This patch makes 'Go to field' and 'Errors' strings translatable Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:03:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:03:32 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29585-70-70qDlmuf31@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi David, thx for trying to test this! > After applying the patch > ~~~~~~~~~~~~~~~~~~~~~~~~ > > 1. Update the language files: perl translate install de-DE This step will install de-DE again, but the po file won't have been updated to have the string yet. So you need to follow the instructions here first: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation Then you should be able to verify, that the string appeared in the po files and you can edit them to translate them if you want. As this one is an easy fix, I am taking the liberty to move it straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:11:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:11:46 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-TZT6otYzL1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #14) > Missing dependencies, not backported to 21.05 I think this needs to be pushed to 21.11 urgently, but seems to have been pushed and then reverted? https://git.koha-community.org/Koha-community/Koha/commits/branch/21.11.x Kyle, can you clarify? Andrew, you should check for your version only after Kyle has pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:15:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:15:40 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-KadYs9M6xl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What's missing here to move on? (In reply to Martin Renvoize from comment #25) > I'm happy for this to progress without my final patch... but I would love to > see it moved to another bug for the next round of performance enhancements > and code cleaning. > > I think the following statement still needs some action though: However, > currently, there is one test failing and I couldn't grok how to fix it: > `t/db_dependent/api/v1/patrons.t` Has this been taken care of yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:18:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:18:14 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-DHtQdR7Mmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #34 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #33) > What's missing here to move on? This is ready as-is, but I need to discuss something with Martin tomorrow morning. > (In reply to Martin Renvoize from comment #25) > > I'm happy for this to progress without my final patch... but I would love to > > see it moved to another bug for the next round of performance enhancements > > and code cleaning. > > > > I think the following statement still needs some action though: However, > > currently, there is one test failing and I couldn't grok how to fix it: > > `t/db_dependent/api/v1/patrons.t` > > Has this been taken care of yet? I took care of that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:21:02 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: <bug-29495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29495-70-EeW0iEQFkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #26) > (Wouldn't it be better to put effort in merging the tables?) We have blocked a lot of important bug fixes because of the merge table question... at the moment I think fixing bugs is more reachable than the table merge which also could never be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 15:50:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 14:50:21 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-u26QlqWJNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Tomas, go back to your Sunday :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 19 21:11:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 20:11:20 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29330-70-PxJWA9vNcf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #63 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > So it turns out I don't care about this bug :P 3 weeks later, now I'm maintaining 20.11.x so back to here ^^" I'll see what I can do. It's a blocker after all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 00:37:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 Dec 2021 23:37:54 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-gp0ApGHuWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #27 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #26) > Either here or a separate bug report. > > `git grep "psgi.*ENV"` shows the different occurrences. I think that's way outside the scope of this bug, so I think a separate bug report for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 02:10:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 01:10:09 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: <bug-18540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18540-70-1K2G1N9HMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 02:10:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 01:10:14 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: <bug-18540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18540-70-xqPcSCuZYr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120943|0 |1 is obsolete| | --- Comment #3 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128724&action=edit Bug 18540: Handle indexing sort title only when needed This patch moves the code that generates the xsl for MARC21 biblio sorting to it's own template that is only called when specified in the xml To test: 1 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 2 - git diff 3 - Note that authority-zebra-indexdefs.xsl now has 245 Title:s info 4 - Apply patch 5 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 6 - git diff 7 - There are lines added about title sort, but no 245 block 8 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 9 - git diff 10 - Note lines changes to ...title_sort 11 - 245 block does not change Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 03:51:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 02:51:44 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: <bug-11807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11807-70-EvADjvL4Ja@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #17 from David Cook <dcook at prosentient.com.au> --- Noticed this while looking through the code, but noticed it doesn't appear to be documented anywhere. Would be good to have this in the manual or on the wiki. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 04:46:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 03:46:30 +0000 Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and object_store_post In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28173-70-Ow4wbElDiU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook <dcook at prosentient.com.au> --- When I saw the hook names, I was worried about performance, and I can see that worry was well founded. I'm curious if bug 29672 will be enough. These hooks are pretty broad. I wonder how much of a slowdown they would bring overall even with a well designed plugin... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:01:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:01:11 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: <bug-27311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27311-70-N5gHAprBw8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Magnus Enger from comment #0) > which means there is not yet a borrowernumber to pass to the plugin, and > this never worked. I was just about to say this when I noticed the bug reference... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:19:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:19:23 +0000 Subject: [Koha-bugs] [Bug 29734] New: [OMNIBUS] Recalls for Koha Message-ID: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 Bug ID: 29734 Summary: [OMNIBUS] Recalls for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Parent bug report for recalls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:19:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:19:46 +0000 Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29734-70-dVkbWNLGIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Depends on| |19532, 23781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 [Bug 23781] SMS and messaging preferences for recalls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:19:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:19:46 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-wBMt1mZwUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:19:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:19:46 +0000 Subject: [Koha-bugs] [Bug 23781] SMS and messaging preferences for recalls In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-B5py2QA562@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 05:45:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 04:45:01 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-zdREeFYN3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED Summary|SMS and messaging |Recalls notices and |preferences for recalls |messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 08:10:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 07:10:00 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29684-70-TQkYnReFwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5) > Is this not more a clash of variables where we should rename one? > > There is also the preferred language for notices stored in borrowers.lang > and it has a "default" setting. > > It will be visible after activating the TranslateNotices system preferences > on opac-messaging.pl, but also memeberenty.pl. > > With this patch in place, I can no longer set the preferred language to > "Default" or any other installed language in the staff interface. It will > always store the template language. > > 1) Activate TranslateNotices > 2) Edit any existing patron, set language to Default > 3) Save > 4) Edit: Template language will show as selected. > > I haven't verified, but the patch possibly triggering printing slips/notices > in the preferred language from paycollect as well. > > I believe we need to approach this differently. Thx Katrin for verifying this. I only glanced at the patch and was already afraid for this side effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:06:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:06:42 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: <bug-11807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11807-70-G68mTD54ZJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You can use the "manual" keyword to make this show up for the Docs team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:19:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:19:38 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-ch6tIvh8vx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #29 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- (In reply to Katrin Fischer from comment #24) > Hi Thibault, > > some small things: > > 1) Make sure that you start the subject line of your patch with Bug XXXX: > I'll fix this in QA. > > 2) Database update: We have a new format for the database update, the patch > still uses the old one. Please make sure to use the new format in future > patches, see: > https://wiki.koha-community.org/wiki/Database_updates > > 3) I'll rephrase the description of the pref a bit. If you'd like some help > for checking something in English, the native speakers on IRC are usually > willing to help out quickly. > > 4) I noticed your patch has your name as "ThibaudGLT". We can map this to > your full name if you want, but easiest is always to submit the patches with > the name you want to appear on the Dashboard and the release notes already. Hi Katrin, Thanks a lot for this complete review, sorry for the mistakes, but I understand now, I will keep this in mind for my future patchs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:23:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:23:22 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20076-70-LspR8BECpT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > Hi Katrin, > > Thanks a lot for this complete review, sorry for the mistakes, but I > understand now, I will keep this in mind for my future patchs. That was my only intention, hoping to see many more patches from you! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:26:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:26:04 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-prmnyd17qI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #9 from marion.durand at biblibre.com --- (In reply to Katrin Fischer from comment #8) > Hi Marion, > > I believe this will work nicely for MARC21, but not work for UNIMARC as the > fields are quite different. > > Why in MARC21 100 is a person's name, in UNIMARC it seems to be used quite > differently: > > https://www.ifla.org/g/unimarc-rg/unimarc-authorities-3rd-edition-with- > updates/ > 100 – General Processing Data (update 2018) > > So I think we need at least a check on the marcflavor, but it would be even > nicer if we could pick out the right fields for UNIMARC as well. > > Also I wonder if we could avoid querying the record twice, but someone else > might be better suited to comment on that: > > my $record = GetAuthority($authid); > my $authobj = Koha::Authorities->find($authid); Hi Katrin, Thank you for looking at this bug. I must point out that I did nothing on this bug (exept filing it). Thibaud is the one who wrote the patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:29:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:29:35 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-YTGLT4GkJY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > Hi Katrin, > > Thank you for looking at this bug. > > I must point out that I did nothing on this bug (exept filing it). > Thibaud is the one who wrote the patch :) I am sorry, misreading on my part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:42:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:42:27 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6734-70-yKVRGEPlnG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:47:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:47:15 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29589-70-1yFhV27xJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Agreed, it should be part of the guidelines. Maybe we should wait for bug 29602, it contains several examples of what must be done (if we agree there). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:48:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:48:35 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search In-Reply-To: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27912-70-phwPnQhxxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:51:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:51:54 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-pXVPaEZu6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:51:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:51:58 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-ZqD6vBVIeR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128695|0 |1 is obsolete| | Attachment #128697|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128725&action=edit Bug 29481: Terminology: Collection code, call number This patch corrects an instance of the phrase "Collection code," replacing it with the standard "Collection." To test, apply the patch and restart services. - In the staff interface, go to Administration -> System preferences and set the OpacItemLocation preference to "library, collection code, and call number." - In the OPAC, search the catalog using a term which will return multiple results. - In the search results, item descriptions in the "Availability" line should read like this: [Collection, call number: Non-fiction 394.2663 Bu] Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 09:52:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 08:52:03 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code In-Reply-To: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29481-70-CtfGBqYPPk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128726&action=edit Bug 29481: Terminology: Fix other occurrences of 'Collection code' This changes "collection code" to be "collection" as Koha displays the collection description and no codes. This will also help to make the GUI more consistent overall. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 10:04:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 09:04:14 +0000 Subject: [Koha-bugs] [Bug 29304] Add a first time login page In-Reply-To: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29304-70-O5VZQV08rt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29304 Holly <hc at interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:21:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:21:07 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-vdZRvdOLv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:21:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:21:12 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-7iSzBC8MYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128521|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128727&action=edit Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr The selector is not correct, we must to not rely on the number. This patch fixes a regression caused by bug 28445, but also a long-standing bug. * Regression: The barcode plugin is broken is autoBarcode=<branchcode>yymm0001 There is a JS error in the console: Uncaught TypeError: form.field_value is undefined Focustag_952_subfield_p_878344 Focustag_952_subfield_p_878344_handler jQuery 11 BindEventstag_952_subfield_p_878344 * Long standing bug: If there are several item forms on the same page, the branchcode is not correctly retrieved. For instance on the "Serial edition" page there are 2 item forms, the homebranch that is used by the barcode plugin will be the one from the last form. Test plan: * regression Set autoBarcode=<branchcode>yymm0001 Catalogue a new item, click into the barcode input Notice that without this patch you get a JS error in the console * long standing bug Create a new subscription, select "Create an item record when receiving this serial". Receive a serial Open the 2 item forms ("Click to add item") Select 2 different home library and click the barcode inputs. The prefix (branchcode) should be correct with this patch applied. QA Note: it would be way easier if all add item forms were using the new methods, it could be: let loc = document.getElementsByName('items.homebranch')[0].value; Yes, that's all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:21:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:21:53 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-vvgYWd5p7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Nick Clemens from comment #5) > This works on additem.pl and neworderempty.pl but it fails on > serials-edit.pl - I don't get the branchcode - though that page works before > this patch Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:22:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:22:23 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-N9M4SsMnY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch needs quick attention if we want to have it part of 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:25:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:25:14 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-77sydigCFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Fridolin Somers from comment #24) > We cant change how DT is stringified right ? We can, this is the first option described on bug 29718. I don't think it's worth it. > So we better change how we store. > Maybe a Koha::DateUtils dt_to_sql method ? Hum? I am not sure I understand that part. This is DBMS internals, we cannot modify how we store date/datetime/timestamp. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:29:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:29:14 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-NoYCDTV1ZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #11 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128728&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:31:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:31:11 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-wlYNm7Gzjy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128728|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:45:17 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-OOgWR52gN1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128729&action=edit Bug 29552: Disable today for dates in the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:46:06 +0000 Subject: [Koha-bugs] [Bug 29735] New: Remove flatpickr instantiations from .js files Message-ID: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Bug ID: 29735 Summary: Remove flatpickr instantiations from .js files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 29394 Blocks: 29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 [Bug 29394] Remove flatpickr instantiations from .tt files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:46:06 +0000 Subject: [Koha-bugs] [Bug 29394] Remove flatpickr instantiations from .tt files In-Reply-To: <bug-29394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29394-70-W3VeUi6IXu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29394 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 [Bug 29735] Remove flatpickr instantiations from .js files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:46:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:46:06 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: <bug-29239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29239-70-OWKdF90w8q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 [Bug 29735] Remove flatpickr instantiations from .js files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:46:50 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-iQrT1WRVhj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29735 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #10) > I still see some glitches here: > > 1) Place a hold in staff and set the expiration date > - Yesterday is inactive - OK > - Today doesn't jump to today when clicked, but is still active (not OK) Done > 2) Set a date of birth for a patron > - You can set a date of birth into the future. All options are active an and > work. (possibly not related to this patch?) That does not seem directly related. > 3) Administration > Edit or add a patron category > Set the "Until date" > - Dates in the past are greyed out, Yesterday and Today are active, but > won't select a date (not OK) Opened bug 29735. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:46:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:46:50 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-V01NVTbxT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29552 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:47:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:47:01 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-DPuXCrnOnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:53:57 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-wn5U7LZbIY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #9) > This works well once I applied my follow-up. > > Test plan I followed: > 1. Update CSS (This is a staff client patch.. so yarn build [no --view=opac]) > 2. Follow Davids test plan, but for staff client pages only. It's working without your patch but the cache is hard to clear (?) I had to open a private window to make it work (so with Owen's patch only, not yours). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:54:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:54:07 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-2Cny8X6e2c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:57:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:57:19 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-eFSjfBYOgx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128730&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 11:57:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 10:57:24 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-vLX8L66sDA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #13 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128731&action=edit Bug 29173: (follow-up) add marcflavour preference in conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:04:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:04:54 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-vVF2xXDvxo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Thanks to Katrin for the review, I have modified the patch to add the marcflavour preference in the conditions. Regarding these two lines: "my $record = GetAuthority($authid);" This is to get the contents of the fields in the "authfields" array "my $authobj = Koha::Authorities->find($authid);" This is to retrieve the authority as an object and extract the authority type. If there is a simpler method I'm interested of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:13:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:13:56 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-B0HuXFrU29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 --- Comment #18 from marion.durand at biblibre.com --- Created attachment 128732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128732&action=edit Bug 21903: (follow-up) update documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:18:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:18:53 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-x433iEqxqX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:19:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:19:20 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-fRXuz9lru3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:24:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:24:57 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-JuM7W5eYFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:25:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:25:00 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-Xdsvg7eChr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128733&action=edit Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:30:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:30:22 +0000 Subject: [Koha-bugs] [Bug 29736] New: Error when placing a hold for a club without members Message-ID: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Bug ID: 29736 Summary: Error when placing a hold for a club without members Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a club does not have members and a hold is placed for it, there is a JS error appearing in the console: Uncaught TypeError: err.responseJSON.error is undefined -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 12:31:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 11:31:06 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-ftnSz505uw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- [debug] POST "/api/v1/clubs/1/holds" (72f374a3) [debug] Routing to controller "Koha::REST::V1::Auth" and action "under" [debug] Routing to controller "Koha::REST::V1::Clubs::Holds" and action "add" [warn] OpenAPI <<< POST api/v1/clubs/1/holds [{"message":"Properties not allowed: patron_id.","path":"\/body"}] [debug] 400 Bad Request (0.023515s, 42.526/s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:19:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:19:01 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-rnwQcPIKrA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #8) > Also I wonder if we could avoid querying the record twice, but someone else > might be better suited to comment on that: > > my $record = GetAuthority($authid); > my $authobj = Koha::Authorities->find($authid); Agreed, that certainly could be replaced with my $authority = Koha::Authorities->find($authid); my $record = $authority->record; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:47:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:47:54 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21729-70-WpPJliHxd9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #40 from Florian <florian.bontemps at biblibre.com> --- Here is the test plan I followed, from the 21932. To test flaws: 1) Place a first available hold for the next available item, and set the hold expires date to a short time, like tomorrow. 2) Make sure your ReservesMaxPickUpDelay setting is set for longer that a day. Say 7 days, for example. 3) View the hold. Note the expiration date is set. 4) Check in the item and trigger the hold. See that the item is waiting. Note the expiration is set to the patron's preferred expiration date. 5) Set the priority back to 1, and update the hold. Note that the hold is now an item specific hold instead of a next available hold. 6) Note the expiration stayed. This is okay in this instance. 7) Cancel the hold and start over. 8) Place a first available hold for the next available item, but do not set the hold expires date. 9) View the hold. Note the expiration date is not set. 10) Check in the item and trigger the hold. See that the item is waiting. Not the expiration date is set. 11) Set the priority back to 1, and update the hold. Note that the hold is now an item specific hold instead of a next available hold. 12) Note the expiration stayed. This is not okay in this instance. The patron's hold will disappear after the date! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:49:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:49:36 +0000 Subject: [Koha-bugs] [Bug 29737] New: Cannot suspend holds Message-ID: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Bug ID: 29737 Summary: Cannot suspend holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Hold requests Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com >From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:58:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:58:54 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-rdhR8agefg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124286|0 |1 is obsolete| | Attachment #124287|0 |1 is obsolete| | Attachment #124288|0 |1 is obsolete| | Attachment #124289|0 |1 is obsolete| | Attachment #124290|0 |1 is obsolete| | Attachment #124291|0 |1 is obsolete| | Attachment #124292|0 |1 is obsolete| | Attachment #124293|0 |1 is obsolete| | Attachment #124294|0 |1 is obsolete| | Attachment #124295|0 |1 is obsolete| | Attachment #124296|0 |1 is obsolete| | Attachment #124297|0 |1 is obsolete| | Attachment #124298|0 |1 is obsolete| | Attachment #124299|0 |1 is obsolete| | Attachment #124300|0 |1 is obsolete| | Attachment #124301|0 |1 is obsolete| | Attachment #124302|0 |1 is obsolete| | Attachment #124303|0 |1 is obsolete| | Attachment #124304|0 |1 is obsolete| | Attachment #124305|0 |1 is obsolete| | Attachment #124306|0 |1 is obsolete| | Attachment #124307|0 |1 is obsolete| | Attachment #124321|0 |1 is obsolete| | --- Comment #294 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128734&action=edit Bug 20256: Update database Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create two library groups with some libraries in them, make sure to enable the new feature to limit editing of items 4) Test the functionality, if an item is owned by a library in your group, you should have full editing abilities. If an item is from a different group, you should only be able to make the same changes you would be able to if IndependentBranches were. Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:07 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-AzbVHHgRVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #295 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128735&action=edit Bug 20256: Add new permission to editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:13 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-121l6YkTfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #296 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128736&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:18 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-DUsjTtAPVr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #297 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128737&action=edit Bug 20256: Add new methods for checking item editing permissions Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:24 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-dLNHLc9eOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #298 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128738&action=edit Bug 20256: Update groups editor Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:30 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-NGMLFHp5iR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #299 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128739&action=edit Bug 20256: Use new methods Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:36 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-sMVGwH3mlX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #300 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128740&action=edit Bug 20256: Add unit tests Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:42 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-NScYKF9AXm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #301 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128741&action=edit Bug 20256: (QA follow-up) Remove double negative from code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-vI3U0Nt1TS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #302 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128742&action=edit Bug 20256: (QA follow-up) Change meaning should change code Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 13:59:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 12:59:54 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-sqgTzx9i3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #303 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128743&action=edit Bug 20256: (QA follow-up) test borrowernumber in userenv too Bug 22600 added userenv for scripts, so userenv is defined, but some of values in userenv not Test plan: Run with some params: misc/cronjobs/delete_items.pl --> without this patch you will se error message: Can't call method "can_edit_item" on an undefined value at /home/vagrant/kohaclone/C4/Items.pm line 1748 --> with this patch everything works smoothly Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:00 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-CnOlVSrCtJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #304 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128744&action=edit Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to item.can_be_edited Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:07 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-qgWj8ub7f7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #305 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128745&action=edit Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit this item Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:13 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-OYl4Ul3gS3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #306 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128746&action=edit Bug 20256: (QA follow-up) Handle non-existing userenv Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:19 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-aZfVHg87ky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #307 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128747&action=edit Bug 20256: (QA follow-up) Give existing users with edit_items permission edit_any_item as well Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:24 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-7AjVMluNtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #308 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128748&action=edit Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions for Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:30 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-AVtBCRANoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #309 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128749&action=edit Bug 20256: Mark ft_limit_item_editing as boolean in schema file Signed-off-by: Bob Bennhoff - CLiC <bbennhoff at clicweb.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:36 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-gkPpD4CZIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #310 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128750&action=edit Bug 20256: (QA follow-up) Implement for course reserves Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:42 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-tRDsdc4YQ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #311 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128751&action=edit Bug 20256: (QA follow-up) Implement for item search Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-OtbZzV5VH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #312 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128752&action=edit Bug 20256: Update DB Schema [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:00:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:00:53 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-W32RJsROLe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #313 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128753&action=edit Bug 20256: (follow-up) Fix spelling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:02:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:02:09 +0000 Subject: [Koha-bugs] [Bug 29738] New: koha-run-backups can't use option --uploaded_files from koha-dump Message-ID: <bug-29738-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29738 Bug ID: 29738 Summary: koha-run-backups can't use option --uploaded_files from koha-dump Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: marion.durand at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Depends on: 21903 Bug 21903 add tow options to koha-dump (--uploaded_files and --uploaded_temp_files) but these options can't be used from koha-run-backups. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 [Bug 21903] koha-dump be able to include koha-upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:02:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:02:09 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-hPLcatzp38@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29738 [Bug 29738] koha-run-backups can't use option --uploaded_files from koha-dump -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:09:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:09:51 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-a8PsZK6aFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from marion.durand at biblibre.com --- (In reply to Tomás Cohen Arazi from comment #17) > Ok, a few comments: > - If you add parameters to a koha-* script, you need to add them to the docs > in debian/docs/koha-* as well. This is a blocker, so FQA I just submited a patch to fix that point. > Also > - I don't 100% understand how the uploaded tmp files will be differentiated > from any other file in tmp. The 'get_tmp_path' function name in > koha-functions.sh raised my suspicion, as it doesn't mention 'upload' or > 'uploaded'. This could be revisited too. The function 'get_tmp_path' get the general tmp files but then we complete the path to the uploaded folder with this line: 'uploaded_temp_files_dir="$tempdir/koha_${name}_upload" (tempdir is set just before with 'get_tmp_path' fuction) > - I have the feeling that in order to make this more useful for production, > we could try thinking how this could be used from koha-run-backups. When I > added the 'exclude_indexes' option switch to koha-dump, I also added it to > koha-run-backups. In this case it is not a flag (yes/no) but a string > parameter with a path, so it doesn't sound like a straight-forward addition. > But... maybe an option switch to include/not include uploads on the backup? > Food for thougth, not a blocker. I agree with you but as it doesn't sone simple, I won't do it here. I opened a new bug (Bug 29738) and I'll will add a patch soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:11:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:11:39 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-u4JjQUTjJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:11:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:11:43 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-H3Y53Uuvty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128754&action=edit Bug 29737: Fix suspend from hold list >From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:11:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:11:47 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-rVoutg5Stu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128755&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:12:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:12:18 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-xr2YzgKLcO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is a regression but no idea when it has been introduced! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:12:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:12:28 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-cGt3ZtoKnB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:16:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:16:44 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-voh7BWrOyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128731|0 |1 is obsolete| | --- Comment #16 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128756&action=edit Bug 29173: (follow-up) add marcflavour preference in conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:20:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:20:49 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19532-70-DrDWyA7yaF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Laura Horgan <horganl at middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|horganl at middlesex.mass.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:29:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:29:50 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate No Automatic Renewal Before rule In-Reply-To: <bug-25393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25393-70-RVnvXwr08G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:30:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:30:25 +0000 Subject: [Koha-bugs] [Bug 29727] Koha should respect NoRenewalBeforePrecision when No Renewal Before is unset In-Reply-To: <bug-29727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29727-70-pELJP1jdWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29727 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 14:33:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 13:33:25 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-ICIlCC0L8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:05:07 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14364-70-uh0aPHiVgt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:05:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:05:11 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14364-70-HC6EhFkQiF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120941|0 |1 is obsolete| | Attachment #120942|0 |1 is obsolete| | --- Comment #51 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128757&action=edit Bug 14364: Allow automatically canceled expired waiting holds to fill the next hold Right now, if a library automatically cancels expired waiting holds, a librarian must still re-checkin an item to trap the next available hold for that item. It would be better if the next hold was automatically trapped and the librarians receive an email notification so they can make any changes to the item if need be ( hold area, hold slip in item, etc ). Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with one item 4) Place two holds on that record 5) Check in the item and set it to waiting for the first patron 6) Set ReservesMaxPickUpDelay to 1 7) Enable ExpireReservesMaxPickUpDelay 8) Enable ExpireReservesAutoFill 9) Set an email address in ExpireReservesAutoFillEmail 10) Modify the holds waitingdate to be in the past 11) Run misc/cronjobs/holds/cancel_expired_holds.pl 12) Note the hold is now waiting for the next patron 12) Note a waiting hold notification email was sent to that patron 13) Note a hold changed notification email was sent to the library Signed-off-by: Victoria Faafia <vfaafia29 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:05:16 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14364-70-DVrUNiPRVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #52 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128758&action=edit Bug 14364: (QA follow-up) Generate message for transfers as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:05:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:05:21 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14364-70-jWMJnh15bF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 --- Comment #53 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128759&action=edit Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs This patch removes a duplicated stanza left form moving routine Changes the routines to use inbound_library_address Improves the display if the system preferences Updates the update file Moves smaple notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:17:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:17:26 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-upDknn65fn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:17:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:17:30 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-HtNj493u2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128760&action=edit Bug 29736: Don't return empty clubs There is an error when placing a hold for a club without members: Uncaught TypeError: err.responseJSON.error is undefined It seems that we should remove clubs without members from the search. Test plan: Create 1 club xx with 2 patrons Create 1 club xxx with 1 patron and cancel their enrolment Create 1 club xxxx without patron Place a hold for club "x", only the first one should be returned with this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:17:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:17:40 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-5JiI3jKNmS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:17:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:17:51 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-luakCEmXjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:51:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:51:30 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-LBUAlm40xV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 15:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 14:56:24 +0000 Subject: [Koha-bugs] [Bug 26608] Authorities: linked biblios is inconsistent using elasticsearch and QueryAutoTruncate In-Reply-To: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26608-70-2VqLIpnKw6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26608 --- Comment #3 from Filipe Ribeiro <fribeiro at keep.pt> --- Just realized that the problem also occurs at linked_biblionumbers. https://github.com/Koha-Community/Koha/blob/master/Koha/Authorities.pm#L81 Basically, when simple_search_compat is used, instead of id "1" , its searched "1*". This returns all biblios with authorities that starts with the number 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:04:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:04:05 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21729-70-7mrsqT5HOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:04:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:04:11 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21729-70-6VyOL28A1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 128761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128761&action=edit Bug 21729: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:10:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:10:23 +0000 Subject: [Koha-bugs] [Bug 29739] New: Add a staff counterpart for OPACURLOpenInNewWindow Message-ID: <bug-29739-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29739 Bug ID: 29739 Summary: Add a staff counterpart for OPACURLOpenInNewWindow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The OPAC XSLTs respect pref OPACURLOpenInNewWindow when opening URLs. Would be nice to have something like StaffURLOpenInNewWindow in staff? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:19:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:19:06 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-hZn5DSacgy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:19:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:19:12 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-UWlg2Uh9fl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128762&action=edit Bug 29018: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:19:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:19:18 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-psobp1inls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128763&action=edit Bug 29018: Make DELETE /patrons/:patron_id check things When the route was implemented, the checks were overlooked. This patch adds checks for: - Guarantees - Debts - Current checkouts Any of those will block deletion, as it should. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, the route misses checks 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The three conditions prevent deletion! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:19:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:19:36 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-rPvib5iVFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:21:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:21:59 +0000 Subject: [Koha-bugs] [Bug 29697] Excessive use of StripNonXmlChars In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-2ISuObeDY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- ?(In reply to Katrin Fischer from comment #1) > Hi Joubu, can you give an example for such characters that would be > stripped? I want to help, but not sure about why it was added. Short answer? I don't know. The long answer is a rabbit hole. The regex is 391 $str =~ s/[^\x09\x0A\x0D\x{0020}-\x{D7FF}\x{E000}-\x{FFFD}\x{10000}-\x{10FFFF}]//g; And it's related to: https://en.wikipedia.org/wiki/Valid_characters_in_XML U+0009, U+000A, U+000D: these are the only C0 controls accepted in XML 1.0; U+0020–U+D7FF, U+E000–U+FFFD: this excludes some (not all) non-characters in the BMP (all surrogates, U+FFFE and U+FFFF are forbidden); U+10000–U+10FFFF: this includes all code points in supplementary planes, including non-characters. So, some weird characters/non-characters :) > Maybe it would be enough to do it on import/saving a record? Yes, that's why I was suggesting actually with "Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls." Also note that Galen wrote, as the time: commit b549d7e1f1b7d518e16fa48af7360a38e8233fec Date: Fri Feb 8 16:35:18 2008 -0600 added StripNonXmlChars to C4::Charset "StripNonXmlChars should not necessarily be used, as it may be better to reject a file or record if it contains that kind of encoding error." We ended up using it from almost everywhere, inconsistently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:27:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:27:41 +0000 Subject: [Koha-bugs] [Bug 29697] Excessive use of StripNonXmlChars In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29697-70-caGlh5H8xe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Sounds reasonable to move such checks to import only sections in the codebase (if they are needed at all?). And yes, a logical step would be going to ->record now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 16:32:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 15:32:53 +0000 Subject: [Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference? In-Reply-To: <bug-10591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10591-70-IHHhRgwtZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om --- Comment #5 from Florian <florian.bontemps at biblibre.com> --- Any news on this? We're trying to fix the weird traps behaviors (952$0, $1, $4 and $5) and the fact that there's nothing to prevent a hold on a restricted item seems weird to me. Not even a syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:03:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:03:23 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-7y5ZDlC6Ox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #29 from marion.durand at biblibre.com --- Created attachment 128764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128764&action=edit Bug 9565: Use Koha::Biblio (rebase for 21.05.x) Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:06:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:06:17 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-N3chfRNUCv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #30 from marion.durand at biblibre.com --- (In reply to Andrew Fuerste-Henry from comment #28) > Doesn't apply cleanly to 21.05. Please rebase if needed. Thanks! The first 3 patch apply correctly. I attached the rebased version of the patch "Bug 9565: Use Koha::Biblio" I hope it will do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:20:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:20:17 +0000 Subject: [Koha-bugs] [Bug 29295] Page specific jQuery In-Reply-To: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29295-70-POmO5SqAYh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29295 --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Fridolin Somers from comment #1) > You mean JQuery code added in IntranetUserJS or OPACUserJS ? > > Each page as an id in the body. > For example : > <body id="main_intranet-main" class="intranet-main"> > > So you can create a code loaded just for that page with : > if ( $("body#main_intranet-main").length > 0 ) { That solution is a logical selector. I am talking about jquery that will only be loaded for specific pages. If you look at ANY page source in Koha, you will always see ALL of your jQuery, not just jQuery that relates to that page. Some libraries have a lot of jQuery, and an enhancement of this nature would A) reduce the amount of code that is looked at and processed when the page is loaded, and B) reduce unexpected side effects of jQuery that might affect unintended pages due to mistakes in the Koha or jQuery code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:41:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:41:16 +0000 Subject: [Koha-bugs] [Bug 29740] New: New Organization field Message-ID: <bug-29740-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29740 Bug ID: 29740 Summary: New Organization field Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would suggest we add a new field to the patron record called "organization". Currently we are storing organization names in the surname field. This is inaccurate, and causes some issues between validation (maybe custom validation) and switching from a patron type record and an organization record, especially if anything was left in a first name field at the time. Having a separate organization field would also allow us to correctly record an organization name and a contact at that organization. There are ways around this currently, but typical databases usually include a separate field for an organization name. This would also allow us to more accurately identify organizations with a specific contact person and include lines like "c/o: Joe Smith" under the organization name in notifications. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:52:32 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-qLz3rqegYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:52:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:52:36 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-J0uWTGMckr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128733|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 128765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128765&action=edit Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:55:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:55:05 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-fhQTOSSA9t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes (koha-testing-docker): 1. Apply after applying bug 29552 so that options not selectable are greyed out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:00 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-aAcIuuz4W6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118371|0 |1 is obsolete| | Attachment #118372|0 |1 is obsolete| | Attachment #118373|0 |1 is obsolete| | Attachment #118374|0 |1 is obsolete| | Attachment #118375|0 |1 is obsolete| | Attachment #118376|0 |1 is obsolete| | Attachment #118377|0 |1 is obsolete| | Attachment #118378|0 |1 is obsolete| | Attachment #122692|0 |1 is obsolete| | Attachment #122834|0 |1 is obsolete| | Attachment #122841|0 |1 is obsolete| | Attachment #122858|0 |1 is obsolete| | Attachment #122861|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128766&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:18 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-FkXvmzxnGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128767&action=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:21 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-VPM8vnWHpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128768&action=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:25 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-zEJOY8KpYi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128769&action=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:29 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-dwh9YlbUOP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128770&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:33 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-DOOe9tfXgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128771&action=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:37 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-bU1IqF6FqV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #61 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128772&action=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:41 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-jqKzb3KdqV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128773&action=edit Bug 20817: Update module to use YAML::XS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:45 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-juuY7cEA32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128774&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:49 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-zEguytpiog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128775&action=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:53 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-1HDlMhApCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128776&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:58:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:58:57 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-y7IjzCpIka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #66 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128777&action=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 17:59:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 16:59:52 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-9M7B3adJjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:06:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:06:30 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29585-70-lvQUW9Q7YR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #5 from David Nind <david at davidnind.com> --- Thanks Katrin for the link and how to make his work! Noted for any future bug testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:16:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:16:07 +0000 Subject: [Koha-bugs] [Bug 29741] New: Add Koha::Patron->safe_to_delete Message-ID: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Bug ID: 29741 Summary: Add Koha::Patron->safe_to_delete Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:16:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:16:33 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-Q0onqhy7z7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29018 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:16:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:16:33 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-oXTEcL7iOq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:17:06 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-LVoBZGRNsH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:22:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:22:24 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-IEGxL2fewp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128778&action=edit Bug 29741: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:22:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:22:32 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-AxNZq7mdKv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128779&action=edit Bug 29741: Add Koha::Patron->safe_to_delete This patchset adds a handy method for checking if a patron meets the conditions to be deleted. This conditions are: - Has no linked guarantees - Has no pending debts - Has no current checkouts - Is not the system-configured anonymous user To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => FAIL: Of course heh 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, conditions are validated and the right string is returned on each case 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:29:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:29:14 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-lups3ltLKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #67 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- I'm getting an error trying to test this. With the patch applied, I get a duplicate warning when trying to submit my order, click "Use existing" from the dupe check page, and get this error: Undefined subroutine &C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues called at /kohadevbox/koha/acqui/neworderempty.pl line 652 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:29:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:29:49 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-QFyws5WOR0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:29:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:29:54 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-0VFUx2Bu3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128754|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128780&action=edit Bug 29737: Fix suspend from hold list >From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:30:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:30:00 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-fUxz3LS8NQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128755|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 128781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128781&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:45:37 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-5dMimq6OIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:45:41 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-ZxQopXctG3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128782&action=edit Bug 20817: Fix incorrect namespace for subroutine call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 18:56:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 17:56:19 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-HxBWcNsUBh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #69 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 128783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128783&action=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:14:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:14:25 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-Ix4WHzFVRE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29018 | Depends on| |29018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:14:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:14:25 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-OV0urA2xBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29741 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29741 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 [Bug 29741] Add Koha::Patron->safe_to_delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:15:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:15:01 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-ErO3enzUiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128784&action=edit Bug 29741: (follow-up) Make DELETE /patrons use the new validation method This patch adapts the route so it uses the newly introduced Koha::Patron->safe_to_delete method. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Note: There's a trivial behavior change, in which the 'anonymous patron' use case is caugh eariler than the ->delete call. I left the exception catch block just in case, who knows :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:44:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:44:05 +0000 Subject: [Koha-bugs] [Bug 29742] New: Make deletemem.pl use Koha::Patron->safe_to_delete Message-ID: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 Bug ID: 29742 Summary: Make deletemem.pl use Koha::Patron->safe_to_delete Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This method centralizes the validation logic for allowing/denying patron deletion. Should be used instead of having the logic in the controller. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:44:37 +0000 Subject: [Koha-bugs] [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete In-Reply-To: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29742-70-t0EAuYN3sK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Depends on| |29741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 [Bug 29741] Add Koha::Patron->safe_to_delete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:44:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:44:37 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-oS1oKNNT9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:47:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:47:48 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-fCX67opOCU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:47:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:47:52 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-d6xnnKPUyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128766|0 |1 is obsolete| | --- Comment #70 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128785&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:47:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:47:56 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-RcSh49q3Df@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128767|0 |1 is obsolete| | --- Comment #71 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128786&action=edit Bug 20817: Move subroutines to a new Perl module Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:00 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-J5PY6dpWBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128768|0 |1 is obsolete| | --- Comment #72 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128787&action=edit Bug 20817: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:04 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-lU2OOSgRvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128769|0 |1 is obsolete| | --- Comment #73 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128788&action=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:09 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-Tzda4aoQur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128770|0 |1 is obsolete| | --- Comment #74 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128789&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:13 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-4Izw5aJDtR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128771|0 |1 is obsolete| | --- Comment #75 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128790&action=edit Bug 20817: Remove syspref from parameters, it is invariant Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:17 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-FLoE4ZlGXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128772|0 |1 is obsolete| | --- Comment #76 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128791&action=edit Bug 20817: Fix QA script issues Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:22 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-ldUJs3163o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128773|0 |1 is obsolete| | --- Comment #77 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128792&action=edit Bug 20817: Update module to use YAML::XS Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:26 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-jQjKuYCwpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128774|0 |1 is obsolete| | --- Comment #78 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128793&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:32 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-VFJM0VTdxs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128775|0 |1 is obsolete| | --- Comment #79 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128794&action=edit Bug 20817: _trim should always return a value Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:38 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-Kn5v8C2PyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128776|0 |1 is obsolete| | --- Comment #80 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128795&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:44 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-fYVfTutzak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128777|0 |1 is obsolete| | --- Comment #81 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128796&action=edit Bug 20817: (QA follow-up) Fix _trim The patch 'trim should always return a value' does not completely do the job yet. And might have unwanted effects for the '0' case. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:49 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-OSCRgc6VIa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128782|0 |1 is obsolete| | --- Comment #82 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128797&action=edit Bug 20817: Fix incorrect namespace for subroutine call Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:48:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:48:54 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-P6BptOjaUh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128783|0 |1 is obsolete| | --- Comment #83 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128798&action=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:49:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:49:12 +0000 Subject: [Koha-bugs] [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete In-Reply-To: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29742-70-xDsjgKMnvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 19:56:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 18:56:11 +0000 Subject: [Koha-bugs] [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete In-Reply-To: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29742-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29742-70-gR4icwraDt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128799&action=edit Bug 29742: Make deletemem.pl use Koha::Patron->safe_to_delete This patch makes the deletemem.pl controller script reuse the safe_to_delete method introduced by bug 29741. This way, it will use the same logic as the rest of the Koha pieces, like the API. To test: 1. Verify this conditions make deletion be denied: - Has a guarantee - Is the system-defined anonymous patron - Has outstanding debits - Has items checked out 2. Verify that this conditions display relevant information when trying to delete the patron: - Has outstanding credit - Has holds placed - Has pending suggestions 3. Apply this patch 4. Repeat 1 and 2 => SUCCESS: Things didn't change! [*] 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 20:02:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 19:02:16 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-KULR0fnIZ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fridolin Somers from comment #2) > Arg this is bad. > > We can see there is only one check from Bug 14708 > > Maybe we need to create like for Koha::Item : > safe_to_delete() > safe_delete() Done safe_to_delete on bug 29741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 20:29:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 19:29:47 +0000 Subject: [Koha-bugs] [Bug 29743] New: Importing bad MARC can cause internal server errors in Koha Message-ID: <bug-29743-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29743 Bug ID: 29743 Summary: Importing bad MARC can cause internal server errors in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org MARC data can be imported into Koha that may be invalid and can cause internal server errors when someone attempts to view that records. We should validate MARC data before it is imported into the database to prevent this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 20:56:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 19:56:35 +0000 Subject: [Koha-bugs] [Bug 14210] Manage staged marc records deletes replaced item when undoing import into catalog In-Reply-To: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14210-70-MGr94rmGiH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- This is still true and still bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 21:25:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 20:25:39 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-jXMgAZsdtK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |hayleypelham at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 21:33:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 20:33:42 +0000 Subject: [Koha-bugs] [Bug 29728] upgrade from 21.05 to 21.11 DBI Exception In-Reply-To: <bug-29728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29728-70-fd44FiPccZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29728 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |hayleypelham at catalyst.net.n | |z --- Comment #2 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Duplicate of bug 28267 *** This bug has been marked as a duplicate of bug 28267 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 21:33:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 20:33:42 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-hClj2envi5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juanpablovalles at gmail.com --- Comment #23 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- *** Bug 29728 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 21:52:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 20:52:21 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-AXVOytGlQY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 21:52:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 20:52:24 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-nipFlKbcLZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128727|0 |1 is obsolete| | --- Comment #10 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128800&action=edit Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr The selector is not correct, we must to not rely on the number. This patch fixes a regression caused by bug 28445, but also a long-standing bug. * Regression: The barcode plugin is broken is autoBarcode=<branchcode>yymm0001 There is a JS error in the console: Uncaught TypeError: form.field_value is undefined Focustag_952_subfield_p_878344 Focustag_952_subfield_p_878344_handler jQuery 11 BindEventstag_952_subfield_p_878344 * Long standing bug: If there are several item forms on the same page, the branchcode is not correctly retrieved. For instance on the "Serial edition" page there are 2 item forms, the homebranch that is used by the barcode plugin will be the one from the last form. Test plan: * regression Set autoBarcode=<branchcode>yymm0001 Catalogue a new item, click into the barcode input Notice that without this patch you get a JS error in the console * long standing bug Create a new subscription, select "Create an item record when receiving this serial". Receive a serial Open the 2 item forms ("Click to add item") Select 2 different home library and click the barcode inputs. The prefix (branchcode) should be correct with this patch applied. QA Note: it would be way easier if all add item forms were using the new methods, it could be: let loc = document.getElementsByName('items.homebranch')[0].value; Yes, that's all! Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 22:46:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 21:46:31 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-y8DF1f5iUL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry dude, not 100% sure of the construct here... I feel like 'safe_to_delete' should return a Boolean given it's method name? Perhaps a boolean in scalar context and a Boolean + hash or array of errors as the second slot of an array in list context? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 22:59:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 21:59:13 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-zU6CZZl0Vt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Martin Renvoize from comment #4) > Sorry dude, not 100% sure of the construct here... I feel like > 'safe_to_delete' should return a Boolean given it's method name? > > Perhaps a boolean in scalar context and a Boolean + hash or array of errors > as the second slot of an array in list context? Maybe a Koha::Validation object that validates to a bool, and carries messages in it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 23:00:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 22:00:04 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-MhCGxW4hUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Martin Renvoize from comment #4) > > Sorry dude, not 100% sure of the construct here... I feel like > > 'safe_to_delete' should return a Boolean given it's method name? > > > > Perhaps a boolean in scalar context and a Boolean + hash or array of errors > > as the second slot of an array in list context? > > Maybe a Koha::Validation object that validates to a bool, and carries > messages in it? I replicated Koha::Item's to limit the conflict surface, but...hey... Hehe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 23:20:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 22:20:12 +0000 Subject: [Koha-bugs] [Bug 14210] Manage staged marc records deletes replaced item when undoing import into catalog In-Reply-To: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14210-70-bkweR6Zg9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 23:26:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 22:26:07 +0000 Subject: [Koha-bugs] [Bug 29743] Importing bad MARC can cause internal server errors in Koha In-Reply-To: <bug-29743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29743-70-L2IPAFX6Yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29743 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 23:28:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 22:28:05 +0000 Subject: [Koha-bugs] [Bug 29295] Page specific jQuery In-Reply-To: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29295-70-xOLMadiIkZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29295 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 20 23:29:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 22:29:23 +0000 Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21903-70-tgCeDfDwJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:09:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:09:55 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-LQVqLQaeSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:09:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:09:58 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-mfh5Mgqhu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128780|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128803&action=edit Bug 29737: Fix suspend from hold list >From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:10:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:10:02 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-t3WorhYMCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128781|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128804&action=edit Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:16:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:16:59 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-NsRwuEiEW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:17:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:17:04 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29735-70-MTZFaejAVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128765|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128805&action=edit Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:30:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:30:09 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-Fn63ZO1UQZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:30:13 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-SfC9XcUgmr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128510|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128806&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:30:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:30:17 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-6aW2TEQpdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128511|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128807&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:30:21 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-JzSyeAhSWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128729|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128808&action=edit Bug 29552: Disable today for dates in the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:31:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:31:01 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-nG2Q4SoOtw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tested on top of bug 29735. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:31:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:31:27 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-lrPWCnQOjw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128806|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128809&action=edit Bug 29552: Flatpickr - Disable shortcut buttons if inactive If one of the buttons is not relevant we should disable it and mark is as such on the interface. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:31:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:31:31 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-UaNfzx5KBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128807|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128810&action=edit Bug 29552: (follow-up) Use CSS to set disabled class Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 00:31:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Dec 2021 23:31:36 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29552-70-8DPvVmXI5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128808|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 128811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128811&action=edit Bug 29552: Disable today for dates in the future Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:22:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:22:58 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-XcmUl0oAuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:23:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:23:04 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-rVok7sBbnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128762|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 128812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128812&action=edit Bug 29018: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:23:08 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-9jDLlCGQAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128763|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 128813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128813&action=edit Bug 29018: Make DELETE /patrons/:patron_id check things When the route was implemented, the checks were overlooked. This patch adds checks for: - Guarantees - Debts - Current checkouts Any of those will block deletion, as it should. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, the route misses checks 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The three conditions prevent deletion! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:29:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:29:28 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-O0tWQArD8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |These fixes the REST API release notes| |route for deleting patrons | |so that it now checks for | |guarantees, debts, and | |current checkouts. If any | |of these checks fail, the | |patron is not deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:36:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:36:56 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-ECjBQp8ZMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:36:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:36:59 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-47FkUB8jtX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128778|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 128814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128814&action=edit Bug 29741: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:37:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:37:04 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-DXiQMn5iDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128779|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 128815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128815&action=edit Bug 29741: Add Koha::Patron->safe_to_delete This patchset adds a handy method for checking if a patron meets the conditions to be deleted. This conditions are: - Has no linked guarantees - Has no pending debts - Has no current checkouts - Is not the system-configured anonymous user To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => FAIL: Of course heh 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, conditions are validated and the right string is returned on each case 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:37:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:37:08 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-D1FDW9nZFo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128784|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 128816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128816&action=edit Bug 29741: (follow-up) Make DELETE /patrons use the new validation method This patch adapts the route so it uses the newly introduced Koha::Patron->safe_to_delete method. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Note: There's a trivial behavior change, in which the 'anonymous patron' use case is caugh eariler than the ->delete call. I left the exception catch block just in case, who knows :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:40:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:40:41 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-LNCy1zwU4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement adds a release notes| |handy method for checking | |if a patron meets the | |conditions to be deleted. | |These conditions are: | | | |- | |Has no linked guarantees | |- | |Has no pending debts | |- Has | |no current checkouts | |- Is | |not the system-configured | |anonymous user | | | |It also | |adapts the DELETE /patrons | |route to use the newly | |introduced | |Koha::Patron->safe_to_delet | |e method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 01:42:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 00:42:00 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-Rqc65LIdLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #10 from David Nind <david at davidnind.com> --- I've signed this off, but feel free to change the status if more work is still required (comments 4, 5 and 6). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:27:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:27:28 +0000 Subject: [Koha-bugs] [Bug 29744] New: Harmonize psgi/plack detection methods Message-ID: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 Bug ID: 29744 Summary: Harmonize psgi/plack detection methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org In Bug 29420, C4::Context->is_psgi_or_plack() is introduced to check for psgi/plack environmental variables, since C4::Auth::psgi_env doesn't check for "plack" environmental variables which means psgi/plack detection fails. We should replace C4::Auth::psgi_env calls with C4::Context->is_psgi_or_plack() if possible. We should also use C4::Context->is_psgi_or_plack() instead of manually scanning the %ENV hash for psgi/plack variables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:27:38 +0000 Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29744-70-clyCXoneFN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:27:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:27:38 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-fMTx1TXwDD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 [Bug 29744] Harmonize psgi/plack detection methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:28:21 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-KBxbHxzbnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29744 | --- Comment #28 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #26) > Yes, we should use a single method for the same thing. Here you introduce > is_psgi_or_plack then we should use it from where psgi_env and other similar > checks exist. > > Either here or a separate bug report. > > `git grep "psgi.*ENV"` shows the different occurrences. Ok I've opened bug 29744. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 [Bug 29744] Harmonize psgi/plack detection methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:28:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:28:21 +0000 Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29744-70-4yXbp2MKvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29420 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:28:37 +0000 Subject: [Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods In-Reply-To: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29744-70-0877Ir1d9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29420 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 03:28:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 02:28:37 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29420-70-H1PZZGnVZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 [Bug 29744] Harmonize psgi/plack detection methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 04:34:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 03:34:20 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-gWFVhyrT3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #23 from Alex Buckley <alexbuckley at catalyst.net.nz> --- I've been investigating this. In master, the current patchset does not work. Not just because it doesn't apply cleanly, but also because C4::Reserves->_Findgroupreserve() - called when returning an item - checks if there is a holds-queue title-level match. Returning the first match found. But the problem is when the holds queue sets items for title-level reserves the C4::HoldsQueue->MapItemsToHoldRequests() only checks hold policies regardless of patron category. So I could define that students should not be able to reserve book item types, and yet the holds queue would set a book item for a student's title-levle reserve. I think the holds queue should check the hold policies for a given patron category. I will work on adding that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:03:58 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29330-70-9wHfE8v2B3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #64 from David Cook <dcook at prosentient.com.au> --- (In reply to Kyle M Hall from comment #56) > Pushed to 21.05.x for 21.05.05 Should this be 21.05.06? I only notice it in the git tag v21.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:32:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:32:12 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-4t7KyRUCY1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:32:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:32:22 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-p28NDGXvqY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:32:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:32:32 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-7x8fe4COx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:32:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:32:42 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-gFeXPoCG75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:33:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:33:12 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-8KRM6TjInc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #24 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128817&action=edit Bug 23172: The holds queue should check if a patron category is eligible to reserve an itemtype Currently when mapping items to pending holds the holds queue does not check the circulation rules to determine if the reserving patron category is eligible to reserve the item. This patch fixes that by calling C4::Reserves->CanItemBeReserved() when mapping items to pending reserves. Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Run HoldsQueue.pl 7. Notice in 'Circulation' > 'Holds queue' Patron A is listed as having a hold on the Book 8. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 9. Apply patch and restart services 10. Run HoldsQueue.pl 11. Notice in 'Circulation' > 'Holds queue' Patron A is listed as having a hold on the Continuing resource. Patron B is listed as having a hold on the Book -> These holds conform to the circulation rules 12. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:33:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:33:48 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-jFLUmW0SQ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #25 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Patchset attached and unit tests to come -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:34:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:34:19 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11350-70-UTcshz2Kdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> --- I think this bug report might be a duplicate of bug 23172 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:34:36 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11350-70-vwSXzkUp5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23172 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 05:34:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 04:34:36 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-4yuakqq7Yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11350 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 08:03:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 07:03:51 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-2OV0imNfS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #25) > > > So we better change how we store. > > Maybe a Koha::DateUtils dt_to_sql method ? > > Hum? I am not sure I understand that part. This is DBMS internals, we cannot > modify how we store date/datetime/timestamp. I mean a method to stringify a DT into a string that we store in database. Called "dt_to_sql" as oposite of "dt_from_string($str, 'sql')". We may call it "dt_to_string". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 08:22:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 07:22:53 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-Ew6h05GQ9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #6) > (In reply to Tomás Cohen Arazi from comment #5) > > (In reply to Martin Renvoize from comment #4) > > > Sorry dude, not 100% sure of the construct here... I feel like > > > 'safe_to_delete' should return a Boolean given it's method name? > > > > > > Perhaps a boolean in scalar context and a Boolean + hash or array of errors > > > as the second slot of an array in list context? > > > > Maybe a Koha::Validation object that validates to a bool, and carries > > messages in it? > > I replicated Koha::Item's to limit the conflict surface, but...hey... Hehe I should have read more code for context, happy to stick with this as there's a precidence in Koha::Item.. I thought I'd seen something somewhere but couldn't place it. In the transfers work I threw exceptions and allowed a force option to be passed, but the use case isn't the same. I'd love to see us settle on something consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 09:39:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 08:39:29 +0000 Subject: [Koha-bugs] [Bug 29745] New: Due dates via SIP2 wrong for unique holidays Message-ID: <bug-29745-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29745 Bug ID: 29745 Summary: Due dates via SIP2 wrong for unique holidays Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org A library is reporting that they have added a "Holiday repeating yearly" (orange colour in the calendar) followed by some days of "Unique holiday" (light red colour). When self check machines do checkouts via SIP2, the "Holiday repeating yearly" is respected when calculating the due date, but not the "Unique holiday". For regular checkouts done in the staff interface, due dates are calculated as expected. If they change the "Unique holiday" days to "Holiday repeating yearly" it also works as expected. useDaysMode = Use the calendar to push the due date to the next open day -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:23:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:23:15 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-Dj9mVHEh1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We don't need a to_sql_string.. that's handled already for db date/datetime/timestamp type fields.. in this case we're not dealing with such a field, we're dealing with a varchar.. which allows any ol' string. Does bug 29718 not basically resolve the test failure this introduces? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:31:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:31:17 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-iXrxXlKGRr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #28 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Martin Renvoize from comment #27) > Does bug 29718 not basically resolve the test failure this introduces? I'll test. In error we see : The given date (2021-12-15T16:06:30) does not match the date format (us) Realy strange to see US format there, looks like its a call on "dt_from_string" without explicit format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:37:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:37:46 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-zptkNxtzxU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128702|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128818&action=edit Bug 29696: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:37:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:37:50 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-OVQ8OPkqdv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128703|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128819&action=edit Bug 29696: Preserve link to biblio when creating a suggestion Caused by commit 586bed1319592e05f5dc3acf64a1dba8cae69d6b Bug 28941: Filter suggestion inputs at the OPAC We are loosing the link with the biblio (suggestion.biblionumber) Test plan: At the OPAC, go to the detail page of a bibliographic record, click "Suggest for purchase" and submit the form. Without this patch the suggestion is created but the link to the bibliographic record is lost With this patch applied you should see that suggestions.biblionumber has correctly been preserved Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:38:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:38:07 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-Brsm9zUjUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 11:44:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 10:44:09 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-YqzhA7WxaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, I'll take a deeper look at the code to see what it's doing then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:15:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:15:55 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-NuAqB490xj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK.. I took a deeper look and my assumptions were correct.. so I applied the two patchsets and ran the tests again.. and for me.. they pass as expected?! Are you sure you had both this patchset and bug 29718 applied? It is a bit of a funky test... in smart-rules we actually grab the passed date, convert to a datetime, then convert to an iso string and drop the time component. In the test, we're just passing a DateTime object, so it'll include a time element and it'll contextually stringify using the datetime defaults (to ISO including Time - Hense the 'T'). What is happening in our DateUtils is that we try to match on preference format ('us' in this case which will fail) and then fallback to 'sql/iso'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:16:15 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-wpAykTKUCk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 [Bug 29718] DateTime - our 'iso' is not ISO 8601 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:16:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:16:15 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-o5Rx05WHzZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:36:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:36:54 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-HhlChamyDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:36:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:36:58 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-qj1u6OFkUX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126534|0 |1 is obsolete| | Attachment #126535|0 |1 is obsolete| | Attachment #126536|0 |1 is obsolete| | Attachment #126537|0 |1 is obsolete| | Attachment #126538|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128820&action=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Bug 22785: API files Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:37:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:37:02 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-QE3twIPvGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #49 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128821&action=edit Bug 22785: DO NOT PUSH Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:37:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:37:06 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-TfqyAwO0gk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #50 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128822&action=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:37:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:37:10 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-dHMVhqFbSz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #51 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128823&action=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Ben Daeuber <bdaeuber at cityoffargo.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:37:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:37:14 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-heUQ65aLfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #52 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128824&action=edit Bug 22785: (follow-up) Fix translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:39:36 +0000 Subject: [Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import In-Reply-To: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22785-70-7UFN7pyDnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #53 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #47) > 1) Translatability Updated > > 2) Unrelated file change Removed > I am a little worried about side effects, like with the CLI tools for staged > MARC import, so would like to see those tested as well. There should be no change - previously we just picked the first mathc, now we explicitly mark it as chosen during staging and will then select it during import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:46:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:46:52 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-NPuKrvc5Ko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128825&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:48:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:48:19 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-MiCZlBC8O4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128450|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128826&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:48:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:48:22 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-e31MElwE06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128451|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128827&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:48:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:48:26 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-PLUPI2PFaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128452|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128828&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:48:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:48:30 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-fb18Q0EOcg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128825|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128829&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:48:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:48:49 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-zkoV45gg32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 12:49:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 11:49:21 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29403-70-v0sfiCPbbu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I reversed the dependencies and fixed a badly written test I included here in the first place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:09:30 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28962-70-zeTC9t5xY1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Nind from comment #4) > Signed-off-by: David Nind <david at davidnind.com> Thx for your signoff's, David ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:11:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:11:33 +0000 Subject: [Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages In-Reply-To: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29245-70-rEpsnDd5xz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #19) > (In reply to Marcel de Rooy from comment #17) > > (In reply to Katrin Fischer from comment #16) > > > I count myself as a non-progammer tester as well - I think you mean that we > > > already break the rule for not hardcoding the template, but I think those > > > are bugs we should fix then. Hea shows that having your own OPAC template is > > > not as rare as one would think. > > > > This is an architectural patch, not the popular kind, yes. And insisting > > that it should also fix such occurrences makes it even harder. Since the > > patch is about fixing parameters, I would be tempted to say that it is > > outside the scope too ;) > > > > Having a look now how to get this on track again. But if it takes too much > > time, I will abandon it. > > I didn't mean fixing them on this bug - just that I would consider it a bug > and that we should not add more hardcoded 'bootstraps'. No problem. I understand your point and was willing to revert a few occurrences too. But working further, I decided to refactor a little bit more. Add more tests and at some point my time was up ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:41:15 +0000 Subject: [Koha-bugs] [Bug 15121] runreport.pl cronjob ought to let you specify multiple email addresses In-Reply-To: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15121-70-GDy1r3zh9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> --- Hi, you could add several email with report.pl with a 19.11 version (and previous version also) by spliting the adresses with a comma. For example runreport.pl 683 --format=html --email --to=mail at mail.fr, mail2 at mail.fr It isn't possible anymore since we are in 20.11 version. My colleague Olivier suggest a change in Koha::Email. Could we retrieve this feature ? Thanks Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:41:36 +0000 Subject: [Koha-bugs] [Bug 29365] Koha::Email needs to be refactored In-Reply-To: <bug-29365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29365-70-hQJ7kYsZAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365 Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15121 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:41:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:41:36 +0000 Subject: [Koha-bugs] [Bug 15121] runreport.pl cronjob ought to let you specify multiple email addresses In-Reply-To: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15121-70-zogAdsrlVF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29365 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:42:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:42:20 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-vacmVRcMLn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15121 CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:42:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:42:20 +0000 Subject: [Koha-bugs] [Bug 15121] runreport.pl cronjob ought to let you specify multiple email addresses In-Reply-To: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15121-70-ZO1M0fUtjN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12802 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:42:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:42:43 +0000 Subject: [Koha-bugs] [Bug 29746] New: Add a handy Koha::Boolean class Message-ID: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Bug ID: 29746 Summary: Add a handy Koha::Boolean class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The idea is to provide an OO class that can carry a boolean value, and also useful messages for feedback. An example usage: sub safe_to_delete { my ( $self ) = @_; my $result = Koha::Boolean->new; my $can = 1; if ( condition_1 ) { $can = 0; $result->add_message({ message => 'has_debt' }); } ... if ( condition_n ) { $can = 0; $result->add_message({ message => 'has_guarantees' }); } return $result->set_value($can); } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:43:36 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-2EIvzOHxAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:49:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:49:05 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-tyHaf40m3T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128830&action=edit Bug 29746: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:49:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:49:09 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-Iv1MyoKcc2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128831&action=edit Bug 29746: Add Koha::Boolean This patch introduces a new OO class that can be used as return value from methods that need to return boolean values, but also provide some feedback. This last bit is implemented using Koha::Object::Message objects that can carry valuable information. This class can also implement a `to_api()` method so it is suitable for API usage. And so the Koha::Object::Message class. Will be done as needed. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/Koha/Boolean.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:54:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:54:26 +0000 Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor) for authority records In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22232-70-qydRMIc6id@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232 Afroditi Fragkou <infoscienceaddict at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infoscienceaddict at gmail.com --- Comment #4 from Afroditi Fragkou <infoscienceaddict at gmail.com> --- Couldn't agree more. In fact, if this was to be considered a different bug, I believe it could get many votes from a lot of cataloguers I know... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 13:56:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 12:56:17 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-I3FreidZPd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Martin Renvoize from comment #11) > (In reply to Tomás Cohen Arazi from comment #6) > > (In reply to Tomás Cohen Arazi from comment #5) > > > (In reply to Martin Renvoize from comment #4) > > > > Sorry dude, not 100% sure of the construct here... I feel like > > > > 'safe_to_delete' should return a Boolean given it's method name? > > > > > > > > Perhaps a boolean in scalar context and a Boolean + hash or array of errors > > > > as the second slot of an array in list context? > > > > > > Maybe a Koha::Validation object that validates to a bool, and carries > > > messages in it? > > > > I replicated Koha::Item's to limit the conflict surface, but...hey... Hehe > > I should have read more code for context, happy to stick with this as > there's a precidence in Koha::Item.. I thought I'd seen something somewhere > but couldn't place it. In the transfers work I threw exceptions and allowed > a force option to be passed, but the use case isn't the same. I'd love to > see us settle on something consistent. I filed bug 29746, and provided an implementation. If I get feedback on that, I can re-do this using that which will be much cleaner. It could be done on a follow-up bug if required, and definitely should cover Koha::Item->safe_to_delete as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:17:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:17:15 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-JDAiJ6JkvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + $debit_line = $self->account->add_debit( + { + amount => $amount, + user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef, I would expect $self->borrowernumber here instead of going to context? Note btw that this field (in debit lines) user_id is chosen VERY unfortunate. We already had the mixup on the other report. It should be renamed (but not here). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:17:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:17:42 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-pGBjMDoh6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Few comments forthcoming still -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:18:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:18:50 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-Y2r0Itik7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Seeing Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 373. Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 378. Typo patron's categor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:19:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:19:45 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-vCGlnBKDpg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 --- Comment #31 from marion.durand at biblibre.com --- Created attachment 128832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128832&action=edit Bug 9565: (follow-up) Adapt batch record deletion tool (rebase for 21.05.x) Add a column "Subscriptions" to the batch deletion tools Add a link on the number of subscription to the search page with all the subscriptions of the record Add a button in the toolbar to select only biblio record without subscriptions The changes are only on display It is still possible to delete records that are attached to subscriptions from this tool (as it is possible for records with attached items) To test: 1) Go to the batch record deletion (in tools) 2) Select a list of record numbers (select some with one or more subscription) 3) Click on Continue 4) Check that there is no column named "Subscription" and that there is no button "Select without subscription" in the toolbar 5) Apply patch 6) Repeat steps 1 to 3 7a) Check that there is a column named "Subscription" fill with the number of subscriptions attached to the record 7b) Check that the link in the subscriptions column send you to the search page with the subscriptions linked to this record 7c) Check that there is a button "Select without subscription" in the toolbar that selects record with no subscription attached 8) Sign off Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:20:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:20:17 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-SzrumV1xGV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Personally do not likes changes like this: - [%- CASE 'ACCOUNT' -%]Account creation fee - [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee - [%- CASE 'LOST' -%]Lost item - [%- CASE 'MANUAL' -%]Manual fee - [%- CASE 'NEW_CARD' -%]New card - [%- CASE 'OVERDUE' -%]Fine - [%- CASE 'PROCESSING' -%]Lost item processing fee - [%- CASE 'RENT' -%]Rental fee - [%- CASE 'RENT_DAILY' -%]Daily rental fee - [%- CASE 'RENT_RENEW' -%]Renewal of rental item - [%- CASE 'RENT_DAILY_RENEW' -%]Renewal of daily rental item - [%- CASE 'RESERVE' -%]Hold fee - [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long - [%- CASE 'Payout' -%]Payout - [%- CASE -%][% debit_type.description | html %] + [%- CASE 'ACCOUNT' -%]Account creation fee + [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee + [%- CASE 'ARTICLE_REQUEST_FEE' -%]Article scan request fee + [%- CASE 'LOST' -%]Lost item + [%- CASE 'MANUAL' -%]Manual fee + [%- CASE 'NEW_CARD' -%]New card + [%- CASE 'OVERDUE' -%]Fine + [%- CASE 'PROCESSING' -%]Lost item processing fee + [%- CASE 'RENT' -%]Rental fee + [%- CASE 'RENT_DAILY' -%]Daily rental fee + [%- CASE 'RENT_RENEW' -%]Renewal of rental item + [%- CASE 'RENT_DAILY_RENEW' -%]Renewal of daily rental item + [%- CASE 'RESERVE' -%]Hold fee + [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long + [%- CASE 'Payout' -%]Payout + [%- CASE -%][% debit_type.description | html %] If you want to add one line, why change 20 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:20:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:20:44 +0000 Subject: [Koha-bugs] [Bug 29747] New: Cataloguing upload plugin broken Message-ID: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Bug ID: 29747 Summary: Cataloguing upload plugin broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When 856$u has plugin 'upload.pl' attached, the choosing of the record fails because of a dataTables error. When fetching the column settings, we need to account for the fact that the plugin has 2 fewer columns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:22:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:22:07 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-zVAHG7JEFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:22:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:22:29 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-tq5zXAZEZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- The most important comment as last in the row: There is no handling of the cancellation. We need to provide a credit. Remarkable that we miss it here, since it was the reason for holding back the whole thing earlier? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:27:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:27:51 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-BNVXvWpsZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #54) > Personally do not likes changes like this: > > - [%- CASE 'ACCOUNT' -%]Account creation fee > - [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee > - [%- CASE 'LOST' -%]Lost item > - [%- CASE 'MANUAL' -%]Manual fee > - [%- CASE 'NEW_CARD' -%]New card > - [%- CASE 'OVERDUE' -%]Fine > - [%- CASE 'PROCESSING' -%]Lost item processing fee > - [%- CASE 'RENT' -%]Rental fee > - [%- CASE 'RENT_DAILY' -%]Daily rental fee > - [%- CASE 'RENT_RENEW' -%]Renewal of rental item > - [%- CASE 'RENT_DAILY_RENEW' -%]Renewal of daily rental item > - [%- CASE 'RESERVE' -%]Hold fee > - [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long > - [%- CASE 'Payout' -%]Payout > - [%- CASE -%][% debit_type.description | html %] > + [%- CASE 'ACCOUNT' -%]Account creation fee > + [%- CASE 'ACCOUNT_RENEW' -%]Account renewal fee > + [%- CASE 'ARTICLE_REQUEST_FEE' -%]Article scan request fee > + [%- CASE 'LOST' -%]Lost item > + [%- CASE 'MANUAL' -%]Manual fee > + [%- CASE 'NEW_CARD' -%]New card > + [%- CASE 'OVERDUE' -%]Fine > + [%- CASE 'PROCESSING' -%]Lost item processing fee > + [%- CASE 'RENT' -%]Rental fee > + [%- CASE 'RENT_DAILY' -%]Daily rental fee > + [%- CASE 'RENT_RENEW' -%]Renewal of rental item > + [%- CASE 'RENT_DAILY_RENEW' -%]Renewal of daily rental item > + [%- CASE 'RESERVE' -%]Hold fee > + [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long > + [%- CASE 'Payout' -%]Payout > + [%- CASE -%][% debit_type.description | html > %] > > If you want to add one line, why change 20 ? We do that to keep the indentation, I would do it again anytime it is needed :-D That said, I think I can remove the trailing _FEE and avoid it this time! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:29:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:29:13 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-AxaFA1tu07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:29:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:29:16 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-PyzB2dC8MB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128833&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:29:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:29:34 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-tZGMiCkTRs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:30:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:30:05 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-fPrRoiczQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #57 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #51) > + $debit_line = $self->account->add_debit( > + { > + amount => $amount, > + user_id => C4::Context->userenv ? > C4::Context->userenv->{'number'} : undef, > > I would expect $self->borrowernumber here instead of going to context? > Note btw that this field (in debit lines) user_id is chosen VERY > unfortunate. We already had the mixup on the other report. It should be > renamed (but not here). the 'user_id' parameter accounts for the currently logged user recording the debit. So the staff member that added the debit. I think it is correct to fallback to userenv as it is the accountlines.manager_id attribute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:30:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:30:33 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-mz8aYprgki@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 [Bug 28177] Add date column and column configuration to uploads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:30:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:30:33 +0000 Subject: [Koha-bugs] [Bug 28177] Add date column and column configuration to uploads In-Reply-To: <bug-28177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28177-70-zYyg0uruCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28177 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29747 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 [Bug 29747] Cataloguing upload plugin broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:30:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:30:34 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-QNkbkTwtGx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #53) > Seeing > > Argument "" isn't numeric in numeric gt (>) at > /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article. > tt line 373. > Argument "" isn't numeric in numeric gt (>) at > /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article. > tt line 378. > > Typo patron's categor Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:32:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:32:00 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-wCi7uVP7Vd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #59 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #55) > The most important comment as last in the row: There is no handling of the > cancellation. We need to provide a credit. > Remarkable that we miss it here, since it was the reason for holding back > the whole thing earlier? Yes! My thinking was: Koha currently provides ways to restore credit. So what we are talking about is an automatic way to do it. My plan is to do it on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:32:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:32:18 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-G1pcIzoetn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #57) > > the 'user_id' parameter accounts for the currently logged user recording the > debit. So the staff member that added the debit. I think it is correct to > fallback to userenv as it is the accountlines.manager_id attribute. Ah ok. You will be right. Well it even more demonstrates that this field name was picked very badly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:33:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:33:26 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-RP6DI7LTWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #59) > (In reply to Marcel de Rooy from comment #55) > > The most important comment as last in the row: There is no handling of the > > cancellation. We need to provide a credit. > > Remarkable that we miss it here, since it was the reason for holding back > > the whole thing earlier? > > Yes! > > My thinking was: Koha currently provides ways to restore credit. So what we > are talking about is an automatic way to do it. My plan is to do it on a > separate bug. If it is just as simple as adding a credit, I would say do it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:42:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:42:01 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-TwbFGU6Up4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #32 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:53:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:53:33 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-XA8dvtSsLW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:53:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:53:43 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-S8IlAV32kv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128830|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 128834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128834&action=edit Bug 29746: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:53:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:53:51 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-V6OdQ25FCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128831|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128835&action=edit Bug 29746: Add Koha::Boolean This patch introduces a new OO class that can be used as return value from methods that need to return boolean values, but also provide some feedback. This last bit is implemented using Koha::Object::Message objects that can carry valuable information. This class can also implement a `to_api()` method so it is suitable for API usage. And so the Koha::Object::Message class. Will be done as needed. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/Koha/Boolean.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:56:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:56:15 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-VC29gWrfiB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:56:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:56:17 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-7EZGgNcRmm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:56:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:56:45 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-5dwwNclLJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128836&action=edit Bug 29736: Don't return empty clubs There is an error when placing a hold for a club without members: Uncaught TypeError: err.responseJSON.error is undefined It seems that we should remove clubs without members from the search. Test plan: Create 1 club xx with 2 patrons Create 1 club xxx with 1 patron and cancel their enrolment Create 1 club xxxx without patron Place a hold for club "x", only the first one should be returned with this patch. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:56:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:56:51 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-3NqA92UvPH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128837&action=edit Bug 29736: Restore searching Without this patch, the list will always display all clubs. To test: 1. Have two clubs, with enrollemnts: - Cthulhu fans - The Shadow Out of Time fans 2. Search for the letter c => FAIL: You get both results 3. Apply this patch 4. Repeat 2 => SUCCESS: Only Cthulhu is returned 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:56:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:56:55 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29736-70-VrqyhR9NcI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128838&action=edit Bug 29736: (QA follow-up) No need to delete all clubs There's no real need to delete all the existing clubs in the tests. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 14:58:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 13:58:48 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29737-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29737-70-W2k2qYgL0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 15:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 14:09:23 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-Ye1EPquqPX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 15:09:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 14:09:26 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-ItBthGqaMu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128833|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128839&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 15:17:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 14:17:32 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29718-70-jQz5UNGpZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 128840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128840&action=edit Bug 29718: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 15:56:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 14:56:47 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28786-70-GNTA4MP9x8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128841&action=edit Bug 28786: DO NOT PUSH - DBIx schema changes Added for testing purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:00:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:00:52 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-dVWnN0T1kC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:00:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:00:57 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-mpoWTcHFAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:01:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:01:02 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-BEdpIAL7ay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128662|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:01:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:01:06 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-EO4588PbLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:01:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:01:09 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-Rd4RscRc8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:01:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:01:13 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-syWq2gFARe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:06:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:06:15 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9097-70-KNBpPmovMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #7 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- +1 Sending a welcome email is a really great way to engage new users. Owen's suggestion for how this could work sounds great. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:12:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:12:42 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28786-70-oHVK4Nf894@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128842&action=edit Bug 28786: (QA follow-up) Upgrade atomicupdate to new style Test plan: Run dbrev again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:23:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:23:05 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29702-70-WHMmhbIcVk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 16:23:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 15:23:08 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29702-70-W65BtBZ9d9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128572|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128843&action=edit Bug 29702: fetch group libraries in a single call The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursively calls itself if a group. This slows down performance. We can utilize the 'libraries' method to get all child libraries at once, then make a check for child groups separately To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection 8 - Apply patch 9 - note improvement 10 - prove -v t/db_dependent/Koha/Libraries.t Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 17:11:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 16:11:07 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-dUTyrY08q6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 17:11:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 16:11:10 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-fxhDzYo22D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120102|0 |1 is obsolete| | Attachment #127584|0 |1 is obsolete| | Attachment #127585|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128844&action=edit Bug 19318: DO NOT PUSH - SCHEMA CHANGES Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 17:11:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 16:11:14 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-1ol9Yzc8vA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128845&action=edit Bug 19318: Allow multiple storage spaces for file uploads This patch allow to configure multiple storage spaces to be used when uploading a file. Configuration is done in $KOHA_CONF. Element 'upload_path' is replaced by 'storage', which is repeatable and can contain the following elements: - name: The storage's identifier (also used for display) - adapter: The storage's adapter is a Perl module who is responsible for actually writing in the storage (creating/deleting files/directories). There is actually only one adapter, 'directory', which writes directly on the filesystem. - adapter_params: Additional parameters required for the storage's adapter - hash_filename: Whether to prepend hashvalue to the filename or not - temporary: Whether the storage is temporary or not - baseurl: Base URL of the storage, if one doesn't want to (or can't) use opac-retrieve-file.pl This is all documented in Koha::Storage There is two built-in storages: - 'TMP', the default temporary storage (not configurable) - 'DEFAULT', the default persistent storage (configurable in $KOHA_CONF) Note that if $KOHA_CONF is not updated, uploads should continues to work (the 'DEFAULT' storage will use 'upload_path', if set) This patch affects the following pages: - Tools › Upload - Tools › Upload local cover image (ZIP file upload) - Tools › Stage MARC records for import - Tools › Upload patron images - Circulation › Offline circulation file upload - Cataloguing plugin upload.pl Test plan: 0. Before applying the patch, be sure to use the pages mentioned above and upload some files, those files should continue to be accessible after the patch 1. Apply the patch, run updatedatabase and update_dbix_class_files 2. Without modifying $KOHA_CONF, verify that files uploaded in step 0 are still accessible (you can find them in tools/upload.pl) 3. Verify that you can still upload files using the pages mentioned above 4. Edit your $KOHA_CONF, copy the <storage> element from etc/koha-conf.xml in the source, set the <path> using the value of <upload_path> and remove <upload_path> 5. Verify that you can still upload files 6. Add another storage in $KOHA_CONF, set <hash_filename> to 0, and a <baseurl>. Now try to use the cataloguing plugin and see how the generated URL change. Also note that the files keep their original filename (without the hashvalue prepended) 7. Create some subdirectories under the main storage's path (using a shell). Try to upload a new files and see that these directories appear in a dropdown list. Select one, finish the upload and verify that the file has been uploaded to the selected subdirectory. 8. Run prove t/ImportBatch.t t/Koha/Storage.t t/db_dependent/ImportBatch.t t/db_dependent/Upload.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 17:11:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 16:11:18 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-xso9EU6Z4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128846&action=edit Bug 19318: Normalize uploaded file name The uploaded file name can appear in the MARC record (if using the upload plugin), and all the strings in the MARC record are normalized using Unicode::Normalize::NFC. So the file name must be normalized everywhere (in the filesystem and in the uploaded_files table too). Test plan: 1. Create a file whose name contains combining characters. For instance: echo 'contents' > $(perl -e 'print "cine\x{cc}\x{81}ma"') 0xcc 0x81 is utf8 for "Combining acute accent" (́ ) https://unicode-table.com/fr/0301/ Once normalized it should be 0xc3 0xa9 (é) 2. Use the upload tool to upload this file 3. Verify on your filesystem that the filename is normalized % ls cin* | xxd 00000000: 6369 6ec3 a96d 610a cin..ma. ^^ ^^ 4. If you have configured the storage with a `baseurl`, use the upload cataloguing plugin, and verify that the generated URL works correctly Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 17:11:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 16:11:22 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19318-70-kqf6bFq2YG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128847&action=edit Bug 19318: (follow-up) remove uploadcategory column from tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:10:49 +0000 Subject: [Koha-bugs] [Bug 29726] ulactioncontainer on opac-detail.pl needs to be closer to top on small devices In-Reply-To: <bug-29726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29726-70-XtGqqkcKz4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29726 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:11:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:11:48 +0000 Subject: [Koha-bugs] [Bug 29720] Allow per-user customization of table settings In-Reply-To: <bug-29720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29720-70-pyiwZenfm1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29720 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:12:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:12:28 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: <bug-29713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29713-70-dcwxEtx9px@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:16:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:16:25 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-DXNscM7ZfP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:53:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:53:27 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20747-70-SdWxSTpevm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #6 from Lisette Scheer <lisetteslatah at gmail.com> --- But 22284 did not fix this issue. It only limited completely to the group, rather than prioritizing the group and then going out of the group, similarly to Bug 12004 but to allow just group prioritization and not branch prioritization. The reason that using just the transportation cost matrix doesn't just do this has to do with when an item is already checked out and returned, it'll send the item far away and then when the copy for the far away branch comes in, it gets routed up to us. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 18:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 17:55:20 +0000 Subject: [Koha-bugs] [Bug 12004] Regional preference on holds In-Reply-To: <bug-12004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12004-70-x4fMaYOsxX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 --- Comment #2 from Lisette Scheer <lisetteslatah at gmail.com> --- (In reply to Katrin Fischer from comment #1) > I wonder if we need this to be a separate thing or something that you could > calculate into your cost matrix - libraries in the same region get lower > 'cost values' than those outside the region. > So the cost values work for holds to pull lists but not for items that are checked out and then have holds when they are returned. It makes it take longer for patrons to receive holds and a lot of items spend more time in the courier than if the patron waited a couple extra days for their copies to come in. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 19:34:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 18:34:32 +0000 Subject: [Koha-bugs] [Bug 27086] Add a both/most restrictive option for ReservesControlBranch In-Reply-To: <bug-27086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27086-70-ETQMKy5IRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27086 --- Comment #2 from AspenCat Team <aspencatteam at clicweb.org> --- Here are scenarios that ByWater came up with that generally describe how this would work. Scenario 1: Libraries A, B, C, and D in a consortium A, B, C all have DVDS and will share these items with other libraries Library D doesn't have any DVDs and is not allowed to request other libraries DVDs. Library A, B, C set their hold policy to any library can place a hold With the proposed development, Library D sets a rule to say no holds allowed on DVDs (because they don't have them and patrons can't have anybody else's). The new logic of checking item AND patron library would result in no hold being allowed by patrons from library D, but would be allowed by A,B, C Scenario 2: Libraries A, B, C, and D in a consortium A, B, C all have DVDS and will share these items with other libraries Library D has DVDs but does NOT allow others to request their DVDs and as a result their patrons are not allowed to request other libraries DVDs. Library A, B, C set their hold policy to any library can place a hold With the proposed development, Library D sets a hold policy rule that specifies 'HOME library '. The logic here is a bit murkier as the hold is allowed by A,B,C libraries but 'obliquely' points to patrons of D being the only ones allowed to place holds so the software needs to know that also means they are NOT allowed to place holds on others DVDs. Note: this logic starts to include some assumptions and becomes a tad grey Scenario 3: Libraries A, B, C, D, and E are in a consortium Libraries A,B, C and in a library group (a school district, or small town with 3 branches for example) All the libraries have DVDs, but Group A,B,C only want to share their DVDs with themselves and not with D or E. A,B,C all share together, D and E share together, but D and E can't request A,B,C and A,B,C can't request D or E. This is what branch transfer limits is effectively doing for you now - albeit in a difficult way to administer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 19:45:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 18:45:17 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-e6SRGhTnbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #157 from Lucas Gass <lucas at bywatersolutions.com> --- Aleisha, This is a very nice looking feature! A couple things I noticed while testing: 1. If I make a page for the OPAC or both and click the 'View' link I get a 404 error at: http://localhost:8080/cgi-bin/koha/page.pl?page_id=7 In the OPACMoreSearches line the link is build correctly as http://localhost:8080/cgi-bin/koha/opac-page.pl?page_id=7 and I can see it without 404. 2. IF I click on the dropdown-toggle arrow next to the view button I see the 2 options 'View on OPAC' and 'View on staff client'. They work good. However, if the page is set for staff only or OPAC only when I click the button nothing happens. Thanks for working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 20:28:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 19:28:06 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29330-70-D88E1BgWzs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #65 from Victor Grousset/tuxayo <victor at tuxayo.net> --- About the backport for 20.11, the conflict was a bit though to solve but the test plan works as expected. I also tested a hold notice. So I hope nothing is broken. Is there anything else I must test before pushing this for the next release? For the record here is a branch with the backport: https://gitlab.com/tuxayo/Koha/-/commits/20.11.x-with-29330-attempt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 21:13:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 20:13:30 +0000 Subject: [Koha-bugs] [Bug 29748] New: Most Wanted/Lucky Day Items Message-ID: <bug-29748-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29748 Bug ID: 29748 Summary: Most Wanted/Lucky Day Items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries have a Most Wanted or Lucky Day collections. These collections are not holdable and are for patrons physically in the building to discover and checkout. The idea is that patrons that rely more on browsing in the library rather than use the OPAC rarely see popular books that are never on the shelf. Another approach to this might be to have a Most Wanted / Lucky Day setting or status on an individual item, where, if active, would allow holds, but once the item is checked in, it will not trigger a hold for x amount of days. This would allow the item to go back on the shelf or on display for a while before going to the next hold, giving local browsers an opportunity to stumble upon the item. Any thoughts on this idea? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 21:32:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 20:32:50 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-MX9I3KgwGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 21:32:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 20:32:53 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29722-70-57uNUZR1R6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128643|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128848&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 21:56:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 20:56:07 +0000 Subject: [Koha-bugs] [Bug 29639] OPAC cart and staff cart are not consistent In-Reply-To: <bug-29639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29639-70-W9tsbjhGI8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29639 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 22:18:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 21:18:48 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28919-70-JHGrjQsxAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #16) > I like Jonathan's patch here, it does what libraries have indicated they > want. Though I agree that on initial page load all dropdowns (the overall > dropdown at the top and the individual dropdowns on each title) should > default to the logged in branch if that's a valid pickup location. > > But if the logged-in branch is not a valid pickup location for one of the > titles, then that title's dropdown should be blank to start and require one > to select a valid pickup location before the form can be submitted. +1 I think this would be behavior that is consistent with that Tomas did in Bug 29349 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 22:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 21:20:40 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29585-70-FnPXjkHMhJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the 'Go to release notes| |field' and 'Errors' strings | |in the basic MARC editor to | |make them translatable. | |(This is a follow-up to bug | |28694 that changed the way | |validation error messages | |are displayed when using | |the basic MARC editor in | |cataloging.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 22:36:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 21:36:57 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29338-70-Zxe9oumAp5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 22:37:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 21:37:00 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29338-70-heZ9rPep57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128849&action=edit Bug 29338: (follow-up) only show print button when hold is waiting or intransit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 23:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 22:11:32 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-bXrru8z8h4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 23:27:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 22:27:27 +0000 Subject: [Koha-bugs] [Bug 29749] New: Clean up OpacStarRatings Message-ID: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 Bug ID: 29749 Summary: Clean up OpacStarRatings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org While working on Bug 29280 I noticed there is some different code related to OpacStarRatings that could be consolidated a bit. OPAC pages that include OpacStarRatings are: -OPAC detail -OPAC user summary -OPAC reading history -OPAC results Sometimes a logged in user can interact with the ratings (OPAC detail, user summary, reading history ) Other times they cannot ( results ) A bit of cleanup here can make it easier to implement OPACStarRatigs elsewhere, like on the list displays in Bug 29280. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 23:30:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 22:30:49 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: <bug-28152-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28152-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28152-70-Yv3kK0AB1q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleypelham at catalyst.net.n | |z --- Comment #2 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Hi Jonathan, I tried to test this but the patch didn't seem to fix the behaviour. What I did: 1) Exported record with an item, confirmed contained 952 data 2) Staged for import with default parameters 3) Imported record with Always add items 4) import_items contained a new row import_items_id | import_record_id | itemnumber | branchcode | status | marcxml | import_error | +-----------------+------------------+------------+------------+--------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------+ | 1 | 1 | 0 | NULL | error | <?xml version="1.0" encoding="UTF-8"?> <collection xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd" xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00000 a </leader> <datafield tag="952" ind1=" " ind2=" "> <subfield code="0">0</subfield> <subfield code="1">0</subfield> <subfield code="4">0</subfield> <subfield code="6">_</subfield> <subfield code="7">0</subfield> <subfield code="8">REF</subfield> <subfield code="9">192</subfield> <subfield code="a">FPL</subfield> <subfield code="b">FPL</subfield> <subfield code="c">GEN</subfield> <subfield code="d">2014-09-04</subfield> <subfield code="p">39999000003697</subfield> <subfield code="r">2014-09-04</subfield> <subfield code="w">2014-09-04</subfield> <subfield code="y">BK</subfield> </datafield> </record> </collection> | NULL | 5) Checked imported record with View button in Manage staged MARC import and saw that there were no items associated with record 6) Applied patch and restarted services 7) Repeated steps 2-3 8) import_items contained a new row | 2 | 2 | NULL | NULL | error | <?xml version="1.0" encoding="UTF-8"?> <collection xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd" xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00000 a </leader> <datafield tag="952" ind1=" " ind2=" "> <subfield code="0">0</subfield> <subfield code="1">0</subfield> <subfield code="4">0</subfield> <subfield code="6">_</subfield> <subfield code="7">0</subfield> <subfield code="8">REF</subfield> <subfield code="9">192</subfield> <subfield code="a">FPL</subfield> <subfield code="b">FPL</subfield> <subfield code="c">GEN</subfield> <subfield code="d">2014-09-04</subfield> <subfield code="p">39999000003697</subfield> <subfield code="r">2014-09-04</subfield> <subfield code="w">2014-09-04</subfield> <subfield code="y">BK</subfield> </datafield> </record> </collection> | NULL | 9) Record still didn't have an item associated Please let me know if I've missed some step! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 21 23:56:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 22:56:22 +0000 Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be logged out In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23102-70-Q7rWu6wELW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleypelham at catalyst.net.n | |z --- Comment #14 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:01:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:01:03 +0000 Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings In-Reply-To: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29749-70-P6bfGULiqI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:01:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:01:07 +0000 Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings In-Reply-To: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29749-70-S5BUE6pj9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 128850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128850&action=edit Bug 29749: Clean up OpacStarRatings code To test: 1. Apply patch 2. Make sure OpacStarRatings is set to 'results, details, patrons' 3. Check out some items to a patron you can login to the OPAC as 4. Do a OPAC catalog search that will turn up some of those items you checked out 5. Go to the item's detail pages, logged in as the patron with those checkouts 6. From the detail page, rate some of those items. 7. Go to the user summary page, make sure you can see and change the ratings from there. 8. Go to the reading history page, make sure you can see and change those ratins from there. 9. Go back to the detail pages and make sure any changes you made on the user summary and reading history page are acuratly reflected 10. Look at those items from the results page. You should be able to view the ratings but not change them. 11. Again visit the OPAC, this time as a unauthenticated user. You should be able to view the ratings from the details page but not interact with them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:02:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:02:34 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-P6ZAYM1UKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleypelham at catalyst.net.n | |z --- Comment #2 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- I get an error after applying the patch and using a name with an accent to request the token Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_admin_share_content_2epl::encode_json called at /home/vagrant/kohaclone/admin/share_content.pl line 70 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:04:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:04:04 +0000 Subject: [Koha-bugs] [Bug 29280] Add star ratings to OPAC lists display In-Reply-To: <bug-29280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29280-70-PxIrVo21SG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29280 --- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> --- I filed Bug 29749 to clean up OpacStarRatings a bit. If it is pushed it will make adding OpacStarRatings to lists easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:13:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:13:43 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-n27ZDOl28n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:13:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:13:47 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-eEfOKLcdvF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 --- Comment #3 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128851&action=edit Bug 28332: (follow-up) Include encode_json method in admin/share_content.pl Test plan: - Go to Administration Share content with Mana KB (cgi-bin/koha/admin/share_content.pl) - In "Configure Mana KB" part, set your email and a name with accent (Université Foo), - Click on "Send to Mana KB" => Fail. No mana token. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:15:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:15:19 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-Xlwm8zT8et@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120884|0 |1 is obsolete| | --- Comment #4 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128852&action=edit Bug 28332: Fix data encoding when requesting Mana token -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:15:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:15:43 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-FeWITi48v9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128851|0 |1 is obsolete| | --- Comment #5 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128853&action=edit Bug 28332: (follow-up) Include encode_json method in admin/share_content.pl Test plan: - Go to Administration Share content with Mana KB (cgi-bin/koha/admin/share_content.pl) - In "Configure Mana KB" part, set your email and a name with accent (Université Foo), - Click on "Send to Mana KB" => Fail. No mana token. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:17:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:17:54 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-vXjXBSXSVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128852|0 |1 is obsolete| | --- Comment #6 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128854&action=edit Bug 28332: Fix data encoding when requesting Mana token Authored-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:18:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:18:41 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-Oo74aWO44k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128853|0 |1 is obsolete| | --- Comment #7 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128855&action=edit Bug 28332: (follow-up) Include encode_json method in admin/share_content.pl Test plan: - Go to Administration Share content with Mana KB (cgi-bin/koha/admin/share_content.pl) - In "Configure Mana KB" part, set your email and a name with accent (Université Foo), - Click on "Send to Mana KB" => Fail. No mana token. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 00:29:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Dec 2021 23:29:04 +0000 Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings In-Reply-To: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29749-70-AoIyTeQ5ay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 01:58:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 00:58:12 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: <bug-29511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29511-70-ekHUxZQtwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 01:58:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 00:58:16 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: <bug-29511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29511-70-4mImypG0zG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127955|0 |1 is obsolete| | --- Comment #3 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Created attachment 128856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128856&action=edit Bug 29511: Sort hash keys This code exists in authorities/authorities.pl and the hash keys are sorted I just do the same here To test: 1 - Find/create a record with 245a 245h populated 2 - Load/reload the record several times and note that fields c and b are ordered randomly 3 - Apply patch 4 - Reload and note c and b are ordered alphabetically 5 - Move subfield h before subfield c 6 - Save and reload 7 - Confirm that existing/filled fields retain order in the MARC record Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 02:14:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 01:14:55 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-YuQ6SE6GDm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z --- Comment #28 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Hello, What needs signing off here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 04:21:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 03:21:15 +0000 Subject: [Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-RrsJCLfw9r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #26 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128857&action=edit Bug 23172: Unit test for holds queue Test plan: 1. sudo koha-shell <instance> 2. prove t/db_dependent/HoldsQueue.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:07:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:07:06 +0000 Subject: [Koha-bugs] [Bug 29750] New: Reserves.pm should check patron category hold policies when finding a reserve for an item Message-ID: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Bug ID: 29750 Summary: Reserves.pm should check patron category hold policies when finding a reserve for an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 23172 introduced a check for patron categories hold policies when the holds queue maps items to pending reserves. This patchset will introduce a check for patron categories hold policies when finding a reserve for an item. This is useful when the holds queue has not been generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:14:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:14:40 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-DXgsCVO9ZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issuingrules not checked |Holds queue should check |when returning item and |patron category hold |allocating to bib-level |policies when mapping items |holds |to pending reserves Status|ASSIGNED |Needs Signoff Text to go in the| |The hold queue should check release notes| |patron category hold | |policies when mapping items | |to pending title-level and | |item-level reserves. | |Previously the hold queue | |only checked the hold | |policies regardless of | |patron categories. --- Comment #27 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hi all, This is ready for testing, with unit tests attached. This patchset covers adding the check of patron category hold policies when the holds queue maps items to pending reserves. Meanwhile, I've split out to bug 29750 a check of patron category hold policies when an item is returned and Koha looks for reserves to allocate to it. bug 29750 is necessary for when an item is returned before the hold queue has been updated. Thanks! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:15:00 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-KaUJZZHerh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23172 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:15:00 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-Tu5N48WGYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29750 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:23:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:23:37 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-WimcgUsUTc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128858&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:25:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:25:51 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-pZqbXqINAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 128859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128859&action=edit Bug 29750: Unit test fixes for Reserves.pm Test plan: 1. sudo koha-shell <instance> 2. prove t/db_dependent/Holds.t prove t/db_dependent/Reserves.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 05:27:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 04:27:45 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-zxRVPhx4Te@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> --- I have attached the following fixed unit tests: - t/db_dependent/Holds.t - t/db_dependent/Reserves.t I still have to fix these failing unit test files: - t/db_dependent/Circulation.t - t/db_dependent/Holds/HoldItemtypeLimit.t - t/db_dependent/Holds/LocalHoldsPriority.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:15:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:15:09 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-FYRnpUQ54W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #29 from Fridolin Somers <fridolin.somers at biblibre.com> --- ((In reply to Hayley Pelham from comment #28) > Hello, > > What needs signing off here? Last patch : Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors() I bet one can not sign the Selenuim patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:45:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:45:36 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19482-70-xRaQAwMsSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:45:37 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-YuCEgNVAYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bug 20388 depends on bug 19482, which changed state. Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:45:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:45:38 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29436-70-R4TToGTW7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Bug 29436 depends on bug 19482, which changed state. Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:45:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:45:38 +0000 Subject: [Koha-bugs] [Bug 28279] mappings.yaml no longer in sync In-Reply-To: <bug-28279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28279-70-J1SeahBYJS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28279 Bug 28279 depends on bug 19482, which changed state. Bug 19482 Summary: Elasticsearch - prevent removal / editing of required indexes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:07 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-87ZMYIou0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:11 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26587-70-t1q5QEc1hb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #31 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:14 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29436-70-EugIUm3Uzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:16 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29436-70-uF8jDm0Pqo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:18 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-fn6IbUb8aK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:55:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:55:20 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29457-70-69rQk3n5pr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 --- Comment #44 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 07:59:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 06:59:58 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-gIWystHrTY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:02:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:02:32 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29670-70-sqwSicnB5N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers at biblibre.com> --- Ah QA tests fail for me : FAIL t/db_dependent/Koha/Edifact/Order.t FAIL spelling segement ==> segment segement ==> segment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:09:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:09:35 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-dtxZOk3iSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:27 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29289-70-JqEqWlWvKZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:29 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29289-70-MPnJg8bIof@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 --- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:32 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-X7uAN8BXhY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:34 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-8Th2zuBi6M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 --- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:36 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-3kpkqvcTTo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:11:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:11:39 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29696-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29696-70-Pb5y0EuaOJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 --- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:21:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:21:16 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-T4WO1dYW6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> --- Hi, Maybe a silly question : - return $now unless $issuing_rule; I don't understand why do we remove this ? issuing rule may be undef right ? In this case the calls $issuing_rule->{xxx} will fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:43:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:43:40 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28703-70-MlSzbhdgMD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> --- Duplicate of Bug 29604? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:43:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:43:55 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28703-70-NQMyVDV95w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29604 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 08:43:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 07:43:55 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29604-70-RgqHUrquo0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28703 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 09:02:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 08:02:45 +0000 Subject: [Koha-bugs] [Bug 12709] Send a custom email to some or all patrons In-Reply-To: <bug-12709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12709-70-BlQvyGepC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #5 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Isn't this a duplicate of Bug 16149 which added the ability to combine report results with a custom notice to generate emails? I've been testing out the new feature that came in 19.05 but as it doesn't support html in the message we probably wont be able to use it. (Enhancement request being worked on right now.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 09:07:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 08:07:11 +0000 Subject: [Koha-bugs] [Bug 29455] 505$t - change in line break/display In-Reply-To: <bug-29455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29455-70-kbnYbeqe9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29455 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28703 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 09:07:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 08:07:11 +0000 Subject: [Koha-bugs] [Bug 28703] Display problem in 505$a field In-Reply-To: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28703-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28703-70-be3SwBGmu1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28703 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29455 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 09:49:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 08:49:18 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29588-70-QNtOTRukKv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes "or", release notes| |"Yesterday", "Today" and | |"Tomorrow" in the flatpickr | |date selector so they can | |be translated. (This was | |because __ was used when _ | |should have been used (__ | |is for .js files only)). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 09:55:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 08:55:21 +0000 Subject: [Koha-bugs] [Bug 29748] Most Wanted/Lucky Day Items In-Reply-To: <bug-29748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29748-70-wXgtIvwi9H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29748 Anneli Österman <anneli.osterman at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #1 from Anneli Österman <anneli.osterman at koha-suomi.fi> --- In OUTI Libraries, Finland, we have something similar called "Short loans". They are not holdable or renewable. They have their own itemtype which we have set in smart rules as not holdable (holds allowed = 0) and not renewable (renewals allowed = 0). They also have their own collection code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:13:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:13:44 +0000 Subject: [Koha-bugs] [Bug 29751] New: [DOCS] Document how linking from Koha to the manual works Message-ID: <bug-29751-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 Bug ID: 29751 Summary: [DOCS] Document how linking from Koha to the manual works Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Documentation Assignee: david at davidnind.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org >From the 16 December 2021 documentation meeting: "document how the linking from Koha to the manual works". See: http://irc.koha-community.org/koha/2021-12-16#i_2394778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:16:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:16:29 +0000 Subject: [Koha-bugs] [Bug 29751] [DOCS] Document how linking from Koha to the manual works In-Reply-To: <bug-29751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29751-70-lOxUqaMsd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29712 Severity|enhancement |normal Priority|P5 - low |P3 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 [Bug 29712] [DOCS] [Omnibus] Content development guide -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:16:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:16:29 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29712-70-vRrMkuAUUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 [Bug 29751] [DOCS] Document how linking from Koha to the manual works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:35:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:35:41 +0000 Subject: [Koha-bugs] [Bug 29752] New: [DOCS] Look at adding documentation tasks to the dashboard Message-ID: <bug-29752-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29752 Bug ID: 29752 Summary: [DOCS] Look at adding documentation tasks to the dashboard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P3 Component: Documentation Assignee: martin.renvoize at ptfs-europe.com Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org >From the 16 December 2021 documentation meeting: "to look at adding docs tasks to the dashboard https://dashboard.koha-community.org/" See: http://irc.koha-community.org/koha/2021-12-16#i_2394908 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:35:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:35:55 +0000 Subject: [Koha-bugs] [Bug 29752] [DOCS] Look at adding documentation tasks to the dashboard In-Reply-To: <bug-29752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29752-70-ZR05p7LlDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29752 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:45:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:45:45 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29712-70-s71eKtVL7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29751 Blocks|29751 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 [Bug 29751] [DOCS] Document how linking from Koha to the manual works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 10:45:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 09:45:45 +0000 Subject: [Koha-bugs] [Bug 29751] [DOCS] Document how linking from Koha to the manual works In-Reply-To: <bug-29751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29751-70-rVBGpyjmEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29712 Depends on|29712 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 [Bug 29712] [DOCS] [Omnibus] Content development guide -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 12:04:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 11:04:01 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29476-70-SzpARUDsta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Fridolin Somers from comment #16) > Hi, > > Maybe a silly question : > > - return $now unless $issuing_rule; > I don't understand why do we remove this ? > issuing rule may be undef right ? > In this case the calls $issuing_rule->{xxx} will fail. The first check is 'defined' so it will be okay. We remove the return because there are two cases, see comment 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 12:08:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 11:08:42 +0000 Subject: [Koha-bugs] [Bug 28832] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28832-70-BjyS0QUkIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #15) > I am sorry, this no longer applies - can you please rebase? > Applies cleanly to 21.05.x for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 12:21:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 11:21:42 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-IqU4wLV8NN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 12:21:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 11:21:45 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option In-Reply-To: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29689-70-of7DRyjjW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128800|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128860&action=edit Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr The selector is not correct, we must to not rely on the number. This patch fixes a regression caused by bug 28445, but also a long-standing bug. * Regression: The barcode plugin is broken is autoBarcode=<branchcode>yymm0001 There is a JS error in the console: Uncaught TypeError: form.field_value is undefined Focustag_952_subfield_p_878344 Focustag_952_subfield_p_878344_handler jQuery 11 BindEventstag_952_subfield_p_878344 * Long standing bug: If there are several item forms on the same page, the branchcode is not correctly retrieved. For instance on the "Serial edition" page there are 2 item forms, the homebranch that is used by the barcode plugin will be the one from the last form. Test plan: * regression Set autoBarcode=<branchcode>yymm0001 Catalogue a new item, click into the barcode input Notice that without this patch you get a JS error in the console * long standing bug Create a new subscription, select "Create an item record when receiving this serial". Receive a serial Open the 2 item forms ("Click to add item") Select 2 different home library and click the barcode inputs. The prefix (branchcode) should be correct with this patch applied. QA Note: it would be way easier if all add item forms were using the new methods, it could be: let loc = document.getElementsByName('items.homebranch')[0].value; Yes, that's all! Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 13:18:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 12:18:56 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-pW81tzFyXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable Version(s)| |21.05.08 released in| | CC| |andrew at bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 13:35:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 12:35:30 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-oWpndG7rYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 14:15:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 13:15:30 +0000 Subject: [Koha-bugs] [Bug 29586] "Hold reminder" notice doesn't show in messaging preferences in new installation In-Reply-To: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29586-70-WfHKSUGecM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 14:35:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 13:35:24 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-QJp0iGHmwM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion Blocks| |29750 --- Comment #28 from Nick Clemens <nick at bywatersolutions.com> --- I have some concerns with the changes in this patchset, and its dependent bug 29750. While I agree that the current behavior does not match expectations, I think we are conflating two circ rules when we make this change. - reservesallowed defines how many holds a patron cna place on an item. - hold_allowed defines whether the patron is eligible to have a hold on an item. When libraries have AllowHoldPolicyOverride enabled, they will setup policies such that patrons cannot place holds, but staff can place these holds and they will be filled. After these patches, there will be new holds that can be placed by override but will not fill. I think the two questions: - Can a patron place a hold? - Can this item fill a hold for this patron? Are different. I think the real solution here would be to make 'hold_allowed' part of the circ rules matrix in a way that allows it to be set at a more granular level. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 14:35:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 13:35:24 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29750-70-1aN3F4AHGr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 14:51:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 13:51:22 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-wAFzWAG4Qb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 15:12:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 14:12:05 +0000 Subject: [Koha-bugs] [Bug 29753] New: Quickly Edit an Authority record Message-ID: <bug-29753-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29753 Bug ID: 29753 Summary: Quickly Edit an Authority record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When editing a bibliographic record, there are several steps you need to perform in the basic editor before editing an authority you may notice is incorrect. 1. perform a search 2. click edit record 3. click the 1 tab 4. click the tab editor for the 100a 5. click search 6. click edit authority It would be great to either have an edit authority option in the results or allow the authority to be edited while editing the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 15:49:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 14:49:48 +0000 Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings In-Reply-To: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29749-70-xDbBVhbpY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:17:00 +0000 Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18783-70-PYG0eexDm6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Jessie Zairo <jzairo at bywatersolutions.com> --- When testing we got an error of DBIx::Class::Row::store_column(): No such column 'auto_claim_enabled' on Koha::Schema::Result::Subscription at /kohadevbox/koha/Koha/Object.pm line 79 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:23:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:23:02 +0000 Subject: [Koha-bugs] [Bug 29754] New: Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled Message-ID: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Bug ID: 29754 Summary: Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The check for fines amount when using this pref fetches the patrons fines, then adds the total fines with guarantors, including this borrowers fines. This means the patrons own fines are doubled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:37:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:37:28 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-HY2TAPFlK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:37:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:37:31 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-v7nSMOVZSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128839|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 128862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128862&action=edit Bug 29747: Delete columns that don't exist from settings This patch simply checks if we are callinmg from the plugin, and removes two columns from the settings if so To test: 1 - In Admin->Marc bibliographic framework got to Marc Structure for default framework 2 - Search for 856$u 3 - Set Plugin to upload.pl 4 - Edit a record in the default framework 5 - Under 856u, click 'Upload' 6 - Uplaod a file and then click 'Choose' 7 - nothing happens 8 - View consiole (f12) and see error 9 - Apply patch 10 - Reload the page 11 - No more error 12 - Click choose 13 - Record link is populated Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:37:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:37:56 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29747-70-83g4NqvHYC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:51:39 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:51:39 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29230-70-b8MPiB6S9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl, | |tomascohen at gmail.com --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Although it looks good to me on itself, we have a clash with Koha::Object::messages. cc: Tomas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:51:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:51:48 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29230-70-QOTMzZWlNg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:53:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:53:29 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-mEoxlI2CGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:55:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:55:22 +0000 Subject: [Koha-bugs] [Bug 29755] New: SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees Message-ID: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Bug ID: 29755 Summary: SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The sip code always checks noissuescharge as the limit for fines, never the other possible limits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:56:21 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29754-70-GgGer2rHtL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:56:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:56:24 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29754-70-8ERoHP2TLX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128863&action=edit Bug 29754: Unit test This adds a unit test to the SIP code It also adds some spacing and dividers to make the tests for 'relationships_debt' easier to read To test: prove -v t/db_dependent/Koha/Patron.t - passes and is readable prove -v t/db_dependent/SIP/Patron.t - fails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:56:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:56:27 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29754-70-eWFCdXEUXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128864&action=edit Bug 29754: Don't include patron when fetching guarantees fines This patch removes the flag to fetch the patrons own debts as we have already calculated them This test plan highlights another issue - the value of NoIssuesChargeGuarantorsWithGuarantees is not checked in SIP code - we merely get the total owed including guarantees and compares to noissuescharge See bug 29755 To test: 1 - Apply first patch only 2 - prove t/db_dependent/SIP/Patron.t 3 - It fails 4 - Enable NoIssuesChargeGuarantorsWithGuarantees, you can set to 1 5 - Create/find a patron 6 - Add a $10 charge to parons account 7 - Add a guarantee to patron 8 - Add a $5 charge to guarantee 9 - Set noissuescharge to 15.01 10 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 11 - Note the 64 message starts with Y's that mean patron is blocked 12 - Patron shouldn't be blocked as under 15.01 13 - Apply patch 14 - Restart all 15 - repeat 10 16 - Patron is no longer blocked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 16:57:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 15:57:55 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29054-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29054-70-Y8DcEuH2fz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Hayley Pelham from comment #0) > When the advance_notices.pl cronjob is run and the > EnhancedMessagingPreferences syspref is set to don't allow, we get the > following warning: > > The "EnhancedMessagingPreferences" syspref is off. > Therefore, it is unlikely that this script will actually produce any > messages to be sent. > To change this, edit the "EnhancedMessagingPreferences" syspref. > > The advance_notices.pl script help says: > > -v Verbose. Without this flag set, only fatal errors are reported. Not sure if we should remove a warn here or edit the above description? Removing fatal or replacing it by a less severe term? Needs feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 17:00:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 16:00:21 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29754-70-MuF9CxaXT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Ah, simpler to check correct total, 'BV' field in SIP response will be 25 before patch, 15 after -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 17:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 16:05:07 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29754-70-Lh4AL9S1kc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29755 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 17:05:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 16:05:07 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29755-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29755-70-pD0HvmknPB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29754 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 17:36:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 16:36:37 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: <bug-14083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14083-70-tJEDZpCmMj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 18:33:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 17:33:24 +0000 Subject: [Koha-bugs] [Bug 29756] New: No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay Message-ID: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 Bug ID: 29756 Summary: No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Set OpacMaxItemsToDisplay to something low 2. Find a record from the OPAC that has more items then OpacMaxItemsToDisplay 3. Go to that record's detail page via the OPAC. 4. Look for a 'Place hold' button in action container on the right. You won't find one. 5. Click on "View all the physical items". ow you will see a Place hold button One should not have to click on "View all the physical items" in order to place a hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 18:34:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 17:34:34 +0000 Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay In-Reply-To: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29756-70-zxA2zcbfFI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 19:05:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 18:05:16 +0000 Subject: [Koha-bugs] [Bug 29757] New: Add filter_by_non_reversable/reversable methods for offsets Message-ID: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Bug ID: 29757 Summary: Add filter_by_non_reversable/reversable methods for offsets Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Taking this methods out of bug 28656 for reusing them, with Martin's approval. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 19:59:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 18:59:56 +0000 Subject: [Koha-bugs] [Bug 29758] New: CGI::param in list context in boraccount.pl warning Message-ID: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Bug ID: 29758 Summary: CGI::param in list context in boraccount.pl warning Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: tomascohen at gmail.com Reporter: evelyn at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Found the following warning in plack intranet error log: CGI::param called in list context from boraccount.pl line 58, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:09:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:09:30 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: <bug-24220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24220-70-SKXHoYXCyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:24:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:24:01 +0000 Subject: [Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table In-Reply-To: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29330-70-XeuQfQWSGU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.13 released in| | --- Comment #66 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Let's be optimistic. Backported: Pushed to 20.11.x branch for 20.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:28:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:28:23 +0000 Subject: [Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty In-Reply-To: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25946-70-y8EpNBeHeV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #23 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #22) > Doesn't apply cleanly to 20.05. Please rebase for backport. Is this going to be backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:37:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:37:05 +0000 Subject: [Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty In-Reply-To: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25946-70-BuMKQLrOU6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #24 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- (In reply to Christopher Brannon from comment #23) > (In reply to Andrew Fuerste-Henry from comment #22) > > Doesn't apply cleanly to 20.05. Please rebase for backport. > > Is this going to be backported? This isn't going to be backported any further, no. It's in what are now oldstable and oldoldstable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:55:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:55:51 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-lY3Xv2WxYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:55:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:55:55 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-ozzhgzPrsT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128865&action=edit Bug 29757: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:56:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:56:01 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-E2jtc3bEhE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128866&action=edit Bug 29757: Add filters for reversable offsets This patch adds filtering methods for (non)reversable offsets. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 20:56:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 19:56:05 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-EFuM240Izj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128867&action=edit Bug 29757: (QA follow-up) POD fixes This patch adds POD, fixes the existing one in the file, and also renames reversable => reversible as required by the QA scripts. If this name change is problematic, I can revert it and resubmit my follow-up. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:04:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:04:32 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-S13eA2xn5i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Just kinda feels like something we should fix, yknow? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:29:26 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-F4kDMJUd7R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28656 Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 [Bug 28656] Cancellations should be allowed on paid/partially paid debts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:29:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:29:26 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28656-70-AxYVHYNs3W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:29:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:29:40 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-WCQ2U9vIF6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:30:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:30:30 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-joEwm1GL8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:30:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:30:30 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-2XCGwtdYTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:31:08 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-RAqRQz2FvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on|29757 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:31:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:31:08 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-jGN8AoGWAv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27946 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:33:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:33:52 +0000 Subject: [Koha-bugs] [Bug 29759] New: Revert credit when cancelling an article request Message-ID: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug ID: 29759 Summary: Revert credit when cancelling an article request Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 27946 adds the ability to charge a fee when the patron makes an article request. This development will make the fee be reverted. Reversible credits will generate a refund. Methods introduced by bug 29757 will be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:34:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:34:07 +0000 Subject: [Koha-bugs] [Bug 29759] Revert credit when cancelling an article request In-Reply-To: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29759-70-4NVmFVxAzd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29757, 27946 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:34:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:34:07 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-wnCIPFlKXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 [Bug 29759] Revert credit when cancelling an article request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:34:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:34:07 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-uOKT0uHFQy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 [Bug 29759] Revert credit when cancelling an article request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:40:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:40:42 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-ibf0uG0RLi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128868&action=edit Bug 27946: Add article_requests.debit_id and ARTICLE_REQUEST account debit type Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:40:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:40:48 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-s9Lhh4nrqq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128869&action=edit Bug 27946: DBIC schema changes [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:40:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:40:53 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-MbZOkBYtBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128870&action=edit Bug 27946: Add article request fee to circulation rules This patch adds a new circulation rule: article requests fee. It can be set per library and category. To test: 1. Try setting sdifferent numeric values, change, and delete them => SUCCESS: Things work as expected 2. Make sure rules are loaded correctly when re-entering the circ rules page => SUCCESS: All good 3. Verify the data on the DB is stored as it should on each of your tests: $ koha-mysql kohadev > SELECT * FROM circulation_rules \ WHERE rule_name='article_request_fee'; => SUCCESS: All good (remember NULL => 'All' in the UI) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:40:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:40:59 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-3qQNK7f2xE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #65 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128871&action=edit Bug 27946: Article request fee methods in Koha::Patron This patch adds article_request_fee() and add_article_request_fee_if_needed() methods to Koha::Patron. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:41:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:41:04 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-QEAORknqeT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #66 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128872&action=edit Bug 27946: Make Koha::ArticleRequest->request add a fee if required This patch makes the ->request method add a fee for the patron if required. It relies on methods defined in Koha::Patron for the task. The debit line is linked to the AR if applies. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:41:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:41:10 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27946-70-tPrZ8lE8SB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #67 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128873&action=edit Bug 27946: Add UI handling of AR fees This patch: - Adds a notice about the fee to be charged to the patron (staff and OPAC) - Adds the right UI description for ARTICLE_REQUEST_FEE debit types in the UI. To test: 1. Have some article request fee rules 2. Play with placing an article request in OPAC and staff => SUCCESS: You see a message about the fee => SUCCESS: The fees are correctly applied to the patron 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:51:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:51:35 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29437-70-I51MB2BRtP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Hi, I'll try to backport this for 20.11. Thanks Marcel for digging into this, how should this change be used? How can I use it to solve the conflicts due to bug 29319 missing? Or maybe it's a whole alternative patch? Another way: does bug 29319 seems like a risky backport to you? The odd thing is that I can catalogue search stuff that begins with digits without getting errors. In other words, I don't reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 21:59:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 20:59:51 +0000 Subject: [Koha-bugs] [Bug 29514] ILL requests: Remove extraneous › HTML entity from breadcrumbs In-Reply-To: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29514-70-AsemCXGkLW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29514 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:00:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:00:58 +0000 Subject: [Koha-bugs] [Bug 29513] Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks In-Reply-To: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29513-70-WesVRd775g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29513 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:01:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:01:22 +0000 Subject: [Koha-bugs] [Bug 29521] Patron Club name hyperlinks not operational + weird CSS behavior In-Reply-To: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29521-70-Rid33VrF7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29521 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:02:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:02:03 +0000 Subject: [Koha-bugs] [Bug 29427] Debug mode not honoured in SMTP transport In-Reply-To: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29427-70-sd5smY7kUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29427 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:02:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:02:21 +0000 Subject: [Koha-bugs] [Bug 29488] NumSavedReports system preference doesn't work In-Reply-To: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29488-70-vwrCJCnSb5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:02:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:02:22 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29530-70-CqSqPg8Rk7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Bug 29530 depends on bug 29488, which changed state. Bug 29488 Summary: NumSavedReports system preference doesn't work https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29488 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:03:20 +0000 Subject: [Koha-bugs] [Bug 29036] Accessibility: OPAC buttons don't have sufficient contrast In-Reply-To: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29036-70-yWpo0C8bg8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #27 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:03:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:03:20 +0000 Subject: [Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] In-Reply-To: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28188-70-Pk8qEE9z9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Bug 28188 depends on bug 29036, which changed state. Bug 29036 Summary: Accessibility: OPAC buttons don't have sufficient contrast https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29036 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:03:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:03:36 +0000 Subject: [Koha-bugs] [Bug 29494] html-template-to-template-toolkit.pl no longer required In-Reply-To: <bug-29494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29494-70-g5EKOqf0wp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29494 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:21:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:21:04 +0000 Subject: [Koha-bugs] [Bug 29759] Revert credit when cancelling an article request In-Reply-To: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29759-70-2TmfioY2mA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128874&action=edit Bug 29759: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:21:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:21:08 +0000 Subject: [Koha-bugs] [Bug 29759] Revert credit when cancelling an article request In-Reply-To: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29759-70-vf6TOta1xj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128875&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:21:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:21:24 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29662-70-Of4RFY1W7x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z --- Comment #4 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- Hello, Can someone please give a test plan for this patch? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:22:52 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29759-70-mtinoFpUAx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Revert credit when |Refund credit when |cancelling an article |cancelling an article |request |request CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28656 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:22:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:22:52 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28656-70-LCM5Q0iOcx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29759 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:23:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:23:09 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29759-70-osmuXOjGC0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:36:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:36:09 +0000 Subject: [Koha-bugs] [Bug 29529] Fix \n in hint on Koha to MARC mappings In-Reply-To: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29529-70-lngRAlKVH0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29529 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:36:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:36:30 +0000 Subject: [Koha-bugs] [Bug 29487] Set autocomplete off for userid/password fields at login In-Reply-To: <bug-29487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29487-70-0qDm3PixBx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29487 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:36:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:36:46 +0000 Subject: [Koha-bugs] [Bug 29556] MARC21slim2MODS.xsl broken by duplicate template name "part" In-Reply-To: <bug-29556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29556-70-JvvDaQJt6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29556 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:37:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:37:05 +0000 Subject: [Koha-bugs] [Bug 29601] The list download option ISBD is useless when you cleared OPACISBD In-Reply-To: <bug-29601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29601-70-pwr1w4E2KT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:37:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:37:06 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29609-70-KSPRYpG8sa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Bug 29609 depends on bug 29601, which changed state. Bug 29601 Summary: The list download option ISBD is useless when you cleared OPACISBD https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29601 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:37:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:37:23 +0000 Subject: [Koha-bugs] [Bug 29580] Misplaced closing 'td' tag in overdue.tt In-Reply-To: <bug-29580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29580-70-gDhVRFNuMt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29580 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:37:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:37:45 +0000 Subject: [Koha-bugs] [Bug 28853] Textarea in biblio record editor breaks authority plugin In-Reply-To: <bug-28853-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28853-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28853-70-7PyL5BFlfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28853 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:38:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:38:07 +0000 Subject: [Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate In-Reply-To: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29484-70-6cPbtMq3JS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:38:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:38:07 +0000 Subject: [Koha-bugs] [Bug 21102] OAI-PMH specification conformance [UMBRELLA] In-Reply-To: <bug-21102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21102-70-3gQvXNfQFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 Bug 21102 depends on bug 29484, which changed state. Bug 29484 Summary: ListSets doesn't return noSetHierarchy when appropriate https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:38:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:38:30 +0000 Subject: [Koha-bugs] [Bug 29611] Clubs enrollment layout problem in the OPAC In-Reply-To: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29611-70-h48bQdezI9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29611 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:39:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:39:23 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29115-70-5id0qGv07X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:52:32 +0000 Subject: [Koha-bugs] [Bug 29760] New: Show patron category in Holds Queue Message-ID: <bug-29760-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Bug ID: 29760 Summary: Show patron category in Holds Queue Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nick at bywatersolutions.com It would be useful to be able to see a patron's category in the Holds Queue. This would help libraries avoid filling holds placed on bibs with a mix of item types when the patron has 0 allowed holds for that specific item's item type, as in bugs 11350 and 23172 (reservesallowed = 0, but the patron isn't ineligible per hold_allowed). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:52:32 +0000 Subject: [Koha-bugs] [Bug 11350] Holds offered to patrons who are not allowed to put the item on hold In-Reply-To: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11350-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11350-70-8Su55R5kat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11350 Sara Brown <sbrown at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29760 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:52:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:52:32 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-QklmB1aMex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Sara Brown <sbrown at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29760 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:57:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:57:26 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29690-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29690-70-fFyiZnvlMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Hayley Pelham <hayleypelham at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Hayley Pelham <hayleypelham at catalyst.net.nz> --- I gave testing the Selenium test regressions.t a go. It failed, here is the output: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/selenium/regressions.t t/db_dependent/selenium/regressions.t .. 1/7 Label not found for "last SKIP" at /usr/share/perl/5.28/Test/More.pm line 1370. Use of uninitialized value $value in string eq at /home/vagrant/kohaclone/C4/Context.pm line 423. # Looks like your test exited with 2 just after 7. t/db_dependent/selenium/regressions.t .. Dubious, test returned 2 (wstat 512, 0x200) All 7 subtests passed (less 7 skipped subtests: 0 okay) Test Summary Report ------------------- t/db_dependent/selenium/regressions.t (Wstat: 512 Tests: 7 Failed: 0) Non-zero exit status: 2 Files=1, Tests=7, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.28 cusr 0.17 csys = 1.47 CPU) Result: FAIL I think I set up the Selenium server correctly, here is the output from another Selenium test: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/selenium/basic_workflow.t t/db_dependent/selenium/basic_workflow.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.00 sys + 1.27 cusr 0.11 csys = 1.41 CPU) Please let me know if you think I have missed a step here Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 22:57:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 21:57:56 +0000 Subject: [Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty In-Reply-To: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25946-70-Vmuo1HT5xG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #25 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #24) > (In reply to Christopher Brannon from comment #23) > > (In reply to Andrew Fuerste-Henry from comment #22) > > > Doesn't apply cleanly to 20.05. Please rebase for backport. > > > > Is this going to be backported? > > This isn't going to be backported any further, no. It's in what are now > oldstable and oldoldstable Got it. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:03:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:03:34 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28216-70-isy0zerJVs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:03:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:03:58 +0000 Subject: [Koha-bugs] [Bug 29040] Uninitialized value warning in Languages.pm In-Reply-To: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29040-70-E9mkM4Z5Sm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:03:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:03:59 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-eByD4MkD5z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Bug 25790 depends on bug 29040, which changed state. Bug 29040 Summary: Uninitialized value warning in Languages.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:04:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:04:44 +0000 Subject: [Koha-bugs] [Bug 28855] Purging suggestions test should not be on timestamp In-Reply-To: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28855-70-G3H8nyJX8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:14:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:14:22 +0000 Subject: [Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds In-Reply-To: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29349-70-i0N8dRDHvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 22 23:56:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 22:56:37 +0000 Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23793-70-F6nWXSTrJp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 --- Comment #21 from David Cook <dcook at prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #20) > > opac/opac-ISBDdetail.pl Cool. I'm going to use it in some local code now. The sample code in the documentation doesn't work but working out the right way of doing it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 00:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 23:18:33 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23172-70-IGHSRQMV2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 --- Comment #29 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to Nick Clemens from comment #28) Hi Nick, Thanks for your reply. We'd like to think more about this and revisit it in the new year. Have a great Christmas holiday. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 00:32:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 23:32:58 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25439-70-OsynS4I7JJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > Actually https://www.elastic.co/fr/support/eol says : > 6.8.x EOL on 2022-02-08 great, they recently fixed the page :D Before it basically said that 6.8.x was EOL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 00:43:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Dec 2021 23:43:20 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29602-70-UIxGKzNRCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #41 from Victor Grousset/tuxayo <victor at tuxayo.net> --- (In reply to Jonathan Druart from comment #20) > Do we move forward with this patch or abandon it? It's now or never. > Or with bug 20988, maybe one day. +1 to move forward. Even without t() Thanks for fixes. Would the replacing of the <span> be easy latter? Or does that set them in stone because it would be too hard to tell the <span> that have a role in the layout or CSS vs these ones? (that influence our translation system to break down the strings) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 01:40:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 00:40:15 +0000 Subject: [Koha-bugs] [Bug 27801] Entering multiple lines of an item in Point of Sale can make the Collect Payment field off In-Reply-To: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27801-70-PWbd5YAs8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|22.05.00,21.11.01,21.05.08 |22.05.00,21.11.01,21.05.08, released in| |20.11.13 --- Comment #15 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Backported: Pushed to 20.11.x branch for 20.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 01:41:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 00:41:15 +0000 Subject: [Koha-bugs] [Bug 28481] Register details "Older transactions" search does not include the selected day in the "To" field in date range In-Reply-To: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28481-70-K1NtOoeE6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 01:41:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 00:41:16 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-AZbF61KVC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 28481, which changed state. Bug 28481 Summary: Register details "Older transactions" search does not include the selected day in the "To" field in date range https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 01:41:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 00:41:40 +0000 Subject: [Koha-bugs] [Bug 9565] Deleting a record should alert or fail if there are current subscriptions In-Reply-To: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9565-70-sBYJiJkRRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9565 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #33 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 01:47:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 00:47:27 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-jTWvXv0YYG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> --- This ticket depend on an enhancement from 21.11 But it was backported to 21.05 . Does that mean 20.11 should be affected as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:05:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:05:43 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29087-70-FZa3NCl3q5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Ashley Johnson <ajohnson at jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson at jcls.org --- Comment #4 from Ashley Johnson <ajohnson at jcls.org> --- Our library system is seeing this bug as well. Had a lot of staff reporting the error message to me today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:35:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:35:46 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-weXxetwWyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #25 from David Nind <david at davidnind.com> --- Created attachment 128876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128876&action=edit Bug 23291 - Duplicated patrons Testing notes (koha-testing-docker): 1. I created three text files that listed card numbers, borrow numbers, and SMS numbers for four patrons. One was duplicated (see the lists at the end). 2. Enabled adding and sending messages by SMS: . Set SMSSendDriver system preference to Email . Not sure whether this is necessary, but for SMS providers (Administration > Additional parameters > SMS cellular providers) I added: - Name: TEST - Domain: example.com 3. Added SMS numbers and SMS provider to patrons. 4. Went through the test plan. 5. When modifying data I just changed the ZIP/Postal code each time. Other notes/things I noted - this is existing behavour, so should be new bugs for fixing them if it is required or warranted: 1. Each batch patrons modification listing page has a 'Mobile' column - this matches to 'Other phone' in the contact information section when editing the patron. It is not the same as the SMS number. 2. If an SMS number applies to one or more patrons and it is included in the input twice or more (either in the file or the input form), then each patron with that number is shown twice on the batch patrons modification page - see the screenshot. This behaviour is exhibited for the by card number and by borrower number options, so is not something introduced by this bug. 3. Should 'By borrowernumber' be 'By borower number'? Realising that is the field name used in the query/URL, but is not "human friendly". Or perhaps 'System patron number' or just 'Patron number'? It is also shown on the patron details page in the summary box on the top left. Details for the three separate files (mentioned in item 1): Card numbers: 23529000035676 23529000651225 23529000080862 23529000695412 Borrower numbers: 19 49 7 38 SMS numbers: 2125551212 2125551212 2125551213 2125551214 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:36:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:36:33 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-fv9MmyvxcF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #26 from David Nind <david at davidnind.com> --- I will add my sign-off once I sort out an issue with my local git repository! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:46:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:46:42 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-XUI6sH1hSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #27 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to David Nind from comment #26) > I will add my sign-off once I sort out an issue with my local git repository! Hi David, Thank you very much for your testing! I believe it's not necessary to add SMS providers. Or at least my patchset does not check if those values are set, however, I don't think it hurts to do so. Good spotting regarding those 3 points, are you happy to create new bug reports for them? I can if you don't. Thanks again! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:53:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:53:20 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-jxFfhp2s1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual Text to go in the| |This enhancement adds release notes| |modifying patron | |information using SMS | |numbers to the patron batch | |modification tool (Tools > | |Patrons > Patron batch | |modification). It adds a | |new tab 'By SMS number', | |and can use a list of SMS | |numbers by either uploading | |a file or entering the | |numbers into the input form | |- the same as for modifying | |patron information using | |borrower numbers or card | |numbers. If an SMS number | |is shared by multiple | |patrons, all patrons with | |that SMS number are | |returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 02:57:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 01:57:21 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-w4MGsCUW1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #28 from David Nind <david at davidnind.com> --- (In reply to Alex Buckley from comment #27) > Good spotting regarding those 3 points, are you happy to create new bug > reports for them? I can if you don't. I'll add bugs for these shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 03:11:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 02:11:16 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-fMfAMDXLz6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #29 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to David Nind from comment #28) > (In reply to Alex Buckley from comment #27) > > > Good spotting regarding those 3 points, are you happy to create new bug > > reports for them? I can if you don't. > > I'll add bugs for these shortly. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 05:44:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 04:44:19 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-r6GYaTpDDt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 05:44:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 04:44:34 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-krarzICWKs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128641|0 |1 is obsolete| | --- Comment #30 from David Nind <david at davidnind.com> --- Created attachment 128877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128877&action=edit Bug 23291: Patron batch modification based on SMS number This patch is based on the patchset on bug 24019. It enabled librarians to list SMS numbers (one per line) or upload a file of SMS numbers, just like they can currently do with borrowernumbers or card numbers. Test plan: 1. Apply patch 2. Restart services 3. Create a patron list in: Tools > Patrons lists 4. Navigate to Tools > Batch patron modification 5. Observe there are 4 tabs: 'By card number', 'By SMS number', 'By borrowernumber', 'By patron list' 6. Test each option for batch patron modifications: - By cardnumber file - By cardnumber list - By SMS number file - By SMS number list - By borrowernumber file - By borrowernumber list - By patron list 7. In all of the above cases the correct patrons should be retrieved by Koha, and modified. 8. Test uploading a SMS number shared by multiple patrons and confirm all patrons with that SMS number are returned 9. Confirm the 'order of operations' for card numbers, SMS numbers and borrowernumbers is followed: - If a file is uploaded AND a list of number submitted then the list of numbers will be used 10. Confirm batches are only submitted from the active tab - If you upload a file OR input a list SMS numbers, and then switch to a different tab and input a list of borrowernumbers then the SMS numbers originally inputted should be ignored. Sponsored-By: Brimbank Library, Australia Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:22:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:22:05 +0000 Subject: [Koha-bugs] [Bug 29761] New: Patron batch modification tool - duplicated information on the listing page Message-ID: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Bug ID: 29761 Summary: Patron batch modification tool - duplicated information on the listing page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org Created attachment 128878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128878&action=edit Screenshot - duplicate rows if same number entered more than once If a card number or borrower number is entered twice or more (either in the input file or the input form), then each patron with that number is shown twice on the patron batch modification page - see the screenshot. This doesn't affect the end result - you can still successfully update the patron information. It may also not happen very frequently, as you would normally only enter the patron card number or borrower number once. This was identified when testing bug 23291, which adds the SMS number as an option for performing patron batch modifications. Multiple patrons may have the same SMS number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:36:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:36:01 +0000 Subject: [Koha-bugs] [Bug 29762] New: Patron batch modification tool - column Message-ID: <bug-29762-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29762 Bug ID: 29762 Summary: Patron batch modification tool - column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org When modifying patron information using the patron batch modification tool (Tools > Patrons > Patron batch modification), the listing pages after entering either card numbers or borrower numbers have a 'Mobile' column. This matches to 'Other phone' in the contact information section when editing patron information. This is not the same as the SMS number when SMS for messages is enabled. Should this remain as 'Mobile" or be changed to match the patron information field title? Or vice versa? This was identified when testing bug 23291 - Patron batch modification based on SMS number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:36:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:36:40 +0000 Subject: [Koha-bugs] [Bug 29762] Patron batch modification tool - mobile phone number column naming In-Reply-To: <bug-29762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29762-70-H1pmSv2JXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29762 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron batch modification |Patron batch modification |tool - column |tool - mobile phone number | |column naming -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:53:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:53:57 +0000 Subject: [Koha-bugs] [Bug 29763] New: Patron information - terminology; borrowernumber Message-ID: <bug-29763-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29763 Bug ID: 29763 Summary: Patron information - terminology; borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the patron details page the 'Borrowernumber' is shown on the top left patron information section. 'borrowernumber' is used as part of the query/URL and is the assigned number given to a patron in the database. It is also used in other areas of the staff interface, such as the patron batch modification tool (Tools > Patrons > Patron batch modification) - see the tab 'By borrowernumber', where you can enter a list of 'borrowernumbers' to modify. Should this be renamed to something more human friendly rather than what the system uses to identify this field? Such as 'Patron number'. Our terminology list says we should use patron, rather than member or borrower: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:54:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:54:22 +0000 Subject: [Koha-bugs] [Bug 29763] Patron information - terminology: borrowernumber In-Reply-To: <bug-29763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29763-70-g8e7yiX3nP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29763 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron information - |Patron information - |terminology; borrowernumber |terminology: borrowernumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:02 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-NqJ2XSiec8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29761 --- Comment #31 from David Nind <david at davidnind.com> --- (In reply to David Nind from comment #25) I have added bugs for the things I noted when testing: > 1. Each batch patrons modification listing page has a 'Mobile' column - this > matches to 'Other phone' in the contact information section when editing the > patron. It is not the same as the SMS number. See bug 29762 - Patron batch modification tool - mobile phone number column naming. > 2. If an SMS number applies to one or more patrons and it is included in the > input twice or more (either in the file or the input form), then each patron > with that number is shown twice on the batch patrons modification page - see > the screenshot. This behaviour is exhibited for the by card number and by > borrower number options, so is not something introduced by this bug. See bug 29761 - Patron batch modification tool - duplicated information on the listing page > 3. Should 'By borrowernumber' be 'By borower number'? Realising that is the > field name used in the query/URL, but is not "human friendly". Or perhaps > 'System patron number' or just 'Patron number'? It is also shown on the > patron details page in the summary box on the top left. See bug 29763 - Patron information - terminology: borrowernumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:02 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29761-70-7DLjLb5A6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:29 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-Uy0OJIXByZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29762 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:29 +0000 Subject: [Koha-bugs] [Bug 29762] Patron batch modification tool - mobile phone number column naming In-Reply-To: <bug-29762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29762-70-sYNoSmiL03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29762 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23291 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:59 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23291-70-zFAaZcpy5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29763 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 06:57:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 05:57:59 +0000 Subject: [Koha-bugs] [Bug 29763] Patron information - terminology: borrowernumber In-Reply-To: <bug-29763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29763-70-tP8AxsBANh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29763 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 07:33:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 06:33:47 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-eM9qe8sErR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> --- Yes, this is only for <= 21.05.x I removed dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 07:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 06:34:03 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-Xn5J1l5Nx3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22544 Depends on|22544 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 07:34:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 06:34:03 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-DfuR1eSg1C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28698 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 [Bug 28698] News for all displays in all locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 08:15:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 07:15:24 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-avPxos0Rhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #4 from AspenCat Team <aspencatteam at clicweb.org> --- Created attachment 128879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128879&action=edit match rule This is the match rule I used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 10:57:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 09:57:10 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-kAeX5B18aO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thank you, that makes sense! *files for later use* -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 10:57:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 09:57:34 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-9TI1TJTZFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Does this work well enough, so this bug could be closed as "WORKSFORME"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 11:34:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 10:34:47 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29325-70-h9fCI0KK7y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tomas or Marcel, any chance for a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:08:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:08:26 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29325-70-XQYsvuR94m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #22 from Ulrich Kleiber <ulrich.kleiber at bsz-bw.de> --- Without this patch the error message appears again, but all bibliographic records are imported. (In reply to Ulrich Kleiber from comment #20) > Under Koha version 20.11 we have the following problem with this patch. > > The commit_file.pl script (CLI) runs through without error message. > > Example: > > MARC record import report > ---------------------------------------- > Batch number: 1 > Number of new records added: 25315 > Number of records replaced: 0 > Number of records ignored: 0 > Number of items added: 26973 > Number of items replaced: 0 > Number of items ignored: 0 > > In reality, however, not all bibliographic records are imported. In this > example the last 14 records are missing. > On the Staff page "Manage staged MARC records" the job status is displayed > as "Importing" and the last 14 titles have the status "Staged". > > After a reset, another attempt with the same data resulted in the same > problem, except that this time 16 records remained with the status "Staged". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:21:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:21:02 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversable/reversable methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-2LdYPwaGtQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:21:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:21:26 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29757-70-oSOVLZsy1I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add |filter_by_non_reversable/re |filter_by_non_reversible/re |versable methods for |versible methods for |offsets |offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:40:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:40:09 +0000 Subject: [Koha-bugs] [Bug 29764] New: EmbedItems RecordProcessor filter POD incorrect Message-ID: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Bug ID: 29764 Summary: EmbedItems RecordProcessor filter POD incorrect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:40:22 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29764-70-D62ShRXCRJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |23793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:40:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:40:22 +0000 Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23793-70-myBLHC0b0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29764 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 [Bug 29764] EmbedItems RecordProcessor filter POD incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:46:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:46:02 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29764-70-XpHSb6nz7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:46:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:46:32 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29764-70-mhmgzWpgkq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:46:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:46:35 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29764-70-pbyDrFNqVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128880&action=edit Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD This patch makes the usage POD for the EmbedItems filter actually be usable. The filter is used in opac-ISBDdetail.pl and the POD is updated to how it is used there. Not much to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 12:48:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 11:48:07 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29764-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29764-70-OhdSmBJKrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128880|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128881&action=edit Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD This patch makes the usage POD for the EmbedItems filter actually be usable. The filter is used in opac-ISBDdetail.pl and the POD is updated to how it is used there. Not much to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:03:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:03:56 +0000 Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter for MARC::Record objects In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23793-70-U05PYfkAeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793 --- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #21) > (In reply to Tomás Cohen Arazi from comment #20) > > > > opac/opac-ISBDdetail.pl > > Cool. I'm going to use it in some local code now. The sample code in the > documentation doesn't work but working out the right way of doing it... I fixed the POD on bug 29764. Please test. The only change is parenthesis for square brackets in the filters list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:19:42 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:19:42 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-wLhE0GfztK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:19:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:19:45 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-9upUH2EZ7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:19:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:19:48 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-gTHe1S05Pd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:21:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:21:23 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-REmeKOyaaT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128882&action=edit Bug 29746: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:21:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:21:30 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-sA24MztFoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128883&action=edit Bug 29746: Add Koha::Result::Boolean This patch introduces a new OO class that can be used as return value from methods that need to return boolean values, but also provide some feedback. This last bit is implemented using Koha::Object::Message objects that can carry valuable information. This class can also implement a `to_api()` method so it is suitable for API usage. And so the Koha::Object::Message class. Will be done as needed. If some other result types are required, then we can move some of the messaging logic to a top-level Koha::Result class this one inherits from (and the new one as well, say, Integer?). To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/Koha/Result/Boolean.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:22:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:22:49 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-jjFutWyowR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a handy Koha::Boolean |Add a handy |class |Koha::Result::Boolean class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 13:45:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 12:45:35 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-KLVC6H8IG6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I've just renamed the class because this is not an attempt to introduce booleans in Perl :-D but a way to have a consistent way to return values and have them evaluated in the core codebase. I will pick a real-life example to highlight how it can be useful: CanItemBeReserved. This method is called like this: C4/Circulation.pm: @items = grep { CanItemBeReserved( ... )->{status} eq 'OK' } @items; In this case, the reason why it is not holdable doesn't really care. We are comparing to an arbitrary string that represents a boolean value (to be fair, OK is the obvious pick :-D, but the ->{status} bit could vary from one implementation to another). If it used this library as a return value, we would only evaluate the result in a boolean context: @items = grep { CanItemBeReserved( ... ) } @items; And if we wanted to know 'why', we could do: my $result_object = CanItemBeReserved( ... ); and then have a consistent way for this method and all other methods that need to return extra info: if ( !$result_object ) { foreach my $message ( @{$result_object->messages} ) { $template->param( do_your_thingy ); } } Please feel free to comment about this and add your thoughts. As this return value has its own class instead of what we did before, we could do things like: - implement a to_api() method that makes it render in a suitable way, have it embed the messages, etc. I can see how it can be useful. - some other caller contexts could be considered. for instance, some methods we have return, in list context, a boolean (the result) and a payload with extra info. We could make this class do the same, for an easy transition of legacy code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:07:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:07:02 +0000 Subject: [Koha-bugs] [Bug 29765] New: Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object Message-ID: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Bug ID: 29765 Summary: Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org With the purpose of highlighting the value of the Koha::Result::Boolean class, this bug will migrate the current implementation with string return values to one using Koha::Result::Boolean instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:07:22 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-BdOKWfgDuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29741, 29746 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 [Bug 29741] Add Koha::Patron->safe_to_delete https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 [Bug 29746] Add a handy Koha::Result::Boolean class -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:07:22 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29741-70-QVgyYnVWpc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:07:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:07:22 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-wIE8fG1Q2N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:20:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:20:05 +0000 Subject: [Koha-bugs] [Bug 29766] New: Add options to runtime parameter Message-ID: <bug-29766-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29766 Bug ID: 29766 Summary: Add options to runtime parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.breuillard at biblibre.com QA Contact: testopia at bugs.koha-community.org To make some SQL cash reports about it could be good to have more options in the dropdown menu "Insert runtime parameter" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:22:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:22:45 +0000 Subject: [Koha-bugs] [Bug 29767] New: Add options to runtime parameter Message-ID: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Bug ID: 29767 Summary: Add options to runtime parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.breuillard at biblibre.com QA Contact: testopia at bugs.koha-community.org To make some SQL cash reports it could be good to have more options in the dropdown menu "Insert runtime parameter" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:24:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:24:50 +0000 Subject: [Koha-bugs] [Bug 25971] Allow arbitrary database field as runtime parameter In-Reply-To: <bug-25971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25971-70-DhnRLPSK34@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25971 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29767 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:24:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:24:50 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-3Gx35dPzbs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25971 CC| |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:33:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:33:51 +0000 Subject: [Koha-bugs] [Bug 29766] Add options to runtime parameter In-Reply-To: <bug-29766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29766-70-VMkzRh5iAX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29766 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jeremy.breuillard at biblibre. | |com --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- *** This bug has been marked as a duplicate of bug 29767 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:33:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:33:51 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-PYS2GYzEos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- *** Bug 29766 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:35:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:35:49 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-vsNVKfCr5s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128884&action=edit MT 28590: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:36:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:36:57 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-zPufIKH6Ka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:41:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:41:34 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-rWg0JjzY5o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 --- Comment #3 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128885&action=edit Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:42:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:42:11 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-SOdzvBjpnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:46:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:46:37 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-g9wZZ4ZktY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Needs Signoff |Failed QA --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- QA script reports the following errors: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 1651) FAIL reports/guided_reports.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 903) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 14:56:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 13:56:32 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-BGXYncW3zh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128885|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128886&action=edit Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:28:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:28:28 +0000 Subject: [Koha-bugs] [Bug 29768] New: hidepatronname hides guarantor name on borrower edit screen Message-ID: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Bug ID: 29768 Summary: hidepatronname hides guarantor name on borrower edit screen Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bdaeuber at cityoffargo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The syspref hidepatronname is now hiding the guarantor name on memberentry.pl. This seems like a strange place to enforce that system preference since it's convenient for staff to be able to double check that info when editing patron information and personal information is already showing on that screen. It's not enforced on other patron details screens (such as moremember.pl) and I don't think it should impact patron edit screen either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:42:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:42:29 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29768-70-x1YtRPEYCK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Benjamin Daeuber <bdaeuber at cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:54:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:54:27 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-Opv1BKXnov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128887&action=edit Bug 29765: Make Koha::Patron->safe_to_delete use Koha::Result::Boolean This patch makes the safe_to_delete method in Koha::Patron return this new object type instead of a plain string. This way we have a consistent way to deal with 'can_*'-like methods return values when feedback is needed. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: The adjusted tests pass. Tests cover the boolean context eval and also the carried messages, that include the same string code that was returned originally. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:54:31 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-UsZiJruGYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128888&action=edit Bug 29765: Adjust DELETE /patrons/:patron_id controller This patch adjusts the only current place using the Koha::Patron->safe_to_delete method to the new return value. There should be no behavior change To test: 1. Apply the previous patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, because of the change, the controller is broken 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No test tweak required, no behavior change 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:54:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:54:54 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-Hv05rxZ0fx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 15:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 14:56:16 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29746-70-r26mr2Bc5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I went ahead and used this in bug 29765. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:33:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:33:17 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-VUV5Rn7iZJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128886|0 |1 is obsolete| | --- Comment #6 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128889&action=edit Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:45:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:45:34 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-lDhpeeaxoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:45:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:45:37 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-dBIciDVvuh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128086|0 |1 is obsolete| | --- Comment #29 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128890&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:45:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:45:41 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-SSfKKwRxRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128087|0 |1 is obsolete| | --- Comment #30 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128891&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> The patch works fine for me. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:48:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:48:47 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-MlZllqhbZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:48:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:48:51 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-Vn3hK6WqSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:48:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:48:54 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-ILWQPNaqnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:48:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:48:57 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-mZt5kpWq3I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:49:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:49:58 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-XjuUu6O2ef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128892&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:50:03 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29440-70-RnU7gcCX98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:50:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:50:03 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-ihL1a5bZN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128893&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:50:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:50:09 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-w7B2eQz3BS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128894&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:51:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:51:41 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-4vbizdHDW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Rebased. (In reply to Nick Clemens from comment #21) > Small QA failures: > OK Koha/Schema/Result/Itemtype.pm > FAIL installer/data/mysql/kohastructure.sql > FAIL boolean_vs_tinyint > The new column (type) for table configurations is using BOOLEAN as type, > must be TINYINT(1) instead, see the SQL12 coding guideline This is a false positive. The DB structure defines an ENUM, that can take the string 'boolean' as a possible value, and the QA checks don't notice it is an ENUM type. > FAIL t/db_dependent/Koha/Configurations.t > FAIL file permissions > File must have the exec flag Fixed, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 16:54:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 15:54:50 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-JfVuYu4buC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Martin Renvoize from comment #20) > Is there a new example bug where this is getting used? My plan was to do it for bug 22457. Because it felt like changing the model for each single configuration specific to a category sounds like bad design. And 'circulation_rules' doesn't sound like the use case. (In reply to Marcel de Rooy from comment #6) > Just reading diagonally, sounds like yet another configuration to manage? > Moving all preferences into it would be a dramatic refactoring that we > probably do not finish? I agree. I will probably abandon this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 17:18:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 16:18:32 +0000 Subject: [Koha-bugs] [Bug 29769] New: Claim return status cannot be changed without checking item in Message-ID: <bug-29769-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 Bug ID: 29769 Summary: Claim return status cannot be changed without checking item in Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With the addition of bug 24279, libraries can no longer change the status of a claim return without checking the item in, which is not a desired behavior. Example: a library sets an item to claims return, looks for the item for three months per policy, item is not found, status needs to be changed from Claim to Lost so the patron is billed for the item. In this scenario, the item should not be checked in to clear the claim status. Marking the claim as resolved does not allow the status to be changed either. Perhaps this could be a setting with Claims Return system preferences as to whether staff are permitted to change the claim/lost status of an item from moredetail.pl? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 17:22:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 16:22:26 +0000 Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed without checking item in In-Reply-To: <bug-29769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29769-70-S8N1Z4UNr4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 Donna <bwsdonna at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 17:28:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 16:28:29 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14367-70-7pVlNghq0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 17:39:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 16:39:50 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14367-70-HqMuJVXu4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #65 from Frank Hansen <frank.hansen at ub.lu.se> --- Applying: Bug 14367: Add MARC record history Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/addbiblio.pl M koha-tmpl/intranet-tmpl/prog/css/addbiblio.css M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt M koha-tmpl/intranet-tmpl/prog/js/cataloging.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/cataloging.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/addbiblio.css Auto-merging cataloguing/addbiblio.pl CONFLICT (content): Merge conflict in cataloguing/addbiblio.pl Auto-merging C4/Biblio.pm CONFLICT (content): Merge conflict in C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14367: Add MARC record history Patch doesn't apply. Rebase please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:14:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:14:38 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-6yqQRxsfEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:14:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:14:44 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-H9OnRUp4qZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125211|0 |1 is obsolete| | --- Comment #49 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128895&action=edit Bug 20551: Add option for including deleted records in export_records.pl Add option "--include_deleted" to include deleted biblios in export_records.pl as marc records with record status (in leader) set to "d" and "--deleted_only" to export only deleted biblios. How to test: 1) Run tests in t/db_dependent/Exporter/Record.t 2) All tests should pass 3) Delete a biblio record in Koha 4) Run the export script as: `export_records.pl --date=<date-just-before-deletion> --include_deleted` 5) Open the generated koha.mrc, and verify that contains the recently deleted record, and that the record header has record status "d". 6) Perform the same check with: `export_records.pl --date=<date-just-before-deletion> --include_deleted --format=xml` 7) Run: `export_records.pl --date=<date-just-before-deletion> --deleted_only --format=xml` and verify that only the deleted biblio was included in the export. Sponsored-by: Gothenburg University Library Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:14:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:14:49 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-DANhbP7r7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125212|0 |1 is obsolete| | --- Comment #50 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128896&action=edit Bug 20551: Fix option name in pod Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:14:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:14:54 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-BEarFxzPnT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125213|0 |1 is obsolete| | --- Comment #51 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128897&action=edit Bug 20551: Rename "marcflavour" field to "schema" Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:15:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:15:00 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-rNAhSHsRu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125214|0 |1 is obsolete| | --- Comment #52 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128898&action=edit Bug 20551: Improve documentation and make compatible with more options Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:15:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:15:06 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-5akzjS5YW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125215|0 |1 is obsolete| | --- Comment #53 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128899&action=edit Bug 20551: Add missing subroutine import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:15:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:15:11 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-7XaRMalgq8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125216|0 |1 is obsolete| | --- Comment #54 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 128900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128900&action=edit Bug 20551: Fix tests Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Works fine for me. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:16:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:16:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-HKmFkGX3Zq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:16:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:16:43 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29767-70-V8sqe6bSeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:18:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:18:30 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease lona period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-u8m2IU3pyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:18:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:18:33 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease lona period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-Zs4thZ5kIo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128901&action=edit Bug 29102: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:18:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:18:36 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease lona period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-ey4ro2hJsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128902&action=edit Bug 29102: Do not count patron's own hold against limits This patch makes two changes: 1 - The borrower's own holds are not counted towards HighHolds limit 2 - We exclude all hold counts from CanItemBeReserved Previously a patron's hold could put the count over the threshhold, and if the patron is only allowed 1 hold per record, and the hold wasn't found before the checkout, it would make all items unholdable, thus lowering the theshhold for dynamic HighHolds To test: 1 - Set sysaprefs: decreaseLoanHighHolds - enable decreaseLoanHighHoldsDuration - 1 decreaseLoanHighHoldsValue - 1 decreaseLoanHighHoldsControl - dynamic decreaseLoanHighHoldsIgnoreStatuses - blank 2 - Set circ rules to allow 1 hold per record and loan period of 5 3 - Find/create a record with 3 items 4 - Place a title level hold for a patron 5 - Attempt to checkout item - note warning about high holds 6 - Cancel checkout 7 - Set decreaseLoanHighHoldsControl - static 8 - Attempt checkout - note warning about high holds 9 - Apply patrch 10 - Checkout item - no warning 11 - checkin item, replace hold 12 - Set decreaseLoanHighHoldsControl - dynamic 13 - Checkout item - no warning -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:18:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:18:40 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease lona period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-mXfVTWMcf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 128903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128903&action=edit Bug 29102: Remove ignore_found_holds If not counting patrons holds, found or unfound, we no longer need this option introduced by bug 28078 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:19:15 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:19:15 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-VS1vAYvEUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DecreaseLoanHighHolds will |DecreaseLoanHighHolds will |decrease lona period if |decrease loan period if |borrower has an 'unfound' |borrower has an 'unfound' |hold |hold CC| |cbrannon at cdalibrary.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:20:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:20:28 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-3Pja1DmnCI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 Donna <bwsdonna at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 18:27:37 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 17:27:37 +0000 Subject: [Koha-bugs] [Bug 6659] Show OpacNav and OpacNavBottom on the login page In-Reply-To: <bug-6659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6659-70-YTCkb9rPLP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6659 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:12:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:12:29 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-DyYIo0u2Fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Nick Clemens from comment #21) > Small QA failures: > OK Koha/Schema/Result/Itemtype.pm > FAIL installer/data/mysql/kohastructure.sql > FAIL boolean_vs_tinyint > The new column (type) for table configurations is using BOOLEAN as type, > must be TINYINT(1) instead, see the SQL12 coding guideline https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:12:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:12:54 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-KXolpYNyYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:12:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:12:57 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-hIXy7vbKE0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:13:01 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:13:01 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-EKO72zPVYL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:13:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:13:29 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-V11M9Mr3UP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128904&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:13:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:13:38 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-sD3OeZ80Do@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128905&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:13:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:13:48 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26129-70-oEwCl13B77@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128906&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:39:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:39:04 +0000 Subject: [Koha-bugs] [Bug 29770] New: Refining acq add to basket workflow Message-ID: <bug-29770-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29770 Bug ID: 29770 Summary: Refining acq add to basket workflow Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org With bug 27900, while users now can get back to the basket which is helpful, libraries are requesting a few less clicks. When you do a search with no results, you can select View Basket, but then have to select Add to basket and submit the info for the search again. Libraries have requested the following workflow: -In acq, add to basket, choosing from existing record -enter search term -if no results, present the options from "add to basket", and retain entered search term, such as populating ISBN when choosing "from an external source" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:54:31 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:54:31 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-VOAhmM9Pie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:54:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:54:47 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-HgTFQ1Ryh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128907&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 19:55:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 18:55:12 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-ctzpHZHzwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:07:54 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:07:54 +0000 Subject: [Koha-bugs] [Bug 29771] New: Get rid of CGI::param in list context warnings Message-ID: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Bug ID: 29771 Summary: Get rid of CGI::param in list context warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:08:29 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-o12cpsOBZ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of CGI::param in |Get rid of CGI::param in |list context warnings |list context warnings | |[UMBRELLA] Depends on| |29758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 [Bug 29758] CGI::param in list context in boraccount.pl warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:08:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:08:29 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-P6IyWCGbmT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:10:21 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-9yC3CyrHfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21051, 18320, 17239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17239 [Bug 17239] Vulnerabilitiy warning for package C4::Biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 [Bug 18320] patroncards/edit-layout.pl raises warnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 [Bug 21051] CGI::param called in list context when editing a patron card layout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:10:21 +0000 Subject: [Koha-bugs] [Bug 17239] Vulnerabilitiy warning for package C4::Biblio In-Reply-To: <bug-17239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17239-70-YwxHghmV9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17239 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:10:21 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-IO1rNrQTct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:10:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:10:21 +0000 Subject: [Koha-bugs] [Bug 21051] CGI::param called in list context when editing a patron card layout In-Reply-To: <bug-21051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21051-70-Psb5YerKtx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:12:28 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:12:28 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-xXuRb8D26P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- $ git grep '\->param' | grep -v -e 'template' -e 'multi_param' | grep '@' | wc -l 54 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:19:25 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:19:25 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-2XUa3Gpoby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128908&action=edit Bug 29771: Remove warning from acqui/finishreceive.pl This patch removes a warning that shows when receiving. To test: 1. Do the acq workflow up to the receive step. 2. Once you choose the items and click on Finish => FAIL: There's a warning in the logs 3. Revert receipt 4. Apply this patch 5. Receive => SUCCESS: No more warnings 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 20:24:03 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 19:24:03 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-bnyFTi66QN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #55 from Cab Vinton <bibliwho at gmail.com> --- Will this enhancement be available from the staff interface? i.e., Tools > Export data (.../cgi-bin/koha/tools/export.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:09:23 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:09:23 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-nmx3eMkXoM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 --- Comment #7 from AspenCat Team <aspencatteam at clicweb.org> --- Yes, I think it can be closed - do I do that? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:25:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:25:33 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-mFJJZYH2d2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:25:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:25:36 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-GDxFQiKmrp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128908|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:26:20 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:26:20 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-KuQ7cYL5VY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evelyn at bywatersolutions.com | |, liz at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:26:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:26:44 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-6NJJSsY7wR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128909&action=edit Bug 29771: Remove trivial cases I squashed the patches because they are too trivial to have a test plan. Or it is too much work to write the test plan for such trivial cases. I leave the original commit messages just in case. Generally, this are all cases in which CGI::param is being called in a trivially identifiable _list context_. i.e. they are assigned to a @variable. I left one case out on purpose: admin/auth_subfields_structure.pl Paul introduced this: my @kohafield = ''.$input->param('kohafield'); and then: my $kohafield = $kohafield[$i]; My intuition says it is forcing scalar context on the first assignment so the list contains a single element and then inside the loop some $kohafield assignments should lead to undef, and even warnings. I leave it for a separate patch because it is not that easy testable and is a sensible area. Bug 29771: Remove warning from acqui/finishreceive.pl This patch removes a warning that shows when receiving. To test: 1. Do the acq workflow up to the receive step. 2. Once you choose the items and click on Finish => FAIL: There's a warning in the logs 3. Revert receipt 4. Apply this patch 5. Receive => SUCCESS: No more warnings 6. Sign off :-D Bug 29771: Remove warning from svc/members/add_to_list To test: 1. Run: $ tail -f /var/log/koha/kohadev/*-error.log 2. Generate a patron list 3. Perform a patron search that gives you a few 4. Select some, and choose to add them to the list => FAIL: The logs show the infamous warn: CGI::param called in list context from /kohadevbox/koha/svc/members/add_to_list 5. Apply this patch 6. Restart plack and repeat 4 => SUCCESS: No warn! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:26:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:26:48 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings [UMBRELLA] In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-EcKbyU4ORK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128910&action=edit Bug 29771: Scalar context for split This patch tackles a very specific scenario. Calling split(..., CGI::param) makes it be called in list context. The split docs say: split /PATTERN/,EXPR,LIMIT this means the first CGI param will be used as EXPR and the second one as LIMIT, which is wrong anyway. So the fix is to just force scalar context. To test: 1. Not sure, just make sure nothing breaks when using the scripts in the browser. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:29:27 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29771-70-hGEzqI3ww0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of CGI::param in |Get rid of CGI::param in |list context warnings |list context warnings |[UMBRELLA] | Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:29:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:29:27 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-h051XiyxYF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:30:21 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-aZ5udETS0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:30:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:30:21 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25790-70-YEcBkXsoQ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18320 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 [Bug 18320] patroncards/edit-layout.pl raises warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:55:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:55:27 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-J1zpQsuvgw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:55:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:55:29 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-1Z7HDf7kV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:56:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:56:09 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-thr7TwUgWs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #6) > I still see one: > > > 1) Add a new patron layout, just entering the layout name > 2) Change the Units > CGI::param called in list context from > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards- > errors.inc line 57, this can lead to vulnerabilities. See the warning in > "Fetching the value or values of a single named parameter" at > /usr/share/perl5/CGI.pm line 412. > 3) Delete layout > CGI::param called in list context from > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards- > errors.inc line 57, this can lead to vulnerabilities. See the warning in > "Fetching the value or values of a single named parameter" at > /usr/share/perl5/CGI.pm line 412. > > I don't seem to be able to make them appear consistently. Can you take a > look? > > (Marking failed QA, to get your attention ;) ) Sorry for the delay. Will need your help testing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:56:16 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:56:16 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-NXE3V8cJ3L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128911&action=edit Bug 18320: Remove patroncards/edit-layout.pl warnings This patch removes warnings generated by the script itself. To test: - Go to Tools › Patron card creator › Manage layouts and Tools › Patron card creator › New layout - Add a new layout, adit existing. => FAIL: Warnings logged by edit-layout.pl - Apply this patch - Go to Tools › Patron card creator › Manage layouts and Tools › Patron card creator › New layout - Add a new layout, adit existing. => SUCCESS: No warnings generated by edit-layout.pl - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 23 21:56:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 20:56:21 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18320-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18320-70-yPTsaU5hCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128912&action=edit Bug 18320: Remove calls to CGI->param from the templates in patron cards This patch removes calls to CGI->param from within the templates (patroncards-errors.inc) and passes error_* variables with the same codes from the controllers to the template instead. This way we can be sure CGI->param is not called in list context. To test, try those pages and see they don't show warnings anymore. Verify that error situations still show the error messages. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 00:00:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 23:00:05 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: <bug-19501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19501-70-c5CNWnqzbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Hi there, In bug 26346 I've added the ability to create public lists that are only editable by staff, but viewable by all. Question: Rather than add a 'Share' button in the staff client would it be the cleaner solution to revert bug 28959 , and add a third category of 'Restricted' which is viewable by all in the staff client, and by staff users in the OPAC? I'm not sure what the best practice is for reverting patches that have been upstreamed? Thanks! Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 00:50:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Dec 2021 23:50:48 +0000 Subject: [Koha-bugs] [Bug 28840] Better texts in batch record modification/deletion In-Reply-To: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28840-70-DwPVW1qGgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samu.heiskanen at hypernova.fi --- Comment #4 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Applying: Bug 28840: Better texts in batch record modification/deletion Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28840: Better texts in batch record modification/deletion hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28840-Better-texts-in-batch-record-modificatio-wjnSzH.patch Patch doesn't apply. But very easy to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 01:02:27 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Dec 2021 00:02:27 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29761-70-y2IRQYlhjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Working on this. Will attach the finished patch when I'm back from leave on the 5th of January -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 02:33:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Dec 2021 01:33:02 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29761-70-F4GY7Ls32w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 --- Comment #2 from David Nind <david at davidnind.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 09:39:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Dec 2021 08:39:46 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11083-70-uTEVTIIxCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 128913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128913&action=edit Bug 11083: Add sample XSLT for UNIMARC authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 24 09:41:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Dec 2021 08:41:14 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11083-70-poHZdqq9ga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Katrin Fischer from comment #5) > Julian - will you provide a sample file for UNIMARC? It took 6 months, but here it is ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 11:25:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 10:25:46 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-H46npQ4vUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128888|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128914&action=edit Bug 29765: Adjust DELETE /patrons/:patron_id controller This patch adjusts the only current place using the Koha::Patron->safe_to_delete method to the new return value. There should be no behavior change To test: 1. Apply the previous patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, because of the change, the controller is broken 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No test tweak required, no behavior change 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 12:32:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 11:32:56 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-JVwoVbZvE3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 12:33:48 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 11:33:48 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-zfKDlqhrma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 12:33:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 11:33:51 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-SCVlsh0ECA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128915&action=edit Bug 28020: Unit tests The unhandled_exception() Mojo helper didn't have proper tests. As this bug is adding a slight behavior change, I tried to add some. As it relies on the OpenAPI plugin, it cannot be done the usual way using Mojo::Lite. So I picked a route and forced an exception through mocking to be able to write tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 12:33:55 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 11:33:55 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-F3sk7LK0lX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128916&action=edit Bug 28020: Add error_code to error responses This patch adds the *error_code* attribute to the error response definition. This way it can be added when returning an error. I also made a sample usage of it on the generic unhandled_exception helper, which the unit tests on this patchset expect. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:12:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:12:26 +0000 Subject: [Koha-bugs] [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke In-Reply-To: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29087-70-QDNBx1Fgqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:36:36 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-I7sw8ixYsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128917&action=edit Bug 28020: (follow-up) Add docs about error_code on the API This patch intends to be a guide for inserting Markdown documentation for error codes. The idea is that it can be copied and pasted as-is in new routes. And adapted to new error codes. To test: 1. Apply this patch 2. Run: $ npx redoc-cli at 0.10.4 bundle --cdn --output index.html \ api/v1/swagger/swagger.yaml => SUCCESS: It builds correctly 3. Open index.tml on your browser 4. Pick a route, and see the 500 status description includes information about the possible `error_code` values. 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:37:13 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-e3VFGHhdUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 [Bug 29620] Move the OpenAPI spec to YAML format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:37:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:37:13 +0000 Subject: [Koha-bugs] [Bug 29620] Move the OpenAPI spec to YAML format In-Reply-To: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29620-70-Ynw9Y45YzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29620 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 [Bug 28020] Error responses should return a code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:39:34 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:39:34 +0000 Subject: [Koha-bugs] [Bug 29772] New: Make DELETE /patrons return error codes in error conditions Message-ID: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Bug ID: 29772 Summary: Make DELETE /patrons return error codes in error conditions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Bug 28020 introduces the option to return error codes instead of just textual descriptions. Let's use that! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:39:53 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-eG5i2Ne56t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28020, 29765 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 [Bug 28020] Error responses should return a code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:39:53 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-Cpddun88tm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 [Bug 29772] Make DELETE /patrons return error codes in error conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 14:39:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 13:39:53 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-aT3K8f5EHi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 [Bug 29772] Make DELETE /patrons return error codes in error conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:10:46 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:10:46 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-j5zGGnhrNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:10:49 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-ybVogP1uDS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128915|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128918&action=edit Bug 28020: Unit tests The unhandled_exception() Mojo helper didn't have proper tests. As this bug is adding a slight behavior change, I tried to add some. As it relies on the OpenAPI plugin, it cannot be done the usual way using Mojo::Lite. So I picked a route and forced an exception through mocking to be able to write tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:10:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:10:53 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-zQFT3mkZS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128916|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128919&action=edit Bug 28020: Add error_code to error responses This patch adds the *error_code* attribute to the error response definition. This way it can be added when returning an error. I also made a sample usage of it on the generic unhandled_exception helper, which the unit tests on this patchset expect. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:10:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:10:56 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-6cScbEwuYL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128917|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Created attachment 128920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128920&action=edit Bug 28020: (follow-up) Add docs about error_code on the API This patch intends to be a guide for inserting Markdown documentation for error codes. The idea is that it can be copied and pasted as-is in new routes. And adapted to new error codes. To test: 1. Apply this patch 2. Run: $ npx redoc-cli at 0.10.4 bundle --cdn --output index.html \ api/v1/swagger/swagger.yaml => SUCCESS: It builds correctly 3. Open index.tml on your browser 4. Pick a route, and see the 500 status description includes information about the possible `error_code` values. 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:15:35 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-RinMM2sEsh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29018 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Rebasing on top of bug 29018 as that one needs to be backportable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:15:35 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:15:35 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29018-70-N6bTip6h4A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 [Bug 28020] Error responses should return a code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:18:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:18:49 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-c0LYrAlVg3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128918|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128921&action=edit Bug 28020: Unit tests The unhandled_exception() Mojo helper didn't have proper tests. As this bug is adding a slight behavior change, I tried to add some. As it relies on the OpenAPI plugin, it cannot be done the usual way using Mojo::Lite. So I picked a route and forced an exception through mocking to be able to write tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:18:53 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:18:53 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-ocYiZGjNuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128919|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128922&action=edit Bug 28020: Add error_code to error responses This patch adds the *error_code* attribute to the error response definition. This way it can be added when returning an error. I also made a sample usage of it on the generic unhandled_exception helper, which the unit tests on this patchset expect. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:18:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:18:58 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28020-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28020-70-URuKDvVDQL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128920|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128923&action=edit Bug 28020: (follow-up) Add docs about error_code on the API This patch intends to be a guide for inserting Markdown documentation for error codes. The idea is that it can be copied and pasted as-is in new routes. And adapted to new error codes. To test: 1. Apply this patch 2. Run: $ npx redoc-cli at 0.10.4 bundle --cdn --output index.html \ api/v1/swagger/swagger.yaml => SUCCESS: It builds correctly 3. Open index.tml on your browser 4. Pick a route, and see the 500 status description includes information about the possible `error_code` values. 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:41:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:41:43 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-wNuUjLx9wP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128924&action=edit Bug 29772: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:41:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:41:47 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-uHHrXGRYJD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128925&action=edit Bug 29772: Make DELETE /patrons/:patron_id return error codes This patch makes the controller add the error_code attribute on error conditions payload. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Boo, the API doesn't include the error_code attribute on the error responses for the DELETE /patrons/:patron_id route 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! error_code is included in the response! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:41:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:41:51 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-Csk5OmbR25@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 128926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128926&action=edit Bug 29772: (follow-up) Document error codes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:42:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:42:02 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-rD1fZGwKP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 15:44:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 14:44:08 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-tRBupV7MMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make DELETE /patrons return |Make DELETE |error codes in error |/patrons/:patron_id return |conditions |error codes in error | |conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 20:13:19 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 19:13:19 +0000 Subject: [Koha-bugs] [Bug 29773] New: suggestion.pl event listener too restrictive Message-ID: <bug-29773-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29773 Bug ID: 29773 Summary: suggestion.pl event listener too restrictive Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Suggestion.pl has an event listener that is listening to all buttons of the type submit, which requires the user to select at least one suggestion on the page. This prevents other buttons of a submit type that have nothing to do with that particular form from being added to the page and working without this same restriction. $("button[type='submit']").on("click", function(e) { var submit_button = this; var form = $(submit_button).parents("form"); var action = $(submit_button).val(); var selected_suggestions = $(form).find("input[name='suggestionid']:checked"); if ( selected_suggestions.length == 0 ) { alert(_("Please select at least one suggestion")); e.preventDefault(); return false; } needs to be rewritten so that it is limited to the 4 buttons at the bottom of the page only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 27 21:10:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 20:10:52 +0000 Subject: [Koha-bugs] [Bug 24115] patron import tool should have option to not overwrite specific fields In-Reply-To: <bug-24115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24115-70-FbEbqXlGgW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24115 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> --- This would be very helpful for us when we want to update certain aspects of patron export automatically, but reserve some fields for changing. Anything we can do to get this moving, we would be happy to. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 00:49:07 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Dec 2021 23:49:07 +0000 Subject: [Koha-bugs] [Bug 29770] Refining acq add to basket workflow In-Reply-To: <bug-29770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29770-70-rxwgCVWuSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29770 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 16:46:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 15:46:40 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29066-70-XvM93Xl2VT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 16:46:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 15:46:44 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29066-70-kb71PBdSDz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Samu Heiskanen <samu.heiskanen at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125084|0 |1 is obsolete| | --- Comment #5 from Samu Heiskanen <samu.heiskanen at hypernova.fi> --- Created attachment 128927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128927&action=edit Bug 29066: Remove text in OPAC search form and use Font Awesome icons In modern front-end websites, first think you see in header region is an large input text with a search icon. No need to say it is a search form. We still tell it in 'title' attribut for accessibility. This patch removes 'Search' text. If 'my library first' feature is enabled, shows a text in title of a question mark icon. In submit button, replaces 'Go' with a seach icon and add title 'Search'. Test plan : 1) 1.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Add' SearchMyLibraryFirst to 'Don't limit' 1.2) Go to OPAC main page 1.3) You don't see 'Search' anymore 1.4) You see in submit button an icon 1.5) Move mouse over submit button to see tooltip text 'Search' 2) 2.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Don't add' SearchMyLibraryFirst to 'Limit' 2.2) Go to OPAC main page 2.3) Log in 2.4) You don't see text 'Search (in <library name>) only' 2.5) You see a question mark icon 2.6) Move mouse over submit button to see tooltip text 'Search (in <library name>) only' Signed-off-by: Samu Heiskanen <samu.heiskanen at hypernova.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 19:29:33 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 18:29:33 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29519-70-GPc4SSOCEX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 20:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 19:26:29 +0000 Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed without checking item in In-Reply-To: <bug-29769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29769-70-FdlYbKXBsm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 20:27:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 19:27:02 +0000 Subject: [Koha-bugs] [Bug 29774] New: Self registration notification management Message-ID: <bug-29774-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774 Bug ID: 29774 Summary: Self registration notification management Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Self registration notifications do not appear to be stored in the patron record under notices. While there is sensitive information in the notice that could be masked to staff, it would be helpful if there was a record of this notice on our end, and a way to resend (with new self-generated passwords when appropriate). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 28 22:02:51 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 21:02:51 +0000 Subject: [Koha-bugs] [Bug 29676] Protect a bib record from being overlaid when matched In-Reply-To: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29676-70-kpyvRWqKlo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29676 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 00:12:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Dec 2021 23:12:22 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29102-70-BlabJE3hLk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- I'm using a sandbox, and I haven't applied the patch yet and I am not running into the problem in step 5. It just checks out the item and removes the hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 11:08:26 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 10:08:26 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-GgN1sYHZ5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 11:08:30 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 10:08:30 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-wbdDQgrqzo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128887|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128928&action=edit Bug 29765: Make Koha::Patron->safe_to_delete use Koha::Result::Boolean This patch makes the safe_to_delete method in Koha::Patron return this new object type instead of a plain string. This way we have a consistent way to deal with 'can_*'-like methods return values when feedback is needed. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: The adjusted tests pass. Tests cover the boolean context eval and also the carried messages, that include the same string code that was returned originally. 3. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 11:08:38 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 10:08:38 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29765-70-AYmQVp7rtH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128914|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 128929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128929&action=edit Bug 29765: Adjust DELETE /patrons/:patron_id controller This patch adjusts the only current place using the Koha::Patron->safe_to_delete method to the new return value. There should be no behavior change To test: 1. Apply the previous patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, because of the change, the controller is broken 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No test tweak required, no behavior change 5. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 15:24:10 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 14:24:10 +0000 Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay In-Reply-To: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29756-70-ekeRkLSdI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) <george at nekls.org> --- This seems highly problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 15:33:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 14:33:32 +0000 Subject: [Koha-bugs] [Bug 27189] Unable to delete patron In-Reply-To: <bug-27189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27189-70-H7XLFhGjcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189 Anke <anke.bruns at gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED CC| |anke.bruns at gwdg.de --- Comment #2 from Anke <anke.bruns at gwdg.de> --- I encounter the same in one of my Koha libraries. In other libraries (instances), even on the same server, the problem doesn't occur. What can be the reason? To solve it, I tried several things which all didn't help: - Created an AnonymousPatron user and set the AnonymousPatron parameter from default "0" to the new AnonymousPatron accordingly. - deleted all entries from deletedborrowers which were duplicates to entries in borrowers. Interestingly, the borrowernumber of the borrower I had tried several times to delete showed up 6 times in deletedborrowers. None of the patrons have a cardnumber starting with a leading 0 (as in Bug #11636). Yet no patron can be deleted. Neither batch deletion nor deletion of a single borrower works. Deletion of a single borrower leads to the error message described here by Nishad Ahmed. Batch deletion leads to Internal server error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 17:39:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 16:39:36 +0000 Subject: [Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client In-Reply-To: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21225-70-a3WS61nmIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #8 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Just checking on the status of this one. We would love to be able to see Syndetics covers in the staff client, especially for DVDs, and other materials that Amazon doesn't have covers for such as Playaways. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 19:32:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 18:32:14 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: <bug-28734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28734-70-13rpugpwJh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Pablo AB <pablo.bianchi at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #31 from Pablo AB <pablo.bianchi at gmail.com> --- Will be backported to 21.05.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 21:55:57 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 20:55:57 +0000 Subject: [Koha-bugs] [Bug 29775] New: Batch deleting items with linked analytics gives unhelpful error Message-ID: <bug-29775-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29775 Bug ID: 29775 Summary: Batch deleting items with linked analytics gives unhelpful error Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Deleting an item from detail -> Edit items gives a nice "Cannot delete: item has linked analytics.." however, when you try to batch delete these items (tick the boxes from detail.pl and click "delete items") - the error is only "Cannot delete items" - which can cause quite a lot of confusion if the item is not otherwise impeded from being deleted. It would be nice to have more detail on this error message for this case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 29 23:44:44 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Dec 2021 22:44:44 +0000 Subject: [Koha-bugs] [Bug 28698] News for all displays in all locations In-Reply-To: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28698-70-pldUa4Yk8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can confirm the bug in 20.11 - we have seen it a few times when updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 07:35:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 06:35:21 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-879UHeEGEZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |alex.arnaud at biblibre.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 09:02:22 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 08:02:22 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-QQ8Oo8YoYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 09:04:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 08:04:45 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28267-70-SmQkAKgzFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #24 from Fridolin Somers <fridolin.somers at biblibre.com> --- We also need to impact borrowers table right ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:10:49 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:10:49 +0000 Subject: [Koha-bugs] [Bug 18683] biblioitems.marcxml does not match MARC21slim.xsd In-Reply-To: <bug-18683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18683-70-MCc71UVyvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18683 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |tomascohen at gmail.com Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- The biblioitems.marcxml column doesn't exist anymore on the current stable releases. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:15:17 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:15:17 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-FpBalCxAvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #9 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128930&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:17:00 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:17:00 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-H4kxXMoCu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot at biblibre.co | |m Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:18:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:18:24 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-XE2Xx85kRa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:20:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:20:08 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-qYO5SdzQWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128931&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:20:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:20:40 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-eBwl5DdU2b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:20:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:20:58 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-TWSz7chjyd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:23:43 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:23:43 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-V0IghQuzVR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #11 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128932&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query Bug 26537: (follow-up) fix paging of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:24:41 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:24:41 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-IZirLy4Mg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:25:14 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:25:14 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-7JbSRlnRwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:25:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:25:59 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-DpW79DQsim@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128933&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:26:29 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:26:29 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-TjZ9AFkDqd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:26:59 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:26:59 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-bO2m3fgd40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:27:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:27:45 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-rkOgKmjgA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #13 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128934&action=edit Bug 26537: (follow-up) fix paging of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:28:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:28:13 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-oU0jvdXj0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:28:40 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:28:40 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-5tlGpGXm0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:38:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:38:08 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: <bug-24630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24630-70-dgkBKanwlN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 17:38:12 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 16:38:12 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: <bug-24630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24630-70-SZZuEvKuSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Florian <florian.bontemps at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116580|0 |1 is obsolete| | --- Comment #9 from Florian <florian.bontemps at biblibre.com> --- Created attachment 128935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128935&action=edit Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode Signed-off-by: Florian Bontemps <florian.bontemps at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 30 22:12:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Dec 2021 21:12:36 +0000 Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay In-Reply-To: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29756-70-EZndObtODO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- Temporary workaround until this is fixed: //Add missing hold link to opac-detail when holdings are hidden (v21.05) if ($('#opac-detail').length) { if($('#holdings:contains("This record has many physical items")').length){ var detailBib = $('#catalogue_detail_biblio').attr('data-biblionumber'); $('#action').prepend('<li><a class="reserve btn btn-link btn-lg" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=' + detailBib + '"><i class="fa fa-fw fa-bookmark" aria-hidden="true"></i> Place hold</a></li>'); } } //END Add missing hold link to opac-detail when holdings are hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:12:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:12:58 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-5ndChOX1eV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128937&action=edit Bug 26537 : (follow-up) fix paging of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:13:32 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:13:32 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-PNvm2Yp0ZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:13:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:13:45 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-UOcZwILh58@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:16:04 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:16:04 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-w1gubglZTE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #15 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 128938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128938&action=edit Bug 26537 : (follow-up) fix paging of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:36:45 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:36:45 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26537-70-JDAgaeg5cT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:36:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:36:52 +0000 Subject: [Koha-bugs] [Bug 29776] New: Fields 580 are wrong displayed in summary column Message-ID: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29776 Bug ID: 29776 Summary: Fields 580 are wrong displayed in summary column Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.breuillard at biblibre.com QA Contact: testopia at bugs.koha-community.org Whitespaces escaped by ; are displayed in the summary instead of fields 580 Test plan: 1)Home > Authorities > Result from authority search 2)On the authorities list, verify that one of those is displaying the fields 580 on the summary column (it should look like: ; ; ; ;) 3)Apply patch 4)Repeat 1) and 2) 5)Notice the changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:41:21 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:41:21 +0000 Subject: [Koha-bugs] [Bug 29776] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29776-70-7PQXsPwGDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29776 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- In the results of an Authority searching we can see semicolon appears in 'Summary' column. It should be field 580 instead -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:42:05 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:42:05 +0000 Subject: [Koha-bugs] [Bug 29776] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29776-70-hAUK4CYlqr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29776 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- In the results of an Authority searching we can see semicolon appears in 'Summary' column. It should be field 580 instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:43:24 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:43:24 +0000 Subject: [Koha-bugs] [Bug 29777] New: Fields 580 are wrong displayed in summary column Message-ID: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Bug ID: 29777 Summary: Fields 580 are wrong displayed in summary column Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.breuillard at biblibre.com QA Contact: testopia at bugs.koha-community.org In the results of an Authority searching we can see semicolon appears in 'Summary' column. It should be field 580 instead -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:43:36 +0000 Subject: [Koha-bugs] [Bug 29776] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29776-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29776-70-djlPpuc4yg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29776 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- *** This bug has been marked as a duplicate of bug 29777 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 09:43:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 08:43:36 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29777-70-RZqkEBLbDg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- *** Bug 29776 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 11:31:52 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 10:31:52 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29777-70-TPAwVpuI7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 --- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> --- Created attachment 128939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128939&action=edit Bug 29777: Fields 580 are wrong displayed in summary column Whitespaces escaped by ; are displayed in the summary instead of fields 580 To test: 1)Home > Authorities > Result from authority search 2)On the authorities list, verify that one of those is displaying the fields 580 on the summary column (it should look like: ; ; ; ;) 3)Apply patch 4)Repeat 1) and 2) 5)Notice the changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 11:32:47 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 10:32:47 +0000 Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary column In-Reply-To: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29777-70-TN9m7FvmMF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:00:50 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:00:50 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-6r3dcrshn5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:00:56 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:00:56 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-0ZTIgVt2q6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128907|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 128940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128940&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:05:09 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:05:09 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29758-70-E78Vw9RJfT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the cause of release notes| |warning messages ([WARN] | |CGI::param called in list | |context from...) in the | |plack-intranet-error.log | |when accessing the | |accounting transactions tab | |for a patron. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:16:58 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:16:58 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-mZpkA5apZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:17:02 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:17:02 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-nuI7xf7R3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128924|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 128941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128941&action=edit Bug 29772: Regression tests Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:17:06 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:17:06 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-zn9H8WKxi5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128925|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 128942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128942&action=edit Bug 29772: Make DELETE /patrons/:patron_id return error codes This patch makes the controller add the error_code attribute on error conditions payload. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Boo, the API doesn't include the error_code attribute on the error responses for the DELETE /patrons/:patron_id route 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! error_code is included in the response! 5. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 18:17:11 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 17:17:11 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29772-70-xMVnq3iJkE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128926|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 128943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128943&action=edit Bug 29772: (follow-up) Document error codes Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 19:30:08 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 18:30:08 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-I67CdpgWyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 19:30:13 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 18:30:13 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-hKigCMvYyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128854|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 128944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128944&action=edit Bug 28332: Fix data encoding when requesting Mana token Authored-by: Alex Arnaud Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 19:30:18 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 18:30:18 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-bL1et5VXka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128855|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 128945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128945&action=edit Bug 28332: (follow-up) Include encode_json method in admin/share_content.pl Test plan: - Go to Administration Share content with Mana KB (cgi-bin/koha/admin/share_content.pl) - In "Configure Mana KB" part, set your email and a name with accent (Université Foo), - Click on "Send to Mana KB" => Fail. No mana token. Sponsored-by: Catalyst IT Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 31 19:36:36 2021 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Dec 2021 18:36:36 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28332-70-ZkcnTbblIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes the Mana release notes| |configuration so that | |accented names (such as | |Université Foo) can be used | |when requesting the Mana | |token. Before this, the | |account registration would | |fail and no token was | |received back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.