[Koha-bugs] [Bug 29484] ListSets doesn't return noSetHierarchy when appropriate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29484

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #9)
> (In reply to Jonathan Druart from comment #5)
> > I will amend the patch with
> > -    ) unless scalar @{$sets} > 0;
> > +    ) unless @$sets;
> 
> Why? I prefer what I wrote and have been adding it all the time. If it makes
> more sense to do it your way, we should make sure it is in the guidelines. I
> still prefer to have the reader understand we are talking about the list
> size.

ok, reverted.

@$sets does exactly what you are describing, just less verbose. Nevermind.

-- 
You are receiving this mail because:
You are watching all bug changes.