[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
And... thinking loud, sorry for the noise if it does not make sense.

There is a _CanBookBeAutoRenewed sub but we are still doing "auto renewal"
related checks in CanBookBeRenewed. It should be simpler than that actually, we
should call _CanBookBeAutoRenewed that will call CanBookBeRenewed, not the
reverse.

Ideally
  Koha::AutoRenewalHold inherit from Koha::Hold
  Koha::AutoRenewalHold->can_be_renewed will do its specific check for auto
renew then can SUPER::can_be_renewed

Aren't we actually doing the reverse here?

-- 
You are receiving this mail because:
You are watching all bug changes.