[Koha-bugs] [Bug 29633] New: Unecessary GetMarcBiblio call in Koha::UI::Form::Builder::Item (?)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29633

            Bug ID: 29633
           Summary: Unecessary GetMarcBiblio call in
                    Koha::UI::Form::Builder::Item (?)
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Andrew contacted me to raise a potential problem coming from bug 27526:

  commit 7a8357f7099d0863a322d1e91741b792b97fd6e1
  Bug 27526: Adjust code to use Koha::Items

-C4::Biblio::EmbedItemsInMarcBiblio({
-    marc_record  => $temp,
-    biblionumber => $biblionumber });

has been removed.

I have tried to know where the items subfields could be used and found, in
Koha/UI/Form/Builder/Item.pm:
1. only if itemcallnumber is used
164             my $temp2 = $marc_record->field($CNtag);

2. cataloguing plugins:
316             record  => $marc_record,

I have not found any cataloguing plugins using the MARC::Record (some are
retrieving it when they have been passed in parameter, but that's another
story).

So maybe we could:
* Remove marc_record from generate_subfield_form param list
* Fetch it in the itemcallnumber block
* Remove it from the cataloguing plugins

-- 
You are receiving this mail because:
You are watching all bug changes.