[Koha-bugs] [Bug 29628] purchase suggestion link on staff main page should always show, even if logged in branch has 0 suggestions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 128220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128220&action=edit
Bug 29628: (follow-up) fix for rare edge case

When the number of pending suggestions in the currently selected branch
is equal to the number of pending suggestions across all branches, the
`all_pendingsuggestions` template parameter is equal to 0. This results
in the "Suggestions pending approval:" block not being printed at all.

This follow-up patch fixes that.

Also fixed is the display of pending suggestions in Home > Acquisitions.

Test plan:
1) Apply this patch.
2) Create two Library branches; submit two suggestions in each one.
3) Visit the Home page, and also visit Home > Acquisitions: you should
   only see "${BRANCH_CODE}: 2" suggestions pending approval, regardless
   of the branch you have selected using the 'Set library' menu option.
4) Delete both suggestions from the 1st branch, and set your library
   to be the 1st branch.
5) Visit the same pages: this time "${BRANCH_CODE}: 0 / All libraries: 2"
   is displayed.
6) Set your library to be the 2nd branch, and visit the same two pages:
   this time "${BRANCH_CODE}: 2" is displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.