[Koha-bugs] [Bug 29349] Item-level holds should assume the same pickup location as bib-level holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 128233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128233&action=edit
Bug 29349: Do not assume holding branch is a valid pickup location

The original code for pickup locations when placing item-level holds
picked the currently logged-in library.

We made things more robust, as the logged-in library might not be a
valid pickup location for the patron and item. But it was wrongly chosen
to use the holding branch as the default.

A more robust approach is needed, and this precedence is picked this
time (it could be configuration-driven in the future):

    - Logged-in library
    - Holding branch
    - The first valid pickup location the above are not valid

To test:
1. Pick a biblio with various valid pickup locations, some not including
   the logged-in library.
2. Pick a patron for placing the hold
=> FAIL: Notice that (when valid pickup location) the holding branch is
always chosen
3. Apply this patch
4. Repeat 2
=> SUCCESS: If valid pickup location, the logged-in branch is picked as
default for item-type level. When it is not, the holding branch is
picked, and if not, some of the valid pickup locations is selected (i.e.
there's no empty dropdowns)
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.