[Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at hypernova.fi

--- Comment #12 from Lari Taskula <lari.taskula at hypernova.fi> ---
Hi Samu and welcome,

I can confirm the "No title" bug from Nick's patches.

I tested Samu's patch and noticed that your patch is introducing a new bug -
batch placement of holds gets broken, follow this plan to replicate:
  0. Have at least two bibliographic records in your Koha installation
  1. In staff client, perform a search that returns at least two results
  2. On search result list there are checkboxes, check them for two or more
results
  3. Click "Place hold" button
  4. Observe the following error: "Cannot place hold: one or more records don't
exist."

This is because at line 326 (with your patch included) we are checking if any
of the biblios in batch request is missing. The loop that starts at line 321 is
handling each biblio of the batch request individually and each iteration
requires that specific biblio to be loaded with "my $biblio =
Koha::Biblios->find( $biblionumber );" so that required steps can be performed
on it.

Also, patch/commit title should be "Bug 29043: subject". See
https://wiki.koha-community.org/wiki/Commit_messages#Subject_line

-- 
You are receiving this mail because:
You are watching all bug changes.