[Koha-bugs] [Bug 27708] Cannot create EDI order if AcqCreateItem value is not "placing an order"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27708

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 127233
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127233
Bug 27708: Unify two item object creation blocks to be stored as hash

Review of attachment 127233:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27708&attachment=127233)
-----------------------------------------------------------------

::: Koha/Edifact/Order.pm
@@ +392,5 @@
> +                    branchcode     => $item->{branchcode},
> +                    itype          => $item->{itype},
> +                    location       => $item->{location},
> +                    itemcallnumber => $item->{itemcallnumber},
> +                };

Pretty sure the above block causes breakage.. you are using `$item` as though
it's a hash representation of an item row.. but it's not.. it's the hash of the
AqOrdersItems link table.. so it doesn't contain branchcode, itype, location or
itemcallnumber.

It should be using the actual item row.. as before.. $i_obj

This breaks our live systems

-- 
You are receiving this mail because:
You are watching all bug changes.