[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 10 07:40:41 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Fridolin Somers from comment #4)
> I see it returns undef when plugins are disabled.
> It should return empty array non ?
> 
> In order to allow :
> 
> my @plugin_responses = Koha::Plugins->call(
>     'opac_results_xslt_variables',
>     {
>         lang       => $lang,
>         patron_id  => $borrowernumber
>     }
> );
> for my $plugin_variables ( @plugin_responses ) {
>     $variables = { %$variables, %$plugin_variables };
> }

Oh i see it is covered by a unit test :
    t::lib::Mocks::mock_config('enable_plugins', 0);
    @responses = Koha::Plugins->call('check_password', { password => '1234' });
    is_deeply(\@responses, [], 'call() should return an empty array if plugins
are disabled');

Should be OK :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list