[Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Björn, 

thx for your patches! Some first things I noticed:

1) QA test tools
There are some problems noticed by the QA test tools. It's a good habit to run
them yourself before submitting patches to catch these kind of things:

 FAIL   circ/returns.pl
   FAIL   critic
                # Variables::ProhibitConditionalDeclarations: Got 1
violation(s). 

 FAIL  
installer/data/mysql/atomicupdate/bug_27208-add_delay_util_to_message_queue.pl
   FAIL   file permissions
                File must have the exec flag
   FAIL   valid
                Useless use of anonymous hash ({}) in void context 

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
   FAIL   forbidden patterns
                forbidden pattern: console.log (line 1167)

2) Authorship of patches

The first 2 patches don't have your authorship:

Author: root <root at 9b7442205204>

3) Functionality

It looks like this will allow for manually setting a time until the notice will
be delayed on the checkin page. I am not sure if this is what Barbara had in
mind here as it won't work for self checkins using the web based checkin or the
RFID based ones. - And it also might be quite easy to get things confused if
you have multiple circulation desks.

I wonder if it would not be easier/better to make this a configuration setting,
but probably a little harder to do. I am thinking circulation rules, since you
might want to differentiate for different branches, but possibly a global
setting could also be a good starting point.

What do others think?

-- 
You are receiving this mail because:
You are watching all bug changes.