[Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Shouldn't we fix all the existing occurrences?

background-job-progressbar.js:                humanMsg.displayMsg( '<p>' +
_('Import of record(s) failed: ') + textStatus + '</p></br>'+xml.responseText,
{ className: 'humanError' } );
calendar.js:                is_date_after: _("Validation error to be shown,
i.e. End date must come after start date")
checkouts.js:        $(selected_option).text(_("%s (current
status)").format($(selected_option).text()));
datatables.js:                        var search_title = _("%s
search").format(title);
holds.js:            _("This pickup location is not allowed according to
circulation rules") +
letter.js:        $(sms_counter).html(length + "/" + sms_limit + _("
characters"));
onboarding.js:function _(s) { return s; } // dummy function for gettext
pages/results.js:                            div.find(".hint").html(_("Coce
image from Amazon.com"));
pages/results.js:                            div.find(".hint").html(_("Coce
image from Google Books"));
pages/results.js:                            div.find(".hint").html(_("Coce
image from Open Library"));
pages/tags-review.js:    // window.alert(_("AJAX approved tag: ") + tag);
pages/tags-review.js:    // window.alert(_("AJAX rejected tag: ") + tag);
pages/tags-review.js:    $('#test_button').html("<i class='fa
fa-check-square-o' aria-hidden='true'></i>" +_(" Test"));
pages/tags-review.js:        // window.alert(_("Click detected on ") +
event.target + ": " + $(event.target).html);
rotating-collections.js:        if(confirm(_("Are you sure you want to delete
this rotating collection?"))){
xmlControlfield.js:                alert(_("AJAX error: receiving data from
%s").format(settings.url));

-- 
You are receiving this mail because:
You are watching all bug changes.