[Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in <branchcode>0001 option

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128490|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 128521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128521&action=edit
Bug 29689: (bug 28445 follow-up) Fix AutoBarcode=hbyymmincr

The selector is not correct, we need to use .input_marceditor instead of
name="field_value".

Test plan:
Set autoBarcode=<branchcode>yymm0001
Catalogue a new item, click into the barcode input
Notice that without this patch you get a JS error in the console

Uncaught TypeError: form.field_value is undefined
    Focustag_952_subfield_p_878344
    Focustag_952_subfield_p_878344_handler
    jQuery 11
    BindEventstag_952_subfield_p_878344

With this patch applied the barcode is correctly generated.

QA Note: it would be way easier if all add item forms were using the new
methods, it could be:
  let loc = document.getElementsByName('items.homebranch')[0].value;
Yes, that's all!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.