[Koha-bugs] [Bug 29602] We must be nicer with translators

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
All done, thanks Frido!

(In reply to Fridolin Somers from comment #29)
> 6)
> 
> There is a removal in issues_stats.tt, is this on purpose ?
>  - [% loopfilte.filter | html %]
> 
> https://bugs.koha-community.org/bugzilla3/attachment.
> cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/
> issues_stats.tt_sec1

Yes, it's moved up to be part of the string to translate.

(In reply to Fridolin Somers from comment #30)
> 7)
> 
> There is a missing openning <span> :
>         [% ELSIF ( message_loo.approver ) %]No match for user ([%
> message_loo.approver | html %]). FILTER REQUIRES BORROWERNUMBER (not
> name).</span>
> 
> https://bugs.koha-community.org/bugzilla3/attachment.
> cgi?id=128109&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/
> review.tt_sec1
> 
> In fact other lines all have :
>   <strong>Error :</strong> ...
> 
> Maybe this text can be moved outside of IF loop.

I fixed the missing span but prefer to not modify the logic here.

-- 
You are receiving this mail because:
You are watching all bug changes.