[Koha-bugs] [Bug 29697] New: Excessive use of StripNonXmlChars

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

            Bug ID: 29697
           Summary: Excessive use of StripNonXmlChars
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We are using C4::Charset::StripNonXmlChars from different places of the code to
remove characters that should not be part of the MARC::XML

Historically we were removing them every time we were fetching the record.

However, since we are starting to use Koha::Biblio::Metadata
($biblio->metadata->record) to retrieve the xml stored in the biblio_metadata
table, such characters will not be removed and a degraded view will be
displayed on the bibliographic detail page (see bug 23846).

We didn't get a lot of complains, and it's part of Koha since 19.05.05.

Shouldn't we start to use $biblio->metadata->record where GetMarcBiblio is
actually used?

Either we assume the MARC::XML that is stored is correct, or we need to add
more StripNonXmlChars calls.

-- 
You are receiving this mail because:
You are watching all bug changes.