[Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587

--- Comment #27 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #26)
> (In reply to Jonathan Druart from comment #21)
> > Created attachment 128446 [details] [review] [review]
> > Bug 26587: Use Koha::Cache::Memory::Lite
> 
> Great.
> 
> But in my opinion cache key is too short :
>   my $cache_key    = "Library_branchname:" . $branchcode;
> We may have need for library datas cache in other places.
> 
> I propose :
>   my $cache_key    = "Template_Plugin_Branches_branchname:" . $branchcode;

Good call on using Koha::Cache::Memory::Lite. 

I suppose the cache key is debateable. I don't think we have an index of cache
keys, so Frido might be right about making a more targeted cache key, so that
there isn't an accidental collision with another script that stores different
data using the same key.

-- 
You are receiving this mail because:
You are watching all bug changes.