[Koha-bugs] [Bug 29721] New: automatic_renewal.pl dies if patrons choose SMS for digests and there is no SMS template defined

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29721

            Bug ID: 29721
           Summary: automatic_renewal.pl dies if patrons choose SMS for
                    digests and there is no SMS template defined
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:

1.  Have AutoRenewalNotices set to "according to patron messaging preferences"
2.  Make some patron checkouts eligible from auto_renewal 
3.  Turn on SMS and Digest only Auto renewal messaging prefs for that patron
4. By default there is no SMS template for AUTO_RENEWALS_DGST, leave it that
way
5. Run automatic_renewal.pl

When it hits that patron you'll see:

No circulation AUTO_RENEWALS_DGST letter transported by sms at
/kohadevbox/koha/C4/Letters.pm line 633.
no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see
sample_notices.sql at /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl line
304.
Can't use string ("1") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Letters.pm line 947.


The job dies at this point. It would be better if it just skipped sending this
patron a notice and carried on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.