[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420

--- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to David Cook from comment #25)
> (In reply to Jonathan Druart from comment #23)
> > 
> > I cannot PQA without a follow-up bug report and patch.
> 
> Could you elaborate a bit? 
> 
> Do you mean a follow-up bug report that depends on this one? And in that bug
> report one would replace C4::Auth::psgi_env with
> C4::Context->is_psgi_or_plack() (or vice versa) and check that it doesn't
> cause a regression in the multiple different calls to C4::Auth::safe_exit?

Yes, we should use a single method for the same thing. Here you introduce
is_psgi_or_plack then we should use it from where psgi_env and other similar
checks exist.

Either here or a separate bug report.

`git grep "psgi.*ENV"` shows the different occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.