[Koha-bugs] [Bug 28698] News for all displays in all locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28698

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128098|0                           |1
        is obsolete|                            |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 128678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128678&action=edit
Bug 28698: Fix news for all displays in all locations

Some news are used for custom text with a specific language, for example
"opacheader".
The bug is that in these locations, news for all (staff and opac) are
displayed.
This is because GetNewsToDisplay uses SQL :
  opac_news.lang = '' OR opac_news.lang = ?

This patch is a quick fix.
This feature maybe needs a big revamping.

Test plan :
1) Remove any news
2) Create a news with empty 'Display location' and some content
3) Display OPAC interface
4) without patch you see in location of 'opacheader', 'opacnavright' ... the
content
   of the news
5) With patch you see content of the news only in news table
6) Create a news for opacheader
7) Check it appears in correct language

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.