[Koha-bugs] [Bug 29727] New: Koha should respect NoRenewalBeforePrecision when No Renewal Before is unset

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29727

            Bug ID: 29727
           Summary: Koha should respect NoRenewalBeforePrecision when No
                    Renewal Before is unset
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:
- create a circ rule for item type A, automatic renewal, No Renewal Before=0
- create a circ rule for item type B, automatic renewal, No Renewal Before
unset
- set NoRenewalBeforePrecision to Exact Time
- check out an item of type A with a due date of today, 23:59
- check out an item of type B with a due date of today, 23:59
- perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -v
- confirm neither checkout would have renewed, both would get auto_too_soon
error
- set NoRenewalBeforePrecision to Date
- perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -v
- confirm that item type A, where No Renewal Before=0, would have renewed
- confirm that item type B, where No Renewal Before is unset, would have
renewed


We generally treat an unset No Renewal Before as equivalent to zero for
automatic renewal. We should do the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.