[Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Fridolin Somers from comment #4)
> (In reply to Tomás Cohen Arazi from comment #3)
> > I don't even think it should consider the syspref. The syspref would've been
> > considered when setting the 'schema'
> 
> Ah but the code of get_marc_*() often contains a "if UNIMARC else ..."
> because fields number are hardcoded (for example title on 200 in UNIMARC).
> 
> Only when we will have a Dublin Core schema this will not be needed anymore
> ^^

What if the biblio_metadata.schema had UNIMARC and the syspref MARC?

I'd say biblio_metadata.schema would be the source for truth, same as with
DublinCore. So we don't need to read the syspref in
Koha::Biblio::Metadata->authors, we just check $self->schema and do the right
thing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.