[Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903

marion.durand at biblibre.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #19 from marion.durand at biblibre.com ---
(In reply to Tomás Cohen Arazi from comment #17)
> Ok, a few comments:
> - If you add parameters to a koha-* script, you need to add them to the docs
> in debian/docs/koha-* as well. This is a blocker, so FQA
I just submited a patch to fix that point. 


> Also
> - I don't 100% understand how the uploaded tmp files will be differentiated
> from any other file in tmp. The 'get_tmp_path' function name in
> koha-functions.sh raised my suspicion, as it doesn't mention 'upload' or
> 'uploaded'. This could be revisited too.
The function 'get_tmp_path' get the general tmp files but then we complete the
path to the uploaded folder with this line: 
'uploaded_temp_files_dir="$tempdir/koha_${name}_upload"
(tempdir is set just before with 'get_tmp_path' fuction)


> - I have the feeling that in order to make this more useful for production,
> we could try thinking how this could be used from koha-run-backups. When I
> added the 'exclude_indexes' option switch to koha-dump, I also added it to
> koha-run-backups. In this case it is not a flag (yes/no) but a string
> parameter with a path, so it doesn't sound like a straight-forward addition.
> But... maybe an option switch to include/not include uploads on the backup?
> Food for thougth, not a blocker.
I agree with you but as it doesn't sone simple, I won't do it here. I opened a
new bug (Bug 29738) and I'll will add a patch soon.

-- 
You are receiving this mail because:
You are watching all bug changes.