[Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. I took a deeper look and my assumptions were correct.. so I applied the
two patchsets and ran the tests again.. and for me.. they pass as expected?!

Are you sure you had both this patchset and bug 29718 applied?

It is a bit of a funky test... in smart-rules we actually grab the passed date,
convert to a datetime, then convert to an iso string and drop the time
component. In the test, we're just passing a DateTime object, so it'll include
a time element and it'll contextually stringify using the datetime defaults (to
ISO including Time - Hense the 'T').

What is happening in our DateUtils is that we try to match on preference format
('us' in this case which will fail) and then fallback to 'sql/iso'.

-- 
You are receiving this mail because:
You are watching all bug changes.