[Koha-bugs] [Bug 29245] Fix the parameters of getTranslatedLanguages

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29245

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #19)
> (In reply to Marcel de Rooy from comment #17)
> > (In reply to Katrin Fischer from comment #16)
> > > I count myself as a non-progammer tester as well - I think you mean that we
> > > already break the rule for not hardcoding the template, but I think those
> > > are bugs we should fix then. Hea shows that having your own OPAC template is
> > > not as rare as one would think.
> > 
> > This is an architectural patch, not the popular kind, yes. And insisting
> > that it should also fix such occurrences makes it even harder. Since the
> > patch is about fixing parameters, I would be tempted to say that it is
> > outside the scope too ;)
> > 
> > Having a look now how to get this on track again. But if it takes too much
> > time, I will abandon it.
> 
> I didn't mean fixing them on this bug - just that I would consider it a bug
> and that we should not add more hardcoded 'bootstraps'.

No problem. I understand your point and was willing to revert a few occurrences
too. But working further, I decided to refactor a little bit more. Add more
tests and at some point my time was up ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.