[Koha-bugs] [Bug 27946] Add a charge per article request to patron categories

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 21 14:27:51 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946

--- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #54)
> Personally do not likes changes like this:
> 
> -        [%- CASE 'ACCOUNT'          -%]Account creation fee
> -        [%- CASE 'ACCOUNT_RENEW'    -%]Account renewal fee
> -        [%- CASE 'LOST'             -%]Lost item
> -        [%- CASE 'MANUAL'           -%]Manual fee
> -        [%- CASE 'NEW_CARD'         -%]New card
> -        [%- CASE 'OVERDUE'          -%]Fine
> -        [%- CASE 'PROCESSING'       -%]Lost item processing fee
> -        [%- CASE 'RENT'             -%]Rental fee
> -        [%- CASE 'RENT_DAILY'       -%]Daily rental fee
> -        [%- CASE 'RENT_RENEW'       -%]Renewal of rental item
> -        [%- CASE 'RENT_DAILY_RENEW' -%]Renewal of daily rental item
> -        [%- CASE 'RESERVE'          -%]Hold fee
> -        [%- CASE 'RESERVE_EXPIRED'  -%]Hold waiting too long
> -        [%- CASE 'Payout'           -%]Payout
> -        [%- CASE                    -%][% debit_type.description | html %]
> +        [%- CASE 'ACCOUNT'             -%]Account creation fee
> +        [%- CASE 'ACCOUNT_RENEW'       -%]Account renewal fee
> +        [%- CASE 'ARTICLE_REQUEST_FEE' -%]Article scan request fee
> +        [%- CASE 'LOST'                -%]Lost item
> +        [%- CASE 'MANUAL'              -%]Manual fee
> +        [%- CASE 'NEW_CARD'            -%]New card
> +        [%- CASE 'OVERDUE'             -%]Fine
> +        [%- CASE 'PROCESSING'          -%]Lost item processing fee
> +        [%- CASE 'RENT'                -%]Rental fee
> +        [%- CASE 'RENT_DAILY'          -%]Daily rental fee
> +        [%- CASE 'RENT_RENEW'          -%]Renewal of rental item
> +        [%- CASE 'RENT_DAILY_RENEW'    -%]Renewal of daily rental item
> +        [%- CASE 'RESERVE'             -%]Hold fee
> +        [%- CASE 'RESERVE_EXPIRED'     -%]Hold waiting too long
> +        [%- CASE 'Payout'              -%]Payout
> +        [%- CASE                       -%][% debit_type.description | html
> %]
> 
> If you want to add one line, why change 20 ?

We do that to keep the indentation, I would do it again anytime it is needed
:-D
That said, I think I can remove the trailing _FEE and avoid it this time!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list