[Koha-bugs] [Bug 23291] Patron batch modification based on SMS number

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291

--- Comment #25 from David Nind <david at davidnind.com> ---
Created attachment 128876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128876&action=edit
Bug 23291 - Duplicated patrons

Testing notes (koha-testing-docker):

1. I created three text files that listed card numbers, borrow numbers, and SMS
numbers for four patrons. One was duplicated (see the lists at the end).

2. Enabled adding and sending messages by SMS:
   . Set SMSSendDriver system preference to Email
   . Not sure whether this is necessary, but for SMS providers (Administration
> Additional parameters > SMS cellular providers) I added:
     - Name: TEST
     - Domain: example.com

3. Added SMS numbers and SMS provider to patrons.

4. Went through the test plan.

5. When modifying data I just changed the ZIP/Postal code each time.


Other notes/things I noted - this is existing behavour, so should be new bugs
for fixing them if it is required or warranted: 

1. Each batch patrons modification listing page has a 'Mobile' column - this
matches to 'Other phone' in the contact information section when editing the
patron. It is not the same as the SMS number.

2. If an SMS number applies to one or more patrons and it is included in the
input twice or more (either in the file or the input form), then each patron
with that number is shown twice on the batch patrons modification page - see
the screenshot. This behaviour is exhibited for the by card number and by
borrower number options, so is not something introduced by this bug.

3. Should 'By borrowernumber' be 'By borower number'? Realising that is the
field name used in the query/URL, but is not "human friendly". Or perhaps
'System patron number' or just 'Patron number'? It is also shown on the patron
details page in the summary box on the top left.

Details for the three separate files (mentioned in item 1):

Card numbers:
  23529000035676
  23529000651225
  23529000080862
  23529000695412

Borrower numbers:
  19
  49
  7
  38

SMS numbers:
  2125551212
  2125551212
  2125551213
  2125551214

-- 
You are receiving this mail because:
You are watching all bug changes.