[Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (19.11.x), tests don't pass.
If needed for 19.11, please send a patch. Note that it's not a major bug so
it's not a big deal if it's not backported. Just tried to backport since I
already knew the test plan.

t/db_dependent/SIP/ILS.t .. 2/11 
    #   Failed test 'We get a success message when issue is renewed'
    #   at t/db_dependent/SIP/ILS.t line 170.
    #          got: 'Issue failed : NO_MORE_RENEWALS'
    #     expected: 'Item already checked out to you: renewing item.'

    #   Failed test 'Renewals has been reduced'
    #   at t/db_dependent/SIP/ILS.t line 173.
    #          got: '0'
    #     expected: '1'
    # Looks like you failed 2 tests of 4.
t/db_dependent/SIP/ILS.t .. 11/11 
#   Failed test 'checkout'
#   at t/db_dependent/SIP/ILS.t line 174.
# Looks like you failed 1 test of 11.

For the first failure, it seems the messages where simpler (NO_MORE_RENEWALS)
in 19.11 which can be fixed in the test, however this is not the same semantic
between the actual and expected message.

-- 
You are receiving this mail because:
You are watching all bug changes.