[Koha-bugs] [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1.
 69         tendered => scalar $input->param('tendered'),

Looks like this var is not used in the notice template.

2.
 65         credits   => $credit_id,
 66         borrowers => $patron->borrowernumber

Should not we remove borrowers/[% patron %] and use credit.patron instead?

3.
+            - "[% PROCESS 'accounts.inc' %]"

There is no precedence for that (using an include file from a notice template).
Don't know if it's a good idea or not. Does it work with translation?

-- 
You are receiving this mail because:
You are watching all bug changes.