[Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 4 04:55:30 CET 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #72 from David Cook <dcook at prosentient.com.au> ---
I think something I find challenging about this patch set is that it makes a
number of changes beyond including support for the timezone offset.

I think it might be easier to get this through if it were broken up into
different bugzilla issues. For instance:

1. Correct tests for offset handling in RFC3339 dates
2. Don't fallback when date_format is passed
3. Correct offset handling in dt_from_string
4. Always return 'instance' local time

Honestly, the number of different changes just makes me less confident that I'm
thoroughly testing everything and that makes me uncomfortable QAing this one.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list