[Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #12)
> +        if ( $c eq 'more_subfields_xml' ) {
> +            my @more_subfields_xml =
> $input->multi_param("items.more_subfields_xml");
> +            my @unlinked_item_subfields;
> +            for my $subfield ( @more_subfields_xml ) {
> +                my $v = $input->param('items.more_subfields_xml_' .
> $subfield);
> +                push @unlinked_item_subfields, $subfield, $v;
> +            }
> +            if ( @unlinked_item_subfields ) {
> +                my $marc = MARC::Record->new();
> +                # use of tag 999 is arbitrary, and doesn't need to match
> the item tag
> +                # used in the framework
> +                $marc->append_fields(MARC::Field->new('999', ' ', ' ',
> @unlinked_item_subfields));
> +                $marc->encoding("UTF-8");
> +                $item->more_subfields_xml($marc->as_xml("USMARC"));
> +                next;
> +            }
> +            $item->more_subfields_xml(undef);
> +        } else {
> +            my $v = $input->param("items.".$c);
> +            next unless defined $v;
> +            $item->$c($v);
> +        }
> 
> Is this the time to get rid of the MARC stuff for items completely?
> Do we really need more_subfields_xml or could we resolve otherwise?

+1, please file that bug!

-- 
You are receiving this mail because:
You are watching all bug changes.