[Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
This is looking so good! 

I'm sorry but I just have a couple more things. This is so so close.

In "div#external_login", the "a" element should be encapsulated within
"div#external_login_button". I think that might just be a typo in the current
patch.

I think that "external_login_button" should be "shibboleth_login_button" and
"external_login_icon" should be "shibboleth_login_icon" and
"external_login_name" should be "shibboleth_login_name".

My reasoning here is that we could add additional external login buttons for
different external auth providers. I have an OpenID Connect local extension
that I would add here, for instance. This would also be a good place for
authentication plugins to advertise. 

In fact, if you don't mind, I might just provide a little follow-up and see
what you think...

-- 
You are receiving this mail because:
You are watching all bug changes.