[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
You'd still get the increments via the adjust method.. it's the 'create' I'm
less enamoured by.

We have huge numbers of lines for the creation of an accountline that don't
really add any information.. at the moment only fines can be adjusted without
having a corresponding offsetting accountline.

Even if we don't agree to get rid of them entirely.. could we perhaps ratify
their codes?


i.e. I would say it's significantly clearer for all the 'create' actions in the
offsets to have the same type..

accountline.debit_type_code = OVERDUE + offset.type = CREATE
accountline.debit_type_code = ACCOUNT + offset.type = CREATE

etc...

as opposed to

accountline.debit_type_code = OVERDUE + offset.type = OVERDUE
accountline.debit_type_code = ACCOUNT + offest.type = ACCOUNT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.