[Koha-bugs] [Bug 27630] TestBuilder real number formatting is different to DBI(x)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27630

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Lari Taskula <lari.taskula at hypernova.fi> ---
Jonathan suggested using build_object() instead of build(). It works in most
cases.

build_object() already refreshes the object because it executes a search on the
given Koha-objects class, thus returning values in the same format that
Koha::Objets->search/find would have.

I found only two DBIx schema files that have decimal fields with higher number
of allowed decimal places than two, and no corresponding Koha::Object. These
are AqbudgetsPlanning and PendingOfflineOperation. So there are very few cases
where build_object would not be sufficient to solve the decimal formatting
issues.

Additionally, as pointed out by Jonathan, we should be first study the side
effects this patch would have on the total execution time of Koha test suite.
I'm gonna mark this as Failed QA until we have those numbers.

-- 
You are receiving this mail because:
You are watching all bug changes.