[Koha-bugs] [Bug 27707] Renewing doesn't work when renewal notices are enabled
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Feb 16 10:46:47 CET 2021
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27707
Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #116909|0 |1
is obsolete| |
--- Comment #5 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 116910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116910&action=edit
Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set
Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query
in C4::Circulation::SendCirculationAlert is not correctly handled.
>From the MySQL doc that is copied few lines before, "LOCK TABLE will
commit any transactions", but here we don't have a savepoint and the
release for a non-existent savepoint will throw a DBI exception.
This patch removes the unecessary transaction and prevent the following
error when a renewal is done:
> DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm line 3590
Test plan:
1. Enable RenewalSendNotice
2. Add some email address to patron and select the email box from the message
preference "Item checkout and renewal" in order to receive renewal emails.
3. Check 1 item out to a patron
4. Renew it
Signed-off-by: Andrew Nugged <nugged at gmail.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list