[Koha-bugs] [Bug 27718] New: Holds to Pull list doesn't respect holdallowed circulation rule anymore

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718

            Bug ID: 27718
           Summary: Holds to Pull list doesn't respect holdallowed
                    circulation rule anymore
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nugged at gmail.com
        Depends on: 24488

After bug 24488 was merged Holds to Pull list
(/cgi-bin/koha/circ/pendingreserves.pl) doesn't respect anymore the
'holdallowed' circulation rules (we bisected it to this change). If we look at
the patch "Bug 24488: Show correct first patron details on Holds to pull"
(2285c2d6575) then we can notice that previously the items that were shown in
the list must had holdallowed != 0:

> LEFT JOIN circulation_rules ON ( items.itype=circulation_rules.itemtype AND rule_name = 'holdallowed' AND circulation_rules.branchcode IS NULL AND circulation_rules.categorycode IS NULL )

And

> AND ( circulation_rules.rule_value IS NULL OR circulation_rules.rule_value != 0 )

Now it seems like similar circ rule check is missing in the newly rewritten
Holds To Pull implementation. I will continue investigating deeper this issue
and update on progress.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
[Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.