From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 03:00:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 01:00:34 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #22 from David Cook ---
(In reply to Mark Hofstetter from comment #21)
>
> OR, my suggestion (semi pseudo code, I hop my intentions are clear)
>
I'm sorry but I didn't really follow that. But that might just be me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 04:34:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 02:34:15 +0000
Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not
yet listed in the about page.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495
--- Comment #16 from wainuiwitikapark at catalyst.net.nz ---
Backported to 19.11.x for 19.11.20
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 04:34:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 02:34:49 +0000
Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not
yet listed in the about page.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495
wainuiwitikapark at catalyst.net.nz changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.05.00,20.11.07,20.05.14 |21.05.00,20.11.07,20.05.14,
released in| |19.11.20
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 04:35:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 02:35:06 +0000
Subject: [Koha-bugs] [Bug 27495] The "Accessibility advocate" role is not
yet listed in the about page.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27495
wainuiwitikapark at catalyst.net.nz changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to oldoldstable |Pushed to oldoldoldstable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 08:30:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 06:30:24 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122507|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 122511
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122511&action=edit
Bug 28640: Unit tests for edi_order relation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 08:30:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 06:30:28 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122508|0 |1
is obsolete| |
--- Comment #6 from Martin Renvoize ---
Created attachment 122512
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122512&action=edit
Bug 28640: Expose EDI Status on basket details page
This patch adds the edi_order relationship method to
Koha::Acquisition::Basket to return the most recently attached
edi_message of type 'ORDER' for the basket.
NOTE: EDI currently returns raw DBIC results. I have opted to maintain
that approach here, but would like to work on upgradeing the
Koha::EDIFACT::Order class to be a subclass of Koha::Object at a later
date.
We then use this new relationship in acqui/basket to display the EDI
status for such baskets.
Test plan
1/ Setup a vendor with EDI Ordering enabled
2/ Add a new basket for the vendor.
3/ Note the new 'EDI status' field displays and reads 'Not ordered'
4/ Close the basker
5/ The 'EDI status' should continue to display 'Not ordered'
6/ Re-open the basket
7/ Close the basket via 'Create EDIFACT order'
8/ Navigate back to the now closed basket
9/ Note the 'EDI status' field now displays 'Pending' and the transfer
date.
10/ Progress the EDI order by running the edi_cron.pl script
11/ The EDI status field should now reflect that the message has been
sent.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 08:32:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 06:32:41 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #7 from Martin Renvoize ---
(In reply to Kyle M Hall from comment #4)
> Instead of just printing the value of edi_order.status in the template,
> please use and IF/ELSIF/ELSE block for all the possible statuses, so they
> may be translated.
Thanks for testing.. I've now amended the patch with a SWITCH style block as
requested.. I can envisage that moving into an include at a later date should
we want to include these status details in other area's.. but I thought I'd
leave that to another bug ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 10:19:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 08:19:53 +0000
Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons
payments/fines, simplified
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507
--- Comment #13 from Martin Renvoize ---
(In reply to Henri-Damien LAURENT from comment #12)
> Your solution seems to fit your environment. But let me state that some
> countries, like France have different signs for thousand delimiter and
> decimal delimiter.
>
> And I can see no real support for those "oddities" in the proposed js code.
> Worse, there seems to be no way to parametrize those 'locales' for currency.
>
> For instance, if someone copy pastes 123,13 €, it would be converted into
> 12,313.00 which is counter intuitive for usual french folks.
>
> To that aim, decimal_fill (hardcoded at the moment in Koha::Number::Price
> could be parametrized).
> And the way the proposed patch fixed that would take a system variable for
> number format into account.
> So it has my favour.
>
> Can it be discussed some time ?
More than happy to discuss.. I'm a little confused by your comment though.. are
you replying to the code attached here or the algorithm I propose in comment
10. Unfortunately, I've not had a moment to actually try to realise the code
to match that algorithm yet.
> Moreover, it seems that there is no way to add more decimals... (which
> should be enable for some rates, if there is a fine per page printed for
> instance, it could be 0.013 cents per page)
I can see this being an issue with my algorithm, though I don't expect the
algorithm to be applied to all inputs.. only those that may be pasted into..
for this case I would expect a typed amount and we should allow parts of a
cent. (admittedly, I've never actually come across a scheme like this.. koha
doesn't support a 'fine per page' rule anywhere currently unless I'm mistaken?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 12:42:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 10:42:03 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122511|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize ---
Created attachment 122513
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122513&action=edit
Bug 28640: Unit tests for edi_order relation
Test plan
1/ Run t/db_dependent/Koha/Acquisition/Basket.t
Signed-off-by: Benjamin Veasey
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 12:42:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 10:42:07 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122512|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize ---
Created attachment 122514
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122514&action=edit
Bug 28640: Expose EDI Status on basket details page
This patch adds the edi_order relationship method to
Koha::Acquisition::Basket to return the most recently attached
edi_message of type 'ORDER' for the basket.
NOTE: EDI currently returns raw DBIC results. I have opted to maintain
that approach here, but would like to work on upgradeing the
Koha::EDIFACT::Order class to be a subclass of Koha::Object at a later
date.
We then use this new relationship in acqui/basket to display the EDI
status for such baskets.
Test plan
1/ Setup a vendor with EDI Ordering enabled
2/ Add a new basket for the vendor.
3/ Note the new 'EDI status' field displays and reads 'Not ordered'
4/ Close the basker
5/ The 'EDI status' should continue to display 'Not ordered'
6/ Re-open the basket
7/ Close the basket via 'Create EDIFACT order'
8/ Navigate back to the now closed basket
9/ Note the 'EDI status' field now displays 'Pending' and the transfer
date.
10/ Progress the EDI order by running the edi_cron.pl script
11/ The EDI status field should now reflect that the message has been
sent.
Signed-off-by: Benjamin Veasey
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 12:58:28 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 10:58:28 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #10 from Martin Renvoize ---
Tested by a Loughborough University and signed off.. patches attached.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 13:47:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 11:47:26 +0000
Subject: [Koha-bugs] [Bug 28574] Double id in source code member.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28574
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #2 from Owen Leonard ---
The duplicate ID is not in the HTML of the template. The duplicate is created
by the "hcSticky" JavaScript library in order to create the "floating" toolbar.
This will be true on any page that uses the same feature.
I'm going to mark this as "WONTFIX" because I don't believe this is going to
cause practical problems. If someone finds otherwise please reopen this report.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 13:48:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 11:48:25 +0000
Subject: [Koha-bugs] [Bug 28592] ISE after paying through opac payment plugin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28592
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |master
Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 14:47:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 12:47:24 +0000
Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790
--- Comment #8 from Julian Maurice ---
(In reply to Martin Renvoize from comment #7)
> How mature is the TOML support in perl... I note David looked
> at the TOML module (which is pure perl) and hasn't been updated since 2016..
> does that mean it's perfect or it's just not maintained? There's also a
> recent TOML::XS module on cpan.. but will this get packaged and is it likely
> to be around for a while and maintained.
This looks problematic :/
Maybe it's safer to stick with YAML for now.
> Either way.. I think the splitting out of Zebra config from the config file
> is a great first step.
+1
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 14:52:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 12:52:23 +0000
Subject: [Koha-bugs] [Bug 27182] Add ability to rename a MARC modification
template
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
--- Comment #1 from Andrew Fuerste-Henry ---
+1, this is a stilly functionality to leave out.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 15:11:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 13:11:04 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #19 from Agustín Moyano ---
(In reply to Katrin Fischer from comment #18)
> > Given how Koha now operates, I think we could well do without the fallback
> > for now. If you did not define the disclaimer in a language that you do
> > offer, you dont have a disclaimer.
> > As soon as a solution for GetNewsToDisplay is found, it will resolve this
> > case too..
>
> +1
Ok, seems I overdid here.. I'll try to keep it simple then.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 15:13:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 13:13:21 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 15:13:24 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 13:13:24 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122513|0 |1
is obsolete| |
Attachment #122514|0 |1
is obsolete| |
--- Comment #11 from Kyle M Hall ---
Created attachment 122515
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122515&action=edit
Bug 28640: Unit tests for edi_order relation
Test plan
1/ Run t/db_dependent/Koha/Acquisition/Basket.t
Signed-off-by: Benjamin Veasey
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 15:13:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 13:13:35 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
--- Comment #12 from Kyle M Hall ---
Created attachment 122516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122516&action=edit
Bug 28640: Expose EDI Status on basket details page
This patch adds the edi_order relationship method to
Koha::Acquisition::Basket to return the most recently attached
edi_message of type 'ORDER' for the basket.
NOTE: EDI currently returns raw DBIC results. I have opted to maintain
that approach here, but would like to work on upgradeing the
Koha::EDIFACT::Order class to be a subclass of Koha::Object at a later
date.
We then use this new relationship in acqui/basket to display the EDI
status for such baskets.
Test plan
1/ Setup a vendor with EDI Ordering enabled
2/ Add a new basket for the vendor.
3/ Note the new 'EDI status' field displays and reads 'Not ordered'
4/ Close the basker
5/ The 'EDI status' should continue to display 'Not ordered'
6/ Re-open the basket
7/ Close the basket via 'Create EDIFACT order'
8/ Navigate back to the now closed basket
9/ Note the 'EDI status' field now displays 'Pending' and the transfer
date.
10/ Progress the EDI order by running the edi_cron.pl script
11/ The EDI status field should now reflect that the message has been
sent.
Signed-off-by: Benjamin Veasey
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 15:25:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 13:25:43 +0000
Subject: [Koha-bugs] [Bug 28640] Add EDI order status to basket details
display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28640
--- Comment #13 from Kyle M Hall ---
Created attachment 122517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122517&action=edit
Bug 28640: (QA follow-up) Prevent unit tests from failing
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:08:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:08:44 +0000
Subject: [Koha-bugs] [Bug 28644] New: Can't call method "borrowernumber" on
an undefined value at C4/Reserves.pm line 607
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Bug ID: 28644
Summary: Can't call method "borrowernumber" on an undefined
value at C4/Reserves.pm line 607
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Got this one under 19.11 on line 521
Looks like someone tried to cancel an already cancelled hold from the opac (in
the user menu).
Trivial fix.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:09:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:09:01 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Severity|enhancement |trivial
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:09:08 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:09:08 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:18:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:18:52 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:18:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:18:55 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
--- Comment #1 from Marcel de Rooy ---
Created attachment 122518
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122518&action=edit
Bug 28644: Fix calling borrowernumber on undefined value
If the hold is not found (e.g. already cancelled), we should
return earlier without crashing:
Can't call method "borrowernumber" on an undefined value at
/usr/share/koha/C4/Reserves.pm line 521
(Note: line number from 19.11)
Test plan:
Run t/db_dependent/Reserves.t
Add a hold, go to user menu with holds in OPAC.
At the same time, cancel this hold from staff.
Now click the Cancel in OPAC.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:19:21 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:19:21 +0000
Subject: [Koha-bugs] [Bug 28644] Can't call method "borrowernumber" on an
undefined value at C4/Reserves.pm line 607
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28644
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #2 from Marcel de Rooy ---
Self signoff; too trivial to wait for.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:24:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:24:10 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #23 from Kyle M Hall ---
(In reply to Mark Hofstetter from comment #21)
> As stated before I consider the plugin system to explicit ie you have to
> "tell" every function/method that there may be a plugin.
>
> For example something I am currently working on:
>
> Problem: Customer wants to change how patron cardnumbers are autogenerated,
> (a prefix and a fixed padded length)
>
> One could make a plugin for Koha::Patron::fixup_cardnumber
>
> OR, my suggestion (semi pseudo code, I hop my intentions are clear)
>
> extend the base class(es) in this case
>
> Koha::Object->_new_from_dbic();
>
> if () {
> require KohaObjectHooks; # whatever
> }
>
>
> KohaObjectHooks
>
> use Hook::LexWrap;
> wrap 'Koha::Patron::fixup_cardnumber', post =>
> sub { my ( $self ) = @_;
> $self->cardnumber( sprintf("LB%09d", $self->cardnumber));
> };
>
>
>
> Hook::LexWrap hat pre/post a around hook may be implemented easily
>
> I know this a major change, but solves a least some problems
That's interesting. I'd love to see a proof of concept!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 16:44:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 14:44:22 +0000
Subject: [Koha-bugs] [Bug 28182] Elastic search exact authorities search
includes punctuation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28182
Heather changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |heather_hernandez at nps.gov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Jul 1 17:36:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Jul 2021 15:36:03 +0000
Subject: [Koha-bugs] [Bug 28645] New: write off fine on selected items does
not pay against those lines
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28645
Bug ID: 28645
Summary: write off fine on selected items does not pay against
those lines
Change sponsored?: ---
Product: Koha
Version: 19.11
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Fines and fees
Assignee: koha-bugs at lists.koha-community.org
Reporter: bernard.scaife at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
Selecting outstanding fines which do not happen to be the earliest in the
accountlines table for the borrower will result in the earliest fines being
written off instead of the ones selected.
1. In a list of 4 fines for a borrower, select tick box on one which was not
the first to be accrued.
2. Click the write off button at the bottom of the screen.
3. Note the payment is shown against the earliest accrued item instead.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 02:19:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 00:19:31 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 02:19:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 00:19:36 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122134|0 |1
is obsolete| |
--- Comment #20 from Agustín Moyano ---
Created attachment 122519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122519&action=edit
Bug 27948: Add disclaimer to article request
If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear
before an article request can be made
To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText news
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 02:19:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 00:19:40 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #21 from Agustín Moyano ---
Created attachment 122520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122520&action=edit
Bug 27948: (follow-up) Use Koha.news and PROCESS koha_news_block to bring
disclaimer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 02:29:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 00:29:20 +0000
Subject: [Koha-bugs] [Bug 28646] New: when I'm on the circulation screen and
I want to go back to home nor return
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28646
Bug ID: 28646
Summary: when I'm on the circulation screen and I want to go
back to home nor return
Change sponsored?: ---
Product: Koha
Version: 21.05
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: About
Assignee: koha-bugs at lists.koha-community.org
Reporter: miguelunodos2012 at gmail.com
QA Contact: testopia at bugs.koha-community.org
Created attachment 122521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122521&action=edit
when I'm on the circulation screen and I want to go back to home
when I'm on the circulation screen and I want to go back to home, it doesn't
come back,
Thanks for the support
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 03:05:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 01:05:32 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #24 from David Cook ---
I think I understand a little better now, although I still don't understand the
logic flow. You'd have to load the plugin to override the original code, but
your example doesn't say when that would happen. Unless you're preloading
modules at startup time (which will only work with Plack and could mean large
worker processes), then you're going to have to load at script load time, but
then you'll probably want to be targeting particular plugins for particular
situations, and then I'm not sure that you're actually gaining any advantage
over the current way of doing things?
Hook::LexWrap is also black magic. Perl lets a person do all kinds of wild
things, but it reminds me of Jurassic Park: "Your scientists were so
preoccupied with whether or not they could, they didn't stop to think if they
should."
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 05:05:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 03:05:26 +0000
Subject: [Koha-bugs] [Bug 28647] New: administration_tasks.t is failing
randomly
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28647
Bug ID: 28647
Summary: administration_tasks.t is failing randomly
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: victor at tuxayo.net
QA Contact: testopia at bugs.koha-community.org
Koha_Master #1697
koha_1 | /usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1340 in
(eval)
koha_1 | /kohadevbox/koha/t/lib/Selenium.pm:165 in
Selenium::Remote::Driver::find_element
koha_1 | t/db_dependent/selenium/administration_tasks.t:188 in
t::lib::Selenium::click
koha_1 |
selenium_1 | 1624989981543 Marionette INFO Stopped listening on
port 43585
selenium_1 | 18:06:22.136 INFO [ActiveSessions$1.onStop] - Removing session
ee327494-5e3c-4809-aa8c-51d0c0df60b2
(org.openqa.selenium.firefox.GeckoDriverService)
koha_1 | Error while executing command: no such element: Unable to locate
element: //div[@id="container-main"]//a[contains(@href,
"/admin/admin-home.pl")] at
/usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm line 411.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 05:10:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 03:10:56 +0000
Subject: [Koha-bugs] [Bug 28647] administration_tasks.t is failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28647
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
Status|NEW |ASSIGNED
Assignee|chris at bigballofwax.co.nz |victor at tuxayo.net
--- Comment #1 from Victor Grousset/tuxayo ---
I can reproduce. I'm trying stuff like adding finds before so it waits for an
element to be here before continuing.
But haven't found yet something that actually works when retrying a lot of
times.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 05:17:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 03:17:00 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 05:17:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 03:17:05 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Agustín Moyano changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120147|0 |1
is obsolete| |
--- Comment #13 from Agustín Moyano ---
Created attachment 122522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122522&action=edit
Bug 27946: Add article request fee feature
This patch adds the ability to charge a fee for article scan requests.
To test:
1. apply patches
2. updatedatabase
3. restart_all
4. enable ArticleRequest in preferences
5. grab a patron category and set a fee for article requests
6. grab a patron of that category (patron a) and another fron different
category (patron b)
7. place an article request for both patrons
SUCCESS => only for patron a, a warning is displayed saying a fee will be
charged
8. check the account for both patrons
SUCCESS => only for patron a there is a debit of type ARTICLE_REQUEST
9. cancel the article request for patron a
SUCCESS => the debit for patron a gets canceled
10. repeat step 7 only for patron a
11. change article request fee for the patron a's category
12. repeat step 10
13. check account for patron a
SUCCESS => there are 2 debits with different amount of typ ARTICLE_REQUEST
14. cancel only one article request
SUCCESS => only the corresponding debit gets canceled
15. prove t/db_dependent/ArticleRequests.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 05:19:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 03:19:22 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #14 from Agustín Moyano ---
(In reply to Marcel de Rooy from comment #12)
> Some of these 5 points justify a status change here now.
Hi Marcel, I addressed points 1 to 4. The 5th, even though I agree there should
be a limit, I believe is out of scope, and should be done in a different bug.
Cheers.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 06:37:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 04:37:31 +0000
Subject: [Koha-bugs] [Bug 28648] New: Add a counter variable to marc
modification template field value
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28648
Bug ID: 28648
Summary: Add a counter variable to marc modification template
field value
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at koha-suomi.fi
QA Contact: testopia at bugs.koha-community.org
Marc modification templates currently support two placeholders in the field
value: __CURRENTDATE__ and __BRANCHCODE__. It would be useful (for eg.
renumbering or adding barcodes) to have a __COUNTER__ (which would count from 1
up to how many records are being modified in the batch)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:22:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:22:22 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:22:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:22:26 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122519|0 |1
is obsolete| |
--- Comment #22 from Marcel de Rooy ---
Created attachment 122523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122523&action=edit
Bug 27948: Add disclaimer to article request
If ArticleRequestsDisclaimerText news is set, a disclaimer text will appear
before an article request can be made
To test:
1. apply patches
2. enable ArticleRequest syspref
3. in OPAC place an article request for a patron
CHECK => No disclaimer text should appear before placing article request
4. add a text in ArticleRequestsDisclaimerText news
5. repeat step 3
SUCCESS => A disclaimer text is shown before you can place an article request
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:22:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:22:30 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122520|0 |1
is obsolete| |
--- Comment #23 from Marcel de Rooy ---
Created attachment 122524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122524&action=edit
Bug 27948: (follow-up) Use Koha.news and PROCESS koha_news_block to bring
disclaimer
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:22:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:22:34 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #24 from Marcel de Rooy ---
Created attachment 122525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122525&action=edit
Bug 27948: (QA follow-up) Remove unused $disclaimer code
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:35:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:35:29 +0000
Subject: [Koha-bugs] [Bug 28649] New: Add cache to GetAuthorisedValueDesc
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28649
Bug ID: 28649
Summary: Add cache to GetAuthorisedValueDesc
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: fridolin.somers at biblibre.com
QA Contact: testopia at bugs.koha-community.org
C4::Biblio::GetAuthorisedValueDesc() is used in many places.
In C4::XSLT::transformMARCXML4XSLT() for example it will convert all subfields
defined with an authorised value category.
For better performance, add cache to this function.
It will improve a lot when there are a lot of items with same value in branch,
location, ccode, ...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 08:52:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 06:52:42 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #25 from Marcel de Rooy ---
Actually, seeing a minor bug:
+[% SET disclaimer = KohaNews.get( location => "ArticleRequestsDisclaimerText",
lang => lang, library => branchcode ) %]
Just as I did, you expected branchcode here already filled just like lang is.
But unfortunately branchcode is empty.
Which results in getting the All branches disclaimer only.
I dont consider this as a blocker here, and I suspect that a few other calls of
KohaNews.get suffer from the same assumption. So we should probably fill
branchcode in Auth.pm like lang in Templates.
Opening a new report for this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:00:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:00:39 +0000
Subject: [Koha-bugs] [Bug 28650] New: Assumed branchcode variable appears to
be empty
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650
Bug ID: 28650
Summary: Assumed branchcode variable appears to be empty
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Found on bug 27948, but it occurs more often.
We expect the variable branchcode in the template just like e.g. the lang
variable. And we use it in a call to KohaNews.get.
Example from opac-suggestions template:
[% SET opacsuggestion = KohaNews.get( location => "OpacSuggestioninstructions",
lang => lang, library => branchcode ) %]
But unfortunately we do not have a general branchcode variable.
So what we get is the All branches output, not the branch one.
Should we fill branchcode in Auth.pm? Or call Branches.GetLoggedInBranchcode in
the template?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:01:07 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:01:07 +0000
Subject: [Koha-bugs] [Bug 28650] Assumed branchcode variable appears to be
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650
--- Comment #1 from Marcel de Rooy ---
Some spots to consider:
git grep "KohaNews.get"
Koha/Template/Plugin/KohaNews.pm:[% KohaNews.get() %]
Koha/Template/Plugin/KohaNews.pm:the following TT code: [% KohaNews.get() %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sci.inc:[% SET OpacHeader =
KohaNews.get( location => "opacheader", lang => lang, library => branchcode,
blocktitle => 0 ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc:[% SET OpacHeader =
KohaNews.get( location => "opacheader", lang => lang, library => branchcode,
blocktitle => 0 ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:[% SET OpacHeader =
KohaNews.get( location => "opacheader", lang => lang, library => branchcode,
blocktitle => 0 ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:[% SET OpacCustomSearch
= KohaNews.get( location => "OpacCustomSearch", lang => lang, library =>
branchcode, blocktitle => 0 ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc:[% SET
OpacLoginInstructions = KohaNews.get( location => "OpacLoginInstructions", lang
=> lang, library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% SET opaccredits =
KohaNews.get( location => "opaccredits", lang => lang, library => branchcode )
%]
koha-tmpl/opac-tmpl/bootstrap/en/modules/maintenance.tt:[% SET OpacHeader =
KohaNews.get( location => "opacheader", lang => lang, library => branchcode,
blocktitle => 0 ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt:[% SET
OpacLoginInstructions = KohaNews.get( location => "OpacLoginInstructions", lang
=> lang, library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt:[% SET OpacNavRight =
KohaNews.get( location => "OpacNavRight", lang => lang, library => branchcode )
%]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt:[% SET OpacMainUserBlock
= KohaNews.get( location => "OpacMainUserBlock", lang => lang, library =>
branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt:[% SET
OpacLoginInstructions = KohaNews.get( location => "OpacLoginInstructions", lang
=> lang, library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt:[%
SET OpacNavRight = KohaNews.get( location => "OpacNavRight", lang => news_lang,
library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt:[% SET
disclaimer = KohaNews.get( location => "ArticleRequestsDisclaimerText", lang =>
lang, library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt:[% SET
opacsuggestion = KohaNews.get( location => "OpacSuggestioninstructions", lang
=> lang, library => branchcode ) %]
koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt:[% SET OpacHeader =
KohaNews.get( location => "opacheader", lang => lang, library => branchcode,
blocktitle => 0 ) %]
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:07:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:07:25 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #26 from Marcel de Rooy ---
Created attachment 122526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122526&action=edit
Bug 27948: (QA follow-up) Correct empty branchcode
Let us just fix it here and leave the rest to bug 28650.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:08:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:08:02 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=28650
--- Comment #27 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #25)
> I dont consider this as a blocker here, and I suspect that a few other calls
> of KohaNews.get suffer from the same assumption. So we should probably fill
> branchcode in Auth.pm like lang in Templates.
> Opening a new report for this.
See bug 28650
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:08:02 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:08:02 +0000
Subject: [Koha-bugs] [Bug 28650] Assumed branchcode variable appears to be
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=27948
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:09:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:09:05 +0000
Subject: [Koha-bugs] [Bug 28650] Assumed branchcode variable appears to be
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650
--- Comment #2 from Marcel de Rooy ---
Decided to fix the call in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt (bug 27948) by
calling GetBranches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:14:34 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:14:34 +0000
Subject: [Koha-bugs] [Bug 27948] Add disclaimer text to article requests
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27948
--- Comment #28 from Marcel de Rooy ---
Agustin: When you have an All branches and a branch specific one, they are both
listed directly following each other. An OPAC user would not know that they
actually are two separate messages. Staff should be aware of that in order to
prevent misunderstandings.
No blocker.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:16:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:16:54 +0000
Subject: [Koha-bugs] [Bug 28651] New: Automatic renewal don't send out
notice if status "On hold"
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28651
Bug ID: 28651
Summary: Automatic renewal don't send out notice if status "On
hold"
Change sponsored?: ---
Product: Koha
Version: 20.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: somesecretemail at mailinator.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
It seems like the cron job automatic_renewals does't create notices if the
biblio is on hold by another patron.
These are the steps to reproduce the bug:
1. Set date_due to current date on an issue
2. Place a hold on the biblio related to the issue
3. Run cron job automatic_renewals.pl --send-notices -c -v
4. Note feedback in terminal "Issue id: xx for borrower: xx and item: xx will
not be renewed. (on_reserve)"
5. Click "Notices" on the patron which is related to the issue.
Result: List lacks notice informing patron about the issue not been renewed.
Expected result: Notices list containing a notice about the issue not been
renewed.
I tried removing the hold och rerunning the auto renew cron job. Then the issue
is renewed and the notice is created correctly, so it's not a general bug in
the automatic renewals functionality.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:17:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:17:32 +0000
Subject: [Koha-bugs] [Bug 28651] Automatic renewal don't send out notice if
status "On hold"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28651
Stefan Norinder changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
Priority|P5 - low |P3
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:26:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:26:01 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #25 from Mark Hofstetter ---
Created attachment 122527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122527&action=edit
THIS IS NOT A BUGFIX JUST A PROVE OF CONCEPT
just run
t/patron-object-hook.t
and see what happens
to make this work properly something like
https://metacpan.org/pod/Module::Pluggable
should be used to find & include the plugins
Signed-off-by: Mark Hofstetter
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:29:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:29:38 +0000
Subject: [Koha-bugs] [Bug 28652] New: Enforce maximum on article request
charges
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28652
Bug ID: 28652
Summary: Enforce maximum on article request charges
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Just like we enforce a maximum charge for fines, rentals etc. we should not
allow article request charges to pile up unlimited.
See also bug 27946. Compare: maxoutstanding, OPACFineNoRenewals, MaxFine,
noissuescharge, RentalsInNoissuesCharge.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:29:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:29:49 +0000
Subject: [Koha-bugs] [Bug 28652] Enforce maximum on article request charges
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28652
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |27946
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
[Bug 27946] Add a charge per article request to patron categories configuration
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:29:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:29:49 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |28652
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28652
[Bug 28652] Enforce maximum on article request charges
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:30:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:30:42 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #15 from Marcel de Rooy ---
(In reply to Agustín Moyano from comment #14)
> Hi Marcel, I addressed points 1 to 4.
Great! Thx
> The 5th, even though I agree there
> should be a limit, I believe is out of scope, and should be done in a
> different bug.
I could at least open a new report for that one. Bug 28652.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:31:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:31:38 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
Mark Hofstetter changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |In Discussion
--- Comment #26 from Mark Hofstetter ---
"
Hook::LexWrap is also black magic. Perl lets a person do all kinds of wild
things, but it reminds me of Jurassic Park: "Your scientists were so
preoccupied with whether or not they could, they didn't stop to think if they
should."
"
As I've got a background in biochemistry I am huge fan of tinkering with old
(genetic) code
Hook::LexWrap is widely used (and written by Damien), so it's not too bad
please have a look at it, if the idea makes sense for you I'll make it
pluggable (probably with something like Module::Pluggable)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:49:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:49:31 +0000
Subject: [Koha-bugs] [Bug 28653] New: Sorting loans by due date doesn't work
after renewing
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653
Bug ID: 28653
Summary: Sorting loans by due date doesn't work after renewing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: emmi.takkinen at koha-suomi.fi
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
On patrons check out or details page, after renewing loans they don't sort
correctly when clicking on "Date due" tab. Page has to be reloaded so that
sorting works.
To test:
1. Add 3 loans for patron.
2. Change date dues so you they are e.g. 07/01, 07/02, 07/04
3. Make sure you have renewal period set e.g. 5 days and check your
RenewalPeriodBase syspref (I use current date there)
4. Renew loan with date due on 07/01, it should now be 07/07
3. Sort loans by date due
=> Note that order from top to bottom is 07/04->07/02->07/07 or
07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assumme.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:52:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:52:06 +0000
Subject: [Koha-bugs] [Bug 28649] Add cache to GetAuthorisedValueDesc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28649
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #1 from Fridolin Somers ---
Forget about it, found Bug 28371
*** This bug has been marked as a duplicate of bug 28371 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 09:52:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 07:52:06 +0000
Subject: [Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #8 from Fridolin Somers ---
*** Bug 28649 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:09:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:09:30 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #24 from Martin Renvoize ---
Created attachment 122528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122528&action=edit
Bug 15156: [ALT] Add filter_by_amount_owed that's chainable
This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.
The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:12:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:12:12 +0000
Subject: [Koha-bugs] [Bug 28647] administration_tasks.t is failing randomly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28647
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:12:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:12:55 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #25 from Martin Renvoize ---
I've love to get peoples thoughts on my alternative implimentation.. I've split
out the relevant code I wrote for bug 11983 so we don't have to rely on that
entire bug working it's way through.
It still needs a couple more tests adding to prove the branchcode/debit_type
refinement.
I think it's really beneficial to be able to chain this.. I can see a really
clear use case for needing to filter to those patrons visible to the user prior
to using this function...?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:21:25 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:21:25 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120144|0 |1
is obsolete| |
Attachment #120146|0 |1
is obsolete| |
--- Comment #16 from Marcel de Rooy ---
Created attachment 122529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122529&action=edit
Bug 27946: Add tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:21:29 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:21:29 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #120145|0 |1
is obsolete| |
--- Comment #17 from Marcel de Rooy ---
Created attachment 122530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122530&action=edit
Bug 27946: Add article_request_fee to categories table and ARTICLE_REQUEST
account debit type
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:21:32 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:21:32 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122522|0 |1
is obsolete| |
--- Comment #18 from Marcel de Rooy ---
Created attachment 122531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122531&action=edit
Bug 27946: Add article request fee feature
This patch adds the ability to charge a fee for article scan requests.
To test:
1. apply patches
2. updatedatabase
3. restart_all
4. enable ArticleRequest in preferences
5. grab a patron category and set a fee for article requests
6. grab a patron of that category (patron a) and another fron different
category (patron b)
7. place an article request for both patrons
SUCCESS => only for patron a, a warning is displayed saying a fee will be
charged
8. check the account for both patrons
SUCCESS => only for patron a there is a debit of type ARTICLE_REQUEST
9. cancel the article request for patron a
SUCCESS => the debit for patron a gets canceled
10. repeat step 7 only for patron a
11. change article request fee for the patron a's category
12. repeat step 10
13. check account for patron a
SUCCESS => there are 2 debits with different amount of typ ARTICLE_REQUEST
14. cancel only one article request
SUCCESS => only the corresponding debit gets canceled
15. prove t/db_dependent/ArticleRequests.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:21:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:21:36 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #19 from Marcel de Rooy ---
Created attachment 122532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122532&action=edit
Bug 27946: [DO NOT PUSH] Update DBIx schema
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:21:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:21:58 +0000
Subject: [Koha-bugs] [Bug 28651] Automatic renewal don't send out notice if
status "On hold"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28651
--- Comment #1 from Stefan Norinder ---
After I simplified the template the notice was created, so probably not a bug
after all.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:22:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:22:51 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:23:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:23:13 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:25:52 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:25:52 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #20 from Marcel de Rooy ---
Martin: Are you happy with the way this patch deals with the cancellation as to
the accounts handling? Testing amountoutstanding and choosing line->cancel or
account->add_credit? Balance wise, it works fine.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:33:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:33:47 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |BLOCKED
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--- Comment #30 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:34:19 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:34:19 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #31 from Marcel de Rooy ---
FAIL opac/opac-shelves.pl
FAIL critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:34:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:34:36 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #32 from Marcel de Rooy ---
FAIL t/db_dependent/Virtualshelves.t
OK critic
FAIL forbidden patterns
forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 384)
forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 389)
forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 394)
forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 399)
forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 404)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:44:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:44:54 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
items where location is null
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472
Andreas Roussos changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr
|ity.org |
Status|NEW |ASSIGNED
CC| |a.roussos at dataly.gr
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:49:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:49:27 +0000
Subject: [Koha-bugs] [Bug 28651] Automatic renewal don't send out notice if
status "On hold"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28651
--- Comment #2 from Stefan Norinder ---
No, now I have to withdraw my withdrawal. The initial behavior is back even
with the simplified template.
It would be interesting if someone else could look into this, because I
becoming increasingly confused.
Sorry for the fuss.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 10:56:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 08:56:56 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #33 from Marcel de Rooy ---
Anonymous OPAC user
Can't call method "userid" on an undefined value at
/usr/share/koha/Koha/Virtualshelf.pm line 253
Surely, I do not like that :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:08:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:08:22 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #34 from Marcel de Rooy ---
diff --git a/Koha/Schema/Result/Letter.pm b/Koha/Schema/Result/Letter.pm
index 613c4d9b27..b5627b9674 100644
--- a/Koha/Schema/Result/Letter.pm
+++ b/Koha/Schema/Result/Letter.pm
@@ -29,8 +29,6 @@ __PACKAGE__->table("letter");
is_auto_increment: 1
is_nullable: 0
-primary key identifier
-
=head2 module
data_type: 'varchar'
@@ -217,8 +215,8 @@ __PACKAGE__->belongs_to(
);
-# Created by DBIx::Class::Schema::Loader v0.07046 @ 2021-02-11 12:33:50
-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:qqdTVEicMu5rHppY5qsEuA
+# Created by DBIx::Class::Schema::Loader v0.07046 @ 2021-04-09 22:58:34
+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:2QkUwMWgZ9WfOk9Ngf7yFA
Dont ever do these things in a regular patch !
Please move such changes to separate patches.
In this case I wonder what you are doing..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:14:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:14:03 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #35 from Marcel de Rooy ---
Line 190
Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists )
Line 213
Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists
Wonder if we could have a crash here too?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:16:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:16:13 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #36 from Marcel de Rooy ---
@@ -267,4 +270,3 @@ sub _type {
return 'Virtualshelve';
}
-1;
Never never do this!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:18:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:18:03 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #37 from Marcel de Rooy ---
Virtualshelves
+ if ( Koha::Patrons->find( $borrowernumber
)->can_patron_change_staff_only_lists ) {
Could this crash?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:19:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:19:11 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #38 from Marcel de Rooy ---
+++ b/Koha/Virtualshelves.pm
+use C4::Auth;
+
Out of the blue? Why are you adding it ??
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:24:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:24:58 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:25:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:25:03 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #39 from Marcel de Rooy ---
Created attachment 122533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122533&action=edit
Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user
Seriously!
Can't call method "userid" on an undefined value at
/usr/share/koha/Koha/Virtualshelf.pm line 253
Trivial fix.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:27:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:27:03 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--- Comment #40 from Marcel de Rooy ---
Sorry but there is really too much to fix on this small patch set to get it
further now.
Including serious errors like removing a true value, adding DBIx changes in a
patch, using modules unrelated.
Please carefully adjust !
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 11:32:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 09:32:47 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #41 from Marcel de Rooy ---
And still forgot:
The Staff only permission has no actual effect while this list is strictly
private.
=> Should we not allow that change then ?
CHECK Handling 0 and NULL in column allow_change_from_staff
I saw in my table a NULL and a zero there. Probably existing/new rec.
This is a bit teasing: But I cannot add an item to a public list from another
staff member. But I can edit the list, change the 'Allow', add or delete items,
and undo Allow. Just noting.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 12:02:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 10:02:12 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122528|0 |1
is obsolete| |
--- Comment #26 from Martin Renvoize ---
Created attachment 122534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122534&action=edit
Bug 15156: [ALT] Add filter_by_amount_owed that's chainable
This patch acts as an alternative here. We pull out the code from bug
11983 and extend it to support filtering of debts by branchcode and
debit_type.
The advantage of this approach is that we can add the filter into the
middle of a search chain to filter down an pre-existing search.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 12:02:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 10:02:47 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #27 from Martin Renvoize ---
Tests added
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:03:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:03:57 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Signed Off
--- Comment #27 from Kyle M Hall ---
(In reply to Mark Hofstetter from comment #26)
> "
> Hook::LexWrap is also black magic. Perl lets a person do all kinds of wild
> things, but it reminds me of Jurassic Park: "Your scientists were so
> preoccupied with whether or not they could, they didn't stop to think if
> they should."
> "
>
> As I've got a background in biochemistry I am huge fan of tinkering with old
> (genetic) code
>
> Hook::LexWrap is widely used (and written by Damien), so it's not too bad
>
> please have a look at it, if the idea makes sense for you I'll make it
> pluggable (probably with something like Module::Pluggable)
Mark, this is not the right place to put your patch. Can you please open a new
b ug report and put it there? Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:04:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:04:10 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122527|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:06:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:06:30 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
--- Comment #28 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #27)
> (In reply to Mark Hofstetter from comment #26)
> > "
> > Hook::LexWrap is also black magic. Perl lets a person do all kinds of wild
> > things, but it reminds me of Jurassic Park: "Your scientists were so
> > preoccupied with whether or not they could, they didn't stop to think if
> > they should."
> > "
> >
> > As I've got a background in biochemistry I am huge fan of tinkering with old
> > (genetic) code
> >
> > Hook::LexWrap is widely used (and written by Damien), so it's not too bad
> >
> > please have a look at it, if the idea makes sense for you I'll make it
> > pluggable (probably with something like Module::Pluggable)
>
> Mark, this is not the right place to put your patch. Can you please open a
> new b ug report and put it there? Thanks!
And please add me on that bug! This idea is very interesting but definitely
warrants discussion on its own bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:13:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:13:48 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122033|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:13:59 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:13:59 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122034|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:14:12 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:14:12 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122533|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:14:54 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:14:54 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #42 from Alex Buckley ---
Created attachment 122535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122535&action=edit
Bug 26346: Database changes
- Adds allow_change_from_staff to virtualshelves table
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:14:56 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:14:56 +0000
Subject: [Koha-bugs] [Bug 28344] One should be able to issue refunds against
payments that have already been cashed up.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28344
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:15:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:15:18 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #43 from Alex Buckley ---
Created attachment 122536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122536&action=edit
Bug 26346: Updated schema file
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:15:40 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:15:40 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #44 from Alex Buckley ---
Created attachment 122537
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122537&action=edit
Bug 26346: Add option to make public lists editable by all staff
If a staff member has access to the staff client (either because
'catalogue' permission is enabled or they're a superlibrarian
then that user can add items (from OPAC or staff client) to a list
marked 'Staff only'
Test plan:
1. In the staff client go to: Lists > 'New list'. Notice under 'Allow changes
to contents
from' there are three options: Nobody, Owner only, Anyone seeing this
list
2. Apply first 3 patches and run updatedatabase.pl
cd installer/data/mysql
sudo koha-shell
./updatedatabase.pl
3. Restart memcached and plack
4. Create a public list and select the new 'Staff only' option under
'Allow changes to contents from'
5. Log out of the staff client and log back in as a different user with
the 'Staff access, allows viewing of catalogue in staff interface
(catalogue)' permission enabled.
6. Navigate to the Lists module, and click on the name of the list you
created in #5
7. Select 'Add items' and enter an item barcode and submit
8. Notice the item has been added to the list
9. Search the catalogue in the staff client. Confirm you can add to the
list you created in #5 from both the search result page and biblio
record detail page
10. Confirm you can remove items from the list in the OPAC and staff
client
11. Login to the OPAC as the same user as #5
12. Perform an OPAC search, Select 'Save to lists' under a biblio
record, choose the list from #4 in 'Select a list' and save
13. Confirm in the staff client that the record from #11 has been added to the
list
14. Logout of OPAC and login again as a user which does not have 'Staff
access, allows viewing of catalogue in staff interface (catalogue)' or
superlibrarian enabled
15. Do a OPAC search, hit 'Save to lists' and notice you cannot add the
record to the list from #4
16. Run Patron.t and Virtualshelves.t unit tests:
sudo koha-shell
prove t/db_dependent/Koha/Patron.t
prove t/db_dependent/Virtualshelves.t
17. Login to the staff client as the same user as #5
18. Create a new list in the staff client, select 'Category'='Private',
'Allow changes to contents from'='Staff only'
19. Notice 'The Staff only permission has no actual effect while this
list is strictly private' message hint is displayed
20. Change 'Category'='Public' and notice the hint is removed
21. Switch back to 'Category'='Private' and 'Allow changes to contents
from'='Anyone'
22. Notice the 'The Anyone permission has no actual effect while this
list is strictly private.' is displayed
23. Repeat steps 18-22 in the OPAC
24. Create a 'staff only' list in the OPAC and then login as a different
user with 'Staff access, allows viewing of catalogue in staff interface
(catalogue)' permission enabled. Confirm you are able to add items to
this new 'staff only' list.
25. Confirm that the 'Staff only' option is not available to
patrons with no special permissions when creating lists in the OPAC
Sponsored-by: Horowhenua District Council, New Zealand
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:16:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:16:06 +0000
Subject: [Koha-bugs] [Bug 21286] Advanced search for Corporate-name creates
Zebra errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21286
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
CC| |kyle at bywatersolutions.com
--- Comment #12 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:16:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:16:57 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #45 from Alex Buckley ---
Created attachment 122538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122538&action=edit
Bug 26346: Add edit_public_lists sub-permission enabling patrons to switch
'owner only' public lists (which they're not the owners of) to 'staff only'
lists
The first patch on bug 26346 only allowed owners of existing 'owner only'
public lists switch those lists to be 'Staff only'. This patch will allow other
patrons with the 'edit_public_lists' sub-permission to also make this change.
Test plan:
1. Apply the first 26346 patch and follow it's test plan
2. Apply this patch
3. Apply database changes:
cd installer/data/mysql
sudo koha-shell
./updatedatabase.pl
4. Restart memcached and plack
5. Login to the staff client. Create an 'owner only' public list
6. Create another patron record. Tick the following two permissions:
* "Staff access, allows viewing of catalogue in staff interface
(catalogue) Required for staff login." permission
* Lists > "Edit public lists (edit_public_lists)" sub-permission
7. Logout of the staff client, and login as the user from step #6
8. Navigate to the Lists module, click 'Edit' on the 'owner only' list
9. Confirm you can change the 'Allow changes to contents from:' option
to 'Staff only'
10. Confirm you can now add items to this 'staff only' list
11. Login to the OPAC as the patron from step #5
12. Create a 'owner only' public list
13. Logout of OPAC, and login as the patron from step #6
14. Navigate to public lists in the OPAC and edit the OPAC created
'owner only' public list from step #
15. Confirm you can change the 'Allow changes to contents from:" option
to 'Staff only'
16. Confirm you can now add items to this 'staff only' list
17. Run Virtualshelves.t unit test:
sudo koha-shell
prove t/db_dependent/Virtualshelves.t
Sponsored-by: Catalyst IT
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:17:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:17:26 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #46 from Alex Buckley ---
Created attachment 122539
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122539&action=edit
Bug 26364: (QA follow-up) Do not crash on anonymous OPAC user
Seriously!
Can't call method "userid" on an undefined value at
/usr/share/koha/Koha/Virtualshelf.pm line 253
Trivial fix.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:18:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:18:03 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
--- Comment #47 from Alex Buckley ---
Created attachment 122540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122540&action=edit
Bug 26346: (follow-up) Fixes in response to QA
Fixes for the following comments on bug report 26346:
1. Comment #31
2. Comment #32
3. Comment #35
4. Comment #36
5. Comment #37
6. Comment #38
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:20:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:20:16 +0000
Subject: [Koha-bugs] [Bug 28422] OPAC MARC detail view doesn't correctly
evaluate holdability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #7 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:34:48 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:34:48 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
items where location is null
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472
Andreas Roussos changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:34:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:34:51 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
items where location is null
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472
--- Comment #2 from Andreas Roussos ---
Created attachment 122541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122541&action=edit
Bug 28472: handle items with NULL shelving location
The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).
This patch, based on the comment made by Nick Clemens, fixes that.
Test plan (based on the original Bug Description by Andrew Fuerste-Henry):
1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to
CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:43:27 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:43:27 +0000
Subject: [Koha-bugs] [Bug 28511] Road types in OPAC should prefer OPAC
description if one exists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28511
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |kyle at bywatersolutions.com
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:52:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:52:38 +0000
Subject: [Koha-bugs] [Bug 28655] New: new ideas/proposal to enhance
pluggability
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655
Bug ID: 28655
Summary: new ideas/proposal to enhance pluggability
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Plugin architecture
Assignee: koha-bugs at lists.koha-community.org
Reporter: koha at trust-box.at
QA Contact: testopia at bugs.koha-community.org
see discussion to 28026
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:53:49 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:53:49 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #29 from Marcel de Rooy ---
# Subtest: call_recursive() tests
1..6
ok 1 - Got back one element
not ok 2 - Got expected response
# Failed test 'Got expected response'
# at t/db_dependent/Koha/Plugins/Plugins.t line 97.
# got: '1'
# expected: '4'
ok 3 - Got back one element
ok 4 - Got expected response
ok 5 - Got back one element
ok 6 - call_recursive should return the original arguments if plugins are
disabled
# Looks like you failed 1 test of 6.
not ok 6 - call_recursive() tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:54:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:54:55 +0000
Subject: [Koha-bugs] [Bug 28655] new ideas/proposal to enhance pluggability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655
--- Comment #1 from Mark Hofstetter ---
Created attachment 122542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122542&action=edit
see 28026
THIS IS NOT A BUGFIX JUST A PROVE OF CONCEPT
just run
t/patron-object-hook.t
and see what happens
to make this work properly something like
https://metacpan.org/pod/Module::Pluggable
should be used to find & include the plugins
Signed-off-by: Mark Hofstetter
https://bugs.koha-community.org/show_bug.cgi?id=28026
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:56:00 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:56:00 +0000
Subject: [Koha-bugs] [Bug 28655] new ideas/proposal to enhance pluggability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655
Mark Hofstetter changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:56:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:56:43 +0000
Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable
by library staff only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #48 from Alex Buckley ---
(In reply to Marcel de Rooy from comment #40 and comment #41)
Hi Marcel,
Thank you for QAing!
- Comments #31, #32, #35, #36, #37, #38 (which was an accident- apologies!)
should hopefully be addressed by the 'Bug 26346: (follow-up) Fixes in response
to QA' patch.
- Comment #34 should hopefully have been addressed by my splitting the database
change + DBIx change from the 'Bug 26346: Add option to make public lists
editable by all staff' patch out into two separate patches.
Note: The change to Letter.pm you noted in comment #34 was also incorrectly
committed and is not in the new 'Bug 26346: Updated schema file' patch.
Regarding comment #41:
1. I can certainly add that, however, my thoughts on this are: If a list is
private I would have thought it was expected that other staff members couldn't
see/edit/delete it. Thereby making it justified that the Staff only permission
has not effect while the list is private.
What do you think?
2. Existing lists will have allow_change_from_staff = 0 due to that being the
default value of the new column -
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122535&action=diff
The use of both 0 and NULL in allow_change_from_staff also happens in
allow_change_from_others. This is what I observed when creating and adding
items to lists:
* When creating a public 'anyone seeing this list' list allow_change_from_staff
= NULL. When I add an item to the list then allow_change_from_staff = 0
* When creating a public 'staff only' list allow_change_from_others = NULL.
When I add an item to the list then allow_change_from_others = 0
Similar behaviour exists if you test on master too:
* Create a public 'owner only' list allow_change_from_others = NULL. When I add
an item to the list then allow_change_from_others = 0
3. Would you mind elaborating on if this is in the staff client and/or OPAC? I
haven't been able to replicate so not sure if I'm doing something wrong.
Putting this in 'Needs signoff', apologies if that's the incorrect status for
the bug report at this point!
Alex
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:58:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:58:03 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #28 from Marcel de Rooy ---
+ return $self
+ unless ( defined($options)
+ && ( $options->{less_than} || $options->{more_than} ) );
Would this raise questions if people only pass library or debit_type and get
much more than expected ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 13:59:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 11:59:39 +0000
Subject: [Koha-bugs] [Bug 28026] Add a 'call_recursive' method to
Koha::Plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28026
Mark Hofstetter changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |In Discussion
--- Comment #30 from Mark Hofstetter ---
sorry for the noise, moved the "proposal" to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28655
please don't hesitate to correct/nudge me to koha community standards as I am
new at commiting to this project
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:03:36 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:03:36 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #29 from Marcel de Rooy ---
+ my $group_by =
+ [ map { 'me.' . $_ } $self->_resultset->result_source->columns ];
+
+ my $attrs = {
+ join => 'accountlines',
+ group_by => $group_by,
You probably dont want to group by on all patron columns, heh ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:07:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:07:46 +0000
Subject: [Koha-bugs] [Bug 28653] Sorting loans by due date doesn't work
after renewing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28653
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
|ity.org |
--- Comment #1 from Emmi Takkinen ---
Created attachment 122543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122543&action=edit
Bug 28653: Add new method RefreshIssuesTable
On patrons check out or details page, after renewing
loans they don't sort correctly when clicking on "Date due"
tab. Page has to be reloaded so that sorting works.
This patch adds new method RefreshIssuesTable to
checkouts.js. When loans are renewed or checked in, issues
table is reloaded to and due dates are sorted correctly.
To test:
1. Add 3 loans for patron.
2. Change due dates so you they are e.g. 07/01, 07/02, 07/04
3. Make sure you have renewal period set e.g. 5 days and
check your RenewalPeriodBase syspref (I use current date there)
4. Renew loan with date due on 07/01, it should now be 07/07
5. Sort loans by date due
=> Note that order from top to bottom is 07/04->07/02->07/07
or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would
assume.
6. Apply patch and repeat.
=> Note that issues table is reloaded ("Loading..." pop-up is displayed)
and that due dates are in correct order.
Sponsored-by: Koha-Suomi Oy
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:08:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:08:11 +0000
Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set
borrowers.lastseen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:08:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:08:14 +0000
Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set
borrowers.lastseen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122490|0 |1
is obsolete| |
--- Comment #13 from Marcel de Rooy ---
Created attachment 122544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122544&action=edit
Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron
This patch adds a call to track_login_daily for the AuthenticatePatron
method in ILSDI.
Many libraries use this ILSDI endpoint for electron book borrowing and
need to maintain the lastseen based on this type of lending.
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:08:18 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:08:18 +0000
Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set
borrowers.lastseen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122491|0 |1
is obsolete| |
--- Comment #14 from Marcel de Rooy ---
Created attachment 122545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122545&action=edit
Bug 28630: Add unit tests
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:08:22 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:08:22 +0000
Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set
borrowers.lastseen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122492|0 |1
is obsolete| |
--- Comment #15 from Marcel de Rooy ---
Created attachment 122546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122546&action=edit
Bug 28630: (follow-up) Update wording of syspref
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:08:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:08:46 +0000
Subject: [Koha-bugs] [Bug 28630] ILSDI::AuthenticatePatron should set
borrowers.lastseen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28630
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:09:58 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:09:58 +0000
Subject: [Koha-bugs] [Bug 28388] Search result set is lost when viewing the
MARC plain view (opac-showmarc.pl)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28388
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:16:01 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:16:01 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
items where location is null
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:16:04 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:16:04 +0000
Subject: [Koha-bugs] [Bug 28472] UpdateItemLocationOnCheckin not updating
items where location is null
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28472
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122541|0 |1
is obsolete| |
--- Comment #3 from Andrew Fuerste-Henry ---
Created attachment 122547
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122547&action=edit
Bug 28472: handle items with NULL shelving location
The UpdateItemLocationOnCheckin System Preference can be set to update the
location of ALL items during check in, regardless of their shelving location.
However, this does not currently work 100% as it is excluding items with no
shelving location (i.e. value of NULL in the corresponding database field).
This patch, based on the comment made by Nick Clemens, fixes that.
Test plan (based on the original Bug Description by Andrew Fuerste-Henry):
1) Have a shelving location CART
2) In UpdateItemLocationOnCheckin, enter "_ALL_: CART" (without the quotes)
3) Check in an item that has a shelving location, confirm it changes to CART
4) Check in an item with a NULL shelving location, confirm it doesn't go to
CART
5) Apply this patch
6) Repeat step 4): this time the item should move to the CART shelving location
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:16:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:16:35 +0000
Subject: [Koha-bugs] [Bug 28573] Replace authority record with Z39.50/SRU
creates new authority record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573
Volkan Sonmez changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mvsonmez at gmail.com
Version|20.11 |21.05
--- Comment #2 from Volkan Sonmez ---
That is because authid parameter is missing in z3950_auth_search.tt. So
authorities.pl think that this is new authority file but not modification. if
you change
Import
line with
Import
in
cataloguing/z3950_auth_search.tt
file it will work.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:18:47 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:18:47 +0000
Subject: [Koha-bugs] [Bug 28399] batchRebuildItemsTables.pl error 'Already
in a transaction'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28399
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #4 from Marcel de Rooy ---
Last one:
$schema->txn_commit unless $test_parameter;
Would it be more appropriate/neat to rollback when testing here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:21:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:21:43 +0000
Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=28650
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #3 from Marcel de Rooy ---
Incidentally, stumbled over this one too this morning.
Bug 28650
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:21:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:21:43 +0000
Subject: [Koha-bugs] [Bug 28650] Assumed branchcode variable appears to be
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28650
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=28597
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:22:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:22:10 +0000
Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:22:45 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:22:45 +0000
Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
--- Comment #4 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #3)
> Incidentally, stumbled over this one too this morning.
> Bug 28650
And did the same thing on bug 27948 :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:22:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:22:50 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #21 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #20)
> Martin: Are you happy with the way this patch deals with the cancellation as
> to the accounts handling? Testing amountoutstanding and choosing
> line->cancel or account->add_credit? Balance wise, it works fine.
I think ->cancel is correct but cancelling has some caveats: some exceptions
will be thrown if (say) the line is already offsetted (partially/fully payed,
writen off, etc).
Those cases lead me to think ->void would suit better, but we need to (maybe)
think about possible refunds.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:23:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:23:30 +0000
Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:23:33 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:23:33 +0000
Subject: [Koha-bugs] [Bug 28597] Opac suggestions do not display news for
logged in branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28597
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122178|0 |1
is obsolete| |
--- Comment #5 from Marcel de Rooy ---
Created attachment 122548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122548&action=edit
Bug 28597: Fetch the logged in branchcode for OpacSuggestioninstructions
To test:
1 - Set two news items with location 'OpacSuggestioninstructions'
2 - One should be for all libraries
3 - One should be for a specific library
4 - Sign in to opac with user from the specific library
5 - Add a suggestion
6 - The instructions only show the all libraries item
7 - Apply patch
8 - Reload
9 - All libraries and specific library items are shown
10 - Allow anonymous suggestions: AnonSuggestions - Allow
11 - Sign out of opac
12 - Add a suggestion
13 - Only all librares news is visible
Signed-off-by: David Nind
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 14:28:41 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 12:28:41 +0000
Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron
categories configuration
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946
--- Comment #22 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #21)
> (In reply to Marcel de Rooy from comment #20)
> > Martin: Are you happy with the way this patch deals with the cancellation as
> > to the accounts handling? Testing amountoutstanding and choosing
> > line->cancel or account->add_credit? Balance wise, it works fine.
>
> I think ->cancel is correct but cancelling has some caveats: some exceptions
> will be thrown if (say) the line is already offsetted (partially/fully
> payed, writen off, etc).
>
> Those cases lead me to think ->void would suit better, but we need to
> (maybe) think about possible refunds.
Agustin compares amount with outstanding before calling cancel. So that should
be fine, I guess. It fixes the earlier problem reported.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:04:43 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:04:43 +0000
Subject: [Koha-bugs] [Bug 28479] TestBuilder.pm uses incorrect method for
checking if objects to be created exists
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28479
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:05:50 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:05:50 +0000
Subject: [Koha-bugs] [Bug 28545] Noisy uninitialized warn at
opac-MARCdetail.pl line 313
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28545
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:08:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:08:23 +0000
Subject: [Koha-bugs] [Bug 28582] Can't enqueue letter HASH(0x55edf1806850)
at /usr/share/koha/Koha/ArticleRequest.pm line 123.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28582
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |kyle at bywatersolutions.com
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:09:57 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:09:57 +0000
Subject: [Koha-bugs] [Bug 28423] JavaScript error on MARC modifications page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28423
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
CC| |kyle at bywatersolutions.com
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:10:44 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:10:44 +0000
Subject: [Koha-bugs] [Bug 28427] Terminology: Shelf should be list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28427
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:16:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:16:06 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:16:42 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:16:42 +0000
Subject: [Koha-bugs] [Bug 28462] TT tag on several lines break the
translator tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28462
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:17:51 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:17:51 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:18:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:18:55 +0000
Subject: [Koha-bugs] [Bug 26080] Use the task queue for the batch delete
records tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:03 +0000
Subject: [Koha-bugs] [Bug 23656] Add search box to top of page on
cataloguing/editor.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:10 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:10 +0000
Subject: [Koha-bugs] [Bug 27877] Accessibility: Staff Client - Reduce
heading redundancy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27877
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:16 +0000
Subject: [Koha-bugs] [Bug 28608] Creating a biblio record leads to item
creation even if framework has no items field
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:30 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:30 +0000
Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range,
keep zero padding
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:39 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:39 +0000
Subject: [Koha-bugs] [Bug 28196] In page anchors on additem.pl don't always
go to the right place
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28196
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:46 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:46 +0000
Subject: [Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra
leading zeroes are reported not found
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:19:53 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:19:53 +0000
Subject: [Koha-bugs] [Bug 28491] Field 003 in authority records not updated
after import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28491
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:20:03 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:20:03 +0000
Subject: [Koha-bugs] [Bug 26614] Diacritics taken into account in facet
sorting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26614
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:21:26 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:21:26 +0000
Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426
Eric Bégin changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|hakam.almotlak at inLibro.com |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:24:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:24:06 +0000
Subject: [Koha-bugs] [Bug 28522] Correct eslint errors in staff-global.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28522
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:25:55 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:25:55 +0000
Subject: [Koha-bugs] [Bug 28280] Item types configuration page doesn't use
Price filter for default replacement cost and processing fee
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28280
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #6 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:27:14 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:27:14 +0000
Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #7 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:27:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:27:20 +0000
Subject: [Koha-bugs] [Bug 28476] Update info in docs/teams.yaml file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28476
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:28:11 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:28:11 +0000
Subject: [Koha-bugs] [Bug 28428] Capitalization: Password Updated
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28428
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Pushed to master |Pushed to stable
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:28:16 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:28:16 +0000
Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid
fines/accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #30 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #25)
> I've love to get peoples thoughts on my alternative implimentation.. I've
> split out the relevant code I wrote for bug 11983 so we don't have to rely
> on that entire bug working it's way through.
>
> It still needs a couple more tests adding to prove the branchcode/debit_type
> refinement.
>
> I think it's really beneficial to be able to chain this.. I can see a really
> clear use case for needing to filter to those patrons visible to the user
> prior to using this function...?
I love your alternate patch. It is in line with what we've been promoting the
last couple years in the codebase.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:29:20 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:29:20 +0000
Subject: [Koha-bugs] [Bug 28443] Terminology: Issuing should be Checking out
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28443
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #5 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:37:23 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:37:23 +0000
Subject: [Koha-bugs] [Bug 27348] Error defining INDEXER_PARAMS in
/etc/default/koha-common
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
CC| |kyle at bywatersolutions.com
--- Comment #13 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:38:31 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:38:31 +0000
Subject: [Koha-bugs] [Bug 12169] Improve reliability of sip_shutdown script
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12169
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--- Comment #17 from Kyle M Hall ---
Enhancement not backported to 21.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:39:35 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:39:35 +0000
Subject: [Koha-bugs] [Bug 26860] Add search limit for records without items
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26860
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
CC| |kyle at bywatersolutions.com
Resolution|--- |FIXED
--- Comment #19 from Kyle M Hall ---
Enhancment not backported to 21.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:40:15 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:40:15 +0000
Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register
statistics wizard report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:41:13 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:41:13 +0000
Subject: [Koha-bugs] [Bug 28264] Transaction type is empty in cash register
statistics wizard report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.02
released in| |
Status|Pushed to master |Pushed to stable
--- Comment #7 from Kyle M Hall ---
Pushed to 21.05.x for 21.05.02
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:42:05 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:42:05 +0000
Subject: [Koha-bugs] [Bug 28514] C4::Letters::getletter must be rewritten
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Resolution|--- |FIXED
Status|Pushed to master |RESOLVED
--- Comment #24 from Kyle M Hall ---
Enhancement not backported to 21.05.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:42:06 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:42:06 +0000
Subject: [Koha-bugs] [Bug 15449] Move stuff to the Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
Bug 15449 depends on bug 28514, which changed state.
Bug 28514 Summary: C4::Letters::getletter must be rewritten
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Jul 2 15:42:38 2021
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Jul 2021 13:42:38 +0000
Subject: [Koha-bugs] [Bug 15788] Split borrowers permission into create/edit
and delete
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15788
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Status|Pushed to master |RESOLVED
Resolution|--- |FIXED
--- Comment #23 from Kyle M Hall