[Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #48 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #40 and comment #41)

Hi Marcel,

Thank you for QAing!

- Comments #31, #32, #35, #36, #37, #38 (which was an accident- apologies!)
should hopefully be addressed by the 'Bug 26346: (follow-up) Fixes in response
to QA' patch.

- Comment #34 should hopefully have been addressed by my splitting the database
change + DBIx change from the 'Bug 26346: Add option to make public lists
editable by all staff' patch out into two separate patches.
Note: The change to Letter.pm you noted in comment #34 was also incorrectly
committed and is not in the new 'Bug 26346: Updated schema file' patch.

Regarding comment #41:

1. I can certainly add that, however, my thoughts on this are: If a list is
private I would have thought it was expected that other staff members couldn't
see/edit/delete it. Thereby making it justified that the Staff only permission
has not effect while the list is private.

What do you think?

2. Existing lists will have allow_change_from_staff = 0 due to that being the
default value of the new column -
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122535&action=diff

The use of both 0 and NULL in allow_change_from_staff also happens in
allow_change_from_others. This is what I observed when creating and adding
items to lists:

* When creating a public 'anyone seeing this list' list allow_change_from_staff
= NULL. When I add an item to the list then allow_change_from_staff = 0

* When creating a public 'staff only' list allow_change_from_others = NULL.
When I add an item to the list then allow_change_from_others = 0

Similar behaviour exists if you test on master too:

* Create a public 'owner only' list allow_change_from_others = NULL. When I add
an item to the list then allow_change_from_others = 0

3. Would you mind elaborating on if this is in the staff client and/or OPAC? I
haven't been able to replicate so not sure if I'm doing something wrong.

Putting this in 'Needs signoff', apologies if that's the incorrect status for
the bug report at this point!

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.