[Koha-bugs] [Bug 28622] Selected branchcode not passed to adv search?

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28622

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122467|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 122598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122598&action=edit
Bug 28622: (bug 15758 follow-up) Remove incorrect branch selection in adv
search

From
  commit df97814f3034a3d5015546c4eca21f08ae951e37
  Bug 15758: Koha::Libraries - Remove GetBranches

+    selected_branchcode => ( C4::Context->IsSuperLibrarian ?
C4::Context->userenv : '' ),

And

-        [% PROCESS options_for_libraries libraries => Branches.all() %]
+        [%# FIXME Should not we filter the libraries displayed? %]
+        [% PROCESS options_for_libraries libraries => Branches.all( selected
=> selected_branchcode, unfiltered => 1 ) %]

The change in the pl is wrong as it should pass C4::Context->userenv->{branch},
but prior to this commit it seems that we didn't select the logged in
library anyway.

Looks like we should remove this code but preserve the current behavior and
select "All libraries".

-- 
You are receiving this mail because:
You are watching all bug changes.