[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078

--- Comment #84 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Victor Grousset/tuxayo from comment #75)
>     description => [qw(Multi lines description)],
> 
> It's multiline and it doesn't matter that we actually use it, just having
> this syntax work is enough right? 
> 
> 
>     description => ["Testing", "multi lines", " failure"],
>     up => sub {
>         my $dbh = C4::Context->dbh;
>         $dbh->do(q{ALTER TABLE Foo});
>     },
> 
> Is that useful have another test for this multi line case but successful?
> 
> Should we have a failing test for this syntax?
> qw(Multi lines description)
> 
> > - Make sure the different use cases are covered
> 
> Seems good but quite over my head.

I don't understand what you mean exactly.
The description can return a scalar (one line description) or an arrayref
(multi lines description).
[qw(Multi lines description)] is similar to ["Multi", "lines", " description"],
if it it what disturb you.

(In reply to Victor Grousset/tuxayo from comment #76)
> I get the following conflict when applying the rest of patches after «- Make
> sure the different use cases are covered»
> 
> <<<<<<< HEAD  ---- this is the code after applying «DB revs for testing»
> $VERSION = "21.06.00.100";
> ||||||| constructed merge base
> $VERSION = "21.06.00.004";   --- code in master before the patch that I'm
> applying
> =======
> $VERSION = "21.06.00.005";   --- code from the patch that I'm applying
> >>>>>>> Bug 25078: Put db revs into different files to handle them better
> 
> I should keep 21.06.00.100 right?
> But I'm confused that «Put db revs into different [...]» changes the version.

I rebased the patch, adjusted the commit messages and added a new patch to move
the 5 last db revs.

-- 
You are receiving this mail because:
You are watching all bug changes.