[Koha-bugs] [Bug 27696] Allow choice between ISSUESLIP and ISSUEQSLIP when printing a SCO receipt

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`,
`type` ) VALUES
[...]
+('SCOSlipChoice' , '0', 'issueqlsip', 'issueqslip|issueslip', 'Allow choice
for SCO receipt print',  'Choice' ),
The fields do not match!
Value 0 is not correct. The options are not correct too etc.
Please make sure that the former default == qslip is inserted.

Note that it is confusing too that the sco script tests for qslip and our
values are issueslip and issueqslip.
sco script contains:
if (my $letter = IssueSlip ($session->param('branch') || $branch,
$borrowernumber, $print eq "qslip")) {
We even have wrong calls in a test like:
t/db_dependent/Members/IssueSlip.t:        $slip = IssueSlip( $branchcode,
$borrowernumber, 'quickslip' );
I would recommend to correct that too.

-- 
You are receiving this mail because:
You are watching all bug changes.