[Koha-bugs] [Bug 28567] Pick-up location is not saved correctly when creating a new library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28567

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #3)
> This is (very?) bad.
> 
> When a new library is created, all the non-filled (empty string) fields that
> are "text" at DB level will be set to NULL.
> BUT after they are edited, they are set to an empty string.

Not sure if this is very bad btw. It is inconsistent, yes.
This report is doing two separate things?

+                        $_ eq 'pickup_location' # Don't fallback to
undef/NULL, default is 1 in DB
+                          ? ( $_ => scalar $input->param($_) )
+                          : ( $_ => scalar $input->param($_) || undef )

This kind of construction in scripts like admin/branches will make our life not
easier? Should this be a change done by the store sub of Library instead ?
Note that if we adjust a library somewhere else too we now need to duplicate
these lines again.
And we could test it ?

-- 
You are receiving this mail because:
You are watching all bug changes.