[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #150 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Why Koha::Item->item_orders is not named Koha::Item->orders?
It returns a Koha::Acquisition::Orders.

2.
in move_to_biblio
1215     return unless $self->biblionumber != $to_biblio->biblionumber; 
I am a fan of unless, not when there is a negation in the test :)
         return if $self->biblionumber == $to_biblio->biblionumber; 
Read much better IMO.

3. There is Koha::Item->move_to_biblio($biblio) and
Koha::Biblio->adopt_items_from_biblio($biblio)
Don't you think Koha::Biblio->adopt_items_from_biblio could be
Koha::Items->move_to_biblio actually?
It would be more consistent and flexible.

4. 
in move_to_biblio you are calling, on a DBIC rs, ->update, then update_all:
1237         $hold_fill_target->update({ biblionumber => $to_biblionumber });   

1254     $linktrackers->update_all({ biblionumber => $to_biblionumber });

It's not consistent, is there a good reason for that?

Please provide a fast reply, I can write the follow-up patches if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.