[Koha-bugs] [Bug 22690] Merging records with many items too slow (Elasticsearch)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #153 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #152)
> (In reply to Jonathan Druart from comment #150)
> > 4. 
> > in move_to_biblio you are calling, on a DBIC rs, ->update, then update_all:
> > 1237         $hold_fill_target->update({ biblionumber => $to_biblionumber
> > });                            
> > 
> > 1254     $linktrackers->update_all({ biblionumber => $to_biblionumber });
> > 
> > It's not consistent, is there a good reason for that?
> > 
> > Please provide a fast reply, I can write the follow-up patches if needed.
> 
> I think this is simply because we didn't have a Koha:: based resultset yet
> and he didn't want to add further complexity to the patch by adding that new
> class as well.  Having said that, it's fairly trivial to add such a class so
> long as it's a basic one, so perhaps we should for consistency.

Both are "raw" DBIC resultsets :)

-- 
You are receiving this mail because:
You are watching all bug changes.