[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 20 22:29:46 CEST 2021


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #63)
> Ok, rebased after the EXPORT bug was pushed.
> 
> Letters now will use the new holds table. See the TODO.
> 
> There are still bugs you will notice if you run:
> 
> git diff origin/master --name-only | grep -e '\.t$' | xargs prove
> 
> Help is welcome, but things look much better. A lot has changed recently!
> 
> TODO:
> - t/db_dependent/Reserves.t failure
> - t/db_dependent/Circulation.t failure
> - Add some warning in about.pl about wrong letters (maybe?)

Another TODO: rewrite C4::HoldsQueue in terms of the 'holds' table. It felt
like  just translating into the new table columns was the same amount of work
as moving it into using Koha::Holds directly, and more thought is needed as
there are a bunch of possible optimizations that could be made in the area.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list