[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #66 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Hi, just letting know that I'm investigating the «No reserves HOLD letter
transported by print» warning/error. Just the message, not the failure of the
test.(maybe linked, I didn't looked at all)

So this is weird, it finds a template for
- reserves&HOLD&email
- reserves&HOLD&sms

but not for reserves&HOLD&print

When the letter table contains only
- reserves&HOLD&email
- reserves&HOLD&print

So it shouldn't for sms but should for print

The same query (from Notice/Templates.pm PoV) on the previous test 


The warning/error comes from
"Itemnumber should not be removed when the waiting status is revert"
"Itemnumber should be set on hold confirmation"

More precisely the ModReserveAffect() call before the assertion of the above
tests.


After `cpanm DBIx::QueryLog` adding `DBIx::QueryLog` before the call to the
ORM.
I can see that the params are correct. The query is:
SELECT COUNT( * ) FROM `letter` `me` WHERE ( ( ( `branchcode` = 'Rvfd7OyOU8' OR
`branchcode` = '' ) AND `code` = 'HOLD' AND `lang` = 'default' AND
`message_transport_type` = 'print' AND `module` = 'reserves' ) );

Which yields 1 when ran in mariadb client. (right after interupting the tests
with die: after ModReserveAffect() )

But when using dbh() with the same query right before and after the DBIx one is
done (there are two ->count calls). Is yields 0.

That's what I've found so far.

-- 
You are receiving this mail because:
You are watching all bug changes.