[Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266

--- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Martin Renvoize from comment #17)
> Comment on attachment 123026 [details] [review]
> Bug 27266: Move GetMarcAuthors to Koha namespace
> 
> Review of attachment 123026 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Biblio.pm
> @@ +870,5 @@
> > +    # tagslib useful only for UNIMARC author responsibilities
> > +    my $tagslib;
> > +    if ( $marcflavour eq "UNIMARC" ) {
> > +        # FIXME : we don't have the framework available, we take the default framework. May be buggy on some setups, will be usually correct.
> > +        $tagslib = C4::Biblio::GetMarcStructure( 1, '', { unsafe => 1 });
> 
> I wonder if we aught to fix the FIXME here?
> 
> $tagslib = C4::Biblio::GetMarcStructure( 1, $self->frameworkcode, { unsafe
> => 1 });

True, may as well. Follow-up on it's way.

-- 
You are receiving this mail because:
You are watching all bug changes.